From patchwork Tue Jun 10 12:35:35 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 896412 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D569B29B79E for ; Tue, 10 Jun 2025 12:35:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749558954; cv=none; b=pDJtcWzwJx/iOyWnAzJgatOw/lM4L0ydbldu335kDu/F1OB/h97aF8FJV+aNHw9kBvg5KTFp2ekVwU+5nx7GAYBD7u+qwQf95tY+0NIzOp6llBDNNvUUcFDVyHMnfRzyUvzvIIr9jXHyXqfJPKlfoagcIoO6wiJtydayLMNqM6g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749558954; c=relaxed/simple; bh=b/qgu6/medib2vu4jNB/RyGMXO6WslAvUTV0AIziuY8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=DjSakJqdMrkzX2QwbO3+hgkExJYq3r+gzn7O8UFXgqhhCYFmeoh7qPCeqREP61bpXkjb5fZ8S5gmDEfGdb2NFtn0jPc0EiYatr1OtTlx+YOHnWH0FDk5mIcVuJ5zC5GIhWfGZ8mAR9+MolFASgpvwseVst6dQ0vF37Tuame9ABQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=q/vSNbtD; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="q/vSNbtD" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-453066fad06so19288145e9.2 for ; Tue, 10 Jun 2025 05:35:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1749558951; x=1750163751; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=WTP8xNB64zIn9DIEvp87doAXF5a/sVMPLzzHk43KYWg=; b=q/vSNbtDoMtnidndBvJ9EcvBrPD7JPIiP0R/+Qm+KvfBqcaO45IFoTCIdTSlV2vixk POHDZaxGLHawhrHBs/hGgMotZSBOaoMn9aXF8zvbhlR8ZHKHy82q2tjObecRMrX/A4/8 2tUOflXv0E7wHJI1RBZLhPVCIhf06guJCw99K7ZrTkmz6vkmUmgKi4qSRgcm9hO/lVIG BQVKamX8qNtB+GR5aM4gI01lsJWybw5XGusagV9BjjxkmiOJgRJYZPkvgBSD6/82Niz1 IDAN1eDSh4/enckCiUP8ND2UpvJ0ncmLhMRsyxR3Ubu6tg9nADc1QyBnk5ZYNedXtS7W c/sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749558951; x=1750163751; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WTP8xNB64zIn9DIEvp87doAXF5a/sVMPLzzHk43KYWg=; b=tRvlLBhnik6ARNUwqbKW7ShRwRw9gVH/F1akeALTouXEh6AimjUfrfg7X1Fpq3Z/HR KBRXRDQeKlzjctITZfAUtZ7yK0zMs+SaoJlY8JWY6dAvD33MTJzpvXea0zSRCdHzpyPU L6+RvfFJRypmL7V6yxvkMdeooA87Tf5vLCU/0AvsO+lMQ6NbDKu3/5boXmbo52kKMHw0 90ry1eAOAe1fEZuVMBb7SMM+zcu/PWr4Xa17MqlGJvOiG45ie8aJTNQ1pvFoy78Ra3K1 bQy1EuDgPp5w2VXFgoec/HcBXw3GjHA+rgHDdO7WGX9BottVplpLuLt+I/uVyWxRcZ5Z /2/g== X-Forwarded-Encrypted: i=1; AJvYcCVdiW2wkv4Iy+M3OjSFUelmr9UrLZ0r/jYCQbFoSfZ3R0MCIuFnUL9KSzvfnWFBIA5sA1YS6rT58h2+@vger.kernel.org X-Gm-Message-State: AOJu0YyaO3G8SoxlqviFyhoh1srJBGjpRxGCY57sqD/ct8CbB9124SFv Tz71b8ctMNsIspPvsahI91j/20lKhaLB8mIcHQyMO8XaDAVDSZObK/gDM7l6k8EaABE= X-Gm-Gg: ASbGncsAT4SrwbJaU6wGUqsOFA95bVP+M7/rtXaTJfnK/lVCGEbNcsXMI8tjs5uKGqt fU5ntpwDrxghzKoveFvNfO+AYaN614Sd22mWwHHlMlfCuMu8DvSw5+exhdnOxtZNyOFUnP6UHeQ saTAGkLbtQJ5GxqEQ57KZzZS6DwYMKZ91XmLlpI3ueEjdX9mGJXSG8C2/5CUO/0OpPn1Zry8oRr R9j721+eFRa96TFCUjCvVa1zvdFGrg4iCQ6eoVOWX/NrrTxW3u+WkCm/iH29oc3YAlYdb/c9H/O XOrJcT/sbAfMmb1zx+C1wS7n+oBmy9B8PgEFi631io4VZtvQ9IfSpw== X-Google-Smtp-Source: AGHT+IF4fMlBmPwe1cVJuSXY6WUkMp0q4kctxB4GQTZMFXpPE8OUFwtZ+6mpAu1TMgIrNn8JwGBmkQ== X-Received: by 2002:a05:6000:2305:b0:3a4:f722:f00b with SMTP id ffacd0b85a97d-3a53188a524mr14037191f8f.11.1749558951215; Tue, 10 Jun 2025 05:35:51 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:4d:e52b:812d:eb7c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45307b4788fsm91008455e9.21.2025.06.10.05.35.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jun 2025 05:35:46 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 10 Jun 2025 14:35:35 +0200 Subject: [PATCH 1/7] media: dvb-frontends/cxd2820r: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250610-gpiochip-set-rv-media-v1-1-c088006a152c@linaro.org> References: <20250610-gpiochip-set-rv-media-v1-0-c088006a152c@linaro.org> In-Reply-To: <20250610-gpiochip-set-rv-media-v1-0-c088006a152c@linaro.org> To: Mauro Carvalho Chehab , Linus Walleij , Bartosz Golaszewski , Bluecherry Maintainers , Andrey Utkin , Ismael Luceno , Tomi Valkeinen , Julien Massot , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?utf-8?q?Ni?= =?utf-8?q?klas_S=C3=B6derlund?= Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1778; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=N9OvQ6idGerlmLwTIQS5N5xpWnMU9Eqb+M235W9W9/w=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoSCadiry5Z7JL5xwZjSPC11k6EgWL2TOKgkhdY j0swRBUDq+JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaEgmnQAKCRARpy6gFHHX ck8BEACxqkDlf8kbHZuhC8igQTVWc3VFpeTklJvF/zMHrXyDjVj/KGl93oIuIXc65lu1wF+rDTQ 8FylS3owNdW5LV0g06lDUd82gYVO17rc10SJ/dSHyuvxqxTAjz8cHw39FXqp2Hp5VIp9hlAqEuG YaCmOZ67iRC6o6SPm2VKjcBO9exulpA2Hf67ta56lPOISfp4yHNMoV3f2Vuvw5p456WC7ZWwJjS elJ4UkA4znmUFh+6EpUyaWLGfYo2GnJiIKlDV945J9gob5zIBH+Wd/LbV4koZAppfAnkBEL29S8 bLhYQzLjeuWdBD9k5xd62JZMcqQAL218ThOnr8KUSWKVycedhzijTuIfqQ7Xw1RHv6v4F7TuWIr 9QbbYsHlzm/wXHF3wgBoo6FjSZouLWF0Twr9SUHvE9+i74vkH4HfDxYRMqEF/2gBnkJXSGmuaFh DcmcPcApcQjpqSONIeMAYfeLXJBQc7pax5fyAVwRL7qtl9878G2Z9FdunTE19X+oYedMtquOwoG Ui2PlfLV7zO4+JS6nFz9IbwsbO7LDdY4ThbI6I58ZfoIxR399m75EZq5UioRMq1AM7psC1jGT4H oRU2Y1ekbOWIfhaxy6etGPahcmVYSnphAlRbHfsZg6aNO6yXjFtxSTGChyKSc6pz5SrcBH/53YS kY5tL6sgOSlGs1Q== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/media/dvb-frontends/cxd2820r_core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/dvb-frontends/cxd2820r_core.c b/drivers/media/dvb-frontends/cxd2820r_core.c index c3d8ced6c3baa6608e17cc4797dbeddc5a5ed510..a31a8a6a494652e6aae874c399fc70df3f9ee172 100644 --- a/drivers/media/dvb-frontends/cxd2820r_core.c +++ b/drivers/media/dvb-frontends/cxd2820r_core.c @@ -433,7 +433,7 @@ static int cxd2820r_gpio_direction_output(struct gpio_chip *chip, unsigned nr, return cxd2820r_gpio(&priv->fe, gpio); } -static void cxd2820r_gpio_set(struct gpio_chip *chip, unsigned nr, int val) +static int cxd2820r_gpio_set(struct gpio_chip *chip, unsigned int nr, int val) { struct cxd2820r_priv *priv = gpiochip_get_data(chip); struct i2c_client *client = priv->client[0]; @@ -446,7 +446,7 @@ static void cxd2820r_gpio_set(struct gpio_chip *chip, unsigned nr, int val) (void) cxd2820r_gpio(&priv->fe, gpio); - return; + return 0; } static int cxd2820r_gpio_get(struct gpio_chip *chip, unsigned nr) @@ -651,7 +651,7 @@ static int cxd2820r_probe(struct i2c_client *client) priv->gpio_chip.parent = &client->dev; priv->gpio_chip.owner = THIS_MODULE; priv->gpio_chip.direction_output = cxd2820r_gpio_direction_output; - priv->gpio_chip.set = cxd2820r_gpio_set; + priv->gpio_chip.set_rv = cxd2820r_gpio_set; priv->gpio_chip.get = cxd2820r_gpio_get; priv->gpio_chip.base = -1; /* Dynamic allocation */ priv->gpio_chip.ngpio = GPIO_COUNT; From patchwork Tue Jun 10 12:35:36 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 895376 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC04229B8DC for ; Tue, 10 Jun 2025 12:35:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749558958; cv=none; b=SpCXzkPRorX5XCDU+UpPTzr5/FMugMvEez+6rnOs17ZeeVhmGDommDpjxbkR/yxXWOCvT5oCdHn/79n4Rl1bzNBM3+8RvRLhFopY2Tk1a9UOFg1Ib4I2IOp3xvWEWHxDlqEg10oh7thXCAYpHowYzmaWTlOlP09x0lWIDsuBYIo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749558958; c=relaxed/simple; bh=vBIY6MDSAZqxd0wvprVpXG2GeCT/g5H/eGKWlDdO1xw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=IkwyqtWNUbCzj/ziAkDDNzIZpKpggQ0ygqBIQ0YAXO377bVO30Omx/Dfe1DnMxRzR3Cn4Dz8ImXbQ73v420ty//xY45z0FuOol4ZCAmrwIjz3HmZ8nCvwikyJnw+CPYtTONH83XKBBIYUYHuGQoShV791r00VO6oa0kDTtyKH4U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=YCG07UCv; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="YCG07UCv" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-43ea40a6e98so67955185e9.1 for ; Tue, 10 Jun 2025 05:35:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1749558954; x=1750163754; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=XFQEt0BhzwG4HODHfj1luH5UGQeZf6dSsvCSdYpA/bw=; b=YCG07UCvViyuBYYJYdpKsLd6qgRjrY4YcFzIEbiz7y7oPspJbCdOaP5ddQbsBZ4qHD 3cGOOUZphhmrh7KZ0LhlonEUsz/cMlMqkt0Xn+XZFBQqXZl1kdiwP3HA0AURoCSvx6XH Ob9OJ6kQFAQoJNdGf717C/dGuLcaC9zGX9iF/ACqA1vt0G2mg7ltKQLD5k2Gb02IUxov Hf59VLVKOW1luqFBa/T20stPmIV+7xcznvwX/FfLAP808rxdEV2qJTfA40vxkB3o2p23 poIFLObmHn37nmESfAexk4s5fZult53wJTlRkosEpEP+9KqqfeXYyPaYwnoZ5o0npvjm BrlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749558954; x=1750163754; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XFQEt0BhzwG4HODHfj1luH5UGQeZf6dSsvCSdYpA/bw=; b=BG4CVq5UpZPuACznqEEb8hjVM+7CdqVC2gK1rvIDhBsSkzkvvJqNBmTlvOoa6KVhql Oet0RRvD3CCRYLjMRiSVCXtynnXEKyxpgzZGh1MYUoKT1B9q+8N5ycnPIfUs6VY0BFg/ PHYP8SNYVsN2aSSkaR6EzYSupupxKIPpjat+vcNsqT/3rwHujX+TDpMo1Uj4gD1wcYGn pyUzp5rpVtmEqO1tZKpSMBM3jgm7DSPuD4PQ4rLTdNPwL/PO01V508riufjqfbNiAmXZ OKb6qiNBn46o/lPk3Vkl0J9NeQqoXpZ6IQCk6cuI8xcYEp0rDlDrzb5t4cqUC41h/Crg j2Qg== X-Forwarded-Encrypted: i=1; AJvYcCW7JL+ILQksBfnLuQQs1AgNgy56iU+r9sgGukcglIXWAM5Dtlm9d+Yjz2uYw5j1MBramTZU2uQ5MwhP@vger.kernel.org X-Gm-Message-State: AOJu0YzT0dYgxkjq7Mj5XJXNPfOcdhPjTyyLivEd0o/vjwR0eGTtdV67 ya8tl+Lek8zKL/QpSrZMIP3NO2ec14K0ux2wZf6tt/5X/JGhyYmd2JQ0qW2YIA1Heeg= X-Gm-Gg: ASbGncs0n/Kgm05hGCiJ9RdzFlTkWF/wG8PS0gUMqksNreG8aox8Ws5THCOilrigtbC b2FNrFHPahqhzn51EVTfRauRLzSG5vPVMeJ6Aq2HkFWIgrzuYLDb72Q85tz+wx2Y204SIb0/ikP 0SSCtLPBQtN5d1fyQLbTFpaNIVWjhynBMTOTgc6eiy3dwDl+74GnmYZ73K2rLvDao6vX02JhJK1 SsAmB4WG4SeA7krj4Bxk2ndu/dZR6OQphGRCZfO/eT8CSGBSFq4WxFc2/AfmFAUs4R/n0i7BcYG r3iynUuJbWYN6416q3rm/QjPwp4WzyGp/ecP3m5V75NPn//bNu+v8qV7EbcfJnKE X-Google-Smtp-Source: AGHT+IGeLm6Stn6qwmhFlxY6yRUd1ZWHS+JmYdkbaMswqAFFouRLMnPi65wETwm0g9P1taELNYxEnQ== X-Received: by 2002:a05:600c:4e41:b0:450:d012:df7a with SMTP id 5b1f17b1804b1-4531de914bcmr20613935e9.28.1749558954024; Tue, 10 Jun 2025 05:35:54 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:4d:e52b:812d:eb7c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45307b4788fsm91008455e9.21.2025.06.10.05.35.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jun 2025 05:35:51 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 10 Jun 2025 14:35:36 +0200 Subject: [PATCH 2/7] media: solo6x10: remove unneeded GPIO direction setters Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250610-gpiochip-set-rv-media-v1-2-c088006a152c@linaro.org> References: <20250610-gpiochip-set-rv-media-v1-0-c088006a152c@linaro.org> In-Reply-To: <20250610-gpiochip-set-rv-media-v1-0-c088006a152c@linaro.org> To: Mauro Carvalho Chehab , Linus Walleij , Bartosz Golaszewski , Bluecherry Maintainers , Andrey Utkin , Ismael Luceno , Tomi Valkeinen , Julien Massot , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?utf-8?q?Ni?= =?utf-8?q?klas_S=C3=B6derlund?= Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1660; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=3e0iLtDRWFqoc+uvXxn0R7qOqIkpeyOfEDZD1yz0l28=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoSCad0uJuLemvk7d60Go2/A881xsjcQG2ox29Z GFRhSm6V9OJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaEgmnQAKCRARpy6gFHHX cpxuD/9O2VIBYw/wCZEMw9n47f3PrD4xcBr4nPWgGrIHy09M6wa/1OJdgKzPDnEbEt85UfiTD2M /GwSqgss74CkSEMJHxPlmAhP4xLCapXkVUe8qNxArgtobkWzZ9aFfamY+omdojX7h8xlDSG35Vj 3tIrgZWAADV53CDmEsg2z7L9sIE2RhSv/2IK6ltE93kF2B31Ye6DQf7hZw2W0pvIYps/w+ChxMK Zls4mabX4FBPHubUNorzbFOftqdzWFm1J5CsRPzVMvMmiH1tzevpciIRLT6vXQhYdyD2hZecdUc MqVwGNlSBwshVSqkM246jD4/piYQzT9Cq498QyjnuMlt5a/ZD3ODQyMPfTDKweAOybN6NBAA1m5 ob1bJC2SZkkMkJ9Sg3XgqhabVoonOocwqHv+lSm46b5d97+/RskrNbakpuh1ut87dSBu2XSs/iy jBbXrfhsBmIB7EnrZJqiiaea632or+hXDEbdYAdTaCQv/+UhFjyVYSmOM0Xw1xYMrWj/+adX3Ze tmLVLD6rTGaJC98SPOjkB5kmjrQCa1CoS9kpEKx2E8g6loZyI2da9uGEFpAirlx8TmTnpBm7bkl +6MEmKOoApckOiwzXcWm9W3Gscq3pHunjWTki74Sfs5+R8TLzGIOBGvWHMDLe4kB7I3JzmWVVa5 ubQ0FkFfH8sL17w== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski GPIO core already handles missing direction_input/output() callbacks. The ones in this driver also effectively return magic numbers which is not optimal either (the number accidentally corresponds with -EPERM which is different from the number GPIOLIB returns and so inconsistent). Just remove them. Signed-off-by: Bartosz Golaszewski --- drivers/media/pci/solo6x10/solo6x10-gpio.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/drivers/media/pci/solo6x10/solo6x10-gpio.c b/drivers/media/pci/solo6x10/solo6x10-gpio.c index 084c30760e459e37cd1800132a93dfb0fc70398e..f51f865c69bd7b04fac7a1f951c734965d8fc993 100644 --- a/drivers/media/pci/solo6x10/solo6x10-gpio.c +++ b/drivers/media/pci/solo6x10/solo6x10-gpio.c @@ -116,18 +116,6 @@ static int solo_gpiochip_get_direction(struct gpio_chip *chip, return -1; } -static int solo_gpiochip_direction_input(struct gpio_chip *chip, - unsigned int offset) -{ - return -1; -} - -static int solo_gpiochip_direction_output(struct gpio_chip *chip, - unsigned int offset, int value) -{ - return -1; -} - static int solo_gpiochip_get(struct gpio_chip *chip, unsigned int offset) { @@ -167,8 +155,6 @@ int solo_gpio_init(struct solo_dev *solo_dev) solo_dev->gpio_dev.can_sleep = 0; solo_dev->gpio_dev.get_direction = solo_gpiochip_get_direction; - solo_dev->gpio_dev.direction_input = solo_gpiochip_direction_input; - solo_dev->gpio_dev.direction_output = solo_gpiochip_direction_output; solo_dev->gpio_dev.get = solo_gpiochip_get; solo_dev->gpio_dev.set = solo_gpiochip_set; From patchwork Tue Jun 10 12:35:37 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 896411 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC06729B8E2 for ; Tue, 10 Jun 2025 12:35:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749558961; cv=none; b=B93/tieZdhipNZNUJJwquY3hnT3SItOP0nd/Bo7hQwAGF4Zu5NYZNQpaJn+0tmFhcwLuZn2E5u3vqXyi8auAZdS2FEBSnUs/LdMPCd+uMt1M++TRbpy+xo2+qz2J4kHKyBnvFTWxJSeJsx1lKQqG711xzGuY3YoHRUZNfC5mx6k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749558961; c=relaxed/simple; bh=/mdAoFgifrGqKEEyhtg6uTaMhvs2r5wvt9hHVXqUsuI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gEdxTkGJthKvpqZEATLetJIOF2GkmBHnNK3pgR+YRb1TnkpE2nAlD3LnDpYUqbC8OTcsQKtQ9bj1bQShVYaP/V6bQNU9Rp4WKJMaBp3ZeRbZzKye5ZLNHxJpmZQfOQDKHCidnDLfrX2YaGj5o7V9XGmOFvpTz2N/i+ZLxM7sGXg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=zOLyH1Ta; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="zOLyH1Ta" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-453066fad06so19288995e9.2 for ; Tue, 10 Jun 2025 05:35:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1749558958; x=1750163758; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=uiLT6wBQ650bzMQiyRtp5HseVhCkXjDZMFQECvgUq8g=; b=zOLyH1TagnK0tAeBjC28pcb2Cfx85s+gKA8rAR9e2vj3mnCkDuF5Dc09jHrqHqYlYV L9U7tlC2iI6Z5xNZsrvvJt7vReUac3gWPDxQMqW5UMOgtlZLKOkdDcVhGek+xIPpBPgz FI/Z7UKob/nmjIi4hAhiqUG3SFQ6+QoiLbk+3Uzlc2jxe0GBZF3tTW9TleyQYqdbTQP+ fee4o7rTpRjMPGyaJQs1mBZdtQDPD8qmY4QFhghhjZescWocnUhgN0K7UbwdV6IHhvEp fBRXdQOefBWKbpf0zvCJV8gavWbJdOTMjqlyDqdbZhxkjKZ3jXpevarj9RUVSz963gpg AUkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749558958; x=1750163758; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uiLT6wBQ650bzMQiyRtp5HseVhCkXjDZMFQECvgUq8g=; b=lbGuTcBzKa9Y9wQaX0SQ4CYycgZbcaTWRoo8Wz53JpxlQWuJ4BYa6L6u1mRhjesIjs jzvXoNUOziM9C/sjhQBr1rDYgd2JXtzZwSFvTt5w3r5W9AXCL8dvffGuzftEIsH+A7u4 0lEM/m74ZW/VmbeuCr/u22DVmjAgN7gYXrMi0Y/I1PTCSkMi2efUw4WQCwLG7vk8cDsC LTckIilDpH/OO4oyhl4aRBAdvQmOGpPq9F5eCMZQzh8nUKC5Mb8dLwYW/Pn/lzpiqjmL vzr7MXcBfyqas14IdNP3rdaMIFSX7MreSi8HCgy/PWEjb8zbXmuf2ZPuP/MreVpvzhfp 5Xsw== X-Forwarded-Encrypted: i=1; AJvYcCV8NHZyuWFPeMSg2kW3n4DrRl6HRdyGQNafImCZrKojzMW/5GKZJbyM32HYo4viYogqvKjLd4URxSAY@vger.kernel.org X-Gm-Message-State: AOJu0YwLWpEpaEdGS/pVF0uY1ETKQRy75BUpbXsJ7sXdGlTMy2wzqmiy z6mfB5g8KyZPVRY7YvXRqkl4Mz1jDX/k3GnauP2Px1DkZG1iHrVOrJVlmcljtnVY17o= X-Gm-Gg: ASbGncvLYYwmIDT1k4UdUrgMuZM058Q7V2W++V1LZ+QuoGMooH50w90r7ZrZvijcUpQ S44VTLU4kKUhFcnFfKoyAhd3UQpMrqT5qAgau2i9/MDs2ZgbqLoJ/j1RosxF6OoG1MF4pmGnWBf zoz2U0VboZRXGeO3QlCzEEYEhEDSlebK0KBZVU02PR7/sialgW2lspn7YaCn80E+dD0E+fVhM2p wC0OnAhdILCLPkq7EdMFgsyujQ0skU/QgFDaLqNrheQaVDRO31WDfyoMMHjIItkHpZZoALs5Zyt r46xhnK1+cOed+JNZsqWJ8hzfYfx7FwK6ZRmwfWK9ihTFQ1R8wWGRQ== X-Google-Smtp-Source: AGHT+IGoSNhkQQUc8dbsTa39caQaeUFBSNvNDoCuunqJlyIF33dJ65pZKYd2lzs7WVwwtjBnsP8EQg== X-Received: by 2002:a05:600c:3e84:b0:450:d00d:cc with SMTP id 5b1f17b1804b1-45201417068mr156513005e9.2.1749558958214; Tue, 10 Jun 2025 05:35:58 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:4d:e52b:812d:eb7c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45307b4788fsm91008455e9.21.2025.06.10.05.35.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jun 2025 05:35:54 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 10 Jun 2025 14:35:37 +0200 Subject: [PATCH 3/7] media: solo6x10: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250610-gpiochip-set-rv-media-v1-3-c088006a152c@linaro.org> References: <20250610-gpiochip-set-rv-media-v1-0-c088006a152c@linaro.org> In-Reply-To: <20250610-gpiochip-set-rv-media-v1-0-c088006a152c@linaro.org> To: Mauro Carvalho Chehab , Linus Walleij , Bartosz Golaszewski , Bluecherry Maintainers , Andrey Utkin , Ismael Luceno , Tomi Valkeinen , Julien Massot , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?utf-8?q?Ni?= =?utf-8?q?klas_S=C3=B6derlund?= Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1537; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=qJ7nbVmG9TqqpeyD/Rk6MzccGsAO1RnTiYTVKl04x9Y=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoSCadGfT6tsJ0ampv05o4yVZMWeuF4Ht0vCt63 rpDqVdK4xeJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaEgmnQAKCRARpy6gFHHX cm7HEAClpF8c85JeHHwpmEkbX5J3SM/K2hWTckAq1+2pOb/D9rN51WXNL1GKmXda95xWFPb8Ql3 3+UUGeQtMNFK6RdR+WMUXk8CDLa3yN+KMN+5RoMWGWF7bnYPlMPLhYB0Bow7lRYutbV1Fzf1SUv 3iZvdWfpvs0cGtnhXKHQvJK9llrV5Xmn/YWCIc+QsNmdUlTKqxUu5JvYQWfMnw2dSEtEKJTpOzU 5Op3oYSWaq65qPgQTZOBLihzyOtCKXSs9GeADVPP7R6UUs5Sb7OmUlc0BiarhRLlo9jl+fYBiOV Y2ZmYfDQeVi+p0841IXc+Axd/br77FQnejUoHaWrvpEzaMqBDPxBhqX2duseMecdGVJtYASCxri Rr0YVJbspRHeFtowKjsDgIg+O33oy0H4vRFctv7vE03/Zft4TqGxLXnX1+Buv9CNUcF9J0yAuCm nNkR7+c7woz7qROajOfNUiEzDf0gUx78ppqlLW+PgrrgKXm2tZXl6Cy3KiCOWQvUEJUeNO3Ys5H HJonmu6f4AgtAmChADna/c4xiv4Fx6dFViujt+AjnSGvvo2fpb9DW5dxLr7RwXVJBMWTXyXAJ4C +jpNUnEMLcQQVQtXG381jI0YK660I5nVc3avYSFhkIug8fzD28aipWehAp2I/V7GhJzb4nEGkpp 7Cp8vv1dnL/8mCA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/media/pci/solo6x10/solo6x10-gpio.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/media/pci/solo6x10/solo6x10-gpio.c b/drivers/media/pci/solo6x10/solo6x10-gpio.c index f51f865c69bd7b04fac7a1f951c734965d8fc993..6948f246a29ca92f12e3320d9c130d9bda7eef6a 100644 --- a/drivers/media/pci/solo6x10/solo6x10-gpio.c +++ b/drivers/media/pci/solo6x10/solo6x10-gpio.c @@ -127,7 +127,7 @@ static int solo_gpiochip_get(struct gpio_chip *chip, return 1 & (ret >> (offset + 8)); } -static void solo_gpiochip_set(struct gpio_chip *chip, +static int solo_gpiochip_set(struct gpio_chip *chip, unsigned int offset, int value) { struct solo_dev *solo_dev = gpiochip_get_data(chip); @@ -136,6 +136,8 @@ static void solo_gpiochip_set(struct gpio_chip *chip, solo_gpio_set(solo_dev, 1 << (offset + 8)); else solo_gpio_clear(solo_dev, 1 << (offset + 8)); + + return 0; } #endif @@ -156,7 +158,7 @@ int solo_gpio_init(struct solo_dev *solo_dev) solo_dev->gpio_dev.get_direction = solo_gpiochip_get_direction; solo_dev->gpio_dev.get = solo_gpiochip_get; - solo_dev->gpio_dev.set = solo_gpiochip_set; + solo_dev->gpio_dev.set_rv = solo_gpiochip_set; ret = gpiochip_add_data(&solo_dev->gpio_dev, solo_dev); From patchwork Tue Jun 10 12:35:38 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 895375 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68C7929C33E for ; Tue, 10 Jun 2025 12:36:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749558963; cv=none; b=CaqByc3QcbBa4i2r74u0GbDvjIhGy3qVMs749Ry492mLkd1VOtATuLp05DQhcG8uxsWa5qycJHx1wzMG6tl9iYPKFx6CvoPIzyGDOXPBGten5kgEQknz6RBiF0WZVIZHIlRw5lNgRbTUq7MYIvsPWAlk4azHRRf2T6s+WrvoERc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749558963; c=relaxed/simple; bh=DmSMep/ln8oFNFSCxh+5YdfNVCHUYDbu+lN2rz8R7HQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=QuZZYrJlxBVSyxpx6i+ODEmU1Ehj9/aC9x2Srp9/JGLwjZwxehfwp4hGRyPdgsIeYrve8uMfAySdF+N3VkSbL22n/fS4c+9J+0SNMk1vuY20yqYd2zoeJ53cCQJ2ke5Px+JmwpKWG3AV8pzsI1wVfrSW8sKRLTuX7QMQtxCtRXI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=LrG5vHga; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="LrG5vHga" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4531e146a24so4756965e9.0 for ; Tue, 10 Jun 2025 05:36:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1749558961; x=1750163761; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=q5StFzbVLsxYvLdlkRPCazQb/CEyrkV6c3CXJXiOD9M=; b=LrG5vHgagdYLiNpLHWDrNdxpMHcGqn+TXoLiN9hFlZ5fJjKJR4c2VrE6VFGtAcqUrQ X/16GCxlOG++do5ZfzMeA2peYh90heHv5pC+W1CGnx0Ctvimf7Mkf/THA+NXijvDtsiu l1mOgPNtpazRwDjE5lIYL9evdUVc8A+VN6IDnkHf12f6voKjZq1cjSTNiI7gMFaXb7AL vqLg7mq1Lgz4C/kLzQqy58NB6AYls3nCUusgwDxyBdB/ImiJ1IBTci+Ba7K3Y65JrFdo azzTGoGH4x8yH8E/Eq6JMFhYbE3RMt0Pvhl+iROAn8rjbI+BArp0cggX0IQIJ5/lscv9 ypqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749558961; x=1750163761; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=q5StFzbVLsxYvLdlkRPCazQb/CEyrkV6c3CXJXiOD9M=; b=LY8POJs60uCaD/D6COiFZ3aB0hkfC2ZhHN849fDC6jJjzEvRm2FFOLyTqMTWxAcce8 BsN0biby50DWhXbwu1BvHXEV2rPphEl/cTT0VS4OFXxWbRjQw3zymaZq+nIr++ky35Ok DZJ/BDE+U8uUoJLvwDaVcIVrgCEV2Ewfpxi1Vu2Z+PjdvRSVIzKSWmOHMNmuRCiMu1q8 9PBRqjgbLy0YaiRYrH+8ISm+dG+g7l4ZO+YhTGUEZdA0DoKN2rHniZohWKPvFMF5Mt9C tK3tPfgzlzKAS9ey0vISnqqzspWNs/WNHM1LwwHmwxeJnC3J2XRWbFLCvd4zpHPojtiq o/6w== X-Forwarded-Encrypted: i=1; AJvYcCXUkPRfW6hk5Fuiu75khh+9giFc/k4qpTvGOc5sxINBfBrYGP3Pnq/uOev38R6nVGbuO+TUWEeip10w@vger.kernel.org X-Gm-Message-State: AOJu0YxNuALwwvqpVT0kE1qa0lg+sWJeefsmak9MkfTaeDhB7+8pwLrc em8o2Ge9xvwNWIqU8dJ2fODP18NCN2CHWhdceiNUcdKSL/VZrQ+QkqdNm+RBGmW5iGi5cO0pqf3 rMwbm X-Gm-Gg: ASbGncv4uzsQjF6KumnoS9NhpqKGDeQGE9tyX1pnjekh3woXGNVj5WrWgAPA77694T1 nYRFTkqds/hMKVz92AEMT/mYAeQhe6KLuaqc+FWMmXZWNZPdjxttsVzvc10LIhuXfN7ZAxH4cB7 y7az83cQtvLjDLwfmC7qYC85aUacO3p6mKQ4MYkFINwNvw6dbLfpX6AqA9R3KRZKAVlbzFPmadr 2gaNvOyF9kdF4LSXmu2jw86de7V5BLdFpqGxTVh59taxieJ0hVKHZctk0SnW9twhsaBpk07yrQF OtyjgZHqYa0uyccTu2jeSak77Oz+ZjYCXgzk954QilH/++ZyvJ81DHckrXWlYwuT X-Google-Smtp-Source: AGHT+IHfPMYdbRyv2lDo4Df7tZa8JhMWmqJ5xTNyY8GATqJ5hfSOIDKoiZq2XLjT+/o6Y7BqLz6SBw== X-Received: by 2002:a05:600c:64c6:b0:43c:fceb:91a with SMTP id 5b1f17b1804b1-4531de0093emr23790175e9.11.1749558960814; Tue, 10 Jun 2025 05:36:00 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:4d:e52b:812d:eb7c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45307b4788fsm91008455e9.21.2025.06.10.05.35.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jun 2025 05:35:58 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 10 Jun 2025 14:35:38 +0200 Subject: [PATCH 4/7] media: i2c: ds90ub953: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250610-gpiochip-set-rv-media-v1-4-c088006a152c@linaro.org> References: <20250610-gpiochip-set-rv-media-v1-0-c088006a152c@linaro.org> In-Reply-To: <20250610-gpiochip-set-rv-media-v1-0-c088006a152c@linaro.org> To: Mauro Carvalho Chehab , Linus Walleij , Bartosz Golaszewski , Bluecherry Maintainers , Andrey Utkin , Ismael Luceno , Tomi Valkeinen , Julien Massot , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?utf-8?q?Ni?= =?utf-8?q?klas_S=C3=B6derlund?= Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1766; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=6W1fcEZimkIBP6TJfRKXLMogRIa4qaWvK8I7PtSZn7U=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoSCadgZNCGVFxZVVgaNpXwu+Mm+iPf/1j9OnjS h6B2gUmkKuJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaEgmnQAKCRARpy6gFHHX ctu+EACFkCbwSoa4iv+9cVxVDtv4cv2EitIDVYBEwHyML8ePPxpTHLWdYCwMUNCYk+QXViqfZ5E GSi5XJ1K3P7JnOU4+RjKupliJekYJkcj9T96GcDKPgh2C39AkFUnGUDGyLdGDqYoT6c5Fsb/U2S 0BIsPkWJZGZbJIul0RbAAMO/SnMfXNLHUhMpfEWUMDsD5Md2QO4flxYBCDPLTh8MaibGSa1xnEO tfTSTEPTj2psuOYw3Mp/hgg4cqi2+qygmQBYCIqMErri6FrJluhbL1hSHVf3+ZdtypLKj4CJKF0 GRYFoAFKlt55vzDzxj2qebHPmCwr0J1RZTK31OOanB6psbaR7seEsNAdQeSIv6153VwYXPIDrny V6bhda2T0gEviWbCfZ1DEJbvMORv4wc3bm/Md3/eDQOxeJnyxn0CVMIuXfIpUV8CH+NpXHuTAXY +eTvOs8LnnLkAc5c5bZJN+N1zSGl9SOttchRalCO4JUPknR2ZUef3RRVHVV9UqaV7xs9CvGx59z RYkH8tiMuXikYvRlsHQibPLAk52NL933ARk92kdgqGtrgRiOj/bgzQe2TZ+Ttmmcapp2n7RZu7h NQmmvLreQXMGbiHSuSPC5bVNg6tv7S/Ff5v7WHsymifG7mFjbOFFqT+XnzdjSJIZTwwVQMF2z5B uFM17C8ZjdeYJLA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/media/i2c/ds90ub953.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/media/i2c/ds90ub953.c b/drivers/media/i2c/ds90ub953.c index 59bd92388845eedf64587289c7f7424ee570524a..242dbf6d48f3905c8908bbb06ede84e068e2f267 100644 --- a/drivers/media/i2c/ds90ub953.c +++ b/drivers/media/i2c/ds90ub953.c @@ -317,14 +317,13 @@ static int ub953_gpio_get(struct gpio_chip *gc, unsigned int offset) return !!(v & UB953_REG_GPIO_PIN_STS_GPIO_STS(offset)); } -static void ub953_gpio_set(struct gpio_chip *gc, unsigned int offset, int value) +static int ub953_gpio_set(struct gpio_chip *gc, unsigned int offset, int value) { struct ub953_data *priv = gpiochip_get_data(gc); - regmap_update_bits(priv->regmap, UB953_REG_LOCAL_GPIO_DATA, - UB953_REG_LOCAL_GPIO_DATA_GPIO_OUT_SRC(offset), - value ? UB953_REG_LOCAL_GPIO_DATA_GPIO_OUT_SRC(offset) : - 0); + return regmap_update_bits(priv->regmap, UB953_REG_LOCAL_GPIO_DATA, + UB953_REG_LOCAL_GPIO_DATA_GPIO_OUT_SRC(offset), + value ? UB953_REG_LOCAL_GPIO_DATA_GPIO_OUT_SRC(offset) : 0); } static int ub953_gpio_of_xlate(struct gpio_chip *gc, @@ -362,7 +361,7 @@ static int ub953_gpiochip_probe(struct ub953_data *priv) gc->direction_input = ub953_gpio_direction_in; gc->direction_output = ub953_gpio_direction_out; gc->get = ub953_gpio_get; - gc->set = ub953_gpio_set; + gc->set_rv = ub953_gpio_set; gc->of_xlate = ub953_gpio_of_xlate; gc->of_gpio_n_cells = 2; From patchwork Tue Jun 10 12:35:39 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 896410 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7710C29CB3C for ; Tue, 10 Jun 2025 12:36:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749558970; cv=none; b=qrOeMS8D7rBr6u4dt/BNISFTpteW9jJFCfhG/c2MMI+d3NQWfcOSy7QAH9ItKSFQY4SaK0JLFfMcg75YQHby7DITEHWXAo5+PyRk6By3huobELzSU5ZfchXqiq+j6bkWD2HIT4yuV+xcA406uLbjhRdcwoOo+E6FoBxhxeDoIQk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749558970; c=relaxed/simple; bh=kgpyXSnZmCFwqfmomq7FGHn3gBVV4OHMPubpvkjXFrI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gIWEL/A50jfKaPjpJDsJWFn5No1qllL2yozrUQFPG1ccuTyPb/+fbWBJn0wUdXNOcMRsKuCl02hI7S8ZfWNVWUYDSb7Rj1bEPYHgaiAYs430+p3THHGSCYh9b7rCCpGIEi7h6047WyXIUu8nUG/ECMLavaDv3w1cNezVm5Ca558= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=tEHi3Bh+; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="tEHi3Bh+" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-450ccda1a6eso50419415e9.2 for ; Tue, 10 Jun 2025 05:36:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1749558968; x=1750163768; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=EmUjxGb9YXlrFmgTBSGtVdHlWeBBc2YrESubaUeQXrg=; b=tEHi3Bh+XruBKEKnMg3YGLzi97cXmiX0nLxkjNZCLaNfsbDWwJ5B9Hux2QHaEaN1Jn VCusLoE91wgtXtyZitmTaC8QM+0Yqtd9ghIONGqjRZuwKimjEH3E/4VyqEB+NKy3969G rzz0MgnbHdz3oY/Z2tOKfXJzAGgC5ufI2gPURdFRKKLkZZdwoirCxfq0ddJsuEtU8d8a LledrMs5VrMEVN1zZe2G826s/+/+MH+7TcWiOI/4rOjYhjwr4hTbRhXcEj+WcSH0NnUC U2m41Qk0tfIOYzYAMa1/GGG/Fr8ZBpvlA0V5/0PbNKdDmaLWR8PccCtOZy3DaIJYR/Mm KC9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749558968; x=1750163768; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EmUjxGb9YXlrFmgTBSGtVdHlWeBBc2YrESubaUeQXrg=; b=Oxjv4aQ3XSeoFvCPEJvX6iOhvlNAJfO8OB6hj9c3SrpWdQ2iU61nwwGfL7ngx8oqWg 56YaEt7cDx1qq20Y5e6D7prlVncFVCjzKdostw+MeraHZoFdpHsEMP9PTLwnb3DaTje0 lW/K2kGApn8/UW+4XhCKEb3PeoQyYMsjy/uOZkiPd2PEXblMiV/9JMHq7Q339N5S8+le ZfGJYzyOrS6ufq+cvMdWmWWw0DT+CDBBgXImOX1eWn172R8/ZcuBAoW84i///LYCtL2P OLtDxq1zjeWf4bdu2ftHr4ljNSQkSIFqDzW7iW7vmvEE6y1OS/IFmGHz9QvNEl5hhrwu r0CQ== X-Forwarded-Encrypted: i=1; AJvYcCVr2PiqIaNx/yH7jk++ornQcUx7aLD2/ryJiHKV6b0gT7AmpW5BIRJAihhDO/yyeXAQSrqRSL+3SdT4@vger.kernel.org X-Gm-Message-State: AOJu0YwBHRWS1g72S2NULRKl1GPX+ZS6C0qXrS50Bysp4iU35VoO+PzT pmufabAulOO5MoqVXw9fZPXrcbE3LzksPlRKN+gO4F3oi7/rTOaubIaRFY73fk+P78A= X-Gm-Gg: ASbGncuN7vxsaIms+lIBAe9M+S3zjYHnn6jCoZqhTeoGWZUJG3QIQ9AWwDZ30fxqCsX W/7CsUTiAeziDlkqaEbIRo/xXUhIeepQf7p0o41ENUYYge6gfZ6qlzmLUJtFHv537574BJFdv/f JgIE+zyZ+FgYlt9PYP74dYBVa7rjZ3tKD0+ZYNrw2yTiGMI9QJkUcUsSwYcANM4L+g2hS3kwTYc 20+WD9wgpIPaxrgNXZZHltKWBywQs42l0ywyobwCIatUhtvN7U5AcLR4Viz92N8e9qD7SlI4eZw KWrr1jnkAP2Jbnaj9EdDN+GOvTgW2ZNfaXYgKgk6kdz9hjjKMxWTjg== X-Google-Smtp-Source: AGHT+IHhf0yhbVAU53CCnx70BotxQgp+L6cndixtYZtb017L0GDbKhx9QFoSw4ecB4gLAszon3Fb8g== X-Received: by 2002:a05:600c:458a:b0:450:cabd:b4a9 with SMTP id 5b1f17b1804b1-452014ea1ebmr148815685e9.29.1749558967893; Tue, 10 Jun 2025 05:36:07 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:4d:e52b:812d:eb7c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45307b4788fsm91008455e9.21.2025.06.10.05.36.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jun 2025 05:36:01 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 10 Jun 2025 14:35:39 +0200 Subject: [PATCH 5/7] media: i2c: ds90ub913: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250610-gpiochip-set-rv-media-v1-5-c088006a152c@linaro.org> References: <20250610-gpiochip-set-rv-media-v1-0-c088006a152c@linaro.org> In-Reply-To: <20250610-gpiochip-set-rv-media-v1-0-c088006a152c@linaro.org> To: Mauro Carvalho Chehab , Linus Walleij , Bartosz Golaszewski , Bluecherry Maintainers , Andrey Utkin , Ismael Luceno , Tomi Valkeinen , Julien Massot , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?utf-8?q?Ni?= =?utf-8?q?klas_S=C3=B6derlund?= Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1383; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=uirTvdGFKLj1HJ829gQF9CK8Tn6xJqSzhqLKMW/nEqE=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoSCad2woSfO3sebexW9Mt3ViNPTAVSqTNciWIU a1fvZKssH+JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaEgmnQAKCRARpy6gFHHX cisHD/485qXHf0m8whtLOAatdU72Wh0xmX1LQCoEJ8lYqmSn1CNAuUbRDS5Xt++ChKIdlUgHAUp dha8+20jLZQG8Vt+PtimqLHAcQ0C1ysgeJAZ87FRyk8gZkZqQqtM22spmbSP5rEi3FKriglwT3k dd124M1zjStOeTz+SIKmrlTOvss4mJfsmwa5TU0LUB4HMfIwHhH5mhmK8EDC2Jr13o/WP/xsOxk v/yQPNoNaPRUA2UQRTFykbqozRLnsLlGznz4myOFJIZGXHUgg63M9vMYsi9WOlYQl+n16Kva3yS vaEu0TYIMPwAQzSKUvflz6sjYTY/oWEEigaDnvmBcSIs9jnplkLNiB9YajFBnSnbACEm9BKes4l 6+wTXfBdD0VmbT6xIs8CTAXREwxDxSCbrv2PSVphbOMtF8LNH5AUCeZ86VaBIi0XFX+EozYEotG qCjcjoQkCKjX35KEy8LfeAspwkl+xHA5TmnLW/20UKv+QsWqiwIOa7ggoWaAQ7XxI9X0zZaFR4w 9N6U1gejgLfC1a0E9M30P5uL7Vmc16fsnE5V1IFHUfO2218tUcbaAvfghe2jmmwNBlGTFivrVp4 CDjsXHmTXpKm8zVrkf/ix3PYkogl3gAugAmVL9JKgI+IdlW9UmuLx6Fh/+yggvWpQ0A+ovEBeV5 5FcU4DP9GWAOfpg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/media/i2c/ds90ub913.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/i2c/ds90ub913.c b/drivers/media/i2c/ds90ub913.c index 6d3f8617ef136c6f47871f5886193fe934c6f3b7..c34ffeae5f5080875463b6b6d45acbd9e107d461 100644 --- a/drivers/media/i2c/ds90ub913.c +++ b/drivers/media/i2c/ds90ub913.c @@ -203,9 +203,9 @@ static int ub913_gpio_direction_out(struct gpio_chip *gc, unsigned int offset, 0)); } -static void ub913_gpio_set(struct gpio_chip *gc, unsigned int offset, int value) +static int ub913_gpio_set(struct gpio_chip *gc, unsigned int offset, int value) { - ub913_gpio_direction_out(gc, offset, value); + return ub913_gpio_direction_out(gc, offset, value); } static int ub913_gpio_of_xlate(struct gpio_chip *gc, @@ -235,7 +235,7 @@ static int ub913_gpiochip_probe(struct ub913_data *priv) gc->ngpio = UB913_NUM_GPIOS; gc->get_direction = ub913_gpio_get_direction; gc->direction_output = ub913_gpio_direction_out; - gc->set = ub913_gpio_set; + gc->set_rv = ub913_gpio_set; gc->of_xlate = ub913_gpio_of_xlate; gc->of_gpio_n_cells = 2; From patchwork Tue Jun 10 12:35:40 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 895374 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B40E29CB4A for ; Tue, 10 Jun 2025 12:36:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749558973; cv=none; b=gG9s7lpmJWyyuNGaDLzakujlSv9WWwuki/VsOZ13/zZjC3vXHWbOkJ1htG749BcRLDeBwF7AIP4K35Fd6DifGYXeUnd1+qX5UUI9jbXClPgKD5qOtLl77NO83qjc9YVvj4DIrkUvi9ampneMRQGEn3QoGCasnY3wmmKfB1R70NE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749558973; c=relaxed/simple; bh=6dDruxI0CMaIvewahEW6x/eO1kPM4lNc6aCD8Neqv4U=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ESsPe9bhPKJF06CKc4AVw7uVvf7ur30LqTBinqaBPF4BO5dXV+7SaNQd2bSfVUzAN2gq9B4jEBHVAPx1ELC+miLKDLYTYOBSdtOho2LAaqSxRnYE6NUvNigyOyHxxvUW31qw/227j6ha5E6wtIemUodW3S1naV7waS5e/XCd3sg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=Wn+4yCRH; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="Wn+4yCRH" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-442ea341570so35334795e9.1 for ; Tue, 10 Jun 2025 05:36:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1749558970; x=1750163770; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=vJ+dN5ujs/yPK5NxfTplkwW8W001YBt6mCY985Z4SkY=; b=Wn+4yCRHijd9d/tobSpeB3xPO9DqzHSGOqWglsudRMGwkvi5MVWn87Tir2iBlJvMNE qwtOa2pfwGKZb5T6K8i1wfDf61pK1EBuMGPVsqNlxnkFINiJd1DOtGzueaZ2Q8bxvTP8 syPh64lNMk/qmLWoOXxRql7itpgswvLE+6KuNoQlPD8e368YiQ2ti9qiv0g4i964devq FFlLfMJlxs8UKiGl+Ljq3+rFeVSF/FvICK0g/ER0EEvQq6O9QAROWEv8IrDKLa7g1Oo7 YRROnctvhCzT4lWz0oOX1vGLLX8snXM8Q3LuQUfdpjuIumzK3nkEpnXKPmUGN2O+nA+X BZ/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749558970; x=1750163770; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vJ+dN5ujs/yPK5NxfTplkwW8W001YBt6mCY985Z4SkY=; b=jqj69pGv7mydkbSOcPs6MmH8Kd4RwYo2XbMloG9wRcbsF17e92NntkdEmraXkypnsO yoKT+jzYHJFHOVjAe0tyU3+3D9EkivsoaCYnmH/QVaIjQWjO1RND12ojyun+4OKeuwIC I0USAcaSmSgVtJ0OcmcTOnkR2eSTDcJu6l2QMLlx31ExLcag7cKmyFWebl97hNGKXpKZ 0KkLIfhEh61He4yoUj1OpTjS7rkOzcbARWem0eN2UHoRL++e/YrRrs2ISkaMFCUIUP0t O0XGmympS8Sl8nqvJj6VNXcXYmEaTXgp6E+VCNXCcpA1oGuoNPs7+y+y5VtL0Mjxlmpz a2Iw== X-Forwarded-Encrypted: i=1; AJvYcCWlr7D4q76n2SCrbD0OIX+TwST4CEJA222dLCodww/kr+xr3mSvl3mgVehrFv7S2tWHWCrrY1VPqiAT@vger.kernel.org X-Gm-Message-State: AOJu0YzdMbLBeMEqQihBNgD1FuZxiGDmnZhrJXu/MOoNi0F1b+af6L7k fAKpmc1kU9mo+/fgBwRlpWp9q0CpD7RXdyyFdzNyfzVuZ8UOlLzFMqPR7U74VBsvagM= X-Gm-Gg: ASbGnctPaDy44rKFkPYerbAq7dKJ3UiJi4Bfn/BwjVL9e4atpBk7nRMYDwkql9yX/eo dZBAzg5tfpMuR3Dm7TM9AteC3BUVkdm4ffrpp+Xxn43sHEwgdXGp52wHae+0eirmRaB1MvCiRtB gHbd70rZhGJKWTUqpNKXn1EF25qFcYaGbc1BkLFxLolgpfB4/DX8ebJgkKdgqJ4pmU6fSLI2c6X NCFlsGhABlK6kdJjGIZZK9Dc43xzoD6/NAVNTv7zrZxpuBdX45n2PV6DbM/ige/+KdrXV9P4eol aObWDIShwcpeGnKo0m5blrYTpJ1PR3tYj+hSY/eIfTxzHuQzkVsZeQ== X-Google-Smtp-Source: AGHT+IHGYs9SXMCPNNrSFnm8FqEiFqB/06BTghaHrW4YTub+wcikOYLcYXBiXkT4LJstkXF8wI3dNw== X-Received: by 2002:a05:6000:2507:b0:3a5:2d42:aa17 with SMTP id ffacd0b85a97d-3a531cb8d5cmr13607365f8f.31.1749558969906; Tue, 10 Jun 2025 05:36:09 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:4d:e52b:812d:eb7c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45307b4788fsm91008455e9.21.2025.06.10.05.36.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jun 2025 05:36:08 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 10 Jun 2025 14:35:40 +0200 Subject: [PATCH 6/7] media: i2c: max96717: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250610-gpiochip-set-rv-media-v1-6-c088006a152c@linaro.org> References: <20250610-gpiochip-set-rv-media-v1-0-c088006a152c@linaro.org> In-Reply-To: <20250610-gpiochip-set-rv-media-v1-0-c088006a152c@linaro.org> To: Mauro Carvalho Chehab , Linus Walleij , Bartosz Golaszewski , Bluecherry Maintainers , Andrey Utkin , Ismael Luceno , Tomi Valkeinen , Julien Massot , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?utf-8?q?Ni?= =?utf-8?q?klas_S=C3=B6derlund?= Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1689; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=zxXtt6XCScDkqWqDmMavuunKoHjUaJSqDc/9xdViskQ=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoSCaejRazjUIZVqEFKdPo4Nfm0thjwtuSRRnuy /Ty0XmoSVuJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaEgmngAKCRARpy6gFHHX cnxvEAC18wqQmhpnwgjY2Ep9rhqC2zmil6GXWw7Z2idhzFYOhj+M2phuqy1Jq3OmdM4rqdEz0XV 6i7KwbhgQ1R7aTbkvkbq4oein49RDbVYXNtzq4sM/TcreB8efM5aVJ43KGClhyrF5JiosQRcaY8 /tgxG6+Wl/3nxg+wJ0SBaGwkIWyy1V/iy9R1nzoVpGCiO0MXiKILw6i58qYiH/AUCvF2T1YExdR yQbt58z6I4O2T1W37j26f9nwGzsqvt2JI3JNB4k+AK+UrRfw+ufC/aZDJFEC274u4pYNlj+/18f ZUkuCUhlSbqwP+xena6nVPWbRbStydhD0C340np4bQ3MOTyCz16nbAEEfYfR+N5/2F7RzJgByG/ STfNNIS9YIy20PSBvnwxW08B0wuKYyyPxLfopQphWl1Liy00XlcTJ+s5hoG5z+GjTJg8Uq1Q3ZJ BHrA9V2qgjN1UrkyceGNfNmNjyD2cBaPO/LgAWfEpz0fcaiu3IBPIISNIO+iyAW3K/lF1R9rsUe v3Q4nfhvZYSPZCu5tr+DOJnFY6uIacIM0330u9oVpBNl33aIFzukBTWaKFFgmFQRafxCTYOo2wz vek9sLxuNOv05+yK/eY02RfmHHt0vHKYLkMmJJNV1RzTgt+oP9kMelVIZIQ+a8UZq08pp9uGfYS 9k7y5LEw3NPKCsA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/media/i2c/max96717.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/media/i2c/max96717.c b/drivers/media/i2c/max96717.c index 3746729366aca3af8aef3a807e2f91a8f142ce59..a503a55fe8afa9bdda8fc9b1c2b0e7ebd02afe1c 100644 --- a/drivers/media/i2c/max96717.c +++ b/drivers/media/i2c/max96717.c @@ -297,13 +297,13 @@ static int max96717_gpiochip_get(struct gpio_chip *gpiochip, return !!(val & MAX96717_GPIO_OUT); } -static void max96717_gpiochip_set(struct gpio_chip *gpiochip, - unsigned int offset, int value) +static int max96717_gpiochip_set(struct gpio_chip *gpiochip, + unsigned int offset, int value) { struct max96717_priv *priv = gpiochip_get_data(gpiochip); - cci_update_bits(priv->regmap, MAX96717_GPIO_REG_A(offset), - MAX96717_GPIO_OUT, MAX96717_GPIO_OUT, NULL); + return cci_update_bits(priv->regmap, MAX96717_GPIO_REG_A(offset), + MAX96717_GPIO_OUT, MAX96717_GPIO_OUT, NULL); } static int max96717_gpio_get_direction(struct gpio_chip *gpiochip, @@ -355,7 +355,7 @@ static int max96717_gpiochip_probe(struct max96717_priv *priv) gc->get_direction = max96717_gpio_get_direction; gc->direction_input = max96717_gpio_direction_in; gc->direction_output = max96717_gpio_direction_out; - gc->set = max96717_gpiochip_set; + gc->set_rv = max96717_gpiochip_set; gc->get = max96717_gpiochip_get; gc->of_gpio_n_cells = 2; From patchwork Tue Jun 10 12:35:41 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 896409 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 949B729CB52 for ; Tue, 10 Jun 2025 12:36:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749558974; cv=none; b=XbggICArpQQCUULs1FRI28ipstSqLAXjavw69u5kD6aAHziYxHfk9WK/mWBbr8yFbSXNMfQWXumwCPQvzQ/KrgTShW0KFaiSdMowcyPkpGj+ULnp/A9zs7CRW0XYTMJwD4xKLvBFJ3r8ubsEYHT3Gqijczhty/eJGWdis9bBUdw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749558974; c=relaxed/simple; bh=j8Ee5zNRTgD6Im7szjj0YX+ao0qiLzGNAn/JhbhBZbo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=aUo/6LssoLdvPcyvVmwlqXgk4zRM7XZhYHM/WCR5upSC3IkTsvNawJuwKY+PCCqHTkmQE1prmKdKKw1kTlZSAjVBEkfw2jAKSFvvfdtX5COpHTgWiciMSxYBwF6mfhNkEhlbzdSJl9dNWOsu62e6NYID/dSEUCq6N4tKxDzfJJM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=eslsMBtU; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="eslsMBtU" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-442e9c00bf4so44605585e9.3 for ; Tue, 10 Jun 2025 05:36:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1749558971; x=1750163771; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=UnEiJ0DPVJeTNWgLtlb3XDcjvamvu9NbT3oHT6+NmYs=; b=eslsMBtUON43EvDBMS4G8JtEWhJ4AvaqYfmKFX0JANUU0VU9Ckm8OYwNCbmjA48Gkm ZO5zezDn8W5F4NfJy7droAe8lVK/ZvThBm2mQZIdAdYbDo3Wye0NgRF9+a7Qod15G4FM GrSDH0pk0Pw8ElBdjufGA40HeHRaRrTbWcePHET5WHS90zanlZFWu4m8BtwVwzkpyO1a eC/c0qYm9yMHUX2wJUaBNjKTakHgwHOsaKKGJvdxlrR8weOFSvcxCwAKIkqwyRTHeUrX qQ6ZD9gmip6Qoq+QBYCbiUnReroJ9IM13syniEmG3hO0sLrBdRvHqB1Ve0RSwGSM2nWB vtLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749558971; x=1750163771; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UnEiJ0DPVJeTNWgLtlb3XDcjvamvu9NbT3oHT6+NmYs=; b=WH1JOor+AwRxbEkIhj09qpHn4SGHBhcWnzDT7bG+AUehwkxFzYDk7QXaUVq41OC+lr EtzLpHbl5ZCoTsDRQEn89nlZYxlhwoXnhuIWKAulKtodESYLauKPsfegaw1btkMZc2aK yfYqTjnYIqXklTygGPeaSi51M2XXfxF77V8UkXytlNLLoCkVKWf5kYa5JSqi0XXt4eRn Ct4/v3sc+HmfJRZG9tE1bhZzVi8DXiDaNCFQ7DVifl98xfvfb5qUkWZ66ItBIOM+4QCL PDaFBhdxEPOgxktEh54/s6jhF6Q70V9kJ5tIOtyIeCWfRvpIbVfBKOV4aTBBuD0B2YWB HXhA== X-Forwarded-Encrypted: i=1; AJvYcCWM8PJq4Ezc02Zm0IE6fv1rYyFws2K9MYiSBza83Ml/Jt3uQsJ8vO+LGrp73MnfrOe1Tp3VKPEZc0vQ@vger.kernel.org X-Gm-Message-State: AOJu0Yx9mOsMNHD2az3h6Zu0GW6nYQrMsfhGw1I/BmAuKjPNgauLCS4d wHZz3e95xccSXUdRi+6A70OBw5+wnYUKU0d+vi89wuFedJWrIsRaPtjmmSluM0lra28= X-Gm-Gg: ASbGncvUKTmJwXNx3k2eETUnSyRxmkpRjYLdnu99dXledcTJtheBOO7LsBGMlRsE2ah 8MtPyiGqPU2yvWlqK6Mh9q1+BGsU+quHInplcbRSqfdNupaXxhfWvpJyxqYw4FJhcDli8SnxdkO klHOxoVnpeNinAOeazBek5TYjNbsj3C9x8TwhWe0AvRZ8/8EmZjrZZVelzYibwNhcjKaea/4Vbc rljpxjRorEThWN0ncwtnw7SAt31uH4uKpYoDfXxprAfeXPujqImc1d8BkBoRtV77AIp/K5sg/O4 Y6XQ4uKZnmg0oxr1ulT+8LBAe90+mLWAqHBHL+pSCIqBMpQL4wrgQRSpLFh3CXVy X-Google-Smtp-Source: AGHT+IFu88AAwRyhu7BA5cAy1Z6ElMtpfHSvLceWBxJHD0IwTf3JNoo2snJDzPdaHI3Cx5bomnT2ww== X-Received: by 2002:a05:600c:4507:b0:43d:fa5d:9315 with SMTP id 5b1f17b1804b1-452014b56dbmr144330555e9.33.1749558970866; Tue, 10 Jun 2025 05:36:10 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:4d:e52b:812d:eb7c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45307b4788fsm91008455e9.21.2025.06.10.05.36.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jun 2025 05:36:10 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 10 Jun 2025 14:35:41 +0200 Subject: [PATCH 7/7] media: i2c: max9286: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250610-gpiochip-set-rv-media-v1-7-c088006a152c@linaro.org> References: <20250610-gpiochip-set-rv-media-v1-0-c088006a152c@linaro.org> In-Reply-To: <20250610-gpiochip-set-rv-media-v1-0-c088006a152c@linaro.org> To: Mauro Carvalho Chehab , Linus Walleij , Bartosz Golaszewski , Bluecherry Maintainers , Andrey Utkin , Ismael Luceno , Tomi Valkeinen , Julien Massot , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?utf-8?q?Ni?= =?utf-8?q?klas_S=C3=B6derlund?= Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1468; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=HgIaQmZBN+2BMb6XtS/4r6T+Stu0X4lPC1c0+Nqlo58=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoSCaeYVgRtgxneM0Tdp6ek4umZK57hxpFsRPe8 3Qo0tsVOWaJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaEgmngAKCRARpy6gFHHX cnzLEADanEO4D61rw13E6xqC1/8/v7BtcDVy/bqNG+Y+NLc4oBXjEUrImGZ0A73JmJOyoIo3h/R Q+IjWG1T5qOiyBDuZkPJCgX1PUaHRzLcUpLGo77ov52Jl7YG9h4E/T7XoXnU4SgZG8f/ALerKQ2 P1TTL+GRXwu1p8eEOtxymo/YMD2qqzAeZVSxqpTNv51OcA5s/n0ZD4C7QsJ38S8HDlM8yNZXgE0 XOgEjxQ1t4APIOlELklaiqvYho7OSFfedhxX/WLcyEoHr9cDEoLpd6WCPXoR27DF0yLmo8mwKnQ 74wOYfIK4Ax2Rs5aokxDEj6MtHi4ILx9eWK+5yn28KEVBiHjaMelg/321FNLgehZ4q6vxRQpgwW MkEkkyfi0FwBYIdDMK++zIWs2zIt94YpHOhZUOKe5Wme+hsal8D2LPwGz2cfXq2/ynTGt5Ki9iO 9tCWyftwIAUI79SQBBRSL9kATcSvTvkGC1CEbQaLRGKVUzmwcbXczRQXyv9+t3piw0wXmlWf2jf T/YVP5aNEsJ2MNqmH5F3F4pFqzCUtjxutaTJItTO782IpArBml6cp+2Q+8jyYivE76stySY+3DC o+SsiuvbA2lhrfhAEAypXQhvaYTgI6zqAqFy844bpbHy3byR78ctzTX9oinTBwj0cAH5AzAKnwB YP3dkXIIymqr4HA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/media/i2c/max9286.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c index 9fc4e130a273f8547d7e7ec194cade5b5e9c8df2..1d0b5f56f989874e46f87db4a49d935049e6e7ce 100644 --- a/drivers/media/i2c/max9286.c +++ b/drivers/media/i2c/max9286.c @@ -1193,12 +1193,12 @@ static int max9286_gpio_set(struct max9286_priv *priv, unsigned int offset, MAX9286_0X0F_RESERVED | priv->gpio_state); } -static void max9286_gpiochip_set(struct gpio_chip *chip, - unsigned int offset, int value) +static int max9286_gpiochip_set(struct gpio_chip *chip, + unsigned int offset, int value) { struct max9286_priv *priv = gpiochip_get_data(chip); - max9286_gpio_set(priv, offset, value); + return max9286_gpio_set(priv, offset, value); } static int max9286_gpiochip_get(struct gpio_chip *chip, unsigned int offset) @@ -1220,7 +1220,7 @@ static int max9286_register_gpio(struct max9286_priv *priv) gpio->owner = THIS_MODULE; gpio->ngpio = 2; gpio->base = -1; - gpio->set = max9286_gpiochip_set; + gpio->set_rv = max9286_gpiochip_set; gpio->get = max9286_gpiochip_get; gpio->can_sleep = true;