From patchwork Thu Jun 12 20:02:14 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gustavo Luiz Duarte X-Patchwork-Id: 895794 Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 510AD2E0B73; Thu, 12 Jun 2025 20:03:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749758596; cv=none; b=svINsYeh156TvHlewtvUat4gXGJObK7b8wtP45F9f6g50LfRWIfgKBW9rLgdrQv4Bt96hxp0iXiRfHrfxN39LFNkHgnCVbWAw8ufriyiUImDxK6yphFwt9MgPFVECxpKqmgPAyI4joUe4FYnJffsGXP8+eWOasamJ07ZYtGzXD8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749758596; c=relaxed/simple; bh=p94oIFo4jUglnAhbc3gfVf3Xl1s0WKJ0t3PNRYqQRvE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=RzTuRWggctzloCILkr+B2gCAulAugMYk0yG2jSU9M6qlYnuTUap0yi6mL8rtlpYqo8OhFeM+EWWI+E/JTpmkHvOTQ+Quqacyj3Y/Sd2TxuiYVfszPPIcb8KSCWiPrqoE/GU6L0YD/LHdNOkEvIV8YcG5pdPLJFX+teCooKSr+bM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=keS+JI32; arc=none smtp.client-ip=209.85.160.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="keS+JI32" Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-48b7747f971so1513301cf.3; Thu, 12 Jun 2025 13:03:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749758594; x=1750363394; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=GqK4XVmf88e+UTUicEUcYEEd52VK5FIFk2p//V1IESs=; b=keS+JI32l9TQ8njvXDiHqu+5MxZq81deZkT8Kc8/8CpDfx6EQ3nmW4V5TukVNjOG6g UFVeKh3RctIw0Ami27xVyBbCH+6gCO8hT3pNMT9Z3SXom9kN9g/Zft7sn7wND2gwulcA +knRN+r2c7JrMVRlcZzNOVrr2QahTCrdixsQkaQsHTe7muf8mpguVzUZA+LvMpracJ+F PeePpxAxljGsEPybzedKlunfbFDN2JuD6a2QVmyXR9s08uSO0g6cj80bWQEDCdiycgEp cNiQRzX+rxHoXMbn/zL9I8xVU/RVhMw1kvoAYUPtdqbHu8hVrKnjwGJxVP3GzSt4YzGz AEtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749758594; x=1750363394; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GqK4XVmf88e+UTUicEUcYEEd52VK5FIFk2p//V1IESs=; b=LuWCMlJtCo8kg0wyhAJRfu1FNs63hgraV4SdY+VzKManiU9f3VAz9LhTGqu+NG7O1+ 9kmRZprSU317+7doxFcr91SKjzicLB7t8i23yTEtSWv/Z+CB4S4uoCqgS1nGPZn5zWy2 A0hvumPtM2fnUhFEEMTjj9LHEgy02/+enxnzTILa8d9qqKHc0/6chClnWSLh4+4g80Tp Tp6zghTVSnj0u4wdrKl02FkrbX2Iq6pd/ndXoxdgsgF1mAYIm4l+TwlUvPotoS4McApf c4Av4Gb9zO8rrIUPUvTEQMbIO81b0of3SBqNbF4Tihob5yMxI77CHe6LSjgTsmAl0l6x 8JMw== X-Forwarded-Encrypted: i=1; AJvYcCVkmNiFaPoJzGt541P0DGZpqyzuROlEVgAdHE/VYkZ744LZMcioM7zp4W90yXnYv1EL4Pf9xa7lApc=@vger.kernel.org, AJvYcCVwzbuNM2jx+11ANkP1zm9osmzmcpYfLNKRdoFSG1VEbwMHx67F2Hoj/7BPaQM30ABDZ/Wr3HTNCxd18IhaUjuh@vger.kernel.org, AJvYcCWPJCoY0UG0ptVbHNIJuBVlIgpu/aRnAbCexr5RErjB0INCE9zCZtBr3CUUNTNOmjWSbs0jWKm0eoZTjZNz@vger.kernel.org X-Gm-Message-State: AOJu0YwTI0ev4ZZleUW9V1em597olyNZh6tAgkUeXDEwoK9iveg+3TH9 N+Eo+DSSGL5tZTavH4xSsIfUod0nPBMLQxoeiDEbugsKCrsMjezhZmsr X-Gm-Gg: ASbGncu6wg5oDF8hSDZ+KoMw3XigD2Y8RRxUDO5Je8CfOlgSS8rZo8M3IeE7L9RIVgI /eGWB+Pzv89mLEHdzLYvclGf8q8fxSm+bN9rB7qJldiirGnWVD5OPsge50u92a11hLFNNAicgqO cZ7b7eUxxuKqJIF+FQaREitVMr1NSodOuC58+8E705HpYgphuyS+1a8c8GW4zGnmz1qGBbqWhAk OmWSvYy+8kU+1V+rSAZdbwAH1jxYIs+v33hDGD9Gf/K6KkoEfIOHPC67/yc20EOCNhSU/IUQ8lt DHWFJzcBdodpGCYRr3UJkddisJ/Laim5NnAxw+PwrqDF/uzwG6AhZnY= X-Google-Smtp-Source: AGHT+IHaJ8YHfWK3ymwJNH+TEVoQLf7B7caofHWGb4f5nJ1C2jtwl17bBUz8ImIy+guO+S4h4KW2tA== X-Received: by 2002:a05:6214:f29:b0:6fa:ed8e:372c with SMTP id 6a1803df08f44-6fb3e5fc540mr1071226d6.1.1749758594031; Thu, 12 Jun 2025 13:03:14 -0700 (PDT) Received: from localhost ([2a03:2880:20ff:1::]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6fb35b20f67sm13696456d6.16.2025.06.12.13.03.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jun 2025 13:03:13 -0700 (PDT) From: Gustavo Luiz Duarte Date: Thu, 12 Jun 2025 13:02:14 -0700 Subject: [PATCH net-next v2 1/5] netconsole: introduce 'msgid' as a new sysdata field Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250612-netconsole-msgid-v2-1-d4c1abc84bac@gmail.com> References: <20250612-netconsole-msgid-v2-0-d4c1abc84bac@gmail.com> In-Reply-To: <20250612-netconsole-msgid-v2-0-d4c1abc84bac@gmail.com> To: Breno Leitao , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Shuah Khan , Simon Horman , Jonathan Corbet Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, Gustavo Luiz Duarte X-Mailer: b4 0.13.0 This adds a new sysdata field to enable assigning a per-target unique id to each message sent to that target. This id can later be appended as part of sysdata, allowing targets to detect dropped netconsole messages. Update count_extradata_entries() to take the new field into account. Reviewed-by: Breno Leitao Signed-off-by: Gustavo Luiz Duarte --- drivers/net/netconsole.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c index 1eb678e07dd0..5f8c8c6c5393 100644 --- a/drivers/net/netconsole.c +++ b/drivers/net/netconsole.c @@ -113,6 +113,8 @@ enum sysdata_feature { SYSDATA_TASKNAME = BIT(1), /* Kernel release/version as part of sysdata */ SYSDATA_RELEASE = BIT(2), + /* Include a per-target message ID as part of sysdata */ + SYSDATA_MSGID = BIT(3), }; /** @@ -782,6 +784,8 @@ static size_t count_extradata_entries(struct netconsole_target *nt) entries += 1; if (nt->sysdata_fields & SYSDATA_RELEASE) entries += 1; + if (nt->sysdata_fields & SYSDATA_MSGID) + entries += 1; return entries; } From patchwork Thu Jun 12 20:02:16 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gustavo Luiz Duarte X-Patchwork-Id: 895793 Received: from mail-qv1-f47.google.com (mail-qv1-f47.google.com [209.85.219.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DE702E2F1B; Thu, 12 Jun 2025 20:03:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749758605; cv=none; b=su12do5IIc5e2DWTnX0C00qqW2vFPfSdB1mxaU07uApWkvIP9qVaNrNekUnjaBTdH0tY5sK8O0xCebHE/mPQRYmbG5TQTGUaM0blKBBty4rgXQwXh5iAbBl33IBxycYOqvjhVlgAMkgoOltqKKfirBKU+wHKTwpg8GdImXsJShQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749758605; c=relaxed/simple; bh=nhD7nQP1armvamJAdav9d2T+px7RNCdUFLeEb9HZweo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lZNQDkyw9QZwIkhchDYuG6nms7W+a+hieqZ5Ef7Qbim3WG9mgDE983q4UGaZTfjCNNRGN+olINscVUA/YM7qBwRNLIEU877XKXCdlaB25/s1UWJjv90SS39QzqJCIsuxiMqRCE9coLjPZHPJ5PZ0dUasOdZdlf1bEg45aU6/Sco= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cMwlhDGW; arc=none smtp.client-ip=209.85.219.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cMwlhDGW" Received: by mail-qv1-f47.google.com with SMTP id 6a1803df08f44-6fb0ac80aaaso409946d6.3; Thu, 12 Jun 2025 13:03:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749758602; x=1750363402; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ss/uhQhN6lUEhvR/FJ2esBhszQQF0E4wT4q6/teIq64=; b=cMwlhDGW//LYV29l/hO/0NhoWb1BjmsBQzLdmLyr2K9+gI3Z4F2v3iAYfqFOMKWSHZ KFctZUFz+4Fnc1Yh5LQcdjo2oMSB9hB8TasfJ/+R5OAB5Wx6dX0eFvF97uXX+SO1c6n1 ogTSTO/LC5KWo7D6UDA+n94+j1CGYW2U75/5mKC5mROqdMsWxzU38QHOEA59L/Ws8wTj J+9sW/+KLw/Y9pXhFQSQEqUUom2znq5l/0DSL5m0jatvxLN2hLL0LTldVvxN9/Th0cNn SOwc5WMuScDCeX16HOzgRTKk36htkEpzBFmz5Y3mO7lkt3rB6kpHUXiZ2yR3md2NqBsS cAAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749758602; x=1750363402; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ss/uhQhN6lUEhvR/FJ2esBhszQQF0E4wT4q6/teIq64=; b=uH1sSgdWXWu7vai6Hx8FRTJ9JuyNLPZYJemP09PcgwHXP/0UUZr+g3A0WgyjS4IHX7 qDC6m0nq2ZOzqnxtf5O5kW6STvRi6in0uCNLwnrhNhEzqT2hPIIxA9TJGRbFGpec2mS9 m82+dkWaf460T/kj0N8gCP2VNc3pTbo/LOw+seBqMzI8bdVa3QLf5bUewxG+7P/ka3Kh 7aD4g+LpWujc65/k/HGYMzA5dmAQyWfcQ/dnWo683xpIae251eGnxHhJKSy+hE4qAC+a qecf5bvV9AFbKdM63TSJiQeDCKk/v984wSkA2h5u745K4BjN+pLQIgkAPoXC0XXsBpSw 6TQA== X-Forwarded-Encrypted: i=1; AJvYcCUQtIwBroEqnkpN91qQcSkFCxFLm5aVwVV8z513obOuwfGclbk8MdZzVM6qpBUloUXCST1Xv0+cUv18H65a@vger.kernel.org, AJvYcCWUPYMYsGY6LWWp18QBoDOHgmEPp4RBlUbdGXGhZsDgBbe36mQZbc3S5RyCqogqKg122X8ZmaNRmtcbhHXc2dY3@vger.kernel.org, AJvYcCWnFQ2STlBi0HbF6Po+mdmRYjHuKjZ+FOOsymvYM9sHRonbslRnyxXpjj12joxP8xYbJv7nVjqYEGY=@vger.kernel.org X-Gm-Message-State: AOJu0Yz3xUQOnm/QPOky7o81I6LBwmgrEBc9gcvoBf3vZMSMfXNoSYxO Ex+AxbyOKBAJ2gvV2kzYUkdvupCFw29dzpoFUO+626i78BVFGpHxmrgixjr0OzcecCQ= X-Gm-Gg: ASbGncsKiC5qn6Vwb4sHgoN8OHAFoqlLNWxkPVxCK5gX3EMO8FQwHW2T6fOYKZKI1+K 9LfmmRepd6E5kWdPc41foLEW3td39TosaW1gsGgy2Efj3sjbuV/GvF4hOIZPh5EEd81P5XmUV5K bMWtmKGZo02HLqJpZ0pdAzlO5ulFjkXyjVewdEK4HGaPdeQR6PqtFYk9pV8vALKOisZXoJnIwwJ f0UuPBPDabEu1eDziBouNrapYjzwQOVjwKaxorwn+fjMOfAP6UYU67Pl4lu0+C7NPdllETdhE5H GD3wg0sFsTOoT2D7WkZLbfTRMRln04R9pyAWYrQ/+D58dXDR7qBE+EY= X-Google-Smtp-Source: AGHT+IH9GjdEeMuR/Q5I7mjdit9VX01tOQlZz5H6NKrZw+S6Pvq9hyczKt6X5IFUSwrczAifaz1J0A== X-Received: by 2002:a05:6214:2462:b0:6fa:c22c:f10c with SMTP id 6a1803df08f44-6fb3e665ea8mr837136d6.7.1749758602131; Thu, 12 Jun 2025 13:03:22 -0700 (PDT) Received: from localhost ([2a03:2880:20ff:5::]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6fb35b20f5csm13824086d6.21.2025.06.12.13.03.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jun 2025 13:03:21 -0700 (PDT) From: Gustavo Luiz Duarte Date: Thu, 12 Jun 2025 13:02:16 -0700 Subject: [PATCH net-next v2 3/5] netconsole: append msgid to sysdata Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250612-netconsole-msgid-v2-3-d4c1abc84bac@gmail.com> References: <20250612-netconsole-msgid-v2-0-d4c1abc84bac@gmail.com> In-Reply-To: <20250612-netconsole-msgid-v2-0-d4c1abc84bac@gmail.com> To: Breno Leitao , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Shuah Khan , Simon Horman , Jonathan Corbet Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, Gustavo Luiz Duarte X-Mailer: b4 0.13.0 Add msgcounter to the netconsole_target struct to generate message IDs. If the msgid_enabled attribute is true, increment msgcounter and append msgid= to sysdata buffer before sending the message. Signed-off-by: Gustavo Luiz Duarte --- drivers/net/netconsole.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c index 3bf8777fcd01..baa9862c1bc3 100644 --- a/drivers/net/netconsole.c +++ b/drivers/net/netconsole.c @@ -155,6 +155,8 @@ struct netconsole_target { size_t userdata_length; /* bit-wise with sysdata_feature bits */ u32 sysdata_fields; + /* protected by target_list_lock */ + u32 msgcounter; #endif struct netconsole_target_stats stats; bool enabled; @@ -1345,6 +1347,14 @@ static int sysdata_append_release(struct netconsole_target *nt, int offset) init_utsname()->release); } +static int sysdata_append_msgid(struct netconsole_target *nt, int offset) +{ + wrapping_assign_add(nt->msgcounter, 1); + return scnprintf(&nt->extradata_complete[offset], + MAX_EXTRADATA_ENTRY_LEN, " msgid=%u\n", + nt->msgcounter); +} + /* * prepare_extradata - append sysdata at extradata_complete in runtime * @nt: target to send message to @@ -1367,6 +1377,8 @@ static int prepare_extradata(struct netconsole_target *nt) extradata_len += sysdata_append_taskname(nt, extradata_len); if (nt->sysdata_fields & SYSDATA_RELEASE) extradata_len += sysdata_append_release(nt, extradata_len); + if (nt->sysdata_fields & SYSDATA_MSGID) + extradata_len += sysdata_append_msgid(nt, extradata_len); WARN_ON_ONCE(extradata_len > MAX_EXTRADATA_ENTRY_LEN * MAX_EXTRADATA_ITEMS); From patchwork Thu Jun 12 20:02:18 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gustavo Luiz Duarte X-Patchwork-Id: 895792 Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD7B92E6D0D; Thu, 12 Jun 2025 20:03:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749758612; cv=none; b=oykDLHeFqGybBA7eosJ06LVHYtp0L98BVxAp6ehVyUyWLkePCKLa1JhbnPt7N5sWgMe8IjyS36mmGqw8b9cu8e0agy4szLegwMJAo3l8EdFynHoedKfD2SvF3C58I8PlzCVrkV2xBi8uJKZAXhkAS9K1pUG89RDkdJg0+pJU2K0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749758612; c=relaxed/simple; bh=1fykyusYVro73+SkCEdouTI5VeesZrBsX99TGTggxRY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=GAAyAvv9lIXR3cz9HD2ThZaq1wzxKon+gChUVXXxi1VS9gRNQTL5qia+sq33ISLlSHYpXpzqsL5ysojx4mu5xqIY/L6wkigRRZz6sLFSeySMdcZGyZJ+Sikqb7I3P7YpG/PICLspat9ZGSThXfsH6IMbWm/xtRdHwgRXi0HSLzM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=W4sHbK8R; arc=none smtp.client-ip=209.85.222.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="W4sHbK8R" Received: by mail-qk1-f174.google.com with SMTP id af79cd13be357-7d393a42698so13740885a.2; Thu, 12 Jun 2025 13:03:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749758610; x=1750363410; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ZnKjnGPQVsYruwW26IKQXjP4KtQDe+H/2EepWEDvdH4=; b=W4sHbK8Rs5KCcGme9De5sqRir3UOA9vOZUcGmoOpf2cdZ8eVtjOlxadBwoa6UdY4qA vhv59KXx9PALywRfJr53obg2XymxjiHUWtZtVr5731rN5HyxE2R1NpUM85oNbzaafcrN VrvTpUCkIrV7HSSsCtVA8D2pyJ/IMq5Gwn6Cd1Rtex/VX4UtFGsn0WQdwxybAF5AesVk LT7hYM/v4q+OwU1ZZqFzpQbQs7Z6cvfqwmfpanM950fUjwV3G69dlKjS+VUFniiIuAnj cNFRaZasw117y0uEdrX59SoR6U3rvV92aAMU7lxT/gLn2YABxYYdzqpu/62udPRs10PC sL2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749758610; x=1750363410; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZnKjnGPQVsYruwW26IKQXjP4KtQDe+H/2EepWEDvdH4=; b=FYSb8ZBs+T1hBE7+4cYhBLcBcbUsfBomS5S2hjArW3N8znEvxz2bYAgCrW6iV6cfgg NNZJCP+1wYUnCsuvxuLDQ2kdL4AbWfPrekuhFenU8xGk8R82rh4cPA8jV9qk7gpsDn7s uaywj8UzIhW6/Q9xg0s4tqsa5fp0hffB9fTdf+TwfH35F58BtgwArrHFMxky1YZffq5M WYJC20eWBLQW/CsGtCtVBh1dE0vszMTY8FtcXzcvMX9xoL16PPT+6gjTkvv0KPwpaXop Dqt9aDaCYwZQJ0ggzrcZuYR3RfUJAI+Y+zgi8MM5bFcOHl4E8pIDfgWoRb9yy/kc8vmy i9kA== X-Forwarded-Encrypted: i=1; AJvYcCUzCku/qJEjoT4lmmSJWlLQMDfvzF1PDby7z6diCIzUGlMT28rEjGicpfzSbLCTYSCEHxsFrhoAnVw=@vger.kernel.org, AJvYcCXl1hzb/7TtZYcgq1mRBp2EBAVnlSixPgi9lWp8MBDNQgigANkhltwwRwPdypncKccWOM55JgnLBxC7tbgB5yH1@vger.kernel.org, AJvYcCXpsFENXwt6XDuMBp8YzIRglxg0uGbDIZCrnOc9LSgbmYoA8xLExibsrgmpq3mJkUbF45KAZRpX02YRfoe7@vger.kernel.org X-Gm-Message-State: AOJu0Yzemp48UW2eRTE77l+NhFmWCXbXdMkhb5b+0I6XRfqrHonCSFLK h4VT5dRChQmGcbAOIhgXCj997Wl2MisvoE7U8Dnx1Zop4kL9/HWuOI1D/kEyEkYECYI= X-Gm-Gg: ASbGncv7uSNB/GwdM4f+K0mFi4sLBJxoYHT6kaFLmDKmp93cQlzBQpOmwizBJa23yGD 4X0HQj/NyvhAUMs7WLGZssRZmEdodbtGzznbH8nQvBo3TEZUMnJ6dulO29U+zxzjxL1/DJsCfEe lQwDpoDLnZfiyuBOl2xZYPaSzoAbTWET4A/B7Ot7lnZHosb1AU3GD3hlexvJQ9yyqQUqS3GboCO 6auBKHxFiiI9dD05tHpxoQHdkH9cztNgsosV+fUp64L+c4fWaVlVe8T4dMrA5zx8eVp8yC0POju 1fPKlWizcCqmKwJgpvbD9Etez1QpWPaRN7DB69i/9zhhV3QvV94L1/U= X-Google-Smtp-Source: AGHT+IEYJNouzQaBO57RIFJdSjytY+rAwJnE1qi8JXnfhXTA6dO5SUQ1nlRCfzkPu1uKMj9aLcCzVw== X-Received: by 2002:a05:620a:bc3:b0:7c5:79e8:412a with SMTP id af79cd13be357-7d3bc37d979mr35927485a.2.1749758609646; Thu, 12 Jun 2025 13:03:29 -0700 (PDT) Received: from localhost ([2a03:2880:20ff:1::]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7d3b8ed35b1sm77151285a.88.2025.06.12.13.03.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jun 2025 13:03:29 -0700 (PDT) From: Gustavo Luiz Duarte Date: Thu, 12 Jun 2025 13:02:18 -0700 Subject: [PATCH net-next v2 5/5] docs: netconsole: document msgid feature Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250612-netconsole-msgid-v2-5-d4c1abc84bac@gmail.com> References: <20250612-netconsole-msgid-v2-0-d4c1abc84bac@gmail.com> In-Reply-To: <20250612-netconsole-msgid-v2-0-d4c1abc84bac@gmail.com> To: Breno Leitao , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Shuah Khan , Simon Horman , Jonathan Corbet Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, Gustavo Luiz Duarte X-Mailer: b4 0.13.0 Add documentation explaining the msgid feature in netconsole. This feature appends unique id to the userdata dictionary. The message ID is populated from a per-target 32 bit counter which is incremented for each message sent to the target. This allows a target to detect if messages are dropped before reaching the target. Signed-off-by: Gustavo Luiz Duarte --- Documentation/networking/netconsole.rst | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/Documentation/networking/netconsole.rst b/Documentation/networking/netconsole.rst index a0076b542e9c..59cb9982afe6 100644 --- a/Documentation/networking/netconsole.rst +++ b/Documentation/networking/netconsole.rst @@ -340,6 +340,38 @@ In this example, the message was sent by CPU 42. cpu=42 # kernel-populated value +Message ID auto population in userdata +-------------------------------------- + +Within the netconsole configfs hierarchy, there is a file named `msgid_enabled` +located in the `userdata` directory. This file controls the message ID +auto-population feature, which assigns a numeric id to each message sent to a +given target and appends the ID to userdata dictionary in every message sent. + +The message ID is generated using a per-target 32 bit counter that is +incremented for every message sent to the target. Note that this counter will +eventually wrap around after reaching uint32_t max value, so the message ID is +not globally unique over time. However, it can still be used by the target to +detect if messages were dropped before reaching the target by identifying gaps +in the sequence of IDs. + +It is important to distinguish message IDs from the message field. +Some kernel messages may never reach netconsole (for example, due to printk +rate limiting). Thus, a gap in cannot be solely relied upon to +indicate that a message was dropped during transmission, as it may never have +been sent via netconsole. The message ID, on the other hand, is only assigned +to messages that are actually transmitted via netconsole. + +Example:: + + echo "This is message #1" > /dev/kmsg + echo "This is message #2" > /dev/kmsg + 13,434,54928466,-;This is message #1 + msgid=1 + 13,435,54934019,-;This is message #2 + msgid=2 + + Extended console: =================