From patchwork Mon Jun 16 19:40:19 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Danilo Krummrich X-Patchwork-Id: 896936 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57D42288C0E; Mon, 16 Jun 2025 19:44:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750103094; cv=none; b=cIFBl8hkgIl+u4Q4Lz2tn9BVAcFMEqJfzfUNRVXfl+LbOgB62O45HNURMQ/ThnHIzZPwv9yAy0TcOWvAg7LjpgmMKtETc0ZEL+90cWot9XLwlSkuWvpLohEICPDfimTYRC+zuijpErd5D3F9TzvYFaxAHlNxcSnMMigo6fhb3zM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750103094; c=relaxed/simple; bh=zcddzq/jaoCNyvRXu3ATje4IQQGcAABOvRGRXiVVJ7k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=txfMFBvkjqBcWIRhyb2gUqN2xvdlPvbZk8lKeGsfNyi46CgjPvve8EWGCBOJR1im6DwZaEjHKeGGWGE1fEKNTWigWS7BPpvOJShyL7ZM5QBx6QzJHRQaFTKMtVhzjbhZNyI7XjduDzWGn48CAOtILhsbbqKfwyf8yLtUsZ+UudU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YWhsitIG; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YWhsitIG" Received: by smtp.kernel.org (Postfix) with ESMTPSA id ABC60C4CEEA; Mon, 16 Jun 2025 19:44:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750103093; bh=zcddzq/jaoCNyvRXu3ATje4IQQGcAABOvRGRXiVVJ7k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YWhsitIGa0FpU1aIx1uoIhA8t0I9PSuU0+ox924JynJCGJ6Xp9N9GG122Do3SriZy oTsNS/WjEWO+ZAyf/tN+vU69sfvHVZfnX84b3IKqN+qJT2ta0rPhLsynRwxqKECDJJ k2kpN7POktZLXvSf42FzGKXsQbCaiw1hboTMsIsoevrLFO5fKQrO/V8MlSkKMDktpU H1Z7T18c9UJQBAilnHrHdnyCK8/KxAnJhFaoouf6o65Dko+V1xrhMCdyk/yd7Gt+dO o7OVJjNuu2oKhQHwvuOy9Vm/k8b/1CB2sAvY7Fy3kBlkNRGXkU60zvtouVSuASYK7U +X9JeYoFlKVTA== From: Danilo Krummrich To: igor.korotin.linux@gmail.com, gregkh@linuxfoundation.org, rafael@kernel.org, ojeda@kernel.org, alex.gaynor@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, benno.lossin@proton.me, a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu Cc: rust-for-linux@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Danilo Krummrich Subject: [PATCH 1/3] rust: device: implement FwNode::is_compatible() Date: Mon, 16 Jun 2025 21:40:19 +0200 Message-ID: <20250616194439.68775-1-dakr@kernel.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250613135407.1233005-1-igor.korotin.linux@gmail.com> References: <20250613135407.1233005-1-igor.korotin.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Implement FwNode::is_compatible() to check whether a given match string is compatible with a FwNode. Signed-off-by: Danilo Krummrich Reviewed-by: Dirk Behme --- rust/helpers/property.c | 6 ++++++ rust/kernel/device/property.rs | 9 +++++++++ 2 files changed, 15 insertions(+) base-commit: 2a1ea59de83bf367215e2a4dd9bf8bbd061349b3 diff --git a/rust/helpers/property.c b/rust/helpers/property.c index 08f68e2dac4a..177b9ffd7ba4 100644 --- a/rust/helpers/property.c +++ b/rust/helpers/property.c @@ -6,3 +6,9 @@ void rust_helper_fwnode_handle_put(struct fwnode_handle *fwnode) { fwnode_handle_put(fwnode); } + +bool rust_helper_fwnode_device_is_compatible(const struct fwnode_handle *fwnode, + const char *match) +{ + return fwnode_device_is_compatible(fwnode, match); +} diff --git a/rust/kernel/device/property.rs b/rust/kernel/device/property.rs index 838509111e57..a946bf8d5571 100644 --- a/rust/kernel/device/property.rs +++ b/rust/kernel/device/property.rs @@ -93,6 +93,15 @@ pub fn property_present(&self, name: &CStr) -> bool { unsafe { bindings::fwnode_property_present(self.as_raw().cast_const(), name.as_char_ptr()) } } + /// Return `true` if this [`FwNode`] is compatible with `match_str`, `false` otherwise. + pub fn is_compatible(&self, match_str: &CStr) -> bool { + // SAFETY: + // - By the invariant of `CStr`, `name.as_char_ptr()` is valid and null-terminated. + // - The type invariant of `Self` guarantees that `self.as_raw() is a pointer to a valid + // `struct fwnode_handle`. + unsafe { bindings::fwnode_device_is_compatible(self.as_raw(), match_str.as_char_ptr()) } + } + /// Returns firmware property `name` boolean value. pub fn property_read_bool(&self, name: &CStr) -> bool { // SAFETY: From patchwork Mon Jun 16 19:40:20 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Danilo Krummrich X-Patchwork-Id: 898015 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7FDA28A40E; Mon, 16 Jun 2025 19:44:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750103098; cv=none; b=W8acqCGOgz0KQKdSH2iWZz4fUwbiURyxNTqYXvBZEOFd8rrIUa6iLxHoHk9UoAJa6M39T0gIw+eJl5UUp3U5BXRejCCwn3mR6CU9s6OnALGBkJEDIvaN66d6lQTrJfgd6UIOhhFfgskF46sfp/qSRqTack/9iNva9KYYo3ulS0k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750103098; c=relaxed/simple; bh=Xe0INp48LTcwqCr5InqN8S+WZL2OaJHjHcHJ15QthgY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bKUyfsP4K1JtOv0mus8i9elAE71PmKZ425iw+STJdbPuBp2mzAjLHqzxLD+bHWlBOrjO+OaOZ0c57WMBFpz3UN6Vtm0sQ1NsGE9cCivYjfJWK+WQuqkbaXDeUqTQ7A0DL4zlfKuzaM8MHL5Or1krxyZVBp32kSdLLMaRewnednk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OWf70akD; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OWf70akD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 50833C4CEEE; Mon, 16 Jun 2025 19:44:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750103097; bh=Xe0INp48LTcwqCr5InqN8S+WZL2OaJHjHcHJ15QthgY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OWf70akD3FiLgaus9rVzHNqJvLHkKmGPZ54ZLk71AJt2u6mKI4sdDMAzinmk9t3cg 0H+POci6AzXW1CQTuU+iED5fjpeU/5/B3aKYfTwbsyHuHOiV0OrM/5bH2DFfUNxHl6 Qqkc6fJA+OAWJI4Ol/JbjE6qNoT8aT8rk3LmPwTfQzSCH8LnY6aPpivcA4zW5PA/z4 uR9usic1/JvCnD3huDcS80OnErQEhPHlyUGY3kgt2uHu+BWnoK1xlVJKYjphT563JB zbnNWz7WcU7KGolGHqn1j4Nx2jjKNT6v62RpQSDZTXxxuN+6jz6uZkaXAvjYMZrtCl nwlIhz13njghg== From: Danilo Krummrich To: igor.korotin.linux@gmail.com, gregkh@linuxfoundation.org, rafael@kernel.org, ojeda@kernel.org, alex.gaynor@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, benno.lossin@proton.me, a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu Cc: rust-for-linux@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Danilo Krummrich Subject: [PATCH 2/3] samples: rust: platform: don't call as_ref() repeatedly Date: Mon, 16 Jun 2025 21:40:20 +0200 Message-ID: <20250616194439.68775-2-dakr@kernel.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250616194439.68775-1-dakr@kernel.org> References: <20250613135407.1233005-1-igor.korotin.linux@gmail.com> <20250616194439.68775-1-dakr@kernel.org> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In SampleDriver::probe() don't call pdev.as_ref() repeatedly, instead introduce a dedicated &Device. Signed-off-by: Danilo Krummrich --- samples/rust/rust_driver_platform.rs | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/samples/rust/rust_driver_platform.rs b/samples/rust/rust_driver_platform.rs index c0abf78d0683..000bb915af60 100644 --- a/samples/rust/rust_driver_platform.rs +++ b/samples/rust/rust_driver_platform.rs @@ -32,13 +32,15 @@ fn probe( pdev: &platform::Device, info: Option<&Self::IdInfo>, ) -> Result>> { - dev_dbg!(pdev.as_ref(), "Probe Rust Platform driver sample.\n"); + let dev = pdev.as_ref(); + + dev_dbg!(dev, "Probe Rust Platform driver sample.\n"); if let Some(info) = info { - dev_info!(pdev.as_ref(), "Probed with info: '{}'.\n", info.0); + dev_info!(dev, "Probed with info: '{}'.\n", info.0); } - Self::properties_parse(pdev.as_ref())?; + Self::properties_parse(dev)?; let drvdata = KBox::new(Self { pdev: pdev.into() }, GFP_KERNEL)?; From patchwork Mon Jun 16 19:40:21 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Danilo Krummrich X-Patchwork-Id: 896935 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3ACC128A1D6; Mon, 16 Jun 2025 19:45:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750103101; cv=none; b=tEYfYZUY4RtcybaGsXSgRMUNddlI7/wguACpo0OgoLQ66hSUadadqn6U6q1UlwAYZk257ZaAfci7lzZlpwZ93KUIPfyeALUFdRZt3kSrDUIda3Y/IqCEgEVGNv6KRSAViDiPyX5/zR8dcWwrxVaLKyiJEx6fbXoQD9pAxcx2yFA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750103101; c=relaxed/simple; bh=Xr330VJZ59GqasSbBRpzL/AsW35MswJhQCbz4Ie7Ip8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=L84jtbRIkOEXP6GwKb1d0KBdLIhwX9Qs9QTHTkyvUydMcCGX4gOJT03IGb9No1OC6I8qfJPfqrK/U2hY3qi3c4FtekRC5qVBElpZdZgHUmVXJ1Djh4kIxI0cGX+5WtdHtzngfUnvlgBuu06gmWHXZ9zCbuktuZreENg429bcihU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=vB+wNGJd; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="vB+wNGJd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E2462C4CEEA; Mon, 16 Jun 2025 19:44:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750103101; bh=Xr330VJZ59GqasSbBRpzL/AsW35MswJhQCbz4Ie7Ip8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vB+wNGJdTskadDBPNPnJJS5U7SJuMNFtITj7ZFtVUlQeB3weIaCLuCbjI7zg9asK3 lg6y6HZHiNfOOi9olpoCGntfywbOwHcV1wPz03hu6ncuCpn4X7hLsrVTsdiSmk31XL Wy1HU1NJpDWATyeyPuG7MLxI9ckItv0h/9HXTsq+qvG06XhQlLlWtczT5DsBoZ8kx8 3U/3SQhBvJg4bhhAOyitoHmrtqb8ZF8mDBClYsT3Hsy/pH0wonmUm06fGvr0+Spkkn SHwveQ865QwWNTlnaOiKnajNs9rf5+j/4NzZwvHx0SNWVR5S8K5D7A68jGCdhGUBRZ QHKz5J5bVYOPg== From: Danilo Krummrich To: igor.korotin.linux@gmail.com, gregkh@linuxfoundation.org, rafael@kernel.org, ojeda@kernel.org, alex.gaynor@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, benno.lossin@proton.me, a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu Cc: rust-for-linux@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Danilo Krummrich Subject: [PATCH 3/3] samples: rust: platform: conditionally call Self::properties_parse() Date: Mon, 16 Jun 2025 21:40:21 +0200 Message-ID: <20250616194439.68775-3-dakr@kernel.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250616194439.68775-1-dakr@kernel.org> References: <20250613135407.1233005-1-igor.korotin.linux@gmail.com> <20250616194439.68775-1-dakr@kernel.org> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Only call Self::properties_parse() when the device is compatible with "test,rust-device". Once we add ACPI support, we don't want the ACPI device to fail probing in Self::properties_parse(). Signed-off-by: Danilo Krummrich --- samples/rust/rust_driver_platform.rs | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/samples/rust/rust_driver_platform.rs b/samples/rust/rust_driver_platform.rs index 000bb915af60..036dd0b899b0 100644 --- a/samples/rust/rust_driver_platform.rs +++ b/samples/rust/rust_driver_platform.rs @@ -40,7 +40,12 @@ fn probe( dev_info!(dev, "Probed with info: '{}'.\n", info.0); } - Self::properties_parse(dev)?; + if dev + .fwnode() + .is_some_and(|node| node.is_compatible(c_str!("test,rust-device"))) + { + Self::properties_parse(dev)?; + } let drvdata = KBox::new(Self { pdev: pdev.into() }, GFP_KERNEL)?; From patchwork Fri Jun 13 13:54:07 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Igor Korotin X-Patchwork-Id: 898018 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46F7A19B5B1; Fri, 13 Jun 2025 13:56:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749822975; cv=none; b=Hxfg+3AlrkG1u5+c4CCid8TmgBQaQSt7tpRGBBSk993IHkTAEzSYxamm5DDdAuQhBohAk84VNczM5R4oMQSiTMTL6Dm7DD25KFLHSRxpKYwGIQouraU8nr0nzkmdbuzAHayhGBfCNZm4b5dFq+Q3xVyWgyP4+hLnAeitIKLWhtc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749822975; c=relaxed/simple; bh=5+kbWDXXq4IG8sDuXqes6a43G6RDWXt2POCGQmcpyOc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VQ7RrU1SMlgtKb2iiiUfZKID63qg6gnjEpXcQrwSr5b6J3RJKFne4CNTbGhZszHpw5z2BsAfpMvl0IRcvzyPHNl4AuMHLEpHW1pv792quk5DbRI7FYIM2VnhMl2QdZS6Tw4pXIeR5AxjNI1AdIpyWAri83W/xua7YDMJkL/MzjI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jRUMvw6W; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jRUMvw6W" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-442fda876a6so18932965e9.0; Fri, 13 Jun 2025 06:56:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749822971; x=1750427771; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=iuauSSTqx1TDFESDgGFVyFslKTU+wwALp8k7RA41ffM=; b=jRUMvw6WisV+ILtgTMas4DgTJTEiYQxV3Hzm/l6ykxsTgDHvOCUOPS8k3g+w0A4xdy BFyQBSBWqBDBV6oC8wAHQqZaNQkdCfxzno+K4BitIkbEefOJGICEHN+nA8cXz98uwtmb p6Gt1VQGdlBHoJyVBWw8gfnPhaCk79nYQ0Ar4XXNGIRSahDM25kV3HHUaJq3SLwX9vGw 77/07mrhdMuymd7F7J/jj6uIfkC23xUtqMsTqCWgXoML4G66pRiRH6xsDTYNqdT4X2MC VK2rpCkCJq0kAQJ7ND8TR8s7FZDvOIBX9swBFGE9pORDqetlnT3wJpbmwlA4BK9PX3lg YUug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749822971; x=1750427771; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=iuauSSTqx1TDFESDgGFVyFslKTU+wwALp8k7RA41ffM=; b=MoPAFXQhCzafSyAOmmoB1DxNuil7ZX104/ush2znxxIaupQLZBZLBotkQlvZZ2Jx7H eCr0IfM4TlJehTxdYYU6G7bSiPTAXLWowpN9iZlS8EQwTuIUGHdt45Va9Yu7aoops5YG 4rNrLXZAz2DK6KKzWJKIT3cSWpNj/qTcZNvSXPSUnrMuDPYiAO7fHxXvyNRxzTZYyYZ5 uGijrT6tzbjsj0iIH+9rTNSvRjQhsypXRgutBFbVFYbp5gKqdmo4gHvQ/OsK/oZxgf8v wgAwUV14/My6UYSGxbN+cRToR4R6zcEAZTTeSxwxin+d/E4bIoJw24rfyKRTPQblC6Ya FCYw== X-Forwarded-Encrypted: i=1; AJvYcCUtRKb+5/v1k4mo9JaiM2JOX9zp4iSCIbIartapHopbinSE8bxO+9mPDKpjGVea4C10wwpFE/0LDTMN1NWi3to=@vger.kernel.org, AJvYcCWk48ICRaf2wdB3pwYQDYtLwp++BlBdMI4VE4jvjIPLAO5f0UGH8qAIitX5IpcrzyYJZ9iwtMrzi35e@vger.kernel.org, AJvYcCXEFuLNC7rb+Rq8iOJkETTCtoNAwXuSJuVbhHQxoWBi0pPYVJpzU6uAA/fSnZwZVnr+ssEhv3McUDh5/cda@vger.kernel.org X-Gm-Message-State: AOJu0Yyz+27auW6SsGqhycFQ9jjm6RwYjx6ZI0dZ8UFK3ZnRbIsx3HHy VWmxOQbpzw/W9KXMqeXASFAW6bR/RuRHFvaV5DHCNcrGPSPGbTryVSrZ X-Gm-Gg: ASbGncvHr1zSEMMmzsI8Oyvnqk+jY8VcWQzcbMM5BXVO3zZ1k6xL68G7/gHWx8AO2m+ xB2pfhMjEqqL/IRchN2FNlX7cN8hESxljJV8jfl4whPD3mOps9tvXEs27Dw9jaK0X4lTDfzxbjN FW8LWmC5wR8EcCmfGpm5oIuDo6OazRk5oIqv98c5NQEMmgY83VavzyM7WhYIk0FqXQlWYsp7b7+ bzxQKagKfdutzaevgfT7bn+LPJxDS9bH6wPDwDBywpXRUMbMz1xVTiQB1d7pQbYbWDJFU5BSGeI E5KyfTVUUSNuL4a8AKaL2BK9QsIsdkFu4YU+sRzy4F/6J+GpNTr/VIkj3WjFCib4P50xxpP1tRn VhaiNznvGPj3OWG5vIWXdt7huCdjlaGGS8kSF X-Google-Smtp-Source: AGHT+IGTzyy552+tppB1feCaA+V2C1A6hMR43WFjhXbodmqD/BBCl9OoHG4w6shHYXb2kVogl4oGFQ== X-Received: by 2002:a05:600c:3f16:b0:450:d104:29eb with SMTP id 5b1f17b1804b1-45334ab20e4mr31162545e9.5.1749822971229; Fri, 13 Jun 2025 06:56:11 -0700 (PDT) Received: from igor-korotin-Precision-Tower-3620.airspan.com ([188.39.32.4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4532e195768sm53600045e9.0.2025.06.13.06.56.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jun 2025 06:56:10 -0700 (PDT) Sender: Igor Korotin From: Igor Korotin To: ojeda@kernel.org, alex.gaynor@gmail.com, rafael@kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-acpi@vger.kernel.org Cc: boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, benno.lossin@proton.me, a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu, dakr@kernel.org, lenb@kernel.org, wedsonaf@gmail.com, viresh.kumar@linaro.org, alex.hung@amd.com, dingxiangfei2009@gmail.com Subject: [PATCH v6 6/6] samples: rust: add ACPI match table example to platform driver Date: Fri, 13 Jun 2025 14:54:07 +0100 Message-ID: <20250613135407.1233005-1-igor.korotin.linux@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250613133517.1229722-1-igor.korotin.linux@gmail.com> References: <20250613133517.1229722-1-igor.korotin.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Extend the Rust sample platform driver to probe using device/driver name matching, OF ID table matching, or ACPI ID table matching. Signed-off-by: Igor Korotin --- samples/rust/rust_driver_platform.rs | 71 +++++++++++++++++++++++++++- 1 file changed, 70 insertions(+), 1 deletion(-) diff --git a/samples/rust/rust_driver_platform.rs b/samples/rust/rust_driver_platform.rs index 8b42b3cfb363..35d5067aa023 100644 --- a/samples/rust/rust_driver_platform.rs +++ b/samples/rust/rust_driver_platform.rs @@ -2,7 +2,7 @@ //! Rust Platform driver sample. -use kernel::{c_str, device::Core, of, platform, prelude::*, types::ARef}; +use kernel::{acpi, c_str, device::Core, of, platform, prelude::*, types::ARef}; struct SampleDriver { pdev: ARef, @@ -17,9 +17,78 @@ struct SampleDriver { [(of::DeviceId::new(c_str!("test,rust-device")), Info(42))] ); +// ACPI match table test +// +// This demonstrates how to test an ACPI-based Rust platform driver using QEMU +// with a custom SSDT. +// +// Steps: +// +// 1. **Create an SSDT source file** (`ssdt.dsl`) with the following content: +// +// ```asl +// DefinitionBlock ("", "SSDT", 2, "TEST", "VIRTACPI", 0x00000001) +// { +// Scope (\_SB) +// { +// Device (T432) +// { +// Name (_HID, "TEST4321") // ACPI hardware ID to match +// Name (_UID, 1) +// Name (_STA, 0x0F) // Device present, enabled +// Name (_CRS, ResourceTemplate () +// { +// Memory32Fixed (ReadWrite, 0xFED00000, 0x1000) +// }) +// } +// } +// } +// ``` +// +// 2. **Compile the table**: +// +// ```sh +// iasl -tc ssdt.dsl +// ``` +// +// This generates `ssdt.aml` +// +// 3. **Run QEMU** with the compiled AML file: +// +// ```sh +// qemu-system-x86_64 -m 512M \ +// -enable-kvm \ +// -kernel path/to/bzImage \ +// -append "root=/dev/sda console=ttyS0" \ +// -hda rootfs.img \ +// -serial stdio \ +// -acpitable file=ssdt.aml +// ``` +// +// Requirements: +// - The `rust_driver_platform` must be present either: +// - built directly into the kernel (`bzImage`), or +// - available as a `.ko` file and loadable from `rootfs.img` +// +// 4. **Verify it worked** by checking `dmesg`: +// +// ``` +// rust_driver_platform TEST4321:00: Probed with info: '0'. +// ``` +// +// This demonstrates ACPI table matching using a custom ID in QEMU with a minimal SSDT + +kernel::acpi_device_table!( + ACPI_TABLE, + MODULE_ACPI_TABLE, + ::IdInfo, + [(acpi::DeviceId::new(c_str!("TEST4321")), Info(0))] +); + impl platform::Driver for SampleDriver { type IdInfo = Info; const OF_ID_TABLE: Option> = Some(&OF_TABLE); + const ACPI_ID_TABLE: Option> = Some(&ACPI_TABLE); fn probe( pdev: &platform::Device,