From patchwork Sun Jun 15 20:55:05 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tamir Duberstein X-Patchwork-Id: 897159 Received: from mail-qv1-f54.google.com (mail-qv1-f54.google.com [209.85.219.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1ED6C280314; Sun, 15 Jun 2025 20:55:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750020916; cv=none; b=gU8Ha0F9Q8NYdzyIXPY8IcCLFA0HH1TLe3+CDtQ875gjn7Tf0JQp7wnUs1DHgalaLd1Jvw7bEKmLriYIuLq3IWJauenaDbfd2UDIUdzDct8IeeNJBmgBR3L4eqUUS7lSWbNlqzQroLHQnIwHv+fSe96s3od3tv1FpxpydEeWOiI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750020916; c=relaxed/simple; bh=Z1WZVxpuHmE1ZQSxt13n1t7H3AxNePD6nxUc36wIlfY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ut/WwfQleI++Y6hoGl2xLhp6cp6OpoLW+HaRGEmZC+V9mVh+hQ3Dr/Gv55A42wpPWYh8TUzUApMSekDtZqxZmF4x7fR70jxc0fvoUEw61vrYvLcsTBfU9YstBFxc3lBiT5SbT8MihCfGzxa9cNwX0d93LHQO8Cf1aquOutQwBEQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Lv794DGm; arc=none smtp.client-ip=209.85.219.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Lv794DGm" Received: by mail-qv1-f54.google.com with SMTP id 6a1803df08f44-6faf66905adso20730616d6.2; Sun, 15 Jun 2025 13:55:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750020913; x=1750625713; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ezdiXk3y+/AEw6Ox96nDXZDiisIAangHTqyxnDuWGys=; b=Lv794DGmSL8DX6ykGNxWNhzs6fq/vSyFhdcbLQMOVuNvkRZUKTgCLHZ15FhYC7hAbE 9WLZAJetsPmPRvJuq6y1+VfmZ/Qbz6qXFPtzS2WG98G9B51gQccpRHzff5IcD1CNhxZ7 t4LTPGFgWdVTrIlQ1o/+PKkmecaIm0Iu6K3WB0274o1d0zSHf5dop6mDlagOvNbMV24y /Th7dMbvf4yvn748+dXWcvynWT2jToioO8n55sCgpE1ctsnPZJbdUy+22XlPQLtufNBb ASrFxXchdNclceWb8dpFd53Qk46UqtRCEdwRr7sfvSTUZDlwMyl8vGRmjTHedSfC1ofb bgeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750020913; x=1750625713; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ezdiXk3y+/AEw6Ox96nDXZDiisIAangHTqyxnDuWGys=; b=UZHtFfsp7yi2iLlB6CRCdoCadpsaju9wcdSVpG/QK1+swOiKJ0HWILZwxRrMtlsyYP VXwM+CqYjTB8Yhl1+rUpOJiHEWeo7UYzYgX2dO6JBu2VlzaGAxRTOqC9CcNmMRjg6mUI PRuoWDLBh2zLNGqK6Rbe4P2oYYisSF1r4TIGLzktLYW7UsN2xwEGqZuWFj8V1QmG8v3Z P0RZODY4XxGYyR1zd2ykk6cNN5AQapdZc3lccpmVyJAPTpv2Sc7BNT6/01j76kWQugMO GWN7+8CGXAZH/+4RRaYosPuC/gvTzN7KR8UFFHqIW3ZEwWBc8istd5Gv2I2AaiZ9jXF2 UuuA== X-Forwarded-Encrypted: i=1; AJvYcCUNZsqqSOLhJBoCLpUphNYCpJMHnv8Q3DYEx/i2ndO2A6pECiq+hOCw+wILo9aOgsRbx7uLB1DRuMQtLQyNNqS6@vger.kernel.org, AJvYcCUREHItgp73FK/fjghPM3jFv4/cnN5t6oBsHWqBR90SE7gq2DRLPvn8+vnutSELjx6UMXa3Q7PDx8s=@vger.kernel.org, AJvYcCV3e1FIiXHofBU+lJ59/TknBDHo5qd/z2DRunAE4OebPf0AokyAyDn67wS9yhsw86wQV+ZP3M+UnX3lHcg=@vger.kernel.org, AJvYcCWQngbe+FyZF3PM9KlKW5J7t78yUbho5XyOIEVGuGfgX8pHldwtFmK9tZnCWQ5It7ociIfSVJFfSQvDSza+@vger.kernel.org, AJvYcCWdM1bCC8YyVXjHNPoNojpELfEMcNlwM/B/tc2bHV7S39n5YLfGMY8blrKAmIKIqzH6xOtKgplq/FUuy+CfNtc=@vger.kernel.org, AJvYcCWo0VXJbE7/C/t4pgK99dVKsJSK22fyp9yEV0BjOfddxLRPWjrVB7PVQq5725D3jy3e5A2dkTX7@vger.kernel.org, AJvYcCX9BDnRNFeY0QmIthFjWiHDV6DWHkma9JJyBkubJzxmKeS8WD9lybW/xeNf2kbEx5qKynymVq0npCkF@vger.kernel.org, AJvYcCXjVHwlGHWQIWDHtvsO0rYhOXyqKlpZSh83JrtQwVQg0Wn9sXPq/uZjsneS1adSnaFuXS4is6FasxzN@vger.kernel.org X-Gm-Message-State: AOJu0YyQGAq7cthp89akY1MEWDiypc9Zucp2LiOPGHP84nQissuIZAEe qtm6a2+g/0RqU589vFsl4ct4FYAckIKr767eohAUSt/79o1ZdgrREKl0 X-Gm-Gg: ASbGncuSwTLzQX5+nmQ0td1Q4fIX0YQ1Yr1XnFzGF2bWGpm2q+jStP3QV2VyMTlmkKx po+70ttxKTh/AhZ5hrIecYhr+9KJ6Hj9Oo3WMq3Kffs3f+tahD815m4YPjP/E6/Njdp0j0o9sTf 1wWfzFvAN1Q0vOWtwPYUBkbptQYNbI/JbjbfqTIRr211AUBjS5pL7geo4e4zQZgnquIoiWMl+UL u9DHqpzjC1wYu4B0V5lWQx8WeHblnewSGpNJp63l9mES0TyfHqqOs4ng4BRe9jmlz9CeCXy6oPv u7dF7FvUnim+0QjVgFOiOCjOVSH6MSaLRnITnqV9UCIPzQ4IbMcSE3vCGuluIM1dOTHg3Pgn53M 5zSLV X-Google-Smtp-Source: AGHT+IFJgdjmpAWaWHvOd/OzUar9HJMZOiE/PIXu+R/hLZI5MOC1WTPF1Tj/M8HijfTBs7H4eutxLQ== X-Received: by 2002:a05:6214:3389:b0:6fa:ce87:230c with SMTP id 6a1803df08f44-6fb47770502mr109110916d6.25.1750020912752; Sun, 15 Jun 2025 13:55:12 -0700 (PDT) Received: from tamird-mac.local ([2600:4041:5be7:7c00:b0c6:92db:d807:21a6]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6fb35c84148sm43468176d6.109.2025.06.15.13.55.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Jun 2025 13:55:12 -0700 (PDT) From: Tamir Duberstein Date: Sun, 15 Jun 2025 16:55:05 -0400 Subject: [PATCH v12 1/6] rust: enable `clippy::ptr_as_ptr` lint Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250615-ptr-as-ptr-v12-1-f43b024581e8@gmail.com> References: <20250615-ptr-as-ptr-v12-0-f43b024581e8@gmail.com> In-Reply-To: <20250615-ptr-as-ptr-v12-0-f43b024581e8@gmail.com> To: Masahiro Yamada , Nathan Chancellor , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Greg Kroah-Hartman , "Rafael J. Wysocki" , Brendan Higgins , David Gow , Rae Moar , Bjorn Helgaas , Luis Chamberlain , Russ Weight , Rob Herring , Saravana Kannan , Abdiel Janulgue , Daniel Almeida , Robin Murphy , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , FUJITA Tomonori , Nicolas Schier , Frederic Weisbecker , Lyude Paul , Thomas Gleixner , Anna-Maria Behnsen , Benno Lossin , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , John Stultz , Stephen Boyd , Lorenzo Stoakes , "Liam R. Howlett" , Breno Leitao , Viresh Kumar , Nicolas Schier Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-pci@vger.kernel.org, linux-block@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, netdev@vger.kernel.org, linux-mm@kvack.org, linux-pm@vger.kernel.org, nouveau@lists.freedesktop.org, Tamir Duberstein , Benno Lossin X-Mailer: b4 0.15-dev In Rust 1.51.0, Clippy introduced the `ptr_as_ptr` lint [1]: > Though `as` casts between raw pointers are not terrible, > `pointer::cast` is safer because it cannot accidentally change the > pointer's mutability, nor cast the pointer to other types like `usize`. There are a few classes of changes required: - Modules generated by bindgen are marked `#[allow(clippy::ptr_as_ptr)]`. - Inferred casts (` as _`) are replaced with `.cast()`. - Ascribed casts (` as *... T`) are replaced with `.cast::()`. - Multistep casts from references (` as *const _ as *const T`) are replaced with `core::ptr::from_ref(&x).cast()` with or without `::` according to the previous rules. The `core::ptr::from_ref` call is required because `(x as *const _).cast::()` results in inference failure. - Native literal C strings are replaced with `c_str!().as_char_ptr()`. - `*mut *mut T as _` is replaced with `let *mut *const T = (*mut *mut T)`.cast();` since pointer to pointer can be confusing. Apply these changes and enable the lint -- no functional change intended. Link: https://rust-lang.github.io/rust-clippy/master/index.html#ptr_as_ptr [1] Reviewed-by: Benno Lossin Reviewed-by: Boqun Feng Signed-off-by: Tamir Duberstein --- Makefile | 1 + rust/bindings/lib.rs | 1 + rust/kernel/alloc/allocator_test.rs | 2 +- rust/kernel/alloc/kvec.rs | 4 ++-- rust/kernel/configfs.rs | 2 +- rust/kernel/cpufreq.rs | 2 +- rust/kernel/device.rs | 4 ++-- rust/kernel/devres.rs | 2 +- rust/kernel/dma.rs | 4 ++-- rust/kernel/error.rs | 2 +- rust/kernel/firmware.rs | 3 ++- rust/kernel/fs/file.rs | 2 +- rust/kernel/kunit.rs | 11 +++++++---- rust/kernel/list/impl_list_item_mod.rs | 2 +- rust/kernel/pci.rs | 2 +- rust/kernel/platform.rs | 4 +++- rust/kernel/print.rs | 6 +++--- rust/kernel/seq_file.rs | 2 +- rust/kernel/str.rs | 2 +- rust/kernel/sync/poll.rs | 2 +- rust/kernel/time/hrtimer/pin.rs | 2 +- rust/kernel/time/hrtimer/pin_mut.rs | 2 +- rust/kernel/workqueue.rs | 6 +++--- rust/uapi/lib.rs | 1 + 24 files changed, 40 insertions(+), 31 deletions(-) diff --git a/Makefile b/Makefile index 35e6e5240c61..21cc6e312ec9 100644 --- a/Makefile +++ b/Makefile @@ -484,6 +484,7 @@ export rust_common_flags := --edition=2021 \ -Wclippy::needless_bitwise_bool \ -Aclippy::needless_lifetimes \ -Wclippy::no_mangle_with_rust_abi \ + -Wclippy::ptr_as_ptr \ -Wclippy::undocumented_unsafe_blocks \ -Wclippy::unnecessary_safety_comment \ -Wclippy::unnecessary_safety_doc \ diff --git a/rust/bindings/lib.rs b/rust/bindings/lib.rs index a08eb5518cac..81b6c7aa4916 100644 --- a/rust/bindings/lib.rs +++ b/rust/bindings/lib.rs @@ -25,6 +25,7 @@ )] #[allow(dead_code)] +#[allow(clippy::ptr_as_ptr)] #[allow(clippy::undocumented_unsafe_blocks)] #[cfg_attr(CONFIG_RUSTC_HAS_UNNECESSARY_TRANSMUTES, allow(unnecessary_transmutes))] mod bindings_raw { diff --git a/rust/kernel/alloc/allocator_test.rs b/rust/kernel/alloc/allocator_test.rs index d19c06ef0498..a3074480bd8d 100644 --- a/rust/kernel/alloc/allocator_test.rs +++ b/rust/kernel/alloc/allocator_test.rs @@ -82,7 +82,7 @@ unsafe fn realloc( // SAFETY: Returns either NULL or a pointer to a memory allocation that satisfies or // exceeds the given size and alignment requirements. - let dst = unsafe { libc_aligned_alloc(layout.align(), layout.size()) } as *mut u8; + let dst = unsafe { libc_aligned_alloc(layout.align(), layout.size()) }.cast::(); let dst = NonNull::new(dst).ok_or(AllocError)?; if flags.contains(__GFP_ZERO) { diff --git a/rust/kernel/alloc/kvec.rs b/rust/kernel/alloc/kvec.rs index 1a0dd852a468..0477041cbc03 100644 --- a/rust/kernel/alloc/kvec.rs +++ b/rust/kernel/alloc/kvec.rs @@ -288,7 +288,7 @@ pub fn spare_capacity_mut(&mut self) -> &mut [MaybeUninit] { // - `self.len` is smaller than `self.capacity` by the type invariant and hence, the // resulting pointer is guaranteed to be part of the same allocated object. // - `self.len` can not overflow `isize`. - let ptr = unsafe { self.as_mut_ptr().add(self.len) } as *mut MaybeUninit; + let ptr = unsafe { self.as_mut_ptr().add(self.len) }.cast::>(); // SAFETY: The memory between `self.len` and `self.capacity` is guaranteed to be allocated // and valid, but uninitialized. @@ -847,7 +847,7 @@ fn drop(&mut self) { // - `ptr` points to memory with at least a size of `size_of::() * len`, // - all elements within `b` are initialized values of `T`, // - `len` does not exceed `isize::MAX`. - unsafe { Vec::from_raw_parts(ptr as _, len, len) } + unsafe { Vec::from_raw_parts(ptr.cast(), len, len) } } } diff --git a/rust/kernel/configfs.rs b/rust/kernel/configfs.rs index 34d0bea4f9a5..bc8e15dcec18 100644 --- a/rust/kernel/configfs.rs +++ b/rust/kernel/configfs.rs @@ -561,7 +561,7 @@ impl Attribute let data: &Data = unsafe { get_group_data(c_group) }; // SAFETY: By function safety requirements, `page` is writable for `PAGE_SIZE`. - let ret = O::show(data, unsafe { &mut *(page as *mut [u8; PAGE_SIZE]) }); + let ret = O::show(data, unsafe { &mut *(page.cast::<[u8; PAGE_SIZE]>()) }); match ret { Ok(size) => size as isize, diff --git a/rust/kernel/cpufreq.rs b/rust/kernel/cpufreq.rs index b0a9c6182aec..1cb1f29630e5 100644 --- a/rust/kernel/cpufreq.rs +++ b/rust/kernel/cpufreq.rs @@ -647,7 +647,7 @@ pub fn data(&mut self) -> Option<::Borrowed<'_>> { fn set_data(&mut self, data: T) -> Result { if self.as_ref().driver_data.is_null() { // Transfer the ownership of the data to the foreign interface. - self.as_mut_ref().driver_data = ::into_foreign(data) as _; + self.as_mut_ref().driver_data = ::into_foreign(data).cast(); Ok(()) } else { Err(EBUSY) diff --git a/rust/kernel/device.rs b/rust/kernel/device.rs index dea06b79ecb5..5c946af3a4d5 100644 --- a/rust/kernel/device.rs +++ b/rust/kernel/device.rs @@ -195,10 +195,10 @@ unsafe fn printk(&self, klevel: &[u8], msg: fmt::Arguments<'_>) { #[cfg(CONFIG_PRINTK)] unsafe { bindings::_dev_printk( - klevel as *const _ as *const crate::ffi::c_char, + klevel.as_ptr().cast::(), self.as_raw(), c_str!("%pA").as_char_ptr(), - &msg as *const _ as *const crate::ffi::c_void, + core::ptr::from_ref(&msg).cast::(), ) }; } diff --git a/rust/kernel/devres.rs b/rust/kernel/devres.rs index 0f79a2ec9474..e5475ff62da3 100644 --- a/rust/kernel/devres.rs +++ b/rust/kernel/devres.rs @@ -154,7 +154,7 @@ fn remove_action(this: &Arc) { #[allow(clippy::missing_safety_doc)] unsafe extern "C" fn devres_callback(ptr: *mut kernel::ffi::c_void) { - let ptr = ptr as *mut DevresInner; + let ptr = ptr.cast::>(); // Devres owned this memory; now that we received the callback, drop the `Arc` and hence the // reference. // SAFETY: Safe, since we leaked an `Arc` reference to devm_add_action() in diff --git a/rust/kernel/dma.rs b/rust/kernel/dma.rs index a33261c62e0c..666bf2d64f9a 100644 --- a/rust/kernel/dma.rs +++ b/rust/kernel/dma.rs @@ -186,7 +186,7 @@ pub fn alloc_attrs( dev: dev.into(), dma_handle, count, - cpu_addr: ret as *mut T, + cpu_addr: ret.cast::(), dma_attrs, }) } @@ -293,7 +293,7 @@ fn drop(&mut self) { bindings::dma_free_attrs( self.dev.as_raw(), size, - self.cpu_addr as _, + self.cpu_addr.cast(), self.dma_handle, self.dma_attrs.as_raw(), ) diff --git a/rust/kernel/error.rs b/rust/kernel/error.rs index 3dee3139fcd4..afcb00cb6a75 100644 --- a/rust/kernel/error.rs +++ b/rust/kernel/error.rs @@ -153,7 +153,7 @@ pub(crate) fn to_blk_status(self) -> bindings::blk_status_t { /// Returns the error encoded as a pointer. pub fn to_ptr(self) -> *mut T { // SAFETY: `self.0` is a valid error due to its invariant. - unsafe { bindings::ERR_PTR(self.0.get() as _) as *mut _ } + unsafe { bindings::ERR_PTR(self.0.get() as _).cast() } } /// Returns a string representing the error, if one exists. diff --git a/rust/kernel/firmware.rs b/rust/kernel/firmware.rs index 2494c96e105f..94fa1ea17ef0 100644 --- a/rust/kernel/firmware.rs +++ b/rust/kernel/firmware.rs @@ -62,10 +62,11 @@ impl Firmware { fn request_internal(name: &CStr, dev: &Device, func: FwFunc) -> Result { let mut fw: *mut bindings::firmware = core::ptr::null_mut(); let pfw: *mut *mut bindings::firmware = &mut fw; + let pfw: *mut *const bindings::firmware = pfw.cast(); // SAFETY: `pfw` is a valid pointer to a NULL initialized `bindings::firmware` pointer. // `name` and `dev` are valid as by their type invariants. - let ret = unsafe { func.0(pfw as _, name.as_char_ptr(), dev.as_raw()) }; + let ret = unsafe { func.0(pfw, name.as_char_ptr(), dev.as_raw()) }; if ret != 0 { return Err(Error::from_errno(ret)); } diff --git a/rust/kernel/fs/file.rs b/rust/kernel/fs/file.rs index 72d84fb0e266..e9bfbad00755 100644 --- a/rust/kernel/fs/file.rs +++ b/rust/kernel/fs/file.rs @@ -366,7 +366,7 @@ fn deref(&self) -> &LocalFile { // // By the type invariants, there are no `fdget_pos` calls that did not take the // `f_pos_lock` mutex. - unsafe { LocalFile::from_raw_file(self as *const File as *const bindings::file) } + unsafe { LocalFile::from_raw_file((self as *const Self).cast()) } } } diff --git a/rust/kernel/kunit.rs b/rust/kernel/kunit.rs index 4b8cdcb21e77..6930e86d98a9 100644 --- a/rust/kernel/kunit.rs +++ b/rust/kernel/kunit.rs @@ -9,6 +9,9 @@ use crate::prelude::*; use core::{ffi::c_void, fmt}; +#[cfg(CONFIG_PRINTK)] +use crate::c_str; + /// Prints a KUnit error-level message. /// /// Public but hidden since it should only be used from KUnit generated code. @@ -19,8 +22,8 @@ pub fn err(args: fmt::Arguments<'_>) { #[cfg(CONFIG_PRINTK)] unsafe { bindings::_printk( - c"\x013%pA".as_ptr() as _, - &args as *const _ as *const c_void, + c_str!("\x013%pA").as_char_ptr(), + core::ptr::from_ref(&args).cast::(), ); } } @@ -35,8 +38,8 @@ pub fn info(args: fmt::Arguments<'_>) { #[cfg(CONFIG_PRINTK)] unsafe { bindings::_printk( - c"\x016%pA".as_ptr() as _, - &args as *const _ as *const c_void, + c_str!("\x016%pA").as_char_ptr(), + core::ptr::from_ref(&args).cast::(), ); } } diff --git a/rust/kernel/list/impl_list_item_mod.rs b/rust/kernel/list/impl_list_item_mod.rs index a0438537cee1..1f9498c1458f 100644 --- a/rust/kernel/list/impl_list_item_mod.rs +++ b/rust/kernel/list/impl_list_item_mod.rs @@ -34,7 +34,7 @@ pub unsafe trait HasListLinks { unsafe fn raw_get_list_links(ptr: *mut Self) -> *mut ListLinks { // SAFETY: The caller promises that the pointer is valid. The implementer promises that the // `OFFSET` constant is correct. - unsafe { (ptr as *mut u8).add(Self::OFFSET) as *mut ListLinks } + unsafe { ptr.cast::().add(Self::OFFSET).cast() } } } diff --git a/rust/kernel/pci.rs b/rust/kernel/pci.rs index 8435f8132e38..33ae0bdc433d 100644 --- a/rust/kernel/pci.rs +++ b/rust/kernel/pci.rs @@ -78,7 +78,7 @@ extern "C" fn probe_callback( // Let the `struct pci_dev` own a reference of the driver's private data. // SAFETY: By the type invariant `pdev.as_raw` returns a valid pointer to a // `struct pci_dev`. - unsafe { bindings::pci_set_drvdata(pdev.as_raw(), data.into_foreign() as _) }; + unsafe { bindings::pci_set_drvdata(pdev.as_raw(), data.into_foreign().cast()) }; } Err(err) => return Error::to_errno(err), } diff --git a/rust/kernel/platform.rs b/rust/kernel/platform.rs index 5b21fa517e55..4b06f9fbc172 100644 --- a/rust/kernel/platform.rs +++ b/rust/kernel/platform.rs @@ -69,7 +69,9 @@ extern "C" fn probe_callback(pdev: *mut bindings::platform_device) -> kernel::ff // Let the `struct platform_device` own a reference of the driver's private data. // SAFETY: By the type invariant `pdev.as_raw` returns a valid pointer to a // `struct platform_device`. - unsafe { bindings::platform_set_drvdata(pdev.as_raw(), data.into_foreign() as _) }; + unsafe { + bindings::platform_set_drvdata(pdev.as_raw(), data.into_foreign().cast()) + }; } Err(err) => return Error::to_errno(err), } diff --git a/rust/kernel/print.rs b/rust/kernel/print.rs index 9783d960a97a..ecdcee43e5a5 100644 --- a/rust/kernel/print.rs +++ b/rust/kernel/print.rs @@ -25,7 +25,7 @@ // SAFETY: The C contract guarantees that `buf` is valid if it's less than `end`. let mut w = unsafe { RawFormatter::from_ptrs(buf.cast(), end.cast()) }; // SAFETY: TODO. - let _ = w.write_fmt(unsafe { *(ptr as *const fmt::Arguments<'_>) }); + let _ = w.write_fmt(unsafe { *ptr.cast::>() }); w.pos().cast() } @@ -109,7 +109,7 @@ pub unsafe fn call_printk( bindings::_printk( format_string.as_ptr(), module_name.as_ptr(), - &args as *const _ as *const c_void, + core::ptr::from_ref(&args).cast::(), ); } } @@ -129,7 +129,7 @@ pub fn call_printk_cont(args: fmt::Arguments<'_>) { unsafe { bindings::_printk( format_strings::CONT.as_ptr(), - &args as *const _ as *const c_void, + core::ptr::from_ref(&args).cast::(), ); } } diff --git a/rust/kernel/seq_file.rs b/rust/kernel/seq_file.rs index 7a9403eb6e5b..8f199b1a3bb1 100644 --- a/rust/kernel/seq_file.rs +++ b/rust/kernel/seq_file.rs @@ -37,7 +37,7 @@ pub fn call_printf(&self, args: core::fmt::Arguments<'_>) { bindings::seq_printf( self.inner.get(), c_str!("%pA").as_char_ptr(), - &args as *const _ as *const crate::ffi::c_void, + core::ptr::from_ref(&args).cast::(), ); } } diff --git a/rust/kernel/str.rs b/rust/kernel/str.rs index a927db8e079c..6a3cb607b332 100644 --- a/rust/kernel/str.rs +++ b/rust/kernel/str.rs @@ -237,7 +237,7 @@ pub unsafe fn from_char_ptr<'a>(ptr: *const crate::ffi::c_char) -> &'a Self { // to a `NUL`-terminated C string. let len = unsafe { bindings::strlen(ptr) } + 1; // SAFETY: Lifetime guaranteed by the safety precondition. - let bytes = unsafe { core::slice::from_raw_parts(ptr as _, len) }; + let bytes = unsafe { core::slice::from_raw_parts(ptr.cast(), len) }; // SAFETY: As `len` is returned by `strlen`, `bytes` does not contain interior `NUL`. // As we have added 1 to `len`, the last byte is known to be `NUL`. unsafe { Self::from_bytes_with_nul_unchecked(bytes) } diff --git a/rust/kernel/sync/poll.rs b/rust/kernel/sync/poll.rs index d7e6e59e124b..339ab6097be7 100644 --- a/rust/kernel/sync/poll.rs +++ b/rust/kernel/sync/poll.rs @@ -73,7 +73,7 @@ pub fn register_wait(&mut self, file: &File, cv: &PollCondVar) { // be destroyed, the destructor must run. That destructor first removes all waiters, // and then waits for an rcu grace period. Therefore, `cv.wait_queue_head` is valid for // long enough. - unsafe { qproc(file.as_ptr() as _, cv.wait_queue_head.get(), self.0.get()) }; + unsafe { qproc(file.as_ptr().cast(), cv.wait_queue_head.get(), self.0.get()) }; } } } diff --git a/rust/kernel/time/hrtimer/pin.rs b/rust/kernel/time/hrtimer/pin.rs index 293ca9cf058c..2f29fd75d63a 100644 --- a/rust/kernel/time/hrtimer/pin.rs +++ b/rust/kernel/time/hrtimer/pin.rs @@ -79,7 +79,7 @@ impl<'a, T> RawHrTimerCallback for Pin<&'a T> unsafe extern "C" fn run(ptr: *mut bindings::hrtimer) -> bindings::hrtimer_restart { // `HrTimer` is `repr(C)` - let timer_ptr = ptr as *mut HrTimer; + let timer_ptr = ptr.cast::>(); // SAFETY: By the safety requirement of this function, `timer_ptr` // points to a `HrTimer` contained in an `T`. diff --git a/rust/kernel/time/hrtimer/pin_mut.rs b/rust/kernel/time/hrtimer/pin_mut.rs index 6033572d35ad..d05d68be55e9 100644 --- a/rust/kernel/time/hrtimer/pin_mut.rs +++ b/rust/kernel/time/hrtimer/pin_mut.rs @@ -83,7 +83,7 @@ impl<'a, T> RawHrTimerCallback for Pin<&'a mut T> unsafe extern "C" fn run(ptr: *mut bindings::hrtimer) -> bindings::hrtimer_restart { // `HrTimer` is `repr(C)` - let timer_ptr = ptr as *mut HrTimer; + let timer_ptr = ptr.cast::>(); // SAFETY: By the safety requirement of this function, `timer_ptr` // points to a `HrTimer` contained in an `T`. diff --git a/rust/kernel/workqueue.rs b/rust/kernel/workqueue.rs index d092112d843f..de61374e36bd 100644 --- a/rust/kernel/workqueue.rs +++ b/rust/kernel/workqueue.rs @@ -170,7 +170,7 @@ impl Queue { pub unsafe fn from_raw<'a>(ptr: *const bindings::workqueue_struct) -> &'a Queue { // SAFETY: The `Queue` type is `#[repr(transparent)]`, so the pointer cast is valid. The // caller promises that the pointer is not dangling. - unsafe { &*(ptr as *const Queue) } + unsafe { &*ptr.cast::() } } /// Enqueues a work item. @@ -522,7 +522,7 @@ unsafe impl WorkItemPointer for Arc { unsafe extern "C" fn run(ptr: *mut bindings::work_struct) { // The `__enqueue` method always uses a `work_struct` stored in a `Work`. - let ptr = ptr as *mut Work; + let ptr = ptr.cast::>(); // SAFETY: This computes the pointer that `__enqueue` got from `Arc::into_raw`. let ptr = unsafe { T::work_container_of(ptr) }; // SAFETY: This pointer comes from `Arc::into_raw` and we've been given back ownership. @@ -575,7 +575,7 @@ unsafe impl WorkItemPointer for Pin> { unsafe extern "C" fn run(ptr: *mut bindings::work_struct) { // The `__enqueue` method always uses a `work_struct` stored in a `Work`. - let ptr = ptr as *mut Work; + let ptr = ptr.cast::>(); // SAFETY: This computes the pointer that `__enqueue` got from `Arc::into_raw`. let ptr = unsafe { T::work_container_of(ptr) }; // SAFETY: This pointer comes from `Arc::into_raw` and we've been given back ownership. diff --git a/rust/uapi/lib.rs b/rust/uapi/lib.rs index c98d7a8cde77..e79a1f49f055 100644 --- a/rust/uapi/lib.rs +++ b/rust/uapi/lib.rs @@ -14,6 +14,7 @@ #![cfg_attr(test, allow(unsafe_op_in_unsafe_fn))] #![allow( clippy::all, + clippy::ptr_as_ptr, clippy::undocumented_unsafe_blocks, dead_code, missing_docs, From patchwork Sun Jun 15 20:55:07 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tamir Duberstein X-Patchwork-Id: 897158 Received: from mail-qv1-f44.google.com (mail-qv1-f44.google.com [209.85.219.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 40253283FD5; Sun, 15 Jun 2025 20:55:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750020919; cv=none; b=Aaf3PmhGn8cDpL/D5rYQtt5pFT+V1BlX6gFm803w11922jxAmUjnH5GotDVnKF2dgrmMTJIJkfCLC3OlEZhsuPydtmnns6NB3Mm8Bk3zyhk3xK0MVpDTcW98Hc2930DYTSKklhhdvY6rZekUze/l0P9eaxocOwiQEFdePyOCu94= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750020919; c=relaxed/simple; bh=yF5Gv8tK9X1wroVzoAbelwVn5+WfGFCL8D9RidNzyJg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=pFY7P5R+pKr47ZpotNJd+wl9Mj+esP2fZQhkcWURnFRcv+6RSU3x/K1SPYeVQydyulv1aKBJt0fRfnHkLfKy6qtvoTIMUG/lsp63WlqoJ1U3mXMCrJlzI/0zn7Y1QaAp/S1eeqGWqNMeeFf/mU6Xv66HUj7o+dBEO95T7fEO+w0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PKCF1xDt; arc=none smtp.client-ip=209.85.219.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PKCF1xDt" Received: by mail-qv1-f44.google.com with SMTP id 6a1803df08f44-6fac1c60e19so51740796d6.1; Sun, 15 Jun 2025 13:55:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750020917; x=1750625717; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=BwuzOkwr2WXLbNIqZ4PjxHxYIhjL5EaV2fkU8tqfaYg=; b=PKCF1xDtFWQ0SDEV0gdWl9qc/I3iAdlG0nU9+IBQjW08EWvn2FrsyURMvOdg9apz2w x7dLBOjsP0zPO86xk+dakk4DoFAmVl3raAtq2i3Qvn1S5uYAw55vBcXMX8YnD/zVO1fT Nm4Eb7UCkw6H176Fc551phGh1JqlOmXT1KgMQvKdsm18QCYTm7cdIcuEhJq+kDQSlcED N6OAyiIMacLqOktj9ueypT/LRqXTpLGEzLr9i6UwMO8x8mJAz/8Njk7A0CDSNoSf6y3W x0KE28JhWQgHBv4yRxL6i3A+5I3VcJe/CLDMBGuUuFHgWNZmAK5dlJVVu7HR1fbd4FLy 9lNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750020917; x=1750625717; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BwuzOkwr2WXLbNIqZ4PjxHxYIhjL5EaV2fkU8tqfaYg=; b=QDmI7EVnFx1Ly41N1UryqAg5JEttTM/SaphAIJlNf3J/hTQLl8lbvAfHtXN1ZBV0ZD YfFX1/9aiPPxjW0A3q5vPuBR111lRqL8aBzFHcgfCPDVPJHwgxI0MAlj2QiP1rLB5NQH UrXEAuYD0XfjYCAYItjNZweKFqgqVUbE3DGSYsxAFreUCngNBOTN6PrhkCv6J4ZIV0R3 jbTdUlBS+CDiP1tuJKcVzR0mw1K0RDtC4Bi/yzRooYQpYFeynl9YY9NYngBLmfSx0LH/ yxrWg35/Zjl79mP3+W+8itEArxdPESZvwYCoVOwyCLcqGUVW8kKP78cttyIAQKeMb0gq T+Yw== X-Forwarded-Encrypted: i=1; AJvYcCUk++kanK8CKtZsBJ2dmdVBiFsm9FBdPrEeqRaSg8Op3eeNxc5GT0F6W6Gn1shSSM/QoQtKVcs2Z0pJ2BJRZsxP@vger.kernel.org, AJvYcCVYLHSwmFpJhRrVC9YITqciswF419myrYz8Ez/lvzluBFht4d568VZ4N+ubJa2F2EGqejO+5dZ5hTiuc+iHJeA=@vger.kernel.org, AJvYcCVbq0GC+3T69ZwU8tgPFDW+Bu2qiuyajmpcnRSA9Brr1sbDVQYPGhphWOG+tGBtk0CfioLQlBuigdntOi0u@vger.kernel.org, AJvYcCWPsd0yMGDaNmKIKfJao7gqZSpolpFlTPPivWSUoaJuApRRjkotu17e7xUc6dlXvlcjiOZTznO/EAXT@vger.kernel.org, AJvYcCWm8F08MpYKjp2LV+iJIo1Gqw9qeGrzWMd+GACImVSzU9u1DEBhF1LVXriPvQA86xe3Cv1gLhwIG94s@vger.kernel.org, AJvYcCXA09cIpQVdDjw7PIMyFLG6Y4hWZwRD7G8L08QWBu4ciHSkk2dyyqQ8t/jFJLNggpXBrshDLI2GKHQ7l0s=@vger.kernel.org, AJvYcCXOf2zfs4YP4WzBWNE2M8ZzHv1YtNoYiBpek6eB5CzikZWhMKOrTwI4T6CmJK592uXTTrfRJ06tMRA=@vger.kernel.org, AJvYcCXXh+gsnqS6SJBopffVEGpS8xOkL7lRBeKYIwr5ccfBd1DYvA4s1AddL+Kp+Ak2irayq5iX28Xo@vger.kernel.org X-Gm-Message-State: AOJu0YwkYNo1r9d/G5prmNEwm7I1gemQTjZ6FPDCup20RQiflulVZ5Fw eUhow6+nR7mB4K9hbCTJMG6u0c0OW63rJc6C6mQbNZ5CldCx7XL+Km/R X-Gm-Gg: ASbGncuaeC/kDvlPIj1j+f9tOd74xvzDO6lHRL73+JCUGy3qSnh38jFMvprOdc3VvrH LuK8NMvQwKwKYBudgb3zulyyhcGPpmcsZCZtC3C70RkFGAUOAlydgkNp74yCd/ygq8jJ2C/7q8M 5oacKX/j/v+1auAbai2OE5Z/kI+xW1DzNlrSYjHDXDir3f+EpDfwWpLgnhhmMBWIteEokZTCbdT 99c9+wKPOftRjXe6YCxruWKOHF9XkA/Th/3QAVgRx4QacS3DTbBQEevEf4ot5mhPf7+f64yISM6 3yTfd81gwaoaUJYKmdxMk2ncaEmTdjYVZ01Nvuer6JPGqUVzAod1WZw+JHggxLUsw6K4CA== X-Google-Smtp-Source: AGHT+IEgmK9+Bj58C8dqWwTYX0gZlBqZMRj5psT70nx4i2bPfqmKaepd9+hxp6sh8BMt38kvfV7yAg== X-Received: by 2002:a05:6214:76d:b0:6f8:c53f:48e with SMTP id 6a1803df08f44-6fb459eecb2mr143148166d6.0.1750020917091; Sun, 15 Jun 2025 13:55:17 -0700 (PDT) Received: from tamird-mac.local ([2600:4041:5be7:7c00:b0c6:92db:d807:21a6]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6fb35c84148sm43468176d6.109.2025.06.15.13.55.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Jun 2025 13:55:16 -0700 (PDT) From: Tamir Duberstein Date: Sun, 15 Jun 2025 16:55:07 -0400 Subject: [PATCH v12 3/6] rust: enable `clippy::as_ptr_cast_mut` lint Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250615-ptr-as-ptr-v12-3-f43b024581e8@gmail.com> References: <20250615-ptr-as-ptr-v12-0-f43b024581e8@gmail.com> In-Reply-To: <20250615-ptr-as-ptr-v12-0-f43b024581e8@gmail.com> To: Masahiro Yamada , Nathan Chancellor , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Greg Kroah-Hartman , "Rafael J. Wysocki" , Brendan Higgins , David Gow , Rae Moar , Bjorn Helgaas , Luis Chamberlain , Russ Weight , Rob Herring , Saravana Kannan , Abdiel Janulgue , Daniel Almeida , Robin Murphy , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , FUJITA Tomonori , Nicolas Schier , Frederic Weisbecker , Lyude Paul , Thomas Gleixner , Anna-Maria Behnsen , Benno Lossin , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , John Stultz , Stephen Boyd , Lorenzo Stoakes , "Liam R. Howlett" , Breno Leitao , Viresh Kumar , Nicolas Schier Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-pci@vger.kernel.org, linux-block@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, netdev@vger.kernel.org, linux-mm@kvack.org, linux-pm@vger.kernel.org, nouveau@lists.freedesktop.org, Tamir Duberstein , Benno Lossin X-Mailer: b4 0.15-dev In Rust 1.66.0, Clippy introduced the `as_ptr_cast_mut` lint [1]: > Since `as_ptr` takes a `&self`, the pointer won’t have write > permissions unless interior mutability is used, making it unlikely > that having it as a mutable pointer is correct. There is only one affected callsite, and the change amounts to replacing `as _` with `.cast_mut().cast()`. This doesn't change the semantics, but is more descriptive of what's going on. Apply this change and enable the lint -- no functional change intended. Link: https://rust-lang.github.io/rust-clippy/master/index.html#as_ptr_cast_mut [1] Reviewed-by: Benno Lossin Reviewed-by: Boqun Feng Signed-off-by: Tamir Duberstein --- Makefile | 1 + rust/kernel/devres.rs | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 5eeddfbf5900..bb33023f87c3 100644 --- a/Makefile +++ b/Makefile @@ -479,6 +479,7 @@ export rust_common_flags := --edition=2021 \ -Wrust_2018_idioms \ -Wunreachable_pub \ -Wclippy::all \ + -Wclippy::as_ptr_cast_mut \ -Wclippy::ignored_unit_patterns \ -Wclippy::mut_mut \ -Wclippy::needless_bitwise_bool \ diff --git a/rust/kernel/devres.rs b/rust/kernel/devres.rs index e5475ff62da3..237182446db3 100644 --- a/rust/kernel/devres.rs +++ b/rust/kernel/devres.rs @@ -140,7 +140,7 @@ fn remove_action(this: &Arc) { bindings::devm_remove_action_nowarn( this.dev.as_raw(), Some(this.callback), - this.as_ptr() as _, + this.as_ptr().cast_mut().cast(), ) }; From patchwork Sun Jun 15 20:55:09 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tamir Duberstein X-Patchwork-Id: 897157 Received: from mail-qv1-f47.google.com (mail-qv1-f47.google.com [209.85.219.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B04BA2857DA; Sun, 15 Jun 2025 20:55:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750020924; cv=none; b=lTmC6zJIAYHPNtAyDC4GBTDW/2sv6n4IAnGr9P3EYgorofa4Vi3KBpJEJHI/1RmwahQDrAIYu2jK1C6MyHpjQ6S+oEnoL5rKTSYol06rCAc7/JH2cOGZ8sOyFJiA1uJt4+30rYM5bFEba4yDUDwN+eNCm3lRbSmn+55LfwroGTM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750020924; c=relaxed/simple; bh=L+8VpQuz+KnH4o2+cApd2o8QUP5OiMY0hZcxdLKK1OI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rLYRDchxJM2CFC5W/tXIxMIYLyJfj3HMo0XrgMBcRnzG/9pv2GG47BscQizhQeHtVA5Jz2bAqkJbrh8uax0FqZ96Jq+/GdooSL9JVOSKK9+zccDF1NXVur+KkicILBUJAM16DxLRMcSfxUA5Qug03voCKOWvDqt8kefLbQShQZg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=O7yaXrFl; arc=none smtp.client-ip=209.85.219.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="O7yaXrFl" Received: by mail-qv1-f47.google.com with SMTP id 6a1803df08f44-6fafb6899c2so46948436d6.0; Sun, 15 Jun 2025 13:55:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750020921; x=1750625721; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=EzIO770K3BEzT6LTWkTmJxAe6XJ7JYWo5FVTqpGa1qI=; b=O7yaXrFlbfcvgLVNgOnL4GVrA7XIu2WqAofd2knrECXrZ9uk0gQyOv3V+3sOOu5OU7 UGLxDq/3ZPVK0/Hbo9Nr4t6wJrA4RNvDW/VtLcqVAWse24khnliapQX6OsDcnbOibb7c Hbx8JyMnZGgioGw8AnBwJIQXK+PPEHUKtrp77t9e/SAWr8v8BBCLMZ2YsNJy+wteEXtf 9iG5ysJF3R/+P7I2NA2U0RWO3Ea21vND81mwspOKEfLLFp1ZAC+X3VjBjvmOow+yrld2 hhrTm5fohKdx98+b1cypgqw0UXRhKycV9FNygVMQsDXAXESKeCy6WY9ITFyttUbs0ymg oaUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750020921; x=1750625721; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EzIO770K3BEzT6LTWkTmJxAe6XJ7JYWo5FVTqpGa1qI=; b=aMmslBoK77hUjS5OpS0aLK1HRoXTt7MquGKIQvNjCdRIAWIuX78barJVOcq1zINXoA ooB720Hl91PhGOkMqhj2pTmf1bgGa5emTPtmx1Ua3V6p54CmjghvNWJopxrSA7xDF781 u6fYvvImEGlV293jHUxFtzxgOywXDQWnONdgcRQYFSQlWJvSy0jO8raQgImTT5lEci6v 823+EEsh7uEND3Cn+GEmjUTNQ0juyf89SdW9YpHMY2bfp0RPSIK95Gqze8rLcylfDrxy p6GSQVJL6g20RcOZZFSXkjejC+GyCx2glc2MGT/oQwNvMzXeZqUmdEvV4RbwdS7lVCnB xjpQ== X-Forwarded-Encrypted: i=1; AJvYcCU4tWPR7l5hhWlGNAqpxRIU1i/XFfX3oqlc0aYijLCO6RDdq93xl8cxjyZjTwVpWpzBgWLHLTFFUeUEpicS4Zw=@vger.kernel.org, AJvYcCUYFh13zOF/hr4YGr+xk5dY1kcAE/YKLhG6aVgUpbJlj+7fQfbjeOuK8/HvAKzx+OPVD8kK1egd@vger.kernel.org, AJvYcCVAJsjQ9wA9TrlisvarJAXxrh6hKaSkyCDn4g/oexi5iZcL2H2PKCdt09/yqFC0thrYh1WrBY99TrI=@vger.kernel.org, AJvYcCVFzF1KjaZJO/0tUQUfRAasblNX1/Lj+GVXIZDxeQmNpidVrYteYi1WR9MctMqhaSnfFBn1XUXN/r0vIrk=@vger.kernel.org, AJvYcCWJCdcKo/ua+dGnOIZVCFIj9XX/3flkOohvGGg2f+041LWD/TaUTvY98lToDUQm/rxkVxSS18zg9MNNNXszdT0r@vger.kernel.org, AJvYcCWJtHO/B5rqmGxPBgemLOeZZmQEdkA+cLOq95tXM+nME9bYiYA8COQzfhVFCWLY4sttPAoCDBmccDikRyL6@vger.kernel.org, AJvYcCWva8qFTE9Sx7YP/DHP4VHPQh+2sb3I/LG/BC6xx3ElegZtIvNCgi9VcodFZ8w5Dym54Hcjp4Qy2x8g@vger.kernel.org, AJvYcCXzfnLLrdaCYeJVOWfyMDUG3kIOxRxV+6XAnTNOr59/6mdgFqsZNSXfFxiLK0yYYBHoVeH1uzxwlgEG@vger.kernel.org X-Gm-Message-State: AOJu0Yx2VPM0VfEr+Gls+3Wk8ApYNgSYcniBgk538tIbxOVO4S83VWh8 D9/Qqo/pE9J630rzyePQUGOHKj/NYPEt9rpL/1HLpuPtl5EKUHum/43n X-Gm-Gg: ASbGncuFxR4LyURP/AhYoWqtoINnaxoE7Oj9HFKgknZ7rD4AowNlvchqwREbVJKVxOP Z2NJLiTqKu9gNN5kHjUU8r/jHuDJv/sTi1sf5lwJQsOfyAGiFrVQQEFs5VTWTJ9/5qoVPodBe0M StC7x4tOFlso6C67eNx6v6mtVCv9kwsb3X4TsS/347aAR8+IHQ/K5bWm8ADTc1MbmDB9ukU6/cj kpR3Ne7PCIvk8Z4ez3cD2/EXsbfIGIMGIt6vkSlZ14UfkvqIODCcFLF1cHkqTohWTUqwaaBnPc0 10xHAj8csr5yx1A+/+or8ub0Iydf3spshN7C1sO8iWayPL5oFqQwHc8pPVKl2St5FvsvKg== X-Google-Smtp-Source: AGHT+IHuJ5ATyUdQgk4pt9BONn4x9zspwvV+2Gm1qDCe2qRdxVwp1sIbazWwdq/xR0732z5MemwTXw== X-Received: by 2002:a05:6214:2529:b0:6fa:b467:aa67 with SMTP id 6a1803df08f44-6fb45c26e75mr137361606d6.20.1750020921472; Sun, 15 Jun 2025 13:55:21 -0700 (PDT) Received: from tamird-mac.local ([2600:4041:5be7:7c00:b0c6:92db:d807:21a6]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6fb35c84148sm43468176d6.109.2025.06.15.13.55.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Jun 2025 13:55:21 -0700 (PDT) From: Tamir Duberstein Date: Sun, 15 Jun 2025 16:55:09 -0400 Subject: [PATCH v12 5/6] rust: enable `clippy::cast_lossless` lint Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250615-ptr-as-ptr-v12-5-f43b024581e8@gmail.com> References: <20250615-ptr-as-ptr-v12-0-f43b024581e8@gmail.com> In-Reply-To: <20250615-ptr-as-ptr-v12-0-f43b024581e8@gmail.com> To: Masahiro Yamada , Nathan Chancellor , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Greg Kroah-Hartman , "Rafael J. Wysocki" , Brendan Higgins , David Gow , Rae Moar , Bjorn Helgaas , Luis Chamberlain , Russ Weight , Rob Herring , Saravana Kannan , Abdiel Janulgue , Daniel Almeida , Robin Murphy , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , FUJITA Tomonori , Nicolas Schier , Frederic Weisbecker , Lyude Paul , Thomas Gleixner , Anna-Maria Behnsen , Benno Lossin , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , John Stultz , Stephen Boyd , Lorenzo Stoakes , "Liam R. Howlett" , Breno Leitao , Viresh Kumar , Nicolas Schier Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-pci@vger.kernel.org, linux-block@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, netdev@vger.kernel.org, linux-mm@kvack.org, linux-pm@vger.kernel.org, nouveau@lists.freedesktop.org, Tamir Duberstein , Benno Lossin X-Mailer: b4 0.15-dev Before Rust 1.29.0, Clippy introduced the `cast_lossless` lint [1]: > Rust’s `as` keyword will perform many kinds of conversions, including > silently lossy conversions. Conversion functions such as `i32::from` > will only perform lossless conversions. Using the conversion functions > prevents conversions from becoming silently lossy if the input types > ever change, and makes it clear for people reading the code that the > conversion is lossless. While this doesn't eliminate unchecked `as` conversions, it makes such conversions easier to scrutinize. It also has the slight benefit of removing a degree of freedom on which to bikeshed. Thus apply the changes and enable the lint -- no functional change intended. Link: https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [1] Suggested-by: Benno Lossin Link: https://lore.kernel.org/all/D8ORTXSUTKGL.1KOJAGBM8F8TN@proton.me/ Reviewed-by: Benno Lossin Reviewed-by: Boqun Feng Signed-off-by: Tamir Duberstein --- Makefile | 1 + drivers/gpu/drm/drm_panic_qr.rs | 4 ++-- drivers/gpu/nova-core/regs.rs | 2 +- drivers/gpu/nova-core/regs/macros.rs | 2 +- rust/bindings/lib.rs | 1 + rust/kernel/net/phy.rs | 4 ++-- rust/uapi/lib.rs | 1 + 7 files changed, 9 insertions(+), 6 deletions(-) diff --git a/Makefile b/Makefile index 0ba22c361de8..29cf39be14de 100644 --- a/Makefile +++ b/Makefile @@ -481,6 +481,7 @@ export rust_common_flags := --edition=2021 \ -Wclippy::all \ -Wclippy::as_ptr_cast_mut \ -Wclippy::as_underscore \ + -Wclippy::cast_lossless \ -Wclippy::ignored_unit_patterns \ -Wclippy::mut_mut \ -Wclippy::needless_bitwise_bool \ diff --git a/drivers/gpu/drm/drm_panic_qr.rs b/drivers/gpu/drm/drm_panic_qr.rs index dd55b1cb764d..6b59d19ab631 100644 --- a/drivers/gpu/drm/drm_panic_qr.rs +++ b/drivers/gpu/drm/drm_panic_qr.rs @@ -404,7 +404,7 @@ fn pop3(&mut self) -> Option<(u16, usize)> { let mut out = 0; let mut exp = 1; for i in 0..poplen { - out += self.decimals[self.len + i] as u16 * exp; + out += u16::from(self.decimals[self.len + i]) * exp; exp *= 10; } Some((out, NUM_CHARS_BITS[poplen])) @@ -425,7 +425,7 @@ fn next(&mut self) -> Option { match self.segment { Segment::Binary(data) => { if self.offset < data.len() { - let byte = data[self.offset] as u16; + let byte = u16::from(data[self.offset]); self.offset += 1; Some((byte, 8)) } else { diff --git a/drivers/gpu/nova-core/regs.rs b/drivers/gpu/nova-core/regs.rs index 5a1273230306..c1cb6d4c49ee 100644 --- a/drivers/gpu/nova-core/regs.rs +++ b/drivers/gpu/nova-core/regs.rs @@ -32,7 +32,7 @@ pub(crate) fn architecture(self) -> Result { pub(crate) fn chipset(self) -> Result { self.architecture() .map(|arch| { - ((arch as u32) << Self::IMPLEMENTATION.len()) | self.implementation() as u32 + ((arch as u32) << Self::IMPLEMENTATION.len()) | u32::from(self.implementation()) }) .and_then(Chipset::try_from) } diff --git a/drivers/gpu/nova-core/regs/macros.rs b/drivers/gpu/nova-core/regs/macros.rs index 7ecc70efb3cd..6851af8b5885 100644 --- a/drivers/gpu/nova-core/regs/macros.rs +++ b/drivers/gpu/nova-core/regs/macros.rs @@ -264,7 +264,7 @@ pub(crate) fn $field(self) -> $res_type { pub(crate) fn [](mut self, value: $to_type) -> Self { const MASK: u32 = $name::[<$field:upper _MASK>]; const SHIFT: u32 = $name::[<$field:upper _SHIFT>]; - let value = ((value as u32) << SHIFT) & MASK; + let value = (u32::from(value) << SHIFT) & MASK; self.0 = (self.0 & !MASK) | value; self diff --git a/rust/bindings/lib.rs b/rust/bindings/lib.rs index 81b6c7aa4916..7631c9f6708d 100644 --- a/rust/bindings/lib.rs +++ b/rust/bindings/lib.rs @@ -25,6 +25,7 @@ )] #[allow(dead_code)] +#[allow(clippy::cast_lossless)] #[allow(clippy::ptr_as_ptr)] #[allow(clippy::undocumented_unsafe_blocks)] #[cfg_attr(CONFIG_RUSTC_HAS_UNNECESSARY_TRANSMUTES, allow(unnecessary_transmutes))] diff --git a/rust/kernel/net/phy.rs b/rust/kernel/net/phy.rs index 32ea43ece646..65ac4d59ad77 100644 --- a/rust/kernel/net/phy.rs +++ b/rust/kernel/net/phy.rs @@ -142,7 +142,7 @@ pub fn is_autoneg_enabled(&self) -> bool { // SAFETY: The struct invariant ensures that we may access // this field without additional synchronization. let bit_field = unsafe { &(*self.0.get())._bitfield_1 }; - bit_field.get(13, 1) == bindings::AUTONEG_ENABLE as u64 + bit_field.get(13, 1) == u64::from(bindings::AUTONEG_ENABLE) } /// Gets the current auto-negotiation state. @@ -427,7 +427,7 @@ impl Adapter { // where we hold `phy_device->lock`, so the accessors on // `Device` are okay to call. let dev = unsafe { Device::from_raw(phydev) }; - T::match_phy_device(dev) as i32 + T::match_phy_device(dev).into() } /// # Safety diff --git a/rust/uapi/lib.rs b/rust/uapi/lib.rs index e79a1f49f055..08e68ebef606 100644 --- a/rust/uapi/lib.rs +++ b/rust/uapi/lib.rs @@ -14,6 +14,7 @@ #![cfg_attr(test, allow(unsafe_op_in_unsafe_fn))] #![allow( clippy::all, + clippy::cast_lossless, clippy::ptr_as_ptr, clippy::undocumented_unsafe_blocks, dead_code,