From patchwork Tue Jun 17 08:19:59 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chen-Yu Tsai X-Patchwork-Id: 898105 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C22F7291C38 for ; Tue, 17 Jun 2025 08:20:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750148417; cv=none; b=psunjmFjHrr8WzdA2fRpLLKwzru88ZA2n6qzNKcfIUML+06qDNWiKFYq9Vc1Xo1ijWIJo4hroCi4T+cvrGql4EfUGMUwNW8XOTS0JmkMNpK+XjhpgDRxWFEePkdGwglE6KAXYVXVFrD57M8IaVygRHABPnAcSMtfaiJPI/diCjg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750148417; c=relaxed/simple; bh=sZ4za1Id7G7nTtjakVPvrhklzZJfNGfC4w42qoWdWUg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kYVkuBM5REgCYWGBQlztcQdzNn1FeD0X0g3231J3+UOFr1mHZEtCWeH1pxXFc3GDYFL7JDaVeRGk3/MvQC6omZDg3YrCCgdn9TkmLNzl+7GCIv85eziCub5OoNIyrfTQ5Sk08n0Bnhxu6wTiETcnb3q9S+vF2WLBtTlhBmBUh7c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=FszV23VG; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="FszV23VG" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2350fc2591dso49507035ad.1 for ; Tue, 17 Jun 2025 01:20:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1750148414; x=1750753214; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hJpSSWKODubMWDu6LS8hKhfIs2zxRW9+kSXB6f03nq8=; b=FszV23VGo5soy7GqxhDa8qKGOPpx4ZJMjjJTg/0uTpRAaGcmgNhwDNF7oZyfeVxQTS T2NZs4rOdGbY4Ft9XdzsAVa4noz+gFOpJqzBKL26PJznvBmf5hbjUAvVHpwKoqiXIzaB PlsEXYnHvIoPcZrZ664znfwMIM+9Rkq7cV1T8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750148414; x=1750753214; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hJpSSWKODubMWDu6LS8hKhfIs2zxRW9+kSXB6f03nq8=; b=mjYxACmU/4OKiZigfeK4gJJ8Cv+hYpUmxJsrJfY1RNgBpBXA5Orng/ePdsnP0KZ+Cr +SALP0o5H/U94JqR3yklmYn5hMAL1RC3vD+6+M/7S2UtLg0TfpJ1+aBRffYGRQVDNRvP YZXAEcc/WIRe9X11fsabqLEKEIsyR9sSJJh53n2l1/WLHUR8CVFCf4CPHJS8rbxVQlBD BYPDTm7o5lVIzLp2qbAUXuum5NlCXqdmZJVk8lTreHTVvoTrc7W4FJgZSgyIiiURL8R3 1QTDxLB+2SZQqdp5P6D3PyHi5isvzeMCWC/uoTWBYskoqGK4mTzLdmrnfSFoRzWvNcL2 gs7Q== X-Forwarded-Encrypted: i=1; AJvYcCUEC66NvZurnWs5ml9UseVgkUNLoCn0ACGy5xuhAbV4VK08szMZWRtYestEVKPdeWVhSw9i3NZS8hSm6g==@vger.kernel.org X-Gm-Message-State: AOJu0YyRm4LepGIveerieim4izSXvRS20XNSoh1JNOhbqsWCzJe10nzJ ZtWD3iSy0vEnKXP8Avt0X4R2ZrO6xryLNpH/5yCBl1+PvjKpX/qgk1ej9LXTpPtdYQ== X-Gm-Gg: ASbGncty92p6LE56O1Ndco7APeUb/zLU0OVXKt2bpPvgD+e/w8qYG2bnschilFzJ0jw uZygelaMpX5XOX9MLa44+nlWr9MaqMKKowQHkeDGcVTQZ5Kpnxv/+8pwtr2TbtNyjatKQ+R9Z9M 1aQKeNChjsc6cf0hb0H/Ua2735sUCSHmyPl/8+R4BxaSqwwIqCaspr/P1yG5YltIbvvl+31EXdr Kq+BeQ5HcCEXL2DWUale7L/XzG6IkifLfTdLFGCWkVfEOAE9WhvLsxKkhFzDO8VnxAv83nuki2Y M1id7//sfU78nKvOUx5BT5zNqusvCs+VkE7T9hxsm1M5OZvk6ZU0ZlwykjXiYWN4ITeIYoFfwSb AF4Wa7DqA8ZzBSlI= X-Google-Smtp-Source: AGHT+IFfpg2r7E+A3hwnVaD8XvFL8a9eXnDD2HrKdh1NTx8ZQ0KD0SKLHARkzMHejSWGfoyIg/Kiig== X-Received: by 2002:a17:903:4b07:b0:234:b3fb:8ed with SMTP id d9443c01a7336-23691bedec5mr30450435ad.1.1750148414061; Tue, 17 Jun 2025 01:20:14 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2401:fa00:1:10:24a1:2596:1651:13d8]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2365de781f7sm74598885ad.110.2025.06.17.01.20.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jun 2025 01:20:13 -0700 (PDT) From: Chen-Yu Tsai To: Matthias Brugger , AngeloGioacchino Del Regno , Dmitry Torokhov Cc: Chen-Yu Tsai , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-input@vger.kernel.org, "Rob Herring (Arm)" , Benson Leung Subject: [PATCH v3 2/6] dt-bindings: arm: mediatek: Merge MT8186 Voltorb entries Date: Tue, 17 Jun 2025 16:19:59 +0800 Message-ID: <20250617082004.1653492-3-wenst@chromium.org> X-Mailer: git-send-email 2.50.0.rc2.692.g299adb8693-goog In-Reply-To: <20250617082004.1653492-1-wenst@chromium.org> References: <20250617082004.1653492-1-wenst@chromium.org> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 There are only two different SKUs of Voltorb, and the only difference between them is whether a touchscreen is present or not. This can be detected by a simple I2C transfer to the address, instead of having separate compatible strings and device trees. Drop the SKU-specific compatible strings and just keep the generic "google,voltorb" one. Acked-by: Rob Herring (Arm) Reviewed-by: Benson Leung Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Chen-Yu Tsai --- Changes since v1: - Added Rob's ack --- Documentation/devicetree/bindings/arm/mediatek.yaml | 3 --- 1 file changed, 3 deletions(-) diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml index a7e0a72f6e4c..2032b0b64ba7 100644 --- a/Documentation/devicetree/bindings/arm/mediatek.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml @@ -350,9 +350,6 @@ properties: - const: mediatek,mt8186 - description: Google Voltorb (Acer Chromebook 311 C723/C732T) items: - - enum: - - google,voltorb-sku589824 - - google,voltorb-sku589825 - const: google,voltorb - const: mediatek,mt8186 - items: From patchwork Tue Jun 17 08:20:01 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chen-Yu Tsai X-Patchwork-Id: 898104 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 963AF295530 for ; Tue, 17 Jun 2025 08:20:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750148421; cv=none; b=TQo5LgMMO3qvzMZRnc5lCb02VZH5SNtRgpQSIIGdJKZ8OfiQRhz3RG69K5TKlhNb4poL9DSVdVIs0e+7YCXPdx5yJmqtIoLxNnz9h9IgJUEgjLk5xEnpT8p3d9ZcaVE0S4Jk+G1nCDXba/FfUieHgPcffqvbC4LtNxxXmxlfrNE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750148421; c=relaxed/simple; bh=oBHXVLfPUMNfuLYLhWWLUgYUX4yzCGGF3ElVjcq/IvQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tb68xLb0e/Vm5l8ZJN/Z0ob2UoK8Y3iN6iuCmyedTM6Q5yfALHpwUMUgLV9g2nJ9UkWixjHlrZ8yPbQtTGcf2sP20AqICbgRH+B8kx994+RwvuakhJImwXOODVw2SYEjiAZze1MamALTQvynzGjr7+/snNv4qkraFstXJ4yboSE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=iqH7AOxL; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="iqH7AOxL" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2350fc2591dso49507525ad.1 for ; Tue, 17 Jun 2025 01:20:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1750148419; x=1750753219; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vLfwvnKqf7flG1w1FJwQLt+8yXkZ/9IUG75s/1+ddU0=; b=iqH7AOxL7rK9x2UR5zCInQMw8iDB9vPxWOHkjgqvZ5EQmEC5bsr5V87wRSaENmpvXA kN2sBl5wNb313noKZKTtFPTVmzdmLoY+xRUS3/3NIxBTbqa3qhB3Efte7Vv6hbLNW8O+ VZi12NS5YGlKwMXnW3j/koBJ0wEJIuIeARJ6U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750148419; x=1750753219; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vLfwvnKqf7flG1w1FJwQLt+8yXkZ/9IUG75s/1+ddU0=; b=hwsvC6yW4aiEA+ZhAEgrDMluyeHjv6Ro6ZEtmKAEKABjsb9NEXinl7U7iqDMBFKbqU ir5VwsuxaR6Sjam7N5PBjwGYyWdtQ0c0OuVn0xfHoI83gED5cmJgLWNmwiz4bXH/vEX/ LzOpPDluiH3ER640hbIBdu9ruCQCJnH0Ad4uF4rpamnwuuWP5Bg+ZEwZyMfzmwRcMACr MbVKc7HmJoCioXKJ75iq9VMmcs56MTTZ0w7Dnlw+DXE4AI+JCMuLGVQd3tW7yM7JTgVt ezvoFFC7bjq1NP5/WoB8xaIqsCyelbDitBvkyYWlRLkM68mQsJta53mhGSemB0artroV ujdg== X-Forwarded-Encrypted: i=1; AJvYcCWCJuUSFMv/ZItZ03xOuW7prjfe0NY+YTjri5lQLo+SeTP3cLb+Jzi6wYJioFVKXDxIoU6ApbJHK1obMg==@vger.kernel.org X-Gm-Message-State: AOJu0Yyo7lszATOo9SouujlLJlVO0zEZ8ED0kdDB/9eXsDtl+T6R114X fhLideWLm+BvHlJjUf60HRP37gjD4b/ttXAGRHHpYjl1Sxos/bHgx3wSk0cWubnIdQ== X-Gm-Gg: ASbGncvH1ITlgnTZPnx4ZfWBRmg/AJ19SO5tBBQK8jxnXSTWS4nBMyUt0LXH15D7EUB uF2oYGhhMrpXkwowrzoPIq5XBPzFRgp+O2Etj3ZXZAVGNmbRdD3vSW5h+RT9juDJeLrYrzuqjOb wg6CSaLNuhoWl6LYuPQCqpDzKwQJ0zYSDFtbXBiujQ0AAwcrmCTyG7rhqrTl1zboUg2sXSKWmY1 HyXg3JfBhf1otyevY8CE9raYl+01N4vSWe9UzL4juuzJQSKt2iRQXeKvvyRwoBO5CP/m34SJWfv A+e7KL2PzQef75kZDSbABshImvhpyndh21+dJfs9B/8ghron0pexU5lgitPZFnzxqj7ls/dI0/3 FfdC1 X-Google-Smtp-Source: AGHT+IEdEae9jR3M9Ile50GhlK5a+mZddJwAjCXfQi04qoA/3oENN3QsRc5nWKd11gVEcOZh5+alGQ== X-Received: by 2002:a17:902:d4d0:b0:236:15b7:62e3 with SMTP id d9443c01a7336-2366ae00e3fmr181507135ad.9.1750148418807; Tue, 17 Jun 2025 01:20:18 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2401:fa00:1:10:24a1:2596:1651:13d8]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2365de781f7sm74598885ad.110.2025.06.17.01.20.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jun 2025 01:20:18 -0700 (PDT) From: Chen-Yu Tsai To: Matthias Brugger , AngeloGioacchino Del Regno , Dmitry Torokhov Cc: Chen-Yu Tsai , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-input@vger.kernel.org, stable+noautosel@kernel.org Subject: [PATCH v3 4/6] arm64: dts: mediatek: mt8186-steelix: Mark second source components for probing Date: Tue, 17 Jun 2025 16:20:01 +0800 Message-ID: <20250617082004.1653492-5-wenst@chromium.org> X-Mailer: git-send-email 2.50.0.rc2.692.g299adb8693-goog In-Reply-To: <20250617082004.1653492-1-wenst@chromium.org> References: <20250617082004.1653492-1-wenst@chromium.org> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Steelix design has two possible trackpad component sources. Currently they are all marked as available, along with having workarounds for shared pinctrl muxing and GPIOs. Instead, mark them all as "fail-needs-probe" and have the implementation try to probe which one is present. Also remove the shared resource workaround by moving the pinctrl entry for the trackpad interrupt line back into the individual trackpad nodes. Cc: stable+noautosel@kernel.org # Needs accompanying new driver to work Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Chen-Yu Tsai --- .../boot/dts/mediatek/mt8186-corsola-steelix.dtsi | 7 +++++++ .../mediatek/mt8186-corsola-tentacool-sku327683.dts | 2 ++ .../mediatek/mt8186-corsola-tentacruel-sku262148.dts | 2 ++ arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi | 10 ++++------ 4 files changed, 15 insertions(+), 6 deletions(-) diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola-steelix.dtsi b/arch/arm64/boot/dts/mediatek/mt8186-corsola-steelix.dtsi index e74e886a00cb..822a177e7c19 100644 --- a/arch/arm64/boot/dts/mediatek/mt8186-corsola-steelix.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola-steelix.dtsi @@ -123,8 +123,11 @@ trackpad@2c { reg = <0x2c>; hid-descr-addr = <0x20>; interrupts-extended = <&pio 11 IRQ_TYPE_LEVEL_LOW>; + pinctrl-names = "default"; + pinctrl-0 = <&trackpad_pin>; vdd-supply = <&pp3300_s3>; wakeup-source; + status = "fail-needs-probe"; }; }; @@ -197,3 +200,7 @@ pins-vreg-en { }; }; }; + +&trackpad { + status = "fail-needs-probe"; +}; diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola-tentacool-sku327683.dts b/arch/arm64/boot/dts/mediatek/mt8186-corsola-tentacool-sku327683.dts index c3ae6f9616c8..4dbf2cb73a81 100644 --- a/arch/arm64/boot/dts/mediatek/mt8186-corsola-tentacool-sku327683.dts +++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola-tentacool-sku327683.dts @@ -17,6 +17,8 @@ trackpad@15 { compatible = "hid-over-i2c"; reg = <0x15>; interrupts-extended = <&pio 11 IRQ_TYPE_LEVEL_LOW>; + pinctrl-names = "default"; + pinctrl-0 = <&trackpad_pin>; hid-descr-addr = <0x0001>; vdd-supply = <&pp3300_s3>; wakeup-source; diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola-tentacruel-sku262148.dts b/arch/arm64/boot/dts/mediatek/mt8186-corsola-tentacruel-sku262148.dts index 447b57b12b41..ee5bc2cd9e9f 100644 --- a/arch/arm64/boot/dts/mediatek/mt8186-corsola-tentacruel-sku262148.dts +++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola-tentacruel-sku262148.dts @@ -19,6 +19,8 @@ trackpad@15 { compatible = "hid-over-i2c"; reg = <0x15>; interrupts-extended = <&pio 11 IRQ_TYPE_LEVEL_LOW>; + pinctrl-names = "default"; + pinctrl-0 = <&trackpad_pin>; hid-descr-addr = <0x0001>; vdd-supply = <&pp3300_s3>; wakeup-source; diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi b/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi index 18cfc99cfa3c..ff20376a44d7 100644 --- a/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi @@ -398,19 +398,17 @@ &i2c1 { &i2c2 { pinctrl-names = "default"; - /* - * Trackpad pin put here to work around second source components - * sharing the pinmux in steelix designs. - */ - pinctrl-0 = <&i2c2_pins>, <&trackpad_pin>; + pinctrl-0 = <&i2c2_pins>; clock-frequency = <400000>; i2c-scl-internal-delay-ns = <10000>; status = "okay"; - trackpad@15 { + trackpad: trackpad@15 { compatible = "elan,ekth3000"; reg = <0x15>; interrupts-extended = <&pio 11 IRQ_TYPE_LEVEL_LOW>; + pinctrl-names = "default"; + pinctrl-0 = <&trackpad_pin>; vcc-supply = <&pp3300_s3>; wakeup-source; }; From patchwork Tue Jun 17 08:20:03 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chen-Yu Tsai X-Patchwork-Id: 898103 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0B86293B5C for ; Tue, 17 Jun 2025 08:20:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750148425; cv=none; b=uZm8EjGJnuMR/6Gqb0Hh50q8698tv4228oJYe8bsrvry5+578+1EhqFall6E/lwwjxzjPkC/r1w9zF19jVYfisc0i4MFZyhOdcwIkmtNEMu/OIJRSgpjft7vzCvg+jo/f7kRYc9hflT+qazJ721kRYjUOzbOsivwjcL9b9Q0W6E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750148425; c=relaxed/simple; bh=8yYHhsk6aMkF+7LDvlU62jXCOJIeWXFnbuZRr/rWNfI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oiTbkj1NhwYoU8qo4N0hpjLgbgQyD1a+DinurZBIxAqFN/pIF/64g9QO3r79DODAxJ9hQ/tOeqpCW6jq0OxmrLPNPL2SiGyoq0JFWAjCZePY11WyVZHfTqsC7e1iHTWJZTSGhbvJEKpQ2KQTXBaztrYnhVq/pRSLDO4Amk4gxh8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=W9+d0LI8; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="W9+d0LI8" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-234b9dfb842so48934435ad.1 for ; Tue, 17 Jun 2025 01:20:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1750148423; x=1750753223; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=t0zl5UgUMJioINXEhfKw/OPFCjl4142IWY9RjIGoGFw=; b=W9+d0LI8+UdMHmzRSI819lrmhq8Z/1urzXKx/QhCCgI5Kr73XTflATW40xQRb7pR7r 8Wge0OBuNquzzBLYDm/fmJH75fwSDY3ijAZnTtaRr4b6MxSDqd1FyfXyGTSplLjDcp8/ HkVpmaTvORVcevstAv2mBshgvutS2d1jGzJ4g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750148423; x=1750753223; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=t0zl5UgUMJioINXEhfKw/OPFCjl4142IWY9RjIGoGFw=; b=TrZPQYbMF3bSmCuhQF+Ubeb/FcL7BBauDgt+gAMn69tmfD8JIylEiqGSrtgLStLoq3 BL47pSOREYk0diwI5u6Kbu/aqzhb6J3OzA0GWMjTpHfbES/fhBfxVFGA46ANWzSovxWN WKEwCieeGjOyF1oOyY/1pasPI7KVpJ6x81ODDSk9ws/N1wD1LEicBzPq185VWD/2d/pn 8gbHtNZk9FuCT9dzg/2zDuuKO75zLwYQCDWoXCdDIUPM9dkvm88LD/AztbSieuRfT5EA i5pC3X7KDw7qhHquWStgU43b75TWKbRUi81F8hqg61ZhwGDhq7ypxbye5l8uTD84VAiG igzA== X-Forwarded-Encrypted: i=1; AJvYcCV13WK/akJZ7W1T/BHx0QAWaq7oUCKA2TB33077nm6XgY/MmsryoQxEt+m1BfUkWHJyg9bxU2RECE1gTw==@vger.kernel.org X-Gm-Message-State: AOJu0Yxvj0ftpylWiaOaGkKB+LZ2ebgBZ7IbNGWTrEZLbYCAEFQU1szo 0IcuiSzAPT0oUrLtnvUMJhWfc6WFw1Ob/+gvHl8WdW1gYFof+rZAk4vYDEgwGjN+0Q== X-Gm-Gg: ASbGncsJCJBAjSSS2oMV+zNnpIO4SIEkVtFkQsZ6j+Nw4M10lpihx22VG5UxPG3iTsf oL/wV4JXE5yIDmoOHVBQkJuUEUS6/4CAkcRtXWxYve0fst2egF0kDAZIidYQga5m+f0HjxvXT+l Dn+T2syUr8VJQs2inS57KT36KKBOI1rrQFBSf064XSHtNskcYiID66HEyq7eWOi0MElWOZzUvwH AqBIk6CbpAq4FFYvvkF8sCCS2xDlsLY1FZjTtrKFyhcp9cjROM6Nu87Cg6Z68inApaFk4C0zuMk 2JKD7skPEf31+1WUkmvy2yXMkTdpfb0+IclkYWDzgLZ5lYQtiAQZztYP4LOf9ilnU8Uy9OwrUuu u0w9C X-Google-Smtp-Source: AGHT+IF4kxUCNX955eBUeMtmUp09tZHq5eVY7way6VVQf06qYS7+0eKNuGC1EFb0EH+rMHbB8Kt5lw== X-Received: by 2002:a17:903:440f:b0:235:60e:3704 with SMTP id d9443c01a7336-2366b32ccafmr198804545ad.12.1750148423221; Tue, 17 Jun 2025 01:20:23 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2401:fa00:1:10:24a1:2596:1651:13d8]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2365de781f7sm74598885ad.110.2025.06.17.01.20.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jun 2025 01:20:22 -0700 (PDT) From: Chen-Yu Tsai To: Matthias Brugger , AngeloGioacchino Del Regno , Dmitry Torokhov Cc: Chen-Yu Tsai , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-input@vger.kernel.org Subject: [PATCH v3 6/6] arm64: dts: mediatek: mt8186: Add Squirtle Chromebooks Date: Tue, 17 Jun 2025 16:20:03 +0800 Message-ID: <20250617082004.1653492-7-wenst@chromium.org> X-Mailer: git-send-email 2.50.0.rc2.692.g299adb8693-goog In-Reply-To: <20250617082004.1653492-1-wenst@chromium.org> References: <20250617082004.1653492-1-wenst@chromium.org> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Add a device tree for the MT8186 based Squirtle Chromebooks, also known as the Acer Chromebook Spin 311 (R724T). The device is a 2-in-1 convertible. Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Chen-Yu Tsai --- arch/arm64/boot/dts/mediatek/Makefile | 1 + .../dts/mediatek/mt8186-corsola-squirtle.dts | 107 ++++++++++++++++++ .../dts/mediatek/mt8186-corsola-steelix.dtsi | 2 +- 3 files changed, 109 insertions(+), 1 deletion(-) create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-squirtle.dts diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile index a8b8796276aa..a4df4c21399e 100644 --- a/arch/arm64/boot/dts/mediatek/Makefile +++ b/arch/arm64/boot/dts/mediatek/Makefile @@ -68,6 +68,7 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-magneton-sku393218.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-ponyta-sku0.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-ponyta-sku1.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-rusty-sku196608.dtb +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-squirtle.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-starmie-sku0.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-starmie-sku1.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-steelix-sku131072.dtb diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola-squirtle.dts b/arch/arm64/boot/dts/mediatek/mt8186-corsola-squirtle.dts new file mode 100644 index 000000000000..f721ad4e5c97 --- /dev/null +++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola-squirtle.dts @@ -0,0 +1,107 @@ +// SPDX-License-Identifier: (GPL-2.0 OR MIT) +/* + * Copyright 2024 Google LLC + */ + +/dts-v1/; +#include "mt8186-corsola-voltorb.dtsi" + +/ { + model = "Google squirtle board"; + compatible = "google,squirtle", "mediatek,mt8186"; + chassis-type = "convertible"; +}; + +&i2c1 { + touchscreen@10 { + compatible = "elan,ekth6915"; + reg = <0x10>; + interrupts-extended = <&pio 12 IRQ_TYPE_LEVEL_LOW>; + pinctrl-names = "default"; + pinctrl-0 = <&touchscreen_pins>; + reset-gpios = <&pio 60 GPIO_ACTIVE_LOW>; + vcc33-supply = <&pp3300_s3>; + status = "fail-needs-probe"; + }; + + touchscreen@16 { + compatible = "elan,ekth8d18", "elan,ekth6a12nay"; + reg = <0x16>; + interrupts-extended = <&pio 12 IRQ_TYPE_LEVEL_LOW>; + pinctrl-names = "default"; + pinctrl-0 = <&touchscreen_pins>; + reset-gpios = <&pio 60 GPIO_ACTIVE_LOW>; + vcc33-supply = <&pp3300_s3>; + status = "fail-needs-probe"; + }; +}; + +&i2c2 { + trackpad@68 { + compatible = "hid-over-i2c"; + reg = <0x68>; + hid-descr-addr = <0x20>; + interrupts-extended = <&pio 11 IRQ_TYPE_LEVEL_LOW>; + pinctrl-names = "default"; + pinctrl-0 = <&trackpad_pin>; + vdd-supply = <&pp3300_s3>; + wakeup-source; + status = "fail-needs-probe"; + }; +}; + +&i2c5 { + clock-frequency = <400000>; + + /delete-node/ codec@1a; + + rt5650: codec@1a { + compatible = "realtek,rt5650"; + reg = <0x1a>; + interrupts-extended = <&pio 17 IRQ_TYPE_EDGE_BOTH>; + avdd-supply = <&mt6366_vio18_reg>; + cpvdd-supply = <&mt6366_vio18_reg>; + pinctrl-names = "default"; + pinctrl-0 = <&speaker_codec_pins_default>; + cbj-sleeve-gpios = <&pio 150 GPIO_ACTIVE_HIGH>; + #sound-dai-cells = <0>; + realtek,dmic1-data-pin = <2>; + realtek,jd-mode = <2>; + }; +}; + +&sound { + compatible = "mediatek,mt8186-mt6366-rt5650-sound"; + model = "mt8186_rt5650"; + + audio-routing = + "Headphone", "HPOL", + "Headphone", "HPOR", + "HDMI1", "TX"; + + hs-playback-dai-link { + codec { + sound-dai = <&rt5650>; + }; + }; + + hs-capture-dai-link { + codec { + sound-dai = <&rt5650>; + }; + }; + + spk-hdmi-playback-dai-link { + codec { + sound-dai = <&it6505dptx>; + }; + }; +}; + +&speaker_codec { + status = "disabled"; +}; + +&trackpad_steelix { + status = "disabled"; +}; diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola-steelix.dtsi b/arch/arm64/boot/dts/mediatek/mt8186-corsola-steelix.dtsi index 822a177e7c19..8a196dc9a96b 100644 --- a/arch/arm64/boot/dts/mediatek/mt8186-corsola-steelix.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola-steelix.dtsi @@ -118,7 +118,7 @@ &i2c2 { i2c-scl-internal-delay-ns = <22000>; /* second source component */ - trackpad@2c { + trackpad_steelix: trackpad@2c { compatible = "hid-over-i2c"; reg = <0x2c>; hid-descr-addr = <0x20>;