From patchwork Thu Jun 19 05:35:09 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shiji Yang X-Patchwork-Id: 898647 Received: from TY3P286CU002.outbound.protection.outlook.com (mail-japaneastazolkn19010009.outbound.protection.outlook.com [52.103.43.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69BA52417FA; Thu, 19 Jun 2025 05:36:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.103.43.9 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750311367; cv=fail; b=abIy3urFPEtL+BrfZxwQwp3y2LgV1mBTSGx5OO0jkRHaGnSlh4GBQ7iwg6gi4tWJhMqXoHaef4BFgbRkMhHRZhVg0Q1QkCaStUuSy8cXG+oQF69/Nm34JRELDy9+nYaEtjmG8DVn6wrsTGBjr2uwpyhDB3ISzpGDJt5ucv7aoH8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750311367; c=relaxed/simple; bh=l9E28H91SuiRZMiYj2wavzdI2QvFKzUsV5UOywqrTQA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=aCLO8ENTEaujygLRsiprlWMGrSVgrYPmrwujytdk/iB7/OLqkAlmFB17EM6q/FSyw7rJNwdKp9/ARfsiR9riwvFG89uAiB06B969iRlenYZMIIEfwXH33s9qYiUBFbbqg7YPxJ9e3fvj163thfpHTgPkfjjBWs4fIqM7WTd9cGU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=outlook.com; spf=pass smtp.mailfrom=outlook.com; dkim=pass (2048-bit key) header.d=outlook.com header.i=@outlook.com header.b=Qw0Wxa4X; arc=fail smtp.client-ip=52.103.43.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=outlook.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=outlook.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=outlook.com header.i=@outlook.com header.b="Qw0Wxa4X" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=igZR7jAJM9DORW36wUArvk/m531YVS9lx9aMvAZd7V3pB3ZtpAlC4BurqAA8AmViuDqc0nqQU2ELEB2CUjHA5q/kDe37kEz9MDk4nLfbYtV6imMxUEL3TsiL/SCUE5eZe+KQXPcdw+H81iG1uKdKT9faq3NflZ8YhQ4Nfe+RIfjwMYX1d8CH3HAK/irIs/OL8a4n2zkblIfQJEqDATDgJ1AIVdWT+5Qj1F6qRIye2WWItf4sDdtWcXDpzP/y1npYD8mvPQfQrpaFprHq97DvpuidcBFUSc/WgXEU/AVMiYGulXywvaMmask2K59Bk1Zbc7JBvuoVUR4n+mJRgg/Tog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Q4XNvnBmWktxueVjyOdJhHfHZggemsSL1h/OFPR7oMU=; b=hzyjXYgApZxIVyqfUHiKtCyaTpuuNQUmXYp2WEpsfrA7grffLzoSalB51V7vgwZWPNgcfkTSJY0cu0HKTNlaxM6xW8708fooNUe642MKSWZUGsFlwACGfgdf5MNX4AzsiZvcFYNOSnyE8oGAH+4zG50YNCsyemnBaXJKIe/imZ7CtIO8MeR7RsuBao8rQiw7gVk5oDrxopMfVUoAjBtDRH1af7D4Ct5TJNw9n0gm0rq/g/Wgy12xaQzEawUd4jqPgcHp7ltcI3UOjrFMXbsm0z1tAZ2fel9PJS6zmnUaaxreLdmamIHr5xbtlNS8l2zSToL6R8pUIMs6s0wO0k30WA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q4XNvnBmWktxueVjyOdJhHfHZggemsSL1h/OFPR7oMU=; b=Qw0Wxa4XnBsecqtkSqYTIgF+vEwbwiM3QAgJcrZXrwyxXGFTY5rrSEpaxEWiuoWfEx337Ce3PnGClCwYd0f2+b5fB1euRqX8fIZfIg/BgeGyIJi1++Y2cnZq6y36RIqdVKJvooTyP/Ai0R6SuwwmmtIDFPZGIQsePL3JJ1G2WdRb71k34bC6Sd6Z+SICg/uvY/PEYrRfkq3vqW471OFrULSBPpvXGTd+x1zG2TQhUR6BkXynahhyrtx35p55pcqmvmNK/QzycEpe+QM2s9wJQ/rUWoivUQ0V9leHAJSbqdtR80IWVOh2/4K+DAruqq0Gh6rRBij0gaWq61rSqWy+xA== Received: from OSBPR01MB1670.jpnprd01.prod.outlook.com (2603:1096:603:2::18) by OS9PR01MB16295.jpnprd01.prod.outlook.com (2603:1096:604:3f3::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.20; Thu, 19 Jun 2025 05:36:02 +0000 Received: from OSBPR01MB1670.jpnprd01.prod.outlook.com ([fe80::c00:ec4e:ee7e:9b7f]) by OSBPR01MB1670.jpnprd01.prod.outlook.com ([fe80::c00:ec4e:ee7e:9b7f%7]) with mapi id 15.20.8857.016; Thu, 19 Jun 2025 05:36:02 +0000 From: Shiji Yang To: linux-mmc@vger.kernel.org Cc: Chaotian Jing , Ulf Hansson , Matthias Brugger , AngeloGioacchino Del Regno , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Shiji Yang Subject: [PATCH 1/4] mmc: mtk-sd: disable auto CMD23 support for mt7620 Date: Thu, 19 Jun 2025 13:35:09 +0800 Message-ID: X-Mailer: git-send-email 2.50.0 In-Reply-To: References: X-ClientProxiedBy: SI2PR01CA0032.apcprd01.prod.exchangelabs.com (2603:1096:4:192::18) To OSBPR01MB1670.jpnprd01.prod.outlook.com (2603:1096:603:2::18) X-Microsoft-Original-Message-ID: <20250619053512.14507-2-yangshiji66@outlook.com> Precedence: bulk X-Mailing-List: linux-mmc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OSBPR01MB1670:EE_|OS9PR01MB16295:EE_ X-MS-Office365-Filtering-Correlation-Id: be60d073-8594-4d74-60ae-08ddaef32d03 X-Microsoft-Antispam: BCL:0; ARA:14566002|461199028|12121999007|19110799006|7092599006|15080799009|8060799009|5072599009|40105399003|51005399003|3412199025|440099028|1710799026; X-Microsoft-Antispam-Message-Info: rUNwlLDvLN5hWeYJVTncjGv1AUenfXNk7CZCqLO//fR5wfxtjDvG5goria5Q+yGN7b6r34uE+awIbkHG/QdSkYmEy0GEGithZsgMJAkyxVQ5MWuIKCVDCXrzg9lSPJCNydNrVkMgsKds/g2Cgf3onmBf49ImBmoc4eNiOGQaZ92xIcjb4yrg5Bcwpe3rEQoUG2JsgQck3zcJ96w5rIrCJfhu+ND3jtguCPAurHlVNyFSLL24FFC91kyebPU4ZvHV7bzY0++THo3bKhVrMI/OKAMJ+/W6IICWDLn6QE/zCfbLRnVhig8WwuvythJUeLSfRmpYSCxzI86jzrd8PkZj7onXBPzZt9prVQzGvW40BKYNt2KOgZ5LG25r92sDkPEkx+4uH7ZNDK5Emzs1CaxKjho1eL9q9zoDvVcAk0Tew804RuVS0A8rPK54JjIm4abG2o1Kyny4Ea3iTjGWROCCZ7OHk/qw1PN2kFM8oCWwKRU5xkZJCGzPDBDPuwhaY+UimAJBXPdaiINv7RUtFAIjVqlwoVVa+XzYNp7/hcMG9i3dVXzamJQ2QU6/iG0s6JyO2T0pxaPJW8ThY8GdiwnY6hbzoh8GYDW+njKKYtGW7ZDA6C14AzYAMABPRrCbqJxIajM9+q12i/WdkAjUDJrawz56b7R+mhwQuF+Gxh54M5jzAfrRhF2GM90DoksbkOgOoolxrYCi6GW5YKKUAnvO49pHk15s0nZZKNbRmzcN1qnNllNmIFnWGKdXqKi3kRORXFxpXSmS9B9x/GDWQFllHy9u2pGYmaFPsp8WeZCsujjCPA91mwjDWdFjRAB5tmwCMpQOA9eM2sPSMwvTTrzawF7OWWnc4ufmjWN8ZeTV44kZtCrRVZVHdBta7CBGanAbbzjiAlwiwnJS2ljQM761OiNLtnz6CVRPBk40I+AYin/7aInRayMnFuBXvwHqjtgo6ExPfA3W+sVa0ZJC5Q0l/MURx4r5F3m/bHs4JVjER55/FVCocWCnT6lr+lWs0wRWdqXQyZGyX+ejjWoMzRa+jwUh5idO+Hw/vKwsyYZ5X3QMPxJGr3rbnSnaZ+KLwciTghXGnqZigNaP+Iei0D7CUjnv+UEeM7oNpVTZiWEtDN+V4qVDRVvoKcsMZHSYNYE80rjobRVDamA5DJIPAFKJp1EOOmxrbXmlU+fk+EW7gT5o+A+LejuuLF1KSRqMxipmeChPB/kTPbuaGi3FnbsRZ7hv7mnzwdb3HYFX3UFJn5g= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 8K5C5y3zQKThqVbsqnftNguzhEjo/AJC3gtkuLz+r52+nCtuzYSHHoKSwt+ML7WrAaBihdPf1FJRjo/aThP2B6HeHBBU6dUdSenpM38Ti70TLNWPhUWaltrpcGsV5WKr+vlxWQK0pa91tKbff8Z5IL0eG0HeNFEGEQ1J3iJo37ZngiNYZlAbHqlFs8tAPg5+x6JkV/8IOrVhgRAkCrxXYzqDJcqb+a56NxwE/GPkfIzppUf9w7BxF5r3WeqYedqvnWQIWkeSNMLASZfd5MiLKbLkY3fzHe/s7xlbljthveU/ypUwjVKQ717pDpf9Nm7fbGYlbwYP69tsxa1o2yffKULmV5gp2m5ougkF57uIqZgOwEFoTr1uPefutIWHVi28jkdJQ0DTI8/MBN9tFRLoaRPUlV3yHezC5iLOXNhtAp7hZ5nOtHJ4S9gFvBW6Qs08+fzGmRoiBwCdMNbrsWL0q3LIBxIFxqeR6ku4Jk2lpKVLOhKU+BsMjM851g7jKkHWlvF5fWWeMHbn+SV3sHKsXmaB63wmti/ZOM0ys67s1m2G5LszDsXnjLdlg9ZTRt1Eda+j3EmTwbv+swi0mJJpkx0M8NNk+nKkve7H2aoYCpEJEreEtzi3tiEeHq27XSG4gwKoKZxYU9BWemiCTkPDP403eEdEr7CbOezWtq9T/0ZACEkZVNipJ+qpmTypO+dWD5JlpdUTQ8LmJ4IHNnAAY0ujNmnlDD04Iz7yozonmeg+HtLmEdqpgppwZYBc4fEBWAt6rDYMGZofGrP/W05xdIAKF5Wl//Lrljbwozhmo9JcZ4r7O/ZA4YfYWcbn219FKjlsCPlLv077cmF6x2Y+B4Xu8jfKO9cXiVcX024VZMatW91wz5aONu8HBGdbhwwtjAPNEFV4J01i3L1oEdCaj2h0gqapzOqZ0VDDkffgwklzPmWn9wr26VHyyU1bB1yfmXVl+3/qRofuRNu72ls2vb9mI6Qxk06dQOaEc2pIX3GHsEmFwn4TdDGhAEWsVDy3p3ceLMjs6jl4L3EYrdUb4Ucym9aLlwOZJnfDHvTetPBma+wkfhkc9o3WduLoORHkV0OxnME6KJGdof+cykYcuiMQ1gS/jGtfVk8m9b9L6WAvYFkTQuiokZVBWz4oFQbHfEqVhgdmbXN3UYdzw0w03SdDDkgCuPSeNwM+LxNduh5QGaGHVVLIc7KUVYS2EnnYH6Gtpm5fKPjpjSbKRF5QtxRBQb9hfoHeEeCyLDNfbMsa/ar2V5pfCC73Pntaoiem X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: be60d073-8594-4d74-60ae-08ddaef32d03 X-MS-Exchange-CrossTenant-AuthSource: OSBPR01MB1670.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2025 05:36:02.2843 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS9PR01MB16295 MT7628 ProgrammingGuide indicates that the host controller version 3.0 and later support auto CMD23 function. However, it doesn't define the SD command register BIT[29](Auto CMD23 enable bit). I guess the legacy MIPS MT762x series SoCs don't support this feature at all. The experiment on JDCloud RE-SP-01B(MT7621 + 128 GiB EMMC) shows that disabling auto CMD23 can fix the following IO errors: [ 143.344604] mtk-msdc 1e130000.mmc: msdc_track_cmd_data: cmd=6 arg=03B30101; host->error=0x00000002 [ 143.353661] mtk-msdc 1e130000.mmc: msdc_track_cmd_data: cmd=6 arg=03B30101; host->error=0x00000002 [ 143.362662] mtk-msdc 1e130000.mmc: msdc_track_cmd_data: cmd=6 arg=03B30101; host->error=0x00000002 [ 143.371684] mtk-msdc 1e130000.mmc: msdc_track_cmd_data: cmd=6 arg=03B30101; host->error=0x00000002 [ 143.380684] I/O error, dev mmcblk0boot0, sector 0 op 0x0:(READ) flags 0x80700 phys_seg 4 prio class 0 [ 143.390414] mtk-msdc 1e130000.mmc: msdc_track_cmd_data: cmd=6 arg=03B30101; host->error=0x00000002 [ 143.399468] mtk-msdc 1e130000.mmc: msdc_track_cmd_data: cmd=6 arg=03B30101; host->error=0x00000002 [ 143.408516] mtk-msdc 1e130000.mmc: msdc_track_cmd_data: cmd=6 arg=03B30101; host->error=0x00000002 [ 143.417556] mtk-msdc 1e130000.mmc: msdc_track_cmd_data: cmd=6 arg=03B30101; host->error=0x00000002 [ 143.426590] I/O error, dev mmcblk0boot0, sector 0 op 0x0:(READ) flags 0x0 phys_seg 1 prio class 0 [ 143.435585] Buffer I/O error on dev mmcblk0boot0, logical block 0, async page read Signed-off-by: Shiji Yang --- drivers/mmc/host/mtk-sd.c | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c index 31eb90536..53d63bb4e 100644 --- a/drivers/mmc/host/mtk-sd.c +++ b/drivers/mmc/host/mtk-sd.c @@ -445,6 +445,7 @@ struct mtk_mmc_compatible { u8 pop_en_cnt; bool enhance_rx; bool support_64g; + bool support_cmd23; bool use_internal_cd; bool support_new_tx; bool support_new_rx; @@ -535,6 +536,7 @@ static const struct mtk_mmc_compatible mt2701_compat = { .stop_clk_fix = false, .enhance_rx = false, .support_64g = false, + .support_cmd23 = true, }; static const struct mtk_mmc_compatible mt2712_compat = { @@ -549,6 +551,7 @@ static const struct mtk_mmc_compatible mt2712_compat = { .stop_dly_sel = 3, .enhance_rx = true, .support_64g = true, + .support_cmd23 = true, }; static const struct mtk_mmc_compatible mt6779_compat = { @@ -563,6 +566,7 @@ static const struct mtk_mmc_compatible mt6779_compat = { .stop_dly_sel = 3, .enhance_rx = true, .support_64g = true, + .support_cmd23 = true, }; static const struct mtk_mmc_compatible mt6795_compat = { @@ -576,6 +580,7 @@ static const struct mtk_mmc_compatible mt6795_compat = { .stop_clk_fix = false, .enhance_rx = false, .support_64g = false, + .support_cmd23 = true, }; static const struct mtk_mmc_compatible mt7620_compat = { @@ -588,6 +593,7 @@ static const struct mtk_mmc_compatible mt7620_compat = { .busy_check = false, .stop_clk_fix = false, .enhance_rx = false, + .support_cmd23 = false, .use_internal_cd = true, }; @@ -603,6 +609,7 @@ static const struct mtk_mmc_compatible mt7622_compat = { .stop_dly_sel = 3, .enhance_rx = true, .support_64g = false, + .support_cmd23 = true, }; static const struct mtk_mmc_compatible mt7986_compat = { @@ -618,6 +625,7 @@ static const struct mtk_mmc_compatible mt7986_compat = { .stop_dly_sel = 3, .enhance_rx = true, .support_64g = true, + .support_cmd23 = true, }; static const struct mtk_mmc_compatible mt8135_compat = { @@ -631,6 +639,7 @@ static const struct mtk_mmc_compatible mt8135_compat = { .stop_clk_fix = false, .enhance_rx = false, .support_64g = false, + .support_cmd23 = true, }; static const struct mtk_mmc_compatible mt8173_compat = { @@ -644,6 +653,7 @@ static const struct mtk_mmc_compatible mt8173_compat = { .stop_clk_fix = false, .enhance_rx = false, .support_64g = false, + .support_cmd23 = true, }; static const struct mtk_mmc_compatible mt8183_compat = { @@ -659,6 +669,7 @@ static const struct mtk_mmc_compatible mt8183_compat = { .stop_dly_sel = 3, .enhance_rx = true, .support_64g = true, + .support_cmd23 = true, }; static const struct mtk_mmc_compatible mt8516_compat = { @@ -671,6 +682,7 @@ static const struct mtk_mmc_compatible mt8516_compat = { .busy_check = true, .stop_clk_fix = true, .stop_dly_sel = 3, + .support_cmd23 = true, }; static const struct mtk_mmc_compatible mt8196_compat = { @@ -687,6 +699,7 @@ static const struct mtk_mmc_compatible mt8196_compat = { .pop_en_cnt = 2, .enhance_rx = true, .support_64g = true, + .support_cmd23 = true, .support_new_tx = true, .support_new_rx = true, }; @@ -3054,7 +3067,9 @@ static int msdc_drv_probe(struct platform_device *pdev) if (mmc->caps & MMC_CAP_SDIO_IRQ) mmc->caps2 |= MMC_CAP2_SDIO_IRQ_NOTHREAD; - mmc->caps |= MMC_CAP_CMD23; + if (host->dev_comp->support_cmd23) + mmc->caps |= MMC_CAP_CMD23; + if (host->cqhci) mmc->caps2 |= MMC_CAP2_CQE | MMC_CAP2_CQE_DCMD; /* MMC core transfer sizes tunable parameters */ From patchwork Thu Jun 19 05:35:10 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shiji Yang X-Patchwork-Id: 898208 Received: from TY3P286CU002.outbound.protection.outlook.com (mail-japaneastazolkn19010009.outbound.protection.outlook.com [52.103.43.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0FED242D65; Thu, 19 Jun 2025 05:36:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.103.43.9 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750311369; cv=fail; b=HtESc80IZzknQqTIpRRKwCJ4M3oxBo2d0xYQ1N+xADOgfJFpHSQ/yEWfPAE/TInLiDNtTbvmvwLOoIhzg/wVh389TsrLKNERvbeQlIS/6f+RUUD6vR5t2JXomgGSdOIvBAUwUHsEZXPLjfb8TDvIKJcRefc7Wg/FKnCxgDdWIyY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750311369; c=relaxed/simple; bh=CnmapRIrZmmuiV5GretVNszS0woofNOuD4gzoHN85js=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=W7FMRehy/rkv4gxcvnOtvFocmmDoI6zZlF9Nq0C4zMsJzSNl5FYHePy8FZF7dh53P6Wc1hIUEQu6LdcfWjhfev4gZ+0EsLuvSqKRejAqaszf4jJBBKo09NixV4HO06bIdm2AjDR6/O/x1Tv4hLFy+Osa490mbbF6hYWLl8naZ30= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=outlook.com; spf=pass smtp.mailfrom=outlook.com; dkim=pass (2048-bit key) header.d=outlook.com header.i=@outlook.com header.b=Km7n3QS/; arc=fail smtp.client-ip=52.103.43.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=outlook.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=outlook.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=outlook.com header.i=@outlook.com header.b="Km7n3QS/" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZZgz9WD5TysDhyzaqKppffbiQ/sSle4dwdWvRW6kjVUkmzao86Q0Uodn5DBw5Au1r5H+5mNAqUMxxI1lPM9Wz4DF1VcbB7aQY7vnABmiisCXD3W5I8yOo7bJUaqNYDoG9gjKBD0iqdZOdEqgvtPoDxMUXXiqvk8XMkBtSqpSbidbhoOO7YBqvYZhDi7bEKTetPepj4HFRY2+gOBnx249DHfKTadq9EIvS6wml6bua/B9dRlt7lmGelHeBmxo9e3g5ufCAgfeBYfhevF7NhLRSb+O5Bo2M8CM6cugpPbCGLr2zACcSEcQBzY/wvHFWtsLWakCWRJmwGJWJefbW7zwuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BsHhN8Sa1C64Bo9nY+E0KG8EOfTCWgxRV1weeY9UOtM=; b=aVLcEGnnS2DS64+fea0Cn/13xMOzIMhfy+Doo27vp4UegyK19R4mnXovgG969q5UENZdgMieqLQbb1bjJscltworCmZfJLgZffU7H0X2U3DZ5dS4tdYust+4gxPnPxnZRYvtcCrVaZ9ALlSzYs/ZpUpfMDCiwJUyQz+iEVXFNlwVTzJQiQAEHOcnsfQae3QOc7Sosa+eRwf1htehtNLsYPChbO2vFyCV1vHs3Svnu1a13c1d37BqhueL/e0aNcXpXKuGPYFqI9lYuFwhk1zfp2/+xbOrSujzA5mQ8XMvkx/vULU94STeRxT4+iRsDzyPAjDpIUKR0xoDln4slo8MaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BsHhN8Sa1C64Bo9nY+E0KG8EOfTCWgxRV1weeY9UOtM=; b=Km7n3QS/iGjyI6Lm2YfoTlYZL2bkSs/TYYcyk/3+lzDb8bqgdYlIIj9grRcqSdME7mtSWPOc0BU1snp5FIM7cOMV6bESP2/+9qP9sgfHurGBRe/wexyxK7lPte3CeLwNX0ydIGRZfZXnYerkBhAO0eVsZ3UxVA/7HRC5ZJGw5Wcwyo6X7taKk0CykuoSNOHVA+AQo+7YFEEAo5ex1LyujlZ2oFj+J3A6r76M6R+rQB1WZQBKlqoYfNI/M9bJ7GnqUeRndBuEzxjxBvboz+uu0RNw1xMwc57Vbnntpv9pvmYPZC12S6tx5HkDbNl1xAoyhE/g+BiObueb4H4ncoTmZg== Received: from OSBPR01MB1670.jpnprd01.prod.outlook.com (2603:1096:603:2::18) by OS9PR01MB16295.jpnprd01.prod.outlook.com (2603:1096:604:3f3::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.20; Thu, 19 Jun 2025 05:36:05 +0000 Received: from OSBPR01MB1670.jpnprd01.prod.outlook.com ([fe80::c00:ec4e:ee7e:9b7f]) by OSBPR01MB1670.jpnprd01.prod.outlook.com ([fe80::c00:ec4e:ee7e:9b7f%7]) with mapi id 15.20.8857.016; Thu, 19 Jun 2025 05:36:05 +0000 From: Shiji Yang To: linux-mmc@vger.kernel.org Cc: Chaotian Jing , Ulf Hansson , Matthias Brugger , AngeloGioacchino Del Regno , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Shiji Yang Subject: [PATCH 2/4] mmc: mtk-sd: add default tuning parameters for mt7620 Date: Thu, 19 Jun 2025 13:35:10 +0800 Message-ID: X-Mailer: git-send-email 2.50.0 In-Reply-To: References: X-ClientProxiedBy: SI2PR01CA0032.apcprd01.prod.exchangelabs.com (2603:1096:4:192::18) To OSBPR01MB1670.jpnprd01.prod.outlook.com (2603:1096:603:2::18) X-Microsoft-Original-Message-ID: <20250619053512.14507-3-yangshiji66@outlook.com> Precedence: bulk X-Mailing-List: linux-mmc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OSBPR01MB1670:EE_|OS9PR01MB16295:EE_ X-MS-Office365-Filtering-Correlation-Id: e77c9364-6e22-4179-143e-08ddaef32f8d X-Microsoft-Antispam: BCL:0; ARA:14566002|461199028|19110799006|7092599006|15080799009|8060799009|5072599009|40105399003|51005399003|3412199025|440099028|1710799026; X-Microsoft-Antispam-Message-Info: 0cqiUfJLQzebvEElArWF2MXxRzUY2odTLC2rC4leHVs2banQCGBMA+EYhOUsohB9r9Nt9FqJLcsxApOJUG3hse1We1F+iGA7jZkB3i0Ukce7FaukFEW1cX3nWHY0KoX8sBgpu//ynEKW0hSfKjyiVpi03GtHDLwKbYvyKRiL0PD5di95uL1xFRBw2DQqEb39GjD9LpAL6MNQpFRtLhO8K8K/D+xa3VDwhVIZjC5d4pIkiiMGwCMCqOfD7I/lfWvh4hVP01a8vDd+ikHux+grqI+hfCaZOrcnS9RrdVn1z8EkcXa9p97hrYuzGMOgxParFCBREcprJ81oXgaJHeMao3kveS2j7MZHpmZwqA43POm7oviRPavRHc2Ox8u1KyU7iz0WA9WNOW3UcqLoivQz5ox59qr7x9l/bCzi0AQvwfDrWj/ChVSM2pfxp1PU5e3tu3nNU84fP8xZCtL8XseTQQrNGSyKOWESVxBecADQVfGdBrFxJ1GGU/3BHaaX8lM2XL8rcW8UYVRPkTs/jxwMTziblOgmjLcG/stv89Nrefc2hzpOfCddOo57iwOQ3fe0M7Otn6G9dYzzubromsq8Vh2lLuzbyyZ9pRU3vgwSsX25GIDiejKQjVIZWz1z03v962sYoRNQmBTF00lFvcvd2ox6BsfJEwn/TuzGqO6gATl3gEBp6Q/KkFN4cFmSCptsXXjMjgvq+iOy9Ra9JOMBGxSlWEkycpJlTOUFsstxC7zu6LY81DOs1vAvC7qTpDsOTaGqAfZ1JYcEpZnxr+55ojmRaSRCY7TncXqS/XKkgTgH8HMLDaiWVRM2dsctiJHNw7kmo1rAIC/xahGvHH3N16nEhpbwFSMDOPIpRyph5v44N2NmjVw02iVHoV1NRe18tQOkkdyIFn4fj1/WPRKBYrRdGMvo5oBeLKhKe1iDe9pOWlO8et/vYG1FIvkCrOxX76Y1RRtidG7f3l+jQs6zzYhzP9aK2WdMO1BJNSoDm/OZWPftJspmCrYSFZWtkkG4eqN+/Z7ylkIVRd4NxFuOpRT+ScqvsIM6HArcpyEy5VPQOBLQBpBfU1xu/szKGia/4euRYWEaf/uV9DhQbqIscciP+qjH36ykojlRVlxdbrLKI/ze+9L0ROwTeEHPYlZFOtWmT47jABqtKsPOcQaRqY6ngPcpT6naOQ3tjGCLs/cCkMaAsXudr6vgcEZR6uzXrom5OgEcoR1ziEmeqXu5PA== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: ijQRo5pDBnbFT8jaQI79zlE8Dc1BhP+chJ3tC0XRBJomMYnx1VRyiWcDr2S3Wj9C3rygmDd0ysENTs0td2b8Y4pUOwdZHaAuA86PDiF/7Rfce0tB8GP01SeKMqfaMPHXjcCNtJCzSaxAOG/AGQMl0YD9+OVlXemS1jE2AAq5q2Sdrc0OkNlyswCHUjI2yCpO52CcIKz6hW77BmFxQVBl2AFX22WtMEdLeXlIj7/K1YYmVLPMIrCWW9XtX9SQYPn/n27aH9IjgqSb/prD4ZNX7EL5zrOJgzQn7yT6eQt0pFlG0cjhV50aKFpC72C9Y7HLvw2kpGXtwxUbIO2clmB7gFMzMnac2t4XfSdx8ByTFraFo+eSAU7q0SfoHiKou7VsSg7o71pDHz2KnxaDzoxisVB6KLVGa8SouMybmfyQWeUWjsxe8k1l4U2ucru5nrP3suuvCwCyv9xANw2hyRWZ6AVrNgkjOCLdBftJVSHMAHpx8c5YSW2mpO3ImDYhyhzGhYyBFO3UvA5CeyyDDOfhqvlwMiYfGKLb/4GxtOH+oQUJcORsaRpu5hk0UQFI3I6XuelUQVjXezIcIM6vEppELTnRNb4GqV3FM3csVqJs18jkNil7Ex76Ty+WkVRqpDxeX7jw3pmpV8U9surt2+lSMlVVP6A8mQDVuoIyCt6xRwF1gC676g4Vmu/Zv5JeAUVM0JHU1uXjrMJB+Djof2XmQjXtNMU0N9vCmpdcFzsF64z3+439GX4xe1WRwUOdC5GlBP+IIN6JFhAGvBhR5cXzUmqQqZifkDLgruKnG4MY/xpkmoVgNpJwX54+yMa7lXxrcQ29eTYHPnhor/DPDmiM+Ecshy3FvOlMvdqluGvcb54meAGaWflkEz+NcaRYYmApC2XdITbxSxbn2/fUIUAYL8cdHrXxSE/10nz+OcShXT+4yPOx6e/j0GsenPQs20fhJ/nbH1f+G4R/6BoTpwxTRFti+cavMm3FPrgafoqWjU2QpkxCGKe/+5EeSSyOxizzc403AjJmf4pSojHdodc7a8YBCD+QzZecJDlUOPaVb458tQtR5Da+6dO5sSHsUJO7ee/2FbCoVk8MyAZNKcucT1Z3M+IbXe3jUHdw9R7dTm+xGPe5U8CtnhtTzDMYEHbrUY+kGWdBH4FWmCF4RxTRK/rsvLlhdl3lh275OL/m27cD5+d2q6h88KHnbd62XLPM4WHXx1uZxgFC1sR4FgeH7lSk+3nHxd9Yg8YwgJ5q+tu9jmY0D5g2cO8t8gT85OjU X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e77c9364-6e22-4179-143e-08ddaef32f8d X-MS-Exchange-CrossTenant-AuthSource: OSBPR01MB1670.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2025 05:36:05.8157 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS9PR01MB16295 The MIPS MT762x SoCs require some specific tuning parameters at different clock frequencies. These legacy SoCs only support max 48~50 MHz High-Speed SD mode. Therefore, the standard tuning step is not available. We have to hardcode these tuning parameters to make them work properly. Signed-off-by: Shiji Yang --- drivers/mmc/host/mtk-sd.c | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c index 53d63bb4e..52198daef 100644 --- a/drivers/mmc/host/mtk-sd.c +++ b/drivers/mmc/host/mtk-sd.c @@ -79,6 +79,8 @@ #define MSDC_PATCH_BIT2 0xb8 #define MSDC_PAD_TUNE 0xec #define MSDC_PAD_TUNE0 0xf0 +#define MSDC_DAT_RDDLY0 0xf0 +#define MSDC_DAT_RDDLY1 0xf4 #define PAD_DS_TUNE 0x188 #define PAD_CMD_TUNE 0x18c #define EMMC51_CFG0 0x204 @@ -449,6 +451,7 @@ struct mtk_mmc_compatible { bool use_internal_cd; bool support_new_tx; bool support_new_rx; + bool mips_mt762x; }; struct msdc_tune_para { @@ -595,6 +598,7 @@ static const struct mtk_mmc_compatible mt7620_compat = { .enhance_rx = false, .support_cmd23 = false, .use_internal_cd = true, + .mips_mt762x = true, }; static const struct mtk_mmc_compatible mt7622_compat = { @@ -1090,7 +1094,12 @@ static void msdc_set_mclk(struct msdc_host *host, unsigned char timing, u32 hz) * mmc_select_hs400() will drop to 50Mhz and High speed mode, * tune result of hs200/200Mhz is not suitable for 50Mhz */ - if (mmc->actual_clock <= 52000000) { + if (host->dev_comp->mips_mt762x && + mmc->actual_clock > 25000000) { + sdr_set_bits(host->base + MSDC_IOCON, MSDC_IOCON_RSPL); + sdr_set_bits(host->base + MSDC_IOCON, MSDC_IOCON_DSPL); + sdr_set_bits(host->base + MSDC_IOCON, MSDC_IOCON_W_DSPL); + } else if (mmc->actual_clock <= 52000000) { writel(host->def_tune_para.iocon, host->base + MSDC_IOCON); if (host->top_base) { writel(host->def_tune_para.emmc_top_control, @@ -2028,6 +2037,13 @@ static void msdc_init_hw(struct msdc_host *host) MSDC_PAD_TUNE_RXDLYSEL); } + if (host->dev_comp->mips_mt762x) { + /* Set default tuning parameters */ + writel(0x84101010, host->base + tune_reg); + writel(0x10101010, host->base + MSDC_DAT_RDDLY0); + writel(0x10101010, host->base + MSDC_DAT_RDDLY1); + } + if (mmc->caps2 & MMC_CAP2_NO_SDIO) { sdr_clr_bits(host->base + SDC_CFG, SDC_CFG_SDIO); sdr_clr_bits(host->base + MSDC_INTEN, MSDC_INTEN_SDIOIRQ); From patchwork Thu Jun 19 05:35:11 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shiji Yang X-Patchwork-Id: 898646 Received: from TY3P286CU002.outbound.protection.outlook.com (mail-japaneastazolkn19010000.outbound.protection.outlook.com [52.103.43.0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDD292441B8; Thu, 19 Jun 2025 05:36:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.103.43.0 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750311374; cv=fail; b=O6H2sGrOA22jlMMO0yE4QBjc0gvoCqhXgSUJLQsXvYGiOS8s6VCPmqNa2W5fPC51mZEZJVBtNSy8GJBYVrb1HHHndk2F5vpYAVl5OaGJh+iI+MERVVRQ+vhV0mTPKmD/parv/0l7bEHsWP0g7+p3878vBtwrne7VecLTZ1LrnGk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750311374; c=relaxed/simple; bh=2JQ4lREyrfUxt3qHkZ7EYw8kXclWDY+L8Zv6tQCwi8M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=DCyHFkzsSNvAfOtW3/55CThipMvNqPE2rUcU9WxlD6ifxPnM9AUv638akV4jOZKNvXGLQuzpxHH3F2C6aZGLnu1G+fEMzTeF0Z2KSdkfe83C8foqQD6b8YmZjYyL+/TgJbjeMDO3V91KUpbWyZeJupidoo06MWoJlqfCQVidfVQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=outlook.com; spf=pass smtp.mailfrom=outlook.com; dkim=pass (2048-bit key) header.d=outlook.com header.i=@outlook.com header.b=b7l0SkCW; arc=fail smtp.client-ip=52.103.43.0 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=outlook.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=outlook.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=outlook.com header.i=@outlook.com header.b="b7l0SkCW" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Z+tNn8/3ZmIjymtjliC6BJ+V2Cw+L4Dtag0CqsKiiYu413nFOjt//G5cq0EUGwQLO7P+vxOFub1SQ5SIn3igEnxV6HKjjb9K/IpHAKuPXzIM5nL2qCJoMnysAVV/mwiYLuWAkQHGfVOrguVhwK++G6NSfzHDDOslSFABMroYMLh2PBH8iisCV/usnN3wkleNfCpsGAcPyidfAWLvinSZUluyK3Ot8dLWk+pbKsrye6kHVDXf8PHj3jdvPsMZ1+MawGX81fAbh338mwR3I56nIwrgnNwgfVGhvQILDQ+WssozmEs4T838ntSFSDHfIr3rjmscpRPdAhzDapTLOSUoiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ekr3/OWtsY9qMAAwR3IBBg5HTEEos/SJMBdxtyJ+oi4=; b=mmq7nkMf1teYQ76bwVu7l2w0OTumd5WnQsZ9tXeOTtBJ+C5pLIdx9iZWgfcTO4WHjxsZplhNeOoL2EaERldPKRT8ZfsBfcc26CwfGMjZ6DOjwyV+W1yWL7wSo4xJH6HsEzitNGxVnE71T2xJts4S+2Tp00RQVRFhTNWQmy0J36ePynmBVxHxIMKLXgm5jxH8HwcnKDdYlgDEcFBmr2p3qw3ZyMTA2GyKIQI7t8ooLWFBfsh6xXqN7coNarHdC/ruh240psLzCIee6RXib1ykJRf7JDnuJokKZO/m/zJf7aIEAcwuypUmVWVdO345GQjI8LMJYvQDQztFcTTtyo60eA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ekr3/OWtsY9qMAAwR3IBBg5HTEEos/SJMBdxtyJ+oi4=; b=b7l0SkCWcQz426HNtccQx6e+0BGDYvsLTlv4UWYlEZVAEkHhvOFwt/IsU4dhJxSWGCGuyYBxSWkGcYrTfmFDsICeXSuvKcFFeqY5kYGNM8YzAKYSfqHymDa08WI9KKQnU3I06OWJ9Wf9eKKM5kVFCjG9ugFm1n8gO390SxCtfflZrn6eDd2E38pmMq8CZoLnKnP25Cw64F/DLv7yK1nNkaqpkE0w0jXtDxj2+QnxoFl2raQqqahwpXIgi3pJBLus4pu0ksLslR+bYLT0kazY4sYFxch8am4AkCiM63eThGJbotBDYHwM9IWKOeTnyibUH6nD7cVo8KNVb4Y5kZ0YNw== Received: from OSBPR01MB1670.jpnprd01.prod.outlook.com (2603:1096:603:2::18) by OS9PR01MB16295.jpnprd01.prod.outlook.com (2603:1096:604:3f3::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.20; Thu, 19 Jun 2025 05:36:10 +0000 Received: from OSBPR01MB1670.jpnprd01.prod.outlook.com ([fe80::c00:ec4e:ee7e:9b7f]) by OSBPR01MB1670.jpnprd01.prod.outlook.com ([fe80::c00:ec4e:ee7e:9b7f%7]) with mapi id 15.20.8857.016; Thu, 19 Jun 2025 05:36:09 +0000 From: Shiji Yang To: linux-mmc@vger.kernel.org Cc: Chaotian Jing , Ulf Hansson , Matthias Brugger , AngeloGioacchino Del Regno , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Shiji Yang Subject: [PATCH 3/4] mmc: mtk-sd: add default PAD control for mt7620 Date: Thu, 19 Jun 2025 13:35:11 +0800 Message-ID: X-Mailer: git-send-email 2.50.0 In-Reply-To: References: X-ClientProxiedBy: SI2PR01CA0032.apcprd01.prod.exchangelabs.com (2603:1096:4:192::18) To OSBPR01MB1670.jpnprd01.prod.outlook.com (2603:1096:603:2::18) X-Microsoft-Original-Message-ID: <20250619053512.14507-4-yangshiji66@outlook.com> Precedence: bulk X-Mailing-List: linux-mmc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OSBPR01MB1670:EE_|OS9PR01MB16295:EE_ X-MS-Office365-Filtering-Correlation-Id: a78b3da2-cbd5-4ff3-964b-08ddaef331eb X-Microsoft-Antispam: BCL:0; ARA:14566002|461199028|19110799006|7092599006|15080799009|8060799009|5072599009|40105399003|51005399003|3412199025|440099028|1710799026; X-Microsoft-Antispam-Message-Info: 6/SbD7DpHRd/MI6XHkvfwoQv57Q6qBLXAY/z1tONWwJRnHy3/B55ER1PH9Nwrw+IMz2cGOFLMVk4b9+KnOG+Pu9/HpUNX+ekKcX+BnsjTgAeuaHcIWrdA9meLF1XXfs39nUxgffKfcALnOngqIGWfhvKdud9TurxvJ55+obDJnPsewF98IKjB/fjMsfwnzgj9YNVDAA2Z7SRYwloss9vAw6MVuwA8t2+Ey4dBUA9v7xPmXNOSHcRAytxogoc6ImaMq6hpeedO9uBPLr6nZEQjYIkMm7/+P0mZUCQYvWQjFLdWKuVyDkhv4sVnXtsyyMyqyPI0bMaosN4VJy8mzkqLBEMQRzc4aXpxjOWF/znZExtSR6VnS3S2qqY5VCdB05f/Bro1uLP3sOmi4YFI2lze0fTAt/j92gCSIi5Qj2eBdxIaUwVtjauU/6hcTNOMj73ZDSeM4CaFCFZ9WzSHiOtvjxxJpXIgX2/6tnshGH4HaSA4xgnWFCYXebDN66hENWgnsDevtFX9Vnc139JnUADFUgkYDvb+im+7pHh7MyDZj/rTbl2AlsQumIeo5At14Rr7a/40QSAV9Nl0nroyPF3duLU8n6LQVw6xNr8QfrNnDt08HcK0cQLleCcXPRCDlCGKTY1QygEyyWvJ6xtn6qQc8uaBeQ7y11Fp0gVTTQhFwZ/F+IhecH73P4X7Ac/Q4k+S65VdIx6ILIkHj5x7pILxHKWGW9/nsz3MTk/YQm7DlS+SGcgQPVKKwihyLxsbMPVkbMNvtee1XpHC/gqgU3aqJh0y/JDVlnJlcEVphUuzgTfD0CJEFuwHi3Yx4Pmr8iAjyPl9AhKPlBefi+zharm2eXWb3zIXOWIpFgLAMdUgCJbIDrtRFhSxwo+1yY85tmI3qxklBRNJAZyfdMlvoLQtyEHJqnVIMUYe1BIe3AI+bl/VJgnGdGDEdUttUU4Z5qCRO/V0+YQ0TvksTvBjP2EGmwPYugs47Bvz43bdy5bI7mbrINCh9EIh4Fi3iJXUfjtkJeQNYTLvZgsrl+hvCq0XxBQ8OjQ9q9BsTEIhid7n/kMDC4vib9APzMC2yFTHAflAdP7GXbm64xmVp6u0vci4LMwDtX+Xn29h6/9ZARwNKH+etLFhlEDgTzKM8lCGpMlQU4oo12gO/aMJ3df/lAzY0sb82M8AMIDWFiGcwf1tzgaiwI5q2KOOKWoz/MKLGkwBUMoAbHJO383zg4lkhHH3Q== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: blt9a5HppWENvsKYyYfcxBmHIsVYb3SrbvMG7rwCrHgZb2biYEYFGSojuudmMNS1eJfhlFksyQ9XxzWktCt67YeiEhnOamcyo77Gig4wTlpqPAX1ZudP+PZGt2tNzvQiqOLCaPaZlnw3aFM4v4Yrv3gn3mNGqFHna0oBCWxIe/+/4OA65svSazhhaDa/mXWb7EHFcVZ60+TGFQXw+STMwG/rsda/6zHWa4yYceDv7YzJVX6ksdE6ePIxGTfncQ4G889BAUzaLuR/t1aw1l6cbun+BMQoFiBOGZSMfoyb/kDzc+8mHYhuZRWtIjuz0Jwtl//Yj8JJBrIXb8gc3Xy4T1qKJnv9S0J27UMHIbQFF2Mqk6y+ICI3qvLlIk/352DhIsAR9k1Zzy5wrsOKF/KR86F2kLxlAaKUWtCsx7fLDOVCb28IOW3QfmKSN59me4McOHyjFsd0yFEkYNgqhH/ttr3zLA8h+WEtlKyU8ashjD/zrOSv2AM/Q80UoMmneEb1qmeq25nPOPtjGVY7NH+Iui20oW/hOX6osbbt5yOhnA5KrtygvNbmZN1KE+1vnFVBevYtQgJT9rHPw1meKyhTLBe3D5tazPguIJK2SMdbsriKKkXgtqt9v6CLCL3j+rrTnQa5jmLaS+oPQY8JtsmFch8YmSIp11AQ4aUsxkWSwCz1Cv6AsVne66PCOMcAp9Tlse9uaEoKPj/ChXyKT5B9YoEMxOC9A8yvVOxZn4yWWqJ7DyIJD5e4ka7RF50yd2aeYKS0vzm2PwONW/nXQ5LEi8mQpdvFZr2lhfbGtccYmRy1pGMfELXmNa+m6PzuHmJTBCs0J8Ur1prUqTHlgmHIl5si/cA7ZdcqVU7OXrYRZj9kFhVvIVBvSSwcuceulvQnENkiXsjTBNEhBg3A/exkXViqdqNDkUVpGPSZtYMJlBxWyMcpg/JMMHGPf6Bczv+zbUEiZbunykmObl4psDypjiJsaBqGNKL6LpFOLuS8Uwmavdhh0aGWwkXBT6UxPgwxJ6J/aD9RAXrUREyaA1kamPhZGqhSgAEh67p0fbLC9BBtWKPtanypjhqUn2AC2u33DovrgUmmc2ZGNI1ynaVcAZecuOg/JWdn5iq3ZbfQy5k9+4HVdR2iatFlHJ8BWcXYbxAyAH+2gyJAKVTlcOorBZHFe3PQiom44t2Kg26spKrcZNU2pTApdXOz6Mejj+Okfv80yKQ3VpmS8/ylM6ViRcA6zzPdNpZeuxTyuqXwkF2SbPJQE3qk/FO4PGyjKReo X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a78b3da2-cbd5-4ff3-964b-08ddaef331eb X-MS-Exchange-CrossTenant-AuthSource: OSBPR01MB1670.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2025 05:36:09.9335 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS9PR01MB16295 According to the vendor SDK driver, these legacy MIPS MT762x SoCs require configuring the IO pin drive strength via the PAD control registers. This should help improve the stability of electrical signal transmission. Signed-off-by: Shiji Yang --- drivers/mmc/host/mtk-sd.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c index 52198daef..276d4e324 100644 --- a/drivers/mmc/host/mtk-sd.c +++ b/drivers/mmc/host/mtk-sd.c @@ -77,6 +77,9 @@ #define MSDC_PATCH_BIT 0xb0 #define MSDC_PATCH_BIT1 0xb4 #define MSDC_PATCH_BIT2 0xb8 +#define MSDC_PAD_CTRL0 0xe0 +#define MSDC_PAD_CTRL1 0xe4 +#define MSDC_PAD_CTRL2 0xe8 #define MSDC_PAD_TUNE 0xec #define MSDC_PAD_TUNE0 0xf0 #define MSDC_DAT_RDDLY0 0xf0 @@ -2038,6 +2041,11 @@ static void msdc_init_hw(struct msdc_host *host) } if (host->dev_comp->mips_mt762x) { + /* Set default pins drive strength */ + writel(0x000d0044, host->base + MSDC_PAD_CTRL0); + writel(0x000e0044, host->base + MSDC_PAD_CTRL1); + writel(0x000e0044, host->base + MSDC_PAD_CTRL2); + /* Set default tuning parameters */ writel(0x84101010, host->base + tune_reg); writel(0x10101010, host->base + MSDC_DAT_RDDLY0); From patchwork Thu Jun 19 05:35:12 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shiji Yang X-Patchwork-Id: 898207 Received: from OS0P286CU010.outbound.protection.outlook.com (mail-japanwestazolkn19011036.outbound.protection.outlook.com [52.103.66.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 919A8244673; Thu, 19 Jun 2025 05:36:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.103.66.36 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750311378; cv=fail; b=MFH2NOkmMyPWes1+XHhPWlgv/JKK13Vs01SmnTc/25uE4L8+Ute8Uar3IUnJVIrLbIsieVpmLbLMGG5qdp4uqyo0N9JFKntbjZt1p9XBkRno5b8RQLMGHo2/pM1j+LHEYnNjZfUtNQsq8MtH21VopzC7GITaimMAms/67y7PAws= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750311378; c=relaxed/simple; bh=JaO0c5gFDNO+JOyMUOasRlLbQbRHPbxa3ku7+ASooTk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=u50OrevoKnaYMJcyE1nnrwZSULOgcPHvrnZYGSBV7bslSSrT5RtfMkLVqj/rH0StyArcRYCdE18Vdx9nFc33C+qUe77F2Y70QpqhfOVIsX9ZhwyhSwLHxH3qFilgQ9gZeemSuow/xGjhSKQYhG6TJSOXSxu2R9nm7gqCTc6FXWg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=outlook.com; spf=pass smtp.mailfrom=outlook.com; dkim=pass (2048-bit key) header.d=outlook.com header.i=@outlook.com header.b=PGbDWEVI; arc=fail smtp.client-ip=52.103.66.36 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=outlook.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=outlook.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=outlook.com header.i=@outlook.com header.b="PGbDWEVI" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=pmoQjyIA7qPXIPgHi9xw2q5nlGuDAoOiTmLp96u9Qzn3GkXLNHeXZyItZ7Zo6BJ3OIhtqI8ypRqMV9qXpq+CHRAGUmnCZoz+8IkRkUFy3HPiiCFtw1Pf2BIQWycLRdFIU65KpRkOO28hmsOrdtSOZ/PprClHwFsEWX6c00dJTJCFdzw5rMg6XV4YADMT32u2nJ8RxOzMIaMqly5R87D2Uids6On9xORDhjYmDKQ0qhiKdt0AzbCzc+xR8OwQWtBHJZz8Us2s7vahXvFzOHnP8mGjd23MCU7FC7Mrk8SLus+MPyT066nDm6k9qp52L6hMWyB2tE3F1mG14YebnYYQjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WHHhT+ciB7YF4hAxeA1QyW37V/98objNry8u1LOuxvw=; b=Ghx6QsYZVQuY/3tX6zwDWEgA5q0fLJaOnLncgqVqvuBJS4AwrOElmmRtCYGp6flLgtIfNoFplsLlpAIAa7NpVSDU/YcsiPrAg37XFOGOl468o/wVNTv+TuJtQq9CAqyAN3q5/TGhQtOAwJl8B8FrGvnb+/08NNSwOTg5VijMuE1AjsorhZMwp2BT6Hvm4cV/YlcqcHGnvzvlJktGlbT0Ai2qNxx2xJsMBCpANBgP7jWQimZgRi8nj8eEKkgnpJqbgKKDx3GMCHSOr5Ivz+aL/XARzggMlIGUfan+bNoRj8x4tOyhsqKsLdr/yedQL5Z8y3lNyvaFDqpmZCpptQqCQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WHHhT+ciB7YF4hAxeA1QyW37V/98objNry8u1LOuxvw=; b=PGbDWEVIffmmSEWoYVAoRyk1H93NiB04RDFX6PyXVNKQlXwLDEOJToS3BpVaVPtxo2d6/6EciHZhKNw+2w9PO7L4Jlot0EtZhJVaMdAwFEcQItSpW/yvKLiAsz1+yK+qYquNjUFa2u/mEty8hWGCSfscGglbfuInD7xYY4zn7fc03nYZYE01+84ncf5XzIHCCnIwu7Tykbr8etmpoULmhSvhZBKe0ra3Xz5tIulg+PFfVjo67SGNytDlRCdC1Ki2Uf3TMpRGRW6gZrCVSmmCMuF0piThFQ4gcs4UWepr9O/99yNnteZBNgb5cHBc4efERAzBej0imSCJGNodnd9Lrw== Received: from OSBPR01MB1670.jpnprd01.prod.outlook.com (2603:1096:603:2::18) by OS9PR01MB16295.jpnprd01.prod.outlook.com (2603:1096:604:3f3::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.20; Thu, 19 Jun 2025 05:36:13 +0000 Received: from OSBPR01MB1670.jpnprd01.prod.outlook.com ([fe80::c00:ec4e:ee7e:9b7f]) by OSBPR01MB1670.jpnprd01.prod.outlook.com ([fe80::c00:ec4e:ee7e:9b7f%7]) with mapi id 15.20.8857.016; Thu, 19 Jun 2025 05:36:13 +0000 From: Shiji Yang To: linux-mmc@vger.kernel.org Cc: Chaotian Jing , Ulf Hansson , Matthias Brugger , AngeloGioacchino Del Regno , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Shiji Yang Subject: [PATCH 4/4] mmc: mtk-sd: use default PATCH_BIT register values for mt7620 Date: Thu, 19 Jun 2025 13:35:12 +0800 Message-ID: X-Mailer: git-send-email 2.50.0 In-Reply-To: References: X-ClientProxiedBy: SI2PR01CA0032.apcprd01.prod.exchangelabs.com (2603:1096:4:192::18) To OSBPR01MB1670.jpnprd01.prod.outlook.com (2603:1096:603:2::18) X-Microsoft-Original-Message-ID: <20250619053512.14507-5-yangshiji66@outlook.com> Precedence: bulk X-Mailing-List: linux-mmc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OSBPR01MB1670:EE_|OS9PR01MB16295:EE_ X-MS-Office365-Filtering-Correlation-Id: d8453e70-299e-4cfd-a8f2-08ddaef333db X-Microsoft-Antispam: BCL:0; ARA:14566002|461199028|19110799006|7092599006|15080799009|8060799009|5072599009|40105399003|51005399003|3412199025|440099028|1710799026; X-Microsoft-Antispam-Message-Info: VkzodgXEcE2f8K66yVQ/UAsstE5xaPPGmcg7NvsjzcCgASFLxTFZo2GPZVvqpjOMvigi7vlimlGoRSAngelxhs9/AodSWhEPCb8YG8SUVQGVo5HzNtOV/yFkPXV3EN2tSyAzpF6QoKTsjsf7jEKVpRpDnsMMD2tNTgtfudzzidIU4PRkadBFoHOAN6s12WcTAjZaMIi2G4ffZJKM8FXy3QQb5Py0pRnR2NE2jcETXYZ1yDRP0oMLeuAvBbz8yoWWXxsWG7XhMdsHfqEz1U3I9wMKb0uy6IXubUDNdUs89weqn7rT1OuJ4qxJqYPSmn2NNaNK21ac3qVXg+DUcqqLDGByXFgjutJEKHl3eOtnQ+MmhpCwIg3UXimZGsIau2vWlfA9qtVGb0ny0mpNpgSwsj9P+DMHqg87VssO14awkWX4KxNp9rMrJSMw0IOma3rrutFhZr5YJnr4x3qSPkUt9CtCcD9mDx/r3Fiy2xHqQKib1K+upQ7F+RK7kMUXYJHrkr5S10eRvtaJJyKK/80dWnETSAlrP7X+jZ5YuOh+O7vAFTj/OVEEv3thUHiFlKeUQ2jhSxHGV6aj59iqEYt9N+VxhWHk/FrsnbEqW5rtn9NeEvgKmKItq3Ka0vxa8VPOjeWor8yfOlZ0u69VH6mTe0aVm/TVAKRWkOtMlwHLFHqRpTzsspo3O7Ew9o6nrgeN4ZnT7wBgDwSB+v27U0+cWemechsdG+aN5/ZGX/yIKKbBWvzZhU1gzEMZOqHF/H6DoFodJGuVzj8EZzFnNfNOnZ0uD0qsJiYJw+hbqEY3nFoYhFqlhUzhw8hb22Sm+EWFYW8adm5z2HTgw2/MrELZad3ONB59fS7e4DgoqAVSL0DTmYj4DRtJGVPyWjl6pDAD5Bl35qfWUaXquVt4nTsgWIcZ6xKSC+WngzuNZQgDxF3heScXgtrn3CgY5s4hPXa0uVE/6e5fzm8ofC1dlKnkhgvyzKZ3ejDx9uhxARgjpI4vSslYcw2sM+VJP2vjnrTmFV8K302tnro31ua5yNT8AqFjyZFuXRLjjTPBV791aXM4NOjq7iKexWydva0pJwg2Q11rbYsrzB019xXA3pbOkUdAn+2egPctr+EqIUj/4OHAFHq9P3uLa4nc9/eXS2tzW2siumkajYQMOTrZFk9H499SRDxXLclq8PVdWb3cnQa3NoiKvLhK61MPABc5JO7YRWLZCtlFUIeThf1nbF20Vw== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: nfYmaOdMQPpFcZbV1PQpZvhyc407bX57XnGm6JJ/EEYqcSC5QXJWqpIUNFZLuhnIQxbN3EzSMzHeLxbf7n4/7H3+PMlFlITyu7O3l02vFIK7CP8x3aK4eRbjNhklHAy3BSgxtATizOeoRRIec3kz4Lq0XJYt42tsDJArkiikaANiwKDNQP/DiNIhwoQNo1P4bROmZauyhsnHK1kaK7G9sAjryB+NrnN/dEHSnRFBJqhF42pG9YiNq7QMXEYcJFp/XdjfHcy+3XatimV6Hr0fTLeC+MqpUEOEZ0vg41SFWpq5cqN755RHbtG3Af9xK8T21ZeqWpuNsjL+CyZZ0vgk6Nxyrr/z1+ybbhOPP8TTf5JP2SzVeOVx77ccC27yTC2nbxCHk7yJApL4foePzYLzyftEV7nUy2+EftpXaY6ebK2+GNRmTqAJO9oyXdKnlsgSEUwiwzaCj5pVWObuJy3TojRm77z2vrYRNxRZxTonW5PgGBjxZzlkDSBkLK4NGnAj8FZDe4Xt2ahbntmZviZequ0DMalHXpt6mrF2iq2YTIntjaI/rEaQVA2H5fYO4+5CiPkrwTv/MI/JuQSPOu4C2Ovp4Mg9kbgFF1NLwU6SzE0Tca+soeFufZriWPBm8BDEEbVtYiVEdEcvMo17z29ApSnVkkk9/smcq4YC4+yyx1pLqb5e9oYhn/ORpuTZ878/QKgVMABXiZU9pQXwIlEf/SaC/rUuqEAtumxmBe4BGo69lUgxgmipsPXulrhoboYNa/wyNAwM++r3sAB/OLJQnS9crCpbg6TvONi7Dscxon8jVC1B+fbkW+RjVP+KZVh8YQsZbnauXoWJloPLZymv28+UZi52BEPlAkOKms9Bh7PL98Y3hVvPYUNlmfeL2iCcOWYfCAccqet6UsNQQuEaajaGDMw0bqxqmhYVEkXuafyoR1aQFy9Ptpr5Ypc/6AWj0kEwUieO7CYVpcMooHZ/Qi24Q77htr5ofRqT0+DkPM2ZS/1VccC3cei+k9GvcEafcrm2H61qn0ruJgcuS87UHOu4rhUsHTldJeKAGlgQTP6EmpvJ9DKJZNDfcVn/muC+Hb4B7Imyu2fDU3X56bMNWGsinLvzBmhdqCEz4u9N+WwJ+wl82H3cfQP85v0RbYLN6qdBKERKc9tDblpPDn0OWuoNxoSV6J19MqQ8Wv5xHKCrSEh8VUdX+vsm7oXpktOBKLIlMTNohQ5SAYMIq0i6o5lsdoJP4J5xarCP6qhnzIlcoY0ZJlOPjC47cv0K9FEK X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d8453e70-299e-4cfd-a8f2-08ddaef333db X-MS-Exchange-CrossTenant-AuthSource: OSBPR01MB1670.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2025 05:36:13.1452 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS9PR01MB16295 The register map definitions of these PATCH_BIT registers seem to be slightly different from other variants. Use their default values to respect the vendor SDK driver behaviors. Signed-off-by: Shiji Yang --- drivers/mmc/host/mtk-sd.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c index 276d4e324..8933cd089 100644 --- a/drivers/mmc/host/mtk-sd.c +++ b/drivers/mmc/host/mtk-sd.c @@ -1939,7 +1939,8 @@ static void msdc_init_hw(struct msdc_host *host) val |= FIELD_PREP(MSDC_CKGEN_MSDC_DLY_SEL, 1); /* First MSDC_PATCH_BIT setup is done: pull the trigger! */ - writel(val, host->base + MSDC_PATCH_BIT); + if (!host->dev_comp->mips_mt762x) + writel(val, host->base + MSDC_PATCH_BIT); /* Set wr data, crc status, cmd response turnaround period for UHS104 */ pb1_val = FIELD_PREP(MSDC_PB1_WRDAT_CRC_TACNTR, 1); @@ -2002,8 +2003,10 @@ static void msdc_init_hw(struct msdc_host *host) pb2_val |= MSDC_PB2_SUPPORT_64G; /* Patch Bit 1/2 setup is done: pull the trigger! */ - writel(pb1_val, host->base + MSDC_PATCH_BIT1); - writel(pb2_val, host->base + MSDC_PATCH_BIT2); + if (!host->dev_comp->mips_mt762x) { + writel(pb1_val, host->base + MSDC_PATCH_BIT1); + writel(pb2_val, host->base + MSDC_PATCH_BIT2); + } sdr_set_bits(host->base + EMMC50_CFG0, EMMC50_CFG_CFCSTS_SEL); if (host->dev_comp->data_tune) {