From patchwork Sat Jun 21 13:19:56 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luca Weiss X-Patchwork-Id: 899097 Received: from ahti.lucaweiss.eu (ahti.lucaweiss.eu [128.199.32.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 824AA847B; Sat, 21 Jun 2025 13:21:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=128.199.32.197 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750512102; cv=none; b=tsRKIulDOPbI+C67P9FNJMKzi5KDWC5wJV9h/i9om6HwGwJVMEmC+zD6Orx9fc5lt0OyCyzmYJKZUAivKM9N/uBwKSMMy6pv9T6dP6KZnz6tBPkAkvxIb0gLX1boIApAJbiTps+Yh6s0/+Bn2ig3qLrMeHUY0UHBAM/Qwjyfbqo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750512102; c=relaxed/simple; bh=OY9fA1pP8V0UyOWOBA8+2zh3+veBzlu89j1Vg+fIh4w=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=f6nfAe9bSTQTkGdb6rabl3V5WMWkJNre2yXvpMWEa+hFKdllK2U8CITxmXb/exhb8d+5h37loDbkfFU2DJWRFLAtEcL/d/Jn+zNFSOqqglf/2g3iS0VhlEHSiMzBz6H6sr7Dzq/z9HBvluQ54KpFji+m/pYystYwI6dNzSAhH48= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=lucaweiss.eu; spf=pass smtp.mailfrom=lucaweiss.eu; dkim=pass (1024-bit key) header.d=lucaweiss.eu header.i=@lucaweiss.eu header.b=OQ6D3R78; arc=none smtp.client-ip=128.199.32.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=lucaweiss.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lucaweiss.eu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lucaweiss.eu header.i=@lucaweiss.eu header.b="OQ6D3R78" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lucaweiss.eu; s=s1; t=1750512098; bh=OY9fA1pP8V0UyOWOBA8+2zh3+veBzlu89j1Vg+fIh4w=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=OQ6D3R78qq6W11NekZID7S2uZg+/Hlz+MkSljjxUcZkW40kQ/U33YubDMn21hafdu DI0x1HMdjCEZ3Rpy/f2lEUAfG5G/ES2gYHBmXboD42cu0ZYp9wRugzspYSs7vO/jiA /4/uhNUZPykD4jbTOpgst/8v8v722Px7nMi38sdc= From: Luca Weiss Date: Sat, 21 Jun 2025 15:19:56 +0200 Subject: [PATCH 1/4] dt-bindings: remoteproc: qcom,adsp: Make msm8974 use CX as power domain Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250621-msm8974-rpmpd-switch-v1-1-0a2cb303c446@lucaweiss.eu> References: <20250621-msm8974-rpmpd-switch-v1-0-0a2cb303c446@lucaweiss.eu> In-Reply-To: <20250621-msm8974-rpmpd-switch-v1-0-0a2cb303c446@lucaweiss.eu> To: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Luca Weiss X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2041; i=luca@lucaweiss.eu; h=from:subject:message-id; bh=OY9fA1pP8V0UyOWOBA8+2zh3+veBzlu89j1Vg+fIh4w=; b=owEBbQKS/ZANAwAKAXLYQ7idTddWAcsmYgBoVrHeQf5clqB8TDJHe+W0eckb/5LyNYS2aSw7u kPt4Fpnun2JAjMEAAEKAB0WIQQ5utIvCCzakboVj/py2EO4nU3XVgUCaFax3gAKCRBy2EO4nU3X VqXiD/0ZshgT6VrrXgQ7JzCylYPcb+4jLALDmgF6rFJgQdSj3MVkkqXhh61XlNZupVFL0MxMyox 3EpLciZHsVY7b9FW7vWOshZXG7gfKs9C0Z9ZaPQph7CHRCpUnnb6M4ddNcjQ4k3vfFVhbXn4+DK XkGaEonfVgmiVY1J4jbrDKHhcmoywBeF/RjIas0E2Who4EaB27h0rAZjrym59TbrJ3MGt0/JPlu uFPdqhO+oR/jreYsGRcow9HEZ3TXMwUGuqmfC9t/XuzuAIyZbRGAVZE2MLdPGwj7iiyXhwUgN5b 639QkqyzHT0xF6VqNHID2lk4p8ZSpIOvIivA3h4xmLAeIcBpU7xHAOCqUadXVwb+M8g+IjEacNB NRB6XdODlYNt0hQAmeby4iMgMKfnW2a/X9b0NYYkC+XApFT66YWwTJaKstgwvaEJn9jLEHSl58g aIg8sO359/ynwsh2O3DRSnGvbZW9l2IJt0S6a6AIzHDP166IUiGb5JW5dnf02mvjL26XsRpmtQC 9GVByY0iY/T6X/r3SnWxM+xJXXd0i78sH0pUN/Tf9lAqPOnI8NuBHv7GDv+02RtkM8XMB3nAA5c H21ql3phApUFi6NfcJmNxLv0RnOv5cp0fWd25o1TpSDjR6GJL7qgCIQi7btBoEkwYP9WMXR19lp 9z6lb8R+M3jY1Tg== X-Developer-Key: i=luca@lucaweiss.eu; a=openpgp; fpr=BD04DA24C971B8D587B2B8D7FAF69CF6CD2D02CD Using CX as a regulator is an artifact of earlier times. Instead use CX power rail as power domain from rpmpd. Signed-off-by: Luca Weiss --- .../devicetree/bindings/remoteproc/qcom,adsp.yaml | 18 ++++-------------- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml index 661c2b425da35c3756965fd1c47a485fe15a3f83..03e28d77da50912fe0e3106aef26cb93eb2d4142 100644 --- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml +++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml @@ -31,9 +31,6 @@ properties: reg: maxItems: 1 - cx-supply: - description: Phandle to the CX regulator - px-supply: description: Phandle to the PX regulator @@ -103,16 +100,6 @@ allOf: interrupt-names: maxItems: 5 - - if: - properties: - compatible: - contains: - enum: - - qcom,msm8974-adsp-pil - then: - required: - - cx-supply - - if: properties: compatible: @@ -120,6 +107,7 @@ allOf: enum: - qcom,msm8226-adsp-pil - qcom,msm8953-adsp-pil + - qcom,msm8974-adsp-pil - qcom,msm8996-adsp-pil - qcom,msm8998-adsp-pas then: @@ -187,6 +175,7 @@ examples: #include #include #include + #include adsp { compatible = "qcom,msm8974-adsp-pil"; @@ -204,7 +193,8 @@ examples: clocks = <&rpmcc RPM_CXO_CLK>; clock-names = "xo"; - cx-supply = <&pm8841_s2>; + power-domains = <&rpmpd MSM8974_VDDCX>; + power-domain-names = "cx"; memory-region = <&adsp_region>; From patchwork Sat Jun 21 13:19:57 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luca Weiss X-Patchwork-Id: 899289 Received: from ahti.lucaweiss.eu (ahti.lucaweiss.eu [128.199.32.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A88CD19A2A3; Sat, 21 Jun 2025 13:21:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=128.199.32.197 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750512102; cv=none; b=PG0K1ZqjXBGrHt47ixt2yfaDJ2+mmKSTq/L3jAYDrofABj/io8fURHbqd591tTDguKKU2Sj3Dj3EEsfzgurEANm9YtcZ0iGmEhwTofgg3MwYjHiP4fm8ms9L4ki6S/RM5HDQLXMikYBtraLzOgsJLcg/QMRZ5cORdIRfDyvV+e4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750512102; c=relaxed/simple; bh=BvKtXkC0o8hvEM7A01nMdoB9C06iF4bN2/32ht7CRck=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Ih+iUPGiJZB+qNxRZTleCIkpJ8ISQ4lhLFK/XA2683NNXp6rmI8VNTxs4PpWsnREfJmVcNkkY3CKCg6ZWv/LKPbu4cA4doMSqDFL1ntNG2hHqtWvLDtmy1Va3yQJD4C6iUNXJNLNoGCpxUtU+/jSQWE7qBUwg/tuG4+5pUls11Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=lucaweiss.eu; spf=pass smtp.mailfrom=lucaweiss.eu; dkim=pass (1024-bit key) header.d=lucaweiss.eu header.i=@lucaweiss.eu header.b=QpcjaQfj; arc=none smtp.client-ip=128.199.32.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=lucaweiss.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lucaweiss.eu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lucaweiss.eu header.i=@lucaweiss.eu header.b="QpcjaQfj" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lucaweiss.eu; s=s1; t=1750512098; bh=BvKtXkC0o8hvEM7A01nMdoB9C06iF4bN2/32ht7CRck=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=QpcjaQfjP1X0wdt/SQsq/SN6xBKwhF8Pt9JiUTer8Rp+7HHaqwbFXsPNCsrgqzI/N qNWDIbz9YJL3Dn2lWsoh7ML1hu29Fh6QMQKBjzeu9yH4yIbxv/N5O6QMcZ5+VOvtvx S3SuMHYwPATWTAfufddv5LfqgWcWoLvtr1uKkCvk= From: Luca Weiss Date: Sat, 21 Jun 2025 15:19:57 +0200 Subject: [PATCH 2/4] remoteproc: qcom_q6v5_pas: Use resource with CX PD for MSM8974 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250621-msm8974-rpmpd-switch-v1-2-0a2cb303c446@lucaweiss.eu> References: <20250621-msm8974-rpmpd-switch-v1-0-0a2cb303c446@lucaweiss.eu> In-Reply-To: <20250621-msm8974-rpmpd-switch-v1-0-0a2cb303c446@lucaweiss.eu> To: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Luca Weiss X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1240; i=luca@lucaweiss.eu; h=from:subject:message-id; bh=BvKtXkC0o8hvEM7A01nMdoB9C06iF4bN2/32ht7CRck=; b=owEBbQKS/ZANAwAKAXLYQ7idTddWAcsmYgBoVrHfZZFQs+UHMK8vFt82n2OF0Z+S7vlMwDh3t 2iBZZfGEHqJAjMEAAEKAB0WIQQ5utIvCCzakboVj/py2EO4nU3XVgUCaFax3wAKCRBy2EO4nU3X VvjREACBtm2eo/AIOV5hk2gMca9IWyQvJ01VvbLsMZ5YQtbzFqm2g0Xp+MvPNMQq+6cCMQJmaIh oEqOgj1WWUbwBJ2iRODP3M8bohgeuC/+S/9oOmaNT80MO9Fjmic8jOYYbmTx2vhvxMS8l9XCkJA Jnu/OiDZsXnXzLv9BW44JD0aFY/suu4JO8FdMWxxPQ8DmAmXtlK+t2laWTPtRTDQiXdH1n0sDJ9 vaqfaTTEPdPHMStAg7bnlc/jLcTeFWQriyvfnbW0x9U9GY87vDU7xvzmsFSkkVL5xcaoqcj3ovR JQRENR0MqBfZ7Rx5mvWj4Oop74E7ZnuQyXnm+2wGSXMzxyHRfDnDnCE9JnOK6tLNREX5Zyx+Epn eWVPMmqBiYxOCMQnxDu8fdL6btME840UVdh53Df410K3U5g1vIDoyr8QoHBVSH5R5Oz8b03PcpM P2nKMB25OVnMB37obMSEixkZTsHQbfKveF2AW7ukGEryVk9GMYXbNIu5dl+EXPicUJeLLpM2osK StRzJU0EjiaKy9HDnjjB9p0N1hgYVo7us+w3vND8zKYe+x24nz5X7Obn6TnbhNiW8gDtSs7QgVQ t3/ux/aremz/MPUc1M04Q3j9skk8sX5iWB/knviJ1MFetG2JvKrnybRjFl6rRZtltdPFbo6iwIh CMHRp/nA+SVvarA== X-Developer-Key: i=luca@lucaweiss.eu; a=openpgp; fpr=BD04DA24C971B8D587B2B8D7FAF69CF6CD2D02CD MSM8974 requires the CX power domain, so use the msm8996_adsp_resource which has cx under proxy_pd_names and is otherwise equivalent. Signed-off-by: Luca Weiss --- drivers/remoteproc/qcom_q6v5_pas.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c index b306f223127c452f8f2d85aa0fc98db2d684feae..b1ba5a2381c396e0ee071df1426dc610affbc6a8 100644 --- a/drivers/remoteproc/qcom_q6v5_pas.c +++ b/drivers/remoteproc/qcom_q6v5_pas.c @@ -1437,7 +1437,7 @@ static const struct adsp_data sm8750_mpss_resource = { static const struct of_device_id adsp_of_match[] = { { .compatible = "qcom,msm8226-adsp-pil", .data = &msm8996_adsp_resource}, { .compatible = "qcom,msm8953-adsp-pil", .data = &msm8996_adsp_resource}, - { .compatible = "qcom,msm8974-adsp-pil", .data = &adsp_resource_init}, + { .compatible = "qcom,msm8974-adsp-pil", .data = &msm8996_adsp_resource}, { .compatible = "qcom,msm8996-adsp-pil", .data = &msm8996_adsp_resource}, { .compatible = "qcom,msm8996-slpi-pil", .data = &msm8996_slpi_resource_init}, { .compatible = "qcom,msm8998-adsp-pas", .data = &msm8996_adsp_resource}, From patchwork Sat Jun 21 13:19:58 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luca Weiss X-Patchwork-Id: 899096 Received: from ahti.lucaweiss.eu (ahti.lucaweiss.eu [128.199.32.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8880195808; Sat, 21 Jun 2025 13:21:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=128.199.32.197 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750512103; cv=none; b=Aq+uxwt2JA+2A8OadcK196YXWrsTdjAF8YuUDI124smJS2Sckxor6/RYzWZEze1PzYnM9UNY2H5dZ8kTzx25WQJ0FmzeEUKM1gVz0XBAmJCPrxyhG5y9rlfKsVd4b6LXvvz56EX/M/owOq6LyHB5nR9cZdWTl+0aKBzRLzwnFvY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750512103; c=relaxed/simple; bh=SR6I4Fqmy6vE+82N3HIvGUTmpwSh34gsiI++K5dI2Kk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CyZ/cNESEEFiZ7yYIv+VbrNJVbpsfNDfJB7Yqc3f9EyTR5Impq2/YpZPrhOiWafhC2fLwIvnEIFkJOToCnHRCHO7TJsAVlyDaldNLzReqq5bldi7DbvcghKPPkufUGulCvZR3DK4hFzGky3ftFmfqZW7y3mD34yB5Tn5klj+zoA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=lucaweiss.eu; spf=pass smtp.mailfrom=lucaweiss.eu; dkim=pass (1024-bit key) header.d=lucaweiss.eu header.i=@lucaweiss.eu header.b=Cf0bXCSI; arc=none smtp.client-ip=128.199.32.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=lucaweiss.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lucaweiss.eu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lucaweiss.eu header.i=@lucaweiss.eu header.b="Cf0bXCSI" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lucaweiss.eu; s=s1; t=1750512099; bh=SR6I4Fqmy6vE+82N3HIvGUTmpwSh34gsiI++K5dI2Kk=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=Cf0bXCSIDSaQZovAWIxHT8JUygb71qn9fFTIbE/bzZ2bmzOJF0lPcWfTp+apspTrV 84/c9gP6xklUrTZ4ag2RgLN3oy6eFRoY72wTGZZhLE9GaOzToMD7QM/a2sdUyLQc/G mvDJqCkdZ0VOWLBIAJSHRTKyXqAzmfL+xY0SHo38= From: Luca Weiss Date: Sat, 21 Jun 2025 15:19:58 +0200 Subject: [PATCH 3/4] ARM: dts: qcom: msm8974: Sort header includes alphabetically Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250621-msm8974-rpmpd-switch-v1-3-0a2cb303c446@lucaweiss.eu> References: <20250621-msm8974-rpmpd-switch-v1-0-0a2cb303c446@lucaweiss.eu> In-Reply-To: <20250621-msm8974-rpmpd-switch-v1-0-0a2cb303c446@lucaweiss.eu> To: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Luca Weiss X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1216; i=luca@lucaweiss.eu; h=from:subject:message-id; bh=SR6I4Fqmy6vE+82N3HIvGUTmpwSh34gsiI++K5dI2Kk=; b=owEBbQKS/ZANAwAKAXLYQ7idTddWAcsmYgBoVrHg072I9uYVJWbuUoP/cCWQ5jQD4JVBXnI4Y 25Ogh27hcmJAjMEAAEKAB0WIQQ5utIvCCzakboVj/py2EO4nU3XVgUCaFax4AAKCRBy2EO4nU3X VqJJEACrZ+i4LWy83lbf9nz86QdN1LgEOSZUEb8yW75L7orLdkgbnfq//p7u7GCkOK8vzDXwEeP 6jLAfcqxpHBoosvzn8auy+zAjgvYDd7z3GRaVYi8WPEvAYyZ3Ty/fE8222351H9vjesIEaf2OZz ap4u1agOLZrlpCdwHdGFsth2c7mpu3lTu7k/9IsLmvb/V0c6j4xP2MfnkrVN6NtXUeDzDFrlCCt rKGO5XYgUM9Ug9ZRXqnCUujcejAxxBdFlLrpdc7nsTcT24n7glEnSSkaeudwS8yFmAiBj6OmWnj ZITHpGdlbvjuceSKWuEB9K+d24ZjFM74RkmA/IGKb89f+xJuiI42hV4VxG/J0h/34vhJ34c7T2w vE4bkvKFwKYSskKMILSiCIEzIDCqvi4Gm1/7Ta/uHa5Nn9BqBsOF+EdCRqzEUg9ohid4RAsoh4Z EpU3KUwfjyBRzfMqAQ1c1lRRRdzWR034P0E+cVVP7kAJqKg1cwgKzlPBhgcZ4zYxDBTZgMhhCSS nwNUHV2ZxHTRoH6fIYD1umZKqN3hvT1HpK5K8O8UKOQlg8TAmz1iI7hV+ciylbuU0z44CUWxqMd mnUdRfoW2vWX1WyKq9s9zEFpZem4IqL2Bw1mgbBdJcWquqJH3vejCuJa/2Bx4XrYpPfN6mp2xCZ do9pXj+AXLKhcFw== X-Developer-Key: i=luca@lucaweiss.eu; a=openpgp; fpr=BD04DA24C971B8D587B2B8D7FAF69CF6CD2D02CD Before adding more headers in a random order, let's sort the includes once so that's done. Signed-off-by: Luca Weiss Reviewed-by: Konrad Dybcio --- arch/arm/boot/dts/qcom/qcom-msm8974.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi index 7e119370f3375573e284587d48aef6dca3ed707f..8459a840d9ffee9da2f9a4ad8fd5a1419a3eb5a7 100644 --- a/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi +++ b/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi @@ -1,14 +1,14 @@ // SPDX-License-Identifier: GPL-2.0 /dts-v1/; -#include -#include #include #include #include #include -#include #include +#include +#include +#include / { #address-cells = <1>; From patchwork Sat Jun 21 13:19:59 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luca Weiss X-Patchwork-Id: 899288 Received: from ahti.lucaweiss.eu (ahti.lucaweiss.eu [128.199.32.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 066DF1A2632; Sat, 21 Jun 2025 13:21:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=128.199.32.197 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750512103; cv=none; b=iG8JcbMFC173b36n3i/Zph9G8Kla2+pKRXL7pI9uNVnYsmeiPOG4jxmGWltijV6AHmdcjXzXbm+svm47y24PqJVLXHXyJQyGSlKrt+giS78SeqmRw9tlrooXC4TD2tD9XPL9ziDmDHgLdT/MWoL+3C3k13ni+rohl9PAYy9nLNI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750512103; c=relaxed/simple; bh=XAomN/pt1rLm4ceV0UgfZIOfuOZ8BekTg53f316yM9k=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qCN9OSL1/WdA54qggHkVg1ZBD7SUwIwanga3/XIqYSROtPfbVS1oX/CwW7xbMWycPVBEupcylZ+uCeyXZb6rh373i0VIcG1J4OvXdhz+qYJLXK/OvnluB7j8HryAaTp/Tx6DQl043OMfPKKiQKVQIC9uaidfx8pl7jPgaXBYtNQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=lucaweiss.eu; spf=pass smtp.mailfrom=lucaweiss.eu; dkim=pass (1024-bit key) header.d=lucaweiss.eu header.i=@lucaweiss.eu header.b=LaSm2yEQ; arc=none smtp.client-ip=128.199.32.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=lucaweiss.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lucaweiss.eu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lucaweiss.eu header.i=@lucaweiss.eu header.b="LaSm2yEQ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lucaweiss.eu; s=s1; t=1750512099; bh=XAomN/pt1rLm4ceV0UgfZIOfuOZ8BekTg53f316yM9k=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=LaSm2yEQKM0xVdI6PzPydeCYicBPcmIYCJnonA9qRRrthKMgKRwCC2E+icBST3Y01 Oy7YAT9k5wT92bDyNXjPvPu/vBfkJs5coFVchkWmESErbcG4ESf73ZJ8+WRUopju6t +mFLPSmcyawADX/9xE/WrbsiDvjjIor8GJucA7/E= From: Luca Weiss Date: Sat, 21 Jun 2025 15:19:59 +0200 Subject: [PATCH 4/4] ARM: dts: qcom: msm8974: Start using rpmpd for power domains Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250621-msm8974-rpmpd-switch-v1-4-0a2cb303c446@lucaweiss.eu> References: <20250621-msm8974-rpmpd-switch-v1-0-0a2cb303c446@lucaweiss.eu> In-Reply-To: <20250621-msm8974-rpmpd-switch-v1-0-0a2cb303c446@lucaweiss.eu> To: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Luca Weiss X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=13307; i=luca@lucaweiss.eu; h=from:subject:message-id; bh=XAomN/pt1rLm4ceV0UgfZIOfuOZ8BekTg53f316yM9k=; b=owEBbQKS/ZANAwAKAXLYQ7idTddWAcsmYgBoVrHhbjFCbedrNvHZkNlN9cdTJzJa1cc5udXzr 0VPIgLOj2OJAjMEAAEKAB0WIQQ5utIvCCzakboVj/py2EO4nU3XVgUCaFax4QAKCRBy2EO4nU3X VtQBD/9xcZ6c4d7EGYNzQGpa8l8EK1CSVjMxTYuFN0r1VvkapPc0z3Wpsvb1sjkk+1o+qIquWar iDA3r+4qc1Hk7rjRzEHAorPRVFYu6smpB2BN/TXrXSG95RvHoRjVqiA29FrSt2JrN+0COVJ9pW6 HCOmA2/T2O88KMy9GitlZFuvt8/lMQOBGXvLCJtBPy4CsjrVpgO3KHYCocwXf4tO81jTkAjRS0G 2E4sY9jpwFFLGwGbkiihydCmuWteqGtFkBqCQoxqvb3WZ25RG++cZzkm1B5HhIaZw9Xxvq1bslj uoOz0BTaE4FAK4eSLmgVX5dFcxI9tM7Oqbn0XiILFAoISPOM7djxqGbJ/iBe+u4+KX4YNnFJ5vS hUQPJyucPdlMT6ZTjTYGmC3s0Infiby9VdTy1p5bZNm9ILVfJsv0j4Uw5uRr0sxxdTnUlSHGldc uyesoQi2lgnKjNPxR/oB9NtJPMvOHmUbTiTixMlQ6dWa7tTJm1fajWq2g3BfVGHT0GPP2Mm+xBg BDt8JUhnfyFSHf0orJQh6PBnUsYw9nlnEnAaZAWuIANgG5Jw5I28siUQMxT7C4u3RNWrS9b273n 0fFl88PztjwV0lSGAgTx00+5B73hug3PuRjqHYAn3EBMT7AZ5EHeyqMrIlrEAy7pWlWEWNJXMMx kv0d4/+JA60d5VA== X-Developer-Key: i=luca@lucaweiss.eu; a=openpgp; fpr=BD04DA24C971B8D587B2B8D7FAF69CF6CD2D02CD Due to historical reasons all msm8974 boards have used the CX power rail as regulator instead of going through the power domain framework. Since rpmpd has gained msm8974 support quite a bit ago, let's start using it and replace all usages of pm8841_s2 (CX), pm8841_s4 (GFX) and for the boards using pma8084 pma8084_s2 (CX), pma8084_s7 (GFX). For reference, downstream is using GFX power rail as parent-supply for mmcc's OXILI_GDSC GDSC which then is used for GPU, but nothing there is modelled upstream. Signed-off-by: Luca Weiss --- .../arm/boot/dts/qcom/qcom-apq8074-dragonboard.dts | 13 ------- .../qcom/qcom-msm8974-lge-nexus5-hammerhead.dts | 12 ------ .../boot/dts/qcom/qcom-msm8974-samsung-hlte.dts | 12 ------ .../dts/qcom/qcom-msm8974-sony-xperia-rhine.dtsi | 12 ------ arch/arm/boot/dts/qcom/qcom-msm8974.dtsi | 44 ++++++++++++++++++++++ .../dts/qcom/qcom-msm8974pro-fairphone-fp2.dts | 8 ---- arch/arm/boot/dts/qcom/qcom-msm8974pro-htc-m8.dts | 11 ------ .../dts/qcom/qcom-msm8974pro-oneplus-bacon.dts | 9 ----- .../qcom/qcom-msm8974pro-samsung-klte-common.dtsi | 11 ++---- ...qcom-msm8974pro-sony-xperia-shinano-common.dtsi | 12 ------ 10 files changed, 48 insertions(+), 96 deletions(-) diff --git a/arch/arm/boot/dts/qcom/qcom-apq8074-dragonboard.dts b/arch/arm/boot/dts/qcom/qcom-apq8074-dragonboard.dts index 34b0cf35fdac8b0bc34ffd27f70f900878a15ff7..d3ae6c6a6f83e2b77849eeeb0c348a8efd9464dd 100644 --- a/arch/arm/boot/dts/qcom/qcom-apq8074-dragonboard.dts +++ b/arch/arm/boot/dts/qcom/qcom-apq8074-dragonboard.dts @@ -198,15 +198,12 @@ &pm8941_wled { }; &remoteproc_adsp { - cx-supply = <&pm8841_s2>; - firmware-name = "qcom/apq8074/adsp.mbn"; status = "okay"; }; &remoteproc_mss { - cx-supply = <&pm8841_s2>; mss-supply = <&pm8841_s3>; mx-supply = <&pm8841_s1>; pll-supply = <&pm8941_l12>; @@ -225,20 +222,10 @@ pm8841_s1: s1 { regulator-max-microvolt = <1050000>; }; - pm8841_s2: s2 { - regulator-min-microvolt = <500000>; - regulator-max-microvolt = <1050000>; - }; - pm8841_s3: s3 { regulator-min-microvolt = <500000>; regulator-max-microvolt = <1050000>; }; - - pm8841_s4: s4 { - regulator-min-microvolt = <500000>; - regulator-max-microvolt = <1050000>; - }; }; regulators-1 { diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts b/arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts index 261044fdfee866449e9d9d62cef5aea10d88e874..b60a45f5c34193daffe982ecab132315e4b12865 100644 --- a/arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts +++ b/arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts @@ -368,12 +368,10 @@ led@5 { }; &remoteproc_adsp { - cx-supply = <&pm8841_s2>; status = "okay"; }; &remoteproc_mss { - cx-supply = <&pm8841_s2>; mss-supply = <&pm8841_s3>; mx-supply = <&pm8841_s1>; pll-supply = <&pm8941_l12>; @@ -389,20 +387,10 @@ pm8841_s1: s1 { regulator-max-microvolt = <1050000>; }; - pm8841_s2: s2 { - regulator-min-microvolt = <500000>; - regulator-max-microvolt = <1050000>; - }; - pm8841_s3: s3 { regulator-min-microvolt = <1050000>; regulator-max-microvolt = <1050000>; }; - - pm8841_s4: s4 { - regulator-min-microvolt = <815000>; - regulator-max-microvolt = <900000>; - }; }; regulators-1 { diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974-samsung-hlte.dts b/arch/arm/boot/dts/qcom/qcom-msm8974-samsung-hlte.dts index 903bb4d125135771504281df50aa11c9b6576a28..214cbcbd21cd18554d83f3c8569cd788868c71b0 100644 --- a/arch/arm/boot/dts/qcom/qcom-msm8974-samsung-hlte.dts +++ b/arch/arm/boot/dts/qcom/qcom-msm8974-samsung-hlte.dts @@ -152,12 +152,10 @@ touch_ldo_pin: touchscreen-ldo-state { }; &remoteproc_adsp { - cx-supply = <&pm8841_s2>; status = "okay"; }; &remoteproc_mss { - cx-supply = <&pm8841_s2>; mss-supply = <&pm8841_s3>; mx-supply = <&pm8841_s1>; pll-supply = <&pm8941_l12>; @@ -173,20 +171,10 @@ pm8841_s1: s1 { regulator-max-microvolt = <1050000>; }; - pm8841_s2: s2 { - regulator-min-microvolt = <500000>; - regulator-max-microvolt = <1050000>; - }; - pm8841_s3: s3 { regulator-min-microvolt = <1050000>; regulator-max-microvolt = <1050000>; }; - - pm8841_s4: s4 { - regulator-min-microvolt = <815000>; - regulator-max-microvolt = <900000>; - }; }; regulators-1 { diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974-sony-xperia-rhine.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8974-sony-xperia-rhine.dtsi index d34659ebac22e65a511994ef201fe04f12089781..02a64cea280875a91db8ee70b6b8de683327de50 100644 --- a/arch/arm/boot/dts/qcom/qcom-msm8974-sony-xperia-rhine.dtsi +++ b/arch/arm/boot/dts/qcom/qcom-msm8974-sony-xperia-rhine.dtsi @@ -216,12 +216,10 @@ &pm8941_wled { }; &remoteproc_adsp { - cx-supply = <&pm8841_s2>; status = "okay"; }; &remoteproc_mss { - cx-supply = <&pm8841_s2>; mss-supply = <&pm8841_s3>; mx-supply = <&pm8841_s1>; pll-supply = <&pm8941_l12>; @@ -237,20 +235,10 @@ pm8841_s1: s1 { regulator-max-microvolt = <1050000>; }; - pm8841_s2: s2 { - regulator-min-microvolt = <500000>; - regulator-max-microvolt = <1050000>; - }; - pm8841_s3: s3 { regulator-min-microvolt = <500000>; regulator-max-microvolt = <1050000>; }; - - pm8841_s4: s4 { - regulator-min-microvolt = <500000>; - regulator-max-microvolt = <1050000>; - }; }; regulators-1 { diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi index 8459a840d9ffee9da2f9a4ad8fd5a1419a3eb5a7..2a82ddce94a28eb1b50fdaffd5ba5de86e165156 100644 --- a/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi +++ b/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi @@ -8,6 +8,7 @@ #include #include #include +#include #include / { @@ -146,6 +147,40 @@ rpmcc: clock-controller { clocks = <&xo_board>; clock-names = "xo"; }; + + rpmpd: power-controller { + compatible = "qcom,msm8974-rpmpd"; + #power-domain-cells = <1>; + operating-points-v2 = <&rpmpd_opp_table>; + + rpmpd_opp_table: opp-table { + compatible = "operating-points-v2"; + + rpmpd_opp_ret: opp1 { + opp-level = <1>; + }; + + rpmpd_opp_svs_krait: opp2 { + opp-level = <2>; + }; + + rpmpd_opp_svs_soc: opp3 { + opp-level = <3>; + }; + + rpmpd_opp_nom: opp4 { + opp-level = <4>; + }; + + rpmpd_opp_turbo: opp5 { + opp-level = <5>; + }; + + rpmpd_opp_super_turbo: opp6 { + opp-level = <6>; + }; + }; + }; }; }; }; @@ -743,6 +778,9 @@ pronto: remoteproc@fb204000 { <&wcnss_smp2p_in 3 IRQ_TYPE_EDGE_RISING>; interrupt-names = "wdog", "fatal", "ready", "handover", "stop-ack"; + power-domains = <&rpmpd MSM8974_VDDCX>; + power-domain-names = "cx"; + qcom,smem-states = <&wcnss_smp2p_out 0>; qcom,smem-state-names = "stop"; @@ -1545,6 +1583,9 @@ remoteproc_mss: remoteproc@fc880000 { resets = <&gcc GCC_MSS_RESTART>; reset-names = "mss_restart"; + power-domains = <&rpmpd MSM8974_VDDCX>; + power-domain-names = "cx"; + qcom,halt-regs = <&tcsr_mutex 0x1180 0x1200 0x1280>; qcom,smem-states = <&modem_smp2p_out 0>; @@ -2208,6 +2249,9 @@ remoteproc_adsp: remoteproc@fe200000 { clocks = <&xo_board>; clock-names = "xo"; + power-domains = <&rpmpd MSM8974_VDDCX>; + power-domain-names = "cx"; + memory-region = <&adsp_region>; qcom,smem-states = <&adsp_smp2p_out 0>; diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974pro-fairphone-fp2.dts b/arch/arm/boot/dts/qcom/qcom-msm8974pro-fairphone-fp2.dts index fe227fd3f908e219e20bffe3561390ca6568468e..a081aeadd1d4d9539d38588811be8ac5ba0b79a4 100644 --- a/arch/arm/boot/dts/qcom/qcom-msm8974pro-fairphone-fp2.dts +++ b/arch/arm/boot/dts/qcom/qcom-msm8974pro-fairphone-fp2.dts @@ -156,7 +156,6 @@ &pronto { status = "okay"; vddmx-supply = <&pm8841_s1>; - vddcx-supply = <&pm8841_s2>; vddpx-supply = <&pm8941_s3>; pinctrl-names = "default"; @@ -181,12 +180,10 @@ wcnss { &remoteproc_adsp { status = "okay"; - cx-supply = <&pm8841_s2>; }; &remoteproc_mss { status = "okay"; - cx-supply = <&pm8841_s2>; mss-supply = <&pm8841_s3>; mx-supply = <&pm8841_s1>; pll-supply = <&pm8941_l12>; @@ -201,11 +198,6 @@ pm8841_s1: s1 { regulator-max-microvolt = <1050000>; }; - pm8841_s2: s2 { - regulator-min-microvolt = <500000>; - regulator-max-microvolt = <1050000>; - }; - pm8841_s3: s3 { regulator-min-microvolt = <1050000>; regulator-max-microvolt = <1050000>; diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974pro-htc-m8.dts b/arch/arm/boot/dts/qcom/qcom-msm8974pro-htc-m8.dts index b896cc1ad6f7d4b3f8e70ad4460867b04519a6d9..402372834c53d6ef71a72156d1be7d30ff1feee5 100644 --- a/arch/arm/boot/dts/qcom/qcom-msm8974pro-htc-m8.dts +++ b/arch/arm/boot/dts/qcom/qcom-msm8974pro-htc-m8.dts @@ -70,7 +70,6 @@ &pm8941_vib { &pronto { vddmx-supply = <&pm8841_s1>; - vddcx-supply = <&pm8841_s2>; vddpx-supply = <&pm8941_s3>; pinctrl-0 = <&wcnss_pin_a>; @@ -104,20 +103,10 @@ pm8841_s1: s1 { regulator-max-microvolt = <1050000>; }; - pm8841_s2: s2 { - regulator-min-microvolt = <500000>; - regulator-max-microvolt = <1050000>; - }; - pm8841_s3: s3 { regulator-min-microvolt = <1050000>; regulator-max-microvolt = <1050000>; }; - - pm8841_s4: s4 { - regulator-min-microvolt = <815000>; - regulator-max-microvolt = <900000>; - }; }; regulators-1 { diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974pro-oneplus-bacon.dts b/arch/arm/boot/dts/qcom/qcom-msm8974pro-oneplus-bacon.dts index 4c8edadea0ac63db668dbd666fbb8d92e23232b7..090774e05451e1b5c7cd6d1049760da651cc83b4 100644 --- a/arch/arm/boot/dts/qcom/qcom-msm8974pro-oneplus-bacon.dts +++ b/arch/arm/boot/dts/qcom/qcom-msm8974pro-oneplus-bacon.dts @@ -213,7 +213,6 @@ &pm8941_vib { &pronto { vddmx-supply = <&pm8841_s1>; - vddcx-supply = <&pm8841_s2>; vddpx-supply = <&pm8941_s3>; pinctrl-names = "default"; @@ -239,8 +238,6 @@ wcnss { }; &remoteproc_adsp { - cx-supply = <&pm8841_s2>; - status = "okay"; }; @@ -253,12 +250,6 @@ pm8841_s1: s1 { regulator-max-microvolt = <1050000>; }; - pm8841_s2: s2 { - regulator-min-microvolt = <875000>; - regulator-max-microvolt = <1050000>; - regulator-always-on; - }; - pm8841_s3: s3 { regulator-min-microvolt = <1050000>; regulator-max-microvolt = <1050000>; diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte-common.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte-common.dtsi index d3959741d2ea9e2a3dace149034d42353fbe9828..56a1a25f3df38bf4a9ba5ea4ad9e8a2d1d1c0a95 100644 --- a/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte-common.dtsi +++ b/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte-common.dtsi @@ -453,12 +453,10 @@ ramoops@3e8e0000 { &remoteproc_adsp { status = "okay"; - cx-supply = <&pma8084_s2>; }; &remoteproc_mss { status = "okay"; - cx-supply = <&pma8084_s2>; mss-supply = <&pma8084_s6>; mx-supply = <&pma8084_s1>; pll-supply = <&pma8084_l12>; @@ -474,11 +472,6 @@ pma8084_s1: s1 { regulator-always-on; }; - pma8084_s2: s2 { - regulator-min-microvolt = <500000>; - regulator-max-microvolt = <1050000>; - }; - pma8084_s3: s3 { regulator-min-microvolt = <1300000>; regulator-max-microvolt = <1300000>; @@ -648,6 +641,10 @@ pma8084_l27: l27 { }; }; +&rpmpd { + compatible = "qcom,msm8974pro-pma8084-rpmpd"; +}; + &sdhc_1 { status = "okay"; diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974pro-sony-xperia-shinano-common.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8974pro-sony-xperia-shinano-common.dtsi index 6af7c71c715847f137ec2da41d70f679a8e1c04b..3d2de30b495e6e6176eb38b95ec67634fbcb29ca 100644 --- a/arch/arm/boot/dts/qcom/qcom-msm8974pro-sony-xperia-shinano-common.dtsi +++ b/arch/arm/boot/dts/qcom/qcom-msm8974pro-sony-xperia-shinano-common.dtsi @@ -207,12 +207,10 @@ &pm8941_vib { }; &remoteproc_adsp { - cx-supply = <&pm8841_s2>; status = "okay"; }; &remoteproc_mss { - cx-supply = <&pm8841_s2>; mss-supply = <&pm8841_s3>; mx-supply = <&pm8841_s1>; pll-supply = <&pm8941_l12>; @@ -228,20 +226,10 @@ pm8841_s1: s1 { regulator-max-microvolt = <1050000>; }; - pm8841_s2: s2 { - regulator-min-microvolt = <500000>; - regulator-max-microvolt = <1050000>; - }; - pm8841_s3: s3 { regulator-min-microvolt = <500000>; regulator-max-microvolt = <1050000>; }; - - pm8841_s4: s4 { - regulator-min-microvolt = <500000>; - regulator-max-microvolt = <1050000>; - }; }; regulators-1 {