From patchwork Sun Jun 22 21:03:26 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 899163 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1291B219A95; Sun, 22 Jun 2025 21:03:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750626217; cv=none; b=hR1ITaLV0jqzek5R8KnUWLSMPplm5Jbya9OihcHHgaubpcEhkgZvqJRn6dEsL9u4hPmxot2ebpUEQv4BL0I1TQxnKdZAXscSSWmqA1tmAT/PE5sS9Y99ZUpfES0XkQt2SK9U188u+fgxJT7xYgW9UmXOBvwJ3W5wYhEoG11QkoQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750626217; c=relaxed/simple; bh=/RUstGJfkJjRI+Pr6WW5egPsetwstPl+AsaLyBk7JE4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Afy70MDEWkUFEgopKvkoBSL7BP4JUXQMfEs/zhcqLK7mZ1bQFCMmO5CqV8pmDk9DfUgBqW2LNqC0omdHAgVBF2X4qEL9x2ppAPPBQyIXQmG1efTl7SAKALsM9ofk2jwNaPUayAl985f7zCDWKmH3cXibDNIuIPjQLAudF61V3eo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SutzdAv5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SutzdAv5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C050AC4CEF9; Sun, 22 Jun 2025 21:03:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750626216; bh=/RUstGJfkJjRI+Pr6WW5egPsetwstPl+AsaLyBk7JE4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SutzdAv5FmZPQLzQd5uxJiGRCyX33vYX8YZ6a9jyu9gW6/MSmjfCPZHCgt2dLLuR4 NahuqXySvzmk4Ncl4QfHBqqz0F8uCvIX2Bt9xE8KBvmuDrr0NkYfQ5NYE7GfO0oOuS dQeY40T9lZ06fq8ew4Oqsf5xagcKtI4KwVx9KftQB5YSN8dlwtKwFgX7Q1HulkF+BU qKvXBrsMa3jekBKzPi6Oh0+rrOjf3qNx9Bz8uBowfGmMl9F+Wmt1z3XK7rPRsQTFw7 NeH6JuyVBQ3o3R/YMuF7wITjp9leHWbMxAROdtmA9xlIhJNjd3JKgqOF2IV0DazRVe x1/XdEJnlr+nQ== From: SeongJae Park To: Cc: SeongJae Park , Andrew Morton , Shuah Khan , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH 2/6] selftests/damon/_damon_sysfs: set Kdamond.pid in start() Date: Sun, 22 Jun 2025 14:03:26 -0700 Message-Id: <20250622210330.40490-3-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250622210330.40490-1-sj@kernel.org> References: <20250622210330.40490-1-sj@kernel.org> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 _damon_sysfs.py is a Python module for reading and writing DAMON sysfs for testing. It is not reading resulting kdamond pids. Read and update those when starting kdamonds. Signed-off-by: SeongJae Park --- tools/testing/selftests/damon/_damon_sysfs.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/testing/selftests/damon/_damon_sysfs.py b/tools/testing/selftests/damon/_damon_sysfs.py index 5b1cb6b3ce4e..f587e117472e 100644 --- a/tools/testing/selftests/damon/_damon_sysfs.py +++ b/tools/testing/selftests/damon/_damon_sysfs.py @@ -408,6 +408,9 @@ class Kdamond: if err is not None: return err err = write_file(os.path.join(self.sysfs_dir(), 'state'), 'on') + if err is not None: + return err + self.pid, err = read_file(os.path.join(self.sysfs_dir(), 'pid')) return err def stop(self): From patchwork Sun Jun 22 21:03:28 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 899162 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E711221723; Sun, 22 Jun 2025 21:03:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750626219; cv=none; b=ixSBLv8E7NawoizeApJuQ2C6q+KvrFqEhmYeAkQ/ufx725JEOG6NmtaQvHATLSp2kFhGadSErSquCpgW+wqeY4JzHLL3T/wzAYVvt6ud5N4mbxPpto7xQwbU75mk7lTICt/cKZqOsI9/WauVBfwOYZOoRLrxPOVQX5dY7OpDupg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750626219; c=relaxed/simple; bh=miTM6A3QV73RUDWnpfCOrpusoocXXvQwskQZDbdPk1E=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=YQ4O/LxL+AJ1X8qD28SNeZDQm+OzgtwFnZZlcoeGbTmfoKBdoBkSW06qXPaawM5NG6L6oWh60V+gWbbNWdST9PlrDLgeG3Ok//ZoY99LY6G+9qqoJB1GHwu/zwDTpB2Gh5WTmJXyIZFwZjjZUfXj24M0NGFnOlNmswJkk6oZMBg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GlO6a+zB; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GlO6a+zB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED3C3C4CEED; Sun, 22 Jun 2025 21:03:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750626219; bh=miTM6A3QV73RUDWnpfCOrpusoocXXvQwskQZDbdPk1E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GlO6a+zBcL8nUOw9+1ngXmZzojMVpnSCtjCLKUMlv9sOd/QF89mW7yGkv72BMnv+g dzU9cbXzql1yjIQrCUZ6q6uVghbkAxovnoaxvSuRrMQnYF2jS5cSzbSaUM+aVCRmNZ Zl+Byvk2A5t5GijhzxawGKsQJl2uwdSz9bTDYu1Z5ze5pVEcjuqhjMcuo69Miv2cPE 80wxT1Dxmixv9WCT1Fc0RORvdhSo97itef6kvUTg6e3DEfGBT73SnCf3/3yvjbPg0j A0eg0dXK7X9XnwPncabF+mAjJ4IsShizBJG5rEl1xf4tIAx3JT6R4RAdpS8D4Y8Svk ZHdYPZQYqjvsw== From: SeongJae Park To: Cc: SeongJae Park , Andrew Morton , Shuah Khan , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH 4/6] selftests/damon/sysfs.py: test monitoring attribute parameters Date: Sun, 22 Jun 2025 14:03:28 -0700 Message-Id: <20250622210330.40490-5-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250622210330.40490-1-sj@kernel.org> References: <20250622210330.40490-1-sj@kernel.org> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Add DAMON sysfs interface functionality tests for DAMON monitoring attribute parameters, including intervals, intervals tuning goals, and min/max number of regions. Signed-off-by: SeongJae Park --- tools/testing/selftests/damon/sysfs.py | 34 ++++++++++++++++++++++++-- 1 file changed, 32 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/damon/sysfs.py b/tools/testing/selftests/damon/sysfs.py index 4ff99db0d247..a721901a880d 100755 --- a/tools/testing/selftests/damon/sysfs.py +++ b/tools/testing/selftests/damon/sysfs.py @@ -20,6 +20,11 @@ def dump_damon_status_dict(pid): except Exception as e: return None, 'json.load fail (%s)' % e +def fail(expectation, status): + print('unexpected %s' % expectation) + print(json.dumps(status, indent=4)) + exit(1) + def main(): kdamonds = _damon_sysfs.Kdamonds( [_damon_sysfs.Kdamond(contexts=[_damon_sysfs.DamonCtx()])]) @@ -34,8 +39,33 @@ def main(): exit(1) if len(status['contexts']) != 1: - print('number of contexts: %d' % len(status['contexts'])) - exit(1) + fail('number of contexts', status) + + ctx = status['contexts'][0] + attrs = ctx['attrs'] + if attrs['sample_interval'] != 5000: + fail('sample interval', status) + if attrs['aggr_interval'] != 100000: + fail('aggr interval', status) + if attrs['ops_update_interval'] != 1000000: + fail('ops updte interval', status) + + if attrs['intervals_goal'] != { + 'access_bp': 0, 'aggrs': 0, + 'min_sample_us': 0, 'max_sample_us': 0}: + fail('intervals goal') + + if attrs['min_nr_regions'] != 10: + fail('min_nr_regions') + if attrs['max_nr_regions'] != 1000: + fail('max_nr_regions') + + if ctx['adaptive_targets'] != []: + fail('adaptive_targets') + + if ctx['schemes'] != []: + fail('schemes') + kdamonds.stop() if __name__ == '__main__': From patchwork Sun Jun 22 21:03:30 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 899161 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D27AD222561; Sun, 22 Jun 2025 21:03:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750626222; cv=none; b=nJoQ84DvZ34XacrwrTpQndpcWyJa3OG0RIv7qF05wFioUvlbQL+VeIC+dmTClB+y4YP3KfWXKLx489yhQZ7I0E7Nqj9x/Us1sx3E4pcmtxrTIpOUuti5Zp/uz8dkDgO59c9J0roFGaUJxgGPfoDSZJS55iyC2c6WDzAixR2qvxg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750626222; c=relaxed/simple; bh=CR4mzDVLH9lzs9or4TF7dOJ0izoFCJ1YoukXbycwrC8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=hCgA3pMlysSNjlgwg+E4ZDHOtPV3SLpemM8laJZQ9Wn7TRq1yc7xFF/S0szCM7A1RNygd6ADNClMafth+oGozjdrjn6ArCVXP54KXH2o9oDVnNsGUvTiY2YM5rmdO3Z2/ATgsacMdD5t3LrkaszzzVf0r2tCSPWPMuO8chgJKb4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=pNud93s6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="pNud93s6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 341A5C4CEED; Sun, 22 Jun 2025 21:03:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750626222; bh=CR4mzDVLH9lzs9or4TF7dOJ0izoFCJ1YoukXbycwrC8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pNud93s6qSRE2V1pdjrSodSG5/YV8dkAhP0AXa7Ckh4nHqDDcZ8kpKYu8dUyXDCbV XGex9qXl94srCsIuUeNPqldNomDb9fjBSPmgfHaF8LZbyvrO0IhkwrNkZ6NdsNjUOL A7yz2ZGNDs4eYkhVdNe3SwIcvYsIt84eYAlj/xBLumTlQ73JIxfBpb0cmd/yT+BGuW 8T2rHrsLo7mBWF18WGDhTXyeiSQRulKOoH+WJ4t1H60eXZ9L5WpTbzVi0gx72Dcajm /buyKh9LyCnfqxvhwxrG0PU0F+BHzETLErcJaiiLOBHHbkcv+FdjRaWGvdzBLh9JH9 YJiWTmtiH8R9A== From: SeongJae Park To: Cc: SeongJae Park , Andrew Morton , Shuah Khan , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH 6/6] selftests/damon/sysfs.py: test DAMOS schemes parameters setup Date: Sun, 22 Jun 2025 14:03:30 -0700 Message-Id: <20250622210330.40490-7-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250622210330.40490-1-sj@kernel.org> References: <20250622210330.40490-1-sj@kernel.org> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Add DAMON sysfs interface functionality tests for basic DAMOS schemes parameters setup. Signed-off-by: SeongJae Park --- tools/testing/selftests/damon/sysfs.py | 46 ++++++++++++++++++++++++-- 1 file changed, 43 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/damon/sysfs.py b/tools/testing/selftests/damon/sysfs.py index 3b085268f342..e67008fd055d 100755 --- a/tools/testing/selftests/damon/sysfs.py +++ b/tools/testing/selftests/damon/sysfs.py @@ -29,7 +29,9 @@ def main(): kdamonds = _damon_sysfs.Kdamonds( [_damon_sysfs.Kdamond( contexts=[_damon_sysfs.DamonCtx( - targets=[_damon_sysfs.DamonTarget(pid=-1)])])]) + targets=[_damon_sysfs.DamonTarget(pid=-1)], + schemes=[_damon_sysfs.Damos()], + )])]) err = kdamonds.start() if err is not None: print('kdamond start failed: %s' % err) @@ -66,8 +68,46 @@ def main(): { 'pid': 0, 'nr_regions': 0, 'regions_list': []}]: fail('adaptive targets', status) - if ctx['schemes'] != []: - fail('schemes') + if len(ctx['schemes']) != 1: + fail('number of schemes', status) + + scheme = ctx['schemes'][0] + if scheme['pattern'] != { + 'min_sz_region': 0, + 'max_sz_region': 2**64 - 1, + 'min_nr_accesses': 0, + 'max_nr_accesses': 2**32 - 1, + 'min_age_region': 0, + 'max_age_region': 2**32 - 1, + }: + fail('damos pattern', status) + if scheme['action'] != 9: # stat + fail('damos action', status) + if scheme['apply_interval_us'] != 0: + fail('damos apply interval', status) + if scheme['target_nid'] != -1: + fail('damos target nid', status) + + if scheme['quota'] != { + 'reset_interval': 0, + 'ms': 0, + 'sz': 0, + 'goals': [], + 'esz': 0, + 'weight_sz': 0, + 'weight_nr_accesses': 0, + 'weight_age': 0, + }: + fail('damos quota', status) + + if scheme['wmarks'] != { + 'metric': 0, + 'interval': 0, + 'high': 0, + 'mid': 0, + 'low': 0, + }: + fail('damos wmarks', status) kdamonds.stop()