From patchwork Tue Jun 24 14:32:18 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 899602 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6A92291894 for ; Tue, 24 Jun 2025 14:32:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750775552; cv=none; b=CGX/1KLeM/kuSOg+HYusOG/0Qzaot631EN7BvCgYXCuxSJNVZFRbrxYLlUN5Sn32rFY8Hox1IoSo1S/UYqaCioe5XH6WyE7yJa/jlSPObkoVcXeS2JY3aDX4jl5gCMTGuSHavsvbspkVbaiEtlju0QUIWD2iT+/4iPngCrKBUzE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750775552; c=relaxed/simple; bh=ETdCBVd9dlKlAmlrVMybF4vKOHUekbdvIvNdfOPZpVI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JqJbWkxHsxe8GTGIF8FyzNbRK4Oa8a6YuDdSL2PCE5OzfMNQW0Kv15mg7ybekMzgTX8jVppFCGmMEzZ2qIWZK4qNPQWJU3gJbBpY2/4Iuox06nX6FnCvzBAvDsUFMSGzac2U9nfzfhwuHXUaHOPrUcX3TmqXO0Ejq1f6pW4QXu0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=LMMPD4nf; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="LMMPD4nf" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-453608ed113so48017815e9.0 for ; Tue, 24 Jun 2025 07:32:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750775549; x=1751380349; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=lFxv+CSVT1JduUoBwXVfn9STkVHcaXwFmqXMPaWFmWg=; b=LMMPD4nfWmfdt3oxavht3kP9icuM4VZ/jIaW4KZA6XWc1bvgtK1b2P07rsc+zoF7ld pwc3Mph3yYPdAEVlzDzaWA6U+Jre07n2zfPdLlPrav9nJQwSd/VvCpzGwo7dnjAlK5VZ QdUHO5lZdnEi6gU6evxcrZET7MEpwCjE05BHwCOrObyf7wp8Fmdy/F1fKFUVyQa1TIt0 H8vp756+bFX5/fkLz7RsR7YTBBgtxHMDBwDjLnq083xyukgD0GUE6ob2ntRCrgWJZHS/ bTMaKmbF5IuOuaty+HzI155cUX6KP4iJXuyuYk/JhAC9xb2janfZv18LKuC8HiHrKExj Ts4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750775549; x=1751380349; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lFxv+CSVT1JduUoBwXVfn9STkVHcaXwFmqXMPaWFmWg=; b=IZs2vVPW4H9l7A8y8xK1uHqGg4sxhtvdNODLm8IMLcFwUDkSkiJwAzLhuxwBx8LlzH dN4bKaDzSc50qONnrQV95NMbMQSumH/2snj3JgBW71y8LOPTD+2QDAahYVA9g+k//IHf RpOuH5vtQGK90iNjzH0tzRYE53zg/FPTwQ5nsYwDGj7IKW40SM7yE9ABJJe3Rz5YrIfj Y6D4DwPKpblhe+GFvNL1vMmwz1SQ4kG1L4kVd/wIJi4txhWKXMklsLBF8O/psnqWNEdZ +kZHQd+rd/xa1pNb71ljnJCpcyB5JWA/rog9CHgFILngTQf/r8GPwi/V36qSewMVmDrW wJMQ== X-Forwarded-Encrypted: i=1; AJvYcCWh9pkzx32pGkEunt5Y7G+H4Q1ounneatToglTvvKraSoIw4tv62EmkvA3HfIb8C5x8qMpxjXgiiA==@vger.kernel.org X-Gm-Message-State: AOJu0YyiGU08Nv/FtOk4uUb/MmlKUXzO0oErNM/AOuBR92FdkaG7G8UB LLfKPuP5zLteXnqGnaSBxaECKTFAmPyTeWfloPaMRkPlJDkcxHmmUm+6FV0LwGmZ+Fkv+dqowyB DKmIpxxs= X-Gm-Gg: ASbGncsXUzKvnPIKnqVF/U1Nxbu9Kr6udmdUH/EjuOT1FOsJzCdSNIMjxpFvIpKLUo7 Mn1BJIvHjzWERAsra4dB7FBYxz0eTcQWNWudtn6QPbHOe6TrauvCb2uai0OFFk97uSfeaXnXeKU dgHt41sZ8Q9OGTbgAlb/8Mij+aJqGlpgE9FsCfT3p9Gdy83rnZrGbOZZQI0qAWiYgLdAeOq1s8L FiwJx60cbxqdP1/Zm+JVFKEebSc3g+bFPN2BNQZ2O5olPws7+v84wHnyzELnOp9c2rDDgnfZQjH 6CAZMoelE2g0RtfZSpmwZEZgyo/h0U2vB2lC1OoFHq/1IkDtCve8BA74 X-Google-Smtp-Source: AGHT+IHD4d2ak9CVpp5Gb3Vl//bTvUG78qxypokPSA3JfLjuNCjdx/+p/2yyT5p37+Ky+IXsejzn0Q== X-Received: by 2002:a05:600c:3489:b0:453:b44:eb69 with SMTP id 5b1f17b1804b1-4537dfbbd31mr26524705e9.13.1750775548638; Tue, 24 Jun 2025 07:32:28 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:34d2:109c:3293:19e9]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4535ead2a84sm178512935e9.32.2025.06.24.07.32.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Jun 2025 07:32:28 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 24 Jun 2025 16:32:18 +0200 Subject: [PATCH 1/5] pwrseq: thead-gpu: add missing header Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250624-pwrseq-match-defines-v1-1-a59d90a951f1@linaro.org> References: <20250624-pwrseq-match-defines-v1-0-a59d90a951f1@linaro.org> In-Reply-To: <20250624-pwrseq-match-defines-v1-0-a59d90a951f1@linaro.org> To: Drew Fustini , Guo Ren , Fu Wei , Bartosz Golaszewski , Ulf Hansson , Michal Wilczynski Cc: linux-riscv@lists.infradead.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1282; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=kuQ4uO8LOxmEAAqs0l/C6pNUD/i2/y1K+eYCkH9r2oE=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoWrb5hTVaHLse7YY4Z8fJIQZKJ3AQgAUmHNQv0 VwZwM91+1SJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaFq2+QAKCRARpy6gFHHX cujsEADPF8KCWrxiSt3p+cb4oVKfu3+XmlPa8P9/B3GoYcQRJeLWaTiMykmZYCWqLqquF996s5Z wmdFKfXPHda6dYr0UrL6AjoMDT3E2vi7vhx8XCENm0S3SU2IPnmUC6ZoSrRxq4j+pVYbchBLpi6 usUAgi/RwAJ+oG36mYWYewQdGX7+2dpMjje5y1awCGwzcscsyg6IxSJDp0puslMfIYTfsh/cfRA fBJIzMW/dlVZW0QZVjXoZHWG6dlQbkAmUEiVURqPeKnia6SAvivPg8D+vyYv4etq5Clv18wCJRI lonF0OYTo0XxK3SAtUTgyuyYbiZr2uUAJDyOvzVgTjaJ+kbz2q7s+ykgusXxpBrhfsx0hxTOsh+ Gznzh9pKDozRA9R8QOBdLmHbzqoVvWojoURYiul1T/q/06+CbC7rXfj8z6rH8kaRSBzPE37AIf6 V8CKI/Uqz0B7JZCC1rtmFnWW7fFIkZGLD5DPG+rxIJ7y9IZnAtj3sk1vCRM1rHgnX4+1KajRx0H OXe6HlBsNJCmMzP446DYdvuj+DWhCghrCxIRQLl2EQm5vjiYzGhM27jt2ofnYPFw2G+hob+VbSa LmG1m17inHqLh1uVc/ypB5241VTSoK05UHHf8YR9GurlLl5qGyloHhTHqZdiO9zDc/llKFs77po z9GnVX4voR6m3Jw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski When using kcalloc(), kfree() etc., we need to include linux/slab.h. While on some architectures it may work fine because the header is pulled in implicitly, on others it triggers the following errors: drivers/power/sequencing/pwrseq-thead-gpu.c: In function ‘pwrseq_thead_gpu_match’: drivers/power/sequencing/pwrseq-thead-gpu.c:147:21: error: implicit declaration of function ‘kcalloc’ [-Wimplicit-function-declaration] 147 | ctx->clks = kcalloc(ctx->num_clks, sizeof(*ctx->clks), GFP_KERNEL); Fixes: d4c2d9b5b7ce ("power: sequencing: Add T-HEAD TH1520 GPU power sequencer driver") Signed-off-by: Bartosz Golaszewski --- drivers/power/sequencing/pwrseq-thead-gpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/power/sequencing/pwrseq-thead-gpu.c b/drivers/power/sequencing/pwrseq-thead-gpu.c index 3dd27c32020a6d3b551eeaff2859456fed679814..855c6cc4f3b5bd1aa6e93305af0417d5791b092d 100644 --- a/drivers/power/sequencing/pwrseq-thead-gpu.c +++ b/drivers/power/sequencing/pwrseq-thead-gpu.c @@ -21,6 +21,7 @@ #include #include #include +#include #include From patchwork Tue Jun 24 14:32:20 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 899601 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53C672D4B67 for ; Tue, 24 Jun 2025 14:32:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750775555; cv=none; b=ePf7ZV/tx/uwUTcxufE2opapRudyJBils2c7SVsqyqxr18cKd55/t5RzE0fUyW3Bt/oDgoKBXB4TVUAXeNnpZlEDCSph1B2PQOmmuiyWE0TvMMY4e8EzoovfgI88Cdb091Ja2xKd3ZNlZgGkybKGn7jMxDEsegW+u+2NAxlab2Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750775555; c=relaxed/simple; bh=tcNUMicj3q2TZD7z9sDFdteTWDh+GHAvsTNL8/OskaM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=XIJNmXyiE+9Bjc1/uCiE7UMZEKGncCyR+QF6tD07w0719OwcinJX88pzSFQ4O3FCDeJgUj3RNkT4aXfMRvigLYlxTn7FzrQx2BqQ4yQpvnhVMUtVFYA9PWBNtkBV8JsV1cmQr5rOChxUgGYuBSAnZuEwzDyOa+n5pA4ZVX1Z+Vc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=TETDxPIL; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="TETDxPIL" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-453398e90e9so37287985e9.1 for ; Tue, 24 Jun 2025 07:32:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750775551; x=1751380351; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Uw4x1TQGrA/MBrQhecsgMke6peLxrAZP3r5KIxkbAtg=; b=TETDxPILO55Ud+j3nze9oeolKb6BqHKX6phmmNUG7U+lq6UFdqPhhRjsy/SJv0HTI/ SpVIJ5oIVWSCSSwhMDjtQGGekrRJAEw51PyVu2JFjrgYNbnKOpCqlD3oX2QQDuI3Mtfx PIs4qzhBQXH+fBVBMgvbk149rlVz5LDYKEB/n0PIzFkA+O1E0Udy195M2ShyFwLKbrRG DEwqPkRVHIjb9sEcF0me9IZpyTGRV/Fb9MeTER0V6APYOELWmxu4lRzqGX8iwaJCddwR +kdDiSy+HBixZ+18KJzCc4nU0w9xTwH+kolAH/cxXbdHlM4icORE6aPCDnn5kjH/7e4W ruHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750775551; x=1751380351; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Uw4x1TQGrA/MBrQhecsgMke6peLxrAZP3r5KIxkbAtg=; b=AkOBlLSCa0ACidINT9V2wMCtDNKDH0XcUhop1JUnk4fonQmpdIjkHubVyPhi/MUIR4 0DdmcQsNKiNykdDjkxgcuGOAHYCOzuNyVr2SPPzWUdRiXLVxe9a+M3ivdARCs67DJ/BK ZQ/mZvbCxwayhtpajerOBCS2ZgdNhgTze20aELy/hnueh1UJKuk4FE/4wJM7SqzLbZkk h14pyVQsRxbpfuui40sCFgfqNFHPUIYWuB/dxs1ziHHyrOcPzap2d/Ehcngku8/chM6g rEzSHepsyviiMiUkaqA8xgtzhndwOt2vP7i51bOP+lDZhXZwa5XYtw5IA5hs7/7UpjQj Vt1g== X-Forwarded-Encrypted: i=1; AJvYcCWVLeNQKmNwe2s8w8dXLRp9Q3b7J5dmOZMVUyw793g14o58MRHb2IwE8Ku8beBiffdY0VjuT/kR2w==@vger.kernel.org X-Gm-Message-State: AOJu0YwFy1+zLIz6djzJwk2StBfeXUu9NP/ekMPSQbM4prbe3zg2GB+D Mbfx+RcOI6OxbJzgb+g8CtzpVTQChKpfu2TYkftS2PJrYJTlnHLWQXHGmsMVVDxs/sCsByVEMnU HPjNNzVU= X-Gm-Gg: ASbGncuXX97yCSPfhcYfZDlS8weB4pezSmwMGPNwfZSfX43uVLC6IKd8yBgpcFxOH7T BhPNFTMP4JDMRuP3CREpo/ulmQnKDZBETSn9lS76lLBV4RM7sC49R9ODS07UiQCuPUFAXSfvILp RSvsslEik03yiZIc08TFN3kaiZLPRc+HYN0go5wahSSdHNU2zIWpI/LtPEx24+bj6kZihNWhXWQ EoUstJX60I4rJgl7iTHuZTt+sFb0X8Av8dfaKc4X5RpR1p1sESrXSZTEDZ+kXLpPuPMZqG8hp3H uQ9dG97GEo6QbHqGsB4Zv22Fwip5tx9j6ZxVxS183iWMmP8xW335aAgMzxS/Le0yjRc= X-Google-Smtp-Source: AGHT+IGnv9OAm6kU3yC9OQdJrsGHg+VSoZWXLELg2p5G3m4MaLGEgPnmo4tXgJNKP087uSEZKo6VwQ== X-Received: by 2002:a05:600c:1f0e:b0:43d:563:6fef with SMTP id 5b1f17b1804b1-453659ec182mr147580495e9.21.1750775550906; Tue, 24 Jun 2025 07:32:30 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:34d2:109c:3293:19e9]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4535ead2a84sm178512935e9.32.2025.06.24.07.32.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Jun 2025 07:32:30 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 24 Jun 2025 16:32:20 +0200 Subject: [PATCH 3/5] pwrseq: add defines for return values of the match() callback Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250624-pwrseq-match-defines-v1-3-a59d90a951f1@linaro.org> References: <20250624-pwrseq-match-defines-v1-0-a59d90a951f1@linaro.org> In-Reply-To: <20250624-pwrseq-match-defines-v1-0-a59d90a951f1@linaro.org> To: Drew Fustini , Guo Ren , Fu Wei , Bartosz Golaszewski , Ulf Hansson , Michal Wilczynski Cc: linux-riscv@lists.infradead.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2025; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=J8hhxEPGTDWzHxMDIGZhdqk+RbnXtaJ73h/HNS5w2Tg=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoWrb6545ElYvrc1gET2OFrM9gsPHxKk7OK16+E 9Xxp5PPJKOJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaFq2+gAKCRARpy6gFHHX cldDEAC9QFYvQdgFCGmN1OsF83q9dP6J3ttzdmws4vnanU/xhmtw5AvNBLkGJnyf4wiuUnhY9mS LsUBGrVxyeZlPf3WACN8cUMUqb3hhQY55Qszvh7fRvs0I2OF/OCai/HLPvzX0v92HIYJ+iSR6We 3MpJmzSDBWEXsEG8Hhz0bNys37m9+IL+PlWbQ68d0LfokWAUpfXTwBUa4+jwQMKVJcrGCyTnu8r hpHAEEwMRHRMsWt2i/ifysJANuqldhaThp6Rny0pK0Ymwa28RP445JPMWqGK43wjhO/e6y3RX21 ZvM9Qs4uP/EEzMDEVzFGfRYfq4GpNP63Q9efcGYe/tohWCydW2dBOYVD1ZZ2tVu4bauoHpamPyB 64HT0qbLoZA1CIUYyXpwY+q3zUwaHeJcKlK8EdM3R+PJnSjXb1x2BB2V/CqC+01JQ8nJG/CFzR0 pop1bz38H32jBaud5py5CTPMwkztfda0zwstBFJuW+YyZk74gs2wRroCbE4hVJKtbSvZShBpC61 d1+S20Sp7XJphn2nm8HNpOIm6T8WlSdpgwfNHJyKY5p2obqwPJhvS/tNbKKVkGNE/MO/Nov3kkG XmEonDNdAVE+6z+Z7zXH4Y6rLyOJ0MjOygcURMP+OB+XJvBdzjJcX/JgdMYzQ7ehCkr0JWgeXgq +V4Rib0enUeuJFg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski Instead of using 0 and 1 as magic numbers, let's add proper defines whose names tell the reader what the meaning behind them is. Signed-off-by: Bartosz Golaszewski --- drivers/power/sequencing/core.c | 6 +++--- include/linux/pwrseq/provider.h | 3 +++ 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/power/sequencing/core.c b/drivers/power/sequencing/core.c index 0ffc259c6bb6c8333ba1fc5e6ab43e42ba0d3524..190564e55988557940206b059fef52981bd49e5b 100644 --- a/drivers/power/sequencing/core.c +++ b/drivers/power/sequencing/core.c @@ -628,7 +628,7 @@ static int pwrseq_match_device(struct device *pwrseq_dev, void *data) return 0; ret = pwrseq->match(pwrseq, match_data->dev); - if (ret <= 0) + if (ret == PWRSEQ_NO_MATCH || ret < 0) return ret; /* We got the matching device, let's find the right target. */ @@ -651,7 +651,7 @@ static int pwrseq_match_device(struct device *pwrseq_dev, void *data) match_data->desc->pwrseq = pwrseq_device_get(pwrseq); - return 1; + return PWRSEQ_MATCH_OK; } /** @@ -684,7 +684,7 @@ struct pwrseq_desc *pwrseq_get(struct device *dev, const char *target) pwrseq_match_device); if (ret < 0) return ERR_PTR(ret); - if (ret == 0) + if (ret == PWRSEQ_NO_MATCH) /* No device matched. */ return ERR_PTR(-EPROBE_DEFER); diff --git a/include/linux/pwrseq/provider.h b/include/linux/pwrseq/provider.h index cbc3607cbfcfeb5acbc94908a1eb4a861159dc41..33b3d2c2e39decafac6c6fca9254ad4329d90e94 100644 --- a/include/linux/pwrseq/provider.h +++ b/include/linux/pwrseq/provider.h @@ -13,6 +13,9 @@ struct pwrseq_device; typedef int (*pwrseq_power_state_func)(struct pwrseq_device *); typedef int (*pwrseq_match_func)(struct pwrseq_device *, struct device *); +#define PWRSEQ_NO_MATCH 0 +#define PWRSEQ_MATCH_OK 1 + /** * struct pwrseq_unit_data - Configuration of a single power sequencing * unit. From patchwork Tue Jun 24 14:32:22 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 899600 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BE192D8766 for ; Tue, 24 Jun 2025 14:32:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750775559; cv=none; b=X5ujAVex5YsqS6D2gBeB2CYliOmivSddIgJkB+Y8WIXvfwrQ/kfdMbKMJZhBNIdHVLlhdX9MrWa7WJqKc86JnUsSTlFt6j7SySGr02DzO0Ks9B+VmJity2+0QvxCFMDFCeOeVEqlfdcMQSpwcxugjOhx1V+mROYwdeGlDRqZpzA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750775559; c=relaxed/simple; bh=iLYKM5JKB26am82HXGWbhN5RKHqdXM5CcMWlQP2QiyI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fhtDIeA48nIlcRpVPYXjxaKk8qu+BafNvI6Gove2vnvgEgPchsOdoITXWuJCZHdBsqvbgvQSO0cH64/vJ6wGSUgpxCp45MOMeI7JCIoONjJUQRMHGd6Kf55tnr3aeFlVuTLxvwVwnEsoQxvuyKMKGi1ceO72IN1HS+/1rfSVbaM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=Q3JQBv8A; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="Q3JQBv8A" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-453608ed113so48019305e9.0 for ; Tue, 24 Jun 2025 07:32:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750775553; x=1751380353; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=9CNIW5cNjKjCoab6AIakbGKNTJu3VYBmTvjInHO0Kug=; b=Q3JQBv8AbiHZ2nKJ/U8E83dqgOWOuiQ67ojQcO2JcQ4Aod//xFjiNmXqHibKLENrLe Px7TIIUTifkjREXkSoE0sf4B2EnkFa/70NwS1pcPHYugINOcvWcaysXKNf6uag+FFzfI mgcev4nAV8gy00+F/iGS16xszo2McrK3zQLUZc5V5zkbk8WC4VH8DL0A3ye+8+x3KgQy i1GWcavpjE7ApGgV2wSV5KlVZNFZpdbIukq+DYHqr49bw2AZIR+L3+FWOEybQn5LtEY4 aeepJPqnwdlELRuKl5n1Yr5XwmqwvHY4EQg0w67AWhPbXVEQ6InslPsBA4CDbjarp2X9 xwYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750775553; x=1751380353; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9CNIW5cNjKjCoab6AIakbGKNTJu3VYBmTvjInHO0Kug=; b=ccvPzwPdZdM+ngSLlHhpqvhDIpkAc34ladpxl0HPJtUFVtMalJgROrSgjVuDcI4ZwA YcTqxHvhee4xnlqByg06OZs5wmncuP8AZstv5dlNV+X/3r3SRBPa2ETSbULKcRJnVqio 8kcFCxLhX0CE2NkiKb5Lsufw+OVoJTxhU7ytDd3hIeneHt4hi8u+9O+Pt1NIjmbcBz2t VJ2rNp1YNSQchV7NfKHahfLUjeMAGzQYaPbMWaOXSaDjv+epVvhCzjugTicOpqC9zoTF WbQq6bkyv8yP/6oHCfgoF41H6ExhD6+UEDxPF+YbGhkcKhSbxupHHSKw14+P48w/JKaU S8LQ== X-Forwarded-Encrypted: i=1; AJvYcCX8i6q3tyiwHdu9VKGFTRde9eHGt5Um/khRuFXY65C/2g/vD14FLMIpxoRukT7IYm0Tbld7i4AsHg==@vger.kernel.org X-Gm-Message-State: AOJu0YxJ4xHXi5z0K5dRcFoJEZDjHvKXm0omxAHMg4YIoRUyfeynCC3I L/vHKEsLRr8E0aTS56VmZPPo2n48IPbXyq4PG14Kdg8r/ltcnAmZmwdKKIAUshA8EJF0BQ7X5h8 6cLmfni4= X-Gm-Gg: ASbGnctjKrupoEfvkMzPBU2qjIRWyUMIk8xAuerSExDFpDrXIWN+Xc+uhaq3M75tiIZ /G5m5F2gJcKLlWj7eP1xlLpK/7G6JgeRbIUOQiRKXEeshSKmYTNZB43O/AoO1m+4+S4FAAsmQ8Q +OA4Rqa5MdyS6w8g2rJvmg6wtOc7SJge/cC+y2Fg54AGcALI7Vtor/MNoXzN694UB/AUJ+3cJ8g GVA5a0j27I383pkhvsDccC3p6W+JqTGXGOV2LYtd8WEcrc9XyaZxXU3AQYOjZO+D4eUYG8gzMuY SC0ha2uDmnlZtMeluAxqFeb33RlqJfCPFKoHlljZN4n+PGdjT80qqO9f X-Google-Smtp-Source: AGHT+IGpuQeND4OkNgfppr4DzG+xyz0jUMqc4qLMdr3DGhKhUgWRg/xb9I4Kd3VA/X3bAzgBxw7ciQ== X-Received: by 2002:a05:600c:8594:b0:453:9b3:5b67 with SMTP id 5b1f17b1804b1-453659f8324mr83368095e9.24.1750775553416; Tue, 24 Jun 2025 07:32:33 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:34d2:109c:3293:19e9]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4535ead2a84sm178512935e9.32.2025.06.24.07.32.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Jun 2025 07:32:32 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 24 Jun 2025 16:32:22 +0200 Subject: [PATCH 5/5] pwrseq: thead-gpu: use new defines for match() return values Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250624-pwrseq-match-defines-v1-5-a59d90a951f1@linaro.org> References: <20250624-pwrseq-match-defines-v1-0-a59d90a951f1@linaro.org> In-Reply-To: <20250624-pwrseq-match-defines-v1-0-a59d90a951f1@linaro.org> To: Drew Fustini , Guo Ren , Fu Wei , Bartosz Golaszewski , Ulf Hansson , Michal Wilczynski Cc: linux-riscv@lists.infradead.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1879; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=yIgDwVNP75QjxnnqZUB0eGQftgqLdSGUdNGqQ1mRb+U=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoWrb6qvHHx1tWdZ36+EKv6o8uu1Y32EArBy66E w7IaTlvyISJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaFq2+gAKCRARpy6gFHHX csZVD/9fv5ytgmoZV9N33yr8RMxpPBdNHbhkZf5RLOhy3kaBXhDurMDLG8dJ5gKQFjqAlE3EfXF eJv5toKg4IJYqISkg5O5CnP2z5+DYZLrVhsvD50ZTLF/SxmuoJr+Nm761WUIotQm/fyaVlG5L16 YpuTxlQx32/iAfiz5p2zcoR3as535Y4h0/uPtpvx96MA+K4G/8iv3m416K1ucMaFiGKXFhLLdxG pAtEFKVWU4znKw8FzQfdwGV5D4Vpx0GpBGSz1VIT1hkhnLjgUgjXMOUmeWuvJtPm+lGH7zp5f/F 83VVNmuppn2vC1clDinjXBZxHEyX6X2nZ/tDgXXJr3UI0QeOrJH8cq3Yz9sgkFlHKd/Vw8/N9nA G1QqG+Prg1iL8tX0ntGheLYp52P4yVg2LCc+G7T5btmiuvWE9gsU/hU/4eW7ogsbrWHCDwJ1dYj i6mxMhkOLxVjNB8GnhbYq3D/kNwAcJHyaUIebLmPmjgf2iaioEnWBTJajwEr0CsJCq851pDlCPg 7uQrZiFWMv3OVzsX653lXcONTHxlEZM/yTNo+UcguuyUI66JQY3pRu5H4NHxUwXRtnu01VcND7q uZnFMJVi4uupkyRhrVT7h6v7UGwdJhtA0BsQXRbI+gveepJ+I2hjVNjbzRo+SBDsDh6O61455YC +QHJk5DawusRH0g== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski Replace the magic numbers with proper defines we now have in the header. Signed-off-by: Bartosz Golaszewski --- drivers/power/sequencing/pwrseq-thead-gpu.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/power/sequencing/pwrseq-thead-gpu.c b/drivers/power/sequencing/pwrseq-thead-gpu.c index 855c6cc4f3b5bd1aa6e93305af0417d5791b092d..7c82a10ca9f6917e673711c55dd5e58e58dc8f5c 100644 --- a/drivers/power/sequencing/pwrseq-thead-gpu.c +++ b/drivers/power/sequencing/pwrseq-thead-gpu.c @@ -124,24 +124,25 @@ static int pwrseq_thead_gpu_match(struct pwrseq_device *pwrseq, /* We only match the specific T-HEAD TH1520 GPU compatible */ if (!of_device_is_compatible(dev->of_node, "thead,th1520-gpu")) - return 0; + return PWRSEQ_NO_MATCH; ret = of_parse_phandle_with_args(dev->of_node, "power-domains", "#power-domain-cells", 0, &pwr_spec); if (ret) - return 0; + return PWRSEQ_NO_MATCH; /* Additionally verify consumer device has AON as power-domain */ if (pwr_spec.np != ctx->aon_node || pwr_spec.args[0] != TH1520_GPU_PD) { of_node_put(pwr_spec.np); - return 0; + return PWRSEQ_NO_MATCH; } of_node_put(pwr_spec.np); /* If a consumer is already bound, only allow a re-match from it */ if (ctx->consumer_node) - return ctx->consumer_node == dev->of_node ? 1 : 0; + return ctx->consumer_node == dev->of_node ? + PWRSEQ_MATCH_OK : PWRSEQ_NO_MATCH; ctx->num_clks = ARRAY_SIZE(clk_names); ctx->clks = kcalloc(ctx->num_clks, sizeof(*ctx->clks), GFP_KERNEL); @@ -163,7 +164,7 @@ static int pwrseq_thead_gpu_match(struct pwrseq_device *pwrseq, ctx->consumer_node = of_node_get(dev->of_node); - return 1; + return PWRSEQ_MATCH_OK; err_put_clks: clk_bulk_put(ctx->num_clks, ctx->clks);