From patchwork Mon Jun 23 12:30:34 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pan Chuang X-Patchwork-Id: 899641 Received: from TYDPR03CU002.outbound.protection.outlook.com (mail-japaneastazon11013055.outbound.protection.outlook.com [52.101.127.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F65212C499; Mon, 23 Jun 2025 12:32:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.127.55 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750681933; cv=fail; b=IlS0mRMZ1LMyQgSCTlZtvFYAHeCn4HA//jX1IKS4XjwPdw4O6GujnhjzhDa1ATBFNrFgBqcygfHDjdrmdMIwXPDWq+UvzdvhkSIH361xRptKEi1F8BpOuCPNZ99fChgdDJhfV1iYUPbRU7XvjRJHNBLHzpguhOh+JQEy8gKr1sw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750681933; c=relaxed/simple; bh=Tpfwy7lTMgV42NFEkAN5PiSCjy7Zcq7FKF8xwXsU+No=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=FGjtNGQ7PjMsJI/UAOVebDqlh1RtTLUsm7Ja54AKAyO0GHo20FzJEo6cUqzOZiIzQ185ocGH/Dy6KGYcwMWC7mzQ8LKzhveMT1bGiU3xtqVKOp6wGUkoSDQWbpxA7MkY2R8FvdfYR11NBGN1asJS0d5BWa+om69Di39EqS+Iv4o= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=Q+xc1/8k; arc=fail smtp.client-ip=52.101.127.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="Q+xc1/8k" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LabcuhEI7R0OHPDl6CGYqLYHr25DLNeSHKGqMPr4MfdhX4awHYAPAmAi/eeeQEPseWETC+yyre1zu99BG0riVszYD6/N67ns4bPopLPXSQnkcxbZF0itwQTjAA+CkmAro6VMxzLG75wo43Rzkn2BGRJq/Dj2g8WrWr26yHNTaboJ6NFCGsprYtQ2gfkNbtA0FMOOAc3JIp4gK2T6YSqQg1Mv2LUkIdYXqZF5h+2JAtwR0grQd8XODViNAcXWzkTlf2YhBu5E2R2+yAQ3lqSQq03XJmb23B64ppOh/gXRBMQpd/jNmiYxWF5eZSx3R8izm+yqfVxBAEnyc1oyYCg2bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vocg3RzS4BO05UD+5EdoWPqN5uUHyMEOG0x3xH7h0Q4=; b=dz8+M5m+mmzBazqnVCC7L7DvavNn7/+kSpg7rYTuQ2p6w2zXVHqmGKtITs579/D1w7zTXWSAj8kNl5B4lalgeGkLHNcH2NWbtBHZb1yDp1TSwkHBVonA/CdkHzugH6SaaPotJ0LAoV88GGXa+g3bMbhM7bCIfvc3LzPYlsHQKnsxhSrB6U5RrjIwDVb3GloRZwPCOF/1mkuX7sKu4172F77qF4XLU085UTT4mQz1yu0Dggnkvj7Qq4mBMZQVUVudS2GW5yLTJ8xTWnFsu9zlDhKjr6AZWhfvDeMGQX/ZUChcWZOslGUM/e33x94XM/YDHUOuHsN1eyvxB+R5ASSptQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vocg3RzS4BO05UD+5EdoWPqN5uUHyMEOG0x3xH7h0Q4=; b=Q+xc1/8kKmI1r2CZ+jreb/MupjlqPrTomkN+wUhfEIHAroHfoJtx8uZJ2DJKCY6Bj8V7SWVZomsR4oiwsFyma3lzWU4TkyTJaGu9pjgN0vvdgIeUaI+SxnOjmzOruoomkIeL8EJz2lWuAw4RPmbrjHySSHlCcn3fosNPjgK6oxeYELjVKsjVMp3668rj9PI41U7dxuFKNn9NxW4mNpKfzZP7xH2evs9eqiXweQoTl8hYDWu7zHo9nZf1LfJ2NgKuFKcgeDazHKunGi7FFvlWmyKVzih5gIrtBgOX7UWzypyBjqpP+E5tHeKbNVrqRabdpsw9lQ73uqrJeOfJk+ZUcg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from OS8PR06MB7663.apcprd06.prod.outlook.com (2603:1096:604:2ac::8) by TY0PR06MB5185.apcprd06.prod.outlook.com (2603:1096:400:21f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.26; Mon, 23 Jun 2025 12:32:08 +0000 Received: from OS8PR06MB7663.apcprd06.prod.outlook.com ([fe80::46a5:9b06:416e:1e49]) by OS8PR06MB7663.apcprd06.prod.outlook.com ([fe80::46a5:9b06:416e:1e49%3]) with mapi id 15.20.8857.026; Mon, 23 Jun 2025 12:32:08 +0000 From: Pan Chuang To: "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Miquel Raynal , Markus Mayer , Broadcom internal kernel review list , Florian Fainelli , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , zhanghongchen , Yinbo Zhu , Amit Kucheria , Thara Gopinath , =?utf-8?q?Niklas_S=C3=B6derlund?= , Geert Uytterhoeven , Magnus Damm , Heiko Stuebner , Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , Alim Akhtar , Maxime Coquelin , Alexandre Torgue , Vasily Khoruzhick , Yangtao Li , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Thierry Reding , Jonathan Hunter , Kunihiko Hayashi , Masami Hiramatsu , Thomas Gleixner , Matthias Brugger , AngeloGioacchino Del Regno , Srinivas Pandruvada , Greg KH , Peter Zijlstra , =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= , Conor Dooley , Julien Panis , Arnd Bergmann , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Colin Ian King , Raphael Gallais-Pou , Patrice Chotard , Jonathan Cameron , "Jiri Slaby (SUSE)" , Sebastian Andrzej Siewior , Andrew Morton , Costa Shulyupin , Yury Norov , Cheng-Yang Chou , Caleb Sander Mateos , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Jonathan Cameron , Pan Chuang Subject: [PATCH v6 01/24] genirq/devres: Add devm_request_threaded_irq_probe() and devm_request_irq_probe() Date: Mon, 23 Jun 2025 20:30:34 +0800 Message-Id: <20250623123054.472216-2-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250623123054.472216-1-panchuang@vivo.com> References: <20250623123054.472216-1-panchuang@vivo.com> X-ClientProxiedBy: SI2PR02CA0051.apcprd02.prod.outlook.com (2603:1096:4:196::10) To OS8PR06MB7663.apcprd06.prod.outlook.com (2603:1096:604:2ac::8) Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS8PR06MB7663:EE_|TY0PR06MB5185:EE_ X-MS-Office365-Filtering-Correlation-Id: c61aa7dd-385e-48db-7762-08ddb251f7eb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|52116014|7416014|376014|366016|1800799024|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?BrqqTI3MU4pDKAJVJEh8w6rqmqy7TOV?= =?utf-8?q?DatnvNMiXEtZsCm1SlMduFICRjes6ZuSaMWXPSXkiCpsCPriA6Sm7EXtE6TRRQ8+j?= =?utf-8?q?YhqLiY2D2zvjEbgbH/xsiJw24crhL51pFoMzKK8TkeN6rzi4+AK9RxUs92s0i0Y/a?= =?utf-8?q?1tix/71oT4BxlvkjPbp/HTln4X+4FOVpL0IvD6DSBvbVXorDaCbCbXLDqLgMRhQJN?= =?utf-8?q?Exczaa9gl7q/DgfOTqQVmq2m1nU5Tbg1j+HR8TAp/0eV4sZg3rRB6zmTV0TWrrLkU?= =?utf-8?q?Z7U2e97fgFg3TQozvw+oY2BpeyGY1vm5gYQ2znLe92f4OXQ/472zBwtwD5/Lpagj6?= =?utf-8?q?GGkcXf43hs709OUqZruC8fTZIVonljlMYy7pe+nsyKbO1eBKSPCGy9ktq/7XX5saX?= =?utf-8?q?8Te/u67ULauVNir5uuqJ1Ob+TyT2WGYbpPrs1puidpfP2rYvlhYZSGTztU4jBQ7qQ?= =?utf-8?q?drHlWzEhYm3TS3K62PJXlaMAK0AZzi/GgRLOSA0gO58WIdU2WkFwSjvPAxAw/lisj?= =?utf-8?q?7ZJg11ls7JmsinUXU+WkCBv8DQljFnK+QJOJh3NAnyThBp8DxBqgsaJIEDGIFi5ls?= =?utf-8?q?+/3AeqbQa/fYYEQwlIz2VR84PR3mgfEnuBWYGBthEMbyShtKHJKFZCpLa/XY1I52r?= =?utf-8?q?vaFF2y0MrCdLIKmz5ged9C9Wfi5qUFYNMy8UO7Y/IhwNA0Byl6HvZlEzrYDGdksYb?= =?utf-8?q?4ZTiwFtlk+p59jO+0h87S+PDNewhe6qJFCvb3IUEzML5xmN1x3vYYe3Drapvyg77U?= =?utf-8?q?QmqCz84ysr7P1IU+7OcSczkiLR3dwP+iV4eQVPRXBL0oJzzWxvxnAuZZ1Gew/8hQs?= =?utf-8?q?0M0u31/rH+nBbG21hcJfjwfIlU4BZqS7hj4G4WZxTaEqyRg2ZLmUHIpYrFUpQnYdr?= =?utf-8?q?LugMDiW41malxCXIdY2+kbRntyDamwkLrwlYQYdJojOjRYRBDPeChrnHHX37w+iH9?= =?utf-8?q?5Vzmc2F4osSzj7CrI9drBBbYOzgq5erlfJPldR0jMXs6hBzq8MomEIlgaUIk8lp9v?= =?utf-8?q?fXFCv7ylDLmannNmvW3LAxBPBzd+EUC2Ncr4JDQCcvM8vGnefqRT5xNnlfV4ba/dx?= =?utf-8?q?GkETYpp4lB59W1NeA6Vv9FDIxFo6bfxERrTQMTsLCEvY1WGpFSigRzWOm14OtLjlq?= =?utf-8?q?YS7B64wXYuY7EolK0AzWuYTR+aNq1YlRaKcq05Lt6+43ZAnucckDVOOr6w1NWMBlH?= =?utf-8?q?o3PbkLk4RR5zsynVKLeR8djZ7x/XLaxQ0Ci5bvnTPeZVyYzlVEqOfBRYhnDwhFLZU?= =?utf-8?q?0xAbHAXRexo0gC+wfHurajyyQlsnbVIXesFnzOi8XA9IG1h/1yhQvSWlRBbXSfe3g?= =?utf-8?q?jL+zfPAuMzcWCkSmusGmSpV7j/JB3bYO2lbMlfFSOZKJ0fi4VLvTdx7FlidT+dB00?= =?utf-8?q?t+w2cCbKIq2K1AtzdsXLgc0UvGbVMGJiVqd+Xuj82qbiunZZjucegU=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:OS8PR06MB7663.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(52116014)(7416014)(376014)(366016)(1800799024)(921020)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?zLe7mgs8ug5aN/Bo3wmc3etLN9A/?= =?utf-8?q?lTEJpaL+NKUjqgYM1CGPkzf74Pp7An3dKxE4Pzhs18fNo4FO55xLcOGe8YnmtlhRZ?= =?utf-8?q?3ybx9GoTbLlda5hndS5HggHN44dw8njqqowQIiOJEQXJR5kZaCwCskx7y8+3H0Czi?= =?utf-8?q?6p/VEsgsu/8KPWpa28lpg46OaQ2odXRRajfrtW5d0qLgKdxyuorWtNt6hcWI+Bma2?= =?utf-8?q?YcT6Mdk9QT7++QRnK2KQGKIWAn0WlAD3EIH2viBCWUStkgzjoWg9kcn3QCvpS+YTB?= =?utf-8?q?UiIkML/FKVYk9L9NPzZ1cHz4OsuHy1YQihFHsjPSn3GXyEmNnu1awDMeC54/5Z9Oe?= =?utf-8?q?ZlGRdZpjMmO0pO+vwOVRJ7Z8SCoHoFCGHey/MbvLV6xq3GN7h6j8b30vmtSqo4ST1?= =?utf-8?q?IJR/+QWl/HV0BFJ4OyaAx8ylXL3vtMBB047Nax1m2y7Q7bH2tJ7OAJ0zUnEu3jEFa?= =?utf-8?q?P9Tv7OTqpfttNgX7/nwQRITO1OupsrA0GlrZNsX/kGYmfFO6pIkLtbLOzTurQ3nNH?= =?utf-8?q?EE6tcbAt8lX76rMWXOr05ifNPOtF/IycB2LRfHaiHU6+7H1rgUbfFSOtlivQYUhVc?= =?utf-8?q?0ACNDJw+aL57/7NkuDpjhNJuLzgagHy+A8I7SprsCVHiMZ8jHJTG/wTTkdimvEDFY?= =?utf-8?q?SovgE87BGUwwYMGfTJG3HES6RgDYsjSFuNUBY3Y+CclIWrfZSavE9GLfos50dcVVm?= =?utf-8?q?U90VgXD0D71wF5w+omiOtnUqLV21WOjNGY9HqtaQYgtAIUBPURoOi/pCgU7GqkvlP?= =?utf-8?q?I1aU21fKvaoFFOlpI9qMI6Dz1gycGQKuvoLPNmubJuL1pb3N0FrbIrvoO1LWp5Yei?= =?utf-8?q?LsXW3fXVWTfxsrM2Mui+u4BnttmdwBgp5NBrIGwdaBfxMz2BTvwgigY1RfnHlq730?= =?utf-8?q?gBkgGhEgoZ0vdE/IGkoqylOdzR2QrNyebXkLsQtQBbZcJbjRmfCifnG8v4KLaEdNr?= =?utf-8?q?1+O+NUiTH8d3AwnawqDEUubozu8SQKiS8xR11lAy1aRzfJoVmAFDWaOCrtlB/pDbw?= =?utf-8?q?3XShmDjNRBK5MHmIk2fLC6d7e4fqJ+j8++XdqAOto+75nlW87TzRvwCnn664Kfb2g?= =?utf-8?q?UnMlLAO7JNVEOh6OAxxe/Awjj0RJB5EywszZReIy4eUbCXNcO7bxTvz+nu5BX7DIf?= =?utf-8?q?SE5fTQ9Pd0mWFCMrtLVuhjfYJ7euEPdlFwOWyisEf25VwEAjediaMHquTVgQeo7b+?= =?utf-8?q?zBujxOh2Kswsm1CTqy2+kahArmfO+bIAat1dr12TktmRIMTIGkAKL+S9jX5Qdde90?= =?utf-8?q?nlQ5goocp0OF2Hgz5Tm+IqbeoNWtBM/KsmE7wd3hSwQ/56ak7wyRmA/xzJluh+uFj?= =?utf-8?q?51tMFnFoSJdBHjzkW8Qy0XIdZFsiMKnDn4k2JLKpgSHxgXEID/YIbPZH/bYtWHele?= =?utf-8?q?e7SbIEupHjhzQevtYB5PWP4y2/pFYVWFlkcbCJsiO2FsDndV+0O9LNeDHtMG27v54?= =?utf-8?q?UQYEPMlkoQLzLHduPfY1QnS360kKC+wm3aU1X9PNPp0P0mSI6LONiMKdvg6GuIQuR?= =?utf-8?q?KhYwwKmP7xAH?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: c61aa7dd-385e-48db-7762-08ddb251f7eb X-MS-Exchange-CrossTenant-AuthSource: OS8PR06MB7663.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2025 12:32:08.1159 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: T8TrhS4vQSuLAO+GIir2a6VCIS0vwqh+lw53pF3RgoxHJvQjWInSiMN/Rr3pbfTx8t/tHesWblORkRrIeMwyaA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY0PR06MB5185 From: Yangtao Li There are more than 700 calls to devm_request_threaded_irq method and more than 1000 calls to devm_request_irq method. Most drivers only request one interrupt resource, and these error messages are basically the same. If error messages are printed everywhere, more than 2000 lines of code can be saved by removing the msg in the driver. And tglx point out that: If we actually look at the call sites of devm_request_threaded_irq() then the vast majority of them print more or less lousy error messages. A quick grep/sed/awk/sort/uniq revealed 519 messages total (there are probably more) 352 unique messages 323 unique messages after lower casing Those 323 are mostly just variants of the same patterns with slight modifications in formatting and information provided. 186 of these messages do not deliver any useful information, e.g. "no irq", " The most useful one of all is: "could request wakeup irq: %d" So there is certainly an argument to be made that this particular function should print a well formatted and informative error message. It's not a general allocator like kmalloc(). It's specialized and in the vast majority of cases failing to request the interrupt causes the device probe to fail. So having proper and consistent information why the device cannot be used _is_ useful. So add devm_request_threaded_irq_probe() and devm_request_irq_probe(), which ensure that all error handling branches print error information. In this way, when this function fails, the upper-layer functions can directly return an error code without missing debugging information. Otherwise, the error message will be printed redundantly or missing. Cc: Thomas Gleixner Cc: Krzysztof Kozlowski Cc: "Uwe Kleine-König" Cc: Jonathan Cameron Cc: AngeloGioacchino Del Regno Signed-off-by: Yangtao Li Reviewed-by: Geert Uytterhoeven Reviewed-by: Jonathan Cameron Signed-off-by: Pan Chuang --- include/linux/interrupt.h | 15 ++++++++++++++ kernel/irq/devres.c | 43 +++++++++++++++++++++++++++++++++++++++ 2 files changed, 58 insertions(+) diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h index 51b6484c0493..5c39ff7f030c 100644 --- a/include/linux/interrupt.h +++ b/include/linux/interrupt.h @@ -205,6 +205,21 @@ extern void free_percpu_nmi(unsigned int irq, void __percpu *percpu_dev_id); struct device; +extern int __must_check +devm_request_threaded_irq_probe(struct device *dev, unsigned int irq, + irq_handler_t handler, irq_handler_t thread_fn, + unsigned long irqflags, const char *devname, + void *dev_id, const char *info); + +static inline int __must_check +devm_request_irq_probe(struct device *dev, unsigned int irq, + irq_handler_t handler, unsigned long irqflags, + const char *devname, void *dev_id, const char *info) +{ + return devm_request_threaded_irq_probe(dev, irq, handler, NULL, irqflags, + devname, dev_id, info); +} + extern int __must_check devm_request_threaded_irq(struct device *dev, unsigned int irq, irq_handler_t handler, irq_handler_t thread_fn, diff --git a/kernel/irq/devres.c b/kernel/irq/devres.c index eb16a58e0322..40e3862b0e80 100644 --- a/kernel/irq/devres.c +++ b/kernel/irq/devres.c @@ -80,6 +80,49 @@ int devm_request_threaded_irq(struct device *dev, unsigned int irq, } EXPORT_SYMBOL(devm_request_threaded_irq); +/** + * devm_request_threaded_irq_probe - request irq for a managed device with error msg (recommended in probe) + * @dev: Device to request interrupt for + * @irq: Interrupt line to allocate + * @handler: Function to be called when the IRQ occurs + * @thread_fn: Function to be called in a threaded interrupt context. NULL + * for devices which handle everything in @handler + * @irqflags: Interrupt type flags + * @devname: An ascii name for the claiming device, dev_name(dev) if NULL + * @dev_id: A cookie passed back to the handler function + * @info: Optional additional error log + * + * This is a variant of the devm_request_threaded_irq function. + * It will print an error message by default when the request fails, + * and the consumer can add a special error msg. + * + * Except for the extra @info argument, this function takes the + * same arguments and performs the same function as + * devm_request_threaded_irq(). IRQs requested with this function will be + * automatically freed on driver detach. + * + * If an IRQ allocated with this function needs to be freed + * separately, devm_free_irq() must be used. + * + * Return: 0 on success or a negative error number. + */ +int devm_request_threaded_irq_probe(struct device *dev, unsigned int irq, + irq_handler_t handler, irq_handler_t thread_fn, + unsigned long irqflags, const char *devname, + void *dev_id, const char *info) +{ + int rc; + + rc = devm_request_threaded_irq(dev, irq, handler, NULL, irqflags, devname, dev_id); + if (rc) { + return dev_err_probe(dev, rc, "Failed to request %sinterrupt %u %s %s\n", + thread_fn ? "threaded " : "", irq, devname ? : dev_name(dev), + info ? : ""); + } + return 0; +} +EXPORT_SYMBOL_GPL(devm_request_threaded_irq_probe); + /** * devm_request_any_context_irq - allocate an interrupt line for a managed device * @dev: device to request interrupt for From patchwork Mon Jun 23 12:33:52 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pan Chuang X-Patchwork-Id: 899639 Received: from TYPPR03CU001.outbound.protection.outlook.com (mail-japaneastazon11012019.outbound.protection.outlook.com [52.101.126.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87E71239E84; Mon, 23 Jun 2025 12:34:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.126.19 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750682047; cv=fail; b=BelWhBy7YYJcJbp1dAXyEeyMu0z9yHrnkKrrKnun32cAxa+/bOUZascRfEWR2X9yuPJVkQuIKsTwiGK7J4fOyjq2McDGVa0JkINv6njMukXfvFhopsXIdFpmJ0o8aXr8E7evstmn7r1AB558O/29rCIbO6JErBY0RndsufOQWdk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750682047; c=relaxed/simple; bh=VKwNORudEizAqHSxQCbO+KDnH3oGJ03C6ZoJlXBMlUI=; h=From:To:Cc:Subject:Date:Message-Id:Content-Type:MIME-Version; b=qhyhesqgPAwSBkjVA57VBifo3ws1C7DLKgiu9JyL0SgM8mOKIRLiNmXGE4GXq6OCmqQY2X2+YMae6m4mHtpqNyjxkR5jU8pC/ZmtDi5eoKMMF7Fi96986RiISqFK883NcZekKCm/kwQTvC9vYBOWXp0Pl7U5aWOiVTxD4k2fmGI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=ENWM7dDu; arc=fail smtp.client-ip=52.101.126.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="ENWM7dDu" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RpYFMLBQ8op7sJ/OC2AUEFpyl4lhQYnAkc+tTNjtUvZlciYuuhBxigMRmgLjNFWeRLzL2T2aSK/tdbu0oK2y0G9VHBsI2ESwpR2zgdR/qLoWHaHlxIqqwtpnP5cW+4vLTVGIlslzke7pgrICNUvTlqMVT6PdXurvUovPwivGLDw62VPMiaSFReR4wU9kdNLB/Q2VbIW7vi1wBPgpo7aPHqcC7gZ1vaHauvLPYvdiuEtRlNXjdl7VYptugdmmZ4ygfOtc3gcEVfwW29wcDCa7yS0O4sTCPiT14edikyyEu3t5rnvCy37oC2SENkUwgpt5+E3WmA3177qsO4Kjwj2Oxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hSAS+UdF/2Ab3HHQ9yBDm26rWQXm+1hirRlkWJ11GXM=; b=Wqo2XHcbQk+VF+CXzOvFUHASwzEi0TQGHdYoByG3+R0MrZOpOxmz7xWFE825ZGJy/YZtD9e+gltJiz89BHB3Jf5dwwxTFpu0h0DqKxOthEViAhf9W6z0SURwq2T4IABZcsVnNGCfWCTsrIXa89mpFkkWE+osxvCZ65+rX7WcEYbFcKmi0rUXsVNFVS73iW+3r2ns463RTYy0urlHk8gfEtGnNGGVAAFAQyR/aVyAth50he1wZJSIxcn3VzFL3UN+Rs5hUn4TA3dry7+QI3K6eZlK4pG8EVgcbQo6/H2lfyJMIIXhfou9ooKc3EsWI7L0J9WQn/n0bAGy2zUuuSeVjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hSAS+UdF/2Ab3HHQ9yBDm26rWQXm+1hirRlkWJ11GXM=; b=ENWM7dDuC1rpgYd2GRi0VjfCGFuA2jYKAK98/a8nG0XP+SivpSo2IoOqG1Ba2v+CdTAMsE7KGsO/pQS2kmRoED9TK8Q88A/9g61Zxvk80jNapndAZaNrer8tlToxfNg7f5OpOWjsBIXAcVcPKusnhZa5S6cTg7tiYa13RRbzAeZ6SZPeFfl8PmLz5aa4atXtIhGDlqy//3k6I83GTEHP27lPrWey10QJXkKdNTXkV3QpJfHQ1ylwDpdr6A1Z7goxJGOuf9tMOlqPATGF5BJEZK8CTfM9e9pwuhPa1ekFNipDnCV40L1ZaMYUjxlCKFTnAaqYQujCgCzXJZhS2iTaEg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from OS8PR06MB7663.apcprd06.prod.outlook.com (2603:1096:604:2ac::8) by TY0PR06MB5185.apcprd06.prod.outlook.com (2603:1096:400:21f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.26; Mon, 23 Jun 2025 12:34:02 +0000 Received: from OS8PR06MB7663.apcprd06.prod.outlook.com ([fe80::46a5:9b06:416e:1e49]) by OS8PR06MB7663.apcprd06.prod.outlook.com ([fe80::46a5:9b06:416e:1e49%3]) with mapi id 15.20.8857.026; Mon, 23 Jun 2025 12:34:02 +0000 From: Pan Chuang To: Markus Mayer , Broadcom internal kernel review list , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Florian Fainelli , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Yangtao Li , Thomas Gleixner , Krzysztof Kozlowski , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Jonathan Cameron , AngeloGioacchino Del Regno , Pan Chuang Subject: [PATCH v6 04/24] thermal/drivers/broadcom: convert to use devm_request*_irq_probe() Date: Mon, 23 Jun 2025 20:33:52 +0800 Message-Id: <20250623123353.472668-1-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 X-ClientProxiedBy: TYCPR01CA0175.jpnprd01.prod.outlook.com (2603:1096:400:2b2::15) To OS8PR06MB7663.apcprd06.prod.outlook.com (2603:1096:604:2ac::8) Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS8PR06MB7663:EE_|TY0PR06MB5185:EE_ X-MS-Office365-Filtering-Correlation-Id: 0e80cb9c-b862-4b0c-64cc-08ddb2523c3f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|52116014|7416014|376014|366016|1800799024|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?HxolPAHmi3qK2QQaAEwX++nMQwIHFIt?= =?utf-8?q?qxK4sR701Cotvv+yfSoFkmtG37RmVGEd3wxDpLDm2tGZZ5Z8vJnVsi+TNmSbGiJYB?= =?utf-8?q?XseX5YpUwwJsgtA6U8Bz1Y8/t9U2UwWowedWArwVEZhGFRI7JS5UFrJTBSBGSr0dp?= =?utf-8?q?6vivRCn/E5KpuIxJfHHsTYK1cwmIQ8azaU3jgdxLdV8cqw+P3KXHNXD74mg/JSJKa?= =?utf-8?q?zf7lMouDuYQViZgDIEdTkLmYzBITHIpKCApvlexs/NWFLN9miBGYrnP7QR7IrplF8?= =?utf-8?q?iutG63z8sJFPRyVyEGbagG/jFEAKnsE/iA8eLucX+LG9tEXcUw3YRN8wxolsNjaL0?= =?utf-8?q?K6sCdZRiIeRz5CwYkMhRBuxRMajDBL6PbX69f4OfbGl96PS8wSGAEfZmtVmPi3Hzx?= =?utf-8?q?8BhOmBqE3fQpQHbCh3Ok74DUgSftlGfVlvgkeO/6OPnHxjKOw+6o5qsvZ/ZfToV3v?= =?utf-8?q?wNuZyx5GgRJdP9tOhsnunM3NYE6dpjl58J5rRH/h3thO68wzk3619CorklEckb5dk?= =?utf-8?q?o+sQnLvTy77obiVpLhmYdj6jjcNutDgRDrazGD+RhK5XOSGZpljuonw1O1DM/TdWx?= =?utf-8?q?MEM1tDL+d7hzMhxP+aHCkKLHcRxTNOPSS3zd9jzuKKo0KXX6ZnrB+x3sT2C2zKx0e?= =?utf-8?q?QUZfDk/MIO4UWLba9PDhKAD5Nz4xwPseQKgNSX3zGpHEIK+RJoRxYU4l4Ann+XXQp?= =?utf-8?q?2NOuZQHCZuwkzpjw7ZpvvbhuTLuK0ktch68XizhiAI6jemFxd3w5TmdGfFQWHfMz+?= =?utf-8?q?To+dvWmenfsLMXfxeNfWxJyI1RuMT9edEwuZXJuWUB3OS5Dduh/FOljPB0upEUnio?= =?utf-8?q?WkygvH4Ynb2cNFPjk8Nkerk3t0QmaZU5ESXs7UwwicE/z+ldx8VHJzc2h9mS+tHId?= =?utf-8?q?/uOboPt+MX+JX0vOOIKp4sLkfsRLdoP2NU5Lz13nCWvSU7q/rdQStKH3rq9frhJeO?= =?utf-8?q?mAgA6IeihS6xKVBcx1nBoFMyqlCTQx05xbOmZAwI4hYFkLM7zlLn0Aiq96ZQ1ORq1?= =?utf-8?q?GWcASflNvqHp/HwdEMtbR8KHo/lEX4L4Gq+ooNhtdqpdFSczi/xJkL0B02eMeRhHF?= =?utf-8?q?/L1zd4C68Fc66yG3REszq+Qa6MUWT0Lkk4Zu37P2Lvo5wtdhNfAk7kQXIbrVzspiv?= =?utf-8?q?8YOa5HlnFDcNXetH1xKSTIrx8C+1HAed0ZySkDTcWvY3luVtZa61HfyX1i8HUpOpv?= =?utf-8?q?lmPGi2429m6LiE0rIlRBT1ofmwh5KetzxSLtfzhOdfyG3rYtjUzfPKCYWYMViYsgf?= =?utf-8?q?MWvq41xAYBWO4HpkSrj66r5RhFKgN24RPVbW4kukJSSZWqpay56KzgzWo14kBpwf0?= =?utf-8?q?zEqRh90n1U0TvkbFg1nnf3EmojVHO98cx4YVB0Qk1s5z9s9kQUkDE3rSiyUellg+o?= =?utf-8?q?VJqJmWcYki8mQLZVNGTSXcWVQxHbG0VnFWEvIjpAZQYSJdmJtziapI=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:OS8PR06MB7663.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(52116014)(7416014)(376014)(366016)(1800799024)(921020)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?zfI1U8FFjL+pN5ugAxWIot/hJ5P2?= =?utf-8?q?RNQ1varxC1mu7jKNwCjytG2fbK09XjqzRBuNX4MYBuoVUCg2ksg2CapuhowL00baQ?= =?utf-8?q?JwIK7VyLFsOgvCsb9ajhh5IifrpCKzH7v7ivPHRpxtX8LNpaSO94rGuT7CxC+IXBT?= =?utf-8?q?Vjm/F8TUi58HBinAzVzjYMka9wOWkLB8pU930ANi+PUJvqK8qJNtgmxyhNQkNT7b6?= =?utf-8?q?WMgypiChdnbo0cs6G0OIbN58G+LipbGtLsToaT0oZCMHNvV6Dl7NIFPTF9wzBTcG0?= =?utf-8?q?4t5kM0aR/wtzcv1/QnLqdXPdEXk0libhOOgbpv2zMbwFt/kRqBo4jDNWYvG/fEl22?= =?utf-8?q?wOd+QavPz8pRNUdCjb51BZyeEwR/Bzc5BbHO3HvJKxhff0MUtKRYAQ+HvaPS7qMyF?= =?utf-8?q?170jqMd7ql5e8gjBc185n8MPGX3FcTrfIOS36+pTW7d0x9Gtwbk7mDtBswFxYPG0f?= =?utf-8?q?3cp7Fqgbk1LWhFK1heXEAl5cK6fuC9SdcuaQVe2upjaVVmQo0t7OCAyJwUl9rF6hv?= =?utf-8?q?MnZXMySk6dAJA9JE/LC1DvG5vtzEIxz4kF5OjGyeyDRvnM9DiCyGVjKbHoAJ4yheg?= =?utf-8?q?Wc5hAspn4tBO7R874GB814HhA1t9sRgzEWF/i/tchpDTndQlFntHFuerCSu/10jSa?= =?utf-8?q?FYrv/ZrULvb4qDxUO0DjTpAEMsceRXKK5jeiWbSZ6Ctgnb9w4Zi7QwEKMq8ZQ4+sA?= =?utf-8?q?1XsMPQKqCGg67yaDKLRVp4cqlzkz3PT+AB84bq29/eS8xVJ/PTLaOs2U4P1vLTkcg?= =?utf-8?q?hcZdXXqJ0yowv2tv/ZmPJW44+P57MldL5azYavOGt4BK9nRJ6nMb/ifUVjIkTlrL6?= =?utf-8?q?3umT8fQKHPWFX89jDbZQswLJKVr1azVZKQ5IiFzRj1+j/kDNZMP2rUI4InhmH7dho?= =?utf-8?q?Rg1YtnW95g8T6T01sEr2ZMY0Qr6mTzVc3+LOX92kvkdtAwaVU9in3cCQgOueebpHo?= =?utf-8?q?pMJoeSGS22aLxLqKD5zWCzUyJK0Ki2wPS0biUMB4lmNw9FzoyS5Qz+B+7g1WGa4cw?= =?utf-8?q?i7STbZJr65KFWI9gLeE7ZJZHkxlJC+QNwO1++zWHXnEjOR4Xlp5zzIopF8nH62ARN?= =?utf-8?q?xDPaw5gh01TqxrvShCfTjLyXeHVEinQ4lLai+Ey03V3vg0NiHsiV5dmVmmtr/CBJe?= =?utf-8?q?IAdV7l+HJH6MT2NvjE57uTgeCEQzgciPI5ND1IYFc7DddCjMr/edqXZlGd7JNAbnY?= =?utf-8?q?MX6ANhOhWCkZDyB+gvWa8RrOY+MlJqohFhPlJt/0eriRLlAAfpirOQoeacJiv4NRi?= =?utf-8?q?ZLkl1AtKeszOctGEesUWbba4scYfywrsLJx47M478mdc5d1l0y6Yre5iPI8k+QYCQ?= =?utf-8?q?ORHV55Tg/AcY9cCeRcFyOoJUGN7YjbQlpDpPXR+X4ZfVqYD8zfUdfl6DlrxvrPDp1?= =?utf-8?q?2VeMscm+twdPbYTnpXqDl5dc/m8n+0R/xJQquqRN/6ntu/StUuFGgyTx5XugbALlM?= =?utf-8?q?VAsrD7xjNdaKTBEFkx+TOGY6G4GyOc0EpZnMsoJQUP13jmL8+WYld2n+bGlHyfCXv?= =?utf-8?q?oNw4KlQoM0QP?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0e80cb9c-b862-4b0c-64cc-08ddb2523c3f X-MS-Exchange-CrossTenant-AuthSource: OS8PR06MB7663.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2025 12:34:02.5998 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lbzsrKOLQ8uuq6ZRIHANd1RjTAyOROAF7yjf70geoDSsMk5wOjKysFwM/WSV+rlNud4bbdzIEVZL6aruC1fetQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY0PR06MB5185 From: Yangtao Li The new devm_request_*irq_probe API prints an error message by default when the request fails, and consumers can provide custom error messages. Converting drivers to use this API has the following benefits: 1.More than 2,000 lines of code can be saved by removing redundant error messages in drivers. 2.Upper-layer functions can directly return error codes without missing debugging information. 3.Having proper and consistent information about why the device cannot be used is useful. Cc: Thomas Gleixner Cc: Krzysztof Kozlowski Cc: "Uwe Kleine-König" Cc: Jonathan Cameron Cc: AngeloGioacchino Del Regno Signed-off-by: Yangtao Li Signed-off-by: Pan Chuang --- drivers/thermal/broadcom/brcmstb_thermal.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/thermal/broadcom/brcmstb_thermal.c b/drivers/thermal/broadcom/brcmstb_thermal.c index f46f2ddc174e..c2648fd14267 100644 --- a/drivers/thermal/broadcom/brcmstb_thermal.c +++ b/drivers/thermal/broadcom/brcmstb_thermal.c @@ -353,13 +353,12 @@ static int brcmstb_thermal_probe(struct platform_device *pdev) irq = platform_get_irq_optional(pdev, 0); if (irq >= 0) { - ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, - brcmstb_tmon_irq_thread, - IRQF_ONESHOT, - DRV_NAME, priv); + ret = devm_request_threaded_irq_probe(&pdev->dev, irq, NULL, + brcmstb_tmon_irq_thread, + IRQF_ONESHOT, + DRV_NAME, priv, NULL); if (ret < 0) - return dev_err_probe(&pdev->dev, ret, - "could not request IRQ\n"); + return ret; } dev_info(&pdev->dev, "registered AVS TMON of-sensor driver\n"); From patchwork Mon Jun 23 12:35:35 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pan Chuang X-Patchwork-Id: 899638 Received: from SEYPR02CU001.outbound.protection.outlook.com (mail-koreacentralazon11013047.outbound.protection.outlook.com [40.107.44.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C6172475C8; Mon, 23 Jun 2025 12:35:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.44.47 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750682155; cv=fail; b=ujVnjhapvDNcDas9V7AdsONEh6rfifOKQ38SpRIxR61SWUeloulXq7cJ2S5WNYa9Or5s5/gbU2yW39kf+0NtYkoZZJUPihCNKs28h1ybIQIlAfwKRMrUzyMw56040LUfJITPKDo1guJ/J5tqnzh5BxAg1f/6tsqIA0yjRF8Md+0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750682155; c=relaxed/simple; bh=WI5R8Syk2gjkITfeeuBiP29RV5EyuMNPTvVRPOaAHW8=; h=From:To:Cc:Subject:Date:Message-Id:Content-Type:MIME-Version; b=NlOuCZUdchNut8liUh1EOO4DOoNP11+dXhxVRYi2RHqgfLwJdCDg0Im74lWsLPEBUHum5xVZeP/Nvconxxyr9ckNmGWte1rvYF8/HFgyF3QAOkoDRgDSXxRJzNM+1E/FGuTZHKI2/U5CsG9x7ELVsvc6X1t9c4PAL04wDVswOoI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=TazQ7n3Q; arc=fail smtp.client-ip=40.107.44.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="TazQ7n3Q" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=YkgLuywQ0g5lAhs+gE7QFQYzUk9gZTpu6N1olwgg7uJd74F0KWL08NTpeYDLH5vC/qg5D8GcwJ9ckZHd4VQP7y8gq8nXGTtC3/QmFJx1N5hLMFB3giIeVl9m54tLDvYdfx/hOD02EyI1Ua5NqX7NiJFD/TTHWTDejIlXzOCvTBGm2CLmJRH1mp0sETHlIBhN9So2P9fQGBuHq5ptcmT58maL75STGmLKtOYYC4DrPK7mVjjQ/LL3yPYxlhy85m6PICXbkwZpXRY86lqKeg0i5KRTcb/xbwhlXCOD2n4us3pQ1ozHCJObKrAra/yOlHZqwx84kwStZLPmbGch1qcOoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kbmJeH5i273iynv0vD4TdD2E7VSpTcg5MPtxKgWpqEk=; b=PVJagm5BY7Gzom8jaTEKuz0YyEHhSYRXkr8tRQR2YxHMGK4lnFch3LSrTJM1WapaOJhLaQ76VOMlj0O+l9n+smdaelpA3lUHqE/67vfWg5xiVvTy9mqcDtrR8Wt3Fnqfrt5Bwp1LmfXO3kXCiJFQ6y2tQqRB5ccVFkfQ7g6f3ZcVSEdafBNFnVBadVquQFk9gBX/yH7LKZ3dntVWpuIezwNAJQI1KE+uwIXNhxgKfl7RoJoA8QiKTdaAILlkp9MWLL1n742vvCOLlKpOUzN360gnNMBcIj+fTjsgz5tJewlbl2w9BnAm1OeH7nZB8mFGpP1o+khUHLTRFt2qtKvBjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kbmJeH5i273iynv0vD4TdD2E7VSpTcg5MPtxKgWpqEk=; b=TazQ7n3QoMQ14xnnVJfQScJfU6Q9KpTeWAWF7UwYIiQt1j4nfbhtjLStikiqbyND+kLEcHY/G/p5DLyo4hL3HVYeepZM13bOMlkPizYQEwOWVl6muKwnPKlOPrYgH231OTtUMSem2w70NI7EERLgIo8JuNOPPsqhqx1I49i7DQQc3YjEm5pI1V7JSdtmktk9lCp7/jHC4YTyf/wpMDoVeUtb7mwkLVUGp3CZIxmMLcXcAhAN5dtOgv2XE78X/TfNDyNdI0oXhHgxzQwKLNq1kKb97YskLE6d+IzUrGlNyopQJNdJ6XGbVDra9dZZ6DOA3xzRTfY5qA/FVtdIHo0QYw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from OS8PR06MB7663.apcprd06.prod.outlook.com (2603:1096:604:2ac::8) by TYUPR06MB6196.apcprd06.prod.outlook.com (2603:1096:400:35c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.28; Mon, 23 Jun 2025 12:35:50 +0000 Received: from OS8PR06MB7663.apcprd06.prod.outlook.com ([fe80::46a5:9b06:416e:1e49]) by OS8PR06MB7663.apcprd06.prod.outlook.com ([fe80::46a5:9b06:416e:1e49%3]) with mapi id 15.20.8857.026; Mon, 23 Jun 2025 12:35:50 +0000 From: Pan Chuang To: Amit Kucheria , Thara Gopinath , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Yangtao Li , Thomas Gleixner , Krzysztof Kozlowski , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Jonathan Cameron , AngeloGioacchino Del Regno , Dmitry Baryshkov , Pan Chuang Subject: [PATCH v6 06/24] thermal/drivers/qcom/lmh: convert to use devm_request*_irq_probe() Date: Mon, 23 Jun 2025 20:35:35 +0800 Message-Id: <20250623123535.473392-1-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 X-ClientProxiedBy: SI2PR01CA0020.apcprd01.prod.exchangelabs.com (2603:1096:4:192::6) To OS8PR06MB7663.apcprd06.prod.outlook.com (2603:1096:604:2ac::8) Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS8PR06MB7663:EE_|TYUPR06MB6196:EE_ X-MS-Office365-Filtering-Correlation-Id: 4f6f75d9-7ee8-47fe-e25d-08ddb2527c65 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|7416014|52116014|366016|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?lfKq/omhUb7wqIgAVYrt09oJgPHALy+?= =?utf-8?q?K/41ZSIMDQw9YJSq2ptE0qoBjUt4YV/T2+1q2jxzwyU6Ac8j17b+Hr7OFxBE6Q8HT?= =?utf-8?q?CSJyQpwS1wGbdQxl8+un2u1qCaCQV6j4DKVd6QTyHYwDCofeTKv/zkGa4oZS4PaeC?= =?utf-8?q?Hz9B83EIkqfDJX3O3R4cZyoFCYv/RdpVEIuwkit6mytgCHcSMvPc7ddV/JxmUEpXJ?= =?utf-8?q?L2oVuilJqSBVmuMntcUFqHUwjObuZS3N47UHlWvn79cGw6hKqdjsp+Woylk9IaWrg?= =?utf-8?q?eASLvS8U8tnTXuhi0W6uGOxUW4HJ5s7l2plXP3rQTbjoQrwo/ic1bPYwUwHxUD6iP?= =?utf-8?q?W3rB9syKiewxGb3tXUSLDq/sc42M3Lag9+D4ZIXyZT0F2hOd5sgkdTnc0GB7wQyjY?= =?utf-8?q?vpRbNli2/c/DScPJk7eDpZVhmdSs/kehOEA2QjzRXu4JFQk/gs+uwK1TIdiWTAbb/?= =?utf-8?q?fzXb5ezoijhfVIgwT0DVlA+itiVhEngU0QSdTwbzbScpNssD/fRDxPn6jXUR3pgzk?= =?utf-8?q?1ZT6uEi+zJ6PU8FHMVkQ0DfRICqKlo+oveIl0vhhR5d/YukeGZF98BE8167M71jz/?= =?utf-8?q?7CZwOqUEvmu44Yztjedux99HLFyb/XpWIgmlhfvp0OUQa5x8nnSJnaTlAYK7XPngf?= =?utf-8?q?ADj1lG+xLUIbFYE3eEz5/b+3E4C+4x18BsrKkG//5GQ6FCXAeoWBpKZjGenqjnIcM?= =?utf-8?q?SnEfCFSVcaCTLtsqaeNPrMx7UASPoYjroQ5e/P2+oEJEeIlZFJFcmFkOpBFlvZzP8?= =?utf-8?q?M59juwAbAIKU6GQyafYcCfQI7imZKxzrv3O0vw7SCKzqHDXCkdau2nIBemu3X/bWu?= =?utf-8?q?fdLSlYXnXfEo8fgQpXBAtZHVcIe3OH7QBfvoB67qkyRqJwH/HBzxlv0EKu+9Ou9Kx?= =?utf-8?q?xu+c+npQzgNkOLPZPMhVxHfUzxHpBzMrAbGMtM2nPidJG2yfolLfA/PKVpROOLECh?= =?utf-8?q?EHPlyo2QuPt4y2M0TFK8J0PNw+RQuD5bhKdnAQuQKOloZiw5oEfZXYx71cJr1QK2V?= =?utf-8?q?Ct5mvfiXG4otrFe6EIa6J3OBkV2mhAnCWFMYGacktTjbLeL+Zfjry3rgx4k6E/zfq?= =?utf-8?q?/hRoxy4op2LkuXmFi9d1tx4o7MnbZDTfrrWY9AeACxd6OEw844L5ApS8w+2aKdQD1?= =?utf-8?q?ZKNU9vhFZwiRWW2veACNJ5KgeA7C3hNK7c+udiguVUaoxUm9L3A+CGQai5GY9S/wC?= =?utf-8?q?BVrP9q4Tn2GCshwbazmHPsZcs9Zkqthz/EcJmt5du8jOlrcSIhqWbn7cq8MBiH4po?= =?utf-8?q?uMqvNxENOmts0Gh9s9W80uwB4DQ4sBG2Dc6r6Rbq2qP+hRUTXEEp2WYWJILRJ7WFj?= =?utf-8?q?vI1a823AUhevdLwXpVfT6XIa/9rnltARQw5tpgTX0QjfcfA4lLah1SJh3mRn33cZf?= =?utf-8?q?zwPHOLOolwy+zutprzXTaBH+GNr8bVYaA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:OS8PR06MB7663.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(7416014)(52116014)(366016)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?JaYTZrzslJu5NkoKo3UuID6gjCfq?= =?utf-8?q?NTqoYiFDCbjSX5c3OQgIn9NhAAJ4LCYcbEe2dbZhB34bWMrTGODODLxA3IMeoQIR8?= =?utf-8?q?foX66bNHSINJwYAxncRyhIU3xSmG9TsmmzyhCSZY0sBW7ot+gYNB6yA592yt0JHic?= =?utf-8?q?vfHqRHZKENpAAmI1/SBHb4C2rsIziZQDlZrCxD+em2B0YDYis2j94r5B0lRUr5jEr?= =?utf-8?q?V1c8jMpqmeoJWl2G7+CSQBT/LznY8GooHro9tDFkxuyoUOU+eouwjcLmwh1UDOPq5?= =?utf-8?q?MmwOQhw2RLw0jtnIjV/J19CizlQqLaNc8YW7lG1ngwC5/J6FrL8DH5rgM+w5nAR5e?= =?utf-8?q?oRLfbdLdUo+rxeUsPzqR0EWQQrb7PI2DhZKkWW2jX6fWwbuzRXJvkcDdzwCF0ASLz?= =?utf-8?q?CoLMp7l4TMr5vL8lAIugSGtrLpL19WBm7vFAYGS1jdbZe9zORThJGYtOXv0s3phS3?= =?utf-8?q?OqVWuedjbLAOkbu3rD/01T3Cscjz69b6EyUOteQ2l6f2Qijn22YDVSIZEFXiSSd1m?= =?utf-8?q?7lH4uqvaNT9m61k67JmpKiUVXkYdj7tD/w1lSTejpJv1+DrURaq/xFSAiqU1LbVTp?= =?utf-8?q?sy0QNeoQnVkAJBfi2YK9YHSd8ZbO0fzb4zKRZ+FJ3ffaeGUoMEmMdB4x+mvpUgPNF?= =?utf-8?q?LLnmEQIzGHLYBmZw4A7N2gBVDlCWLdShMgbILm8Z87HNND1Z03/UztM2yN+meIYLJ?= =?utf-8?q?8PLPU+wg6prupc9NL6vwizRNol0HBxHHZf+o3fGfY4B1z2w7W2bHbxYRDiFz9iJc9?= =?utf-8?q?z/CoNEmZ4Wy0+jWDXBluxHkL716QPngQXqbdbAg5/l9sTvRMqP2TwMz6JHP059IDc?= =?utf-8?q?mJyk8bFuEA1ywLJ4pyBtAVltAjAPDDXo9pFjL+eMcGPmDd2MCde5NYIyXAd/JEZpP?= =?utf-8?q?tQp8iO52hWoTnPDS2dlywLWZDzxPJSQ8ZWTurpDeGEFLe6FWu29r9L8zoFDKFFWoi?= =?utf-8?q?uU+7WwZFAFcer0HUsMpdsknQKlMlrMGY1jF83MjJ5eN0B8VB+0stZK6QwKRiryHxy?= =?utf-8?q?8qgJ6wJH23KopwWj/T4E+5gLKi0GJalSwYfO1azi+5q4PUhFmCXAoabrb594kGhkr?= =?utf-8?q?ugj/QSmVeogI9W6+9eLdiVs11B+XQh/ETzWyfF8UQ7qfrsLYzSzYrcXAID4ZGmHwo?= =?utf-8?q?PMY0DjwX1PhsufF7CUzmaKix5QSWq2kknkhspSx/H92Cm3lA4EpP9qhUUmzub6JG3?= =?utf-8?q?17PFWtUkPiMYfElXUxM14POWLFixEk2wN7ZN40XkeqxStsAG7q4+MiFeX+H/kygQC?= =?utf-8?q?nxAd4+RbgkCiVOIy9uwO049jmFIRxVRCIDD4JyTk1aODe7IYmr/WjkZSjjhgnKNrf?= =?utf-8?q?X06izHUS4daK1wLxar9MxCf/7ckgMhrxaP4jQcNunYPQDw+j8P/o/oQRZfN3XQRDd?= =?utf-8?q?7jVJrJsbg79GdxWa5W3illdUvudL+pPvM/jeewIAluAL1H8Zb+yiJ58SkRCn5dETs?= =?utf-8?q?6n8GJFRql/MK45TbsINhwc5OHIKGuzW7eMWgXS+0jg6CbecBxyCauEdm5d9GvtVVl?= =?utf-8?q?8caGOQYkDYVy?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4f6f75d9-7ee8-47fe-e25d-08ddb2527c65 X-MS-Exchange-CrossTenant-AuthSource: OS8PR06MB7663.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2025 12:35:50.3007 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: K8sbiiyhKukh6SbTxKHtW9j6HrTnd9154IR5cw8R9fF0g2WaL7LWgkdTTnnDpDqO88/QVj/5eoWnjT45bYaK9A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYUPR06MB6196 From: Yangtao Li The new devm_request_*irq_probe API prints an error message by default when the request fails, and consumers can provide custom error messages. Converting drivers to use this API has the following benefits: 1.More than 2,000 lines of code can be saved by removing redundant error messages in drivers. 2.Upper-layer functions can directly return error codes without missing debugging information. 3.Having proper and consistent information about why the device cannot be used is useful. Cc: Thomas Gleixner Cc: Krzysztof Kozlowski Cc: "Uwe Kleine-König" Cc: Jonathan Cameron Cc: AngeloGioacchino Del Regno Signed-off-by: Yangtao Li Reviewed-by: Dmitry Baryshkov Signed-off-by: Pan Chuang --- drivers/thermal/qcom/lmh.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/thermal/qcom/lmh.c b/drivers/thermal/qcom/lmh.c index 991d1573983d..2d7751e31a7e 100644 --- a/drivers/thermal/qcom/lmh.c +++ b/drivers/thermal/qcom/lmh.c @@ -218,11 +218,10 @@ static int lmh_probe(struct platform_device *pdev) /* Disable the irq and let cpufreq enable it when ready to handle the interrupt */ irq_set_status_flags(lmh_data->irq, IRQ_NOAUTOEN); - ret = devm_request_irq(dev, lmh_data->irq, lmh_handle_irq, - IRQF_ONESHOT | IRQF_NO_SUSPEND, - "lmh-irq", lmh_data); + ret = devm_request_irq_probe(dev, lmh_data->irq, lmh_handle_irq, + IRQF_ONESHOT | IRQF_NO_SUSPEND, + "lmh-irq", lmh_data, NULL); if (ret) { - dev_err(dev, "Error %d registering irq %x\n", ret, lmh_data->irq); irq_domain_remove(lmh_data->domain); return ret; } From patchwork Mon Jun 23 12:36:27 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pan Chuang X-Patchwork-Id: 899637 Received: from OS8PR02CU002.outbound.protection.outlook.com (mail-japanwestazon11012043.outbound.protection.outlook.com [40.107.75.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BF2613C9D4; Mon, 23 Jun 2025 12:37:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.75.43 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750682234; cv=fail; b=HYlYC+FVu8DfXImn2GSIVRyNX1nAp2S0MRRU78oIMSHsOwJrIgq0R4N7/bzSlKJl/nLkaRaSCZbvjOar8d7R52sqoSEZTM0SMfmup6DMPBaRcKCcUFBMlJ0O6qNsTOD7cfO4Pwe/gKxu90ZjDE/QkR972fQlt6ceWUPXkqTarVk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750682234; c=relaxed/simple; bh=wU4yGuHecdRil7Go1Kci+NaFPbtnYjHgVKucw0O2nC8=; h=From:To:Cc:Subject:Date:Message-Id:Content-Type:MIME-Version; b=AKMhBniKGw3cV9cQlgxofm1aShvtrHRRJMB0VJ2SHOF8APCV7sphZzEu7Wlh4dSV/RVg0Rx7goIxhWx2ndRqHC7zNzuaVvcyMYv1JPXA6StWtZEq95R9T3r8O3O1l590YqOoK68PiLm0ffzxwB3rNUgqyhLBNALaAv8Oklalbg4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=ee4OXkf9; arc=fail smtp.client-ip=40.107.75.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="ee4OXkf9" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qD0aaEvO666D0goqxSQsI/7xyWTuMxtL2AFDjH+D7Xzus8XpsYgtWBP4MoXm13+ye033hc41A1FyaB1BvaQF497bWB6xBhwlxekU0tt0jggQQ6ZW0Ymk5C52F8JbTccTUOvfbB4zsAO5q9QNEkMT0OgjzVoqvmvOOrDwX4H5MONOLLzAtiKKcYezzVybrZ2lisvBkmUTfCPbvaSevtCosplKct+4Y+aoBaRrCHajteY7QoiGrq48ogbdh+BxCNGMdsOc06irdoA4+QV6gO1zkCRWd01ecOXrN/DmQap/RXGn8HWjy1CJWKADWBaIOGIqPgHl7S/0MpcF/jDUB32bOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=btLHxzjwkqaJdTaAPpeWOJKLa/Oe6y4ZXomp35AzxCk=; b=hMSCc4wpaxG6gO3m0Wx+7eIs8SltFuxFrBH4p4Q9W4GC4A4iSECuIwfhQqXaaX5JaIeAEgo1yp0JWG3F0LGSiZf2R5cJNVLhnp9G6vvAVqZNtsmfC3NJPHA14ghB4Lw6Xqdz4DVGOho3+I3NNu+CF0MWMCth2IVX5SSVNsMQMS71A6Oi8mQI0XVNKpPzHp6jLN4y/hQ2CTrORpFz4w3xVkU+Dt+wm+M+B5d+D5JoAPsAQsZrbHKIIwgb8f/XvRhpVzngYmPszdBMlKo6gnrAkD6/S2WQNuc30Q2uWvsZh4CTdIwau33HSRjhRWxn6naRs7SdXANmgFOLnknVExOdnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=btLHxzjwkqaJdTaAPpeWOJKLa/Oe6y4ZXomp35AzxCk=; b=ee4OXkf9t1D3nnOs8RwDXs0MAFMFrAQl5XA12vP5ZQUfxktEoWHXJHjZrhO7W5IIw3gC5kdhn3aNbSXUcfniYMHTey3ATdZ0Sfz2QNbLITMBFaeMAyNo2SRNpuakxVfDR3UM4EiZwDWEk+C7wHLKWeFdz1KZ2ayfIpcGZpJDamKCwsHhPsIg6bA4+FXz9q3S4qh9vIsSlxGyHlHZEXA3iuFIWork1JHsClNYVSgIpHFt/XmZGgG8wCGuwa7ytdStYCpsEkDTJGKe1QaRX2xWoaSvbxNpKQKeu4xvcZG5sb0JjjN+7yMF+frSvj8o081siO+ErwCCa4uTaKY2mf5azg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from OS8PR06MB7663.apcprd06.prod.outlook.com (2603:1096:604:2ac::8) by TYUPR06MB6196.apcprd06.prod.outlook.com (2603:1096:400:35c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.28; Mon, 23 Jun 2025 12:37:09 +0000 Received: from OS8PR06MB7663.apcprd06.prod.outlook.com ([fe80::46a5:9b06:416e:1e49]) by OS8PR06MB7663.apcprd06.prod.outlook.com ([fe80::46a5:9b06:416e:1e49%3]) with mapi id 15.20.8857.026; Mon, 23 Jun 2025 12:37:09 +0000 From: Pan Chuang To: =?utf-8?q?Niklas_S=C3=B6derlund?= , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Geert Uytterhoeven , Magnus Damm , linux-renesas-soc@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Yangtao Li , Thomas Gleixner , Krzysztof Kozlowski , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Jonathan Cameron , AngeloGioacchino Del Regno , Pan Chuang Subject: [PATCH v6 08/24] thermal/drivers/renesas/rcar: convert to use devm_request*_irq_probe() Date: Mon, 23 Jun 2025 20:36:27 +0800 Message-Id: <20250623123627.473612-1-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 X-ClientProxiedBy: SG2PR03CA0110.apcprd03.prod.outlook.com (2603:1096:4:91::14) To OS8PR06MB7663.apcprd06.prod.outlook.com (2603:1096:604:2ac::8) Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS8PR06MB7663:EE_|TYUPR06MB6196:EE_ X-MS-Office365-Filtering-Correlation-Id: bec5c918-876b-4988-5c5c-08ddb252abb5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|7416014|52116014|366016|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?ct0znz4aBHKmd5pLqzxw9CFt5gc1p14?= =?utf-8?q?/Bti0xjxiLbBPsKRdeaSpiNFVi7BEmX3eHL3MxvDO8s3WK//TzYghwjQt4p/Qfl7P?= =?utf-8?q?7y73TNnQ3/JmpF/DPTl/O3egVgzjJffslZ1kfkTnJZymJ4Giu8yRBSpDZbKRojgV8?= =?utf-8?q?8FKTdDCn9AWE1y+sAGmJnH+BcGqAIKY+AuGcHiWMwngSPXLLPf2lJwf/cPqpIqrLs?= =?utf-8?q?f6tzCoO1dFPoaRB2cpjKWl01gQWmOhPTkoxisDSgtpe0Q/JqlwcURnqcepQQrX5LL?= =?utf-8?q?f2Al+NsOnoYBGh5PkCgmqr1P8xUQ2VnjtbtTrmvkX5L3HAXjNafR9GDiMmTW67Hzv?= =?utf-8?q?z8ng+6FUQid63xE8UB73hmbO1nUiy5SZVLxt4jsgLKnGQsOP0MhDeohK364JZweut?= =?utf-8?q?ML/8vFqkWZDFRgq9vTGuNNiJlMGR3QtvTxOuXCBaFkMTG3Rta5Yoq2oK83v/cCeQS?= =?utf-8?q?kTgw9706V3sptSbZrFGv5opNRfefRD/8xlXq0cMAOZ9TKRfgozZfgK3G2Cu0+MCIn?= =?utf-8?q?GErHhuGuGKsuPKYLu9AyUSvYbZuJQwr8pDO7WPQyZbj2BfX+PlPtV7FGUe2Ea6tM1?= =?utf-8?q?e0Ey+8FG3yRC0vB7VtlSTZ5J0JZueMh9IRGm7G2y7fZGSc72f4UmW92MpjKgowPST?= =?utf-8?q?qbHla6CZUNefhwFJhQvnat6dSYEqzhc2BGLP2Bn4Q6PBRzMjKN/Zc/KgsBaeu5yne?= =?utf-8?q?22l8zOB78yoUEXUM7rXq9vZcR2RBs92qoaV5RxKUYTGAbxi6ytRgleHRuqpDHYDxz?= =?utf-8?q?d5JackIDW1YdFdZE0kq5IJGh+ZTCpznfGaNeNhcQj7OLA/Xstqus6cLrtbSRIN/Sp?= =?utf-8?q?y1rRX7X3McgBeX6gXCD99ch9Uy6ugtiOuub1G6u+Can+gNWHllBYMDnuksiHqZsUH?= =?utf-8?q?AjxMjl85XELYpe8y4keYVchJONGa2ScNOn3HSn/+CFtt2QI46zQGs/oyoWexx+kdb?= =?utf-8?q?u+2bbjP0QAUi7FhFE7JteUngH2dPYOi9dlz6YMiHGZAAR3CaB6fPW0FJt+gy+tp0R?= =?utf-8?q?XdTwR+1vFYDqs3qhbBNyFJRLfONdQhmaeVUwhp8dXYpjUeZ2T16URTFYMzFLOR0C9?= =?utf-8?q?A6u8hxJ62DjNqboHYTF2HyhBIm7cdW/fbK1kWGJH2Aw7vpiGqrIob5Cj9DNTYeZJ9?= =?utf-8?q?JJ29DAvV6E1P2Bu/23Wemx4gTJUjY1ywBg0R+XnRQxU3qWKPLj8E8MzIrqy88Pzak?= =?utf-8?q?6IEorP9gdDNAgAWaf3rzYNTNejRKgBvoZwlwqAS/6BYyF+qY+nK6KI7LHbgYx+IG7?= =?utf-8?q?RnFvyws1c9LmRP96d05HIE0p55+JXFvpbvbMmpUTQWpcLKR6emJp87gLUJH7Q3R9M?= =?utf-8?q?YOSKFcwJbkKaeiEfPkJKXHAEZItjhMmkyU9zs9IZcrjaJYHbbaMM6CwAqup3uDccA?= =?utf-8?q?r9wS3fMDWhuYWDNo8nLSSbA51w+amFRVG+qUjWasQWnR3fy8zrY4T0=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:OS8PR06MB7663.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(7416014)(52116014)(366016)(921020)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?M4Vfg/Vl0f1pryv6rOzC17FHSxZx?= =?utf-8?q?o+PFRm8zPq9DZYbEhfKeQFkrpb3kwSVWfaKiqJnB/bafGUO4VKsjW+/CkRiq9p0q/?= =?utf-8?q?HdE5WH89/2IF3xr85Jfr/MBgfmSUU11TdtwaF613RtDjF/7M3UyYN+sDHWtB94xX8?= =?utf-8?q?M9V15hacaYQcAyQjdzeqs5YLoz2JYktpJfrR+Wc1P7zDarSEyHIFLfpf4ycwAatLm?= =?utf-8?q?y4lD7zz7REhalK/DTkkqYfOgACTWZsdcV9QPqGAh92sKiZMvqb/vuqPBAksugxrSg?= =?utf-8?q?ynwEXlRp7iwHvBnS3tiEExq30lNEj60LaDc1N/cYsi66y62qvjETnYbLZja9BNdtS?= =?utf-8?q?N5OHqO+2HX3SoUA6dgeaFM2hbU8hPk3mTDgnbbT2lckipbeCPEXZkxvHJ6xAcM3St?= =?utf-8?q?6nnzuBpMhZLKcAO/q09i+oKuVMgs+IvJUyYlCY2y8AZ2N1FDusdgaiavCg6oH9PCr?= =?utf-8?q?FSCJ6Dt6HkYPcuMn9YO5YGxZv+mbj36e47LNlQizZEUBDEd14rt2IKUvGyaWBWw9/?= =?utf-8?q?bLEuD7WDkaimDNAh6FOY5BzgpYkelDd90DoiATxFmK0kqUnGbwcueMHjc5RYzgIKI?= =?utf-8?q?2Pq1TjX6bXuzVwkK/SOG7ZXQTj+xJELCM/IYvelNPQJYUUM79CaHE06/XIQ7FiW41?= =?utf-8?q?YF5k0A7zIz4/wUBnjaB9x9I7EIdm2FGEVKwE8uf8KYlyKZe+e/wEmdVa6djO03l8j?= =?utf-8?q?zhdZP3HXZhZ9cFK+ffHBR6bMkSfnYD5WxIoq9iTH53dWZybLHyq5k5s3LtUi9C7vE?= =?utf-8?q?Z6hC8PHb5ruPJWvPyZw6UFZAKPf6ePLsH12XFRNxAjgVyM3ukJ0u09wSbL/6auZwV?= =?utf-8?q?X3Ra16Y4USFCgPhLHtqsUF3zRubCrfenvLRCKkMAC03uhBzoJ35jQ1Y9xIoptK/3x?= =?utf-8?q?etKRwvh1ZOHqQ5HgyNqsuMQPgS3oMvEeABcRC4Kjo0Dm5P+fr/1Jb3SsUnamTtJwb?= =?utf-8?q?KQ/yOPChpgm4IAmiO3u79IRncGtE6IH7qByzvsyCscaVu9zkRQ3yLP/RRQUPB/eGP?= =?utf-8?q?YN9InDF/M0exSVdNm/SfybT5C1BGrRW1Demg85pQUHtvS/rwV/B9ms/clh0JLAb2m?= =?utf-8?q?f+qRvUy2/7hBW/GFTOZvqRwZ3w9ly+baw1HLSFzg7ZU1Gm7/0nNIK3OXSCvY1BLyY?= =?utf-8?q?HRfvyy3tT3n3N3BzlvcTO+7T2aVs5jjsydMyqAIHDjnD4az9cJevgyF8L4J5xNAJG?= =?utf-8?q?92ZBbz4wS7vszPFqhlyc8GQui8hdM2lrxoVr7NYX7GYpKBaLHubC4VTAwx5pqIZHR?= =?utf-8?q?7FNFTXoO7mo4hY7uiKCNfaSCzKwzyZUzAdzdf37Yn+KadJlFbjazD8aY8a8k5VnCX?= =?utf-8?q?htNy0ocYzg7CYrh8tQsnA3CVoyeV+BR/SxGtWWESdfu0Rt2IzE6L6NMD7BQrUpo0Z?= =?utf-8?q?TJmN8kc8P8TZ3y/u/5v8xJS/3Lt5sDJs0zhh1Jkd1TY34ObVuoHe5zI161tC4Fscr?= =?utf-8?q?654ItVX6tz1//SXB2yX+kQQl1NhTskXkxcvn/+aPq1BOfHWlOTw3MfKgNSe/uuSjv?= =?utf-8?q?Hffl66ioWHQK?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: bec5c918-876b-4988-5c5c-08ddb252abb5 X-MS-Exchange-CrossTenant-AuthSource: OS8PR06MB7663.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2025 12:37:09.6329 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: coxkRM5NMUP0QgIzrY7yGnAefbhexWpCIHLyTJV/F3BTScXvqwuqgP2ZJTn9Eb5i0sDWE5Hu6WP00KtqY3Yrog== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYUPR06MB6196 From: Yangtao Li The new devm_request_*irq_probe API prints an error message by default when the request fails, and consumers can provide custom error messages. Converting drivers to use this API has the following benefits: 1.More than 2,000 lines of code can be saved by removing redundant error messages in drivers. 2.Upper-layer functions can directly return error codes without missing debugging information. 3.Having proper and consistent information about why the device cannot be used is useful. Cc: Thomas Gleixner Cc: Krzysztof Kozlowski Cc: "Uwe Kleine-König" Cc: Jonathan Cameron Cc: AngeloGioacchino Del Regno Signed-off-by: Yangtao Li Reviewed-by: Geert Uytterhoeven Signed-off-by: Pan Chuang --- drivers/thermal/renesas/rcar_thermal.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/thermal/renesas/rcar_thermal.c b/drivers/thermal/renesas/rcar_thermal.c index 00a66ee0a5b0..30cfac39fc4d 100644 --- a/drivers/thermal/renesas/rcar_thermal.c +++ b/drivers/thermal/renesas/rcar_thermal.c @@ -444,12 +444,11 @@ static int rcar_thermal_probe(struct platform_device *pdev) idle = 0; /* polling delay is not needed */ } - ret = devm_request_irq(dev, irq, rcar_thermal_irq, - IRQF_SHARED, dev_name(dev), common); - if (ret) { - dev_err(dev, "irq request failed\n"); + ret = devm_request_irq_probe(dev, irq, rcar_thermal_irq, + IRQF_SHARED, dev_name(dev), + common, NULL); + if (ret) goto error_unregister; - } /* update ENR bits */ if (chip->irq_per_ch) From patchwork Mon Jun 23 12:37:40 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pan Chuang X-Patchwork-Id: 899636 Received: from TYDPR03CU002.outbound.protection.outlook.com (mail-japaneastazon11013011.outbound.protection.outlook.com [52.101.127.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 678AC2BB1D; Mon, 23 Jun 2025 12:37:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.127.11 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750682279; cv=fail; b=hiMXELtTkrKSjdjCt0Dd5E6ndvq1XKmG2jwwqRvsjSrccdfMlwCgRJMHtNKUXEfOaCnpPl9TO+GZz8+Ss06e/Gs+kAcbAoytybIUV7yMT+omw08PBtJOEH9iGZdBjHopbTQkwtonArycVR1wB2W6gJ0Ns2kUI9a5OoZBhXre/2o= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750682279; c=relaxed/simple; bh=LOJIsiN8kkgSPG+DkApz/QiPf6srtRDeXuzDeZVZwgg=; h=From:To:Cc:Subject:Date:Message-Id:Content-Type:MIME-Version; b=RtQcGrBTI1vBm4wCPmwNL1KRLCpORrQN810gC44JRyJezE5XjbpENLzqHskXi6o7XSu/w+e9NVWrgsNH6JYfTPYW8d2WWWQYRg+l74xioJd/sHoc1zJQy2V9T1LrFKmP9Z/WdtIjtYCFYwy1yDbx0U8H4gp96zk99Ptjg8AeNSA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=qT3Fyh8f; arc=fail smtp.client-ip=52.101.127.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="qT3Fyh8f" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fYK0oLMtdPyilK1cv5luaJthLoRSsuMYGWFKQB4JyNhLttoxHm5Ev0/R1Km4pQDcVlSDFGiTZoRja1eurNUJWoEBxw039FJWpvvZuRx7Nyc7MbmDrPcfPLm6Ofm+/ly/vLbS4gpvIeuVk7kMs8FCUzJzkKoaCFPMDSlJDv0cI8OW2sKn1W73SDglkTfd/+UlPB9UNAJUPGhd/MAYR9+VXfCahza3bEbuhFGhlVlviJjY5GSzzFYx8IbfSZGDH453+UIUI2Y6r2S6a5kDTfPx0qVka3Akkv1TetkFQ4KjPHhCL1s8DLk4ebIQl0ckDfYE2tH/nwQNaQfjJ3KkcUV7ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RwfaVNjtYPVSS48geUPzHt0Vys8CeoMwiRwWDUiwVhk=; b=MvMi8E7P2E2fCA0ozaNIH6pyJld4kA7R3stfk6PXGyOXklrbI8r1geHaU5i01euMZUXRGVkE3bjo98dyMov31jO45R4qrAqBb27gqrdMFfXmGEBqgqBfAAoWCNEQR93LTXGq2++zgjgqNTO3ZUbybDHlMxckbiixq4JYdVioe7+c7LBVGcfvGY8cO9FrhVV50w3ELzFXhPsnlJL5U++6uycOD1OfdrJRNAnUKGatMUO7EgA1JuRk62t+/WBGVuYFRajgqvTlQPHpGM/UvW3yfl6eErRqpUy130X/FrK+jWyQ4Syu5oPEOD+QoR1En4ywm/5g+GQsmGNC42T6GY9XCQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RwfaVNjtYPVSS48geUPzHt0Vys8CeoMwiRwWDUiwVhk=; b=qT3Fyh8f6wx/ONpqvmxAv9YQeuuqViBIyu5XarWJYDpF/VKBMUm3QRjrFrVxV0zGRHBSAk7CorXjjoezr1CZSBfyCk418e0ikLRhwzsuy/mo1DzISeL0VAl73m2Pqj/Qmdogouf1acatRP6KcPPi1YfkMpgQiUZYEHDKp/V13dc4sr9ZxbWjpu0ZOQP2pns09kNtNKBwmiLdJyO694TgE3oBexL5naxpWpXeTf5moOOmw1D3BsiJ0hy6dC5Z/djeqIX+lwLAkyP0vZyOjVn763rKhCyRoWWcSKHwwvXDfFjZiqRQLLd6USAqlA9IoW9C6vCBq+5QiCt+Ef5agbaoaw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from OS8PR06MB7663.apcprd06.prod.outlook.com (2603:1096:604:2ac::8) by TYUPR06MB6196.apcprd06.prod.outlook.com (2603:1096:400:35c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.28; Mon, 23 Jun 2025 12:37:54 +0000 Received: from OS8PR06MB7663.apcprd06.prod.outlook.com ([fe80::46a5:9b06:416e:1e49]) by OS8PR06MB7663.apcprd06.prod.outlook.com ([fe80::46a5:9b06:416e:1e49%3]) with mapi id 15.20.8857.026; Mon, 23 Jun 2025 12:37:54 +0000 From: Pan Chuang To: "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Srinivas Pandruvada , Peter Zijlstra , Greg KH , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Yangtao Li , Thomas Gleixner , Krzysztof Kozlowski , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Jonathan Cameron , AngeloGioacchino Del Regno , Pan Chuang Subject: [PATCH v6 10/24] thermal: intel: int340x: processor_thermal: convert to use devm_request*_irq_probe() Date: Mon, 23 Jun 2025 20:37:40 +0800 Message-Id: <20250623123743.473677-1-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 X-ClientProxiedBy: TYCPR01CA0087.jpnprd01.prod.outlook.com (2603:1096:405:3::27) To OS8PR06MB7663.apcprd06.prod.outlook.com (2603:1096:604:2ac::8) Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS8PR06MB7663:EE_|TYUPR06MB6196:EE_ X-MS-Office365-Filtering-Correlation-Id: 02a6db28-bd3f-4210-3083-08ddb252c671 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|7416014|52116014|366016|7053199007|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?AgpVO8uEbx0/8GSmQzAZcGpBzUc/O3I?= =?utf-8?q?DsquvkN8P2/JMKwMv2X2Ntl6I86y+vwWOx2hmZX0upMSJ32FZGDus3F/wlXBqEmR6?= =?utf-8?q?JL5Vk05IpRMboTWkdXVaMcsoNUTKkFdxHkqh5TK0oI+5tiwf4ALg9dD2g8oTFe9DG?= =?utf-8?q?bfUaFXNPc/Mp9U+SpssYXTwjf0V3LFBtusiicPJiMuzSHCITebcVmTexbcHNPX0KR?= =?utf-8?q?xBmucLFX02kvav2lNrYKW1pnrAATkW+qGRI7koDZACYlEX7jflcdeuN44561wKajn?= =?utf-8?q?JC8dz6quk+DgwMwEQB7lI7ZD271OA4aP9Wb6LlRoKZeBn0mduvN8+7euxvwQQlr71?= =?utf-8?q?gWw5pz9eKsVio2QacvcCyZEJ4gXRY1uFHiIJ2QeeM5VqpMtxcqgDuSTc3el0YT4UN?= =?utf-8?q?xNiZImKsK76pDZlDIgFPISjuLzv1YAMZEWl0GPamQizgUse9reNFczpWmj6V8l8kA?= =?utf-8?q?razocN4FvdS9HCfGnB0gaDtvOd68kzO293154pYxtYJLlLyarxm4N7q6Yi1lw56JB?= =?utf-8?q?mB68AGl2PZu9p0Np4ycKgogEYGYfvFFhuGT5By1xpFpXDDWywHOERjo4eQZoYBvIa?= =?utf-8?q?yMopqqMkp0x/ifVpxsmfBZKWX4dtlm6+AmVi+7U4qgrZ+V0ujclpPFwQVsmbqAmkY?= =?utf-8?q?Il15F63BfJRGrMmHw833tc5r6YU/Ej17vzKQdVSNbS8+ByWQBVRNC5E8nqeK9fn+W?= =?utf-8?q?AbaAYNaEfIuytn6oQ68RHLjpCFDkt30EbU+3PCSPK1PeywNWXjKcCb3iLJF2oSl/i?= =?utf-8?q?egwpIKlJc12oE+X/XLUAyb9Z+b6p9UjYZpDz4VAKkmSCXDLfSU4ddD4Hgyyj6mshd?= =?utf-8?q?eFdb2mZ9Yq6b4z2rAW9gIgPhrdbWK9l4lnOYWeov3FIjeS9brKf/jMqxE8rxvhD5+?= =?utf-8?q?RbY0mGZTVZHHk3owWRZmVh8e0l3SX88+zHqYBLosvv9lUJwszW73xD0W1HDyTF+1C?= =?utf-8?q?1Dubr+cNY5HsjfFgvoe7M/2y1uewc0pQbF6JonJTlJ+m72ad9rXBR1AfJWAEN2R/7?= =?utf-8?q?2yOiwdJo55zL1h37lOUAk86H2UTpZCKKhW9Dkewoj9Lh0YeEzB8tPxLK0aBUq2krt?= =?utf-8?q?Xjodgdsnatxs0ZpwFPwhTvl+9MvQ92ebTg2XGTtG75K2N2t+me9TjniNZXcjHp0cR?= =?utf-8?q?gzAaj8biJVp0VrAY2O2wubXiQNNMCGKv96/js6zw03VOgwqkI5DmhlajW4gY6rYH2?= =?utf-8?q?CPe0jrx7pUUG70ML2YFoJ8QhsfICqRQ0IvAvVUPjKC3xYnDGBE3NjpQqnVu4+RKKe?= =?utf-8?q?Ya2F+B7oFMkb8+EsGsbQOpekAEjGWASglEVYV+i+qg4LkLsxyPC5D+IIkgwuAKkM1?= =?utf-8?q?gruT58QspbnE78rt/ETkBZlailFn1d839tMcFASwIABp7OIIQYUn/s3PmKJlc0NBC?= =?utf-8?q?9ytH1wtKtQPVHMAwCbejDx+3DlHvyq14w=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:OS8PR06MB7663.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(7416014)(52116014)(366016)(7053199007)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?ckf08Q9+nPlWWi5zn+9MNDLA7Avp?= =?utf-8?q?W7EMaFJrrSGZYIUp+pPWJpymPn0wzZQjd1FEk6wuo/8SILBJiP60c1DsqI7u1Zdkn?= =?utf-8?q?ZZumcJpYhz0ctkJCO9XUrRNgkhII85OAgebGx5lZqObo0JJCDBYuxE++aD7YiF3vg?= =?utf-8?q?emdacShdy3y1BADSEIF820gbR3vKL0QaTdbvRm39Uzwc5jUBQ3gN71w6+koSsqbCL?= =?utf-8?q?IqJxH77msmUXwjzIvf7fMYsH1I3h1Lw/HLwzRqmPgoWqL9UDs50fXsXiupeY13jLS?= =?utf-8?q?IkPKuGHAtFv2jbZIpuoqdAWhl+2Ly9PzsD9QBQmnltRGcOcGBGjC09oiZVeKQk5dR?= =?utf-8?q?VdMAKQBjjzi6gw3CiT0x1sJ6Sq2tGmmaAfpOCyq8+xq3tMTYI1jMIOv5pvCh50RzR?= =?utf-8?q?qPvv3OGRZ13NjfzRi5/0v4QQYyHNI7mQBFUnQ4xWCZdswtKKZjvSnuQYV1oUgEZVE?= =?utf-8?q?Sa3DTiPXoURn5/KdKI3mkCAK+mA+ZY9tryA97iAnTojSZlVxS337WsIAcDpByuF6o?= =?utf-8?q?xnbvPg0ZEU9lMQRUkyPiaR+yfhI58JavJ0Qe11r/21fl9x5+wRr34VyMXWEeqA8az?= =?utf-8?q?uuGqpmJ1lRrq0JZFwyzWZBLKnYdSVwxMkVI+tGBPL0bqhnjrL87CAkoe2zBkI31eT?= =?utf-8?q?pmlTD8KqLhGMTLQ5cDQBbXaahROmHK04PmW7Ue4up/1LDHEKodha5KskQHniy42Bv?= =?utf-8?q?lhvL/R5Kt+dcwSqc6jBQS20W9R7DZeBwEWWi6IgDK3HkgcD+1s2CEZ7Pg5NzFHJdg?= =?utf-8?q?tVKO0Hg6i5kMq4xYVqwPl2KcUoIVVxa92x3xfARO+MPa47tvY2QrlnHtn4qzYi0i5?= =?utf-8?q?hdkT0iA4nMPn07NEA0HUQVXuwwYbBDkvqFbxs4a1cLSl7QuBm3ueSB58IxbrO+Nbr?= =?utf-8?q?28LC+164OSKQtXIGq72+1JU0tgtmX6xy/6gtdQun/JOMzVEn4G18vHO8SxKvQSoVl?= =?utf-8?q?lW9u/ZcFu4njsi9DWfMGbbQ5osJnqbcFu7LgDbeUgdc6tG0BYXPbcENkCRZt4q8fP?= =?utf-8?q?2rpHNugx2Wm4o3W149mmVHEMBG0IctXPIFYtk0eBU7R2wwcxive4u8PT/PRNVzLQ+?= =?utf-8?q?C05QxRvJJsVaHJ7KUqHuy5pC01tgDyinpcAtzB/3mw7WJHAE4DEXgRYmP0/g0YaUp?= =?utf-8?q?YTm0m6+X/4fk6TkNpOPBoJvMzZIy8hGFz/mXRRguVhf1RxkTV95g+6M2PWJsP2rLx?= =?utf-8?q?h8uIB4rWaBYsvm9/P53xsu2yUsEkRVf9IYSfaXsLRE3BkGIx87k4bkzhfZ+vwDwQ5?= =?utf-8?q?KVbT5RGyMGHmEk1mjfTGfcFpSwqvOaPb7GBCbhUrYmm7aDYrxI2W1SoSyhkNpZ5VY?= =?utf-8?q?9lg/R3sBKiegVP/tUnNhswsF62G+7S51bx7Ln7udoxfHsB8gJaMmYqLZ5CBEh3Jc9?= =?utf-8?q?0T546sUG2yN8Dr9xL5QCDeMvMkEyanHUv0ogeceebOVEsoHBmvVR3FVP6MFJGJWU6?= =?utf-8?q?kAr7nFzyF8Rsi1egcdiv1jhVRau+fpFcwF011jFLNchM4PfRbQ/rjjqUAc0Nnsj9T?= =?utf-8?q?f0rFHZu/8LFT?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 02a6db28-bd3f-4210-3083-08ddb252c671 X-MS-Exchange-CrossTenant-AuthSource: OS8PR06MB7663.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2025 12:37:54.4832 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FJBaNiIXiCV+7Wyf8fost2qj3vtjA9SvUw4iDT+BjE9doB1PlSaCeNld0J7PvNeKxdztVXp7ZEZ/CXT3VKloZA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYUPR06MB6196 From: Yangtao Li The new devm_request_*irq_probe API prints an error message by default when the request fails, and consumers can provide custom error messages. Converting drivers to use this API has the following benefits: 1.More than 2,000 lines of code can be saved by removing redundant error messages in drivers. 2.Upper-layer functions can directly return error codes without missing debugging information. 3.Having proper and consistent information about why the device cannot be used is useful. Cc: Thomas Gleixner Cc: Krzysztof Kozlowski Cc: "Uwe Kleine-König" Cc: Jonathan Cameron Cc: AngeloGioacchino Del Regno Signed-off-by: Yangtao Li Acked-by: Rafael J. Wysocki Signed-off-by: Pan Chuang --- .../processor_thermal_device_pci.c | 24 +++++++++---------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c b/drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c index 00160936070a..d3e3a53511c4 100644 --- a/drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c +++ b/drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c @@ -305,13 +305,13 @@ static int proc_thermal_setup_msi(struct pci_dev *pdev, struct proc_thermal_pci for (i = 0; i < count; i++) { irq = pci_irq_vector(pdev, i); - ret = devm_request_threaded_irq(&pdev->dev, irq, proc_thermal_irq_handler, - proc_thermal_irq_thread_handler, - 0, KBUILD_MODNAME, pci_info); - if (ret) { - dev_err(&pdev->dev, "Request IRQ %d failed\n", irq); + ret = devm_request_threaded_irq_probe(&pdev->dev, irq, + proc_thermal_irq_handler, + proc_thermal_irq_thread_handler, + 0, KBUILD_MODNAME, + pci_info, NULL); + if (ret) goto err_free_msi_vectors; - } proc_thermal_msi_map[i] = irq; } @@ -391,13 +391,13 @@ static int proc_thermal_pci_probe(struct pci_dev *pdev, const struct pci_device_ irq_flag = IRQF_SHARED; irq = pdev->irq; - ret = devm_request_threaded_irq(&pdev->dev, irq, proc_thermal_irq_handler, - proc_thermal_irq_thread_handler, irq_flag, - KBUILD_MODNAME, pci_info); - if (ret) { - dev_err(&pdev->dev, "Request IRQ %d failed\n", pdev->irq); + ret = devm_request_threaded_irq_probe(&pdev->dev, irq, + proc_thermal_irq_handler, + proc_thermal_irq_thread_handler, + irq_flag, KBUILD_MODNAME, + pci_info, NULL); + if (ret) goto err_ret_tzone; - } } ret = thermal_zone_device_enable(pci_info->tzone); From patchwork Mon Jun 23 12:38:35 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pan Chuang X-Patchwork-Id: 899635 Received: from TYPPR03CU001.outbound.protection.outlook.com (mail-japaneastazon11012037.outbound.protection.outlook.com [52.101.126.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE109239E84; Mon, 23 Jun 2025 12:38:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.126.37 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750682332; cv=fail; b=bAi1wjKTVmDuut5dL9DRtHStIaT5KGqD5OXE7mNPjkEGJWvMj3rz7DmrCP02/rmz1iTwG6LrMWpczDOIrgN6hlQR0a6yz4xbPBCj7iclrCd5e2m5mso4hOHGb1IdVxcOINchnxEYtxtp/o6fB706WEH6ZdiNpCRLHis0qLHrh38= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750682332; c=relaxed/simple; bh=FFIfLslow3HPs/t2u5VfuSNXNCnJ+WScJEQXJeyerls=; h=From:To:Cc:Subject:Date:Message-Id:Content-Type:MIME-Version; b=asuw+L+u/4CVYuFD7EBm9sqzgy9+i7EL68+aR25BXHXVNkWxyTgjFEmDbwzWN6w2tLANM8fqvXIYFSxKRvAl2cRCmzJTbFl0i77uQnMlaA5EUcsq0Appbtr8qtC1gWNb1TEk251tgbRDxHhS7pCoh+AU062mfl/stVkB8dWOkPA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=mwSdT/Fq; arc=fail smtp.client-ip=52.101.126.37 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="mwSdT/Fq" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HodDJGqEvv1C0zqW1r7BKeS6EmQGykCQAcmdpg2kosECoMrpqa+05SLKYXRrDTywEVS0HNoEh3FJtIis9Dy0w8F1xIxRovbbG0Ry+PKI0/wN4mWXuzp6Hf5dMZA6MyPgJI4GpLxIml6g5bIKrK53MiKEEOgMkNgqFHBCd2szgHcA3aEglga18cfRgYj2P4VSz4M1Gy1Irl1JpSvsOh3bsFFTiattZ4QWUjThUF4hLVZ0wb1ViHp5luUOM5yk5WvkrM63Nlq9Ukw2kwG/1DUEP8co2VodbessPqTBzAlOgcED3dIfd21imxv/3lTQ9AH//V2zvZy2tYVm0tJJOgToaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LkDGdVlQZYWMN9a94Q+BlSceVeS3v9T6gqhzFf6gXjg=; b=iQxlggxt0YnMNnSAIG55BTqAFdsFlUyDefh1rhdlpeQZ/HeB97+1H2cs84i+pgvqSoKR0e/mli6q+t2D4zjAwTUMyF8hvtOOI/GVkfADFVGqacHSgSSnxeDwC/4ylsd1GP17m4m7ajCEJPdlzCL8mQ0CpCTj+NtGliU3EU/URd4c6EiPLiTdXPoRRhiB2s2byxIiV0VVoihldTmfPD58ERIf6lGY7ENwXQL1tnMR/AEBSVTJfhWrN8cJX4AiFcVLjAdthx94eZ/G43ZbxZB+r9VK/RJzDsyUn/DcBb41q+wElb2/1kcxn0Lve5yiZTPytdv13OZzb9MxZ/Q/TtoVig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LkDGdVlQZYWMN9a94Q+BlSceVeS3v9T6gqhzFf6gXjg=; b=mwSdT/FqZ7Qw2rk+WVGMpNpGGLpt6JVPSiRSvubVyPJccGqhpklRBwHGGjlTzEKofOsmVImPaLzvt6hBVYRrhUfvfwfh5C97jYI2CDVrn3zPudVhhtzsFn8+AXF3zqTc6g596LVzsP4ydrx5YvDqTW+mqhrAUjdMRPQiP3umF4ZGNuiXimQm7iGoj4GmGcwt0rNj0upP+m3rb0ssuYhY+//c4+df/Awt8lYGcNnH1hyxkTZNptYdIl6GJRU5EVOfinDOaNxUd7BwAcqrzCjhj4N8nW5YVrE6ba0cXiQqsCgSGpl03L8Pw5Xa92hcNzgd+GYZtMcjQ4QNUFKIhbwKjg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from OS8PR06MB7663.apcprd06.prod.outlook.com (2603:1096:604:2ac::8) by TYUPR06MB6196.apcprd06.prod.outlook.com (2603:1096:400:35c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.28; Mon, 23 Jun 2025 12:38:48 +0000 Received: from OS8PR06MB7663.apcprd06.prod.outlook.com ([fe80::46a5:9b06:416e:1e49]) by OS8PR06MB7663.apcprd06.prod.outlook.com ([fe80::46a5:9b06:416e:1e49%3]) with mapi id 15.20.8857.026; Mon, 23 Jun 2025 12:38:48 +0000 From: Pan Chuang To: "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Yangtao Li , Thomas Gleixner , Krzysztof Kozlowski , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Jonathan Cameron , AngeloGioacchino Del Regno , Pan Chuang Subject: [PATCH v6 12/24] thermal/drivers/hisi: convert to use devm_request*_irq_probe() Date: Mon, 23 Jun 2025 20:38:35 +0800 Message-Id: <20250623123835.473981-1-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 X-ClientProxiedBy: SG2PR01CA0130.apcprd01.prod.exchangelabs.com (2603:1096:4:40::34) To OS8PR06MB7663.apcprd06.prod.outlook.com (2603:1096:604:2ac::8) Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS8PR06MB7663:EE_|TYUPR06MB6196:EE_ X-MS-Office365-Filtering-Correlation-Id: e2439b9a-f48e-483f-2161-08ddb252e664 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|7416014|52116014|366016|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?SFRNMgyc8LsmWqJHZiYtJ+pJzs/Xouh?= =?utf-8?q?fJwTewxF2Ls33Aoq4bilx2L60FTAcMSJ61tUnUUa5U2eamihLAGK0sVRedEXCwWrH?= =?utf-8?q?0Mx7RbGtRr+e59TtkFEPx+4pZMy+x6VuUYxMSOlSut1OjU+1PLreZTwMiQsOFnXVQ?= =?utf-8?q?fU0hIyBQV7qy2MiAdG2tyvNsiqrAhsY4TjQDqcLKx4HPSntHjo6Rf1HOfzXM6V8YF?= =?utf-8?q?bjb9c8u8EgCsFkhmR65Tv1OLoVMGDFLhovFaFWfbyH1X7VSNTMFuVnZD8VcPrBiIr?= =?utf-8?q?f1nowqXTuBloTD/9qPZxtN+fd8Imzcu1Dugz61w7RPmz0W5wtoDOCJXkIzdRr4dMh?= =?utf-8?q?ahzs2/UIUWTJEfknZb/wrEUSVqq0MnWhywRiPOhFi2cow0VaWj7TXsJGH3uCsoHMk?= =?utf-8?q?AOjFgDrDL3oWLKNCIUfM8M3GukChgzipNG/6IuyyNhBv+MgCrkT1Kg9BUipI89MNz?= =?utf-8?q?K3/YOu3y5GDk/fSgS9yAWzEyFj9HqzmNfODdTjfwBe5AfYgKc22Ow52Am/k/k18Np?= =?utf-8?q?VS20539xXsovkYbpTfUUf6pXi08duiSfuBwvhbfSgVKjqycAZYxoVobAHcNJ0tWqb?= =?utf-8?q?7M6JvkOZ9FzPaY7gnApdL8DHtKn1N1n7dMQwmWfUbCZKQjxBBAyidYI7TGLinqbkZ?= =?utf-8?q?6QYRTbLzsa0aPYcw8haiwRmyKLLkFdoJekZuJp0cy895eMunDKXcu04pJIQSNA+VF?= =?utf-8?q?W4sFdBjn0uODCYYjP3WGfmbhnFxt9fq1nRbqJ61b6r6h0KX4XZp9ba2K4dHiZ7KMp?= =?utf-8?q?9gcTaVydeoYv4KxUq44h6VJU602Ylji9ksS5Kvd55uhsnBVVojRVec/AtHfwP1zOE?= =?utf-8?q?0eaHD9vwQ4/zQ6rY6y+rzjbvUxbWG4jQJVNWDNP7mbtG5C29kJc6rFzBkBHKgagcf?= =?utf-8?q?UHeGmoRg5XrgDMQUEB073xL5yE4LMMzRKDCJVqb+iJmorsWKnJzVOIPHsoWI5Cgt8?= =?utf-8?q?0z1N1wqlECfXjep+F0H09xqhQZl8Sd/0yyxL1YokWzeqnNSU2tW1dvX1zas+86/7J?= =?utf-8?q?Z7qKcV/b54eGYigxElKyyU9x7EIw9F7DYeBUe5p5BKYEIeL4AnnZm/hj2w3pRqoIr?= =?utf-8?q?93ZtbcF60JgEa4MyBbbnK+HBUaY65jgfZ3L5Q8n+gE09eCuA70Q1M1hXUqzCXy5Ed?= =?utf-8?q?yGX1KJ8hQRAjXew4fVbMCWV01mfhc+6fh6Bc0eAuXlCNeBk48+ldGgzDJFCx2pV+3?= =?utf-8?q?JMkVKM7LBTgRzjOmDoviFntiJ97kQhW78ECnwrdX7iN+wbbYP/gOPRj++rPT0mEab?= =?utf-8?q?q7+GuOdWHu5wTmNiZaf1wUPbR1Q109FHCqLkgTmV90snJSTUZcyj8/kmR/71o5SHQ?= =?utf-8?q?OpgnkNmgt9TJQIPJkdTjLtvFc7wNc1M1CRzwmpyrWmU2XbMuhtS/fPox4DZrrcH59?= =?utf-8?q?V8vwrsCA1ISe9VqKIGnRx2U2vhNuFeqzw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:OS8PR06MB7663.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(7416014)(52116014)(366016)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?+dhjbO6+ZSMMLJirTYcRrTL1AGK0?= =?utf-8?q?fBygCeQjgNULplkiUGdtZnTijMHbiQlzvtTfBnbwKpPXXfg6U4PHdKbVqfUjx/bzp?= =?utf-8?q?mbHu2xa1Qziy/6kHb/6THOz7J+u4qbRJmxkT+GzDVZkyCLtib+XgGFbHrANhExyGb?= =?utf-8?q?jJSbhKruSUj8d4YJ8AvxmFArRqzqPUnn2BDfGKu+Gnk8edAjz/YXeL6og9iESZerg?= =?utf-8?q?rRrlYaE/mFlMLq6bLb3B5SwOTdVugsZahf8DdvBeHtrhVDmVHLWwa4MG5G2X4Bc79?= =?utf-8?q?5ZnADG9rk6q0Tm8067r2/cxW8xZZ6p6M9c7lwRe9uDVOhlffK5txKSJkvmI1G+heJ?= =?utf-8?q?K52feNwAxLnS5UKpJ98pTZM6CC8drf8b0e2wMQM6ju2j4xqttdEV4zXLobJi4H52r?= =?utf-8?q?xX0EI4uRC0AThih98HW93Bl/ig+pqwnj4wamMMgG3tT55qkpylJ5yYLzl+8dVYpJL?= =?utf-8?q?lLGGqpAyVfyKR8Jzc/1+//lyKYYzc5B5kaJlLZrz+pf7nwflsD1GgaEEVZNWUKHXR?= =?utf-8?q?ecNN1qniITxRMQs32Re3pbJRWkMTjIGgzyCUDY/jqJvG2eLHd+0eNYZERAy+aUV1o?= =?utf-8?q?jMsgckqSC1TQMarYoyAxkbXvMIJXa1MnrM1+sgUxqmumTd1Fe5ojucnUB+weO2Xuc?= =?utf-8?q?3goFcrM/odZrahBO6m4eudeK+xrjCBJ7XdQGTpzd3zAmUOeTkxczOhamUJEHXvpkn?= =?utf-8?q?iBQAvrbBGQ8lXrpLVUzzLUYUojF5Idsb00yGd+fsJbriNOU++VgObU30YUFub78oI?= =?utf-8?q?CXxq/uXfQmUZQr/R04eEXoNiNDhsKTc8JDxzICdrfdK9V4YSNam5olnQgxyvkBO4f?= =?utf-8?q?9lau+9JgX9KRQ4LG4VzhnqH6tmPteE+NojFhGGFX9tYOdOeUTHNNM+UfRXm7KHcAi?= =?utf-8?q?uGTqd68isQ+q5Vi/wMeabui13LrEgN5iYWEsDmqL4ycN8KA6v2VIEls/hfGxoZcIc?= =?utf-8?q?9zQ6kknrlkV6aKE2PAdtX4Ll3xsIyVC5eY2xss3ZF0rsyHlfmh2HyJIjT9e9cyF5I?= =?utf-8?q?m+w94r6sKUhE3MSffXumuuHqtwxczbOcnqs63O+0ckW34IBfWCbJqZJrbZxHUB4+J?= =?utf-8?q?m3NmRNoE8xEnvVcMY3b+jeUABmMzr1of4KR4D69zywUUIU/ssIahFw+tLxTiH2k8V?= =?utf-8?q?WbFYA7D+NCnf+VIV5nVKNNNW8FHf/fjN4F+eg3JP5M5Z49T0eSxfuBjIHChQ9yaoN?= =?utf-8?q?FKjZDNwNmUmLVtIkkWEcSMcFcOnQZVvPL+1TbZn/MYP00kleb9lKvX7KG6A+Ly3uW?= =?utf-8?q?dGEGm8m4ZNe0ewDKSgoLEeKh0aUd3mJUU3YFhQhCX+NxCb71scHUiMmHd5nD6h1q3?= =?utf-8?q?poATBAttb4vZrpGEEZBxsxXEIgjvSXpZ6q+CFGPVZ4qtj2nxAmNRGWpU2hLGnW5v7?= =?utf-8?q?zKxS8FzIlM2iTx9UytnLSwmXt15/aD4lMb3myBVirSr/F1fV43q6A4pPoOMrZwLOl?= =?utf-8?q?uctM7jsKlFlS2wutZmblfxjKfCsli5EeGTXaeauIdUQmSc72XZyBCLAwZuh3x/IvW?= =?utf-8?q?H2zzsKKtTmoY?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: e2439b9a-f48e-483f-2161-08ddb252e664 X-MS-Exchange-CrossTenant-AuthSource: OS8PR06MB7663.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2025 12:38:48.1384 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ujJ3m5OtCUJvjBrOiPwZQOlzoRm8WlUmvbk7zqqeb+y0m2ZtRtxWoaPgkVS0VGyBbvYKaP5iZoX0MFxZgIGIOg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYUPR06MB6196 From: Yangtao Li The new devm_request_*irq_probe API prints an error message by default when the request fails, and consumers can provide custom error messages. Converting drivers to use this API has the following benefits: 1.More than 2,000 lines of code can be saved by removing redundant error messages in drivers. 2.Upper-layer functions can directly return error codes without missing debugging information. 3.Having proper and consistent information about why the device cannot be used is useful. Cc: Thomas Gleixner Cc: Krzysztof Kozlowski Cc: "Uwe Kleine-König" Cc: Jonathan Cameron Cc: AngeloGioacchino Del Regno Signed-off-by: Yangtao Li Signed-off-by: Pan Chuang --- drivers/thermal/hisi_thermal.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/thermal/hisi_thermal.c b/drivers/thermal/hisi_thermal.c index 4307161533a7..bf283b8c216b 100644 --- a/drivers/thermal/hisi_thermal.c +++ b/drivers/thermal/hisi_thermal.c @@ -574,14 +574,12 @@ static int hisi_thermal_probe(struct platform_device *pdev) if (ret < 0) return ret; - ret = devm_request_threaded_irq(dev, ret, NULL, - hisi_thermal_alarm_irq_thread, - IRQF_ONESHOT, sensor->irq_name, - sensor); - if (ret < 0) { - dev_err(dev, "Failed to request alarm irq: %d\n", ret); + ret = devm_request_threaded_irq_probe(dev, ret, NULL, + hisi_thermal_alarm_irq_thread, + IRQF_ONESHOT, sensor->irq_name, + sensor, "alarm"); + if (ret < 0) return ret; - } ret = data->ops->enable_sensor(sensor); if (ret) { From patchwork Mon Jun 23 12:39:19 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pan Chuang X-Patchwork-Id: 899634 Received: from TYDPR03CU002.outbound.protection.outlook.com (mail-japaneastazon11013039.outbound.protection.outlook.com [52.101.127.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0450B239E84; Mon, 23 Jun 2025 12:39:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.127.39 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750682374; cv=fail; b=c717K9CR9JJdr+OO+bycQXnxogBeXS58DZX2Q76O7siRo3rMI2lNPNr8VywCBVt9zUDE6xijvzD1tHCHF0qZ+YB3pLwbn08DAj9klbWSX7S9NO7TzVViRhK1l30AKRvFht/G6dgyK4lwJ443IX4kthpbMY79XGX0gLEBYGIbUKQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750682374; c=relaxed/simple; bh=6FkJk9jQ67iK68a2CSIV+I58zHMBBFV/IO5kNjiqWO0=; h=From:To:Cc:Subject:Date:Message-Id:Content-Type:MIME-Version; b=IPvRrFBqZ8kS8gYcC3ZTxn0wS8UoB8SmzBZM4AOtWXEVr5qN290w5c7sx5ZphVSb2r2/u030gJhjrhNqQoLak9eagvjJyaozPTOdYmjdqGjooJ+xq5i1rcMdbf30G76yKKkQEmZSyZL1oVelNa48r/wglHm8P3nn6+oAqPTBhx8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=MGnZNUea; arc=fail smtp.client-ip=52.101.127.39 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="MGnZNUea" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wfDhTOfJMRuQJ9sbZDX1kUIasy/ODSEJ0a41zx5dNuiOyQ1eWS29yzmgnMt7hD2lNkqS1fNMyOsEgXhjZ4fa1UT8huxedrZfmp7CK4kxhFQ+1XsKbtAGRme9E+oL0/RcFgleHli8hKJUmx1hxZSGFCc5Zy99LKDuyug6Jt+5vyxKPrIhw5zYu/z9aihkoThuSkAyIPMw27GmLOpcy0yIai7ztjUEO2dw768z8RJciusZMw8a1wmfT+EuyCZWBPVAt13jSpw50exdhPq9yTsVFc8ldcCd3EJwW+9ekPkh4uw8eZ/agr6LOvKqV03sgnAmbttrYG04Ae1lTy3mZR27Qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UN07oeb20Ry0roUHWfBUvPJITjHi9aJrh12ugIVNthg=; b=i99w471DALnO4xyFTpy5yX5HSda1nakcpXnqe0EZK7XfQg0FKPuDep9kHSYOK+twoXzcK0ck917ZnarRRSPZbXbkHJ0njFP8FcoMsKCmJyWF87oMrfuharDW3tXUUOCGePWE7w9pbGoBeOGwI5L9jFNyssl9mmBk3U2PbEvuLBYeuSyMLeHoJ0VbbtuIbQeriYOU4+NhVPxRiZvQqkSFd6Gp9oPMfcVCYAhWMvP+Q9s1JoIKd52YFXWq8raEOIh4FWFLPrDZBM1aK+UTsJ1uM+VsJRNEUy+iX+yQGa08rDxkvZhtmcURsSCO9TbBXv8EJonCkW+uMLcUke4Vb5leSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UN07oeb20Ry0roUHWfBUvPJITjHi9aJrh12ugIVNthg=; b=MGnZNUeap9XaDzg3k2mX02xC5LwYc5tazVV0Al37oGsIrbrKTYK33sk7pTUy6akh2uexqX40Tq+z/8kdo9O4J0Cry2E4/piHMpH5Fh+sQdZ/y9XTzHr8P1gXMm2N+3yc7ad7MsFbn0idbEqAVezi2Hm9A3Dn8poQjEYzu55/0Ir34T+oqy5L/f9B6pe9N9zqixE91gN32tXGQB5P8WAP9SChuPaMCBrSrfMvQ6Fz1lqlf9BIUGhDJgLFZGM6GAo2psYlkqiJ85CLCmYAeHke/sJ8lH5Zo5apOVVmGg0/DtmDvxlB+m9UuwbaGtWNuBKe+saLA71fpSQFf/N0m8g/Rg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from OS8PR06MB7663.apcprd06.prod.outlook.com (2603:1096:604:2ac::8) by TYUPR06MB6196.apcprd06.prod.outlook.com (2603:1096:400:35c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.28; Mon, 23 Jun 2025 12:39:30 +0000 Received: from OS8PR06MB7663.apcprd06.prod.outlook.com ([fe80::46a5:9b06:416e:1e49]) by OS8PR06MB7663.apcprd06.prod.outlook.com ([fe80::46a5:9b06:416e:1e49%3]) with mapi id 15.20.8857.026; Mon, 23 Jun 2025 12:39:30 +0000 From: Pan Chuang To: =?utf-8?q?Niklas_S=C3=B6derlund?= , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Geert Uytterhoeven , Magnus Damm , linux-renesas-soc@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Yangtao Li , Thomas Gleixner , Krzysztof Kozlowski , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Jonathan Cameron , AngeloGioacchino Del Regno , Pan Chuang Subject: [PATCH v6 14/24] thermal/drivers/renesas/rcar_gen3: convert to use devm_request*_irq_probe() Date: Mon, 23 Jun 2025 20:39:19 +0800 Message-Id: <20250623123919.474049-1-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 X-ClientProxiedBy: TY4P286CA0021.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:2b0::6) To OS8PR06MB7663.apcprd06.prod.outlook.com (2603:1096:604:2ac::8) Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS8PR06MB7663:EE_|TYUPR06MB6196:EE_ X-MS-Office365-Filtering-Correlation-Id: e063562c-de46-4c98-6bca-08ddb252ff66 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|376014|7416014|52116014|1800799024|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?q?vjwlITgMWo7j7tGjqRe0QIMKAsJ0UVD?= =?utf-8?q?MNc13Vw7IffdvPtSpyPqyqzd4iup5dPlNIKZdekQZWzkr81sSutpEfmnFhpjTPlZO?= =?utf-8?q?e/6UgUNqHw5PhSAKy/9EAgXskTfCmV6qJxRfVI5j0kRbghAFWOz6XgO1qICPAQREp?= =?utf-8?q?CiBggh5+HYNTUmyyYgAU/E183lSp4mJTNzoSCaJNd6zkqsXpKnuuqcaziIDv+PvoG?= =?utf-8?q?PP74CyDlIEnC0M9IL1cje8rpXXa0dgGSpdJRJzqNxcMV/D6EIip3yy/F/Y5vK+ZXI?= =?utf-8?q?M8rf0R/bxfxP7gDLr2v0Kt88STTm9y19OIcU8O0JjUtCQaZlnWLfEhLivxS9mCkSJ?= =?utf-8?q?gfDt+u1t28PmqZcoPqXG74qtJAyXHxc2zq9uJIZPudQoQY44u/F6kSSJVWkN5GYPw?= =?utf-8?q?vXl2BezyzctQPAEVcZrN2TqpcJXPR1+H99/jUBg8AdB+kHr2hNP+p0nVDsJtDvekF?= =?utf-8?q?qxCgpQE9ekbNXar8qT3daezkOJvubaVDIrlVQO5vSYY1QBuET+/6IHpFYd7TbikzS?= =?utf-8?q?VgyeS7m+G7OLXQs19l4XfF2Pces41ftLoTEFF0RonJbmbxkN25S78nq5Sxtadhxnp?= =?utf-8?q?J9gK7IytugliIAmWRCd/y2LjSXzMFhqZCeoPtd89TQOGqFEoJZXAtBBj7FRIrCFxT?= =?utf-8?q?H4tHoRv+rF5BSlVhLDPM7N3OpeQxbNWeFMVeHsm6FPG6cjw9ucTAt9XTocC9pgD2B?= =?utf-8?q?XIVazmLkjAIAuj1/iVgBrJd8lG4+4x2Bf+gJDSguWYBGN4D1hj7jwB48Re93KJUTO?= =?utf-8?q?jatjg2I0ICpvckusPES0HMjUfdqV5GqFZd8Xb43R8Tnqj8+KJJpE9RQECGvCxntLv?= =?utf-8?q?Tkn3ufw4l3Nyj+1eQE1qfPXXv8KQMNDd4m+5kwAflKu0h/VHxji2ca7HixP/T9LVF?= =?utf-8?q?Bs3luwQRF0q+Y8pzVdsdiAaQ90mgRnFOQeP82uHoZx548bQmH/sWgZI2KS09cYSxr?= =?utf-8?q?BZly6iDpeaGZ37B8i2+1EcH+0u/d44eeJYdQClr+BgeBjvjdf+9IG2IH620mjUhxS?= =?utf-8?q?0aInSpVXRsV5mfqy5PaREcr5ASaXv1a+oHKJFdCxd/R533+FyjQbjeMtDCWPPihb+?= =?utf-8?q?MZ481i6aZlgWHhbbTu2FGFPjXBizQJlLO4QvLK+m4xd/NJa3kuBRyiHEKDRuk5frP?= =?utf-8?q?zeIeb51PfoAEfsJ8o5bMN0yk+W51qoF7qAvyjpjdKf4OHlx0kI4gyQU1XfgJlTeup?= =?utf-8?q?+CDQAhOmI6kfJ5nrjHWyqGJdkSER7el/vTf29aTLr1FtCoeFi2ky4U4xfkF+epocd?= =?utf-8?q?46EG13XSEllGumRHykrL9ieDj86/0rYc0kTSEBw8USQUuV06lLUwZvpkZ1hW3TSaG?= =?utf-8?q?Qv/2dVDQ8tWIJCQC78USHPOrWfeUafRKQXGpPvkTlXL7XWsOSZhaiQNalj+L6ajH1?= =?utf-8?q?xdz/ZKUC1mYH2XV45dZHMnMK2+adiCJeAP5ejtOvXM2cnADQ4NmSAE=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:OS8PR06MB7663.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(7416014)(52116014)(1800799024)(38350700014)(921020); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?eH2oMAyWYiB0jLH+f6BJDGJHcKVt?= =?utf-8?q?64SJspnoiDpM0sHfu08sHylzhSQCk4w69/6JsrHr8hQqwhh+qFM8fQlyA7ImjIAtj?= =?utf-8?q?Z5iyBIbjuyWxO8zeIkkEtojwPhEbF1nfey6jQ2o/dlRQy0hLzPAkFQU+RINAd7jAa?= =?utf-8?q?vjxxUMwjIjgS8oRgRrDwAIwW1ys16fUJYnN2ZgPIXhAyHGxQcq8gzTb0fdBCQo8s6?= =?utf-8?q?0zMHMMJUUSAD4RiRcdFwMRx97mNEUkd0b31fQm1GqjlhtaZRneLEHyEsekHdVZ7P0?= =?utf-8?q?J6AWcPT4C5avcddLDKgyuT1G0+/yE66faTj8hU/Xh+LbxWIH0gr33+1tMB3ivEhg8?= =?utf-8?q?QFZuPQZ6MvF2c1ggVg9/lCjKXkrxN+kZNS+ccPaLBWWTZVcyg8owIWronghuCTU4q?= =?utf-8?q?YPzLwasWEbq18K1mMutUwU4wmvDYHDUjCGtkEus5BCINuWWNWBwA+UVh+SUP95dPN?= =?utf-8?q?HOtd2qdi0001koZXanPXldxJKObVKJuaErQV3rOl4KiT/kfutIIdFEKIeJnDbLQ66?= =?utf-8?q?uCDNQ9F4rrPzWI1buh4Mv21pMfhgJOTiyzp6QMCNR4ZEomL6wCVsT8L2LUb9jC+0v?= =?utf-8?q?3ZjRUOzyLojeXnzA0Bd94Y7o7nWfiyHoWnW92EXDftxgxCenP1faJiPvE5bdRCpKG?= =?utf-8?q?pXyy2963/wfHooj89wP9ucJDXOR9pfqPVkn8FDpoQECd4DB9+hTE1FbK04x/+H9zM?= =?utf-8?q?cZv0UOTC7IMVoEsN6wrhShCLZTlQMJU/nG7I8H/RS9ICUZ1b6/+Hb/yOVaVJT6HI+?= =?utf-8?q?G9C0A/0ChGT3poJTYde1EeUhElZ8TCC6/OuhjU+tsyTothVwWQEzMwpa7J6zmY/Ze?= =?utf-8?q?Qz4tB/I55HS+4GwVvrVY+TRmCPYcC7kiJzUdRR3h+/sSIegjo8wDWOK76JLKEF1oD?= =?utf-8?q?e9RBmMo0nzA7uib1SHBNLctmuE1V8Ahu4Q964V+68XnwE/qwrh79UKVzLbp9nFDMZ?= =?utf-8?q?xVjT5HXFCx1SOtebHbW/rM38MB6P9IvO65Q4c/EDDtiBcdX7d5mf4kemvMmignvvY?= =?utf-8?q?AuOZunFgAbYPA2X3p2A/WEEUjpglWsRUl7pNEMpCjOCyi03ROkJF0ZKWZBuwA7Tie?= =?utf-8?q?9IjCoOqOCGW7+jSkONFKlx7as5PFois++rxZLSB0+fBtL1sYsRUBHX3+C/862n1ql?= =?utf-8?q?V6fBO90gme4UrHcd+cD+N89Y44+EZTUxO94WIWZKVd9R4e+48tOvGDNZ/Vojldl80?= =?utf-8?q?bfyIrjQGKwsmdvFMyFti8uv5RvVgnDIXXhWoF4rgWB+KKTP6ofJELiL5d4dh/L18p?= =?utf-8?q?7iUnCdIzaWZiAVaF9wRS9q2MiYTSq+cOfnwI+PvdIh/jMOXgP+kXICBZQw9D/L+Bb?= =?utf-8?q?mtqWSXpj+5dMMDmAytsjejHyqM/DnDkImbmRaMLDvq+FwHGzxge1fdjNIE8hpjqMd?= =?utf-8?q?V3lDoJ3O5kzD5Xv6AvVUg83L/bIsfB/FKyCWtWt+Rtsz4ALfcM8VcwZt4k3ANbruV?= =?utf-8?q?C1x+NGeGSohICHyenTO9zx2AUKYnAvV+x1K0Z9p3+BbZe0gc+bbOblLWznUlCCqwa?= =?utf-8?q?Lt2rRQw64TfF?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: e063562c-de46-4c98-6bca-08ddb252ff66 X-MS-Exchange-CrossTenant-AuthSource: OS8PR06MB7663.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2025 12:39:30.0594 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EIuVKJKm2CqebjiWo0JyAG19ha5RNFK5CFJ4SPGhgy+W7+YrVgiT0HgSxs2XE31ngzfqYdVaW+MB4SHUEaZWwQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYUPR06MB6196 From: Yangtao Li The new devm_request_*irq_probe API prints an error message by default when the request fails, and consumers can provide custom error messages. Converting drivers to use this API has the following benefits: 1.More than 2,000 lines of code can be saved by removing redundant error messages in drivers. 2.Upper-layer functions can directly return error codes without missing debugging information. 3.Having proper and consistent information about why the device cannot be used is useful. Cc: Thomas Gleixner Cc: Krzysztof Kozlowski Cc: "Uwe Kleine-König" Cc: Jonathan Cameron Cc: AngeloGioacchino Del Regno Signed-off-by: Yangtao Li Reviewed-by: Geert Uytterhoeven Signed-off-by: Pan Chuang --- drivers/thermal/renesas/rcar_gen3_thermal.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/thermal/renesas/rcar_gen3_thermal.c b/drivers/thermal/renesas/rcar_gen3_thermal.c index 24a702ee4c1f..e7ba1aced606 100644 --- a/drivers/thermal/renesas/rcar_gen3_thermal.c +++ b/drivers/thermal/renesas/rcar_gen3_thermal.c @@ -468,9 +468,10 @@ static int rcar_gen3_thermal_request_irqs(struct rcar_gen3_thermal_priv *priv, if (!irqname) return -ENOMEM; - ret = devm_request_threaded_irq(dev, irq, NULL, - rcar_gen3_thermal_irq, - IRQF_ONESHOT, irqname, priv); + ret = devm_request_threaded_irq_probe(dev, irq, NULL, + rcar_gen3_thermal_irq, + IRQF_ONESHOT, irqname, + priv, NULL); if (ret) return ret; } From patchwork Mon Jun 23 12:40:15 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pan Chuang X-Patchwork-Id: 899633 Received: from TYPPR03CU001.outbound.protection.outlook.com (mail-japaneastazon11012026.outbound.protection.outlook.com [52.101.126.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E721246BCF; Mon, 23 Jun 2025 12:40:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.126.26 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750682432; cv=fail; b=X0XnNI4p6oejZrV0YxwOfwZQbydaFI8puFl5GW4E3QPKIGE3zkQRHNfyzlcuaTsvvXqm46TbQEjXfKjt08QUocpsCc5tb6Uz7Mu53Le4i1oXvEKRcLggQGF3yLLSK7JY4qFzKqWAP6W+2YwP9IEEraombyPre3qlTgDFOaZgOMw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750682432; c=relaxed/simple; bh=vBkC9/MwHKQoBltgAeciWRFifRV0a/iGrp8DKiMuTy8=; h=From:To:Cc:Subject:Date:Message-Id:Content-Type:MIME-Version; b=n0C0UyyDbDs/8vUyw/TbfRgY4AVFnfAv7Ibl3OjwL0GTf/k4aoiBQjDpqmDYkkttTxjUcf2KD/RCWOlMELw8aV1sG+obaxP9fUKtYOoHQNRMYya326n44XC0hKQvxFHgCkVznloQ9aoD4h+L8ZdXecvCWG8CtNfh4pwcefZoQ2Y= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=CNqCM2yd; arc=fail smtp.client-ip=52.101.126.26 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="CNqCM2yd" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QYvSSVl5xpEbMdo2vKKVxpZGUXO/GVEJFpTcdVr5R+lyElDoOJ2UnR+rsFZSIJOz9aodaMaa5zsYarLbY5YAzWuUstywtYt/1BDGarDueLVxN0uBQeiLTbPO1ZNr1SDBHzFv2097kVjCFdGX2OVF4kT/tRw0xE0+Jt9/3Rtvw2iQZVYZZ2yLE6xixbRhOjeDFdIz9jHTyZRIsyUaRbB/Vu7x2YC4r0Svnqb2ScxVetk8sa3hUVQcwDar6aMXNpctpl9BOR29wOFaWit3JIoq1eNPpN0J5g9/VuQiDHZ7q+vCxpN67tAA8AIj6cmLDBD9toctmbjrgpRHMOdNItHPOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vf5xgcn70NGF48RdCUNfbkCTsJQvidMlsdWCNA2c3IA=; b=cKU0t4f6DPNq+VLNMP7SKWJUyP+2gURTnoIfCWcQbgFCuemr4eYThJQ0vR2ZX7QCACsNSJBdsQ6m/nVKAmh9Ha/gbj/mwYggZbdP/N0ZJR4qQV1xYGHFgBfUeVAAXZdsGVZ+EegaQRRlQVa2JjCbocKb8v2oUNCiXqbATU5hmwVXNsc3mB7l/qXI0F93MiT3Z2t3WcQe5sAlfKCmTadtfsPh4RLgCc2tYeMNjIT1WODSXyn/tRxsNmdvnpAmOrCb96IR3Qaoj/HSB8f0dnN/cwqUzhMIJT+SmOhGI91TiOKkY7pSabiR0tT+sbOpEyNOJiDic9Fbt/N+byrjPNuckA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vf5xgcn70NGF48RdCUNfbkCTsJQvidMlsdWCNA2c3IA=; b=CNqCM2ydodVNYjrsz2yLko2ffj9TO1iSZkQ6YJ0hAjenYihOnCwOrumuOVob/oxlzgoBZ7rf4Q6VLdoBEoV69uipYUKeyyEpJOo7OfWj6gmwB3N7INnH82yZkL+nvt0djI4pqtPDeWdIZuaX5erNhpvwcmRnkNfk/RoYeUvReSNR3fAeNgvTI0SXpQ01PFimrzOJiXzf3hX5OkjbyKLQzojgMx99Iq35aCICmuLYGQHFVaRR/OuXu67UbbH5ttlCid/NcjW31IAj6Xk3NAf4pUtyg4IL/KHKkYZp93Po9gYs6RwVH/rGo/fRr2w2Xudm7Ot6vJUroyGIfiWoSpiS0A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from OS8PR06MB7663.apcprd06.prod.outlook.com (2603:1096:604:2ac::8) by SE3PR06MB8096.apcprd06.prod.outlook.com (2603:1096:101:2e3::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.27; Mon, 23 Jun 2025 12:40:28 +0000 Received: from OS8PR06MB7663.apcprd06.prod.outlook.com ([fe80::46a5:9b06:416e:1e49]) by OS8PR06MB7663.apcprd06.prod.outlook.com ([fe80::46a5:9b06:416e:1e49%3]) with mapi id 15.20.8857.026; Mon, 23 Jun 2025 12:40:28 +0000 From: Pan Chuang To: "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Yangtao Li , Thomas Gleixner , Krzysztof Kozlowski , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Jonathan Cameron , AngeloGioacchino Del Regno , Pan Chuang Subject: [PATCH v6 16/24] thermal/drivers/max77620: convert to use devm_request*_irq_probe() Date: Mon, 23 Jun 2025 20:40:15 +0800 Message-Id: <20250623124016.474586-1-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 X-ClientProxiedBy: SG2PR02CA0098.apcprd02.prod.outlook.com (2603:1096:4:92::14) To OS8PR06MB7663.apcprd06.prod.outlook.com (2603:1096:604:2ac::8) Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS8PR06MB7663:EE_|SE3PR06MB8096:EE_ X-MS-Office365-Filtering-Correlation-Id: ecf7c47f-4766-4c96-dae0-08ddb2532222 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|52116014|7416014|376014|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?gvcx/d3xyUDGn/qiuFFh1gYhkeMQk6z?= =?utf-8?q?B6Ex/5wdzWkPtvZvUfnlteFYyktuS/cJcLYcPpphMRUhepjddQ9nvQVsIlRql/jlt?= =?utf-8?q?q9vwWO2izYWbbX9Bb+06K3yIm72aO7G7U7k4Q7Npj3j1gbyhwBPWAY4Z1F3mGROpU?= =?utf-8?q?G8METaLxZB56YONq8pFxnrkwcMhSMzmqP80dj3Wr3eStey72lVDsQtLKYxmzGPuI4?= =?utf-8?q?jsiOqCLm+dlDsoHrIpoV9xObWxyRyskrW/tUHZhxyr3OPNu3isJqO+GMFade1qvFo?= =?utf-8?q?+ZCWbhzY5uSIZzu21/pEsCZwdDcZ4OQCARw+0n46E+OYsDj8iI+7bKjHsL0PYlaFW?= =?utf-8?q?Hh+SJCxd2UzHDJCi4ZK2+Y9mpCI3VgSkVkQg2i5f5I5UwCe1E7f/Bk5UK3cTnsZc/?= =?utf-8?q?5SVSzMstEjfzBDRSyAOiFvwWxUhh77MEBkI+Ui0CY/XyCgsLzpJ148mcxM4IzLSLE?= =?utf-8?q?g2bEuYbZAj/aSZRd5163EZiWzQEMdHYQ7ZjirShehmGKl31QA1AV7BRcGG6EVoUmD?= =?utf-8?q?cA1poCIjiTc1/x0k4IuKhSUUBc32eVBHI9hF6Ld8zRd5khXJiybCRu4+yxucsgSNw?= =?utf-8?q?F93PMB/mrHD5i+2E8dr+41bWy6H+brvLF8A1JRGFfqFA879s7A3SnuH9XWuJ3RUlO?= =?utf-8?q?TJtXe7iDTt6cZISQI+jjueFH6Irlw35+sZiIMv9TKLJ8wL3Zl2wCDhmaapqWvIDUa?= =?utf-8?q?/UNCv4JLzmoemOJ6s6S/LrJaE2wrT/6i6WefLmvCTbPqZxmOnHIqOLidsOIIHQP6c?= =?utf-8?q?q5nXwy+NE5ocvbvmIv6V+oubtTA9qZtB1YjjZq086Uik67d38hLw6JKIB7fwXXej7?= =?utf-8?q?9qhXR7isspn+2YkiRKlnwQvh+Ip5Bw41sAt3IP+EZB0dVV0sI8cPK4yegVtFYiiNP?= =?utf-8?q?+mFFTO819PbiKVi+b0V2YFxkamQckuWjAa39wEzYD7S6KtSgpB+2m1B9CaxdfGprm?= =?utf-8?q?UqkkuEBYTqqm4Y0ljrugssNP4rzTlIdFDuYFZVNcafe0dgTWnYd2wapB4aWOQ44sU?= =?utf-8?q?3+y4i+/WfoJ1h9dvg1Sd5l6fDXjRGKMH0MC6sGA/YDy06tw1/GFB6B89sqWWqjMc4?= =?utf-8?q?5gjSf5DWnUBLVEA0nsMeN85EL1WF00srRsoB6nVkoxB2m2dCoSyH4zLDzfA6hc2I1?= =?utf-8?q?DYG0eKewk34edq+hO5FVvbVB9U2uCiDKn5FmDEpxIgEDv68oX+AZZgdh9C2+U8H/Y?= =?utf-8?q?HfgLmEsoAGdcDqmBhlj7bFJoj38HLF2cGzex4ERaGtIvActVdEjQLfiOu4DnmRgx4?= =?utf-8?q?wef9wsZqUVh9oL0X6p1BDfPoH+Di2nzMivFpaKw1zfTnvg73WnxhIUVtrC7vJU3Fw?= =?utf-8?q?uuEmW2IWMcl78GvOQLP7lFSYh4qgIkrUbklyos1QJE/V6V8P0r1056K1RihnP8HxB?= =?utf-8?q?5atRmN2AmL2BF4Zdae4tUI8tARw+DUJgw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:OS8PR06MB7663.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(52116014)(7416014)(376014)(366016)(1800799024)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?Jzo6+zzHKbtAGA5oWEBhrA73hekS?= =?utf-8?q?ZKGMlE0zAPaebFjj21eftahfsqDVS/lsohRzJSepjcJFY+dY4ZcIh5MQnvnfwfVSD?= =?utf-8?q?wY2n039n07Y8aaSMkdQbQUQW8KRZL1zSPCMCIh7xHjhIPcb+6ImX4nK1KiDL1d8uR?= =?utf-8?q?2y82/z9QZfEOFMy80ad5FUDKtbfvJ8q7vY6/bsQKF2YaGmgAWGZ+oYhHQv3qT9LHa?= =?utf-8?q?5kaI4E7eHdFAEWrgDQNUD5AZwLfk1mhIRJJdK/CorxCgSb1by4auPLTNHc35Qfle7?= =?utf-8?q?ubeuYg7QhPAaIM4plwRrf02LgG+3GQYYBrGv3u7Wd584uTQXfcHvgCaiSs0rxyb6M?= =?utf-8?q?W+BRwdjI+YotivAjTUxXr2dQbNFfMYWrY83qte286rvWl3EInGPbhC8kYQTet02Ih?= =?utf-8?q?OziQzSaVFT0gx9Bf7rcXDAMA32XSpNyb2nPNY5oxfvPX1AOo413q2deurFCo8398D?= =?utf-8?q?dPqAmsxcgFgKAMAVPyjpt6IVPTpyiOLzk6jEP+Mhzry+woUQZkNgkfm5PULkzHXGF?= =?utf-8?q?N+d2N+BylWkMLoLMqnxxPB6BU27dv2lC/acojlArwnAdapV/6XVejRdPTPAAXA1fG?= =?utf-8?q?0S6GYsQP0+bClB3mGUnhHgp6Z8ERnYY65pOXzf4Jdnxe2ZcH7ges/v0DACtwGUiBI?= =?utf-8?q?8PM9A4QY1gpNZQvd9Y/QpktQbk4poUMl6KKluvNPVH0f6NlvDn6jafBGnzLpx8bJt?= =?utf-8?q?u/NY0ArasnDFGmPuF/NHkeO1xlZ8fZJ8S58djG2QClYUFuzh6/biUfCMFx08O4lVu?= =?utf-8?q?+cxYQ9g+E4YbBygXd6RKdt0L0nGb7Qqw+qjE7aDN4/5fPbdEf5L/Vqh/nHnPRSePc?= =?utf-8?q?LdWBtWrMiKTTQBOqms6hQOYdWQPqAgv5EIQJSYNAy6fzDdbphSMMJ9Pk2m5G8OVu/?= =?utf-8?q?c3NnXQBIlVfup8xlG+Q31afpQ7N58dP6txwAiTGmsRIMc83xpK9ScEDyM11jbJaRR?= =?utf-8?q?Pe7opSa2rEckgeqoWDbxRVmpa6RcxlteKcw4D9pBOICDbIT/hAPzUoAaW0epan6MG?= =?utf-8?q?wV6hiQqXu/FZbxfnS7X6Ae7L8kbaUC6r1mcoOS4YrMGvHjaN6jjESsDbAch5lQ8hQ?= =?utf-8?q?DcdVM567pnz4XsbQ9wB5Y5eStVDq/m4qphF1981cr0Wshh5JNjBVkSxLkpbFXzVn4?= =?utf-8?q?c0qA8jLfL5LikWXK474hQrLzrsU5U+9uEllfqYWBK3dqK8+mcxZ9mL/ukeUgSgJNt?= =?utf-8?q?aAw2WboYNXdEXqjvT0F+SzRCw9ErBLHX6kMM5oCCd8+cHLHycRDWaPyYqSpAVg4Pr?= =?utf-8?q?YSFIkqTCxytOvmW0cBPNE1rMx0EgkVz0YHfJBV6tIDTF3VTPvZcDJzKiXadmKJ6DG?= =?utf-8?q?8tExZiLqN0qfEAqHk7C/QpVZV/fmO4CYMgVHSeHunWLoQsd83Y66PBkqjudLYuRWV?= =?utf-8?q?QJNewoEMJIqhYaBxZ4OR1Iz8RJMUxPIWd0H4FZ2ulPyRJjzAu2bEwuLrH/XB9W7A7?= =?utf-8?q?hnEiPahsMbdh3CoLTexSvNOF4NWH3NMZFw91cOG7KGkgKYgCVtYIUhY9r0LAB93st?= =?utf-8?q?D/OpfAE/Ht/b?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: ecf7c47f-4766-4c96-dae0-08ddb2532222 X-MS-Exchange-CrossTenant-AuthSource: OS8PR06MB7663.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2025 12:40:28.2964 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +jQiMt44yN/nt9zAFJCzR6VeOjCEoLOrWipztzmig2myzPiVcGm4o6B0H+SlBqexW8+LXIuVtiYCUVb9wZSyrg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SE3PR06MB8096 From: Yangtao Li The new devm_request_*irq_probe API prints an error message by default when the request fails, and consumers can provide custom error messages. Converting drivers to use this API has the following benefits: 1.More than 2,000 lines of code can be saved by removing redundant error messages in drivers. 2.Upper-layer functions can directly return error codes without missing debugging information. 3.Having proper and consistent information about why the device cannot be used is useful. Cc: Thomas Gleixner Cc: Krzysztof Kozlowski Cc: "Uwe Kleine-König" Cc: Jonathan Cameron Cc: AngeloGioacchino Del Regno Signed-off-by: Yangtao Li Signed-off-by: Pan Chuang --- drivers/thermal/max77620_thermal.c | 24 ++++++++++-------------- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/drivers/thermal/max77620_thermal.c b/drivers/thermal/max77620_thermal.c index 85a12e98d6dc..c425be81a1e6 100644 --- a/drivers/thermal/max77620_thermal.c +++ b/drivers/thermal/max77620_thermal.c @@ -117,23 +117,19 @@ static int max77620_thermal_probe(struct platform_device *pdev) if (IS_ERR(mtherm->tz_device)) return PTR_ERR(mtherm->tz_device); - ret = devm_request_threaded_irq(&pdev->dev, mtherm->irq_tjalarm1, NULL, - max77620_thermal_irq, - IRQF_ONESHOT | IRQF_SHARED, - dev_name(&pdev->dev), mtherm); - if (ret < 0) { - dev_err(&pdev->dev, "Failed to request irq1: %d\n", ret); + ret = devm_request_threaded_irq_probe(&pdev->dev, mtherm->irq_tjalarm1, NULL, + max77620_thermal_irq, + IRQF_ONESHOT | IRQF_SHARED, + dev_name(&pdev->dev), mtherm, "irq1"); + if (ret < 0) return ret; - } - ret = devm_request_threaded_irq(&pdev->dev, mtherm->irq_tjalarm2, NULL, - max77620_thermal_irq, - IRQF_ONESHOT | IRQF_SHARED, - dev_name(&pdev->dev), mtherm); - if (ret < 0) { - dev_err(&pdev->dev, "Failed to request irq2: %d\n", ret); + ret = devm_request_threaded_irq_probe(&pdev->dev, mtherm->irq_tjalarm2, NULL, + max77620_thermal_irq, + IRQF_ONESHOT | IRQF_SHARED, + dev_name(&pdev->dev), mtherm, "irq2"); + if (ret < 0) return ret; - } return 0; } From patchwork Mon Jun 23 12:41:17 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pan Chuang X-Patchwork-Id: 899632 Received: from TYPPR03CU001.outbound.protection.outlook.com (mail-japaneastazon11012048.outbound.protection.outlook.com [52.101.126.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BAB4324502E; Mon, 23 Jun 2025 12:41:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.126.48 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750682501; cv=fail; b=BJMt/Al/Ne5UXujy2+rBMWBMK9Mj626MIAwQHmcPjCSNbSAl2fS8Y5D1HQGhUcq+9rR3uezaryVz/EjCoZVf4rYN/58m5h4o2aJ4iyH5TtPtdVSnByX/S83jxt/VXAb9lQyzOv5q/jbrt/ctCxIOJWUiYi1tYL6wS9/5mtETyxc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750682501; c=relaxed/simple; bh=HDqoTVqfddamV68B3lhgw/7IoAkBbt4822cpc5oM98A=; h=From:To:Cc:Subject:Date:Message-Id:Content-Type:MIME-Version; b=MyAjHQY0upDSYMEsheihZ3Nid71f9hCpI05fciGJMmEGGWvjBpmv1vVWnvFzca0NlLYpFCgW88zSQx7cBIm21cdlw+bJl71pfHaEp+un+CCp1WOWWMFlLzcxkLTzLlbe+pzKIk7qBLVDx2w1AS97WkX+THOh/c5PuM85W/x3oE0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=gfPaZBSh; arc=fail smtp.client-ip=52.101.126.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="gfPaZBSh" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gd79OyqZFysNPZmqgaSSyXnhe9AcjL/Ale5Yt9SqjbZOW2iUkHH7CusqmKCF373cdww8qQKKC7oan3Oaj81aCAL2GbfzHdzJDkDI8x6t4a5Vs3ubXk3AcXBCXyeScIpMRpeYXRfEFJ6dqxDS65XA2H6pQCDYB5Myl8u9uTPvbNbVDCGkxQVP7yvuN3wPuO7khjbLA05DQvELOpC0AKy9g12OK50setmxTH6LQ1xCKkbZzkEU2/2QGI6qqkeDF2Xx7QjBMWAyZTmSEKRWXNNSChq1hveNM2ZyB8uKOhcIBryf9qP1TpdCrDmqLxuUJh//Dff5XloenLVlZ75F5xgh2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VJHVDgwiWvmvOxA6h/J4YopEOXPzSmTbgluUEuz0QQs=; b=KFP9kNyXeRBJVNRCebmGqt0fyLrfyYh22iBWpj9NFOPoDUi/8qFBjyZEuhZlG7M0w5gofy/bJ0rZ99sjiJyGb861/C0+0QMdl4IksEjlZ963kdGQg3WOM7iUb5/fnveXWdckstczXXryos0Z3PJc5mjhEbmwnsXJ0hyeceuqjsRcuRhx3VZPbe4numtqVcD/H3vemSethjVOEum5hDq1SYH9KCuGp9uiM5/myRS+KPg7fxNdGMGMro8+OitNU8OsORAkCVDtYdr+xTSn05GZsfmvbkJnH/cWnA0U3TeTy6FssgEDfpvZ3eGIzJyrL8GUWCF/YhxWLp93i290DZa4LQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VJHVDgwiWvmvOxA6h/J4YopEOXPzSmTbgluUEuz0QQs=; b=gfPaZBShI9Dq4RKkTWrggg4dTir2Pea4OkmDGmIdd2Je5StC99/zqBOzlRYEwYRcnbEVYa86Lfil3qy0QunRKUErFe/vbo10nIN9277Qxj6PROG6kLouAs22p1+mEVdYm3vzVpq2N7Q2MV0dkygEjh5WGw6PTFBfCyE2IXXqFWfPfCyfMvMelm9cIWXXiWzJfRaYy/HK6rKuERyI/SC0Sp4ibgAFC0C31Qg/J2zRLiTuDeOQSxGprPWJC8eMgJhd1u8yHfyfbaAdD4grZTOKeAuNr34DMj/AnpRnaQYcZpxY/2kTBI39Uq9eeQ5RNDHirEnUfz0m8ETMsRMZN7htNw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from OS8PR06MB7663.apcprd06.prod.outlook.com (2603:1096:604:2ac::8) by SE3PR06MB8096.apcprd06.prod.outlook.com (2603:1096:101:2e3::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.27; Mon, 23 Jun 2025 12:41:37 +0000 Received: from OS8PR06MB7663.apcprd06.prod.outlook.com ([fe80::46a5:9b06:416e:1e49]) by OS8PR06MB7663.apcprd06.prod.outlook.com ([fe80::46a5:9b06:416e:1e49%3]) with mapi id 15.20.8857.026; Mon, 23 Jun 2025 12:41:37 +0000 From: Pan Chuang To: "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Maxime Coquelin , Alexandre Torgue , Raphael Gallais-Pou , =?utf-8?q?Uwe_Kleine-K=C3=B6ni?= =?utf-8?q?g?= , Patrice Chotard , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Cc: Yangtao Li , Thomas Gleixner , Krzysztof Kozlowski , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Jonathan Cameron , AngeloGioacchino Del Regno , Pan Chuang Subject: [PATCH v6 18/24] thermal/drivers/stm: convert to use devm_request*_irq_probe() Date: Mon, 23 Jun 2025 20:41:17 +0800 Message-Id: <20250623124122.474673-1-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 X-ClientProxiedBy: SI1PR02CA0016.apcprd02.prod.outlook.com (2603:1096:4:1f4::17) To OS8PR06MB7663.apcprd06.prod.outlook.com (2603:1096:604:2ac::8) Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS8PR06MB7663:EE_|SE3PR06MB8096:EE_ X-MS-Office365-Filtering-Correlation-Id: 05a28713-e432-4faa-64a4-08ddb2534b36 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|52116014|7416014|376014|366016|1800799024|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?vg3Fy070fPq9rLCZ7JY4zcm2msXZFtR?= =?utf-8?q?PXv/Dwk2kF52DpkWkwpZfTeUrZ3tZyV3UJQ6TvCLZwtF9MnTmZC+wekc4dJ5hsSk4?= =?utf-8?q?GJvBvlHKUvncokixEioxWXSh5lOO5K+VPGP21JaEzUeOqzMhKyxRAOVy29leV89vF?= =?utf-8?q?J6Tcn/aTUf8qgR/1e7KKBrhCMmW5MICaj+DNIok9RKm3URysfJrx2isNZ64yGPuQB?= =?utf-8?q?qHrx0ZMMTW62d59zYLGYbK+lR12tFkNK1QnrLjWHKF0obDEpU0Oo4PY/74BYRYMWQ?= =?utf-8?q?bzNvmQMKsUTgqlwMvAksiN7uGHiTq6d5SbV63LcVPQLXU93SUpKYjEJZ1XfHPzCNm?= =?utf-8?q?r5md/EdVxR0XkqMBrbJ9yjoPXh4kcR3wdOCGTEuhJvhQvIvkXM/DtBIA7ehbhX8lo?= =?utf-8?q?8RYDyfEjyFx51cqlElCqJx/XcOg8cKGo3s1MxJa8+OYTjZZeBHH2jszli322id5Kk?= =?utf-8?q?TNxetF9CniZYVvzekYvIN6h+4uAKUa05vyAOTnPqb0KUDNyyFmbPue6s2ZaPN0oTH?= =?utf-8?q?EkaJJHsTXSJmdqA6RtQyLldxXbRwP6W8pRbU88Br8ZTdhp3xY87DJxaRRAZCmJTfX?= =?utf-8?q?Hv2wTMnnwEch8Wh+uiKpXmeZ8BHq14Mca4/GmYkjqjtq3V2DeFW41YxpWpTK53cWh?= =?utf-8?q?gDd0OhZcFl+5HHrR02hr9DKo1lVOQN697L8r7TvUANnboPALGX+ZiEX9GBl733Eh5?= =?utf-8?q?5B9AwE1xW1nPm/KgOh9YVA9fOozBJOYjdHTxzsGY/ERjnlT2aPyfcyX1dJ9IXKqpU?= =?utf-8?q?euguiCaQyZexkivW2ltOWuc1KGf88yCNvZkza05K+DHc/aYisfJRLjHPqvHJoEDFm?= =?utf-8?q?KHd8+IrlJboSD94rZeKbJ8dC/+UziLnITVpxzjiMOWLI1IWlDUbhAUxqEVyPXoZBw?= =?utf-8?q?FUWEYgu/ZLNfvrl9aVLA+7VZgtl7DfJsTN2grlp5Ud2oh0uYUru6SXC/rCTGGGljL?= =?utf-8?q?iCzP37OBLF2Va9UZPaHUqKqJXtdjNCot0WNxWX+QOPzsP4D0qvP3pYRoe5ELQO//y?= =?utf-8?q?DFFYgcmdTA/AOIh0Fb6TgQ5lSPovKKJGxBZkF65/gk/qh1NlqohOHjjrdz2O9XVs/?= =?utf-8?q?QL7O6otOecDBYIrM6q+O9TNOsbAqNrEn0RBmUIoxM+Y5qdhEggn/Ss3U4wfwxXz+/?= =?utf-8?q?5UnJUt2YwcIf4FjbWKrpEMaTk1y+jTRLdGmmRoS+0xT/LPgwhzYuwVY4mJK3tvqhc?= =?utf-8?q?XYgWjplWv6fxrc+SPnIofgrOOQWAxa59dLKxULo4b02stCR1kymbPkV8g88FHqIcY?= =?utf-8?q?b6SYrHca8hwpcQ96dKXhMKOzT10qkKmJNlUmcWb367aLf7X5DGpl7hH9eKQNc3jni?= =?utf-8?q?r408gUw9/MUdgdw6+ifCEbgBwfqnCwSQQJ/oTkVALinfXfKpdeWFEylsI0zXIDM0K?= =?utf-8?q?LpqkWY/vp8ymlQDXvHfxy1GRgOyOR2k2STSqojtky510NbCdpx6faw=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:OS8PR06MB7663.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(52116014)(7416014)(376014)(366016)(1800799024)(921020)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?FtHbsX0AfI3AcW0bjTvi4U27rIhB?= =?utf-8?q?K0QuVIQnIKFw4z/pa6qhXqC4eaPri8xzTQtXD0FCyaXrd6YgIkie9H6diUIbN7zKt?= =?utf-8?q?YUl8WdT0Q9SbGzfuCT7dJSC5IBSnaQXQzZvEKTZOScX+eDx5uSJbIa78QTuHjyUzq?= =?utf-8?q?3ahJrxQB+tGShvr0cadhAfsIPVG70lgLuWxHX1/UWwn8exbO3VhWOAOD5eLcDZ355?= =?utf-8?q?dectqza2jE7ynKUbSR7WrLNOLISeyLRLZ23WwlhS0bih1gb+3QAPpUbSGjq1W86Yg?= =?utf-8?q?2/Us5WEeh0NqFTuEbeA1Iz9Zomc6lzmonNSLudHrdzqUMXW3otqV+SQPgPHJIY68S?= =?utf-8?q?+2c8qtZKMt5+2P1C5PcZnDhRbDxV/qkVMFktvvoNx7d/nuvENOki6ep+cg27lF4Ru?= =?utf-8?q?b0G5875zvvdXPc6xpdg15SxA6RMq1WRfclLEvbBOak4ixkCxULfsK0NrfW1evgCbB?= =?utf-8?q?/vhJBVBGc32xjCZ389ayfdjs9TAncvks3KjXMjzrKP17D67H2UPD7jnT1HNvnu6bb?= =?utf-8?q?34khXQfSda6TyeOVKFAdGNduNKEwg3cCWzl9HzXV136JpGHe8CuGEBDgZWKc+4o2H?= =?utf-8?q?5drSgixgLYMCla1jUwgETjC5mViMFhFlYK8JexfhCU+OGc7GLG19Lxu/q8bfey7/i?= =?utf-8?q?pd9pxLpqpoja09+v9MX8UUdm8utemcfaNl9JsMLMVWbj02sKMWep+NOurTa03v8Jh?= =?utf-8?q?v6ICANrdmecgtymxlxBMvsfnnXcplvyTKpahEpODnhPG1wHC5yLUw64tcNlkEXnJ6?= =?utf-8?q?IHN8//17UK/QyLXUYixDTd//bzVHD/Uuj4lGXx3FkpRI8xtRzDDbyM1I+QaJ8wmBC?= =?utf-8?q?j+ALz9rO34Fz1XR4NKyh/oCJkKN/w+w9vT8xYHfsHSTWCX+X0154jyLtqVNjNc+lP?= =?utf-8?q?VQSxFSEGu0OT0WBfzui1QgAj+QrppyVybUxgvnDNKhWOctTxOmYrDeWX7S8gZ2J0R?= =?utf-8?q?tG0yBIlp6djClS3V4WJqDytwf0WoNGbhQXr+NLexEhfGMI3hKtH+GVSebhodJIPtC?= =?utf-8?q?vlplv20MCZF5Rr+7HzEKDA4DSHoOcoaa29M+WjG78HAI8ULUWn5cQr31fCAwJMt2q?= =?utf-8?q?DKTmjaARH4+/xUYQDkwH3W0KMuwCmheF2vADRvBNQr8Ppc3GhvoajZob+FWEdPrKq?= =?utf-8?q?nG7LLey4ARzRSqSocseU73w1dz9ziZjFtr2wYV1+9XFVTjKFxUEt1DzoNCdV2bowN?= =?utf-8?q?E5MoGy2FekK6J1LViggUAWDjCIdTfeY1LdE56AWLYDkBd/liqADFgs7E7O3huAy48?= =?utf-8?q?OWAFMgK5KcoAyNBuLXomem7c2J06WzNPl1oE+A6ShIPdRHiqecH8e7wM1HYXFSVMa?= =?utf-8?q?U4vIZ9aqV+R4NbJckUrHOy6b7lnSnJXbq0FX6xCfJl+NAeYLb+sdLSgv3FaTA18K5?= =?utf-8?q?9oB2mT5mHmpKW6J4VdaJcMUhQOMVob5s4WX0jUOCh1EMv1zghRfgxov261d4IKPKA?= =?utf-8?q?9Zq3V2WbvW3CKK8qjuM2GqqbtVchgtBBYKo3vejHbABMVpfavtOs59Dn0317ZdMc+?= =?utf-8?q?3e1KXXiHvldl?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 05a28713-e432-4faa-64a4-08ddb2534b36 X-MS-Exchange-CrossTenant-AuthSource: OS8PR06MB7663.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2025 12:41:37.2799 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Siklz3zFisNcSnIKLTgyTw6fFmq10IRet56WrL5SYwzwgFDuinNe6sJJodKR5GKhQJMf1oK87Vp5sjadcSLgPw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SE3PR06MB8096 From: Yangtao Li The new devm_request_*irq_probe API prints an error message by default when the request fails, and consumers can provide custom error messages. Converting drivers to use this API has the following benefits: 1.More than 2,000 lines of code can be saved by removing redundant error messages in drivers. 2.Upper-layer functions can directly return error codes without missing debugging information. 3.Having proper and consistent information about why the device cannot be used is useful. Cc: Thomas Gleixner Cc: Krzysztof Kozlowski Cc: "Uwe Kleine-König" Cc: Jonathan Cameron Cc: AngeloGioacchino Del Regno Signed-off-by: Yangtao Li Signed-off-by: Pan Chuang --- drivers/thermal/st/st_thermal_memmap.c | 12 +++++------- drivers/thermal/st/stm_thermal.c | 14 +++++--------- 2 files changed, 10 insertions(+), 16 deletions(-) diff --git a/drivers/thermal/st/st_thermal_memmap.c b/drivers/thermal/st/st_thermal_memmap.c index 8f76e50ea567..f0dac7a17883 100644 --- a/drivers/thermal/st/st_thermal_memmap.c +++ b/drivers/thermal/st/st_thermal_memmap.c @@ -97,14 +97,12 @@ static int st_mmap_register_enable_irq(struct st_thermal_sensor *sensor) if (sensor->irq < 0) return sensor->irq; - ret = devm_request_threaded_irq(dev, sensor->irq, - NULL, st_mmap_thermal_trip_handler, - IRQF_TRIGGER_RISING | IRQF_ONESHOT, - dev->driver->name, sensor); - if (ret) { - dev_err(dev, "failed to register IRQ %d\n", sensor->irq); + ret = devm_request_threaded_irq_probe(dev, sensor->irq, + NULL, st_mmap_thermal_trip_handler, + IRQF_TRIGGER_RISING | IRQF_ONESHOT, + dev->driver->name, sensor, NULL); + if (ret) return ret; - } return st_mmap_enable_irq(sensor); } diff --git a/drivers/thermal/st/stm_thermal.c b/drivers/thermal/st/stm_thermal.c index 6e90eb9f414d..267b86e2e8c3 100644 --- a/drivers/thermal/st/stm_thermal.c +++ b/drivers/thermal/st/stm_thermal.c @@ -385,16 +385,12 @@ static int stm_register_irq(struct stm_thermal_sensor *sensor) if (sensor->irq < 0) return sensor->irq; - ret = devm_request_threaded_irq(dev, sensor->irq, - NULL, - stm_thermal_irq_handler, - IRQF_ONESHOT, - dev->driver->name, sensor); - if (ret) { - dev_err(dev, "%s: Failed to register IRQ %d\n", __func__, - sensor->irq); + ret = devm_request_threaded_irq_probe(dev, sensor->irq, NULL, + stm_thermal_irq_handler, + IRQF_ONESHOT, + dev->driver->name, sensor, NULL); + if (ret) return ret; - } dev_dbg(dev, "%s: thermal IRQ registered", __func__); From patchwork Mon Jun 23 12:42:16 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pan Chuang X-Patchwork-Id: 899631 Received: from TYDPR03CU002.outbound.protection.outlook.com (mail-japaneastazon11013005.outbound.protection.outlook.com [52.101.127.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57F5C2417D1; Mon, 23 Jun 2025 12:42:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.127.5 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750682554; cv=fail; b=uLg6m0UBiAbnguIrq3Dbk4y7CV2T1JzdSvSXRGg97GB6tEnmcpU7LchrXFnFZ7HGKqYKJFZ56I0SHssg8on+r1VFwx8JzmEEhzV3FwN6yr4uxeto9f7JjPjJt+LP/1Xvu5yZX/K3ywIuIr02ENhaGoZnxH1sObSE/aFxdplw+xI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750682554; c=relaxed/simple; bh=8HSxXfItqCRjBiCW1mgwBE0gx6czQ9/W4EvXBl3OOxI=; h=From:To:Cc:Subject:Date:Message-Id:Content-Type:MIME-Version; b=RGkP1XLuoaEcfaWYOel79+4u730XTEjJpoxc2/0iIiL9mbEz3hLvRtsXC0CNVL6g0PxqEJj/iRdF8B9hU5OnW6CaLLGKtVN4UNmDUG/pW7ti8/yozDsqqqHz6D3/1najdF2NnyvIYAVqlkZfEFlZSYxr+LzXCsdMrBjfHQ/XWsY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=N8XikW6o; arc=fail smtp.client-ip=52.101.127.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="N8XikW6o" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vvDBxbkUipDP8jUooMun6GYIEQFJEDDMc5szRHGlb82IU0eIbJzujCrFoQYUS1uc4DHQfmeGTeFieo1x3Lffp3HxJ8oumkGvrobAsjpKLWPpbTZviw/a3wZt+cdWhlwmfTmvJWEvS3ai2rjiF27c9RdY76FFYrTMzZM1SFNF5YrQpsAlxSQJFqOa1s7p2hGCmnNEJsd28fZoEy6HwMQIwhg7p5TfmcvJTJOFzYQwqlMwzxqqb32GlY4PfzkoBupWTOwkbaA3QC9/rsbom6JJL5tUzuFpA2H6ne7rZGlMWekXhP4hX2eLESm0Y56cIGBdlzwv0Tj3aOTZyGMSMTmqaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=abc3Cii16sOfg5vsiw6Uys17OgCCdI5cJP599frfTr4=; b=qJ2gtPWu2VjX7RTVMUV7kGkc/a91jIDWfUG0EOkDFGc2WPCyYLYjjbv11Vlc01vvSpGc9SCkg8DuDnUHrEmWI30LT5YO2XqFnAXMWbVI4AX9qJBmDRB2Flw2R7ah5K5Wm8nCLzALOL8y7ZoChjhRDakzLN0RpzZSaw9Y362H5NJtgK75pRLx/O/Clbp8BLcbjoClql4azbEMMov51R+cAvaYx48l3qGPxFJa5m8TCikTJJNPfPPdUYlhyho5OrwV1iT/DytQONBdfYDFrXCbSgMAX0fTexjGpOi6gisK3Ilu5KgfSmDvEB6TDpEvUw11lgxMSIcM1lhZ+D2CZc5QFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=abc3Cii16sOfg5vsiw6Uys17OgCCdI5cJP599frfTr4=; b=N8XikW6oxZ0wnbvGVC1DHTMXpcSZpplkylrTLHwIic0PeX2KbGDQjq327wZofIdI0MCSQVTylFzIT3Y2ttgtIDOcGAAg7MHfiURXNAOAvxbg35aCccB/6lQ2PsL6U3DpR8axntsAZ2ogzOKQiR7iVGjTADDmOXsFBev0w6NBJI38DNReUn0SkcUQP5yfUA15dH7ScaGi+x61ysjqwhO/Teuk+So6RMJwpQG/gl0GS9y2Zb8qEf0BSFD+GTQvlCrSjvnIAthZW8D4cDOdqLnD26tGicpXMKqYaLwszFMkECifGVIJpWeYkMQoUd1v+vbulQjPoINF9Ps+WJQF2d52cA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from OS8PR06MB7663.apcprd06.prod.outlook.com (2603:1096:604:2ac::8) by SE3PR06MB8096.apcprd06.prod.outlook.com (2603:1096:101:2e3::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.27; Mon, 23 Jun 2025 12:42:30 +0000 Received: from OS8PR06MB7663.apcprd06.prod.outlook.com ([fe80::46a5:9b06:416e:1e49]) by OS8PR06MB7663.apcprd06.prod.outlook.com ([fe80::46a5:9b06:416e:1e49%3]) with mapi id 15.20.8857.026; Mon, 23 Jun 2025 12:42:29 +0000 From: Pan Chuang To: Amit Kucheria , Thara Gopinath , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Yangtao Li , Thomas Gleixner , Krzysztof Kozlowski , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Jonathan Cameron , AngeloGioacchino Del Regno , Dmitry Baryshkov , Pan Chuang Subject: [PATCH v6 20/24] thermal/drivers/qcom/spmi-adc-tm5: convert to use devm_request*_irq_probe() Date: Mon, 23 Jun 2025 20:42:16 +0800 Message-Id: <20250623124216.474893-1-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 X-ClientProxiedBy: SG2PR01CA0185.apcprd01.prod.exchangelabs.com (2603:1096:4:189::19) To OS8PR06MB7663.apcprd06.prod.outlook.com (2603:1096:604:2ac::8) Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS8PR06MB7663:EE_|SE3PR06MB8096:EE_ X-MS-Office365-Filtering-Correlation-Id: 7b84030b-3f27-48ce-ea73-08ddb2536a97 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|52116014|7416014|376014|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?yrAWQM3P+pBDFXyIxXgTgL2QBLrJyDT?= =?utf-8?q?2MNXVUYNEu4zfmp9q/xnKcOmXVjFXoN19Rfl4gjWtZCfidcUrkocP/OcBOZNzGOP8?= =?utf-8?q?HpdcpbHwLdn2rYCto/Q9UtXnTx6LXvO2fHyOD0FVzpDvKAI6IEyMZwyndY3SaamhR?= =?utf-8?q?6d5INkaoRGGu9SIJoprsp0g8Ct7Z3iF7dDlnog7riJHFB2rzReQLifkhipnCJQgA3?= =?utf-8?q?OGmvhE240KPDE/OGiBHEtd5+zb3bBhpvc2GEZFsa68A2r0lE4jSHqP44Jv5OJhroE?= =?utf-8?q?aJr1KxpSIjysZiZmsiqwAaxP5xpZbs/HeRUwZkDiFibRVXNuBTot0vLh1x+7UhE05?= =?utf-8?q?MLWNki+1wFf7OxyUAHduegJ5IPCELXI9Lq6lz4VvyVXkrPtLo6qt3q2tzHyb0UN3S?= =?utf-8?q?2cLIy4yfkVEgZV6zvZSt2SNI9JA/Z5vbvGxqP6vSiEachek4IihGXUVF5hGKxNz+t?= =?utf-8?q?C49k8STaPdyE7psQTtHhR3eURNWXaQ5aOBEQIf/pRmTrsh5GFmKphKGi2UjqXt0x9?= =?utf-8?q?15Bgze/qFKrtt3dBSEQO7/IlDXdTGeALNmDcgRjdxaT6UwB4aidH7WvLmXgfIrr8Q?= =?utf-8?q?GgAzyDKHstoLvo+OjgX303GfKLqq4N+W9rgWHBFbMcbTwOQTr6wP+sMK1wdG2USW5?= =?utf-8?q?kWSC/zJq7KsZ/0wWdvbcSOdX58hfTtA+qXs2NLctISxYGyXkz761q+H6Zr3JDh/Wc?= =?utf-8?q?FHOPf0hU3xMQ0+PzHTkBbpzuIJ8RHi9jCJmTRqb3eX6VrYaeufkCCuQeRt9n+1vZJ?= =?utf-8?q?5ta0FcVSh1h1rvNZjD1jQOhyiRvOYSbh4y+DnK7s0NMJdhC5rjSEVL9XmiG5n5I+U?= =?utf-8?q?uBadh50v2E+GZqVyZfE0Nbo8SmSEaMm3NQ5WvOLVkXu9p7G9vZxhC9pPLIJ1m2fOR?= =?utf-8?q?NiTw+bQPParORcIFb6B1uO4DBPw2yX0oWkkXFGZNWKabPtvI3mk4FBonP7p7SqxwK?= =?utf-8?q?BBco0esapTEZFJQBCB7ALb7KP356HdeIOg5FdrgGjtLFl9D+U20dVBCEDTeX2JdRb?= =?utf-8?q?ItVytSL+KLiTQ+VPOTZNMLSWNZV+P4xY1bjWG7lDqnncrqXeXJ2IGoZm5MjwrlvGF?= =?utf-8?q?K0y3fBxaUBZkS4pqUXXBj1hnlDyLK9ZpwOJDYDPziGXQAbxNPWIqRb7kZOU2rdDNP?= =?utf-8?q?vDlYZzDFk9n3Y6uQS35nXiyqm60Tek8aFXOc+OU5iSu86pg/PARksJCzSVXcaWuIS?= =?utf-8?q?jli969O8jtfRtAOglRLEu39riYI//AucoVl+W20rzH8gEVN5/nURipT5/TnYe01ow?= =?utf-8?q?9SD0iaGm0ppjKOHsIjnwm4L0ajerApySFhagO4nu2Q/ozY/FfYBEtSajH236v713R?= =?utf-8?q?Zlmx80kBuss18oyG4iYngxcTp/Bg5Sy1tCf13sXJsqvyHV8GEhVyONbaGYOiJlLZ1?= =?utf-8?q?/l5AnFCwDnkFQVvYKpXAcq2HzoHqxXI+w=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:OS8PR06MB7663.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(52116014)(7416014)(376014)(366016)(1800799024)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?/hso6WUtb4s/sZt+LtIWeIBy/xtK?= =?utf-8?q?/Bn5b8jQuEP5y8Cl66pXHzx7HZdHbbDzKciKA039e7Ljl5da5987rYBEN59VGO1/V?= =?utf-8?q?EbRH4HGslmGWEHyhTtWICtYgZpyYGeK4hcNx9wNbCaDnPbAXfobG0jdEySmr7h6Na?= =?utf-8?q?srHkftUoL3+poenK6l/RTBkddFZmbALmYWtjWHlIc+9vCBTiM0kQghZJH+yQWgivS?= =?utf-8?q?/NFd9WuQBmuKqcQ2YCrN7cT1c+hcg9N6pJZ7P+LKB6SLz3NfO0/ajVmYhznuxJ2iA?= =?utf-8?q?zrxVJ2R2Jl/yKpczy6YSFBXiUjadhu3mHz62OZlbI1W0xpg1JTeWNya+qVLKzbi4M?= =?utf-8?q?kAwoAmFdOxvDQIuNReQKyIU8JCxR35BcwxkWiADYC3lVGDLcuD4MRQlG3zLfbM42e?= =?utf-8?q?EWt7YXumS6TPWaHDNCscZNbZSUJKuZ8GE8ym/PwTSCKN3OkQpti4O4vNCvAgsFJmf?= =?utf-8?q?2eo4MAfAvwYFnxBGndGtV4OFD9ihJdTGZ6ZB7GVBgYvqveIfTkaE8t2i2bhefAFPC?= =?utf-8?q?0sCroNH2sXuftDFe9wz+sdhE+t4Ufi1GclOxWLLb/QsAy81+xXK7m/GiFeuspUbeB?= =?utf-8?q?Z7ROBqNzNoIMTsELAg5eC14aujsnlTV3xvJCbCwlhanqezoQBskIsjtXUf0Obwovw?= =?utf-8?q?u2nA3BUA9jwehRUyaB2tzdlY/TPdhLBcXa5YzQeF8nkVkaZatJMlC9QwQ6vnBKKDk?= =?utf-8?q?Y5SEkLVuXza1Xif3uMIIhMnfF4dmRFENv3OwZr1ZGpFF62xBr3AlIAA/82H30fgZs?= =?utf-8?q?tZKycgeqzmrBIlaBrO23ktlxfLh2HLXrWC0VbM5l9qLCuUoWOlEJnj/u0RrlXs6I7?= =?utf-8?q?r5MHSPuM55/Ii+fBqduLe7f2yDAyWPe6HnuSIa5PnE7Z/c53nkMK6caMNZRvMTCWv?= =?utf-8?q?95dGq2mTIfvRaneW02GGAaBF8UUvWWLXucQgCoBlaQaRwIUGtzlSMlA5Yn5ZTkZxK?= =?utf-8?q?roNwsoddR+iRG4288ftWvhMW3GhanWcHugdr5IdTH/bAkmcW20M8NHf40DL3q7hqt?= =?utf-8?q?U8HtozLEwRNaYrsi07gwNeG6I7qO++Z5oJTyqeFZ0Qd+NLBvevrlivh9B10IvlAgp?= =?utf-8?q?qvVJMkNPRXUkFS75VxKm8szELt2O+9nhQ9T763SvMCeQ2rS2buiAFQteiyX3COvqf?= =?utf-8?q?b7SXh5WCIpTButsoJ17QSsd0QYzkSpUEu5MNiyPegQaiuitacw9XreZSPSpZSTjkn?= =?utf-8?q?EN5WgjBoMx9yZjb5Lnv39yel/CUZgu3d1ZSmVQiMOe/A+KfQNm48wXiNewffACEuh?= =?utf-8?q?ejIfC0ZqJMkb648LVZ1kxbysRPPv1TR4nJjfjaFDFTLiIq0uYhAhT31GIiFYVxhNV?= =?utf-8?q?Uyl4VCqnNdIa7p57BdRvVPHxUqIyo390opmmLywx+6hj2POtIwrY+9dprabAHM/yu?= =?utf-8?q?mDy5DoDRvPTo8yKMLGDarmrkFeAR80oQ5670Fb9fFOsYU0NhWghaVaQzZGlGKerp7?= =?utf-8?q?ygqNvsA5D6J40lGqOIsqQn0vkQYoaC4fMbPfrYfYlH6elch6Cv8OegFPaukvfNbwd?= =?utf-8?q?g2+K8+yWlrH7?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7b84030b-3f27-48ce-ea73-08ddb2536a97 X-MS-Exchange-CrossTenant-AuthSource: OS8PR06MB7663.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2025 12:42:29.9083 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: h7koDVMFnnYx5dRSUxoGeJi0qgxLt3MU/54whcn1HEzE6Jku5sgyzndWto3Dn1aIdnnBwDad3XBbjsFkj+TzPA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SE3PR06MB8096 From: Yangtao Li The new devm_request_*irq_probe API prints an error message by default when the request fails, and consumers can provide custom error messages. Converting drivers to use this API has the following benefits: 1.More than 2,000 lines of code can be saved by removing redundant error messages in drivers. 2.Upper-layer functions can directly return error codes without missing debugging information. 3.Having proper and consistent information about why the device cannot be used is useful. Cc: Thomas Gleixner Cc: Krzysztof Kozlowski Cc: "Uwe Kleine-König" Cc: Jonathan Cameron Cc: AngeloGioacchino Del Regno Signed-off-by: Yangtao Li Reviewed-by: Dmitry Baryshkov Signed-off-by: Pan Chuang --- drivers/thermal/qcom/qcom-spmi-adc-tm5.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/thermal/qcom/qcom-spmi-adc-tm5.c b/drivers/thermal/qcom/qcom-spmi-adc-tm5.c index d7f2e6ca92c2..18c0ace7e5ed 100644 --- a/drivers/thermal/qcom/qcom-spmi-adc-tm5.c +++ b/drivers/thermal/qcom/qcom-spmi-adc-tm5.c @@ -1037,8 +1037,9 @@ static int adc_tm5_probe(struct platform_device *pdev) return ret; } - return devm_request_threaded_irq(dev, irq, NULL, adc_tm->data->isr, - IRQF_ONESHOT, adc_tm->data->irq_name, adc_tm); + return devm_request_threaded_irq_probe(dev, irq, NULL, adc_tm->data->isr, + IRQF_ONESHOT, adc_tm->data->irq_name, + adc_tm, NULL); } static const struct of_device_id adc_tm5_match_table[] = { From patchwork Mon Jun 23 12:42:57 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pan Chuang X-Patchwork-Id: 899630 Received: from TYDPR03CU002.outbound.protection.outlook.com (mail-japaneastazon11013064.outbound.protection.outlook.com [52.101.127.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49951248869; Mon, 23 Jun 2025 12:43:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.127.64 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750682593; cv=fail; b=pYaCP6qu8zHTo7ZnRJ1tb3ViHjjX2rl0IveXLXPVGKOhoJ6bk+tbq8ddQLAkmteP9457P9xVNXJx4LpWo0EGzZZUrCJQWBNjR9p4egrrVbyViwqxbzKeQ6MaP0J7TX85UyUgbTpGQex2FWiZAh7QT0vGaEsaC0buW7c0xwibCbk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750682593; c=relaxed/simple; bh=mtKABeNl9bsn6KpzM02VkMvjMWLJR2UXDz0RgpeaMPw=; h=From:To:Cc:Subject:Date:Message-Id:Content-Type:MIME-Version; b=NKfTPUOvwM4255N/6YTCr1VSprQo5fyftL3Vwt59t/fN8rOoKf8cpSC0vYe0BiStSAHINBdvI59/f5BjItl0qPg1y1g2zAPW6h4CcqF/XnRYngoDrdUtodZIfP1VtNVjU/q2s0xhGZoJ6UVIqAWkmvbwPyeNFJbDrD1qLC5e80g= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=SaZl12Cw; arc=fail smtp.client-ip=52.101.127.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="SaZl12Cw" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QvEuap8gp+KyXDQnQ62OuRibg22LNF9y0vr4C0ucrM5oQhdyMCNv7MM17tJ9rpjBwMlMf9vYvrABvdm8YG6VM55tPHgffuHEcTZjE/y8iEJ+DzyRLL1hEOhyIAH3qlWFaC/9GwU4O+2upn4R9mM6UVceKyY2A6YWklH6Kv0AMOL/hBY/XPx1Iz02MhSiPnOD4FO+Qv++97VwekemyrufXFyPp7S14G4PyooUDqJ0TkDpOpvRiFHo+hPKO4559DJqnX4ZKbuNd523fGR/vZ8qJggNQEzonYnbPR4s/mY8X58DhzQgunI9iKHSZHOMVZiMASHPeK6+tAeDYygQ2qsP1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XrdQYRzc4i6gQxXe/L3NrovTIRXD3dty8Sm3Fve1Uck=; b=Xd5FOmvpSTAjWzRBcVre5zA7/fwwzZaaolX2DmFI1Oa93POK5HAazrjFN0uuO4+Ii7wlHGHMInD3R/HglNJnUrCaNo0Q2XqBACUh4vO9c/o+FSnFbsi0tjpk7ASuIQ3x4M4YbYxyNr/RgsApRK+PBrZpqFVhLWK2w7QLh78wHN5jchf00lX2EAxSQiI3ZIe83dHzMsJ/Yq45AiZ9zhwu63lxNGVOPjsK9Hbg+jCL8XqHoOe9ayvYNZpwGLPi+xCyEiIyBAYuQWP3N/1t2RQ6GVIX2U9zG6FGaG2SAhSLPE7ejVK15SZvtkQKjOrggJ4uKmVMXH4d0Z7OJfxMKHzhxQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XrdQYRzc4i6gQxXe/L3NrovTIRXD3dty8Sm3Fve1Uck=; b=SaZl12Cwqfjqb+QzXcm1HN9JrItZLQ4fvHliqUxvCxXz8bV2ONrekTpSlHOk5ih+1XNWqi/yfD9aq4P3EW2mnZRbmeSNuHdWSqwvksiaz7NJwXukpP3Ycs7qF1hkr62hFW2vp7RDV2iCyL8ttzBzni2BgYLNZumuOyX+t2UWdIk9CBHwzKzpTyRwXtVWSyNx9XQYQ0AUKHhUik9o7DvPQsELgF+cdm7DjpG2cXTzt1La3efvSpqhfc2dzLLgF+sfuiOALtwIBD2q5zp1rs4z9YFo/OC7+EnWdgdmtj58u/iJqUMvTYrdgDUlllJ1m5ljKcjhD2Ng64ZCv9KSYD1RwQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from OS8PR06MB7663.apcprd06.prod.outlook.com (2603:1096:604:2ac::8) by SEZPR06MB6611.apcprd06.prod.outlook.com (2603:1096:101:18a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.28; Mon, 23 Jun 2025 12:43:07 +0000 Received: from OS8PR06MB7663.apcprd06.prod.outlook.com ([fe80::46a5:9b06:416e:1e49]) by OS8PR06MB7663.apcprd06.prod.outlook.com ([fe80::46a5:9b06:416e:1e49%3]) with mapi id 15.20.8857.026; Mon, 23 Jun 2025 12:43:07 +0000 From: Pan Chuang To: "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , linux-pm@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Yangtao Li , Thomas Gleixner , Krzysztof Kozlowski , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Jonathan Cameron , AngeloGioacchino Del Regno , Pan Chuang Subject: [PATCH v6 22/24] thermal/drivers/imx: convert to use devm_request*_irq_probe() Date: Mon, 23 Jun 2025 20:42:57 +0800 Message-Id: <20250623124257.475083-1-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 X-ClientProxiedBy: TY4P286CA0020.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:2b0::13) To OS8PR06MB7663.apcprd06.prod.outlook.com (2603:1096:604:2ac::8) Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS8PR06MB7663:EE_|SEZPR06MB6611:EE_ X-MS-Office365-Filtering-Correlation-Id: 44a0fcd0-ee84-41d1-0547-08ddb253811f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|52116014|366016|7416014|376014|1800799024|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?q?Hlx8ABzPNogxq2UPUvR+05MKCj88PU3?= =?utf-8?q?AtZohXHCQ8NXYCjzpMX8bwWZui70oalruNq6gTq2O0XK3dinI+s+bVbO3afm2nO0u?= =?utf-8?q?WgcMvzDv1y9lVxC05vTUwwqWODbcgyqDyhfZsJTi/C56V+m92nJwOgF6+oWy2OnhO?= =?utf-8?q?bfCS8ORQsMH9tCCzJjMvlJnqf1sEAg4qN87FbBRUAMpRkIgS2srF69XpULFG9JXmz?= =?utf-8?q?CHsYp0N7hZNSVjUExFJpJjNUHpLjsqkMmxAAa0hM4iVERvAc2C/8q1OYu6tQKqpF+?= =?utf-8?q?YcxP+iuS3UaRmFSP0PP8k/OX/IdbyeuxAZ2wZ6tJ2yV4nxAuLC4WrCSdhzwk3Icwe?= =?utf-8?q?lQH1V3RzPnnGSn7ifMH9ZPLd2rXQBjAzb7SHmEqsR1Kkdfvak7XwIA/esCZHJDjJI?= =?utf-8?q?O0tpquRDzm4hZ6SflmPYanLwaz/enJPtQ2DqskZY3vyiA/Ve77XdDCmb0iiNFixXp?= =?utf-8?q?i9oTt1b0KvMLbdjbgqh0k9BcVotzMSDL5D48kV+15qExzMVTT65uYYZBEKsy+GBR6?= =?utf-8?q?EQhMjy16m2eXYRUYQPF8LialhpCVv9EQn5yMinXdcXoWadDf9ykQ/4g2iCKJLInZb?= =?utf-8?q?zeHzEBT6z9ZMwwuzerrL9MfAvaXvvKqSM1lx8fA7GUMSUdnb+LZaO1xU6D86fBocI?= =?utf-8?q?VSGYjNEoSZl+g3/7LyV9bRU2BEV1DBimqKp0vvLVaQWTviBGAytIHCLm/1GGYrHrP?= =?utf-8?q?5R1Jt0XeSeNdAt8BWIFkzUF92MyvEDL3y3F+rSpzJZqpN1DZ0nq3/es/Cg8J79LPk?= =?utf-8?q?NZP7ckmxXbpQxvELmAFmYu+g6USrFCr77buqa65AfYpEsmnWil2qpvbM62lyAjoh+?= =?utf-8?q?pKOB+tYCn6Rp/isZx1+HDzSH65K1qBSmhWPrZgvLWruqcozpKLLDJUrSoWrRIzcUJ?= =?utf-8?q?cttWKqirHJGEX6Yzxu4YIid51fBILQ940W+ZxyBRw+fxAp8+pGL7okBvK++lezPy/?= =?utf-8?q?sVRiWJFRM3kv2wQUci0hguhpmqYMi3zf/HW5odWHy6ZYB0GHRbsZyDtFjEvDfugh5?= =?utf-8?q?SzOxW7Daxb1TgzVUhVH6VjeyuDRJjprU8abWrlrAwzTy9D0uuRIY6b/bOJf7Oyyq9?= =?utf-8?q?gFLAwgvKdKmz00kxlanO0FMaS50T38d+pUQAV5snvXkb1m2bTncPucJgB+Z49NpUa?= =?utf-8?q?qPY4ciBV3yqHtOikER8NlBipcOq+VoulwV2SS10diAqZRUXWZGhHs4dWuCR+ep3Kb?= =?utf-8?q?+Vlhzlr0l1buvTJYnvxPTHOgxKoFSUUdBuLhpzq9a23Eu1XWZKg2JHl7VkOWglAFo?= =?utf-8?q?RO5odgkjDq6wyhYpRcMhlor/X3t1o+6Me/7dhZVo+6oCuKjduw7FH7xiJs86i2E2E?= =?utf-8?q?Na22xDODPossM6+4gVj+I81vqxJZTPWd/wdNgnsl+521bFXKFJXm7gx4Dc3K5lt0N?= =?utf-8?q?j6t5qF9TYMGoerjjHGIq7qCI8q9JjDKv9KunGgUNj4xGh3J/XgiQkE=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:OS8PR06MB7663.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(52116014)(366016)(7416014)(376014)(1800799024)(38350700014)(921020); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?qrYLJaoa1d4n1nOsXDcfyh00s9Zf?= =?utf-8?q?WE5R6oZgITEWDCPPPBRs8jkgexszZCQa8JMHuZR1dogcGxtVV3bYQ2dOTlWtuByuN?= =?utf-8?q?MmTZ2fX1UwGGECbek+wheiqocuXZgFVfFauQ2EVRyaAdxc2f28u6zHubqk5zLh7Aj?= =?utf-8?q?XqYYQjb8/bOCCiounqfGg+RfWt2Sh8dQnCUnow83wjThrxo4hZwkCn4nAYrMqkuje?= =?utf-8?q?c3Dusa3zYt0l/1FMQpUJc1BPjsFTkEP+2ogmsMWAUWSAEeoTtdnYbL32TVs7azcWU?= =?utf-8?q?h8gSy/X8atMEeJr31FGzha/Xp/g5+TPjykZsnMc9tHbXttGienRao6+L6lcMcYQ8A?= =?utf-8?q?hk4MZVJBaNxL3Z+awDGmrPHxRtr3K6tv9x4RM8eGYVHoomZwQXNg3M2MZFFcYidjQ?= =?utf-8?q?WZjm6zFUZdELUEPWxaMjAnFZZ8qP3+sDiGQChxL8/Uvvt8fWVfQuzjx5loQKKt4J3?= =?utf-8?q?v0CSB/0mlJHDdpRv1N2vI7BrL2uV1brZnDQi41XywPyYgeu7ZWHZDEayPkR/Ik8lO?= =?utf-8?q?Dlerj85noBULpDwh2zTrEFerREqEXpLursKYByAQ08AVPlZB7LdRP3G/L5mIBtDcx?= =?utf-8?q?etetMFbb+HkKDZQTG3SNUxpHQRyrHMh8gYYAVzwoZjGSHTiv1bB3CmDYjbUE6w9Wz?= =?utf-8?q?25ng3SSMO5tb1WF0eOOzpp7ZxVpCRXpu2/ng/Enpj7JIlr4/6gVFrbZptAsRkMKjP?= =?utf-8?q?xunehUL/CrLUjL2qZJNWOdZjvDbT8vuAkvGSqFYC4yBcUcffDDQi/sO9l8MSpxK8V?= =?utf-8?q?2kiGchv4ArsY0j1+6fJV7alJWxPp/fcpttrA/Y4zrAt95VVNHOL8KkluYcDhlMsSO?= =?utf-8?q?i8NIew7CE3niBvIMiwFDfsZMTk/M7d7tTKzubkF7pLbR3J6lbsL+OhfCeKdLbVuao?= =?utf-8?q?1eXteFi5FLSpivo9fbgvFj3DCmZJi6mdIQvfRDibTtHqstK8NsJjdUhFRQXI8gqrL?= =?utf-8?q?/upzB3ZlOyx0CB/ckPg2UaaVGd+UzsRr4NOxFvBFBCdgn3E/F6pLRNC7rpG7lhAXI?= =?utf-8?q?iqd2Qov15VEge0PGw/LtnN8+xqs4qNeDIUM2PNOc0iHY2qXQNH0bLEMREdDVpA/1b?= =?utf-8?q?ph+tjGR0bNLxubjORtQNXu15Gm7vQyLQPJzKdcQd+xJFlxuPU486KC8OLZvQ9pXM8?= =?utf-8?q?TmfDy17LQnVZ//pJm9687mjuYz/9T1ULbIka6P/R3flccF5ldodWICho5LVXEHMNg?= =?utf-8?q?VBjPuzqXofv6HClsP2p0s1Wt0hUnnEIJtXBe6hRuBjCPop5aNBbvTYNo2mRdu/wxm?= =?utf-8?q?yLqm0e198Oo+K39nFhcL1Pzu4kEN3ndERWqBIJ4jEAyVyKMTZWoYebKPcOqHysD2b?= =?utf-8?q?rlkiDwj71wCuAcFF0G1//LNteP+9XILdUhUW2RNz0XhEXDt6QvSS9Z5+DFDo5iQju?= =?utf-8?q?5UdnOLY1/MBarSk/Cjr0SYWxhxKyaBwbIkwoOtupSrOLTuwn3QD4OpabJfnaCxkTQ?= =?utf-8?q?7mKfLYknp9iRiyVYOx9+I/1qougwlPkT+IKIG9nVF93CiuGqrTvuhlgiwCY1A4jGN?= =?utf-8?q?0t2N+42Id/m+?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 44a0fcd0-ee84-41d1-0547-08ddb253811f X-MS-Exchange-CrossTenant-AuthSource: OS8PR06MB7663.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2025 12:43:07.6770 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tg32qEwa3U4FZhGPDubLC6mZexaXe6TGAQsynMP23YGcI4IyTyM8C9Ex9hUaafQUPMvgjRexLrJOlG25paxDIg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR06MB6611 From: Yangtao Li The new devm_request_*irq_probe API prints an error message by default when the request fails, and consumers can provide custom error messages. Converting drivers to use this API has the following benefits: 1.More than 2,000 lines of code can be saved by removing redundant error messages in drivers. 2.Upper-layer functions can directly return error codes without missing debugging information. 3.Having proper and consistent information about why the device cannot be used is useful. Cc: Thomas Gleixner Cc: Krzysztof Kozlowski Cc: "Uwe Kleine-König" Cc: Jonathan Cameron Cc: AngeloGioacchino Del Regno Signed-off-by: Yangtao Li Signed-off-by: Pan Chuang --- drivers/thermal/imx_thermal.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/thermal/imx_thermal.c b/drivers/thermal/imx_thermal.c index bab52e6b3b15..151976d0820e 100644 --- a/drivers/thermal/imx_thermal.c +++ b/drivers/thermal/imx_thermal.c @@ -729,13 +729,12 @@ static int imx_thermal_probe(struct platform_device *pdev) if (ret) goto thermal_zone_unregister; - ret = devm_request_threaded_irq(dev, data->irq, - imx_thermal_alarm_irq, imx_thermal_alarm_irq_thread, - 0, "imx_thermal", data); - if (ret < 0) { - dev_err(dev, "failed to request alarm irq: %d\n", ret); + ret = devm_request_threaded_irq_probe(dev, data->irq, + imx_thermal_alarm_irq, + imx_thermal_alarm_irq_thread, + 0, "imx_thermal", data, "alarm"); + if (ret < 0) goto thermal_zone_unregister; - } pm_runtime_put(data->dev); From patchwork Mon Jun 23 12:43:29 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pan Chuang X-Patchwork-Id: 899629 Received: from TYDPR03CU002.outbound.protection.outlook.com (mail-japaneastazon11013010.outbound.protection.outlook.com [52.101.127.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD8B324888D; Mon, 23 Jun 2025 12:43:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.127.10 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750682626; cv=fail; b=lBPsW5uQpCSjc9ElkqVVEXzeLiuzOaU/KP/5oOzaeoZp2hc/+/8zIwW20/Br4+99APG4o6Y9X7kjzPuBJdu1LD2xteiKoLVwgCXb1O0UVHf5hnLgoPm+kRM7nBph1nQ4jo9+la2q/vpk2b81tMMrf+7Ci3iMJN13A/IEEtVSraY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750682626; c=relaxed/simple; bh=qv72uYWMjNnjUaDROC60KRs9nT8l2gVgXpP/GOyR0iQ=; h=From:To:Cc:Subject:Date:Message-Id:Content-Type:MIME-Version; b=TXqJshaxKAozOhgauiQVhDzjy4TqHT5H+8ZyijEsDvZgQut55d3CtqD6+5K9y1mCaRNpvWXl2k+n9S5PR2iyLiSVoSQzAiS+TG0J5rZCWAU+KyXKAXMYUaDydV7vu4/Q7QzEiBPcPVWKNKwwJ/mW6Ffon959p4P13NA0QpA8mMw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=FjYVJoUA; arc=fail smtp.client-ip=52.101.127.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="FjYVJoUA" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ABc17AJJ00v2WsCqV3rPo1eLpO+Hx2vZFXNgncIGfpkm6RsC5h+Thu98dAbDG9sD78fMjuhxUEEA2T/iCC2dMhcAsyTDTdjHHZL3HHJtz+Z+4tQqaIOK0b8JdOBHGgZCx8OPHoMokcxiNAF0/6utDzuavlozu0Rl6aQCqcWB6X0sutJA7ogSSLuq9W1mUsgWWWg3ey/QD9xdaG5yeHgr6noS2pPWM7odCI+H1yz6aD6eWhBTPUjUC6H9x8PM/1N8bbDmhkAPWMNEmvYd+Pd/GczUq/tLoFSi4C4UiXWv9N8GYEXMHZFg6xjAI5Ki9/jzJzX1dN483BH97B03OTOsJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m55j4/lBNEAJFpgAHXZuEtDyuLAH4bvJbs0juv3TjVc=; b=FnyYJ7TJl2css9CBA5M77HaWpCFXd7CpWYELY3RdIKAiSS3t+A0MdIv9Krt/gFik8ydX6pBlp6+rsuOmzdkx6Zn8w1Kj5H5wJpV76s2jQi+P86Cx6SFpHw1haXZiUPkdwryyEywMeXjSmK3WiB6FxCDEEzV/+WeGjsM0ahQstX8MoIE4nOk9sxxbUxqS73sE3xltQR/9ny5AR2wb9+Kp0WiH9LX6Hg3ze9w1GNJAdl9yERDUjXdwyvTMuVmifhmjeVk9kKwmCI94akQ1OSM8Z+cxKe6VHLSApFc5LjqnJfGiMkPPYzQ34+X08+qkEZsx/3l4h0m9IMKf0wqZMQMuFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m55j4/lBNEAJFpgAHXZuEtDyuLAH4bvJbs0juv3TjVc=; b=FjYVJoUAg3EUwnxbd7nkN2YwBFEDzLMieoCvopBWI2PVAjY6LK7c8Vql1r+lx7wB9kyoRDprY2jrF39p43+aLuPqlkJv8kEtF8yysVgpykGAU7OeEYq0wDNzordyWyj9itTg3OOU6bd3dRXi22AsHwMz0j4Xw3NwEht5xsuLLOUIwiJ9wOsDkMTZ1qF4KHl50tsFQUgGInmBPHWy2rWQTnML8Bw2n+y89hFQ8YkS59Xqr5MejnjsV5YCTPC8mW6pXqrjFL3hC+0JBgS3SkHOx7+9XGHfz7HK7uQwlQMXjG74dPtqkW8InqEy8XpwRTTqSsParq46/KtW6r18L+pINg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from OS8PR06MB7663.apcprd06.prod.outlook.com (2603:1096:604:2ac::8) by SEZPR06MB6611.apcprd06.prod.outlook.com (2603:1096:101:18a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.28; Mon, 23 Jun 2025 12:43:42 +0000 Received: from OS8PR06MB7663.apcprd06.prod.outlook.com ([fe80::46a5:9b06:416e:1e49]) by OS8PR06MB7663.apcprd06.prod.outlook.com ([fe80::46a5:9b06:416e:1e49%3]) with mapi id 15.20.8857.026; Mon, 23 Jun 2025 12:43:42 +0000 From: Pan Chuang To: "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: frank.li@vivo.com, Pan Chuang , Thomas Gleixner , Krzysztof Kozlowski , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Jonathan Cameron , AngeloGioacchino Del Regno Subject: [PATCH v6 24/24] thermal/drivers/airoha: convert to use devm_request*_irq_probe() Date: Mon, 23 Jun 2025 20:43:29 +0800 Message-Id: <20250623124329.475147-1-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 X-ClientProxiedBy: SI2PR02CA0048.apcprd02.prod.outlook.com (2603:1096:4:196::23) To OS8PR06MB7663.apcprd06.prod.outlook.com (2603:1096:604:2ac::8) Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS8PR06MB7663:EE_|SEZPR06MB6611:EE_ X-MS-Office365-Filtering-Correlation-Id: 04b2f066-59a7-433e-11f9-08ddb25395bb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|52116014|366016|7416014|376014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?JlxOR3FGtr2Vj7E+50xTxrY8fpYmoGm?= =?utf-8?q?2Ykt5Hb5FNtDnmks039oRO5rK2E7pk/P3+CJFowz4V0l8VUJV7F5wqd4FrCnukCgE?= =?utf-8?q?0SDtYEfnfxmsYoCXKXtTW1h3eHdAdLApQId476/W9ZIcRubNyIF6RepF6HuPCyVcw?= =?utf-8?q?ONYs6Z/gUUKdCROANIHjALYbpBzUrO5pHWwOn1nVZBAaGVgACcAKWCB8dj3WvtjIZ?= =?utf-8?q?5kGNmAukhHRMJEd4EZEO8W8eaGA9lILWQ2NNrP/VLR9+52kfPvhbTgvcolicdcGEV?= =?utf-8?q?Fq9IDiVdPvnmQVFASGhtEkIbJcAbj9glCrBcZOx0Yk2mYkUrAES26c3og5k4KASRt?= =?utf-8?q?VJBeaop70PvitdUOoS2M2N9qciz+m3ipvB5Qzuy3QGCh0DE7sH+T1dw6B8ZNochsK?= =?utf-8?q?/7EYhz98cy1WKUruyDpCpySW3u5bsUuEFoeMyRfwVmWj2YHI6ARnKVwMJ+SLmtiqJ?= =?utf-8?q?HR7xNTHA7NAhBCHsvqAPM3Lg3tZlRY6cbC1rbe6ydiGVy8lTbq+q/sGJH4HNygz7E?= =?utf-8?q?QA7sZ+2T1r77WZj1dJdEqZop6iMs/CBmOQ1/GvmLOmwHyzjYqmgmT6g/hlXRqhfo3?= =?utf-8?q?C9MytX6Tr0XWLEmmsYh5BCr8ZWzZn8SXJjiG2UuFOXp7UVOqCSQnaanXE7T1uuI+W?= =?utf-8?q?NuY7GhEBqzI4Vr5P0ADktmqbp2wuPMyZMh15TMHFEcTridzmowAHc56kPkWxyNezf?= =?utf-8?q?iJ5FX0kgnYRL+MU6TG63XwJxy7VM7DfDCelXAuk3QBIDCvi9tqVl+a/fVa/9sDEOR?= =?utf-8?q?PMn/6iCeU69r6UMEK8E6M8zIubrOp/Uxmb6ql4wfws3x9Bee27g+fxtPHOrYKUlp2?= =?utf-8?q?Ws0W+ilZkowxxyjcPq/DXrFfmxFdWQQwZxl48+t2NYjhaQHBoeTIX/T6UL4ugLQj4?= =?utf-8?q?0uzCamj8+jhvxSsvLn6IZ8kn2yuPMDimiYe9tt5rdz3vkhRL9/3pFbIy5hYT8SmN5?= =?utf-8?q?EXPkykwm4e4YNo21rSG/Y5bR1v4cu+3kpsZ4wnsMzXYdXq66LL7hECa+TlJUyFgpk?= =?utf-8?q?C4UYlMWR7rLe+yzFcRgNuqN7C6dn4KeN/3fXs/woG8yDGwgshFsMK5YAMX3F46zvw?= =?utf-8?q?xmEbG9f5eO/JO7+C6mUO5SDwVR+1tf5oirScnChWTiK/8MR9pngtIhvQlSdDV/BMy?= =?utf-8?q?mwKI9yVXTEfsPhKjzwU/zLDAYROxenXRa6CtGFHCgofVl18G2v4P5GB2VmJASF2So?= =?utf-8?q?gZHiMrS6PLbvMbv/ldU8c+nQZPsFZke0ryKg7G9tbdMp5eflAHfXdUr2Cd7NVyu3u?= =?utf-8?q?is4E/WmbmEHabGTZFuNjWw+QUJoxFXlM74tEzkICAz24BKWBx+QpYrV8czJJPwGEe?= =?utf-8?q?Hyl26Ly2jLD1YuAybXsi5qQZwUlvibRJYrofSc2TB3akBXDKaCtpqzLFwsHuvMACi?= =?utf-8?q?z0d30mk3eRvBNFD1iIJxg/pnEV15o6xIQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:OS8PR06MB7663.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(52116014)(366016)(7416014)(376014)(1800799024)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?qv0cj5QQfnHvgQu7+Jo8ls2zUq30?= =?utf-8?q?3elN2jh6V2xMj+osxmyjqXEKAM+43r04x4HpPkxKXJJbfjGihJScnwijlJ8O5VKuv?= =?utf-8?q?FOj9rAboZ2iKlYRIovievtnPcNJyYEbDhETJd8iPYPwd2/T8DyCA7Vdlv548sN4xS?= =?utf-8?q?1il43ASFzjZFQ8uUUewZbKpPnqrSGgJT0TfZHzumawX4tzrnMlzlVtTzwxBJnHrbk?= =?utf-8?q?Rr7sZRdUIzXmyDJow0R26RAgs8dp0Sbm3gGapbJiskM7uOkTUpaLAlVdLgp7Z/35L?= =?utf-8?q?6lueNrknbOlEq+vde9gOEuWybqYo5nVBp7ZveyDHL9mdJc01nMxQQfHHDKQvqjNwI?= =?utf-8?q?A5eSxliNwSBuybb8yFZp0c2F5a6yIz1o+ZaB7blcwOyJdPC+y4pf2qJeszrccvTG3?= =?utf-8?q?ty2rPuxwJXsxp2cfMXmk+jJATdWlPXinPMA8i17Zc296UOhUYQaf/XyJfDlWormFm?= =?utf-8?q?QSorFjPkxge+GLsfU03cKFDdydwt+NeyDul4MxDKURjpW9Vu2+oF9n/E1grwQJ/tI?= =?utf-8?q?ZpFzORDiZBpkNHYOGZajgNHBaKQ/O9PG5YVdnJHwSdv0DoJcYtBPgMqjPanhvHHYz?= =?utf-8?q?+UJB4IARc06k8DexqwkusUZwM9Mtsb4zpcxRagTbN2ILWdrjpU81s3u9PvA65TxBI?= =?utf-8?q?lExepB3NE6cG+md6Ck2FKkg5ch12FNI+j7ll0qLy+FYNsuAHhTMF9H+wj/n+qv94c?= =?utf-8?q?NjMBZ1MCrfhMUu9dVhrDOYgK7eC/viwFG2Ym+98J6HqqBRh0LHTOf/8xvR4WrO4BZ?= =?utf-8?q?Iwltc3K2Jqm+155KUkLZzDP6uj2VMkP7tJmZTkpj7khiOtbIkNCPk2J3OWrgj0MyG?= =?utf-8?q?IQO9CBz+iwSV/6qyR+wbz6G7e5GD/bUJccCeVq0AAFb7uTarurechPeG5hoDHtGog?= =?utf-8?q?PL8Z78nZPxS+3zmnPiudox0YZNmrxvvOSrSH5OHfdNITWGaex5owIYRbHc72gyKrD?= =?utf-8?q?Bf8o+/vysi40CcL1RpF32puhrkG6aZAKRqELrDpOZeheuzx2+0wBuk5FkXQlOeC0u?= =?utf-8?q?uzfjXbtg5O5/nIOCz5hP90VYBE2z9ZGinyV71LVRwOsWbI5/Rfegen6bEcV0mjhVQ?= =?utf-8?q?Ns9itxLRLVchQZ3JzlZ3zc4xFjrk4x7A2bBtl1sIcIsmJ5tfqXohqWlYnCoRuKAqD?= =?utf-8?q?3UNSsfoK20LeBVsxOdFmIRyfBIOj3p0iN2SJEFKuMFKaepJOLafteLMXcsP25XT8X?= =?utf-8?q?MwPm6v5mcrUGuvTCzd5IHL1wc/df7MGJqRE0PkTXatg+N7Np/Q1mTpgof75Xt0adm?= =?utf-8?q?FajDZZkaCUq0X9/8LUQWWKfCbmJcD/edE/Ir8C9LcUyFKlGqz8jjNmChFCpDHYpmx?= =?utf-8?q?oOba4hGn/IDfgS6MueWptG4Yld1IlvyGZzmGFT6gQ4pgLkSqHou9b3GQuv/2P1/00?= =?utf-8?q?zfhsJHAPmpj4fc/tSWQS+46njFfR67Dv9uW1Fcnd1qpJVZGI7luyuiagJIHtbw9cd?= =?utf-8?q?4hUDi2eaqFoO06QU7BOElAAZf4LY9MTrYa2g6Dvx+URrY1P8y9hia5oInbzTV1o+8?= =?utf-8?q?boeA7mROPfl1?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 04b2f066-59a7-433e-11f9-08ddb25395bb X-MS-Exchange-CrossTenant-AuthSource: OS8PR06MB7663.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2025 12:43:42.3334 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UGtQ8GPa+MVyv35MgorhQzEWKWq6tGcA+C4R6w5HZblTYCzu5gHcLEakgbf67jV+gViWA0Fl4Oop8Gk1R30sTA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR06MB6611 The new devm_request_*irq_probe API prints an error message by default when the request fails, and consumers can provide custom error messages. Converting drivers to use this API has the following benefits: 1.More than 2,000 lines of code can be saved by removing redundant error messages in drivers. 2.Upper-layer functions can directly return error codes without missing debugging information. 3.Having proper and consistent information about why the device cannot be used is useful. Cc: Thomas Gleixner Cc: Krzysztof Kozlowski Cc: "Uwe Kleine-König" Cc: Jonathan Cameron Cc: AngeloGioacchino Del Regno Signed-off-by: Pan Chuang --- drivers/thermal/airoha_thermal.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/thermal/airoha_thermal.c b/drivers/thermal/airoha_thermal.c index b9fd6bfc88e5..6918043c8630 100644 --- a/drivers/thermal/airoha_thermal.c +++ b/drivers/thermal/airoha_thermal.c @@ -441,13 +441,11 @@ static int airoha_thermal_probe(struct platform_device *pdev) if (irq < 0) return irq; - ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, - airoha_thermal_irq, IRQF_ONESHOT, - pdev->name, priv); - if (ret) { - dev_err(dev, "Can't get interrupt working.\n"); + ret = devm_request_threaded_irq_probe(&pdev->dev, irq, NULL, + airoha_thermal_irq, IRQF_ONESHOT, + pdev->name, priv, NULL); + if (ret) return ret; - } airoha_thermal_setup_monitor(priv); airoha_thermal_setup_adc_val(dev, priv);