From patchwork Thu Jun 25 06:46:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 191727 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp539013ilg; Wed, 24 Jun 2020 23:46:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwAx71EPlNrXa7eHwqXEsXOQSnxmcef9plMf3ekKR1cMeAZ0OvuXCXyw3mBn2EIBl/zJB9k X-Received: by 2002:a05:6402:1d18:: with SMTP id dg24mr5082420edb.33.1593067587569; Wed, 24 Jun 2020 23:46:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593067587; cv=none; d=google.com; s=arc-20160816; b=lZan1HF/nQtsz6QZlcHUnYj3csOZ4asABxI6Hz4N+ybRU7XMJ/BaTrVG/NoDquAw8I /BeTfo0SLFxtDG0RIIMvYvo+Lx/LWgboqFfKoFZY8v1wpFlrOaj9BuRcO6u2r7VpI83U q9WtWYlq0XCW2vwcFyKNzUjW/W+d6GBrt4sQxNsEVCtIetWr+YebkbRasuXuu/bqEMZq ny72LKnfRoSfGttVWf6gyQB69062bO1BsoTntsupzRGL8ZQ9cGXXUj2jXDC8JsZuk0LE Zt+7+SUru1OO4P1+uYGzoQ7xW40kZijR9LDTzxKXj4Epg8KAB/yW2Jn5ctTnwok3K3JA SFdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=L7/cDxvGdffp0R1d8Bbrv1z7a+JwOkzEK0KwjgT2NxE=; b=cKziOii8wXxDolngwoU7DPTsRpiHAXtwZMcDiEJRIRQC7cdnLWze+VeLpROYSBw9ku RR6/20q9afDU5PwOU9rSLnd9Pu6MHfikXCA8eMFvNugJXIrNARYrZC4yLWwE12tWl0n3 4AX4LUp8a/JrGAjKF12wiLMrEoF2u/BXSclP6vH1dgg/AN+5Fj3M4jwQLQzpymwnNOhX KmZ+IZmkjQuOjmpRaiphnbbCue+pdGPhp71ELeS+b+Qk4PgZ8UifK1+qLTyftgAtNz1K Jb8oHdRXEe5CeZjwSo9oEHMNylpLjp+FsZgVcPRY8r83t0bpSFgwqD28WweXviH/mILy LRTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BCmUEtT5; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ce16si6319319edb.550.2020.06.24.23.46.26; Wed, 24 Jun 2020 23:46:27 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BCmUEtT5; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390108AbgFYGq0 (ORCPT + 15 others); Thu, 25 Jun 2020 02:46:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389962AbgFYGqZ (ORCPT ); Thu, 25 Jun 2020 02:46:25 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 195A2C061573 for ; Wed, 24 Jun 2020 23:46:25 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id a6so4611139wrm.4 for ; Wed, 24 Jun 2020 23:46:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=L7/cDxvGdffp0R1d8Bbrv1z7a+JwOkzEK0KwjgT2NxE=; b=BCmUEtT5UTfVuC8CblpswRBGT7MKphCIGdncmeha98yeFZF1RxkE4l+xGv/tGqHYum OA7y8Haiw+RQimK4Bda7ht6soHr43nbRuSKpQJKow84aunLep803VCuEqWLD4Pw5JD0X 96eXzyQsx45dx26MXUnpGnDy3jpxvAk/wDI/hOHxeUYKXagFUmKRFRU2OagSbsHl0qGt 3hqH62/Q/B/G57ZQng+i5vaGJeaL08Uf6dM6WYvSIGm4WjFfLQhGVxxCjI7i1u91A4xL YpMRNTBntLVloYGvv2ibyEIZ80NwV+J19HiToZeKVO4vSmFhN16plNct104f+WeRmk81 jkJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=L7/cDxvGdffp0R1d8Bbrv1z7a+JwOkzEK0KwjgT2NxE=; b=Q3N8SdrnQKXKMsX46W9kHEQqgEh5EgUnbB8Bb/RzbIJjHs5jQkl3QaUjmRKQb52avu S/A05fzUHpywr5FK6W83yipDblr8oGBm9H1mSNV6z1r5tnn2RzXyuq7+2fbC4+TQGtzJ t3jZYK6hNvcXalRZHtawCRRALDk0wZmjyM/H1knp3MWQ2twQbxF+oTG9ibYQMXM4mLxT uhNImdPLPrfTo/NpA1fE+yzr/EcrIJIFTZZAFWZ3K51G+fc6BfKbbtjFngd5niWu1Z88 uRTs9Ps18M8fFTjN3nDOm7TlCozHmvw2BV2KQ6VK9NUUIqyYy9/RSw3EfaG8vS0VfoQg nFrQ== X-Gm-Message-State: AOAM5311n0LvJy+N2SPX4wBhZpumTF6MVJLaknQERQJM9M96RDK5YeII IXvp/VA9zpTwBRU/H+8HWsAJqw== X-Received: by 2002:adf:8b18:: with SMTP id n24mr37002049wra.372.1593067583753; Wed, 24 Jun 2020 23:46:23 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id c20sm27235363wrb.65.2020.06.24.23.46.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 23:46:23 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, patches@opensource.cirrus.com Subject: [PATCH 01/10] mfd: wm8350-core: Supply description wm8350_reg_{un}lock args Date: Thu, 25 Jun 2020 07:46:10 +0100 Message-Id: <20200625064619.2775707-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200625064619.2775707-1-lee.jones@linaro.org> References: <20200625064619.2775707-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Kerneldoc syntax is used, but not complete. Descriptions required. Prevents warnings like: drivers/mfd/wm8350-core.c:136: warning: Function parameter or member 'wm8350' not described in 'wm8350_reg_lock' drivers/mfd/wm8350-core.c:165: warning: Function parameter or member 'wm8350' not described in 'wm8350_reg_unlock' Cc: Cc: patches@opensource.cirrus.com Signed-off-by: Lee Jones --- drivers/mfd/wm8350-core.c | 4 ++++ 1 file changed, 4 insertions(+) -- 2.25.1 diff --git a/drivers/mfd/wm8350-core.c b/drivers/mfd/wm8350-core.c index 42b16503e6cd1..fbc77b218215c 100644 --- a/drivers/mfd/wm8350-core.c +++ b/drivers/mfd/wm8350-core.c @@ -131,6 +131,8 @@ EXPORT_SYMBOL_GPL(wm8350_block_write); * The WM8350 has a hardware lock which can be used to prevent writes to * some registers (generally those which can cause particularly serious * problems if misused). This function enables that lock. + * + * @wm8350: pointer to local driver data structure */ int wm8350_reg_lock(struct wm8350 *wm8350) { @@ -160,6 +162,8 @@ EXPORT_SYMBOL_GPL(wm8350_reg_lock); * problems if misused). This function disables that lock so updates * can be performed. For maximum safety this should be done only when * required. + * + * @wm8350: pointer to local driver data structure */ int wm8350_reg_unlock(struct wm8350 *wm8350) { From patchwork Thu Jun 25 06:46:11 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 191737 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp539573ilg; Wed, 24 Jun 2020 23:47:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwkIZLeivS+rpTQGV/6lhGzFbFeWlck0XQ9e/kWyAocUxBZJ4/eKlp8gtHaE3NMpIJqcDys X-Received: by 2002:a17:907:9c4:: with SMTP id bx4mr1398918ejc.495.1593067635462; Wed, 24 Jun 2020 23:47:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593067635; cv=none; d=google.com; s=arc-20160816; b=1Ei+cVITfKx7Pnrcw6ion66aCNImnDMoz0iv+UZZWT15m/M/5VXtP6x1XaxKs7A32a Zbpm0h6qrs9v5+PJGkNeeu8aZTYgFwHO8YbGR9Plz/ImuHndR4c9hQhrCTjlqRCdv398 BPXnbswl0XaymPSeatXI9J9sQ4FlZSEFN5HhUvJD8hfU/B0exF6Na9AmMDQQp00cMAXt 4IX85oLV20wzBjlTGhdgMH8fHy19mz5arf+bdvtpU5P7MCMyhyM6mvflYZXavWgQY9Eq I7rvjpPahc9W4XWD7xvUBWvAfeQETp87gYbq6ZIbfeXGR/DuikIg3Ln5LS0Bsx8EotQq 2xxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=gpZUopdNGKoMuokzA38cWTWHt4qMbyx0+mhPHuM+Znc=; b=PmtXu64girpgS2uGxRWo9/SwccENuMVkIUAY+j9Kc9zOXtDwM1L0gIfTGeiEAQyItr DcaAjp3qLtmzsNSrk+iWy/+RQlV93MGxnQkXANJus8LPOV6r0FZFyKfpGDy6Tm4mrTar wsZzBRhyxunCheocP4t0CDqzr9cRI4aRbJZnrJjt9NWkAlBnQiyLPnQXlZErcPk1mxUZ 3a3ZYomY5Ga0JHAmlzUW+REnX+FZvuhWpzJDMO0J5HCy+z6MizODOBOO5MBElrbr1Qvs cenas7HcnHNGjrBQOxM1sdom14lOZJ7OIX8TLTsXyOhRJiVKZbEwck52cjpBwKrIgOBZ w6kg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=L3gPi0V6; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id de28si13600184edb.492.2020.06.24.23.47.15; Wed, 24 Jun 2020 23:47:15 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=L3gPi0V6; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390330AbgFYGrK (ORCPT + 15 others); Thu, 25 Jun 2020 02:47:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390115AbgFYGq1 (ORCPT ); Thu, 25 Jun 2020 02:46:27 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41A40C061795 for ; Wed, 24 Jun 2020 23:46:26 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id j94so4637121wrj.0 for ; Wed, 24 Jun 2020 23:46:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gpZUopdNGKoMuokzA38cWTWHt4qMbyx0+mhPHuM+Znc=; b=L3gPi0V6eWwUbjc0a7NWVYNxvmyjxoCjIHRVwhhbx3/PgBUBX1nYVYjjVo442aXOq1 6X+Rxq4jGsIwLTCBZApP2Rl/SureSgHXIaYxg9LovDj+bhfSXt3hSv90MX1xjfcHLEbP pizWIa2VTBVMWI6eNMnPoO4qath3LnLnEPgrrJ4dAIBvozmxRyuEBNn35Sv9RQVY/0Lg hVqcXYlSA2h6mWAEMsGoEiG/cyjNbXgHy0dMkxXGJQjFqwHHP6PZSwCZU5izFBVnfokC WU1eXhZiZYr6t2/pu9Ce3tAAE6tpfZME71ChHW0a72v/TfEzY4id8vKP2OrKnEGANJQQ 3D8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gpZUopdNGKoMuokzA38cWTWHt4qMbyx0+mhPHuM+Znc=; b=KUP+3woGFhpw5QicIno2c900b9Lta94j5t1v6Tl0O0ixtCrnSnc8TwB6GREtMEJmJ6 X/eHLWWYCODCy96piCkS96M3KWBpl/DglqWIY6eAB8lr/IwYUKgkiLhYBiwf9dbwV4QW qugNkHx94Ka3xyTHyKzhcAC+rE19zsD2Wlrxvf0d1NXWqRpvtmiY3dZyrgHJweqeZZAX bO3jzGz8ezkGS6WIf0ToRJ/vpncqaGg7iLIxR6RBVDaltHG3K08JnWZ7hhaTVv6hq4DT bIZx3RfPraGVEplwEAt/Qe6mr/NM/wybbw85Z9j1j6RxNzMU3097LFT3VPMtsETH5FC+ D44A== X-Gm-Message-State: AOAM530IvUUbIb7fC5IQhmcWeBdyTNmvaiwp5Franoq7/d+jrAGy62Z9 dn6apsbxXC1emuASPxxnV38Nyg== X-Received: by 2002:a5d:62cd:: with SMTP id o13mr23631593wrv.272.1593067584905; Wed, 24 Jun 2020 23:46:24 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id c20sm27235363wrb.65.2020.06.24.23.46.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 23:46:24 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH 02/10] mfd: mfd-core: Complete kerneldoc header for devm_mfd_add_devices() Date: Thu, 25 Jun 2020 07:46:11 +0100 Message-Id: <20200625064619.2775707-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200625064619.2775707-1-lee.jones@linaro.org> References: <20200625064619.2775707-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Each function parameter should be documented in kerneldoc format. Squashes the following W=1 warnings: drivers/mfd/mfd-core.c:326: warning: Function parameter or member 'dev' not described in 'devm_mfd_add_devices' drivers/mfd/mfd-core.c:326: warning: Function parameter or member 'id' not described in 'devm_mfd_add_devices' drivers/mfd/mfd-core.c:326: warning: Function parameter or member 'cells' not described in 'devm_mfd_add_devices' drivers/mfd/mfd-core.c:326: warning: Function parameter or member 'n_devs' not described in 'devm_mfd_add_devices' drivers/mfd/mfd-core.c:326: warning: Function parameter or member 'mem_base' not described in 'devm_mfd_add_devices' drivers/mfd/mfd-core.c:326: warning: Function parameter or member 'irq_base' not described in 'devm_mfd_add_devices' drivers/mfd/mfd-core.c:326: warning: Function parameter or member 'domain' not described in 'devm_mfd_add_devices' Cc: Signed-off-by: Lee Jones --- drivers/mfd/mfd-core.c | 10 ++++++++++ 1 file changed, 10 insertions(+) -- 2.25.1 diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c index f5a73af60dd40..720e5c8b1588c 100644 --- a/drivers/mfd/mfd-core.c +++ b/drivers/mfd/mfd-core.c @@ -318,6 +318,16 @@ static void devm_mfd_dev_release(struct device *dev, void *res) * Returns 0 on success or an appropriate negative error number on failure. * All child-devices of the MFD will automatically be removed when it gets * unbinded. + * + * @dev: Pointer to parent device. + * @id: Can be PLATFORM_DEVID_AUTO to let the Platform API take care + * of device numbering, or will be added to a device's cell_id. + * @cells: Array of (struct mfd_cell)s describing child devices. + * @n_devs: Number of child devices to register. + * @mem_base: Parent register range resource for child devices. + * @irq_base: Base of the range of virtual interrupt numbers allocated for + * this MFD device. Unused if @domain is specified. + * @domain: Interrupt domain to create mappings for hardware interrupts. */ int devm_mfd_add_devices(struct device *dev, int id, const struct mfd_cell *cells, int n_devs, From patchwork Thu Jun 25 06:46:12 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 191728 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp539068ilg; Wed, 24 Jun 2020 23:46:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwpg57FXD0Ak0cDe2BtDh65ZigOYgItn2+wICCpt5RfXlCyNdeTIR7+sVmHg4+1w/JKu8o5 X-Received: by 2002:a17:906:3c4c:: with SMTP id i12mr27430331ejg.464.1593067593373; Wed, 24 Jun 2020 23:46:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593067593; cv=none; d=google.com; s=arc-20160816; b=WLubVGFMEcphpeqfWx+5JIie2tCS25LQ8BlE3HIkE/z8ikD/0hq99B4h09yd3UJTJk YWqqos3h/+9vPA//x8aOP7eKyjKuA7Exrg9NCAVYPO8sihZZ32CHDQHlgtk21rQct3Qz TqWjxMTfPxBHiKibXK2Y5K8SVmGm6AwvjMr2InIQuitrlA/Mc1QF2RRZvwCKCJDk6nuS yuGC95lGcXKrahQcBPdkKFbPJ95p1Y4AE93K8poLtxOwGlh1lmGVrhHkqnNRwMXVof7I Rv296C+hv9pHm1Yitw/Tu4r6aq+OBCdmW0iT3Q9F7cyO8iCFoTU5+M3li5L6nx/w7dSL TqtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=1zDIqOBuX/K9nmAOrSn0q1L2wjLhGu0LGpqC1FRybjM=; b=Uc6ibfNyXsgJzvyaHOkPHEdC/ljowehcpnfBEFxT60mqYs21h4VF6xF4G6tuYrcJj7 hLagKAHGBFchmgsoxAx2qOpv1Ql1vi+WNHPWKzq6wz/ryLHB3uc0YpKYAKvOa+4wkUlm uUuu8cFa0LK0e6v/UsSUMIDd0LtTaVxbIpMT8IgBdk2h5orUyZlszhIex2IqJsIMUOeS OJHkODNUGb29vMICUWl58fikHxZGW/Pw804+hSh1Qckzcpn+OFKDaUDG980pJN+dD4W2 roExkJjWXUeQkonl0oFIMyANQRAdGKJespFMGr153Cc7cgYYfwSZfQvpL8FPCJEwi1XY 0KVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Y8Xeawii; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p8si3036113ejf.634.2020.06.24.23.46.33; Wed, 24 Jun 2020 23:46:33 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Y8Xeawii; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390150AbgFYGqb (ORCPT + 15 others); Thu, 25 Jun 2020 02:46:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60122 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390139AbgFYGq3 (ORCPT ); Thu, 25 Jun 2020 02:46:29 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BEDCC0613ED for ; Wed, 24 Jun 2020 23:46:28 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id r12so4559738wrj.13 for ; Wed, 24 Jun 2020 23:46:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1zDIqOBuX/K9nmAOrSn0q1L2wjLhGu0LGpqC1FRybjM=; b=Y8Xeawii/FenN4QcJc/IU0tymI/82VPhOUVQnNDaPq1E1ZUSPPJGiqS/MwnjdXwHqF DvzQqbo+ZusoZvWe7XMRMfOASefHh3I5kfGUIJesheA46gvTr9m5Bqd+xZteU8fuyZhP JSMH36/+uTAtUSckplXY/J74fUfskmrkT+h4Rhi+lPqKjkcu4Wns0XCu97A4qjsByUoy jz6zZaDVI542NxSheQJrNCq2C4ZWaDr3ZAnsBJYX3DPUVqApykF4HUHAiUYbaN/9wj+i v6qGmM7UjH2mb2rrDfpY33gZQo57z3084ZjyupmsBOU9C1cwoWJFWcQi9s8RezQqnSAO XnhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1zDIqOBuX/K9nmAOrSn0q1L2wjLhGu0LGpqC1FRybjM=; b=ggkaTmvxoeD82/Bv+tUp5AUVBVYGNE34etDpi1dvIsDcNOxsXL+UDub2m0gQdSx9RR AwThVt73qfBa8afSKeS9QQBf70BxlxZQIpAby3PYKlRP7aAxEsoYRn5SK4/0FZjnt6jh 9XpooTkkRDyuNXKF1vJgUSV+L32G7sOyHyClakmze6pVly63D2JCPxoAmIJBqiHmqzvh cLb+W3SELp0vxqCKUl/XhK8tTGpN8/R66SxgE0whie0BnXVjFO/UF2qVz224slvRvm2Q AuudYfghpk/QJgn08UXDPZJB1ED9B7Nh5Y4iHEH37LCRuVt4JAVDlXGTjblRtoG2Wk7Z mF6Q== X-Gm-Message-State: AOAM530BvntTWDOy0bm0wKSIVGmK1JYJeC21gDZCerUkpInQeujbPgpi iLtexd0ijJzFV31nfX7ghuVOVXYwK7U= X-Received: by 2002:adf:828b:: with SMTP id 11mr37504223wrc.58.1593067586920; Wed, 24 Jun 2020 23:46:26 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id c20sm27235363wrb.65.2020.06.24.23.46.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 23:46:26 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Linus Walleij Subject: [PATCH 03/10] mfd: db8500-prcmu: Add description for 'reset_reason' in kerneldoc Date: Thu, 25 Jun 2020 07:46:12 +0100 Message-Id: <20200625064619.2775707-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200625064619.2775707-1-lee.jones@linaro.org> References: <20200625064619.2775707-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Each function parameter should be documented in kerneldoc format. Squashes the following W=1 warnings: drivers/mfd/db8500-prcmu.c:2281: warning: Function parameter or member 'reset_code' not described in 'db8500_prcmu_system_reset' drivers/mfd/db8500-prcmu.c:3012: warning: Function parameter or member 'pdev' not described in 'db8500_prcmu_probe' Cc: Cc: Linus Walleij Signed-off-by: Lee Jones --- drivers/mfd/db8500-prcmu.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.25.1 Reviewed-by: Linus Walleij diff --git a/drivers/mfd/db8500-prcmu.c b/drivers/mfd/db8500-prcmu.c index 0452b43b04232..9b58b02967638 100644 --- a/drivers/mfd/db8500-prcmu.c +++ b/drivers/mfd/db8500-prcmu.c @@ -2276,6 +2276,8 @@ bool db8500_prcmu_is_ac_wake_requested(void) * * Saves the reset reason code and then sets the APE_SOFTRST register which * fires interrupt to fw + * + * @reset_code: The reason for system reset */ void db8500_prcmu_system_reset(u16 reset_code) { From patchwork Thu Jun 25 06:46:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 191729 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp539100ilg; Wed, 24 Jun 2020 23:46:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyFC6AEJhvOSsboBF/8zecxfBvpTckNL+g8N/o4waa4sh89szeGcKJ2eNbrt6z85L5abWlY X-Received: by 2002:a17:906:4d13:: with SMTP id r19mr27917630eju.45.1593067595623; Wed, 24 Jun 2020 23:46:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593067595; cv=none; d=google.com; s=arc-20160816; b=vGi//ep93IwWFq8wfu1RDdqRgHrdAKebo/r4E/NyEhKlrpVyHI0o7S93FddL/JKep4 0jcwQv73GD5pDR0RNQC+v1uo2yUtd25F5kMo+AoOn+0Sjcgcu8+25zEXRPIaIRtUZ94a 3fk6zKyKC5SSheqKAvVrIx4SKmuSTXIN3ARjWj3HkuTi0Wr7TKJe9qcifTDa78r6Xqs2 Uhpel2DZ1w36ZAkrf6q8xzbRGnWo2RT08f2Rqhxqa8JxGCOjr2QpjDgk8akKBuAOS+BW NTJBpf0/+vtiXvZSQ44g+83/ArR7fAZure2LLLKPY4GsF6Rd66w2Ilm6omS3ry82x+Pb FehQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=o2mKsGbb/PtyAVg9ggk1Hz11lyz25s2kgotXpuPO+cU=; b=oIqsTZZ0a3fp+tGO/KgjfVtWKnLlLjaEhkOgztpD1NDTy/zz19qhxBVsgJb4jPorLC LoHDl8VXNaF9oMn0DYhgZdny6892DuUWz37drFRX7mfipvGzK5Fq/0O/Ldsj3pobsygx b6rMtkZnsn5wOjFpe3KK+ET53WRiw4jPZvYKrbbetMGMuKD9cjLou8EbndFMTvUuOkm1 7555RmhkqZlBa01FDsNyvy5DCXkUA7uUjqyH3+RR8z/S3uF3DbToXyWH7g1ijarGFoaE btmuaKw7AUu1zr36T7pn3lK+B95blBps75aYdH7FRuEGkbXDt0vDc5Yp9Qi43IVc+7mo Qxhg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=va0D27Lt; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p8si3036113ejf.634.2020.06.24.23.46.35; Wed, 24 Jun 2020 23:46:35 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=va0D27Lt; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390154AbgFYGqe (ORCPT + 15 others); Thu, 25 Jun 2020 02:46:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390110AbgFYGqc (ORCPT ); Thu, 25 Jun 2020 02:46:32 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04BD5C0613ED for ; Wed, 24 Jun 2020 23:46:32 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id o8so4416756wmh.4 for ; Wed, 24 Jun 2020 23:46:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=o2mKsGbb/PtyAVg9ggk1Hz11lyz25s2kgotXpuPO+cU=; b=va0D27LtDcF26UdSeyL0kkvFbOHBO1SeIpvY5r8WAMDpK/CuCoK6gWg7iSvitAeRaA ryg7SmradwXnqeEyywbJGFve2MOz/IujZphJ+CKI08KZftt8JvUgjx3ALYfqDAdSExgd HFdT4fk2Ys9jpWVzhGrmy6a9OlzwxMTl/hUthhMkgSFKi1SIOa6GcBG9oyZcebXLBZip m41Z5wANw8Seya5ZA7FXHiz7X8tSKqWX8afSxQcytVP36TcVt6gAXVYiuDMDmDzfss/o IYL49zByXMBr9NcuNAqRE9msPHvNrfyCmu1lgqgRm+/WycTKKMpJ0a+kxAcG5smLTvte pT5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=o2mKsGbb/PtyAVg9ggk1Hz11lyz25s2kgotXpuPO+cU=; b=L2ylShsk629NnX3dTmg+6BGl+Mi0nrn6jmb09q9OLm940/lYX1Gp8L37DYJHSXZ7fV KUzYQ9jMsLQAL0b6Qvk0Ph1gFijm15zZ3ZsvXZyT36Y7ZtgpWYMhDZmvRHPMJGm3Thl4 KWhhhqFZxPhWBKB0eb12TXd3yNnYSCoo1Z/V3y2EwSpLZPHv6nPxYmCHa23DMuui5TPb oaFZ7CTB231vROmRkvqpdCKgkotxFqoEBs9jxvHGvaiZf1wAfuXpRLrX79x8Rzj6tnrV f5QbdVzQiY1h/zzVAZ/CG5u+w9ukA71Mld6ZLL5zp6/HcYlztrt+aISIHT3me8uloS4i NXbg== X-Gm-Message-State: AOAM530JZMrWS3L4OSbruZMOilj6twUMGKmNJXkQsVGV37yESeibPW7V H6cdYIuyFHV4KOEG9hp2XpNV/A== X-Received: by 2002:a1c:2901:: with SMTP id p1mr1744242wmp.144.1593067590752; Wed, 24 Jun 2020 23:46:30 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id c20sm27235363wrb.65.2020.06.24.23.46.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 23:46:30 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Linus Walleij Subject: [PATCH 04/10] mfd: db8500-prcmu: Remove incorrect function header from .probe() function Date: Thu, 25 Jun 2020 07:46:13 +0100 Message-Id: <20200625064619.2775707-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200625064619.2775707-1-lee.jones@linaro.org> References: <20200625064619.2775707-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Not only is the current header incorrect, the isn't actually a need to document the ubiquitous platform probe call. Cc: Cc: Linus Walleij Signed-off-by: Lee Jones --- drivers/mfd/db8500-prcmu.c | 4 ---- 1 file changed, 4 deletions(-) -- 2.25.1 Reviewed-by: Linus Walleij diff --git a/drivers/mfd/db8500-prcmu.c b/drivers/mfd/db8500-prcmu.c index 9b58b02967638..a9d9c1cdf546b 100644 --- a/drivers/mfd/db8500-prcmu.c +++ b/drivers/mfd/db8500-prcmu.c @@ -3006,10 +3006,6 @@ static int db8500_prcmu_register_ab8500(struct device *parent) return mfd_add_devices(parent, 0, ab850x_cell, 1, NULL, 0, NULL); } -/** - * prcmu_fw_init - arch init call for the Linux PRCMU fw init logic - * - */ static int db8500_prcmu_probe(struct platform_device *pdev) { struct device_node *np = pdev->dev.of_node; From patchwork Thu Jun 25 06:46:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 223012 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D483C433E0 for ; Thu, 25 Jun 2020 06:47:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 54C1620773 for ; Thu, 25 Jun 2020 06:47:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jAVR5eoy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390167AbgFYGqf (ORCPT ); Thu, 25 Jun 2020 02:46:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390139AbgFYGqd (ORCPT ); Thu, 25 Jun 2020 02:46:33 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 125C1C061796 for ; Wed, 24 Jun 2020 23:46:33 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id l17so4430290wmj.0 for ; Wed, 24 Jun 2020 23:46:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zFD+XYh0LbdyDPIgjJ6ML5H3hXoar7p4uFfuKLbk0ZA=; b=jAVR5eoyrmVKjLEHNqfjCNWanaCYTE8ppNlexuZG9che0RL0uhWQj0j1YU5wDQgiB2 XxrXcc5uE085/9qsTkTpk2XicffwrBGGolaOz3pSHPcANX/VXJO3NcsEvj/CjpkIDpYq Q3uXB5Y94Cd9PoRDMEZTfc2n3h2txHH6s5g64wtshhSl8eZGhOHM5VvLNYbdwtut8zjf SHmv0HSTQc3SOI81N9Hl/EIU4+S2YDJJin++zw4JooKAF6IG7Tz/GhIVJ2tlE5mHG9XM kU1qAEaskZkY0Jz/u9LZHE9tEDf4/lcq6JOS+Bt0SaLzhLaG1eGh1Rb50sae3rOuvipu FWZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zFD+XYh0LbdyDPIgjJ6ML5H3hXoar7p4uFfuKLbk0ZA=; b=Mrpq1D79qfd66A5wjaNhT8JxJ9IKWsiQX82zu6lYETupSOs1JNCYn6YjJ44jmO3/YQ 6srQhvWWOFvxnyOJCOdPBClII0jsGeaPr6PGr3O88GIx7t+M9nmN2fGeEhTawMkq8IuA +759DFkoldgp/z0UHxBTTVnF7ELpiQsPY0qmBloDdvTfGNW0H5Zohjhm+UUlzJgErEz7 V69NqrWqPQrBXsLfY3rNI1rAcnkpJSddUTk5aeiiXf9Uebm/dIgJmu15DjzCxunym8Di uFdXqEGKYBeS02CVLAIf9JzeafGk90JCyAQSIFC5fqE77lHQU6httefzqCzKtBnWtygu OVjw== X-Gm-Message-State: AOAM531IAYP78MF/lgSlcSyQP+vG8y0UwSAkxAxd1yDRVv/GwxNnVgB1 6RK6qPD3VO4WSlTmnqMeHlResA== X-Google-Smtp-Source: ABdhPJwMgZfQzBCeFoiLZTJnp/x4vgmn7WMj1vkUKS/+Lm7IeVtJH2PwgM57kLDLfxA35mh6mWhlMA== X-Received: by 2002:a1c:dfd6:: with SMTP id w205mr1785713wmg.118.1593067591825; Wed, 24 Jun 2020 23:46:31 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id c20sm27235363wrb.65.2020.06.24.23.46.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 23:46:31 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Tony Lindgren , Keshava Munegowda , Roger Quadros , linux-omap@vger.kernel.org Subject: [PATCH 05/10] mfd: omap-usb-host: Remove invalid use of kerneldoc syntax Date: Thu, 25 Jun 2020 07:46:14 +0100 Message-Id: <20200625064619.2775707-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200625064619.2775707-1-lee.jones@linaro.org> References: <20200625064619.2775707-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Kerneldoc is for documenting function arguments and return values. Prevents warnings like: drivers/mfd/omap-usb-host.c:128: warning: cannot understand function prototype: 'const char * const port_modes[] = ' Cc: Cc: Tony Lindgren Cc: Keshava Munegowda Cc: Roger Quadros Cc: linux-omap@vger.kernel.org Signed-off-by: Lee Jones --- drivers/mfd/omap-usb-host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c index 1f4f01b02d98c..f56cdf3149dc0 100644 --- a/drivers/mfd/omap-usb-host.c +++ b/drivers/mfd/omap-usb-host.c @@ -120,7 +120,7 @@ static inline u32 usbhs_read(void __iomem *base, u32 reg) /*-------------------------------------------------------------------------*/ -/** +/* * Map 'enum usbhs_omap_port_mode' found in * to the device tree binding portN-mode found in * 'Documentation/devicetree/bindings/mfd/omap-usb-host.txt' From patchwork Thu Jun 25 06:46:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 191734 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp539448ilg; Wed, 24 Jun 2020 23:47:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyL0YU2U+IddsFHx4kd1ipxxVrK1bz3vCjjLbIgokFWvd6+kr51l7f8hIip70FCvSu/4Gs0 X-Received: by 2002:aa7:d158:: with SMTP id r24mr29861295edo.272.1593067625128; Wed, 24 Jun 2020 23:47:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593067625; cv=none; d=google.com; s=arc-20160816; b=ab3keplYK5VO1EK8SasqyDZ8PGI0Sq7uMFgqapxkymu861ETCz7VCeXK4eBvUV7q8N bYR3lm1kgSSB83mbrm6zRIQBHLrXCDsHkZyN74wPFoy0nBNF9Je07XINOPDVzmPfaseb FTBJsDSvNJ/3fJi8Vvzqss6mWt5AQWerdDn8iEADKP9Je5j2pGIX8psyxSXsd9HRvVb0 eEumtMR8Pzu0LFyrI17Hq7Bu0EAli80WhTjlGwrnanRJEM9zUxmMP9ncnx5eWsmmiyAb 5jbb4T8Xq758in4odmqC6KkIYMjCPXrjJ7a0NpSvz5oBeYmKNqtVk7YHlMk4kFGd07pb 7dTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ZzLtCVZ0xnD69Tq7rrN3k4RXzAsRLvX+l/b23e7w5no=; b=XOa6l1b1dxFwWKcQY8uYABEJdCHi3xttE+TxsBT7Fdg4aIgGfaQXFP2MYcR4FTZdSE BPsJWWJPdpLi08zCQ1PFkdgw0tcu/gfvxCKxe04ql+WPU2Gb18AbxQZ+INek92l1tiCu py4Kx5MbrZHTE71D00sSuWdqoOncan7IIXA9cAkevOTelHZyl1qu4KIKCF9P7ENRDon2 xfkFerPLzAJzf3u2wp0wJLjWWXcnphkbcB9vwk+wm0CFsxIQdYfmekdKhPsoukwaptuh v+1SCryk7F8HlOgnYKZXn0ngIPC3uyx9529TnMl7z6dp90Tt/T14ZKRJxAigqoBJAv8x DiNg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BoR0BVfF; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id mm15si7649420ejb.561.2020.06.24.23.47.04; Wed, 24 Jun 2020 23:47:05 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BoR0BVfF; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390290AbgFYGq7 (ORCPT + 15 others); Thu, 25 Jun 2020 02:46:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390175AbgFYGqg (ORCPT ); Thu, 25 Jun 2020 02:46:36 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C8ABC0613ED for ; Wed, 24 Jun 2020 23:46:36 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id u26so5992183wmn.1 for ; Wed, 24 Jun 2020 23:46:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZzLtCVZ0xnD69Tq7rrN3k4RXzAsRLvX+l/b23e7w5no=; b=BoR0BVfFhS9za/tBEuj3YkwiY8nNI24M8p9fmhuCM6IiYJIEKM/q4XFtIYaAjPe2Dk +nz7AdEJTpAE6Z+mq1fY/goiHr+ULfYi+dRbajh5fVCoRPVr0Q+zoCiJpLRmGQXpi0nF hp5QBIuI6XCJpSCjUX0V3zfIn+ZbWxvJgbgmtqBW+2vkICODU7hu8BBVpkSerVZbYksH 3F+0fRc9wCbqjlgJjwvTx76agAqHN5CXzt9RhogHKW0HMD0Hsdt+C+QgFL5edj3pUqh/ qEeWE5X1U9a0rI6T84EX3KqVH/ST5X+6bwNw57W9gxqGVfLBP9icFRkYY03DiWqvKjBD zDhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZzLtCVZ0xnD69Tq7rrN3k4RXzAsRLvX+l/b23e7w5no=; b=tFdCLZWC15Ez36Zh07Ex2LqkEOego4s0CwHsdUWzQOWDOFQAp4ZgvziiuldqAlkha0 7m2L6pAFUf73089B5HkjrM8jXpd55Km+z3gCQEAMmCItpS2EQpE+wuOjm+vQ4Q2zqovX 9BN2DNXXjF/ZBPu78kOkU6+TgZB4eA8cMj6pn4IKhf+JZhxcdKz/p1YEQfyP256yF+jG ud7Xktd9V4LsfPYIWlttSog6ZqhMxY5DgzzO9i2unPE1YW+iHhzW4eR2AlC76tig5Cks 4ud3muNyPQ4YWUgN04rd1fWYOduQuo9QYWXJRHAGnQgCK4wj2APSGlBjhpvuDBHypLgR tSXg== X-Gm-Message-State: AOAM533fC8OC5FGvz+AFt6K7fpnSVRCNsWdlotsoUj6Y2UJC78ZXBS+E lhbJfel9eLWNR9ihqKh0w2TcJg== X-Received: by 2002:a1c:de07:: with SMTP id v7mr1737470wmg.56.1593067595221; Wed, 24 Jun 2020 23:46:35 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id c20sm27235363wrb.65.2020.06.24.23.46.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 23:46:34 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Nicolas Ferre , Alexandre Belloni , Ludovic Desroches , Boris Brezillon Subject: [PATCH 08/10] mfd: atmel-smc: Silence comparison of unsigned expression < 0 is always false warning (W=1) Date: Thu, 25 Jun 2020 07:46:17 +0100 Message-Id: <20200625064619.2775707-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200625064619.2775707-1-lee.jones@linaro.org> References: <20200625064619.2775707-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org GENMASK and it's callees conduct checking to ensure the passed parameters are valid. One of those checks is for '< 0'. So if an unsigned value is passed, in an invalid comparison takes place. Judging from the current code, it looks as though 'unsigned int' is the correct type to use, so simply cast these small values with no chance of being false negative to signed int for comparison/error checking purposes. Squashes the following W=1 warnings: In file included from /home/lee/projects/linux/kernel/include/linux/bits.h:23, from /home/lee/projects/linux/kernel/include/linux/bitops.h:5, from /home/lee/projects/linux/kernel/include/linux/kernel.h:12, from /home/lee/projects/linux/kernel/include/linux/mfd/syscon/atmel-smc.h:14, from /home/lee/projects/linux/kernel/drivers/mfd/atmel-smc.c:11: /home/lee/projects/linux/kernel/drivers/mfd/atmel-smc.c: In function ‘atmel_smc_cs_encode_ncycles’: /home/lee/projects/linux/kernel/include/linux/bits.h:26:28: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] 26 | __builtin_constant_p((l) > (h)), (l) > (h), 0))) | ^ /home/lee/projects/linux/kernel/include/linux/build_bug.h:16:62: note: in definition of macro ‘BUILD_BUG_ON_ZERO’ 16 | #define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e)); }))) | ^ /home/lee/projects/linux/kernel/include/linux/bits.h:39:3: note: in expansion of macro ‘GENMASK_INPUT_CHECK’ 39 | (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l)) | ^~~~~~~~~~~~~~~~~~~ /home/lee/projects/linux/kernel/drivers/mfd/atmel-smc.c:49:25: note: in expansion of macro ‘GENMASK’ 49 | unsigned int lsbmask = GENMASK(msbpos - 1, 0); | ^~~~~~~ /home/lee/projects/linux/kernel/include/linux/bits.h:26:40: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] 26 | __builtin_constant_p((l) > (h)), (l) > (h), 0))) | ^ /home/lee/projects/linux/kernel/include/linux/build_bug.h:16:62: note: in definition of macro ‘BUILD_BUG_ON_ZERO’ 16 | #define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e)); }))) | ^ /home/lee/projects/linux/kernel/include/linux/bits.h:39:3: note: in expansion of macro ‘GENMASK_INPUT_CHECK’ 39 | (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l)) | ^~~~~~~~~~~~~~~~~~~ Cc: Cc: Nicolas Ferre Cc: Alexandre Belloni Cc: Ludovic Desroches Cc: Boris Brezillon Signed-off-by: Lee Jones --- drivers/mfd/atmel-smc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.25.1 diff --git a/drivers/mfd/atmel-smc.c b/drivers/mfd/atmel-smc.c index 1fa2ec950e7df..17bbe9d1fa740 100644 --- a/drivers/mfd/atmel-smc.c +++ b/drivers/mfd/atmel-smc.c @@ -46,8 +46,8 @@ static int atmel_smc_cs_encode_ncycles(unsigned int ncycles, unsigned int msbfactor, unsigned int *encodedval) { - unsigned int lsbmask = GENMASK(msbpos - 1, 0); - unsigned int msbmask = GENMASK(msbwidth - 1, 0); + unsigned int lsbmask = GENMASK((int)msbpos - 1, 0); + unsigned int msbmask = GENMASK((int)msbwidth - 1, 0); unsigned int msb, lsb; int ret = 0; From patchwork Thu Jun 25 06:46:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 191732 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp539319ilg; Wed, 24 Jun 2020 23:46:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx/2ExURvbXCZV9SU6HeY6pBwpWqIj+j5v8xBBaCMlbkrWXzWUDoqe5dStgzxz53/nikb8f X-Received: by 2002:a50:f28e:: with SMTP id f14mr31724255edm.100.1593067615162; Wed, 24 Jun 2020 23:46:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593067615; cv=none; d=google.com; s=arc-20160816; b=PsEAqb4pDBr9n3MWQKSOsV+08XjkoTLQXQO6jCQQWx/sXOECeUHbaRGeV1/Yd2DBei gvt2aqMZP8UewmLZfSbQEkhnoBMharyYy/Scup/8ZLYejKHLTf8xILMgp6sxjIkzcx3Q dxt1SqGttylbUDwWnAxmUZkwC48IjPTceKGQUEipOMkL9uqRKZAxn8RJ97KA3MpEo54h SD4X9KZIl+XSXrwYgfNkYuD6+NPnZ1W6RIDMJep2b1dfIgoVbBubwCTr8MRkke9p/GlL xqj+DzxTf1mS9Wcj2XRbGY3zia0QE3tU/QJScWruLEIsFthaT/79CX8OcLZ8dg5N3EDT IISQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=J2LvBowpzfqfQHnK/gnFZDPalEMEwUf10cp2QuQIuRg=; b=hykRWbWB28pXRlwLNSdGd+4/OwzEk9v2jvUqRE/jYsuyVUWKf388aiRaR9wfcAqIvA s4rLF4v3MQiaCx5Z5Gg1bCO0Plmb7nzQ/6LZM34UGaGLga+bk68maBRtzvql6Yl1PZvF bD/CF/NnNSZhZpZFuLi5+o3SAroegDT4WSMZa6KGLJPgJQWutzBPB7IrU0WOijFaeW9o OCf9OLcuGT6Xkdcy5m8FGTkO7VmxFaq5+vYPSHq/Ya4lC6Ufm4kFZY921D+YN3TonCVU wB1136Cii9HqKUcNeVLHDBKGEyQfSVr11x3mSOInk6n/RGP35ulleM1Tabx31SSs7Cpp Hzyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=MVXl0wtg; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g7si67679ejr.748.2020.06.24.23.46.55; Wed, 24 Jun 2020 23:46:55 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=MVXl0wtg; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390262AbgFYGqx (ORCPT + 15 others); Thu, 25 Jun 2020 02:46:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390194AbgFYGqi (ORCPT ); Thu, 25 Jun 2020 02:46:38 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6BB4CC061799 for ; Wed, 24 Jun 2020 23:46:37 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id b6so4579305wrs.11 for ; Wed, 24 Jun 2020 23:46:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=J2LvBowpzfqfQHnK/gnFZDPalEMEwUf10cp2QuQIuRg=; b=MVXl0wtgTNbcqhYy50uwzSMS91a5du9fhzg4oeB/etwz+t21MCLhi+PSWsJnrEyp3H 37sCoamMGW5zxACUygyfAjblD0iWrElfagnCgzarbJmDFtDaBnfibzhRcELTWRTz6+f7 dAi5vForunxsCLorBb9k5irOYwFYlroFBnbYQ1jQfAosFB6pAR4irkMzKX7m8YjCMfG/ CtRLuLArlmcY/lmBV/bEL17oZ9ZujckJiDZXTLnMsNwn3W3g4RPRBmTy3T6cIdrOxqez DbK7Q3oChBAP1tW0xprzEo4N3hk/VQGb0VfV/LS1HQKjjxRD12nh6V7Q/w8KLxSkDACU DcAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=J2LvBowpzfqfQHnK/gnFZDPalEMEwUf10cp2QuQIuRg=; b=bVSz2p9OyQeWYqCHa/P95GqM8lQ0scZMXKtNex4qn6BLto20EM7VYjQXDzhOX4SbJO ZzUfZuYwMkc1vxawR7BSaZAH0T8eJRKOJW+BB/XM4NHtkfd8VGkW12yZTXRBYGPRIc0c FOTkD817oERtyCZCYrdqmN3YCGabDqX7CNMW61BKxcmamBBeucvs7IqaQ3hkT5bT4S8G REMhfZqwnDbTPPYawmq3fxj8KaW936Pu4Wy7nmifQslJtDL7uWFJjlC54qIhEsHoVaGm nPgtfDKokbI9obMxrPUlF16T8dS9xh8Mi2puFxUmdUt0hyH4lmQXnTiUP/ZsVLaH57zT wQHg== X-Gm-Message-State: AOAM530LsHje+I+IxUrAOf61BxGe/iNh0pnAxA4OPq7ybnXdhnVc9LAX ObfotxtR5GDTDJqpqc4BSc5tAA== X-Received: by 2002:adf:8091:: with SMTP id 17mr33043279wrl.244.1593067596171; Wed, 24 Jun 2020 23:46:36 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id c20sm27235363wrb.65.2020.06.24.23.46.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 23:46:35 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Nicolas Ferre , Alexandre Belloni , Ludovic Desroches , Boris Brezillon Subject: [PATCH 09/10] mfd: atmel-smc: Add missing colon(s) for 'conf' arguments Date: Thu, 25 Jun 2020 07:46:18 +0100 Message-Id: <20200625064619.2775707-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200625064619.2775707-1-lee.jones@linaro.org> References: <20200625064619.2775707-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Kerneldoc valication gets confused if syntax isn't "@.*: ". Adding the missing colons squashes the following W=1 warnings: drivers/mfd/atmel-smc.c:247: warning: Function parameter or member 'conf' not described in 'atmel_smc_cs_conf_apply' drivers/mfd/atmel-smc.c:268: warning: Function parameter or member 'conf' not described in 'atmel_hsmc_cs_conf_apply' Cc: Cc: Nicolas Ferre Cc: Alexandre Belloni Cc: Ludovic Desroches Cc: Boris Brezillon Signed-off-by: Lee Jones --- drivers/mfd/atmel-smc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.25.1 Reviewed-by: Alexandre Belloni diff --git a/drivers/mfd/atmel-smc.c b/drivers/mfd/atmel-smc.c index 17bbe9d1fa740..4aac96d213369 100644 --- a/drivers/mfd/atmel-smc.c +++ b/drivers/mfd/atmel-smc.c @@ -237,7 +237,7 @@ EXPORT_SYMBOL_GPL(atmel_smc_cs_conf_set_cycle); * atmel_smc_cs_conf_apply - apply an SMC CS conf * @regmap: the SMC regmap * @cs: the CS id - * @conf the SMC CS conf to apply + * @conf: the SMC CS conf to apply * * Applies an SMC CS configuration. * Only valid on at91sam9/avr32 SoCs. @@ -257,7 +257,7 @@ EXPORT_SYMBOL_GPL(atmel_smc_cs_conf_apply); * @regmap: the HSMC regmap * @cs: the CS id * @layout: the layout of registers - * @conf the SMC CS conf to apply + * @conf: the SMC CS conf to apply * * Applies an SMC CS configuration. * Only valid on post-sama5 SoCs. From patchwork Thu Jun 25 06:46:19 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 191733 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp539389ilg; Wed, 24 Jun 2020 23:47:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxMd4NbVYXwhbSGBs6PjbJcRbAUAaJHh0/NDrNK2mCOW6N6mWxdhL6Dcqt6ERnTCBL0a/6m X-Received: by 2002:aa7:c590:: with SMTP id g16mr31027611edq.5.1593067620275; Wed, 24 Jun 2020 23:47:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593067620; cv=none; d=google.com; s=arc-20160816; b=eZZVxuvR19JIbAtNyOnhMP0YjmuhFgduWmxAqxtlvqHqAZW5zw6WbulJCuJDa5qFJQ SPX9rjHbNdT+btggeJTrxMuHLz4sj7EoTORD0AL1rh2Y1/CbVAUfjkX+hO47THbAOI6G i+8QrUS8diI9dLaPz5PBCR0LvmCeMUnqlbbN5/+rg4OzvVlTJcl1qWpvpv52dyXb8owQ q1YNRgc83Hf4/+sMn0tLNVbk9Cd44lWbnXioverfqobq3YPAg3Kt3oCkCQN7P+WgLKJt Swf0ygPmXREXi2OlXLGlWqVCEqOMjIKgXzIH5khMCU1sLK/eIYNa7K5PBM/Bu35mb6cr oCsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=bh7BIJEoFgjXHqYRkwppX22NHiJGTlWMxnnDJ2K7EXk=; b=bTCnpbKl+4WC/R0T8zD7d69l7iXTmTArTlKVi+Za/cFCcPZEAjgfRE6JWhzj+KNz54 nml5y/jktb9KH0BKt6rl8/F4wtBqIcJA6xgH856BtCA8aeB+U4CL92453/aq45I0EpWZ x8pCoYzhyj3sEVunW3rn+TFg6zWxrcYyJFoPehCq9XZ8s5CmIrhFUP+M8r46/nN/hx5F EVR7a4SQqmYw3QclB+hyHqTLw3ZEHI03NPIkKHOlQTmECoJiVd227ZRufyOBNPb+cnmK Y6e9NNNEO8QNhbJXdq+bNJWHp29yIyFd1P+tytgcEoXNPCAm3Dk5Y7dmfYOBK8YrSMbf WuPQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=glb++HtS; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w6si14410949eja.471.2020.06.24.23.47.00; Wed, 24 Jun 2020 23:47:00 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=glb++HtS; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390194AbgFYGqy (ORCPT + 15 others); Thu, 25 Jun 2020 02:46:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390141AbgFYGqi (ORCPT ); Thu, 25 Jun 2020 02:46:38 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62043C0613ED for ; Wed, 24 Jun 2020 23:46:38 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id q5so4599739wru.6 for ; Wed, 24 Jun 2020 23:46:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bh7BIJEoFgjXHqYRkwppX22NHiJGTlWMxnnDJ2K7EXk=; b=glb++HtS7oZWTpXDAzu7GckwXl1mrcYHW8RG3vTiRLcrJP0l7bKna80fqlxmkNdFuI WtsEu8LgvypecW54tymX3u8xbDuWXwH15K8LxtUmwAnB5XGefq2pMyX5ndzdlS78CuO6 X8YwtelBuFGRwp5DX/Lg1xCuSkc+Gue1l6Ue7pWro9xfXnmYiRXceFTqupqzt+vGtjDT +jbyK+D9fFbDRc+8XfgTfi+DfbyNx+U0gVeA3dnVYIMm4bPGVm/BWPyspiJbOZd5LODD 3QuaAbe8tuiikxunA1ERhVLZ1r718Dkld9We079Otb5DKfuJKCICePZjxmw2lQLBaD1m DHsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bh7BIJEoFgjXHqYRkwppX22NHiJGTlWMxnnDJ2K7EXk=; b=TrMGfdEcly5tLHcc1YqRQEi4Dfb9U9j2NKh6sMUl2iEI0LEgxJgWzdoLm8HrngfvLf 9Rv0P7N8ahWVoH8PJRP8zvu4EmURnyqTkQ1w3rRf00AxUmBrARmLp/0Had2RtsTW1qYc sOW4U7r2rN5aJ2d5bXCWviSPHW3n3pxkwZ7MhUXltexfQto89OuNBa8PpC9HhCianB9/ ywe2vGP6CBj6Dhw7zDDXO7QWocFGDIsuv6uX0Ymbc4kcU4M+0wqnZAbNWtL+jF0Aj4LV /DUkZN+7LB0RBAgpswMus73LunfTQF3KZxbNYQ5BqHDdQy02ScN2JqvC94K1IkenBdHU s4Uw== X-Gm-Message-State: AOAM532/VMQjqDVZgdM2uFMmpvmMAvTuFmcT7xsQL6basz5BSoHPIZxW U1Ogj8CxOJlum/l3o59P0E9UdA== X-Received: by 2002:a5d:6802:: with SMTP id w2mr8325231wru.88.1593067597162; Wed, 24 Jun 2020 23:46:37 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id c20sm27235363wrb.65.2020.06.24.23.46.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 23:46:36 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Thor Thayer Subject: [PATCH 10/10] mfd: altera-sysmgr: Supply descriptions for 'np' and 'property' function args Date: Thu, 25 Jun 2020 07:46:19 +0100 Message-Id: <20200625064619.2775707-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200625064619.2775707-1-lee.jones@linaro.org> References: <20200625064619.2775707-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Kerneldoc syntax is used, but not complete. Arg descriptions are required. Fixes the following W=1 build warnings: drivers/mfd/altera-sysmgr.c:95: warning: Function parameter or member 'np' not described in 'altr_sysmgr_regmap_lookup_by_phandle' drivers/mfd/altera-sysmgr.c:95: warning: Function parameter or member 'property' not described in 'altr_sysmgr_regmap_lookup_by_phandle' Cc: Cc: Thor Thayer Signed-off-by: Lee Jones --- drivers/mfd/altera-sysmgr.c | 3 +++ 1 file changed, 3 insertions(+) -- 2.25.1 diff --git a/drivers/mfd/altera-sysmgr.c b/drivers/mfd/altera-sysmgr.c index 83f0765f819b0..41076d121dd54 100644 --- a/drivers/mfd/altera-sysmgr.c +++ b/drivers/mfd/altera-sysmgr.c @@ -89,6 +89,9 @@ static struct regmap_config altr_sysmgr_regmap_cfg = { * altr_sysmgr_regmap_lookup_by_phandle * Find the sysmgr previous configured in probe() and return regmap property. * Return: regmap if found or error if not found. + * + * @np: Pointer to device's Device Tree node + * @property: Device Tree property name which references the sysmgr */ struct regmap *altr_sysmgr_regmap_lookup_by_phandle(struct device_node *np, const char *property)