From patchwork Tue Mar 24 12:35:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rajat Jain X-Patchwork-Id: 208042 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E612AC43331 for ; Tue, 24 Mar 2020 12:35:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BE9202070A for ; Tue, 24 Mar 2020 12:35:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="lrkNOvRm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727561AbgCXMfc (ORCPT ); Tue, 24 Mar 2020 08:35:32 -0400 Received: from mail-pj1-f74.google.com ([209.85.216.74]:57377 "EHLO mail-pj1-f74.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727557AbgCXMfc (ORCPT ); Tue, 24 Mar 2020 08:35:32 -0400 Received: by mail-pj1-f74.google.com with SMTP id np3so2442846pjb.7 for ; Tue, 24 Mar 2020 05:35:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=5LJBH8xQN/jQBYcxN7fADpsh/S4ILyM2BLQ/YSrufN0=; b=lrkNOvRmUfIaF/A680qHGLiVgg0GQPkzG6FPhLtY747Zb6pLNG8Zgn8lppIsH1ATDA qi2aczpwz1DwrvZaRiIJjdZuljpnhbxcIlV3tH30rFehu9n/VcQCT72NRCumITBYwZcs u2vqZHudgsefVYz+OnKrpUocL7ncCUxYD1sWAeTYAVKhNG36dPUFEeG2EsskGXE8Gqv7 W6t9VEvV6CZYmMIXsJng/CIAM5+9WkHrlLR16tuWvMJ5B0LjGhrKJnMuf5yTBkRfeVcS 7vQ9gQmNzQA/SHCh04nyP551vhjc9mEyIRgpsmkCP+XyWgTn8pTj+emFXRd7rC+KrqDH BUPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=5LJBH8xQN/jQBYcxN7fADpsh/S4ILyM2BLQ/YSrufN0=; b=reoAJ+XmABDsIAFIgajf8KrqZj5FsmywMnugTyNug5UczE10iOaP9bCZfOVekeyTbz Ugzh61fBVI3rdoNb6luYF2k1A6kVIi275iyFBgc188oEELr6AFIYOA7X5MKlhgXDPjac aNjQLMGi9g+izk0QRDZ2eGgptbW7EDEb5Pjg5cZJjwbfNlfbHMgXtLDIcJjlXsnn8rKZ C5lJWBpJO8KiaGrv3GVGERYBjd0xEmAdvFh6uFat5oku45Owx/kURx1/ZhD1SaLTu6MO QGkUGgsXcSQ1EfCEyiBX7zHNwnAlSWCA2QYYb3xKYwOSd3pjto0Oh6yUCIJUmQTEBwEk QccQ== X-Gm-Message-State: ANhLgQ2G5b+bkSik+oFgVRzpRkzS9olyhiLpx+IIUMRZSIpuWZJ7lyZf RkSmZZ+jRDX5ozmGIioOdopWR/4eFR2l X-Google-Smtp-Source: ADFU+vu288sFSt11Qek/NJ9edzx6Ik5VpV0z7KGXLXL8qHNO1/Re0wIomUu+WPPbOweT/mkzeqW3EKHV9Tjl X-Received: by 2002:a17:90a:ba93:: with SMTP id t19mr4040036pjr.67.1585053326283; Tue, 24 Mar 2020 05:35:26 -0700 (PDT) Date: Tue, 24 Mar 2020 05:35:14 -0700 Message-Id: <20200324123518.239768-1-rajatja@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.25.1.696.g5e7596f4ac-goog Subject: [PATCH v2 1/5] input/serio/i8042: Attach fwnode to serio i8042 kbd device From: Rajat Jain To: Dmitry Torokhov , dtor@google.com, Rob Herring , Mark Rutland , Rajat Jain , Kate Stewart , Enrico Weigelt , Greg Kroah-Hartman , Thomas Gleixner , Allison Randal , "Rafael J. Wysocki" , Stephen Boyd , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, furquan@google.com, dlaurie@google.com, bleung@google.com, zentaro@google.com, dbehr@google.com Cc: rajatxjain@gmail.com Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Attach the firmware node to the serio i8042 kbd device so that device properties can be passed from the firmware. Signed-off-by: Rajat Jain --- v2: Remove the Change-Id from the commit log drivers/input/serio/i8042-x86ia64io.h | 1 + drivers/input/serio/i8042.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/drivers/input/serio/i8042-x86ia64io.h b/drivers/input/serio/i8042-x86ia64io.h index dc974c288e880..ed9ec4310d976 100644 --- a/drivers/input/serio/i8042-x86ia64io.h +++ b/drivers/input/serio/i8042-x86ia64io.h @@ -927,6 +927,7 @@ static int i8042_pnp_kbd_probe(struct pnp_dev *dev, const struct pnp_device_id * } i8042_pnp_id_to_string(dev->id, i8042_kbd_firmware_id, sizeof(i8042_kbd_firmware_id)); + i8042_kbd_fwnode = dev_fwnode(&dev->dev); /* Keyboard ports are always supposed to be wakeup-enabled */ device_set_wakeup_enable(&dev->dev, true); diff --git a/drivers/input/serio/i8042.c b/drivers/input/serio/i8042.c index 20ff2bed3917a..0dddf273afd94 100644 --- a/drivers/input/serio/i8042.c +++ b/drivers/input/serio/i8042.c @@ -21,6 +21,7 @@ #include #include #include +#include #include @@ -124,6 +125,7 @@ MODULE_PARM_DESC(unmask_kbd_data, "Unconditional enable (may reveal sensitive da static bool i8042_bypass_aux_irq_test; static char i8042_kbd_firmware_id[128]; static char i8042_aux_firmware_id[128]; +static struct fwnode_handle *i8042_kbd_fwnode; #include "i8042.h" @@ -1335,6 +1337,7 @@ static int __init i8042_create_kbd_port(void) strlcpy(serio->phys, I8042_KBD_PHYS_DESC, sizeof(serio->phys)); strlcpy(serio->firmware_id, i8042_kbd_firmware_id, sizeof(serio->firmware_id)); + set_primary_fwnode(&serio->dev, i8042_kbd_fwnode); port->serio = serio; port->irq = I8042_KBD_IRQ; From patchwork Tue Mar 24 12:35:16 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rajat Jain X-Patchwork-Id: 208041 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8668C4332B for ; Tue, 24 Mar 2020 12:35:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8071D20870 for ; Tue, 24 Mar 2020 12:35:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="PGKtJEH2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727607AbgCXMfn (ORCPT ); Tue, 24 Mar 2020 08:35:43 -0400 Received: from mail-pl1-f202.google.com ([209.85.214.202]:35266 "EHLO mail-pl1-f202.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727597AbgCXMfn (ORCPT ); Tue, 24 Mar 2020 08:35:43 -0400 Received: by mail-pl1-f202.google.com with SMTP id a8so10589666plm.2 for ; Tue, 24 Mar 2020 05:35:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=9qa8aAp+bZ6gg3RjZoXrpyNia4xdGEkV4pXAFPahzW4=; b=PGKtJEH2E9p0fcB03gDuNWbPXiQ/2waoPhihfZtac0gHwtFY6/Srthu+qCNEaA9hWX ZMDCQJbkHXBUeJdiKVFWL6GEKHGRuADWPn1x3IWiQiE69GsV53fMxXoFyaCvKeC6l+he +x0H2QwnOypxbtb3WWtcSB4G3hvSBZ6fzOseLpEoNaJb+ozK2cL+XtqvsBthu1M2wOzB svB7tDExbTn+kH1naAnmbBMWO2SLH3cW47kfDkXUoKA7lzbfzSg6Y+toJevOADg0gG5G S9963zRiHbFOWHS0bO5cRcPwjsQx7VI2Uq0i4OcUS1h0bAl1Pjjt19e0Zict/AZR9kQS rzHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=9qa8aAp+bZ6gg3RjZoXrpyNia4xdGEkV4pXAFPahzW4=; b=WKL4ojLU3eNXHaGo5HhBlw+F6rzT1b2Y5wHO04tO9KCkZxvv9cqLbrpJZdsE2FCZBP LN6upY1zVZoQprFGRUo+OdsJ4Bw09LkdWH+D1tg5FBMBmOYFZOWt3j1rExGe2PG0bADL j6DFOnJmezndjUBqv+7EcxF/YiE81iFedW2GY3M8tk7GTC+Q7wPJegGSMAg08U7KKfrs V+UKdbv3Hoi5u86u8vrbhWrjfuod+Y79rtoGxitNafkmqkHl8rkQu0H0BoRcem0rOMJv gICh4lIbjoNZS8TzL5AyX9xBP8eEXbqNK6CSsWdgIJNVICaBYbDFoqvukD/hAD9BrJhv A+RA== X-Gm-Message-State: ANhLgQ2btcciBTSne1A0eM8INInLYW7oodNn6WBzlzSJkxNRhv1EcqTV ekGzMemz2+y1Xu/HqTcrM8fOTmrdCoa0 X-Google-Smtp-Source: ADFU+vsjCf2WCgjHPJYj99N2JWIuBp5ZMQN3hRm0xa06BAW6KPosWLcQBDeNjnYsynKKF8M5UcQ85Nk9wBQJ X-Received: by 2002:a63:cb:: with SMTP id 194mr27725855pga.37.1585053342203; Tue, 24 Mar 2020 05:35:42 -0700 (PDT) Date: Tue, 24 Mar 2020 05:35:16 -0700 In-Reply-To: <20200324123518.239768-1-rajatja@google.com> Message-Id: <20200324123518.239768-3-rajatja@google.com> Mime-Version: 1.0 References: <20200324123518.239768-1-rajatja@google.com> X-Mailer: git-send-email 2.25.1.696.g5e7596f4ac-goog Subject: [PATCH v2 3/5] dt-bindings: input/atkbd.txt: Add binding for "function-row-physmap" From: Rajat Jain To: Dmitry Torokhov , dtor@google.com, Rob Herring , Mark Rutland , Rajat Jain , Kate Stewart , Enrico Weigelt , Greg Kroah-Hartman , Thomas Gleixner , Allison Randal , "Rafael J. Wysocki" , Stephen Boyd , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, furquan@google.com, dlaurie@google.com, bleung@google.com, zentaro@google.com, dbehr@google.com Cc: rajatxjain@gmail.com Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Create the documentation for the new introduced property, that describes the function-row keys physical positions. Signed-off-by: Rajat Jain --- v2: Remove the Change-Id from the commit log .../devicetree/bindings/input/atkbd.txt | 34 +++++++++++++++++++ 1 file changed, 34 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/atkbd.txt diff --git a/Documentation/devicetree/bindings/input/atkbd.txt b/Documentation/devicetree/bindings/input/atkbd.txt new file mode 100644 index 0000000000000..816653eb8e98d --- /dev/null +++ b/Documentation/devicetree/bindings/input/atkbd.txt @@ -0,0 +1,34 @@ +Device tree bindings for AT / PS2 keyboard device + +Optional properties: + + function-row-physmap: + An ordered array of the physical codes for the function + row keys. Arranged in order from left to right. + +Example: + + This is a sample ACPI _DSD node describing the property: + + Name (_DSD, Package () { + ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), + Package () { + Package () { "function-row-physmap", + Package () { + 0xEA, /* T1 BACK */ + 0xE7, /* T2 REFRESH */ + 0x91, /* T3 FULLSCREEN */ + 0x92, /* T4 SCALE */ + 0x93, /* T5 SNIP */ + 0x94, /* T6 BRIGHTNESS_DOWN */ + 0x95, /* T7 BRIGHTNESS_UP */ + 0x96, /* T8 PRIVACY_SCRN_TOGGLE */ + 0x97, /* T9 KBD_BKLIGHT_DOWN */ + 0x98, /* T10 KBD_BKLIGHT_UP */ + 0xA0, /* T11 VOL_MUTE */ + 0xAE, /* T12 VOL_DOWN */ + 0xB0, /* T13 VOL_UP */ + } + } + } + }) From patchwork Tue Mar 24 12:35:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rajat Jain X-Patchwork-Id: 208040 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D26C3C41621 for ; Tue, 24 Mar 2020 12:35:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AA29C208CA for ; Tue, 24 Mar 2020 12:35:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="FbYjimOK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727557AbgCXMfx (ORCPT ); Tue, 24 Mar 2020 08:35:53 -0400 Received: from mail-pl1-f202.google.com ([209.85.214.202]:42704 "EHLO mail-pl1-f202.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727667AbgCXMfw (ORCPT ); Tue, 24 Mar 2020 08:35:52 -0400 Received: by mail-pl1-f202.google.com with SMTP id g7so7000437plj.9 for ; Tue, 24 Mar 2020 05:35:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=hVHQV/dj3HvNuxis1PdKXEZxW+M5qBzMZyzK/EGMeCk=; b=FbYjimOK12I3PtYwelwNdAM2oLqQiMBiW6ebqxTWZSWqK1WLC+1+frlwjsMx9DI0CB /yfXTd2ISAw1B9RmhQ2JWRGMh+q5h0RvT2rl8xxYQxy6QKE9UUX7jAGn2q7Hrc3vstib Vxo9M9Xjb52PXkfCA0EDImFlAzYoWgv/DOD7q3CbUAIRhTShV3HgYgO3AJ9x1P86gTSw eaGh29VpqQpDD8VO/Ty4W3ecqFe73U60Gveu6iqzJigkW8z4DYo6PMi09w2M9zsC+UrZ 0jwTerdfdH62UUszaOpPEALroapa4mktu665iMT193wZhGKHqm1NY0CSalVcWI6DDnDJ r7ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=hVHQV/dj3HvNuxis1PdKXEZxW+M5qBzMZyzK/EGMeCk=; b=R7EKN0MK5HnEiQ4eFHNmildjSXdR3nFrkj4rrn8DfeirTMHbT1dO47QQQAdRN3jOh/ kEcRMn7tfdWiam7FYONfPGK+/gxNcka7uVRKi0a+tqlmF1QuCY2h8j124F1kttga98GA Sax1xp2rbPcF003eIiFaCu49/Z87gcVSU18GlrQWD2k3aHxZlZCk6/vkLw/+vJveSmfZ XdDh85P3Tz15MaYh4lQ0hCe0+c0gqY2ygGTTS4JwemhuDjTG9BKoECyEfHNU/apo6ENi H9f9RO7Uo6V4Fteq3QAXEd3kZVA+rbHGyjerUb4jMuQkFZbqJeWbAYD63s31JZrrndwl 4PcQ== X-Gm-Message-State: ANhLgQ23a4iUbF7B0O/Ys+63AeJThun0imu9lZMcPJhdNCOUZ/FenCy0 E4jg2E26S+OMZJPKc5kAUu4m/OySUL57 X-Google-Smtp-Source: ADFU+vsjCoKpoZ06ftk7XttqwAP+E9Yftk1Lj/gHqvVXELUNqecE5DCpQGtBz3ovvibLOkGOpmVDNkzSdZyn X-Received: by 2002:a17:90a:bb92:: with SMTP id v18mr5069386pjr.171.1585053351277; Tue, 24 Mar 2020 05:35:51 -0700 (PDT) Date: Tue, 24 Mar 2020 05:35:18 -0700 In-Reply-To: <20200324123518.239768-1-rajatja@google.com> Message-Id: <20200324123518.239768-5-rajatja@google.com> Mime-Version: 1.0 References: <20200324123518.239768-1-rajatja@google.com> X-Mailer: git-send-email 2.25.1.696.g5e7596f4ac-goog Subject: [PATCH v2 5/5] dt-bindings: input/atkbd.txt: Add binding info for "keymap" property From: Rajat Jain To: Dmitry Torokhov , dtor@google.com, Rob Herring , Mark Rutland , Rajat Jain , Kate Stewart , Enrico Weigelt , Greg Kroah-Hartman , Thomas Gleixner , Allison Randal , "Rafael J. Wysocki" , Stephen Boyd , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, furquan@google.com, dlaurie@google.com, bleung@google.com, zentaro@google.com, dbehr@google.com Cc: rajatxjain@gmail.com Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Add the info for keymap property that allows firmware to specify the mapping from physical code to linux keycode, that the kernel should use. Signed-off-by: Rajat Jain --- v2: Remove the Change-Id from the commit log .../devicetree/bindings/input/atkbd.txt | 27 ++++++++++++++++++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/input/atkbd.txt b/Documentation/devicetree/bindings/input/atkbd.txt index 816653eb8e98d..0a0037d70adc8 100644 --- a/Documentation/devicetree/bindings/input/atkbd.txt +++ b/Documentation/devicetree/bindings/input/atkbd.txt @@ -6,9 +6,15 @@ Optional properties: An ordered array of the physical codes for the function row keys. Arranged in order from left to right. + keymap: + An array of the u32 entries to specify mapping from the + keyboard physcial codes to linux keycodes. The top 16 + bits of each entry are the physical code, and bottom + 16 bits are the linux keycode. + Example: - This is a sample ACPI _DSD node describing the property: + This is a sample ACPI _DSD node describing the properties: Name (_DSD, Package () { ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), @@ -29,6 +35,25 @@ Example: 0xAE, /* T12 VOL_DOWN */ 0xB0, /* T13 VOL_UP */ } + }, + Package () { "keymap", + Package () { + 0xEA009E, /* EA -> KEY_BACK */ + 0xE700AD, /* E7 -> KEY_REFRESH */ + 0x910174, /* 91 -> KEY_FULL_SCREEN */ + 0x920078, /* 92 -> KEY_SCALE */ + 0x930280, /* 93 -> 0x280 */ + 0x9400E0, /* 94 -> KEY_BRIGHTNESS_DOWN*/ + 0x9500E1, /* 95 -> KEY_BRIGHTNESS_UP */ + 0x960279, /* 96 -> KEY_PRIVACY_SCRN_TOGGLE*/ + 0x9700E5, /* 97 -> KEY_KBDILLUMDOWN */ + 0x9800E6, /* 98 -> KEY_KBDILLUMUP */ + 0xA00071, /* A0 -> KEY_MUTE */ + 0xAE0072, /* AE -> KEY_VOLUMEDOWN */ + 0xB00073, /* B0 -> KEY_VOLUMEUP */ + ... + + } } } })