From patchwork Tue Feb 7 04:10:02 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 93505 Delivered-To: patch@linaro.org Received: by 10.140.20.99 with SMTP id 90csp2023774qgi; Mon, 6 Feb 2017 20:10:26 -0800 (PST) X-Received: by 10.98.209.73 with SMTP id t9mr17496346pfl.9.1486440626380; Mon, 06 Feb 2017 20:10:26 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p23si2780932pfl.37.2017.02.06.20.10.26; Mon, 06 Feb 2017 20:10:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752855AbdBGEKQ (ORCPT + 25 others); Mon, 6 Feb 2017 23:10:16 -0500 Received: from mail-pf0-f174.google.com ([209.85.192.174]:35559 "EHLO mail-pf0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752783AbdBGEKN (ORCPT ); Mon, 6 Feb 2017 23:10:13 -0500 Received: by mail-pf0-f174.google.com with SMTP id f144so29438180pfa.2 for ; Mon, 06 Feb 2017 20:10:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=vcNWR2pVOzfqZPZUAT0KgNsOy4TSnQAPuoY3WnMaYaI=; b=O++kN7sohfKBTPl+YuGiUoKdN4qjNJox6bzk2Wfm46g6K+uZKzPwJYWAPPqMQ6JXy5 Vc8tKdiwsuN0IKm96MAntDsNZiujdXImMPRU1s91NIkA+4B3HrJTVt2FaqaK75zc66dH e21oUPtYpLMVdNBKSxiE1YgrkWSwbYppNHrGw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=vcNWR2pVOzfqZPZUAT0KgNsOy4TSnQAPuoY3WnMaYaI=; b=tmnpHJylmh5A6wWcsCjQ8qqTbeN1dNFyvh/hhEhtyU2VyJ9+6Axmr5y757O6J1O636 im2tKA/Uf1csgTMLxP/P6um2EIcNUtme7UzbYNWICoWTyrwH32QnIE9JWY4quZ67WeIt JCO3QL2tjjm1trLug/ZMdSF+UdSl9JnDFErZLkZaLazxXDME0Ux7FJeWfLGs6OnSqONe cRmNFC8XHnvn3r/zJFOJ00AI6DQ0UQxdD7/epjomoyt3dA1iwLzJBS5uDYwGkiUMMqCd nbtLF4CblQsaNvga2V6yM802MUsfEiwsqLSm+h9+vxzFLXznL2skLvWmuUKd2qzoKVHd bdlw== X-Gm-Message-State: AIkVDXKb6bc3dF5p7AS/uGO024l3y5MKd8HltRj4w7lRvnV8BGAqNPiTlEzHK6FW9aeae9Lp X-Received: by 10.99.96.9 with SMTP id u9mr17985052pgb.151.1486440613175; Mon, 06 Feb 2017 20:10:13 -0800 (PST) Received: from localhost ([122.172.165.189]) by smtp.gmail.com with ESMTPSA id d124sm6219982pga.30.2017.02.06.20.10.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Feb 2017 20:10:12 -0800 (PST) From: Viresh Kumar To: Rafael Wysocki , rui.zhang@intel.com, edubezval@gmail.com Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Vincent Guittot , dan.carpenter@oracle.com, Viresh Kumar Subject: [PATCH V2 2/5] thermal: devfreq_cooling: Replace dev_warn with dev_err Date: Tue, 7 Feb 2017 09:40:02 +0530 Message-Id: <992f71aa060655e45dd32349275773e760141948.1486440448.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.7.1.410.g6faf27b In-Reply-To: <79611a51240c83504c35a8739fe8e1837e903671.1486440448.git.viresh.kumar@linaro.org> References: <79611a51240c83504c35a8739fe8e1837e903671.1486440448.git.viresh.kumar@linaro.org> In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There isn't much the user can do on seeing this warning, as the hardware is actually okay. dev_err suits much better here. Signed-off-by: Viresh Kumar --- drivers/thermal/devfreq_cooling.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.7.1.410.g6faf27b diff --git a/drivers/thermal/devfreq_cooling.c b/drivers/thermal/devfreq_cooling.c index cf71550b9d00..218ccc30c7ad 100644 --- a/drivers/thermal/devfreq_cooling.c +++ b/drivers/thermal/devfreq_cooling.c @@ -229,9 +229,9 @@ get_static_power(struct devfreq_cooling_device *dfc, unsigned long freq) dev_pm_opp_put(opp); if (voltage == 0) { - dev_warn_ratelimited(dev, - "Failed to get voltage for frequency %lu: %ld\n", - freq, IS_ERR(opp) ? PTR_ERR(opp) : 0); + dev_err_ratelimited(dev, + "Failed to get voltage for frequency %lu: %ld\n", + freq, IS_ERR(opp) ? PTR_ERR(opp) : 0); return 0; } From patchwork Tue Feb 7 04:10:04 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 93507 Delivered-To: patch@linaro.org Received: by 10.140.20.99 with SMTP id 90csp2023779qgi; Mon, 6 Feb 2017 20:10:27 -0800 (PST) X-Received: by 10.84.224.5 with SMTP id r5mr829883plj.179.1486440627078; Mon, 06 Feb 2017 20:10:27 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p23si2780932pfl.37.2017.02.06.20.10.26; Mon, 06 Feb 2017 20:10:27 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752897AbdBGEKX (ORCPT + 25 others); Mon, 6 Feb 2017 23:10:23 -0500 Received: from mail-pg0-f52.google.com ([74.125.83.52]:33829 "EHLO mail-pg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752864AbdBGEKV (ORCPT ); Mon, 6 Feb 2017 23:10:21 -0500 Received: by mail-pg0-f52.google.com with SMTP id 14so34617612pgg.1 for ; Mon, 06 Feb 2017 20:10:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=2+5+QGX/QwRfwwGCj5kNbRMbUfI9/jIJWkgJkdurW1g=; b=h4Rsuf8hs9OVC3mGWqonTmvUHLTGBc+1acNPg6vTQNTI4IjP1XxTLF1o4P8jecwQGZ otrJCzPpt1Bp7WjxdAH39WIeqksUhT2MbnLQPs4rW0SfXDS4PIJ1NkS4/oex+HEJRQ8x crbgz6Dv1BhP2Mm+2JRtQp3Rx7Uq9ZNuQ9MS4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=2+5+QGX/QwRfwwGCj5kNbRMbUfI9/jIJWkgJkdurW1g=; b=tXHvxjPZXy0sqndBXIYK3sPhM1X4quf4v33XpDPe+eWyNFdjAOfXl8GNuQiUfmchBH 6w/gRc8rP/+GgugM2t+vh/79MV9BcbGDvCN/kcUFjQOPu0+gxevrygqGbRu4ILdHxwUq 65VNBBQ+FLq7Lnm/JRHg76tCJPd1w1i1P6e+22Kmi672olHACkU5VjI8Vu3ypl2xBkXn 8/m/iWx9oZC4OR0tAGP/9pCag2Cyky4WG3dfcLRzhIQGxuLD3945m+D6UUJo6blNL6C4 rhnEqvyMlx1hDcd3DPpKE7BIootm0z+NsH6j5cd9VRPCk+dK9Za7TtyZTgShy45onnxa uJjA== X-Gm-Message-State: AIkVDXLab39VUHyi1CQ5tmv12dteSPZToHB97wPENj0bC0NjMAQ0YDy2gwMUNVcFbHnOMQ9s X-Received: by 10.84.142.101 with SMTP id 92mr22549626plw.66.1486440620299; Mon, 06 Feb 2017 20:10:20 -0800 (PST) Received: from localhost ([122.172.165.189]) by smtp.gmail.com with ESMTPSA id g70sm6210965pfb.50.2017.02.06.20.10.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Feb 2017 20:10:19 -0800 (PST) From: Viresh Kumar To: Rafael Wysocki , rui.zhang@intel.com, edubezval@gmail.com, Amit Daniel Kachhap , Viresh Kumar , Javi Merino Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Vincent Guittot , dan.carpenter@oracle.com Subject: [PATCH V2 4/5] thermal: cpu_cooling: Replace dev_warn with dev_err Date: Tue, 7 Feb 2017 09:40:04 +0530 Message-Id: <89f2241a0059167d6e6b333854fe654c86de07ab.1486440448.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.7.1.410.g6faf27b In-Reply-To: <79611a51240c83504c35a8739fe8e1837e903671.1486440448.git.viresh.kumar@linaro.org> References: <79611a51240c83504c35a8739fe8e1837e903671.1486440448.git.viresh.kumar@linaro.org> In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There isn't much the user can do on seeing these warnings, as the hardware is actually okay. dev_err suits much better here. Signed-off-by: Viresh Kumar --- drivers/thermal/cpu_cooling.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) -- 2.7.1.410.g6faf27b diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c index 85fdbf762fa0..caaaeb3ac0f0 100644 --- a/drivers/thermal/cpu_cooling.c +++ b/drivers/thermal/cpu_cooling.c @@ -435,9 +435,9 @@ static int get_static_power(struct cpufreq_cooling_device *cpufreq_device, dev_pm_opp_put(opp); if (voltage == 0) { - dev_warn_ratelimited(cpufreq_device->cpu_dev, - "Failed to get voltage for frequency %lu: %ld\n", - freq_hz, IS_ERR(opp) ? PTR_ERR(opp) : 0); + dev_err_ratelimited(cpufreq_device->cpu_dev, + "Failed to get voltage for frequency %lu: %ld\n", + freq_hz, IS_ERR(opp) ? PTR_ERR(opp) : 0); return -EINVAL; } @@ -721,9 +721,9 @@ static int cpufreq_power2state(struct thermal_cooling_device *cdev, *state = cpufreq_cooling_get_level(cpu, target_freq); if (*state == THERMAL_CSTATE_INVALID) { - dev_warn_ratelimited(&cdev->device, - "Failed to convert %dKHz for cpu %d into a cdev state\n", - target_freq, cpu); + dev_err_ratelimited(&cdev->device, + "Failed to convert %dKHz for cpu %d into a cdev state\n", + target_freq, cpu); return -EINVAL; }