From patchwork Thu Apr 9 08:28:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: madhuparnabhowmik10@gmail.com X-Patchwork-Id: 216078 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16085C2D0EA for ; Thu, 9 Apr 2020 08:29:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E0AD52082D for ; Thu, 9 Apr 2020 08:29:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MUEXAxyo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726671AbgDII3A (ORCPT ); Thu, 9 Apr 2020 04:29:00 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:36121 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726663AbgDII3A (ORCPT ); Thu, 9 Apr 2020 04:29:00 -0400 Received: by mail-pf1-f194.google.com with SMTP id n10so3808307pff.3; Thu, 09 Apr 2020 01:29:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=0HXV8vx9Be0BBihyhMob71nh1LkIaEr5epGWg9GzRAU=; b=MUEXAxyoTdSoolqIbRRVACRTGku/CrRdwrnfri3FU7m1CGWxvVxECyJzNjlzoqEsKx 3F4wPoUnPw9Kuzp/PVK1EZi9PKkRunyMAcxg9R/YOyGp5tIrKrpjXWEUrlpLOJOWBzUD obPKIv5NLJclwMiHJMYvdi7BAiqeOxWl8X/mhTECRPJ9/Eld7HjSPlVuifZme/saoNlL r7USy8sMvD85yB/97jF8qGDDQ2P63+yhXJqbcB5PJrASY94EGnAi3CmWe/DK9SxyfXu3 3EUfwTX31XHnMhbzoahy0Jh91k/5CiQiM9jr7e97x7EuVBBI/A0B6jKgznf21CII8MWK pJ7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=0HXV8vx9Be0BBihyhMob71nh1LkIaEr5epGWg9GzRAU=; b=GGAF0G0KBZSdBn9vB6CdBJkZTzgEUzkWAxNLCJyn9v9AK0n0yfpMJZL3tyonJadkrS /0WXo/hQzA97oVstCVoDweRjrYgu7AMYbC14+7c8xH42J9np48swbEBMwPMD1yM5CgyA RsuGYw69xTocHkjl2jxakGEo6c5Ei7/Zehk2QhOjlxhUiQA60yS5kNYU37KyEymfdcVz gOpwk8BeMx4Zec4s8eLW5uolNfEKwTadAqrwTClKCevgqcI1igV802QeZBta5q+mwG5N QC6+8VZWsLkxL7yeHC4q2gMXfbZFEC2yPwsdtqPiyLW8fGzET9EReA2LOltbtiifB3k/ M9/Q== X-Gm-Message-State: AGi0PuZ9i4kXGn5z20vtYaNGMM4fl41XQ7LyxBgr8mW1hCutRoMDwJoo 1x9xQSIy+/C1Fu3woSfNyA== X-Google-Smtp-Source: APiQypJMUo7McfIjWzcXnjJmz+8h35KmF64lZDJ+qnUEu0I5lgVqNGuknsQBsn/cgMScS/uFl60oLQ== X-Received: by 2002:a63:e56:: with SMTP id 22mr10914839pgo.173.1586420939939; Thu, 09 Apr 2020 01:28:59 -0700 (PDT) Received: from localhost.localdomain ([2402:3a80:13be:8fdf:25a2:66e2:761f:9d4c]) by smtp.gmail.com with ESMTPSA id h10sm17615674pgf.23.2020.04.09.01.28.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2020 01:28:59 -0700 (PDT) From: madhuparnabhowmik10@gmail.com To: johannes@sipsolutions.net, davem@davemloft.net, kuba@kernel.org Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, frextrite@gmail.com, joel@joelfernandes.org, paulmck@kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, Madhuparna Bhowmik Subject: [PATCH 2/4] net: mac80211: scan.c: Fix RCU list related warnings. Date: Thu, 9 Apr 2020 13:58:49 +0530 Message-Id: <20200409082849.27372-1-madhuparnabhowmik10@gmail.com> X-Mailer: git-send-email 2.17.1 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Madhuparna Bhowmik This patch fixes the following warning: WARNING: suspicious RCU usage [ 84.530619] 5.6.0+ #4 Not tainted [ 84.530637] ----------------------------- [ 84.530658] net/mac80211/scan.c:454 RCU-list traversed in non-reader section!! As local->mtx is held in __ieee80211_scan_completed(), no need to use list_for_each_entry_rcu() (use list_for_each_entry() instead.). Signed-off-by: Madhuparna Bhowmik --- net/mac80211/scan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/mac80211/scan.c b/net/mac80211/scan.c index fdac8192a519..0860f028ab2a 100644 --- a/net/mac80211/scan.c +++ b/net/mac80211/scan.c @@ -451,7 +451,7 @@ static void __ieee80211_scan_completed(struct ieee80211_hw *hw, bool aborted) * the scan was in progress; if there was none this will * just be a no-op for the particular interface. */ - list_for_each_entry_rcu(sdata, &local->interfaces, list) { + list_for_each_entry(sdata, &local->interfaces, list) { if (ieee80211_sdata_running(sdata)) ieee80211_queue_work(&sdata->local->hw, &sdata->work); } From patchwork Thu Apr 9 08:29:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: madhuparnabhowmik10@gmail.com X-Patchwork-Id: 216077 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2408C2D0EA for ; Thu, 9 Apr 2020 08:29:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6906920BED for ; Thu, 9 Apr 2020 08:29:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UeBYraYa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726728AbgDII3g (ORCPT ); Thu, 9 Apr 2020 04:29:36 -0400 Received: from mail-pj1-f66.google.com ([209.85.216.66]:50689 "EHLO mail-pj1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725987AbgDII3g (ORCPT ); Thu, 9 Apr 2020 04:29:36 -0400 Received: by mail-pj1-f66.google.com with SMTP id b7so1010658pju.0; Thu, 09 Apr 2020 01:29:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=F8gyLVop1Ch0gKbGVHgodmcnCvN85X6SPXoRalm/4uY=; b=UeBYraYaZuRxL0liXfpT3eVN66/M7EoV5rBCI8IzWjSmRtb+2fS8VCoKQMRNiiNNPI GQtwO3Bb29klU3jizxQRTERoAEXMyuzs1GZ8SHeaPbBLrD4BxH76imlRAO696yJeT/r2 qBIrWD7A+ldxeRNDjELWGTGbyz2IHckScRapPjH+TRr2QELy92KzJehjWMqTb4aTYhtu 6onqsCgA3u6/XIdsuxQIbr6F331I1soaJ+j5c4fo43C9LhUUj+dNReGxEjJfbh6LKXa4 3cGcDbF00vMoIY6Givp1/PKfafreL5o5/vA6obHT0zDpScse921LkE8zqJb/dXCvp59B Osyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=F8gyLVop1Ch0gKbGVHgodmcnCvN85X6SPXoRalm/4uY=; b=k17Lh734EagITwH2O1h0HwNIvTKwyC4IDOPoItgtq6/LC3tKWetqM3mERr3kHBNUIP Lb6sNN0+wNJF80lOnTeRK/J+CGnZEMl4+TGgHNmcwzRFIzLmlnCqLHg1oYEady3e/muJ KFZxuXHqzSABSXB/j+3l1qxc/bMX3Xt3UuOd9/WPZ24wKeF0JrqcO3qwmnAGc/nfV7y4 pIkNeshxTEFwUu73SPZDsxHm1/rRFZx2XnhXoiN0nJMH6+AuQ4ooWq2599wJT6Sx5RgF 8V3utfuloprOuF3l0d3v19NJTqRacXcGzOC5Vb77b29ZVLoa3UKBFM562jT5b927Jmm6 SJZQ== X-Gm-Message-State: AGi0Pub/xSeM6tE5n8vNNK0pN5rASRyr29rNZi3qhlxog96WsdgUlItY rPDj40s8/4jshS5GAdnchw== X-Google-Smtp-Source: APiQypJOJq7j0sm89Vt3qi8RrEHe8B14IxsT3T/FfEhZcmU+VsnMmS2Hw8QCmcgk7K/Ke/8ZAy4FBQ== X-Received: by 2002:a17:90b:24f:: with SMTP id fz15mr9986110pjb.138.1586420975683; Thu, 09 Apr 2020 01:29:35 -0700 (PDT) Received: from localhost.localdomain ([2402:3a80:13be:8fdf:25a2:66e2:761f:9d4c]) by smtp.gmail.com with ESMTPSA id y19sm19170866pfe.9.2020.04.09.01.29.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2020 01:29:34 -0700 (PDT) From: madhuparnabhowmik10@gmail.com To: johannes@sipsolutions.net, davem@davemloft.net, kuba@kernel.org Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, frextrite@gmail.com, joel@joelfernandes.org, paulmck@kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, Madhuparna Bhowmik Subject: [PATCH 4/4] net: mac80211: mlme.c: Add lockdep condition for RCU list usage Date: Thu, 9 Apr 2020 13:59:25 +0530 Message-Id: <20200409082925.27481-1-madhuparnabhowmik10@gmail.com> X-Mailer: git-send-email 2.17.1 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Madhuparna Bhowmik ieee80211_add_vht_ie() is called with sdata->wdev.mtx held from ieee80211_send_assoc(). Add lockdep condition to avoid false positive warnings. Signed-off-by: Madhuparna Bhowmik --- net/mac80211/mlme.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c index 16d75da0996a..ef64b3e91ce6 100644 --- a/net/mac80211/mlme.c +++ b/net/mac80211/mlme.c @@ -590,7 +590,8 @@ static void ieee80211_add_vht_ie(struct ieee80211_sub_if_data *sdata, bool disable_mu_mimo = false; struct ieee80211_sub_if_data *other; - list_for_each_entry_rcu(other, &local->interfaces, list) { + list_for_each_entry_rcu(other, &local->interfaces, list, + lockdep_is_held(&sdata->wdev.mtx)) { if (other->vif.mu_mimo_owner) { disable_mu_mimo = true; break;