From patchwork Tue Jul 7 14:00:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 235000 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp941981ilg; Tue, 7 Jul 2020 07:01:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwK0vHCxpIuFb0AeRpk1Gtli86U7b77DB1HENDVciTp1OZkTkFHpDek9EaTUD3XhD5UMv02 X-Received: by 2002:a50:d80f:: with SMTP id o15mr62634468edj.156.1594130463834; Tue, 07 Jul 2020 07:01:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594130463; cv=none; d=google.com; s=arc-20160816; b=elqKSvvWIjflklVi99tAKXU5wnLxpu01Hey8j1T2p1Z/UJzWJoQafgZ/3bAewVdU8G FsRMkMsEwXApxoNzs0ybuLTQbJr1rQP85511R2qtV/ndggJ/ZYWHCeq9Kw1sc3n90DuF N1gvCJGzEHmEki+sfjsfWvhzDX2b4alXm3NaaHfPC1KIUiD7Z7kHINUOpPYhzZR7ZQfL Gm9v6t4ahePSf7x98vKNOVlpNaVgk4cD54R+oLeWwl4Y6pAjpG9G5Oj7ckvkAcy67Q01 8KA68d7l1GeU5VuZwuCb+RafiajafOQsLkU/75frVAeEIjMxVwOFm++WBNTol3QKgc2N SRtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ZLWYFu8kb1BK0vYr47DoG19cZZy4irme69VcrjTwQ6E=; b=s5zBsDEZZDvw+RfhuOSIK7wweN9tphdR9E7ZbgcCwSG4K9Je8oEKEzWwA6zQHtireM tCKgRR5DEW8b6JX/XkfPVYP/2HFygYDcH2d4EYen5fg1wws437vIlSBa64bXc0UUYykV 6mkZyz6HAX9K9nG1KmGVPdtlfg27+8X7cIurd4QbmjdO9hEnwY0g6GrFyRimcew7y0f7 D/QvBnmK5WP1wZf26DB+zpYvGJu5DAmH4lelPLHGbbjR+tqFV1hwBaZIIaAC2DNagTv1 vygu3WsSzAlTNWFoPj1a55H5Om23wot7iRhSyfeyZtIGmeNyfpq/kRYzcriz3Qa5RGbE 0KCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=dBcHaJgD; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c22si16608055edx.584.2020.07.07.07.01.03 for ; Tue, 07 Jul 2020 07:01:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=dBcHaJgD; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728061AbgGGOBC (ORCPT ); Tue, 7 Jul 2020 10:01:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727090AbgGGOBB (ORCPT ); Tue, 7 Jul 2020 10:01:01 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 355AEC061755 for ; Tue, 7 Jul 2020 07:01:01 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id 17so46585551wmo.1 for ; Tue, 07 Jul 2020 07:01:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZLWYFu8kb1BK0vYr47DoG19cZZy4irme69VcrjTwQ6E=; b=dBcHaJgD24aprqBmfheHZZJ/02Un4ePwTgSuWV0qJltGAhKjZJ+jax2Rsz4WQvNMtl H3tshEqaE10oB9P9UPfJ+0JHokUGzwrnD/TWTdFkDhSdm/UCYiNJ755SDJi1rbvyWqtg zk+K/Qb6/6K5QO+pBmYAMjCKVyUFD2o2NLTCmKg3oiU0g58EMzJ4wCB8Rhj8SaeLGS4k csnB4Y7CWjhJy/Dgu5RYFaQOaw6Zmz/17F8Ynx5A//PAdRG7t3u2KZ2VTxynKul48+rl TPIHaQhDL1AeiEMRzucUS8l4+Xr60IOFu214FcMPh3XBa1ZAr6Tcc+BuJCuZqJ0Q27i8 s+lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZLWYFu8kb1BK0vYr47DoG19cZZy4irme69VcrjTwQ6E=; b=HpM5WC1RCXv/FwvX0mDyjqyxTaR4Hj4EW6HJuFMQ/baGP4E9TeuXQpH1Zjwsinli0T Aqu10BYTw2joYk0cPh+IQTbtbuAgxnv/LWeU2zywMQk3UJj1i/2YilqPWTkLm1ic2H4R z/NG0nBnijFWwL/ZGqko0+DPQGZb/MFNwTKu9MsfgODTSzzS1/kcmus+/cKkWRu3HO/l aCTXBHkXgQYZTpZJVYcr+jBz3EfNgAznjHlmkWG4PdxFzehbkbT056rhlYHlx2pLlbLN QuK6niXPPVCdhOXvZKaroymy1IEYt8OY7waFKlo08quUvY3U4wgDj/pKVe9Mhq+U7cAa oPzw== X-Gm-Message-State: AOAM533+09TySn/UH7U5aU/szkNtmsSKRtwjlzFLtRqqh0CoLjSwuKAR vsVrBS5+o/CTV98wyUpY+jsJIw== X-Received: by 2002:a7b:c09a:: with SMTP id r26mr4280907wmh.176.1594130459913; Tue, 07 Jul 2020 07:00:59 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id z25sm1102823wmk.28.2020.07.07.07.00.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 07:00:59 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , Kashyap Desai , Sumit Saxena , Shivasharan S , megaraidlinux.pdl@broadcom.com Subject: [PATCH 01/10] scsi: megaraid: megaraid_mm: Strip excess function param description Date: Tue, 7 Jul 2020 15:00:46 +0100 Message-Id: <20200707140055.2956235-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200707140055.2956235-1-lee.jones@linaro.org> References: <20200707140055.2956235-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/megaraid/megaraid_mm.c:105: warning: Excess function parameter 'inode' description in 'mraid_mm_ioctl' Cc: Kashyap Desai Cc: Sumit Saxena Cc: Shivasharan S Cc: megaraidlinux.pdl@broadcom.com Signed-off-by: Lee Jones --- drivers/scsi/megaraid/megaraid_mm.c | 1 - 1 file changed, 1 deletion(-) -- 2.25.1 diff --git a/drivers/scsi/megaraid/megaraid_mm.c b/drivers/scsi/megaraid/megaraid_mm.c index e83163c668845..8df53446641ac 100644 --- a/drivers/scsi/megaraid/megaraid_mm.c +++ b/drivers/scsi/megaraid/megaraid_mm.c @@ -95,7 +95,6 @@ mraid_mm_open(struct inode *inode, struct file *filep) /** * mraid_mm_ioctl - module entry-point for ioctls - * @inode : inode (ignored) * @filep : file operations pointer (ignored) * @cmd : ioctl command * @arg : user ioctl packet From patchwork Tue Jul 7 14:00:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 235009 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp942701ilg; Tue, 7 Jul 2020 07:01:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJydHk2lyAP/pvd6g+aJhqps3SGG+8ANBPumtQhfvxeCpb7kJ2qT2K+MBSsauERsFoyhBY9h X-Received: by 2002:a50:9605:: with SMTP id y5mr9725144eda.388.1594130499614; Tue, 07 Jul 2020 07:01:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594130499; cv=none; d=google.com; s=arc-20160816; b=SoGkyY/mcbIgCLyIMu4Ok6S63dgsAgpvDqwTLn29sTUR37W0qja6pMqB6Ht17AExlR vfgDTxaLBr23M1HmzH/+gRXFjjbB9BgXDf5XHCAY/deVsTPLydjuOUnzLD17pmMc67UZ zMKI09ydU5ciiz9fgqtgS8vjVwAmBq/jwdTh+8Fc9vv37t4P3YBOd0JDm23A7TTd87Re yrRNhyRDmXtDsYtveyLljsGvAIAFS/VfA+U7mYzSFuV2TueuUTUbGE39xuour9Lh1ZiY rao+ptjI0mYeJRpOVSEkpb6JfZLWx1mfEneR055/SyvA49XJlDkWXnPnOxWGLm0oXgNB cBXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=jN1nbT1sxQbFlRXUCBfggkW/hnjjJGCQVCG/NPTfu6Y=; b=MCpj0ZtW5SolXxGrANSP9JBhl0n2Q98ZkS2xfk1NuZPZ4dzaALB+VgFj9pVzYto9Hh CbWnDEIbndmmR3lBF4v8QWAoXO4iphfZil/MVE5OA93G0jJ2Hz86BQ+1LhfwRaBps8bu hzkvqjR890VAy4BVycy03xLkycbf5A84K751XGLX18XI3XlmZSfmNFZCzC47EcoamTfU QHaiIos7zRPM5PBAhKG9kqLd1KqsfD2Z9sC0nYdIUNRF9q6nqzwhGzFrnE7t/D9eUn0A LQvkfGEeIZOl1mtVGi8WA4Akcuj6zxKk+Cpx82NZ5UH8TFmUVHP5Rs7a7PlPQaUfnF7L ggYw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=pjWCUJEZ; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z7si15654865edp.327.2020.07.07.07.01.39 for ; Tue, 07 Jul 2020 07:01:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=pjWCUJEZ; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728337AbgGGOBj (ORCPT ); Tue, 7 Jul 2020 10:01:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728073AbgGGOBD (ORCPT ); Tue, 7 Jul 2020 10:01:03 -0400 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 172FBC061755 for ; Tue, 7 Jul 2020 07:01:03 -0700 (PDT) Received: by mail-wm1-x336.google.com with SMTP id 17so46585638wmo.1 for ; Tue, 07 Jul 2020 07:01:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jN1nbT1sxQbFlRXUCBfggkW/hnjjJGCQVCG/NPTfu6Y=; b=pjWCUJEZwyPxA5RaPU66fCI6rKNgDNOxWlKt8d8YsnOGnz9+M2K1koQ7iG9eKhjaFx g8YYXzC7TkDHe9hJ+8+ILM1uoCB/M+MHWG34tN2gn70O8IytBqRJWMHsFxODpQitWvEe sT1z3OQLglHZy7jLwHM8UGQsPz8CNy8aRD+rEndm5AA2TpFh6opalazJ6fET6JTQdH6o +tipp3x4BsKQaEnJZRxgT8WT7DN2KIDtAgsdP5DvogsK2YWShtueljfN3tKDaAN+lpu2 YLnIN4NNKIPdCd2/DMVhL0hcCLI01P4Qqh9eyPNxWoFhcq6sDnQe2S9JbIZ4IQOte1b9 to+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jN1nbT1sxQbFlRXUCBfggkW/hnjjJGCQVCG/NPTfu6Y=; b=mcApt7Lfocpid/R8wJvCTy+Daya8/13PATonmZSoU4ncgt0j5z7IQ/oZaxf9ISk756 tt/V56b0L5QqwaUFA3z1Fjn9M13inc7HFMXK8q6k5QeFIY+v92F6JDmTLfnOfI1dbt34 wnfgAh+RpJpUl5J2M3b068qf1Zk32cAo3Ov12pDLsAQ0OtbbylbQf84o8KrxmXpKheHd X7KMPyl5Zr1Eqh4K2Y5hpD4i7P2hxbK0xHZt5rHKwYWh1xt+4586xmuLCdo5mUMEGpDR ZkS9S3gjb7CNUejlEnZYDsZnvd+T9f5PBfcxE85HI70PYspMkk2iOtXTlnyn/hmWolX2 yZrw== X-Gm-Message-State: AOAM5316cPnHPxX7l9EU+xMh7TAhaGtuJD+eVi+58Uxl6hbdMGd+doCf bAx+Q8yM24DubxDC7S9pVGtv5gDm8w8= X-Received: by 2002:a1c:4303:: with SMTP id q3mr4547681wma.134.1594130461172; Tue, 07 Jul 2020 07:01:01 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id z25sm1102823wmk.28.2020.07.07.07.01.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 07:01:00 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , Kashyap Desai , Sumit Saxena , Shivasharan S , Atul Mukker , Sreenivas Bagalkote , Manoj Jose , megaraidlinux@lsi.com, megaraidlinux.pdl@broadcom.com Subject: [PATCH 02/10] scsi: megaraid: megaraid_mbox: Fix some kerneldoc bitrot Date: Tue, 7 Jul 2020 15:00:47 +0100 Message-Id: <20200707140055.2956235-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200707140055.2956235-1-lee.jones@linaro.org> References: <20200707140055.2956235-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Some function parameters have changed without updating the documentation. Fixes the following W=1 kernel build warning(s): drivers/scsi/megaraid/megaraid_mbox.c:3314: warning: Excess function parameter 'level' description in 'megaraid_mbox_display_scb' drivers/scsi/megaraid/megaraid_mbox.c:3985: warning: Function parameter or member 'dev' not described in 'megaraid_sysfs_show_app_hndl' drivers/scsi/megaraid/megaraid_mbox.c:3985: warning: Function parameter or member 'attr' not described in 'megaraid_sysfs_show_app_hndl' drivers/scsi/megaraid/megaraid_mbox.c:3985: warning: Excess function parameter 'cdev' description in 'megaraid_sysfs_show_app_hndl' Cc: Kashyap Desai Cc: Sumit Saxena Cc: Shivasharan S Cc: Atul Mukker Cc: Sreenivas Bagalkote Cc: Manoj Jose Cc: megaraidlinux@lsi.com Cc: megaraidlinux.pdl@broadcom.com Signed-off-by: Lee Jones --- drivers/scsi/megaraid/megaraid_mbox.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.25.1 diff --git a/drivers/scsi/megaraid/megaraid_mbox.c b/drivers/scsi/megaraid/megaraid_mbox.c index 8f918df631bfe..cace28dd81ad8 100644 --- a/drivers/scsi/megaraid/megaraid_mbox.c +++ b/drivers/scsi/megaraid/megaraid_mbox.c @@ -3304,7 +3304,6 @@ megaraid_mbox_fire_sync_cmd(adapter_t *adapter) * megaraid_mbox_display_scb - display SCB information, mostly debug purposes * @adapter : controller's soft state * @scb : SCB to be displayed - * @level : debug level for console print * * Diplay information about the given SCB iff the current debug level is * verbose. @@ -3972,7 +3971,8 @@ megaraid_sysfs_get_ldmap(adapter_t *adapter) /** * megaraid_sysfs_show_app_hndl - display application handle for this adapter - * @cdev : class device object representation for the host + * @dev : device object representation for the host + * @attr : unused * @buf : buffer to send data to * * Display the handle used by the applications while executing management From patchwork Tue Jul 7 14:00:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 235001 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp942062ilg; Tue, 7 Jul 2020 07:01:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJybJoXBh7DTYUBoKewHs4epvuVJMcI3jykkldavCrAsIN/1dS8SAwJAyTdgCwobrwAxOPsY X-Received: by 2002:a17:906:29d8:: with SMTP id y24mr47022465eje.212.1594130468225; Tue, 07 Jul 2020 07:01:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594130468; cv=none; d=google.com; s=arc-20160816; b=l4bfjorSHIXR3i1jZQU0P5BPjQXHd//eNnNjga6Oynj5ECCfe+EtCiE2OvhuFZdSZ8 8rjrD8YY0TXQxZbxED21rGx790Vb6V26UP86zwG9QWFPOS4TXR8euLoIuZFuTaRAkVbN 6Xcx7EpOMqzNs6ikoehCPLQQecyy5BkQRe6SWa1aE9cdtBoQOrFKkvXB+JnbA8ahGBKN SzE2XByujCXIF13dWqmNJYzHsN1WiTCSzXdJ8HWkFXywbUk8+IWUHyB7nyjLj9mi/5dq Q8QN6riMt1Y86ye72IFNUDFnGLdtrZASjgJKMAKFu5cXsov1YqKoDIWAkX6ONxgmVvl6 h2vQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=/cqZIdFqcpIXxhTbwotqjldLYbQ1H9RlyQjCdSkXyGs=; b=HcW3oj1Q5I9eWHA73fk/4vhbju164JUtInmXRKUAM186z/Yx7KN7pm5FAAcZVlvXlh bZDb9uwbubM6UAcR1d1SCzeFOgUm4KxwbFaAj3Zlz4Qs/1Wv6+vl/d0JbDCk/BUkU1MC cgvdxUfE3kDn9EBoTpgt4udroPM7Pt19Dby6HpbCDx0r83uGw7l6t/2tkDTmOgh1bt1p 36gq6BKdXXMLiLxd2eC5XQtoLKPydKYLjw7xou7xYNPV8sGMZlGcuaxzopTNDLfv27IL lAVMYh4Jiu9t70XsS5hFsYxgI2BBCIaX9NPBavgvzpAAHjYsO6YLiamOe8HvF/ems/WM FTgw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="DY/Y6rRC"; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c11si15637034edr.502.2020.07.07.07.01.08 for ; Tue, 07 Jul 2020 07:01:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="DY/Y6rRC"; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728179AbgGGOBG (ORCPT ); Tue, 7 Jul 2020 10:01:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728155AbgGGOBE (ORCPT ); Tue, 7 Jul 2020 10:01:04 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF981C08C5E3 for ; Tue, 7 Jul 2020 07:01:03 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id 22so43400524wmg.1 for ; Tue, 07 Jul 2020 07:01:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/cqZIdFqcpIXxhTbwotqjldLYbQ1H9RlyQjCdSkXyGs=; b=DY/Y6rRCsOjNTJ4MkMoPwBn+t6tp8Ea3aR3cwKW07HPMrJatmNWyjsxXWn8QkYDC9A MjrEbwgrbgZZxlHsmKUvipQUvak0bqLJ9f+zQwDGAQFTgW54RkqkMz/JGF+4e5i78Q/c 2KBqbs2XOY808AW/smRWfFkGiaf9aMa713477C90tUkPIRj74nGwK2SRjYtBnft1e8i3 IVkvAi1yYxYJ37bqk704jsA8Ompe5sVbx1WP9CxrdUjsqIps8siu/zYqjiAuTHQrJdCb 41vt5Gk8sl8yd0WJ0DpcW5y/WTCY7ErzeiiIJe2KAXO8GRuw9+Oe0ws8P8hbK/NUezih UwYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/cqZIdFqcpIXxhTbwotqjldLYbQ1H9RlyQjCdSkXyGs=; b=IzCycpbrOfqPCPIISgru0kr7vzkWaSiV+Hh84ZE/lnr1XhvILA7FJzRaQpBEhZinZr 1dsicmN9VidG0GE1xTQMXPptQzqPgZfOfdNjVHDDIk6Aiv2DhrnwWypXOceYxoDlVzt1 CMeH3K1R6mms2Pk46DDqmmSEPGncs/mO981tT7YXsy8tREQYDuwJBTBfSBKVYtaMXSmZ x9HOMrIGZ24+nyWaw/8VeIuRVJCoF+Nq8rkq4rQHe9nBBM4g69yovsdrFlnr0U9t4ucd VPOufC+XSEJu3Sg2QEjNZaeExx9XFpNI4ics+4/9WaCyS558y4qMQFqBAJWdEdnGD80g 4tww== X-Gm-Message-State: AOAM531Cy7X6Z8nWsGL1sn2mTiQWieCwuNwCmzZUSeraRdl1bH/5t+q0 hz9Bk17uBtjsUc55IpgPA9/drw== X-Received: by 2002:a1c:49d4:: with SMTP id w203mr4610085wma.13.1594130462391; Tue, 07 Jul 2020 07:01:02 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id z25sm1102823wmk.28.2020.07.07.07.01.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 07:01:01 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones Subject: [PATCH 03/10] scsi: fdomain: Mark 'fdomain_pm_ops' as __maybe_unused Date: Tue, 7 Jul 2020 15:00:48 +0100 Message-Id: <20200707140055.2956235-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200707140055.2956235-1-lee.jones@linaro.org> References: <20200707140055.2956235-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Not all source files which include 'fdomain.h' make use of 'fdomain_pm_ops' leaving them defined but unused. Mark it as __maybe_unused to tell the compiler this is not only acceptable, but expected. Fixes the following W=1 kernel build warning(s): In file included from drivers/scsi/pcmcia/fdomain_cs.c:16: drivers/scsi/fdomain.h:106:32: warning: ‘fdomain_pm_ops’ defined but not used [-Wunused-const-variable=] 106 | static const struct dev_pm_ops fdomain_pm_ops; | ^~~~~~~~~~~~~~ Signed-off-by: Lee Jones --- drivers/scsi/fdomain.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.25.1 diff --git a/drivers/scsi/fdomain.h b/drivers/scsi/fdomain.h index 6f63fc6b0d127..93afcee207aed 100644 --- a/drivers/scsi/fdomain.h +++ b/drivers/scsi/fdomain.h @@ -103,7 +103,7 @@ enum { #define REG_FIFO_COUNT 14 /* R: FIFO Data Count */ #ifdef CONFIG_PM_SLEEP -static const struct dev_pm_ops fdomain_pm_ops; +static const struct dev_pm_ops __maybe_unused fdomain_pm_ops; #define FDOMAIN_PM_OPS (&fdomain_pm_ops) #else #define FDOMAIN_PM_OPS NULL From patchwork Tue Jul 7 14:00:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 235002 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp942077ilg; Tue, 7 Jul 2020 07:01:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwwfw8AN+K1UhT7BIonSBTfBGuIdDj1Z7vzI52US25SBd9jxret0PNxg2mgrU0vott8/2FQ X-Received: by 2002:a17:906:c150:: with SMTP id dp16mr46826072ejc.536.1594130468781; Tue, 07 Jul 2020 07:01:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594130468; cv=none; d=google.com; s=arc-20160816; b=WWfO2YdwrmIHOD3oTkbAdE1uU1pOhvqqsDhFEMKfRwloV2WvVvKtswZSLtvTbPMmuF pQyt7oYZTmRDar/P075M1c75EgKWrSStd0JKorJp7DX0ZMDQ4JgHx+NfKsZj6T3bqFU0 etXSi5MaAjkgV1L2EQziWi+Yh1E6nZdRa1EkzgIHcFAGdrKkTDML9GfzBTYo+e88faH0 ehwzLKvfGgifO+yBrykyK+dWB9vVlCRCQBaY2ismgUHosqA0kYL91irIasflkbHG/AGp /msgQu4oDGsoq5JKOK7KL73o+uw+CUUdvU3i/N0OL7qWoDltzrqkZxjVDv2eH5VujqW9 rsLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Uauyj1xy+L+/htMK5ksIUAg7Hy+icFikuL1ZKHn5ieg=; b=LWt7z5KxxD8FFEAUqmj7hdwmN1spWeeNf9hczdVToBONFFxGPMvo2Sb8Y/KD85WtW2 WoJy70/cQ4RsCp2/c1/pFvGftPnL2zY58u8pxNddKJlEniLnxZcJWWdBhP6vMs2PhWaC XvHvtzphzWeCo4XIqGqKvrIvmoLfkzNhCj/FBZk/ww7bexL5Dl+t0y9Z/Ipw3D1IhHzm 02kDfJdhNPwADii+ZDarolFXkCXUQjCkrDkiC5jZFxkky2prEMzjJYABasKToarJmO6z IgzB++2vt8dpYa5dmfZA3W8W4QZ/nYfGjIPx4Hlibwmt1mLKRWfDuE9kCMOxJRt7mUmO 2hoA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=X0VdXngJ; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c11si15637034edr.502.2020.07.07.07.01.08 for ; Tue, 07 Jul 2020 07:01:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=X0VdXngJ; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728188AbgGGOBH (ORCPT ); Tue, 7 Jul 2020 10:01:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727793AbgGGOBG (ORCPT ); Tue, 7 Jul 2020 10:01:06 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BDA01C061755 for ; Tue, 7 Jul 2020 07:01:05 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id o2so46636754wmh.2 for ; Tue, 07 Jul 2020 07:01:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Uauyj1xy+L+/htMK5ksIUAg7Hy+icFikuL1ZKHn5ieg=; b=X0VdXngJ93DIwxDMbMyZ1nk58HNjto/r57/NTazOTe/czfJ1X+ndWnxUIrt4mC2sko Bg9tEsmuJACn5nkgagX5dsQd3zqJXichqtOKyNGywBUekWWAmlgzyBKqkolKgNwDOR/4 EMAMoUGrqwHdUqmAcREP7TdENCahylOtUGAV/7Zj+45uHQMC3vKqkckD94TsYkpIfX70 lBxcBlWyb8f2tYZmO/Hp2ryf4gYWAxf9W8psNISB38HDNPx+kj0nzDIQvvkdDKDEtF0F 6lTtOU5ZXOtrVBqq81FwpPjV3NROGzzkGdYNfhiMMdblcBxvJnrcLNZ9V8cOa0ET93on Onlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Uauyj1xy+L+/htMK5ksIUAg7Hy+icFikuL1ZKHn5ieg=; b=VFXUSxC5PSHc4VvZRpeCOuEP5GKLDrZrsFqguMHnS+j8n1G3d3RC6B6a37eYA+OTVw CmufSrKQdIjjdoR2j62tRdxxPYAyVcdDlnjqc/2oK0KDSSaP3KeHW/tcMw25BYkK+urP p/QsuzaTLD+IMIIal+tfosIz6HEpH/ht8qYz7OQJhCDI032rdaasae7X8gwIADpYg08J 1KEv+DkwsfWdx3f4rD8Ee9toacHOQjqjig52Cw0QxH30V5sQfkIZnzb/QBAdYLR8zw5N GoBsbh5kUO6uFrbnE+TZUAqh8OHEc3enfkQ0+n+yAs4BYyA4TcJd0eUNwXyFt4O7xFPw XCXw== X-Gm-Message-State: AOAM531SAMwVi3f7/6cmQq/crrN9vAb7tW8cbSFwjZWW+c2fS8P/2rfY IE6fEnQ8BgDbqpRaIjnqUaLqvA== X-Received: by 2002:a1c:5418:: with SMTP id i24mr4169805wmb.47.1594130464199; Tue, 07 Jul 2020 07:01:04 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id z25sm1102823wmk.28.2020.07.07.07.01.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 07:01:03 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , Kashyap Desai , Sumit Saxena , Shivasharan S , megaraidlinux.pdl@broadcom.com Subject: [PATCH 04/10] scsi: megaraid: megaraid_sas_fusion: Fix-up a whole myriad of kerneldoc misdemeanours Date: Tue, 7 Jul 2020 15:00:49 +0100 Message-Id: <20200707140055.2956235-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200707140055.2956235-1-lee.jones@linaro.org> References: <20200707140055.2956235-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/megaraid/megaraid_sas_fusion.c:106: warning: Function parameter or member 'instance' not described in 'megasas_adp_reset_wait_for_ready' drivers/scsi/megaraid/megaraid_sas_fusion.c:106: warning: Function parameter or member 'do_adp_reset' not described in 'megasas_adp_reset_wait_for_ready' drivers/scsi/megaraid/megaraid_sas_fusion.c:106: warning: Function parameter or member 'ocr_context' not described in 'megasas_adp_reset_wait_for_ready' drivers/scsi/megaraid/megaraid_sas_fusion.c:159: warning: Function parameter or member 'instance' not described in 'megasas_check_same_4gb_region' drivers/scsi/megaraid/megaraid_sas_fusion.c:159: warning: Function parameter or member 'start_addr' not described in 'megasas_check_same_4gb_region' drivers/scsi/megaraid/megaraid_sas_fusion.c:159: warning: Function parameter or member 'size' not described in 'megasas_check_same_4gb_region' drivers/scsi/megaraid/megaraid_sas_fusion.c:181: warning: Function parameter or member 'instance' not described in 'megasas_enable_intr_fusion' drivers/scsi/megaraid/megaraid_sas_fusion.c:181: warning: Excess function parameter 'regs' description in 'megasas_enable_intr_fusion' drivers/scsi/megaraid/megaraid_sas_fusion.c:203: warning: Function parameter or member 'instance' not described in 'megasas_disable_intr_fusion' drivers/scsi/megaraid/megaraid_sas_fusion.c:203: warning: Excess function parameter 'regs' description in 'megasas_disable_intr_fusion' drivers/scsi/megaraid/megaraid_sas_fusion.c:246: warning: Function parameter or member 'blk_tag' not described in 'megasas_get_cmd_fusion' drivers/scsi/megaraid/megaraid_sas_fusion.c:323: warning: Function parameter or member 'fw_boot_context' not described in 'megasas_fusion_update_can_queue' drivers/scsi/megaraid/megaraid_sas_fusion.c:1025: warning: Function parameter or member 'seconds' not described in 'wait_and_poll' drivers/scsi/megaraid/megaraid_sas_fusion.c:1912: warning: Function parameter or member 'work' not described in 'megasas_fault_detect_work' drivers/scsi/megaraid/megaraid_sas_fusion.c:2001: warning: Function parameter or member 'fusion' not described in 'map_cmd_status' drivers/scsi/megaraid/megaraid_sas_fusion.c:2001: warning: Function parameter or member 'scmd' not described in 'map_cmd_status' drivers/scsi/megaraid/megaraid_sas_fusion.c:2001: warning: Function parameter or member 'data_length' not described in 'map_cmd_status' drivers/scsi/megaraid/megaraid_sas_fusion.c:2001: warning: Function parameter or member 'sense' not described in 'map_cmd_status' drivers/scsi/megaraid/megaraid_sas_fusion.c:2001: warning: Excess function parameter 'cmd' description in 'map_cmd_status' drivers/scsi/megaraid/megaraid_sas_fusion.c:2245: warning: Function parameter or member 'sge_count' not described in 'megasas_make_sgl_fusion' drivers/scsi/megaraid/megaraid_sas_fusion.c:2356: warning: Function parameter or member 'io_request' not described in 'megasas_set_pd_lba' drivers/scsi/megaraid/megaraid_sas_fusion.c:2356: warning: Function parameter or member 'io_info' not described in 'megasas_set_pd_lba' drivers/scsi/megaraid/megaraid_sas_fusion.c:2356: warning: Function parameter or member 'scp' not described in 'megasas_set_pd_lba' drivers/scsi/megaraid/megaraid_sas_fusion.c:2356: warning: Function parameter or member 'local_map_ptr' not described in 'megasas_set_pd_lba' drivers/scsi/megaraid/megaraid_sas_fusion.c:2356: warning: Function parameter or member 'ref_tag' not described in 'megasas_set_pd_lba' drivers/scsi/megaraid/megaraid_sas_fusion.c:2356: warning: Excess function parameter 'cdb' description in 'megasas_set_pd_lba' drivers/scsi/megaraid/megaraid_sas_fusion.c:2356: warning: Excess function parameter 'start_blk' description in 'megasas_set_pd_lba' drivers/scsi/megaraid/megaraid_sas_fusion.c:2617: warning: Function parameter or member 'fusion' not described in 'megasas_set_raidflag_cpu_affinity' drivers/scsi/megaraid/megaraid_sas_fusion.c:2617: warning: Function parameter or member 'scsi_buff_len' not described in 'megasas_set_raidflag_cpu_affinity' drivers/scsi/megaraid/megaraid_sas_fusion.c:2950: warning: Function parameter or member 'scmd' not described in 'megasas_build_ld_nonrw_fusion' drivers/scsi/megaraid/megaraid_sas_fusion.c:2950: warning: Excess function parameter 'scp' description in 'megasas_build_ld_nonrw_fusion' drivers/scsi/megaraid/megaraid_sas_fusion.c:3041: warning: Function parameter or member 'scmd' not described in 'megasas_build_syspd_fusion' drivers/scsi/megaraid/megaraid_sas_fusion.c:3041: warning: Excess function parameter 'scp' description in 'megasas_build_syspd_fusion' drivers/scsi/megaraid/megaraid_sas_fusion.c:3414: warning: Function parameter or member 'cmd' not described in 'megasas_complete_r1_command' drivers/scsi/megaraid/megaraid_sas_fusion.c:3414: warning: Excess function parameter 'cmd_fusion' description in 'megasas_complete_r1_command' drivers/scsi/megaraid/megaraid_sas_fusion.c:3467: warning: Function parameter or member 'MSIxIndex' not described in 'complete_cmd_fusion' drivers/scsi/megaraid/megaraid_sas_fusion.c:3467: warning: Function parameter or member 'irq_context' not described in 'complete_cmd_fusion' drivers/scsi/megaraid/megaraid_sas_fusion.c:3639: warning: Function parameter or member 'instance' not described in 'megasas_enable_irq_poll' drivers/scsi/megaraid/megaraid_sas_fusion.c:3656: warning: Function parameter or member 'instance_addr' not described in 'megasas_sync_irqs' drivers/scsi/megaraid/megaraid_sas_fusion.c:3656: warning: Excess function parameter 'instance' description in 'megasas_sync_irqs' drivers/scsi/megaraid/megaraid_sas_fusion.c:3715: warning: Function parameter or member 'instance_addr' not described in 'megasas_complete_cmd_dpc_fusion' drivers/scsi/megaraid/megaraid_sas_fusion.c:3715: warning: Excess function parameter 'instance' description in 'megasas_complete_cmd_dpc_fusion' drivers/scsi/megaraid/megaraid_sas_fusion.c:3734: warning: Function parameter or member 'irq' not described in 'megasas_isr_fusion' drivers/scsi/megaraid/megaraid_sas_fusion.c:3734: warning: Function parameter or member 'devp' not described in 'megasas_isr_fusion' drivers/scsi/megaraid/megaraid_sas_fusion.c:3772: warning: Function parameter or member 'mfi_cmd' not described in 'build_mpt_mfi_pass_thru' drivers/scsi/megaraid/megaraid_sas_fusion.c:3887: warning: Function parameter or member 'instance' not described in 'megasas_read_fw_status_reg_fusion' drivers/scsi/megaraid/megaraid_sas_fusion.c:3887: warning: Excess function parameter 'regs' description in 'megasas_read_fw_status_reg_fusion' drivers/scsi/megaraid/megaraid_sas_fusion.c:3937: warning: Function parameter or member 'instance' not described in 'megasas_adp_reset_fusion' drivers/scsi/megaraid/megaraid_sas_fusion.c:4014: warning: Function parameter or member 'instance' not described in 'megasas_check_reset_fusion' drivers/scsi/megaraid/megaraid_sas_fusion.c:4346: warning: Function parameter or member 'instance' not described in 'megasas_tm_response_code' drivers/scsi/megaraid/megaraid_sas_fusion.c:4346: warning: Excess function parameter 'ioc' description in 'megasas_tm_response_code' drivers/scsi/megaraid/megaraid_sas_fusion.c:4408: warning: Function parameter or member 'mr_device_priv_data' not described in 'megasas_issue_tm' drivers/scsi/megaraid/megaraid_sas_fusion.c:4408: warning: Excess function parameter 'm_type' description in 'megasas_issue_tm' Cc: Kashyap Desai Cc: Sumit Saxena Cc: Shivasharan S Cc: megaraidlinux.pdl@broadcom.com Signed-off-by: Lee Jones --- drivers/scsi/megaraid/megaraid_sas_fusion.c | 73 ++++++++++++--------- 1 file changed, 41 insertions(+), 32 deletions(-) -- 2.25.1 diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c index 319f241da4b66..a0cf55776361c 100644 --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c @@ -90,9 +90,9 @@ extern u32 megasas_readl(struct megasas_instance *instance, /** * megasas_adp_reset_wait_for_ready - initiate chip reset and wait for * controller to come to ready state - * @instance - adapter's soft state - * @do_adp_reset - If true, do a chip reset - * @ocr_context - If called from OCR context this will + * @instance: adapter's soft state + * @do_adp_reset: If true, do a chip reset + * @ocr_context: If called from OCR context this will * be set to 1, else 0 * * This function initates a chip reset followed by a wait for controller to @@ -146,10 +146,10 @@ megasas_adp_reset_wait_for_ready(struct megasas_instance *instance, /** * megasas_check_same_4gb_region - check if allocation * crosses same 4GB boundary or not - * @instance - adapter's soft instance - * start_addr - start address of DMA allocation - * size - size of allocation in bytes - * return - true : allocation does not cross same + * @instance: adapter's soft instance + * @start_addr: start address of DMA allocation + * @size: size of allocation in bytes + * @return: true : allocation does not cross same * 4GB boundary * false: allocation crosses same * 4GB boundary @@ -174,7 +174,7 @@ static inline bool megasas_check_same_4gb_region /** * megasas_enable_intr_fusion - Enables interrupts - * @regs: MFI register set + * @instance: Adapter soft state */ static void megasas_enable_intr_fusion(struct megasas_instance *instance) @@ -196,7 +196,7 @@ megasas_enable_intr_fusion(struct megasas_instance *instance) /** * megasas_disable_intr_fusion - Disables interrupt - * @regs: MFI register set + * @instance: Adapter soft state */ static void megasas_disable_intr_fusion(struct megasas_instance *instance) @@ -238,6 +238,7 @@ megasas_clear_intr_fusion(struct megasas_instance *instance) /** * megasas_get_cmd_fusion - Get a command from the free pool * @instance: Adapter soft state + * @blk_tag: Index into the command list * * Returns a blk_tag indexed mpt frame */ @@ -310,7 +311,7 @@ megasas_fire_cmd_fusion(struct megasas_instance *instance, /** * megasas_fusion_update_can_queue - Do all Adapter Queue depth related calculations here * @instance: Adapter soft state - * fw_boot_context: Whether this function called during probe or after OCR + * @fw_boot_context: Whether this function called during probe or after OCR * * This function is only for fusion controllers. * Update host can queue, if firmware downgrade max supported firmware commands. @@ -1016,6 +1017,7 @@ megasas_alloc_cmds_fusion(struct megasas_instance *instance) * wait_and_poll - Issues a polling command * @instance: Adapter soft state * @cmd: Command packet to be issued + * @seconds: Total seconds to wait * * For polling, MFI requires the cmd_status to be set to 0xFF before posting. */ @@ -1906,6 +1908,7 @@ megasas_init_adapter_fusion(struct megasas_instance *instance) /** * megasas_fault_detect_work - Worker function of * FW fault handling workqueue. + * @work: Pointer to work information */ static void megasas_fault_detect_work(struct work_struct *work) @@ -1989,9 +1992,12 @@ megasas_fusion_stop_watchdog(struct megasas_instance *instance) /** * map_cmd_status - Maps FW cmd status to OS cmd status - * @cmd : Pointer to cmd + * @fusion : Pointer to driver data + * @scmd : Pointer to SCSI cmd * @status : status of cmd returned by FW * @ext_status : ext status of cmd returned by FW + * @data_length : size of reqeusted data + * @sense : sense data */ static void @@ -2234,8 +2240,7 @@ megasas_make_prp_nvme(struct megasas_instance *instance, struct scsi_cmnd *scmd, * @scp: SCSI command from the mid-layer * @sgl_ptr: SGL to be filled in * @cmd: cmd we are working on - * @sge_count sge count - * + * @sge_count: sge count */ static void megasas_make_sgl_fusion(struct megasas_instance *instance, @@ -2341,11 +2346,9 @@ int megasas_make_sgl(struct megasas_instance *instance, struct scsi_cmnd *scp, return sge_count; } -/** +/* * megasas_set_pd_lba - Sets PD LBA - * @cdb: CDB * @cdb_len: cdb length - * @start_blk: Start block of IO * * Used to set the PD LBA in CDB for FP IOs */ @@ -2603,11 +2606,12 @@ static void megasas_stream_detect(struct megasas_instance *instance, * affinity (cpu of the controller) and raid_flags in the raid context * based on IO type. * + * @fusion : Pointer to driver data * @praid_context: IO RAID context * @raid: LD raid map * @fp_possible: Is fast path possible? * @is_read: Is read IO? - * + * @scsi_buff_len: SCSI buffer length */ static void megasas_set_raidflag_cpu_affinity(struct fusion_context *fusion, @@ -2940,7 +2944,7 @@ megasas_build_ldio_fusion(struct megasas_instance *instance, /** * megasas_build_ld_nonrw_fusion - prepares non rw ios for virtual disk * @instance: Adapter soft state - * @scp: SCSI command + * @scmd: SCSI command * @cmd: Command to be prepared * * Prepares the io_request frame for non-rw io cmds for vd. @@ -3028,7 +3032,7 @@ static void megasas_build_ld_nonrw_fusion(struct megasas_instance *instance, /** * megasas_build_syspd_fusion - prepares rw/non-rw ios for syspd * @instance: Adapter soft state - * @scp: SCSI command + * @scmd: SCSI command * @cmd: Command to be prepared * @fp_possible: parameter to detect fast path or firmware path io. * @@ -3405,7 +3409,7 @@ megasas_build_and_issue_cmd_fusion(struct megasas_instance *instance, * megasas_complete_r1_command - * completes R1 FP write commands which has valid peer smid * @instance: Adapter soft state - * @cmd_fusion: MPT command frame + * @cmd: MPT command frame * */ static inline void @@ -3456,7 +3460,7 @@ megasas_complete_r1_command(struct megasas_instance *instance, } } -/** +/* * complete_cmd_fusion - Completes command * @instance: Adapter soft state * Completes all commands that is in reply descriptor queue @@ -3634,6 +3638,7 @@ complete_cmd_fusion(struct megasas_instance *instance, u32 MSIxIndex, /** * megasas_enable_irq_poll() - enable irqpoll + * @instance: Adapter soft state */ static void megasas_enable_irq_poll(struct megasas_instance *instance) { @@ -3650,7 +3655,7 @@ static void megasas_enable_irq_poll(struct megasas_instance *instance) /** * megasas_sync_irqs - Synchronizes all IRQs owned by adapter - * @instance: Adapter soft state + * @instance_addr: Adapter soft state */ static void megasas_sync_irqs(unsigned long instance_addr) { @@ -3706,7 +3711,7 @@ int megasas_irqpoll(struct irq_poll *irqpoll, int budget) /** * megasas_complete_cmd_dpc_fusion - Completes command - * @instance: Adapter soft state + * @instance_addr: Adapter soft state * * Tasklet to complete cmds */ @@ -3729,6 +3734,8 @@ megasas_complete_cmd_dpc_fusion(unsigned long instance_addr) /** * megasas_isr_fusion - isr entry point + * @irq: Interrupt number + * @devp: Interrupt contect */ static irqreturn_t megasas_isr_fusion(int irq, void *devp) { @@ -3763,7 +3770,7 @@ static irqreturn_t megasas_isr_fusion(int irq, void *devp) /** * build_mpt_mfi_pass_thru - builds a cmd fo MFI Pass thru * @instance: Adapter soft state - * mfi_cmd: megasas_cmd pointer + * @mfi_cmd: megasas_cmd pointer * */ static void @@ -3880,7 +3887,7 @@ megasas_release_fusion(struct megasas_instance *instance) /** * megasas_read_fw_status_reg_fusion - returns the current FW status value - * @regs: MFI register set + * @instance: Adapter soft state */ static u32 megasas_read_fw_status_reg_fusion(struct megasas_instance *instance) @@ -3929,7 +3936,8 @@ megasas_free_host_crash_buffer(struct megasas_instance *instance) /** * megasas_adp_reset_fusion - For controller reset - * @regs: MFI register set + * @instance: Adapter soft state + * @regs: MFI register set */ static int megasas_adp_reset_fusion(struct megasas_instance *instance, @@ -4006,7 +4014,8 @@ megasas_adp_reset_fusion(struct megasas_instance *instance, /** * megasas_check_reset_fusion - For controller reset check - * @regs: MFI register set + * @instance: Adapter soft state + * @regs: MFI register set */ static int megasas_check_reset_fusion(struct megasas_instance *instance, @@ -4168,7 +4177,7 @@ void megasas_reset_reply_desc(struct megasas_instance *instance) } } -/* +/** * megasas_refire_mgmt_cmd : Re-fire management commands * @instance: Controller's soft instance */ @@ -4267,7 +4276,7 @@ static void megasas_refire_mgmt_cmd(struct megasas_instance *instance, } } -/* +/** * megasas_return_polled_cmds: Return polled mode commands back to the pool * before initiating an OCR. * @instance: Controller's soft instance @@ -4298,7 +4307,7 @@ megasas_return_polled_cmds(struct megasas_instance *instance) } } -/* +/** * megasas_track_scsiio : Track SCSI IOs outstanding to a SCSI device * @instance: per adapter struct * @channel: the channel assigned by the OS @@ -4335,7 +4344,7 @@ static int megasas_track_scsiio(struct megasas_instance *instance, /** * megasas_tm_response_code - translation of device response code - * @ioc: per adapter object + * @instance: Controller's soft instance * @mpi_reply: MPI reply returned by firmware * * Return nothing. @@ -4393,7 +4402,7 @@ megasas_tm_response_code(struct megasas_instance *instance, * @id: the id assigned by the OS * @type: MPI2_SCSITASKMGMT_TASKTYPE__XXX (defined in megaraid_sas_fusion.c) * @smid_task: smid assigned to the task - * @m_type: TM_MUTEX_ON or TM_MUTEX_OFF + * @mr_device_priv_data: Private device data * Context: user * * MegaRaid use MPT interface for Task Magement request. From patchwork Tue Jul 7 14:00:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 235007 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp942523ilg; Tue, 7 Jul 2020 07:01:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxngHFwiaZBowih9X6Rrcss1XkzuFWdnvL0hha7EoLm8v4DOX+b2CBokZLzclG9cYx8oY8U X-Received: by 2002:a17:906:1102:: with SMTP id h2mr46319379eja.356.1594130490241; Tue, 07 Jul 2020 07:01:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594130490; cv=none; d=google.com; s=arc-20160816; b=YfkLZsf0STvy8kio6szo4CwBfxcaM2+/eUUsl4ZpXIAuZuPoWcPfGzLA/4SuzguOIU FVBA1TqOUKh2chlySD6ErzViJ+3vjKaPtycCT1k3k4jseGvaTYQ2se0IBOYBZbtkzSz7 feVycQVI6gHcyjKFXbkV+QRwqEpE38XLN6bNJmSXx4cfBw/C5kpF4sm3rU6+UFU9Zk8M gyZQdsZZnPyw1BadQhgQ9JbyAd1BIe4J4QP3hNSKFbqRRppbeVnp74oOM9fP0872OhCR AVz4oFo84A44E1vT9xIWozKXqv/0pY4i1dVVKj7QUSE7p0zVRjNz98UAh6Udv0P9IH9o zpdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=y26Vcc37Y6OJEhG8oY+4cT2VI5Efu0cSqIbZ+fS/jqU=; b=LVlRSO+Evyjn0aq8kv0oe2YrbBAJzrxC/49Iq+v9B+oe/iPKFaG7b+RztRERHwjziR PFflYIdyG824zQx2UNwMge1HWkI096WPhUKI0kLmEfgVjwI65mXa59gfZPrIPc6WClt3 +ejCxdQQETobSkBqbGBE8rXzO645FHvETvNUOpGiE4MBpBWxQ5YgoT5+q7qyAo7gUXrB h9UeiZL++RDwDo7WupPehd3XFxfIbUpX19DSlUAmDnFuDghRktPqVwYxtrFiqzJtp8Cf fwxoYdU8EI5K+91lFSfrxwKLfKwI5z8AuNFgnFoikCXMLWs9oSbYlcZpHNIdlugGq1hm BeGQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FCjmwtor; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g3si16568851edn.594.2020.07.07.07.01.30 for ; Tue, 07 Jul 2020 07:01:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FCjmwtor; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728190AbgGGOBI (ORCPT ); Tue, 7 Jul 2020 10:01:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728184AbgGGOBH (ORCPT ); Tue, 7 Jul 2020 10:01:07 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF144C08C5EE for ; Tue, 7 Jul 2020 07:01:06 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id l17so43400836wmj.0 for ; Tue, 07 Jul 2020 07:01:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=y26Vcc37Y6OJEhG8oY+4cT2VI5Efu0cSqIbZ+fS/jqU=; b=FCjmwtorz6vctEvTWYfiq6Y8f6Fbx+tEDfnlJ4nB5DOyvJmPt//qLYZCSdT1zX1nkk mMz1faRYby4rbkKcS+C0KGL5LFQsQMep3SxKa7N+B2i1kW5PZG1LACp9KoGKNKPdmk8m 6hra1t1Pec7tsMfKPiVo1jeEFbuslPDFkGBfig7Q/5HqW4xYOeM+z55AMZcbFr+NAgss fYetrg61K4XOj+wS/l8gsTVbPAWiGPTFH+H2WweP8zHXhhd7zDVcK0TMGzGQZIQFufB8 cAsc2iPIbGETO8T8H7n5QpZYZeq56MrH9mxqxuUsRROd9RQBI/lsaprFh99AYJ+RXasi eoRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=y26Vcc37Y6OJEhG8oY+4cT2VI5Efu0cSqIbZ+fS/jqU=; b=JP/GWlmmDOHl4kk6egl4rce84oirzeEb8IW5GLx9YphsaBXNaoQWlYuRT8I34teVDW Oc7Z5Kt8fzA7Yhg+OzF86fb87P36eqUXMgcJ36BqaaSNmUoNKWGbP3k2wadgNKNQBnyT xCIfcbU5FI507JTYTyT9zLVe9N6vNZ3J0gc/qz2JiQjYzOQiQ9av+1q6/AMbKWKX/j3T eQfyLI/EY84t8N0J4knL+lV8Op8KzO2+6/HCv5GuSZHGpUWA0Cuh1cXHfSkLsAOoonPd Jokd21LJJgjG4wVkcdfffKrLbCjY0KGptmEs+K1DOvF5VPQlPU+9HPM7Z1I6nvtn6fv6 lFKQ== X-Gm-Message-State: AOAM531BjRKKznhI0sX22M22biDarYcCItM4ouImPYDKotFKJIXX/EtQ GS8Y8C78hvgOKxJnzL1EY3YZyQ== X-Received: by 2002:a1c:804c:: with SMTP id b73mr4286540wmd.59.1594130465582; Tue, 07 Jul 2020 07:01:05 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id z25sm1102823wmk.28.2020.07.07.07.01.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 07:01:04 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , Kashyap Desai , Sumit Saxena , Shivasharan S , megaraidlinux.pdl@broadcom.com Subject: [PATCH 05/10] scsi: megaraid: megaraid_sas_base: Provide prototypes for non-static functions Date: Tue, 7 Jul 2020 15:00:50 +0100 Message-Id: <20200707140055.2956235-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200707140055.2956235-1-lee.jones@linaro.org> References: <20200707140055.2956235-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org For Megaraid DebugFS functions called from 'megaraid_sas_base.c'. Fixes the following W=1 kernel build warning(s): drivers/scsi/megaraid/megaraid_sas_debugfs.c:102:6: warning: no previous prototype for ‘megasas_init_debugfs’ [-Wmissing-prototypes] 102 | void megasas_init_debugfs(void) | ^~~~~~~~~~~~~~~~~~~~ drivers/scsi/megaraid/megaraid_sas_debugfs.c:112:6: warning: no previous prototype for ‘megasas_exit_debugfs’ [-Wmissing-prototypes] 112 | void megasas_exit_debugfs(void) | ^~~~~~~~~~~~~~~~~~~~ drivers/scsi/megaraid/megaraid_sas_debugfs.c:122:1: warning: no previous prototype for ‘megasas_setup_debugfs’ [-Wmissing-prototypes] 122 | megasas_setup_debugfs(struct megasas_instance *instance) | ^~~~~~~~~~~~~~~~~~~~~ drivers/scsi/megaraid/megaraid_sas_debugfs.c:161:6: warning: no previous prototype for ‘megasas_destroy_debugfs’ [-Wmissing-prototypes] 161 | void megasas_destroy_debugfs(struct megasas_instance *instance) | ^~~~~~~~~~~~~~~~~~~~~~~ Cc: Kashyap Desai Cc: Sumit Saxena Cc: Shivasharan S Cc: megaraidlinux.pdl@broadcom.com Signed-off-by: Lee Jones --- drivers/scsi/megaraid/megaraid_sas_base.c | 4 ---- drivers/scsi/megaraid/megaraid_sas_fusion.h | 6 ++++++ 2 files changed, 6 insertions(+), 4 deletions(-) -- 2.25.1 diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c index 00668335c2afc..1ccd72b1cbe7f 100644 --- a/drivers/scsi/megaraid/megaraid_sas_base.c +++ b/drivers/scsi/megaraid/megaraid_sas_base.c @@ -202,10 +202,6 @@ static bool support_pci_lane_margining; static spinlock_t poll_aen_lock; extern struct dentry *megasas_debugfs_root; -extern void megasas_init_debugfs(void); -extern void megasas_exit_debugfs(void); -extern void megasas_setup_debugfs(struct megasas_instance *instance); -extern void megasas_destroy_debugfs(struct megasas_instance *instance); void megasas_complete_cmd(struct megasas_instance *instance, struct megasas_cmd *cmd, diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.h b/drivers/scsi/megaraid/megaraid_sas_fusion.h index 30de4b01f7035..5f657d2ba733a 100644 --- a/drivers/scsi/megaraid/megaraid_sas_fusion.h +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.h @@ -1388,4 +1388,10 @@ int megasas_check_mpio_paths(struct megasas_instance *instance, struct scsi_cmnd *scmd); void megasas_fusion_ocr_wq(struct work_struct *work); +/* DebugFS Prototypes */ +void megasas_init_debugfs(void); +void megasas_exit_debugfs(void); +void megasas_setup_debugfs(struct megasas_instance *instance); +void megasas_destroy_debugfs(struct megasas_instance *instance); + #endif /* _MEGARAID_SAS_FUSION_H_ */ From patchwork Tue Jul 7 14:00:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 235008 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp942548ilg; Tue, 7 Jul 2020 07:01:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxHptBjQoFeCB3bKt7C/fZcSmy9t/uAJJIyB1CbyIU/jQLO7Ps081EFEPhRSbw3PXVz9NO+ X-Received: by 2002:a17:906:e0c7:: with SMTP id gl7mr44844683ejb.264.1594130491771; Tue, 07 Jul 2020 07:01:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594130491; cv=none; d=google.com; s=arc-20160816; b=zIbbchE7jTB5bWghXf28ZgW+VyOH+YhPfa6EupDRtXrBTTiDVkd6eogTY7e0ucj9NG CXcCXwGwaRwqdWchUw3MFHhUkDo448mHxYa3rkOTN+V72wWR7IQCOoaC3kQ3jggZJ7hT gsVnt3R/pGZBqCFABwKs83aYU5fncYeneg4l1rvQnQ13oclcgnDxwS2Pra8QjdaIBsRy drqLGtcKzExziPQAhWohsTlS7NA3US7PsGOiDyleDzwKiBFJHmuyA1bWIb5OXLxaEsXK G8uIx7+cwRhbT9s6/FSVp2aDnynVQqM1adO/juVoU1zABDqumSFjXEPG1uCNnBz3UVEH buPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=+O/0d2wA9ZSFy1o93OfBEO3S/Is3leUo2WVahG+2iA4=; b=y9CUCwoei+0ZdFzT6njIx3OMYVstDJwqoPeXbW/HPobnyIRQEiLff2BkqKoLpt2YhF ReiSXsN/NqGFHr/TriuLjMDdzqNlrCJ5490HPWBa60ACWThttZaM2laE+Rk7IBdDLWhT 3c6rbN3qFSI6B0CeCI29/s2XsdMYE70+0bgdmMW/pk3z/4+2XBovznpDHroBk/CCMenK wPPYt5oanHjzxy278TdbmnYwzO6shz2SILCI09qmocqzZua8PaAH+NCczYAFolYMW40f SyQWs41/qtPbtnf6nIm0R7ik0HWTMKcwPMTliIJ73Su8hpdxE1c3W5Dq+ifr8opbFTV2 47KQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=nTK6Gzvx; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g3si16568851edn.594.2020.07.07.07.01.31 for ; Tue, 07 Jul 2020 07:01:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=nTK6Gzvx; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728309AbgGGOBa (ORCPT ); Tue, 7 Jul 2020 10:01:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728184AbgGGOBI (ORCPT ); Tue, 7 Jul 2020 10:01:08 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7412C08C5E1 for ; Tue, 7 Jul 2020 07:01:07 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id l2so45149520wmf.0 for ; Tue, 07 Jul 2020 07:01:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+O/0d2wA9ZSFy1o93OfBEO3S/Is3leUo2WVahG+2iA4=; b=nTK6GzvxFufmNCuaB/22HJzPW+ctnvIE8XhiHfh2DBolWX8XmkjKWKRNr6mcxfuVz8 2WFBe65mFhxIVpnvZUmNUjMcVuK2FTAFkp+J3gGwUC4AlolozrT3b/Fbb60/HtruCkDS ZFMYuIBgwEfx3BrXjKfO5OG2bHyOu5swAPB9FW8MB2jhMHzER4Ho4vK4bfgYXhLqaoVt jMEq9w6X5RaHLgoHJVqa5MNFhySGuagwInfbdzMqtS0MAMRVCSCE9jr1+nW/vN1kcAH3 A2d47G3UPS0UAasKFBCDbKN1r8wQWyWvO/k/t37a8JY9yAFqotKwsU1CLWNDeGzhIv7P W0VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+O/0d2wA9ZSFy1o93OfBEO3S/Is3leUo2WVahG+2iA4=; b=XqbKzF3ltYp9F2sUYpAZi+ZECyx/Q1YMWZn+3hF5ZHHkfcjT2PoJRzexzNoSA7XhjS h2sbADEGuzSzIohn7ZzET59AbxCubHVDq/J/x41pqM8Esbz/AnWF5Q+7NY8AUCAlJk2i y8ihpWVJ6WeTN4q4uTphySBPTKedIysvEOyA23V3Z7UQR/0aZSTp+fT/LSN0yDsdn6Ao sgUeSNFvZdYkrRBCCIXI9LFVPtRXvEr6ruWQd1zbGa3pf+YqaD4P+gwq5le+hhcaTjFp oJMnQ3S5b8BdM4DPoMjTPMAphkWr+hQovWCXRnr+l1A7N1PUnspCH8a8cYo4ESF5xzZt JRnQ== X-Gm-Message-State: AOAM531v4hK4/IUuy+ljEJ5jOwXLTnxwPlI9D79p7hj7S5Ra/XNzeAQH ztfJSan5wg8SLOzDQSyqSqaLhA== X-Received: by 2002:a7b:c09a:: with SMTP id r26mr4281624wmh.176.1594130466648; Tue, 07 Jul 2020 07:01:06 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id z25sm1102823wmk.28.2020.07.07.07.01.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 07:01:06 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , "Juergen E. Fischer" Subject: [PATCH 06/10] scsi: aha152x: Remove unused variable 'ret' Date: Tue, 7 Jul 2020 15:00:51 +0100 Message-Id: <20200707140055.2956235-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200707140055.2956235-1-lee.jones@linaro.org> References: <20200707140055.2956235-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Looks to be unused since 2014. Fixes the following W=1 kernel build warning(s): drivers/scsi/aha152x.c: In function ‘datai_run’: drivers/scsi/aha152x.c:2033:9: warning: variable ‘data’ set but not used [-Wunused-but-set-variable] 2033 | int data; | ^~~~ Cc: "Juergen E. Fischer" Signed-off-by: Lee Jones --- drivers/scsi/aha152x.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.25.1 diff --git a/drivers/scsi/aha152x.c b/drivers/scsi/aha152x.c index 90f97df1c42a4..d8e19afa7a140 100644 --- a/drivers/scsi/aha152x.c +++ b/drivers/scsi/aha152x.c @@ -2030,8 +2030,7 @@ static void datai_run(struct Scsi_Host *shpnt) fifodata, GETPORT(FIFOSTAT)); SETPORT(DMACNTRL0, ENDMA|_8BIT); while(fifodata>0) { - int data; - data=GETPORT(DATAPORT); + GETPORT(DATAPORT); fifodata--; DATA_LEN++; } From patchwork Tue Jul 7 14:00:52 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 235006 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp942362ilg; Tue, 7 Jul 2020 07:01:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzk8KiXWOcvA7+WisWED/csmHmQd3dY/uOe5EYYACT4Hh3Rchnmabvm7VnY9rtXmTSIZv2W X-Received: by 2002:a50:f9c9:: with SMTP id a9mr64304324edq.89.1594130482443; Tue, 07 Jul 2020 07:01:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594130482; cv=none; d=google.com; s=arc-20160816; b=L35dxJOfzTIfS92Rf0je2B9t4CdlELPiJ2emB8ky/VrTejpD5JYQPTM+ntBkY9wplZ lbmLyhtqFjL/r3qyEQ7kQ1VfquaKx44/nQ3EEvg8CJsbho/sdHBCLQQOTS1j1h/72Mnj vmdv8/jkwvqzxSL/hWZwGUKp5BLPjQaSbLXnuf2dNDL9U+7aN0eMQq8/LW65E9qsGZoR zboDrCNP9cZPcf6x2OwWjpgKs51YuV5fZuHvQGBs6YiFB3kl9qCf2+PMKrIlLJAY2K4v nFvmZmJ4mDTXLk9rfG36Bg+JI2507BoMxHpVeh1JdyitEisHUDMdU+OqMu8qe8MXT5ss MseA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=SuL/Iy3i9aJ7SLBRjyYkn8G6jFvDgmCt3JP0c6V0JmE=; b=uAMByDOlPF0wkJGOXIWH5S1dR/aCMf5Y4VZYYdp7FnbZE2yymvqFF/ttMdO2tButLn K7bgVxqdJnTstNRCMv9S1OIm3xK+LQOQ+V42BVRmRp0kMLf21yXY6PeTXz3inpzq2hv1 s46T8t81b4BAfUkC7qaqFZnBHlSKiEZYxDvfAC/vaulfbIVVaAf62oO6qVBhWoAJrBu2 SfcPXVfHnonHBcqNa4eNT28MUho3XAyyH0fJxYYba4NN4kOZdrFy2DxMlTUgf3GiswqH PeuF91dTUzZl/RRIFehzJmEV5sb7beTViwWGrhUFle9hP52uzj7PmfgzvStfa9v0Ib// KBiA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KrbNLXwc; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g3si16568851edn.594.2020.07.07.07.01.22 for ; Tue, 07 Jul 2020 07:01:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KrbNLXwc; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728231AbgGGOBK (ORCPT ); Tue, 7 Jul 2020 10:01:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728207AbgGGOBJ (ORCPT ); Tue, 7 Jul 2020 10:01:09 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31B6BC08C5E1 for ; Tue, 7 Jul 2020 07:01:09 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id j4so42841568wrp.10 for ; Tue, 07 Jul 2020 07:01:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SuL/Iy3i9aJ7SLBRjyYkn8G6jFvDgmCt3JP0c6V0JmE=; b=KrbNLXwcM8rh7ttMrR97DE+xAoJyroqlKx/hR/xRcE7XSM/PPL+3Y5pbiBajeyuHjs iwOG7qmicRXCfX9aM5vTp+l7L0enOJ2k5L9GG2WqKPgF0X/8UFD2zr8hsrCygaQB+5ew g6ICyCXsMEe62zk8uaCUHebsDC0ksQJj5YxhAI7fDooRZnuS1aSUzc8Ewr+1UJNvoLnw nS3Pw1pCEHpHltVJxgrmzM623dDKzXOJ9U+shmarEjFRGXpWilqb+I42YqXgX13E8CJG KFUAi2r8sYjC2qvzSd1/gXekLpbG6wzlgphw0M/6BVGjO3F8xguuvqcj45ujKGcKIzJv i+2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SuL/Iy3i9aJ7SLBRjyYkn8G6jFvDgmCt3JP0c6V0JmE=; b=TfTHEPFX3sJnBzglh8l3icD/bV+M2galq0RLt4sUSZdXPnnjCz+XkZF4OJmVNERLba 7I7SxKC51bCV0F2QzpOStnvPARnAnGKxk/xTWFDvljo1jPV7tjSmgnem/qPOeS1UGVO0 LcEGJaXsoWFg9ze1HjickAPOKeOEgJp33c83I42TnQDEfGrytBJPZuvjD+zqBOJDkW+U uc0QVD0+TZxlp5wwmcHGPWuTIzJ5QhVuUdFBQCemzsjsqOdrMJvdqAB+qfdyN0khLP7N VCuzBG7zFLLIhzQK8PBxNaJdHDtvFu1saDIBJ0sb1so/Xgo5GjZQJF3vt7cX/4PX95zu ogFA== X-Gm-Message-State: AOAM531b2UyzPp1kNIHmehjYRpsxPKnfDAtuPe+Fr2/PT766X5OmpxFA F89+gNHGHRJ/oomIaeF7fS+5IA== X-Received: by 2002:adf:eec8:: with SMTP id a8mr54760951wrp.421.1594130467935; Tue, 07 Jul 2020 07:01:07 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id z25sm1102823wmk.28.2020.07.07.07.01.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 07:01:07 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , YOKOTA Hiroshi Subject: [PATCH 07/10] scsi: pcmcia: nsp_cs: Use new __printf() format notation Date: Tue, 7 Jul 2020 15:00:52 +0100 Message-Id: <20200707140055.2956235-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200707140055.2956235-1-lee.jones@linaro.org> References: <20200707140055.2956235-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/pcmcia/nsp_cs.c: In function ‘nsp_cs_message’: drivers/scsi/pcmcia/nsp_cs.c:143:2: warning: function ‘nsp_cs_message’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format] drivers/scsi/pcmcia/nsp_cs.c: In function ‘nsp_fifo_count’: drivers/scsi/pcmcia/nsp_cs.c:692:24: warning: variable ‘dummy’ set but not used [-Wunused-but-set-variable] Cc: YOKOTA Hiroshi Signed-off-by: Lee Jones --- drivers/scsi/pcmcia/nsp_cs.c | 1 + 1 file changed, 1 insertion(+) -- 2.25.1 diff --git a/drivers/scsi/pcmcia/nsp_cs.c b/drivers/scsi/pcmcia/nsp_cs.c index d79ce97a04bd7..57a78f84f97ab 100644 --- a/drivers/scsi/pcmcia/nsp_cs.c +++ b/drivers/scsi/pcmcia/nsp_cs.c @@ -134,6 +134,7 @@ static inline void nsp_inc_resid(struct scsi_cmnd *SCpnt, int residInc) scsi_set_resid(SCpnt, scsi_get_resid(SCpnt) + residInc); } +__printf(4, 5) static void nsp_cs_message(const char *func, int line, char *type, char *fmt, ...) { va_list args; From patchwork Tue Jul 7 14:00:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 235003 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp942188ilg; Tue, 7 Jul 2020 07:01:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy/D4f4+sxm51NziZwH0ha1+57L4KRdR/VfRrUjM9Wf9cuj3l4hrIAerNSxOvnnO8Xx3RO5 X-Received: by 2002:a50:f187:: with SMTP id x7mr58718538edl.59.1594130474168; Tue, 07 Jul 2020 07:01:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594130474; cv=none; d=google.com; s=arc-20160816; b=lIF9w8ugvuv+hCiA6nYq/PXIB7kBJS2NWozglAW/ycp/i+g2F3s9o7qjkuqMFExXTX ah+HNGtUNWzzVF7OLVOx8EVY7CKAOPeAlbRI2GMW58PrrTX8ZGsMmqezeZpoVuJgij1p aAJt3lNY4BEAB5MG6Pfb3G3YR1TnARqTLTQAVbmsiKkxCYdjGDctnQLULDsrcxxTjZFY etHZjbLKDGdBdPOyIOkhArcXiyG2bVX9t/40zrei+lFu4R5CbOFfqOGXtgGdFk6gcwLR sieicUjg6qMrMnTQJpA7tbN6D/pgc/r/mc9YrQuNpGCF1Zwg6Lvoo+xbcRuHS3qT9F9T YIAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=5akYiP5XbUbIIHU3yZTiMoBU1iltsAOw/hCtwfTaVJc=; b=mq3jSfHXn8y+mrEUk0NDdw/1IJEcRDcYqNz2ssnJJB+AUQZKrk+9MiAr7CRAaV1kOY rY2xoBtxpzjT6vdIkLgnlmqvE21cmpgjH9o8gY590gADz1Pow4KipTUJCSZrv77Ya9T7 ZPnvLE+qD+n44oDSavlvn3UJHMf6+BHuUzxI/81d64ubhTNqAIMJlA5Qk/XkgmPLSWdS V5tOCG7kyLACFoPWkqysjAiGrBPRkwGEbf5rYMCQV1eHcr9InFQ5s8e9KcjvVB450udH rb/pEvnpRQPGoP/TGkhi++pdzxGWxP/LU4BcbwIHyoTzrA7PXBs960Qccdi2bcrUq9Q2 F9VA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XmmS1R2D; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l6si15170651edq.465.2020.07.07.07.01.14 for ; Tue, 07 Jul 2020 07:01:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XmmS1R2D; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728248AbgGGOBL (ORCPT ); Tue, 7 Jul 2020 10:01:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728232AbgGGOBK (ORCPT ); Tue, 7 Jul 2020 10:01:10 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63F70C08C5E1 for ; Tue, 7 Jul 2020 07:01:10 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id 22so43400995wmg.1 for ; Tue, 07 Jul 2020 07:01:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5akYiP5XbUbIIHU3yZTiMoBU1iltsAOw/hCtwfTaVJc=; b=XmmS1R2D9LdImdLyKuJbGDYLB/QYqj96CLTES0Hlurxb83iEVSOZjhC74NA3FNUelQ x3wmfifyk/fKrMiPve8zbbTsvCV7UcsUd0OxmveVMbfZwHXFFXHwDPeEzSChk1mVG4Wn v/FiUOq1EMMxM1DAtPF1xArvV707BeOj3E83i07QtyqPbhBYlv/MO2ydJxGqSbYoENE2 /Y3K5hBOFPGk1oPCkuhHZ8pqhicPWsd+S3xOKp9cFFrb3L1tBG7goNQFL/EXHs7MhYTO /UzKa3qSDPe5HHpccqJfVZYdAKYVlTdKk0TfXV4htQ2UPmq+q71tTFVWoqyA1m/5QveK K14w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5akYiP5XbUbIIHU3yZTiMoBU1iltsAOw/hCtwfTaVJc=; b=t7bCuSfhMDVAOMAL9KkeVG7gmo5fAkbZC0u1uYjkq2zNW+nyDP6K2LBWyoWDY5zyRI aLhbAx95tVBjoRCikmw5N/4XxlT6c65sNkooZ3DTn6fTzvlGIsxTMP/TKR7/yvyjPPqL yRl0+OpY1zpe2lESrsUrxYIvza7HH+iNUgtD8F5WoTyWotGdQQVK2h+7iaIbI/B+JwAg maknt+3OoxP+ptdmp+ZQoV9fsTGBPAMv9OMoFys9/IkoW0WYUN5NQc6AqM8eT1ETzAPX 6nfrGPwAJGAATCbi09IaQp1/cIV5Of3YRrnM0bEwVNGPMflo94uwF8x904D/U+tbaZQH lQMg== X-Gm-Message-State: AOAM533oXDRpd2Q2rcELHWoGWPmT4N91+Ot1pdabOgPqgVXBXMcgg/C3 8zArxYkQ8Xwfx3PNqmzlC7gcMXfsErw= X-Received: by 2002:a1c:7916:: with SMTP id l22mr4167207wme.115.1594130469133; Tue, 07 Jul 2020 07:01:09 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id z25sm1102823wmk.28.2020.07.07.07.01.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 07:01:08 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , YOKOTA Hiroshi Subject: [PATCH 08/10] scsi: pcmcia: nsp_cs: Remove unused variable 'dummy' Date: Tue, 7 Jul 2020 15:00:53 +0100 Message-Id: <20200707140055.2956235-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200707140055.2956235-1-lee.jones@linaro.org> References: <20200707140055.2956235-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org There is no need to populate an unused variable, even if the read is required. Fixes the following W=1 kernel build warning(s): drivers/scsi/pcmcia/nsp_cs.c: In function ‘nsp_cs_message’: drivers/scsi/pcmcia/nsp_cs.c:143:2: warning: function ‘nsp_cs_message’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format] drivers/scsi/pcmcia/nsp_cs.c: In function ‘nsp_fifo_count’: drivers/scsi/pcmcia/nsp_cs.c:692:24: warning: variable ‘dummy’ set but not used [-Wunused-but-set-variable] Cc: YOKOTA Hiroshi Signed-off-by: Lee Jones --- drivers/scsi/pcmcia/nsp_cs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.25.1 diff --git a/drivers/scsi/pcmcia/nsp_cs.c b/drivers/scsi/pcmcia/nsp_cs.c index 57a78f84f97ab..8655ff1249bbc 100644 --- a/drivers/scsi/pcmcia/nsp_cs.c +++ b/drivers/scsi/pcmcia/nsp_cs.c @@ -690,14 +690,14 @@ static int nsp_fifo_count(struct scsi_cmnd *SCpnt) { unsigned int base = SCpnt->device->host->io_port; unsigned int count; - unsigned int l, m, h, dummy; + unsigned int l, m, h; nsp_index_write(base, POINTERCLR, POINTER_CLEAR | ACK_COUNTER); l = nsp_index_read(base, TRANSFERCOUNT); m = nsp_index_read(base, TRANSFERCOUNT); h = nsp_index_read(base, TRANSFERCOUNT); - dummy = nsp_index_read(base, TRANSFERCOUNT); /* required this! */ + nsp_index_read(base, TRANSFERCOUNT); /* required this! */ count = (h << 16) | (m << 8) | (l << 0); From patchwork Tue Jul 7 14:00:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 235005 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp942320ilg; Tue, 7 Jul 2020 07:01:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzWEqHdpADanR9ntUuBGbGx782p+VOrwor3HFRnkusZxPFOdiEhfijKeBe0fpVJynMgASEt X-Received: by 2002:a17:906:958f:: with SMTP id r15mr36416639ejx.77.1594130480725; Tue, 07 Jul 2020 07:01:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594130480; cv=none; d=google.com; s=arc-20160816; b=ktjIk592ShP34/1xTdK7XcPTnlZ+WxM0ICFA8uGx+iVBlk/+vuGY1erriyAMcANmUt yrZH6Ja4H0WFjV2s2ZAQ97HdBDkb+qjrkeI5/U92rZQZrrVxZHIO6gMf4YBVYhlVw041 g9IwqfmZZbdknziGvroGtD5LWV3vfVUnfLx/pOASBdQdhSh1y/mYvl1yMgfX6dioPG5m mUE3Gl0mUV9lOQ8635dRvh3oxdIKNKYFxzogcDa9nFOMb264c4H4ZHcveWaTZlAnVoC1 ZK533ld9EoAazxsIxc4eF2NR2iwoapnTm1K1T5se3DELSzs6671n9KNouZdZ8lezKv2f 9/Pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=vhaBeVx21COzmeKvnb9gJbc8Z89FUyhuQpmdHktQvNU=; b=ySGAJL3RgpQvzv8Efr5VvaMz2h2BM2cyy+nAzNZr7qpFVnbVXeqgwNWErar4Y9UH3b OjWjVVqmzkl18YlBotW4UrZJjK4KExigZKV5Ll+V8CZ7sUnCNe4jqjgtep6yZC3I620a NU4S2Z0BLc7mhaOA6UnYVmJcncQLrRAoN6UQT04OuT183GIbUAFRkJ47RtTlTMCQB8yR hHDs6FqAdzlwMZwoTh0N04IISihJ070G7LVrqb0Sos2tRu+uIjZOLsYxejvH/uGfHtxD fmKEDrCrzPNkJ8XJJNkZeT5ZHbLFjTnoWmavCwmZin63HG5kHbP8Ill9opK3nmSA1tCT G5Rw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KtfiWAoC; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g3si16568851edn.594.2020.07.07.07.01.20 for ; Tue, 07 Jul 2020 07:01:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KtfiWAoC; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728260AbgGGOBN (ORCPT ); Tue, 7 Jul 2020 10:01:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728251AbgGGOBL (ORCPT ); Tue, 7 Jul 2020 10:01:11 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83932C08C5E1 for ; Tue, 7 Jul 2020 07:01:11 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id f18so37191988wrs.0 for ; Tue, 07 Jul 2020 07:01:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vhaBeVx21COzmeKvnb9gJbc8Z89FUyhuQpmdHktQvNU=; b=KtfiWAoCLK/CcBzFXZH0DW+6gnwMZ2c+Afoe7FlgDiLH/DcOmeTzvT3CLZ28OGCcLk BUMwFTWdx9lJz0VKuH/Y0B3Y1mi4EzQtjsGBgL1VwD4zIDyaSJKOp9N3OGwr0p1XvkwK wY8TeV3ixEerfVcYgVoT74cyeUVJ4DQ/n5prdBAU6gTD8jcov5a8/KoS47ByMuhEYize jEiVEC4KeZVxshjRGg8fBBFvEia+tj0ZDrICFHZMvaLfpJQ0U04UDOZhgcz6SpHuFn+r Y8fTa1GJHRTF3KbL6oTL43DcMXqaq3QH2Yu+hI2peNaMNNI2etqkDKkLOGVnDoA1ma8H 4Tzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vhaBeVx21COzmeKvnb9gJbc8Z89FUyhuQpmdHktQvNU=; b=QkQeJ8fVqG7lU9GgT3RbxLZB+Hsq/igu9cFvQW6mjXu2aHeuDq1Hu7WXTj93WTtzdx pQyrS8XtIryzzznscF21i28yAqFEFMjnJlm6svu2ILMgacAN8Q+CAe+3bs3xF82xzBn5 LLRKEl/hqQC/HWMzsR4nPbv1JNSDf07iS0IyzeKLRZ02L5jzBZrlikB2bicTxS+Mz0/X Z9BJ2UWtzs3zEsVXsDsxS+uIpp/lxRbSOudw/e5hzC2Bma2xCny6h5pa0zW681KiAh3u 5/GkXLYVR4QXeZ8ELZUcwQEfJ70TF8h1Ik9+jZHuVDW+pzUzwvfUaOdeVeOvOLwoULHZ wtZQ== X-Gm-Message-State: AOAM531p2v/F3w6vu1gFabj4Qi0emvmhgWsXbp913W+XL4tmGFqJt9th WmCrsILaMp5TMFBVmh1nTpw04Q== X-Received: by 2002:adf:cf0c:: with SMTP id o12mr53592490wrj.265.1594130470272; Tue, 07 Jul 2020 07:01:10 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id z25sm1102823wmk.28.2020.07.07.07.01.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 07:01:09 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , Hannes Reinecke Subject: [PATCH 09/10] scsi: libfc: fc_disc: Fix-up some incorrectly referenced function parameters Date: Tue, 7 Jul 2020 15:00:54 +0100 Message-Id: <20200707140055.2956235-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200707140055.2956235-1-lee.jones@linaro.org> References: <20200707140055.2956235-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/libfc/fc_disc.c:343: warning: Function parameter or member 'disc' not described in 'fc_disc_gpn_ft_req' drivers/scsi/libfc/fc_disc.c:343: warning: Excess function parameter 'lport' description in 'fc_disc_gpn_ft_req' drivers/scsi/libfc/fc_disc.c:380: warning: Function parameter or member 'disc' not described in 'fc_disc_gpn_ft_parse' drivers/scsi/libfc/fc_disc.c:380: warning: Excess function parameter 'lport' description in 'fc_disc_gpn_ft_parse' drivers/scsi/libfc/fc_disc.c:498: warning: Function parameter or member 'disc_arg' not described in 'fc_disc_gpn_ft_resp' drivers/scsi/libfc/fc_disc.c:498: warning: Excess function parameter 'lp_arg' description in 'fc_disc_gpn_ft_resp' Cc: Hannes Reinecke Signed-off-by: Lee Jones --- drivers/scsi/libfc/fc_disc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.25.1 Reviewed-by: Hannes Reinecke diff --git a/drivers/scsi/libfc/fc_disc.c b/drivers/scsi/libfc/fc_disc.c index 2b865c6423e29..428f40cfd1c36 100644 --- a/drivers/scsi/libfc/fc_disc.c +++ b/drivers/scsi/libfc/fc_disc.c @@ -337,7 +337,7 @@ static void fc_disc_error(struct fc_disc *disc, struct fc_frame *fp) /** * fc_disc_gpn_ft_req() - Send Get Port Names by FC-4 type (GPN_FT) request - * @lport: The discovery context + * @disc: The discovery context */ static void fc_disc_gpn_ft_req(struct fc_disc *disc) { @@ -370,7 +370,7 @@ static void fc_disc_gpn_ft_req(struct fc_disc *disc) /** * fc_disc_gpn_ft_parse() - Parse the body of the dNS GPN_FT response. - * @lport: The local port the GPN_FT was received on + * @disc: The descovery context * @buf: The GPN_FT response buffer * @len: The size of response buffer * @@ -488,7 +488,7 @@ static void fc_disc_timeout(struct work_struct *work) * fc_disc_gpn_ft_resp() - Handle a response frame from Get Port Names (GPN_FT) * @sp: The sequence that the GPN_FT response was received on * @fp: The GPN_FT response frame - * @lp_arg: The discovery context + * @disc_arg: The discovery context * * Locking Note: This function is called without disc mutex held, and * should do all its processing with the mutex held From patchwork Tue Jul 7 14:00:55 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 235004 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp942222ilg; Tue, 7 Jul 2020 07:01:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzLQ1sL6wp1DbU26zFagtIGxxJW5q7XItXg6BHXK0Y1Eww83vUH6zbRw4oUT/LoKfljEF2I X-Received: by 2002:a17:907:376:: with SMTP id rs22mr22973925ejb.47.1594130475451; Tue, 07 Jul 2020 07:01:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594130475; cv=none; d=google.com; s=arc-20160816; b=gJZ1nCBmoRMA0p0FkMD2PAICIyoRGm73Njg4Jw5+FS1I1fBv7PAKpy0oA5uHT6/WMe o8P9PDxpdHK0xpII3iwTWaIUrW/WP8fiezs/cDNP9qsMhcOBTr4Bp30Ls7pWJK0jbA6B EQ3eoUSi7S9sBJVqFruhhK/uNb07gdg/Ons+iFxuN9wpaR9EU/oXSIf5/rG1/mlB1Zei erMFACP7Toj1BqzI8cAW8NZCmNlO9KdF+wsrlTQjenMMlpiSMvQPtIynRsmcg/n4h5Of myeAD349qGAuKIjRLXF8cD/Y3Ln9z41lXd9rjwCe2SZDist0XlCljHUz+nD27r2EZPyy CucQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Otr0IW/lc2aubOhQuGn1p9ls5bh+wk/N6Wv8oEf4Osw=; b=d5k649ap+GN0AL2lI3yrwiZOA0QX5IALbpMMegrGpeXtMzQVtXzxLrPDAV1XfwlhAf PdM0nTxovONQNWRXIiXLPCJHD0Dnmkc0yDaxgzcgKv6ha6B+AE15pXjoG3Hk1TvND5OS Djwik3cX7/DN2jJIZOZkXAy7YRE/x1QJcuDPVwOv0mjLWNNefJAjFofykNrqx3/BnUhE Y2VDfQtmuWgnYA+B+tPMP9eMPs6iv5+TtBNBRo5xTjT6gnY2aMFC/0ICInbiQo8ClGR6 W5AnjQbjsyaIHbZnp2SJQJVRC47jeCTXFE0CAsuG6IYnj7LN6cZcjnlPgB6VlpYMmYBR mPQw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HBvBoIuz; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l6si15170651edq.465.2020.07.07.07.01.15 for ; Tue, 07 Jul 2020 07:01:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HBvBoIuz; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728280AbgGGOBO (ORCPT ); Tue, 7 Jul 2020 10:01:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728264AbgGGOBN (ORCPT ); Tue, 7 Jul 2020 10:01:13 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F655C08C5E1 for ; Tue, 7 Jul 2020 07:01:13 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id f7so42241391wrw.1 for ; Tue, 07 Jul 2020 07:01:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Otr0IW/lc2aubOhQuGn1p9ls5bh+wk/N6Wv8oEf4Osw=; b=HBvBoIuzw1P53PX21z9xl0S2Ei5cCmdfti89y/X22YhzPD8leJdxCyYAe5MqjAAObx t1E1P2P9Mt2oi9isgC0/LHnqeHNKZYWtJaO+qhuy07fzjZUTGXrc+CimfVho9ZGf/ZWU FDKy8A+01W+GzzbMSh0NL/QIw5GrC1SzMU8Ku91XKRykA1P90kFf0lvjwOf9VATuJ2AA 9517Y+eDIrAIT5wZd8ZZtjlif5PsJkDCzQ/IYlFfSzlxY79jehb6IrMwyQxTx7/P8qGZ eTJ9g4UC2LIojpNdHyExhVDGr4hCe53uRJOxLjIosZU7CLcCCZeB1c2aAfcu+QhcE4go aC+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Otr0IW/lc2aubOhQuGn1p9ls5bh+wk/N6Wv8oEf4Osw=; b=TPM6kgCBZ3vZCzFcyNoUxr4c9on2tlrN6axoelFDrMHBxvSuD76j6XzBfNzuZp8W+n pXeglBd4JmoC3O0Jpu4YGkPrctDZy9vbT3ZtR5zaQn/3H0xUaRmqvG/FhBSxGEqLVGb6 FX+CLKmxgLPld3myMbYnWVC/4PBsVawo5EWk2OJo/sORc6vHrDjWyZJf0P/YPVWFftRZ NJC2YZw5BNWmtW7r3pymi+DLMAVSLUXzjAU3LfOF1kiatCuJv5cgfxZiYRGiGwCvAyw1 LS16xRsZ9+bmAHlosilYsUClGY9IlRSpVREO2HpSvnjAMggoGnUxNs/V3Ic2XnjzhA8M AJ4Q== X-Gm-Message-State: AOAM5311LFbOW8Vkjuhx7ErEp5GUjrzbX8of+gb3Go0mXZQg3wGHmP3z e+w2fcjIOo5BTvsFjpNOaRMJRw== X-Received: by 2002:adf:e647:: with SMTP id b7mr57813003wrn.170.1594130471901; Tue, 07 Jul 2020 07:01:11 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id z25sm1102823wmk.28.2020.07.07.07.01.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 07:01:11 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , Kashyap Desai , Sumit Saxena , Shivasharan S , megaraidlinux.pdl@broadcom.com Subject: [PATCH 10/10] scsi: megaraid: megaraid_sas: Convert forward-declarations to prototypes Date: Tue, 7 Jul 2020 15:00:55 +0100 Message-Id: <20200707140055.2956235-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200707140055.2956235-1-lee.jones@linaro.org> References: <20200707140055.2956235-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/megaraid/megaraid_sas_base.c:240:5: warning: no previous prototype for ‘megasas_readl’ [-Wmissing-prototypes] 240 | u32 megasas_readl(struct megasas_instance *instance, | ^~~~~~~~~~~~~ drivers/scsi/megaraid/megaraid_sas_base.c:301:21: warning: no previous prototype for ‘megasas_get_cmd’ [-Wmissing-prototypes] 301 | struct megasas_cmd *megasas_get_cmd(struct megasas_instance | ^~~~~~~~~~~~~~~ drivers/scsi/megaraid/megaraid_sas_base.c:327:1: warning: no previous prototype for ‘megasas_return_cmd’ [-Wmissing-prototypes] 327 | megasas_return_cmd(struct megasas_instance *instance, struct megasas_cmd *cmd) | ^~~~~~~~~~~~~~~~~~ drivers/scsi/megaraid/megaraid_sas_base.c:1088:1: warning: no previous prototype for ‘megasas_issue_polled’ [-Wmissing-prototypes] 1088 | megasas_issue_polled(struct megasas_instance *instance, struct megasas_cmd *cmd) | ^~~~~~~~~~~~~~~~~~~~ drivers/scsi/megaraid/megaraid_sas_base.c:2149:6: warning: no previous prototype for ‘megaraid_sas_kill_hba’ [-Wmissing-prototypes] 2149 | void megaraid_sas_kill_hba(struct megasas_instance *instance) | ^~~~~~~~~~~~~~~~~~~~~ drivers/scsi/megaraid/megaraid_sas_base.c:2186:1: warning: no previous prototype for ‘megasas_check_and_restore_queue_depth’ [-Wmissing-prototypes] 2186 | megasas_check_and_restore_queue_depth(struct megasas_instance *instance) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/scsi/megaraid/megaraid_sas_base.c:2263:6: warning: no previous prototype for ‘megasas_start_timer’ [-Wmissing-prototypes] 2263 | void megasas_start_timer(struct megasas_instance *instance) | ^~~~~~~~~~~~~~~~~~~ drivers/scsi/megaraid/megaraid_sas_base.c:2579:5: warning: no previous prototype for ‘megasas_sriov_start_heartbeat’ [-Wmissing-prototypes] 2579 | int megasas_sriov_start_heartbeat(struct megasas_instance *instance, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/scsi/megaraid/megaraid_sas_base.c:4292:6: warning: no previous prototype for ‘megasas_free_cmds’ [-Wmissing-prototypes] 4292 | void megasas_free_cmds(struct megasas_instance *instance) | ^~~~~~~~~~~~~~~~~ drivers/scsi/megaraid/megaraid_sas_base.c:4329:5: warning: no previous prototype for ‘megasas_alloc_cmds’ [-Wmissing-prototypes] 4329 | int megasas_alloc_cmds(struct megasas_instance *instance) | ^~~~~~~~~~~~~~~~~~ Cc: Kashyap Desai Cc: Sumit Saxena Cc: Shivasharan S Cc: megaraidlinux.pdl@broadcom.com Signed-off-by: Lee Jones --- drivers/scsi/megaraid/megaraid_sas.h | 25 +++++++++++++++++- drivers/scsi/megaraid/megaraid_sas_fusion.c | 29 --------------------- 2 files changed, 24 insertions(+), 30 deletions(-) -- 2.25.1 diff --git a/drivers/scsi/megaraid/megaraid_sas.h b/drivers/scsi/megaraid/megaraid_sas.h index af2c7a2a95657..5c8037fca5fc6 100644 --- a/drivers/scsi/megaraid/megaraid_sas.h +++ b/drivers/scsi/megaraid/megaraid_sas.h @@ -2683,8 +2683,31 @@ void megasas_return_cmd_fusion(struct megasas_instance *instance, struct megasas_cmd_fusion *cmd); int megasas_issue_blocked_cmd(struct megasas_instance *instance, struct megasas_cmd *cmd, int timeout); -void __megasas_return_cmd(struct megasas_instance *instance, +void megasas_return_cmd(struct megasas_instance *instance, struct megasas_cmd *cmd); +u32 megasas_readl(struct megasas_instance *instance, + const volatile void __iomem *addr); +void megasas_free_cmds(struct megasas_instance *instance); +struct megasas_cmd *megasas_get_cmd(struct megasas_instance *instance); +void megaraid_sas_kill_hba(struct megasas_instance *instance); +void megasas_complete_cmd(struct megasas_instance *instance, + struct megasas_cmd *cmd, u8 alt_status); +int wait_and_poll(struct megasas_instance *instance, struct megasas_cmd *cmd, + int seconds); + +int megasas_alloc_cmds(struct megasas_instance *instance); +int megasas_clear_intr_fusion(struct megasas_instance *instance); +int megasas_issue_polled(struct megasas_instance *instance, + struct megasas_cmd *cmd); +void megasas_check_and_restore_queue_depth(struct megasas_instance *instance); + +int megasas_transition_to_ready(struct megasas_instance *instance, int ocr); +void megaraid_sas_kill_hba(struct megasas_instance *instance); + +extern u32 megasas_dbg_lvl; +int megasas_sriov_start_heartbeat(struct megasas_instance *instance, + int initial); +void megasas_start_timer(struct megasas_instance *instance); void megasas_return_mfi_mpt_pthr(struct megasas_instance *instance, struct megasas_cmd *cmd_mfi, struct megasas_cmd_fusion *cmd_fusion); diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c index a0cf55776361c..fd0f40bc1795d 100644 --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c @@ -48,34 +48,7 @@ #include "megaraid_sas.h" -extern void megasas_free_cmds(struct megasas_instance *instance); -extern struct megasas_cmd *megasas_get_cmd(struct megasas_instance - *instance); -extern void -megasas_complete_cmd(struct megasas_instance *instance, - struct megasas_cmd *cmd, u8 alt_status); -int -wait_and_poll(struct megasas_instance *instance, struct megasas_cmd *cmd, - int seconds); - -void -megasas_return_cmd(struct megasas_instance *instance, struct megasas_cmd *cmd); -int megasas_alloc_cmds(struct megasas_instance *instance); -int -megasas_clear_intr_fusion(struct megasas_instance *instance); -int -megasas_issue_polled(struct megasas_instance *instance, - struct megasas_cmd *cmd); -void -megasas_check_and_restore_queue_depth(struct megasas_instance *instance); - -int megasas_transition_to_ready(struct megasas_instance *instance, int ocr); -void megaraid_sas_kill_hba(struct megasas_instance *instance); -extern u32 megasas_dbg_lvl; -int megasas_sriov_start_heartbeat(struct megasas_instance *instance, - int initial); -void megasas_start_timer(struct megasas_instance *instance); extern struct megasas_mgmt_info megasas_mgmt_info; extern unsigned int resetwaittime; extern unsigned int dual_qdepth_disable; @@ -84,8 +57,6 @@ static void megasas_free_reply_fusion(struct megasas_instance *instance); static inline void megasas_configure_queue_sizes(struct megasas_instance *instance); static void megasas_fusion_crash_dump(struct megasas_instance *instance); -extern u32 megasas_readl(struct megasas_instance *instance, - const volatile void __iomem *addr); /** * megasas_adp_reset_wait_for_ready - initiate chip reset and wait for