From patchwork Fri Apr 24 17:09:56 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anatolij Gustschin X-Patchwork-Id: 238424 List-Id: U-Boot discussion From: agust at denx.de (Anatolij Gustschin) Date: Fri, 24 Apr 2020 19:09:56 +0200 Subject: [PATCH] sunxi: Fix PHY regression on A20-OLinuXino-Lime2 and A20-Olimex-SOM-EVB In-Reply-To: <20200424163405.16916-1-trini@konsulko.com> References: <20200424163405.16916-1-trini@konsulko.com> Message-ID: <20200424190956.65b666fa@crub> On Fri, 24 Apr 2020 12:34:05 -0400 Tom Rini trini at konsulko.com wrote: > When moving the PHYLIB PHY drivers around in Kconfig we did not at the > same time perform a careful migration of the related drivers and > sub-options. This lead to the case where previously Kconfig-enabled > driver choices were now disabled on some platforms. Correct this by > enabling both the PHY driver and sub-option on the above referenced > platforms. > > Fixes: af2cbfd6b982 ("drivers: net: Provide Kconfig menu for PHYLIB") > Fixes: 8728c97eff5b ("configs: Re-sync") > Reported-by: Dario > Signed-off-by: Tom Rini > --- > After checking back on the original commit I can see that these are the > only two platforms to have been broken in the change. configs/A20-OLinuXino-Lime2-eMMC_defconfig might need similar change. We get many build warnings like: include/configs/sunxi-common.h:276:0: warning: "CONFIG_PHY_REALTEK" redefined Could you include following change to fix it? Thanks! Anatolij diff --git a/include/configs/sunxi-common.h b/include/configs/sunxi-common.h index 0ef289fd64..f4bbce8443 100644 --- a/include/configs/sunxi-common.h +++ b/include/configs/sunxi-common.h @@ -273,8 +273,10 @@ extern int soft_i2c_gpio_scl; /* Ethernet support */ #ifdef CONFIG_SUN7I_GMAC +#ifndef CONFIG_PHY_REALTEK #define CONFIG_PHY_REALTEK #endif +#endif #ifdef CONFIG_USB_EHCI_HCD #define CONFIG_USB_OHCI_NEW