From patchwork Tue Aug 18 07:17:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vinod Koul X-Patchwork-Id: 247887 Delivered-To: patch@linaro.org Received: by 2002:a92:cc90:0:0:0:0:0 with SMTP id x16csp3301597ilo; Tue, 18 Aug 2020 00:17:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyUfo1wP8CeWwjxZRJXLr+ChT9ADTleevXkaQAIGJdbNT5jeHhzArcDUOtbAHdun7W+57xC X-Received: by 2002:a05:6402:1545:: with SMTP id p5mr18006417edx.388.1597735077626; Tue, 18 Aug 2020 00:17:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597735077; cv=none; d=google.com; s=arc-20160816; b=piSm2mQ50nJNHGLgbKCWm9NHyqzZQg6Nl+9SyWXMEZqRRlkJqFr8wiSvM7M3cyD2VS EOkEkarsK6AYXSzWMh67g2b0GtC6OOB7Pm/lVLtL4wn7NEl0jigJGrKnDsVv+YqfIMwY qDis/3/i9Qx9MjTnKBYn4kjQZxasphkQ6PsBoiUK+EHkTuHRkSvBa6detCwymToGdCmL yhb0JdhnU/U7V7og2eBJBz/K//ollK5yk6xT7bjupuJnLFUO3Q5hsRbG2DA1xkCi2NbX rP8cpe70ckYb4u4OhavBzNrCQq8M2+u1H9EvfjEQRS8BYt8OY94UNMjFtUMxFX7ux4zp Bhqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=iHFXylc0nCtcIVpFTgrYyMTy3abggXrr/vzY4is8Pb8=; b=ZDOH5ojFvQP4NiKoQ58MQgvn9ogfZC4SRDRI9rWAqNIA2irOsD6NKbXPU3uYQPMYc+ vU2LYipO5JSq3FScA7uczQfbMqy2ZB+hiQdUkHVUisKAkvQ7pZ5a/kiwgYPwz86ulvKT dSAXScmrRJ1ULucEgCDaJi47y5wA3656EktdGQHczwFr4n63/L6yI1VMPKl1Vrg9lvcj nsXiuDTA+PvenWG/8mbOUPSfMRaH4Yk0YMgbDhZxdLTkoirmhV2ff0hyj7YgMHB8JALp 0wRx6kxzXV2S51gVtO28hOmvYg5cW17Ug0kzBdqBpCY3oey/ZfdYa+WL1kzaYZyxmgcK 2ZPQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Z+IJKwKf; spf=pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-usb-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id va1si12574856ejb.558.2020.08.18.00.17.57; Tue, 18 Aug 2020 00:17:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Z+IJKwKf; spf=pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-usb-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726495AbgHRHRx (ORCPT + 5 others); Tue, 18 Aug 2020 03:17:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:47380 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726203AbgHRHRw (ORCPT ); Tue, 18 Aug 2020 03:17:52 -0400 Received: from localhost.localdomain (unknown [122.171.38.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4165D205CB; Tue, 18 Aug 2020 07:17:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597735072; bh=kWDCs6LXZn2ssp8OT7cyDs/w0TvpT8raWUw8rXcIxtg=; h=From:To:Cc:Subject:Date:From; b=Z+IJKwKfMcfb8xleXJHfeTNTZKaLSWURIJbPSpaci0lnXOIL8xjJt/hOmxUNNuFiE BYlTVO9lGqPHhwfblp0lb0l3gN4BQhc0a9+UHMJ815seNpKyJ1t63KkvJjkqDUnmFq tMBWak7WmMKMr4UPt2oY4LtSgErxMPTJZHKPzdkg= From: Vinod Koul To: Mathias Nyman , Greg Kroah-Hartman Cc: Vinod Koul , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3] usb: renesas-xhci: remove version check Date: Tue, 18 Aug 2020 12:47:39 +0530 Message-Id: <20200818071739.789720-1-vkoul@kernel.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Some devices in wild are reporting bunch of firmware versions, so remove the check for versions in driver Reported by: Anastasios Vacharakis Reported by: Glen Journeay Fixes: 2478be82de44 ("usb: renesas-xhci: Add ROM loader for uPD720201") Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=208911 Signed-off-by: Vinod Koul --- Changes in v3: - drop additional firmware versions and remove the check Greg, this fixes regression for folks with preprogrammed controllers please mark as stable material drivers/usb/host/xhci-pci-renesas.c | 19 +------------------ 1 file changed, 1 insertion(+), 18 deletions(-) -- 2.26.2 diff --git a/drivers/usb/host/xhci-pci-renesas.c b/drivers/usb/host/xhci-pci-renesas.c index 59b1965ad0a3..f97ac9f52bf4 100644 --- a/drivers/usb/host/xhci-pci-renesas.c +++ b/drivers/usb/host/xhci-pci-renesas.c @@ -50,20 +50,6 @@ #define RENESAS_RETRY 10000 #define RENESAS_DELAY 10 -#define ROM_VALID_01 0x2013 -#define ROM_VALID_02 0x2026 - -static int renesas_verify_fw_version(struct pci_dev *pdev, u32 version) -{ - switch (version) { - case ROM_VALID_01: - case ROM_VALID_02: - return 0; - } - dev_err(&pdev->dev, "FW has invalid version :%d\n", version); - return -EINVAL; -} - static int renesas_fw_download_image(struct pci_dev *dev, const u32 *fw, size_t step, bool rom) { @@ -202,10 +188,7 @@ static int renesas_check_rom_state(struct pci_dev *pdev) version &= RENESAS_FW_VERSION_FIELD; version = version >> RENESAS_FW_VERSION_OFFSET; - - err = renesas_verify_fw_version(pdev, version); - if (err) - return err; + dev_dbg(&pdev->dev, "Found ROM version: %x\n", version); /* * Test if ROM is present and loaded, if so we can skip everything