From patchwork Wed Aug 26 09:33:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 248405 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:522:0:0:0:0 with SMTP id h2csp4158196ils; Wed, 26 Aug 2020 02:40:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw57W+dSjajne5d6pmTgO7VNG21+ax6NIwyILCFpBipRwrZMsyPF3ChaJiXdbgBNUhFI/X7 X-Received: by 2002:aa7:df0e:: with SMTP id c14mr14496367edy.200.1598434816986; Wed, 26 Aug 2020 02:40:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598434816; cv=none; d=google.com; s=arc-20160816; b=GuuD+ggtK6QQqbUq6BttKwSqL7h1mjb9Zv2vVToHpGEI8HawqaNQEpmYF20nqjlxxj zLT61dEjDeUUkq3GkHHj8qVZ5iXdsLQkywLqbPPRcsqFUJNuMGeXOJZvdpQxRvKkg9FZ lohaNAb3WoVWCVw9eD7naHTI88xrqZFl4SqHUrPQ3vmKz0DQ2C7H2zPav4zvwQjLyU2R ZfsA9bH66Dshugo3t9diGN5jzRI2H1jGGHcfO3wlGOq4Yw7+DCasfYl8MQF3ePu6Pzpc SFIliIwk8V3v+gOdoVC56tUEXo5lr8YuwLb30dDBufZWsBPVH4BWWuEA8GTwBR5NaJBu V5PQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=i2KGeJSrcx/f0sl9IxgJehFn4dP40Mv7ju8hYZZhmHM=; b=SuwCy2Ul/k0QzjfJCKvnSokqPd+q3KtUF9DtiAXdayTQr371R/Tlm3/KpfNQN1Rt/I siljbwKxRO0bc+x0wxdBaO3lLxNqJei13je/if7+Sp01iLnspblWORoWdMPI8ilperaN yg+AUE6hXGpVf/efhIoYdWELqu5Ad0GctK6bh49QstPW8ovn6PuL6xo07FnnRvlF8rq2 gIFRDQz9UVlyuEW/yZkJzbR83NjAjn8dWHNT8BFlPwg+x4g1/HTy0QTQhbnwKiTlEtjh WnZpUpzPLRWD/d2lgNlnON2eVVUJdnfoSgFuA5fGWmsaybzq+Lqap2FZ531vaYQg242K J5XA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=S2CmOO6z; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bq8si1284837ejb.282.2020.08.26.02.40.16; Wed, 26 Aug 2020 02:40:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=S2CmOO6z; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728250AbgHZJkQ (ORCPT + 2 others); Wed, 26 Aug 2020 05:40:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728223AbgHZJeN (ORCPT ); Wed, 26 Aug 2020 05:34:13 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91530C061797 for ; Wed, 26 Aug 2020 02:34:08 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id b79so481999wmb.4 for ; Wed, 26 Aug 2020 02:34:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=i2KGeJSrcx/f0sl9IxgJehFn4dP40Mv7ju8hYZZhmHM=; b=S2CmOO6zGDkBWEgPuXFWOPordeJwDLVLAI2n79heI2Imt9csW1njAXNoAue6rqjwy6 3B2Ga34gD1kBdIoilsSvQE1uNW9hpBIvnQa30YdZvWD1wA1Wol3EMxqHRzFi1XrjfbAD 9WasQOTM7WFO9pw6uS7+qnQCab9TM1l8uINNZGoU9U92tzbyf4tVP/g0QOes2eYcLrzJ imy9PQ4I9pRiteBOeJenYCVcAdYk8U/HZZjCNjCYJZa/j6UYKxJUQ6BtTvGYBaKjpQQC CHZeTzzgOOlQUS7S+R4x3shf5wCwqEHqZ907ws845F8Qda63OvpToJPtyUWKm1/ajuVt wkyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=i2KGeJSrcx/f0sl9IxgJehFn4dP40Mv7ju8hYZZhmHM=; b=eJAyRJckvlrmJas/NdOLk9MFa9myNepL5GqT5UJ468FUGA6B8FWTNQaHCuxt5cYqDy 0g6AuogJNp8TtlNQzwBdgDQqCX6L0Td/2hp5TMrIHpCygtvJu0B+y8f7UU9cwTuZ2IRm F6yZejCCX658Cg85fvt8tyJxcj4h/kV84DFL8iFMwzyBBl6KqEzoGlxV4GS6X2aKdN+/ CAlAPRMjbe/uYoLznMGjH2rRmAoik6vR3CJrckl2DnLBTHwDpXmfDtVYsH0jteyT9nyp QYPa3PJi6hEFVG4OQj61cJrgT1mTqQUW1LLfxyuKnq1y+2eMi3E5qz0HLbZtYabSQtjV RinQ== X-Gm-Message-State: AOAM531mrvy52K/nJUpJwurtkAY2jHWlVd4vJcqQ2lE+ZYeX4NudxCPZ /fi89bC2z1DltOrormoww1TySY/adM/TBw== X-Received: by 2002:a1c:5a87:: with SMTP id o129mr3115105wmb.145.1598434447276; Wed, 26 Aug 2020 02:34:07 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id u3sm3978759wml.44.2020.08.26.02.34.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 02:34:06 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com Subject: [PATCH 02/30] wireless: broadcom: brcmsmac: ampdu: Remove a couple set but unused variables Date: Wed, 26 Aug 2020 10:33:33 +0100 Message-Id: <20200826093401.1458456-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200826093401.1458456-1-lee.jones@linaro.org> References: <20200826093401.1458456-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): from drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c:18: drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c: In function ‘brcms_c_ampdu_dotxstatus_complete’: drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c:850:7: warning: variable ‘update_rate’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c: In function ‘brcms_c_ampdu_dotxstatus’: drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c:1027:20: warning: variable ‘scb_ampdu’ set but not used [-Wunused-but-set-variable] Cc: Arend van Spriel Cc: Franky Lin Cc: Hante Meuleman Cc: Chi-Hsien Lin Cc: Wright Feng Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Lee Jones Cc: linux-wireless@vger.kernel.org Cc: brcm80211-dev-list.pdl@broadcom.com Cc: brcm80211-dev-list@cypress.com Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) -- 2.25.1 diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c index cbad1a11673ae..c9fb4b0cffaf5 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c @@ -847,7 +847,7 @@ brcms_c_ampdu_dotxstatus_complete(struct ampdu_info *ampdu, struct scb *scb, bool ba_recd = false, ack_recd = false; u8 suc_mpdu = 0, tot_mpdu = 0; uint supr_status; - bool update_rate = true, retry = true; + bool retry = true; u16 mimoantsel = 0; u8 retry_limit; struct ieee80211_tx_info *tx_info = IEEE80211_SKB_CB(p); @@ -867,9 +867,6 @@ brcms_c_ampdu_dotxstatus_complete(struct ampdu_info *ampdu, struct scb *scb, supr_status = txs->status & TX_STATUS_SUPR_MASK; if (txs->status & TX_STATUS_ACK_RCV) { - if (TX_STATUS_SUPR_UF == supr_status) - update_rate = false; - WARN_ON(!(txs->status & TX_STATUS_INTERMEDIATE)); start_seq = txs->sequence >> SEQNUM_SHIFT; bitmap[0] = (txs->status & TX_STATUS_BA_BMAP03_MASK) >> @@ -893,7 +890,6 @@ brcms_c_ampdu_dotxstatus_complete(struct ampdu_info *ampdu, struct scb *scb, ba_recd = true; } else { if (supr_status) { - update_rate = false; if (supr_status == TX_STATUS_SUPR_BADCH) { brcms_dbg_ht(wlc->hw->d11core, "%s: Pkt tx suppressed, illegal channel possibly %d\n", @@ -921,7 +917,6 @@ brcms_c_ampdu_dotxstatus_complete(struct ampdu_info *ampdu, struct scb *scb, brcms_c_ffpld_check_txfunfl(wlc, queue); } } else if (txs->phyerr) { - update_rate = false; brcms_dbg_ht(wlc->hw->d11core, "%s: ampdu tx phy error (0x%x)\n", __func__, txs->phyerr); @@ -1024,7 +1019,6 @@ void brcms_c_ampdu_dotxstatus(struct ampdu_info *ampdu, struct scb *scb, struct sk_buff *p, struct tx_status *txs) { - struct scb_ampdu *scb_ampdu; struct brcms_c_info *wlc = ampdu->wlc; u32 s1 = 0, s2 = 0; @@ -1050,7 +1044,6 @@ brcms_c_ampdu_dotxstatus(struct ampdu_info *ampdu, struct scb *scb, } if (scb) { - scb_ampdu = &scb->scb_ampdu; brcms_c_ampdu_dotxstatus_complete(ampdu, scb, p, txs, s1, s2); } else { /* loop through all pkts and free */ From patchwork Wed Aug 26 09:33:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 248404 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:522:0:0:0:0 with SMTP id h2csp4158066ils; Wed, 26 Aug 2020 02:40:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxbLjrL1QsPUfxaManbp8zS38ucPMnFB3Qx98tpyl/1zuZb0AoyPDRold+QHkEXC9iOrSmW X-Received: by 2002:a17:906:7a49:: with SMTP id i9mr15440142ejo.412.1598434804008; Wed, 26 Aug 2020 02:40:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598434804; cv=none; d=google.com; s=arc-20160816; b=XYneYuj3VzZMmbrESpL8jTMdEj10L5uuxmUNHLxyMl6QZo0aEkr/TBfvXY1lwe+WiT 2JlV2alvUC+JvAil080NB2RmnO+fkxawe5mfSvUrqqEnr4Bi3s1hn3B5BlSLqU9ELSYS 4+hSyjPs0g4nIHCFCwdy3AtNXIFuD/9mW3tltW1telLaNaj+X+IZmKE6lYMY1XkP40ld NiTpUVbeBQgFHe9uSBmIO+tsW/V1piqoJ2I+MrE7P8QoSQCKyxDpgmTiKedCdKgwnEen lLZ1byV3EkH23k0Tb9Kq17G6ckoCGuHDn+QQgrKjSis+SPmADd2y18mAkQS5yFJ94rCW IsUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=v7pVwOhCe9Ig2UDjISm2nmmLj5krAF+eOIO1rewFf+g=; b=rzTn/qNPsSjeRDkv6HeuziHE1YphJDwctJPUm0769YZ1nJ52DcBqNgsnzdkOKkT5JU /+NzVjQoseFtN6AOFFg3CWMjqhtnAI56KcICm/KsT8676WVwjmiqbs4Rxxjz029Y4Rrf hib3Hj24uDKkPdrLO/QM8GYs7g4aa8+KK8rHzIYWbR48e/dqheyblrUzIXGIZaBgWkHi AdEy0wJyXHPsh7l66yYx2m/IQlQ3eN/pBh33q9LNhGuNHyPrlyv1oGO1Y0cAHet8vzqp ObfOrjpc9SaI086aXiAyQqH/eonn9hAlKhX2zRQftJN34ndODca42DwrAd29nn5oTQWE yydQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZNXRsZBa; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q3si1189713ejb.543.2020.08.26.02.40.03; Wed, 26 Aug 2020 02:40:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZNXRsZBa; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728721AbgHZJkC (ORCPT + 2 others); Wed, 26 Aug 2020 05:40:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728119AbgHZJeX (ORCPT ); Wed, 26 Aug 2020 05:34:23 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD05AC06179B for ; Wed, 26 Aug 2020 02:34:09 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id c15so1074613wrs.11 for ; Wed, 26 Aug 2020 02:34:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=v7pVwOhCe9Ig2UDjISm2nmmLj5krAF+eOIO1rewFf+g=; b=ZNXRsZBaDCK0ZGjlwQ3/PKGrGin7lml08qakgCCmU3ghxS0TAyUSGf7bHhNMbvss6a 04cMzKGvqwACd1eu6LtK4yJXxM2cZqhEl+weIPkKneohREJt+O3rUodkDcXA06IvwnEV QedgFepoucQodHv0Gy8X08+8FjRQYP5fN9+AjkoJLCoEUypHfAwuWhzDL7iBHQMScE/M qHfDIuA0KcTbxc2DkSswBCbRI82TRNn58UCdgd+sjqyhyJBPrYBLJ0eXX75AG5rKC9X5 4j/FXgyhAfdI7GbqJp6KIxIh3dVxL4OqoJpmXOGYZObKef1URzb+n0Q8ekrkWzkUU4zJ S1Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=v7pVwOhCe9Ig2UDjISm2nmmLj5krAF+eOIO1rewFf+g=; b=f63SnQ5/MlNH30oBHTJCG+W+cje9o9oyHaTXobyKjnOAmwNx8ML4uajzVOI/g6K4Yn Uc8j+bqGu/MvPMZRA5rxiLNpmqtMbGQhHFt7ez2PEinnYlk7ZJ/kozPytsDAlNkiYV4m 9KYLTuiiF2cdkX0S5ciwWn3fe/ZsoXVLzcedZzVj6bp6yQdd9kTORU1Sdg+fB5GVDYwd YWdOaUaJHR4dBPJ3Y27G+FUubcLyj7ZQF7hX6K8ezfrXSVCYYr20ymFbhmws/krlw1Gt mCwvUqtJmg/p+qLA3NjVqjcfv9msFdCxE8E3SXfdugrcZhZqgFidVv86tUcirEW1UWha 87iQ== X-Gm-Message-State: AOAM533bB/+G+V9H2kpgloEW9wk4lRWYrSfVuECuQ0gYID2QYpY8gtKJ 0V/tjUas4e5ISIz++Xme8iUY/A== X-Received: by 2002:adf:ef8c:: with SMTP id d12mr9875191wro.282.1598434448303; Wed, 26 Aug 2020 02:34:08 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id u3sm3978759wml.44.2020.08.26.02.34.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 02:34:07 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Stanislaw Gruszka , Linux Wireless Subject: [PATCH 03/30] wireless: intel: iwlegacy: 3945-mac: Remove all non-conformant kernel-doc headers Date: Wed, 26 Aug 2020 10:33:34 +0100 Message-Id: <20200826093401.1458456-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200826093401.1458456-1-lee.jones@linaro.org> References: <20200826093401.1458456-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/intel/iwlegacy/3945-mac.c:821: warning: Function parameter or member 'il' not described in 'il3945_setup_handlers' drivers/net/wireless/intel/iwlegacy/3945-mac.c:915: warning: Function parameter or member 'il' not described in 'il3945_dma_addr2rbd_ptr' drivers/net/wireless/intel/iwlegacy/3945-mac.c:915: warning: Function parameter or member 'dma_addr' not described in 'il3945_dma_addr2rbd_ptr' drivers/net/wireless/intel/iwlegacy/3945-mac.c:932: warning: Function parameter or member 'il' not described in 'il3945_rx_queue_restock' drivers/net/wireless/intel/iwlegacy/3945-mac.c:979: warning: Function parameter or member 'il' not described in 'il3945_rx_allocate' drivers/net/wireless/intel/iwlegacy/3945-mac.c:979: warning: Function parameter or member 'priority' not described in 'il3945_rx_allocate' drivers/net/wireless/intel/iwlegacy/3945-mac.c:1179: warning: Function parameter or member 'il' not described in 'il3945_rx_handle' drivers/net/wireless/intel/iwlegacy/3945-mac.c:1663: warning: Function parameter or member 'il' not described in 'il3945_verify_inst_full' drivers/net/wireless/intel/iwlegacy/3945-mac.c:1663: warning: Function parameter or member 'image' not described in 'il3945_verify_inst_full' drivers/net/wireless/intel/iwlegacy/3945-mac.c:1663: warning: Function parameter or member 'len' not described in 'il3945_verify_inst_full' drivers/net/wireless/intel/iwlegacy/3945-mac.c:1703: warning: Function parameter or member 'il' not described in 'il3945_verify_inst_sparse' drivers/net/wireless/intel/iwlegacy/3945-mac.c:1703: warning: Function parameter or member 'image' not described in 'il3945_verify_inst_sparse' drivers/net/wireless/intel/iwlegacy/3945-mac.c:1703: warning: Function parameter or member 'len' not described in 'il3945_verify_inst_sparse' drivers/net/wireless/intel/iwlegacy/3945-mac.c:1739: warning: Function parameter or member 'il' not described in 'il3945_verify_ucode' drivers/net/wireless/intel/iwlegacy/3945-mac.c:1821: warning: Function parameter or member 'il' not described in 'il3945_read_ucode' drivers/net/wireless/intel/iwlegacy/3945-mac.c:2061: warning: Function parameter or member 'il' not described in 'il3945_set_ucode_ptrs' drivers/net/wireless/intel/iwlegacy/3945-mac.c:2093: warning: Function parameter or member 'il' not described in 'il3945_init_alive_start' drivers/net/wireless/intel/iwlegacy/3945-mac.c:2135: warning: Function parameter or member 'il' not described in 'il3945_alive_start' Cc: Stanislaw Gruszka Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Linux Wireless Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- .../net/wireless/intel/iwlegacy/3945-mac.c | 24 +++++++++---------- 1 file changed, 12 insertions(+), 12 deletions(-) -- 2.25.1 diff --git a/drivers/net/wireless/intel/iwlegacy/3945-mac.c b/drivers/net/wireless/intel/iwlegacy/3945-mac.c index 9167c3d2711dd..3a3439492dc16 100644 --- a/drivers/net/wireless/intel/iwlegacy/3945-mac.c +++ b/drivers/net/wireless/intel/iwlegacy/3945-mac.c @@ -807,7 +807,7 @@ il3945_hdl_card_state(struct il_priv *il, struct il_rx_buf *rxb) wake_up(&il->wait_command_queue); } -/** +/* * il3945_setup_handlers - Initialize Rx handler callbacks * * Setup the RX handlers for each of the reply types sent from the uCode @@ -907,7 +907,7 @@ il3945_setup_handlers(struct il_priv *il) * */ -/** +/* * il3945_dma_addr2rbd_ptr - convert a DMA address to a uCode read buffer ptr */ static inline __le32 @@ -916,7 +916,7 @@ il3945_dma_addr2rbd_ptr(struct il_priv *il, dma_addr_t dma_addr) return cpu_to_le32((u32) dma_addr); } -/** +/* * il3945_rx_queue_restock - refill RX queue from pre-allocated pool * * If there are slots in the RX queue that need to be restocked, @@ -966,7 +966,7 @@ il3945_rx_queue_restock(struct il_priv *il) } } -/** +/* * il3945_rx_replenish - Move all used packet from rx_used to rx_free * * When moving to rx_free an SKB is allocated for the slot. @@ -1167,7 +1167,7 @@ il3945_calc_db_from_ratio(int sig_ratio) return (int)ratio2dB[sig_ratio]; } -/** +/* * il3945_rx_handle - Main entry function for receiving responses from uCode * * Uses the il->handlers callback function array to invoke @@ -1654,7 +1654,7 @@ il3945_dealloc_ucode_pci(struct il_priv *il) il_free_fw_desc(il->pci_dev, &il->ucode_boot); } -/** +/* * il3945_verify_inst_full - verify runtime uCode image in card vs. host, * looking at all data. */ @@ -1693,7 +1693,7 @@ il3945_verify_inst_full(struct il_priv *il, __le32 * image, u32 len) return rc; } -/** +/* * il3945_verify_inst_sparse - verify runtime uCode image in card vs. host, * using sample data 100 bytes apart. If these sample points are good, * it's a pretty good bet that everything between them is good, too. @@ -1730,7 +1730,7 @@ il3945_verify_inst_sparse(struct il_priv *il, __le32 * image, u32 len) return rc; } -/** +/* * il3945_verify_ucode - determine which instruction image is in SRAM, * and verify its contents */ @@ -1811,7 +1811,7 @@ IL3945_UCODE_GET(init_size); IL3945_UCODE_GET(init_data_size); IL3945_UCODE_GET(boot_size); -/** +/* * il3945_read_ucode - Read uCode images from disk file. * * Copy into buffers for card to fetch via bus-mastering @@ -2047,7 +2047,7 @@ il3945_read_ucode(struct il_priv *il) return ret; } -/** +/* * il3945_set_ucode_ptrs - Set uCode address location * * Tell initialization uCode where to find runtime uCode. @@ -2081,7 +2081,7 @@ il3945_set_ucode_ptrs(struct il_priv *il) return 0; } -/** +/* * il3945_init_alive_start - Called after N_ALIVE notification received * * Called after N_ALIVE notification received from "initialize" uCode. @@ -2125,7 +2125,7 @@ il3945_init_alive_start(struct il_priv *il) queue_work(il->workqueue, &il->restart); } -/** +/* * il3945_alive_start - called after N_ALIVE notification received * from protocol/runtime uCode (initialization uCode's * Alive gets handled by il3945_init_alive_start()). From patchwork Wed Aug 26 09:33:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 248401 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:522:0:0:0:0 with SMTP id h2csp4157842ils; Wed, 26 Aug 2020 02:39:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyl4ROS/2uu1Ly3G6KtYnFh/3V6LFWeZDyr2+CK9kWyCtsD8brje2kvMoSJeCBpFCRERHqq X-Received: by 2002:a50:8e14:: with SMTP id 20mr14645022edw.331.1598434780240; Wed, 26 Aug 2020 02:39:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598434780; cv=none; d=google.com; s=arc-20160816; b=N/wn2bWRX9jecgL79rFXulNOD4jyfQ0HjI8oOE3jI4mqXmOJtxOWGjAaMBifuYwKiT 4mGgJT9tiDeDwG6rAGk9wgHu1EentFkEfgzd1ELA0+pP/xmUe/y4ex+AoCAUBiL0Z7KY fLpckaisBqfoJ5rFy19RNuB9j4fLuwFQ+74cTYWkvKiDG9Xxk3QDXUOdLpjFIhvIHcxH nIX0whMzWb3UUtOhbrXsAgv82Cbg5cb86YVBiz8GFURhi9jiP3f0mgTxKopiaYoQPEdq uCYPhJepXFCPqKn8oOH25CvZE/ut6fjPRMjuKAkBVw48Kpno5awzIlRclga6Q93wczId NsBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ZXzMFpauZUbIvXTpTjTk511d7rH3VOBZcuLvH1EPh6E=; b=oDWRXYNID8CXoVjti6pEaAtGHVJ9809U8QtN3+tL0onguxr5DC489vLYt/Ii/7MuCq 6sZ6gYz0kEhm9XhOK2GrY+B2sKArl6ul+aBDbdbRr26dRM3NFeMUMDY+vot+8a24tHuD oBad0g7G15YA6WerlIgSFr3L6TJNXr8pZiMgiF5AUh3U3T7DRnVhVx7zhlOJL/9vALT2 Cr8EGu51mp5g//riZzlGSjZmHF9fAeWEly6lu115C+/o0ab9lRPpl75T1007a6+xAse2 cfQuq0puDTZgUloHDY3ulZkg/Ef2xgZ4ZTIbwvi+xBIKnkx8qAtEpqzaYYJYjBWBjnMp QZ4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JXl7Wb1T; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a15si1209383edr.160.2020.08.26.02.39.39; Wed, 26 Aug 2020 02:39:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JXl7Wb1T; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728651AbgHZJji (ORCPT + 2 others); Wed, 26 Aug 2020 05:39:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728253AbgHZJeZ (ORCPT ); Wed, 26 Aug 2020 05:34:25 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84EDBC0617A5 for ; Wed, 26 Aug 2020 02:34:12 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id c15so1074778wrs.11 for ; Wed, 26 Aug 2020 02:34:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZXzMFpauZUbIvXTpTjTk511d7rH3VOBZcuLvH1EPh6E=; b=JXl7Wb1TDc4vtCMn0jU7O2QGXjAE5ZmvNt2UgRowQia4ULjEjnVwFgycqO/xL1xiQL mGwTh6TOAaoCjozXj2v0shvbn57oE3Xbb5yL1zNlrF02tx8FgyqJdJSQ9UBUE7iHQ8Pq WPWeG8MVNOmVmdJCNGy5SV7kEgbOq+/qq+Y0NJ3svO09zeXVLiYNEIt/AkpRr1P8ZkiO NPuBH1yw62bbpTY/ejBsGMKIcy4LOtPiy05IcYX7RwnO3KH9go0bveQTm87bM8i6nI16 rKTfoHx+Xm08R/jH66MdPo3S/AnpzzllpPwufZZhnxpsr6fKuaunZX44bkkmzYRGHhVG S0TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZXzMFpauZUbIvXTpTjTk511d7rH3VOBZcuLvH1EPh6E=; b=lJflF0rHhvUz2ipp9oCRbibDfr4SdayvzMgX0wXlLjdhGDFhuU/wOxZP371EX06QBS /EYCosNllp3bg9P/JkfgDLDZ663I5RRWkOqvUnle188sbLtTqHyx2Y4XPTRvmtMpWFqa Y1Bw0LuzXzpwwcg/dlW5+DbQtrXo7Qf1jvy75J3JtNieQFk0Qn9A6yT/OUpoBlmCGk0m UyNzcLzZGP3q8d/BM6uXUP7iwZhjw6spBQoog8fBxgvpIXDOW+a+/SEkZsjDkHkxrqnx r1/dh7NS3rGcZVnJxXTXQGuGUSEmDPZlrQrSkZ+TNDZAJLLteYRgFsB3Khx8PFl8NM6M 2ngg== X-Gm-Message-State: AOAM530Xw7+4SurY1mSQOhPE6Tz2xKI5iT3Pk7bbdrykZBCgA0IBuiFg qfH79bmYPCI5HByqrOwvV8BiHQ== X-Received: by 2002:adf:f041:: with SMTP id t1mr7808292wro.314.1598434450993; Wed, 26 Aug 2020 02:34:10 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id u3sm3978759wml.44.2020.08.26.02.34.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 02:34:10 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Stanislaw Gruszka , Linux Wireless Subject: [PATCH 05/30] wireless: intel: iwlegacy: 3945: Remove all non-conformant kernel-doc headers Date: Wed, 26 Aug 2020 10:33:36 +0100 Message-Id: <20200826093401.1458456-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200826093401.1458456-1-lee.jones@linaro.org> References: <20200826093401.1458456-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/intel/iwlegacy/3945.c:104: warning: Function parameter or member 'il' not described in 'il3945_disable_events' drivers/net/wireless/intel/iwlegacy/3945.c:273: warning: Function parameter or member 'il' not described in 'il3945_tx_queue_reclaim' drivers/net/wireless/intel/iwlegacy/3945.c:273: warning: Function parameter or member 'txq_id' not described in 'il3945_tx_queue_reclaim' drivers/net/wireless/intel/iwlegacy/3945.c:273: warning: Function parameter or member 'idx' not described in 'il3945_tx_queue_reclaim' drivers/net/wireless/intel/iwlegacy/3945.c:299: warning: Function parameter or member 'il' not described in 'il3945_hdl_tx' drivers/net/wireless/intel/iwlegacy/3945.c:299: warning: Function parameter or member 'rxb' not described in 'il3945_hdl_tx' drivers/net/wireless/intel/iwlegacy/3945.c:637: warning: Function parameter or member 'il' not described in 'il3945_hw_txq_free_tfd' drivers/net/wireless/intel/iwlegacy/3945.c:637: warning: Function parameter or member 'txq' not described in 'il3945_hw_txq_free_tfd' drivers/net/wireless/intel/iwlegacy/3945.c:686: warning: Function parameter or member 'il' not described in 'il3945_hw_build_tx_cmd_rate' drivers/net/wireless/intel/iwlegacy/3945.c:686: warning: Function parameter or member 'cmd' not described in 'il3945_hw_build_tx_cmd_rate' drivers/net/wireless/intel/iwlegacy/3945.c:686: warning: Function parameter or member 'info' not described in 'il3945_hw_build_tx_cmd_rate' drivers/net/wireless/intel/iwlegacy/3945.c:686: warning: Function parameter or member 'hdr' not described in 'il3945_hw_build_tx_cmd_rate' drivers/net/wireless/intel/iwlegacy/3945.c:686: warning: Function parameter or member 'sta_id' not described in 'il3945_hw_build_tx_cmd_rate' drivers/net/wireless/intel/iwlegacy/3945.c:838: warning: Function parameter or member 'il' not described in 'il3945_txq_ctx_reset' drivers/net/wireless/intel/iwlegacy/3945.c:1003: warning: Function parameter or member 'il' not described in 'il3945_hw_txq_ctx_free' drivers/net/wireless/intel/iwlegacy/3945.c:1044: warning: Function parameter or member 'new_reading' not described in 'il3945_hw_reg_adjust_power_by_temp' drivers/net/wireless/intel/iwlegacy/3945.c:1044: warning: Function parameter or member 'old_reading' not described in 'il3945_hw_reg_adjust_power_by_temp' drivers/net/wireless/intel/iwlegacy/3945.c:1053: warning: Function parameter or member 'temperature' not described in 'il3945_hw_reg_temp_out_of_range' drivers/net/wireless/intel/iwlegacy/3945.c:1069: warning: Function parameter or member 'il' not described in 'il3945_hw_reg_txpower_get_temperature' drivers/net/wireless/intel/iwlegacy/3945.c:1107: warning: Function parameter or member 'il' not described in 'il3945_is_temp_calib_needed' drivers/net/wireless/intel/iwlegacy/3945.c:1328: warning: Function parameter or member 'il' not described in 'il3945_hw_reg_set_scan_power' drivers/net/wireless/intel/iwlegacy/3945.c:1328: warning: Function parameter or member 'scan_tbl_idx' not described in 'il3945_hw_reg_set_scan_power' drivers/net/wireless/intel/iwlegacy/3945.c:1328: warning: Function parameter or member 'rate_idx' not described in 'il3945_hw_reg_set_scan_power' drivers/net/wireless/intel/iwlegacy/3945.c:1328: warning: Function parameter or member 'clip_pwrs' not described in 'il3945_hw_reg_set_scan_power' drivers/net/wireless/intel/iwlegacy/3945.c:1328: warning: Function parameter or member 'ch_info' not described in 'il3945_hw_reg_set_scan_power' drivers/net/wireless/intel/iwlegacy/3945.c:1328: warning: Function parameter or member 'band_idx' not described in 'il3945_hw_reg_set_scan_power' drivers/net/wireless/intel/iwlegacy/3945.c:1383: warning: Function parameter or member 'il' not described in 'il3945_send_tx_power' drivers/net/wireless/intel/iwlegacy/3945.c:1460: warning: Function parameter or member 'il' not described in 'il3945_hw_reg_set_new_power' drivers/net/wireless/intel/iwlegacy/3945.c:1522: warning: Function parameter or member 'ch_info' not described in 'il3945_hw_reg_get_ch_txpower_limit' drivers/net/wireless/intel/iwlegacy/3945.c:1552: warning: Function parameter or member 'il' not described in 'il3945_hw_reg_comp_txpower_temp' drivers/net/wireless/intel/iwlegacy/3945.c:1712: warning: Function parameter or member 'il' not described in 'il3945_commit_rxon' drivers/net/wireless/intel/iwlegacy/3945.c:1845: warning: Function parameter or member 'il' not described in 'il3945_reg_txpower_periodic' drivers/net/wireless/intel/iwlegacy/3945.c:1889: warning: Function parameter or member 'il' not described in 'il3945_hw_reg_get_ch_grp_idx' drivers/net/wireless/intel/iwlegacy/3945.c:1889: warning: Function parameter or member 'ch_info' not described in 'il3945_hw_reg_get_ch_grp_idx' drivers/net/wireless/intel/iwlegacy/3945.c:1924: warning: Function parameter or member 'il' not described in 'il3945_hw_reg_get_matched_power_idx' drivers/net/wireless/intel/iwlegacy/3945.c:1924: warning: Function parameter or member 'requested_power' not described in 'il3945_hw_reg_get_matched_power_idx' drivers/net/wireless/intel/iwlegacy/3945.c:1924: warning: Function parameter or member 'setting_idx' not described in 'il3945_hw_reg_get_matched_power_idx' drivers/net/wireless/intel/iwlegacy/3945.c:1924: warning: Function parameter or member 'new_idx' not described in 'il3945_hw_reg_get_matched_power_idx' drivers/net/wireless/intel/iwlegacy/3945.c:2055: warning: Function parameter or member 'il' not described in 'il3945_txpower_set_from_eeprom' drivers/net/wireless/intel/iwlegacy/3945.c:2313: warning: Function parameter or member 'il' not described in 'il3945_init_hw_rate_table' Cc: Stanislaw Gruszka Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Linux Wireless Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/intel/iwlegacy/3945.c | 46 +++++++++++----------- 1 file changed, 23 insertions(+), 23 deletions(-) -- 2.25.1 diff --git a/drivers/net/wireless/intel/iwlegacy/3945.c b/drivers/net/wireless/intel/iwlegacy/3945.c index fd63eba47ba22..0597d828bee1e 100644 --- a/drivers/net/wireless/intel/iwlegacy/3945.c +++ b/drivers/net/wireless/intel/iwlegacy/3945.c @@ -90,7 +90,7 @@ il3945_get_prev_ieee_rate(u8 rate_idx) #define IL_EVT_DISABLE (0) #define IL_EVT_DISABLE_SIZE (1532/32) -/** +/* * il3945_disable_events - Disable selected events in uCode event log * * Disable an event by writing "1"s into "disable" @@ -261,7 +261,7 @@ il3945_rs_next_rate(struct il_priv *il, int rate) return next_rate; } -/** +/* * il3945_tx_queue_reclaim - Reclaim Tx queue entries already Tx'd * * When FW advances 'R' idx, all entries between old and new 'R' idx @@ -291,7 +291,7 @@ il3945_tx_queue_reclaim(struct il_priv *il, int txq_id, int idx) il_wake_queue(il, txq); } -/** +/* * il3945_hdl_tx - Handle Tx response */ static void @@ -627,7 +627,7 @@ il3945_hw_txq_attach_buf_to_tfd(struct il_priv *il, struct il_tx_queue *txq, return 0; } -/** +/* * il3945_hw_txq_free_tfd - Free one TFD, those at idx [txq->q.read_ptr] * * Does NOT advance any idxes @@ -675,7 +675,7 @@ il3945_hw_txq_free_tfd(struct il_priv *il, struct il_tx_queue *txq) } } -/** +/* * il3945_hw_build_tx_cmd_rate - Add rate portion to TX_CMD: * */ @@ -828,7 +828,7 @@ il3945_tx_reset(struct il_priv *il) return 0; } -/** +/* * il3945_txq_ctx_reset - Reset TX queue context * * Destroys all DMA structures and initialize them again @@ -993,7 +993,7 @@ il3945_hw_nic_init(struct il_priv *il) return 0; } -/** +/* * il3945_hw_txq_ctx_free - Free TXQ Context * * Destroy all TX DMA queues and structures @@ -1035,7 +1035,7 @@ il3945_hw_txq_ctx_stop(struct il_priv *il) } } -/** +/* * il3945_hw_reg_adjust_power_by_temp * return idx delta into power gain settings table */ @@ -1045,7 +1045,7 @@ il3945_hw_reg_adjust_power_by_temp(int new_reading, int old_reading) return (new_reading - old_reading) * (-11) / 100; } -/** +/* * il3945_hw_reg_temp_out_of_range - Keep temperature in sane range */ static inline int @@ -1060,7 +1060,7 @@ il3945_hw_get_temperature(struct il_priv *il) return _il_rd(il, CSR_UCODE_DRV_GP2); } -/** +/* * il3945_hw_reg_txpower_get_temperature * get the current temperature by reading from NIC */ @@ -1096,7 +1096,7 @@ il3945_hw_reg_txpower_get_temperature(struct il_priv *il) * Both are lower than older versions' 9 degrees */ #define IL_TEMPERATURE_LIMIT_TIMER 6 -/** +/* * il3945_is_temp_calib_needed - determines if new calibration is needed * * records new temperature in tx_mgr->temperature. @@ -1315,7 +1315,7 @@ il3945_hw_reg_fix_power_idx(int idx) /* Kick off thermal recalibration check every 60 seconds */ #define REG_RECALIB_PERIOD (60) -/** +/* * il3945_hw_reg_set_scan_power - Set Tx power for scan probe requests * * Set (in our channel info database) the direct scan Tx power for 1 Mbit (CCK) @@ -1372,7 +1372,7 @@ il3945_hw_reg_set_scan_power(struct il_priv *il, u32 scan_tbl_idx, s32 rate_idx, power_gain_table[band_idx][power_idx].dsp_atten; } -/** +/* * il3945_send_tx_power - fill in Tx Power command with gain settings * * Configures power settings for all rates for the current channel, @@ -1439,7 +1439,7 @@ il3945_send_tx_power(struct il_priv *il) } -/** +/* * il3945_hw_reg_set_new_power - Configures power tables at new levels * @ch_info: Channel to update. Uses power_info.requested_power. * @@ -1510,7 +1510,7 @@ il3945_hw_reg_set_new_power(struct il_priv *il, struct il_channel_info *ch_info) return 0; } -/** +/* * il3945_hw_reg_get_ch_txpower_limit - returns new power limit for channel * * NOTE: Returned power limit may be less (but not more) than requested, @@ -1537,7 +1537,7 @@ il3945_hw_reg_get_ch_txpower_limit(struct il_channel_info *ch_info) return min(max_power, ch_info->max_power_avg); } -/** +/* * il3945_hw_reg_comp_txpower_temp - Compensate for temperature * * Compensate txpower settings of *all* channels for temperature. @@ -1699,7 +1699,7 @@ il3945_send_rxon_assoc(struct il_priv *il) return rc; } -/** +/* * il3945_commit_rxon - commit staging_rxon to hardware * * The RXON command in staging_rxon is committed to the hardware and @@ -1830,7 +1830,7 @@ il3945_commit_rxon(struct il_priv *il) return 0; } -/** +/* * il3945_reg_txpower_periodic - called when time to check our temperature. * * -- reset periodic timer @@ -1873,7 +1873,7 @@ il3945_bg_reg_txpower_periodic(struct work_struct *work) mutex_unlock(&il->mutex); } -/** +/* * il3945_hw_reg_get_ch_grp_idx - find the channel-group idx (0-4) for channel. * * This function is used when initializing channel-info structs. @@ -1912,7 +1912,7 @@ il3945_hw_reg_get_ch_grp_idx(struct il_priv *il, return group_idx; } -/** +/* * il3945_hw_reg_get_matched_power_idx - Interpolate to get nominal idx * * Interpolate to get nominal (i.e. at factory calibration temperature) idx @@ -2035,7 +2035,7 @@ il3945_hw_reg_init_channel_groups(struct il_priv *il) } } -/** +/* * il3945_txpower_set_from_eeprom - Set channel power info based on EEPROM * * Second pass (during init) to set up il->channel_info @@ -2305,7 +2305,7 @@ il3945_manage_ibss_station(struct il_priv *il, struct ieee80211_vif *vif, vif->bss_conf.bssid); } -/** +/* * il3945_init_hw_rate_table - Initialize the hardware rate fallback table */ int @@ -2520,7 +2520,7 @@ il3945_eeprom_release_semaphore(struct il_priv *il) return; } - /** + /* * il3945_load_bsm - Load bootstrap instructions * * BSM operation: From patchwork Wed Aug 26 09:33:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 248399 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:522:0:0:0:0 with SMTP id h2csp4157640ils; Wed, 26 Aug 2020 02:39:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy1oBg2Q6RXjkxRs5v6o2sEDLVw3x+NkeiSQlV3i2XmklpiHBQXSBw+mtvUy1+ERTtsQfGC X-Received: by 2002:a17:906:3ac4:: with SMTP id z4mr13969118ejd.65.1598434760504; Wed, 26 Aug 2020 02:39:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598434760; cv=none; d=google.com; s=arc-20160816; b=Kyn29LKcEDNK8dogdAyRXwqGcRYydkn0FPgZw139ayAkF82Hd/Vy6XWsTs1XrKb5eP GE39zOo1IY9ikkooP/nCAx6JwBsYsInHGaLEMV/s7asz/r25hrSYEPWfvSW/PVDNy7DC cFGyQqbNNbNjBlGO8qXavTp458PqebvSGvdyh5nBX4kw5YuE/LskCE68BWlHVkG1GQC/ mceLoNm+dCWW7rMwWSQiTU2ogY2ftm6Lfsh+JBwvPQYUQ0q2yBbQF/+ykd8jC/lvfm/A RNyaXtTucf42kE0QqLXLC/nuVXu1tA/3MjezxbqMhmEeDEm7u/TX3F/WEsmKhhpzQnq0 9bKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=7NPqtCpN+MJMO4A/dgMyA434mUf+bmEkPLCWrQ+c5YA=; b=nrMYzcR6ckMIbhVHKllWQom1JhcMG+T9EuYNqsitOQyfb95OKYeY2SkHkxgrb9vXTR SGVwME4xSnNDM0YQ/xP5yP8GHayz80BFKrziL8lQ13rHDUuaJ9KsvFTFCoVPXVWka4kr qgzWGUVRWwmYxWLtJRpL3R+gNt6LSC29PBQ6hawoFp0nroZvboEXyICNu4ZHvoO18KFy JFeYIi2WFwOWvsNtNY9/xzz9AwXMPdji3XHMb5ge7NqIYVaLsS10JROygLalTrgIt818 sxEJZLf+vHwujhXn7XuZJB+LcyD9T+b9oMoOGK7r42zyXc0OjBPtvDR3JFXu780PeWLS Owjg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wEtprO+k; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id va1si1202798ejb.558.2020.08.26.02.39.20; Wed, 26 Aug 2020 02:39:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wEtprO+k; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728687AbgHZJjR (ORCPT + 2 others); Wed, 26 Aug 2020 05:39:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728261AbgHZJe0 (ORCPT ); Wed, 26 Aug 2020 05:34:26 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5F0AC061574 for ; Wed, 26 Aug 2020 02:34:14 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id b79so482433wmb.4 for ; Wed, 26 Aug 2020 02:34:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7NPqtCpN+MJMO4A/dgMyA434mUf+bmEkPLCWrQ+c5YA=; b=wEtprO+kfdTRh0oBj+5B8Yy4ISBKhQwNoTK2RGOv3zTrbnF9ElfliFrU1265sy2Dlk X/Ql8tuDk3rwEZ/h46rhTJo/9PJUV7zVajAOJBku2X0uO34M80zXe45EDRxYuRqQleDC NAP9JiR0oSCosMNy+oDBMCmD/yLLjTIp8xiMSXLlVqiYG1K+qxxyGamKNF7mIOUuyrb5 2VSYZ/iMRe2lF+4MMY6QZMN5DYTs+DH4vh/WXqjhBMVd/g37WzOUKzu3gn6NxpqqmLqK OxsVrOTqkJx4HfE7sGwpLwgjM/oHqbOrnto26nf/M69S3VNyhRFIPip5KiAAkOn5l5Qw D+tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7NPqtCpN+MJMO4A/dgMyA434mUf+bmEkPLCWrQ+c5YA=; b=GPLs86EyJMSinfYtFXiFqOBYINpZ3UMLiuczQhBJL5pe/zLqqmIefcNL1qzWhlboYA HzhBKLz92wCjqYeWD5GyOK9HS++A6DsBQRsI4q6XYCqLnXkekjCpMzRmpmRu/ZrEuFmC qpC27bV+leW7D7/qye4NEuCawv1h96PgH8oRAiKbpS3IXJKbRWkyTKl+PleqyKUrU+hL 4veW82RI4Iw7AUbWIYDYfpLtAP+WmWODcIsjb5DCVPfuVYTp2zgACvsBVOvbk79hSH+Q KtoK5lvpRBMCk70RS0w7P8jGpKDdatPq3JS7o5G8cfb4LRDmXPrWfpsKWCmM7e5uN9ZM kTAQ== X-Gm-Message-State: AOAM530RhWK/sAPCxqkGjw4+65MS/gXg4FdSUbswXmGKydgOvFWRPPYf K7Jh1N5edMAWQUkwEnLMwz+66A== X-Received: by 2002:a1c:b4c1:: with SMTP id d184mr6449203wmf.26.1598434453548; Wed, 26 Aug 2020 02:34:13 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id u3sm3978759wml.44.2020.08.26.02.34.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 02:34:12 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Greg Kroah-Hartman Subject: [PATCH 07/30] wireless: intersil: orinoco_usb: Downgrade non-conforming kernel-doc headers Date: Wed, 26 Aug 2020 10:33:38 +0100 Message-Id: <20200826093401.1458456-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200826093401.1458456-1-lee.jones@linaro.org> References: <20200826093401.1458456-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/intersil/orinoco/orinoco_usb.c:434: warning: Function parameter or member 'upriv' not described in 'ezusb_req_queue_run' drivers/net/wireless/intersil/orinoco/orinoco_usb.c:716: warning: Function parameter or member 'req' not described in 'ezusb_fill_req' drivers/net/wireless/intersil/orinoco/orinoco_usb.c:716: warning: Function parameter or member 'length' not described in 'ezusb_fill_req' drivers/net/wireless/intersil/orinoco/orinoco_usb.c:716: warning: Function parameter or member 'rid' not described in 'ezusb_fill_req' drivers/net/wireless/intersil/orinoco/orinoco_usb.c:716: warning: Function parameter or member 'data' not described in 'ezusb_fill_req' drivers/net/wireless/intersil/orinoco/orinoco_usb.c:716: warning: Function parameter or member 'frame_type' not described in 'ezusb_fill_req' drivers/net/wireless/intersil/orinoco/orinoco_usb.c:716: warning: Function parameter or member 'reply_count' not described in 'ezusb_fill_req' Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Greg Kroah-Hartman Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/intersil/orinoco/orinoco_usb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.25.1 diff --git a/drivers/net/wireless/intersil/orinoco/orinoco_usb.c b/drivers/net/wireless/intersil/orinoco/orinoco_usb.c index 11fa38fedd870..645856bc1796c 100644 --- a/drivers/net/wireless/intersil/orinoco/orinoco_usb.c +++ b/drivers/net/wireless/intersil/orinoco/orinoco_usb.c @@ -423,13 +423,13 @@ static void ezusb_ctx_complete(struct request_context *ctx) } } -/** +/* * ezusb_req_queue_run: * Description: * Note: Only one active CTX at any one time, because there's no * other (reliable) way to match the response URB to the correct * CTX. - **/ + */ static void ezusb_req_queue_run(struct ezusb_priv *upriv) { unsigned long flags; @@ -704,7 +704,7 @@ static inline u16 build_crc(struct ezusb_packet *data) return crc; } -/** +/* * ezusb_fill_req: * * if data == NULL and length > 0 the data is assumed to be already in From patchwork Wed Aug 26 09:33:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 248400 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:522:0:0:0:0 with SMTP id h2csp4157746ils; Wed, 26 Aug 2020 02:39:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy+FrnAy+R93JvkdoNBjEt61o4FQ65JNQbFshRsGIqDAnSD+Jm9ZccHW7h/RWhV0p1hrXVN X-Received: by 2002:a17:906:eb49:: with SMTP id mc9mr14577167ejb.36.1598434771494; Wed, 26 Aug 2020 02:39:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598434771; cv=none; d=google.com; s=arc-20160816; b=k5uQnHvwBs/sOSSvyD4x6LJuw/+UgyB2x+Btsq4fByHB+pKrs+AOurwoageAhL01HE ds0Y8djDs/S+UVoNpUmvxdyEKunRkPnto3LuaLU+gaktIA+HtRadzTORFL7y1TCTzqjb 6iMeIB8y9LsEiHRynGJIXZ2U8HyAl3KpnB64Zi1aJHuzYLG/FNat5IphuAMkhwFkXh67 ci6cR25FXQsF+eH0Bga/FTv6dh06m6f/n7o3xyuJ8LlDHCxzwCFRbv9aTpVxp4ypN/ap kmo8gXK2u52q7OlApAnVRbAbbnLDuNvU1YpU/Fp5BgDnHBM/eDS/ikivUIAfpSDnWyaO KXNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=EvbW1gaMEShMzK91x3sz003pknPcT/UGnfug8AZOG8Q=; b=UHD8CENMkoZxqL2BJVQ3IaxEoPhpHV/Xd/j9UNXfQm5zLFq1GDD2YVAKgc5Oss4e+F 5dQ10QDEta6ic1udNR1CGlnZ68MXS0pk8R6jIMcgFeFOKrw3Y5ZkZB2T2AT1x4mUu59y b/W5ZWykeDy32oGz7lpy0pU4YGGLpnMs9BLrqRS+JfMrCZ9lAsk5L/LEAQPQK9EcyQic IC1+GM9oT0QD3HY3gOPpqgBzJkFSi1x+hKZ2Kwt6wpYddtGB2SLc7VAtx8j309MpPaTd 34bVqeUlNySEiwq5CcZtQubl+8uM0ubhYLNT8kLFsBpgasATge6qW0Y4mi5EzmHIhqYD eN3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rQ8jCjlD; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a15si1209383edr.160.2020.08.26.02.39.31; Wed, 26 Aug 2020 02:39:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rQ8jCjlD; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728679AbgHZJjQ (ORCPT + 2 others); Wed, 26 Aug 2020 05:39:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728269AbgHZJe2 (ORCPT ); Wed, 26 Aug 2020 05:34:28 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E206C0617BA for ; Wed, 26 Aug 2020 02:34:16 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id c15so1074959wrs.11 for ; Wed, 26 Aug 2020 02:34:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EvbW1gaMEShMzK91x3sz003pknPcT/UGnfug8AZOG8Q=; b=rQ8jCjlDnJ/GRppenxBEfbplj3jYE5RBgm+J6KHql5+Pg/1QEb7cydp3GzxR9z9P9g kaNXpfoEQB5mmgt9LoYH3pR5GB3v+D5WgOQkOlTACzKZODywKeCgN/fCJejCa2YL7C6m EuyPPPWx2lYZCCpmNF7aTOVFzmzAeHKX7QvJ2WI3LXWSq6BsGHtgOeTtuZ5xByM5hJ/c 3topIy18stYrkfvrYRGnFTk2dDQj6dcc5ZZZhodNwJTgMnEMIuH8CRCIc6Xj/Ac5XXKS Lys68RV/tWshmsbCXYV5FsOtleZ8NHJlJSq9L8KNLpD8Y7djV6hT/OzyXmNIfoETueSL ES4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EvbW1gaMEShMzK91x3sz003pknPcT/UGnfug8AZOG8Q=; b=WwF7kUQ8rFte2VC6WIOq+yfpvPj/A48dfwwyeiJrhwnJe0KcVlgRdyxeALKQkVU2Ji SCx+wgQCvADnnkcTYrTO4vkF9DVG3Dt0rKQn6AutKa5im/gZ1Q8qf6mknrSFgmZZYlQ0 2CeOtyjPF3KspM+nBN04rLOINak9hZWzHym+gZLdNuggNnXenlbA+ZtwU2OBEOs+2cTK GNiEU+TGHXP5ygZr3/S6vkSPaPsi1RE5CbVIWH1OcXCRUcY2rSWvhO+m7zyZNxcD4APU llc7+R7TaxzqESfZntFmyGI1W2qPJKBe0BVK+QIgIsw44/A+j8IRIZyPOTDtMC6CHNU5 0e6Q== X-Gm-Message-State: AOAM533n2YloBWd+WMzBZJoT3XXz/gDwrBbk5jSVUarltWTeY7OK8/Lb SpY3v52EKime5BhdBoVYI4sy8Q== X-Received: by 2002:adf:c64d:: with SMTP id u13mr15254648wrg.114.1598434454816; Wed, 26 Aug 2020 02:34:14 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id u3sm3978759wml.44.2020.08.26.02.34.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 02:34:14 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com Subject: [PATCH 08/30] wireless: broadcom: brcmsmac: phy_cmn: Remove a unused variables 'vbat' and 'temp' Date: Wed, 26 Aug 2020 10:33:39 +0100 Message-Id: <20200826093401.1458456-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200826093401.1458456-1-lee.jones@linaro.org> References: <20200826093401.1458456-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): In file included from drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_cmn.c:12: drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_cmn.c: In function ‘wlc_phy_upd_env_txpwr_rate_limits’: drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_cmn.c:1516:11: warning: variable ‘vbat’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_cmn.c:1516:5: warning: variable ‘temp’ set but not used [-Wunused-but-set-variable] Cc: Arend van Spriel Cc: Franky Lin Cc: Hante Meuleman Cc: Chi-Hsien Lin Cc: Wright Feng Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: brcm80211-dev-list.pdl@broadcom.com Cc: brcm80211-dev-list@cypress.com Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- .../net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_cmn.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) -- 2.25.1 diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_cmn.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_cmn.c index 2441714169de1..ccc621b8ed9f2 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_cmn.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_cmn.c @@ -1513,14 +1513,12 @@ static s8 wlc_phy_env_measure_temperature(struct brcms_phy *pi) static void wlc_phy_upd_env_txpwr_rate_limits(struct brcms_phy *pi, u32 band) { u8 i; - s8 temp, vbat; for (i = 0; i < TXP_NUM_RATES; i++) pi->txpwr_env_limit[i] = BRCMS_TXPWR_MAX; - vbat = wlc_phy_env_measure_vbat(pi); - temp = wlc_phy_env_measure_temperature(pi); - + wlc_phy_env_measure_vbat(pi); + wlc_phy_env_measure_temperature(pi); } static s8 From patchwork Wed Aug 26 09:33:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 259480 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0422C433E3 for ; Wed, 26 Aug 2020 09:35:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D08C42087D for ; Wed, 26 Aug 2020 09:35:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PRSz0KIN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728298AbgHZJez (ORCPT ); Wed, 26 Aug 2020 05:34:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728274AbgHZJe3 (ORCPT ); Wed, 26 Aug 2020 05:34:29 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD18EC0617BE for ; Wed, 26 Aug 2020 02:34:17 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id x7so1107196wro.3 for ; Wed, 26 Aug 2020 02:34:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hbQ7t0QGJIX1BQrFfjs1A3AU9N9ket4sk5RytzzLdJE=; b=PRSz0KINW/7dL8S4WUZCQfxd14f4YMJbSkBmMHyG1/sQbxmgJbiocMe/T8daglorDC 82MT3w5DXKs4BUDFZ9bXUh2OUgS2NbldfNZvjCgcUdBicoWPOyzI/BFV/5DDflpTHbRK zLv56uyXsO0Ewpl/da6nT0Q2P9XMWgRjvzZ0TO4soBXqTnfOGdxr2CYpFowLMwj7bInj rwmedvcZrOsJxhEwALwPT+KAXfokSNPEFhCOM6Mpzo+OlkIKxmpu5wGDQ9HIa79SyM6B evqqzzuLy045QKid+uDUpQSB8Z+5R8GVMJnXM3r1J20fJjwx3uros9QGhioEqP0eQmiE eJOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hbQ7t0QGJIX1BQrFfjs1A3AU9N9ket4sk5RytzzLdJE=; b=hcymvwlL2fKY4DbfSs4KJHxAt7nWuoAWTSMcdU+NiOI9rySd/Eqqlc9XUJXUrCg/zA oS5ZRtgTaNRp+kcxGrnsSSbU7Qk60VwUiSuPlYuOCND4eTGFpS2okMY//RlcsT3/hnxQ xydf5uyxwAs8YOELhCGdLjmblqCAY/+969T59ho0NPDiWHad4xOascUhh8UdYBTAygpP wTyCQ6BW61j20tS/qXKIWuVl95Fc0Enz2w5gO61wPR3I2Np5t0AY2UlHuHVcvvA1R3Us G4V2MUfGt+57RSft7A1UVVWJ7vTYEKaL2wQ+LnnZwwGfMvl8QfZVqdMmAPa8MAEWcDTd rcPg== X-Gm-Message-State: AOAM531FpvQ8bUkx2M4HBl2WtyCpZ8GPLcuhswMVl+X4ZOeXVPngkJtm hDUMoOIVSWp4CH1YH4br6Pw6VQ== X-Google-Smtp-Source: ABdhPJyojt+ahgae3vKUeH/4QLEhz8Ub210s3VTJowaHOeDDKiO30miza1Ko42Y4aau/f4Uin3GtRQ== X-Received: by 2002:adf:e781:: with SMTP id n1mr4587780wrm.195.1598434456444; Wed, 26 Aug 2020 02:34:16 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id u3sm3978759wml.44.2020.08.26.02.34.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 02:34:15 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Daniel Drake , Ulrich Kunitz Subject: [PATCH 09/30] wireless: zydas: zd1211rw: zd_chip: Fix formatting Date: Wed, 26 Aug 2020 10:33:40 +0100 Message-Id: <20200826093401.1458456-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200826093401.1458456-1-lee.jones@linaro.org> References: <20200826093401.1458456-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Kerneldoc expects attributes/parameters to be in '@*.: ' format and gets confused if the variable does not follow the type/attribute definitions. Fixes the following W=1 kernel build warning(s): drivers/net/wireless/zydas/zd1211rw/zd_chip.c:1385: warning: Function parameter or member 'rx_frame' not described in 'zd_rx_rate' drivers/net/wireless/zydas/zd1211rw/zd_chip.c:1385: warning: Function parameter or member 'status' not described in 'zd_rx_rate' Cc: Daniel Drake Cc: Ulrich Kunitz Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/zydas/zd1211rw/zd_chip.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/zydas/zd1211rw/zd_chip.c b/drivers/net/wireless/zydas/zd1211rw/zd_chip.c index 0af4b1986e487..0216b1583b48b 100644 --- a/drivers/net/wireless/zydas/zd1211rw/zd_chip.c +++ b/drivers/net/wireless/zydas/zd1211rw/zd_chip.c @@ -1375,8 +1375,8 @@ static inline u8 zd_rate_from_ofdm_plcp_header(const void *rx_frame) /** * zd_rx_rate - report zd-rate - * @rx_frame - received frame - * @rx_status - rx_status as given by the device + * @rx_frame: received frame + * @rx_status: rx_status as given by the device * * This function converts the rate as encoded in the received packet to the * zd-rate, we are using on other places in the driver. From patchwork Wed Aug 26 09:33:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 248396 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:522:0:0:0:0 with SMTP id h2csp4157358ils; Wed, 26 Aug 2020 02:38:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzmou86UUPYeZi3ZRiQVjD6yckAeOjbehphnaMcluU44MzCIVgKRiNK422Yc+vc2+XOdyJT X-Received: by 2002:a05:6402:745:: with SMTP id p5mr14323944edy.94.1598434732909; Wed, 26 Aug 2020 02:38:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598434732; cv=none; d=google.com; s=arc-20160816; b=KbJ78K/nDmEqbB1Cuq1YhcU4+6v2i/gcqPSOxOK8lfOj670km1msop55mcl+XR95Jw eNsO9GU1oYE7aGpq5pB4aVX50Nls6tGMg153D/rOA9O9cXMdOxP0I0pv+imP5NXzQcBZ JxPBjQti0OMpmm93DPSDwEB67s00pxknBbsfkOvvOdpdyGUwtKJDTsP+uIk3FzIZM5/G aUTXLDHY1WjRlGGrZ/DAUGivSD5VZXxDx9NHJthYiN22wBhF/cTIJp+fwTL3dcL2UdBU eDV2cFBZiL4w5vx7sqFHD/93D6u7bVggpbbJHn2LEidrQB0+koAkQn72J6ZNn1SfnKSu NMlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=UCFXUOCpjL2qkM32iJ3lfLLlxWZFDQ/GxhURnAb0nIs=; b=099RjVPpZleOkTuPW8ZZkbNJAdR/8xDTGNKVwea4Idf9gsFyVn1R+pc21E0XD/jiyp 40U+cNI3c7TNeiCfy7Pgo+wojQzzgBSf6gqFWyzmsK1PTcErSOxMT6CXa8ZWhtmHYsjF U8L1NtFhogjAaI7VHxUM3nKuFiFx80UmEy6raDRMD4Yuy/syVtk1MJTXMOAfwlhB2VAj RCJPgjvS71i8zqyc9+lAhRdeXaEtAHUM69RKKhgUHwzLuingOQcf2894qFvMZ35Ghb/x N76nqPv9StY+ZRs02knV7eMLoLwMi8u24wkUq7t36eIm6cLPEFEcM8RIWrVQjheeEevC LEyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=uuXN5vpH; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r10si1059339eds.138.2020.08.26.02.38.52; Wed, 26 Aug 2020 02:38:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=uuXN5vpH; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728307AbgHZJiv (ORCPT + 2 others); Wed, 26 Aug 2020 05:38:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728116AbgHZJeq (ORCPT ); Wed, 26 Aug 2020 05:34:46 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69A5BC061387 for ; Wed, 26 Aug 2020 02:34:20 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id o21so1080699wmc.0 for ; Wed, 26 Aug 2020 02:34:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=UCFXUOCpjL2qkM32iJ3lfLLlxWZFDQ/GxhURnAb0nIs=; b=uuXN5vpHqutLOzjRFB1LQN4QqACjrZnO3CfhEXTW4uUwpqGnIGyj69aDbqsJqUciec sfBjBMD+i20bDh3IFK71nJiZWqu4acSyVq8B9uXpNvZ7s2QuDRUP99eZTilx0r+zMmWm AlIo18wNqtkf2Jv2x7dddDChnzjCAZEJCcBRkPXiPQVCrezWhJKm72iYKgmXpYouki8g NXFoO964YcHGCkUToo1McIx9Yx8mNGuY3iCaFKBNgWonQQ2SHN/RC1Q4cBKEeyEAC4Fe fWn198sSJ2tWARhH24lAubxO3h8RT+rlVh4DCiu9xV2IqguSd1hmH+1IX7CnAJO+JsL7 nA+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=UCFXUOCpjL2qkM32iJ3lfLLlxWZFDQ/GxhURnAb0nIs=; b=USuAUapJeFu/OTBZu5a76wshmvaXGYWTdKwnFfdtk9bljZu4Uwpzap3YMyaW2IZ8GE eidEfDjhJT7u628FtslJ2xECNall3t7PKoJN9qVksxIajL5zIzArlVT6CMYEbheU+cfi JKYyvg9FGs2rmKXewqNeQF9Y/e6+bwhmYDNhTWKnUMXPmMsqMQx6VeSCFS5MG1DHL+SQ ye63zbyZfzerQiWRvr2RmG8EnT++SbFmNXP/a0LOw0+XUaz285ctFsSC8/mCWj0LfoK1 KXs+g/35mYdqDfYn5Gk1hvhoc8FoYp7MTgqU+vRJlAGRudZkq+yy37tVW4l8mjoDF7N3 dnfw== X-Gm-Message-State: AOAM531EWQvNKgxFJTPHd5Fs7Q2VE2BDQ/GBJ1iEW6ZFnP1J0fYSIEoK 8cJjYvW9WZBwXzs/lzqpP8qpvQ== X-Received: by 2002:a1c:b082:: with SMTP id z124mr2255183wme.108.1598434458762; Wed, 26 Aug 2020 02:34:18 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id u3sm3978759wml.44.2020.08.26.02.34.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 02:34:18 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Daniel Drake , Ulrich Kunitz Subject: [PATCH 11/30] wireless: zydas: zd1211rw: zd_chip: Correct misspelled function argument Date: Wed, 26 Aug 2020 10:33:42 +0100 Message-Id: <20200826093401.1458456-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200826093401.1458456-1-lee.jones@linaro.org> References: <20200826093401.1458456-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/zydas/zd1211rw/zd_chip.c:1385: warning: Function parameter or member 'status' not described in 'zd_rx_rate' drivers/net/wireless/zydas/zd1211rw/zd_chip.c:1385: warning: Excess function parameter 'rx_status' description in 'zd_rx_rate' Cc: Daniel Drake Cc: Ulrich Kunitz Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/zydas/zd1211rw/zd_chip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.25.1 diff --git a/drivers/net/wireless/zydas/zd1211rw/zd_chip.c b/drivers/net/wireless/zydas/zd1211rw/zd_chip.c index 0216b1583b48b..3bb51dc8d035f 100644 --- a/drivers/net/wireless/zydas/zd1211rw/zd_chip.c +++ b/drivers/net/wireless/zydas/zd1211rw/zd_chip.c @@ -1376,7 +1376,7 @@ static inline u8 zd_rate_from_ofdm_plcp_header(const void *rx_frame) /** * zd_rx_rate - report zd-rate * @rx_frame: received frame - * @rx_status: rx_status as given by the device + * @status: rx_status as given by the device * * This function converts the rate as encoded in the received packet to the * zd-rate, we are using on other places in the driver. From patchwork Wed Aug 26 09:33:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 259471 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A21C0C433E1 for ; Wed, 26 Aug 2020 09:38:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7B7F62087D for ; Wed, 26 Aug 2020 09:38:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PKNmYYfm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728523AbgHZJir (ORCPT ); Wed, 26 Aug 2020 05:38:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728306AbgHZJeq (ORCPT ); Wed, 26 Aug 2020 05:34:46 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DCA7C061388 for ; Wed, 26 Aug 2020 02:34:21 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id s13so1077313wmh.4 for ; Wed, 26 Aug 2020 02:34:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=h4KvSoafFYDL3t+V7I3USug52YwDVapAvje6j/96TQI=; b=PKNmYYfm7KhX1X3aF0zxsjy6kJJLw8wKggaKS4op9K8gqpo9dM/4rcmvwrH3MDSwix 0oAxkkftzAlBeaNp9Akj/VHuM34NtCusOiLzSTdv/8MNAu0IeXzIpOodLj5E+e3ayJN7 WaiyidZNZVQeAGHn2SQQlxq+8puoEin4AI6rbVerRbL+e93PU86Q1EQDR7cMTmNRv6SS MWGQ7j1RiU1qLICEbZTYdtagogcM8Qdigl0LNk9toA2Lcl8jwwl4SFoh6vPRjl+9PmhJ 1Zb/cTc3MquDK5AF4dUE36QmokwMjuZAWIlfMNa8ztmg5or2QmV1QB1bQeOxwSTbLM4s LOdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=h4KvSoafFYDL3t+V7I3USug52YwDVapAvje6j/96TQI=; b=q7aCXy5cNtLF8vW6AGcWtJGcLWrwIrvej6tzl3L/nuliwSF6D4RhUMRdjiZexJxhsI 1VemxQ2FkBwPNMAeRvGz+BbMGSa7rsce276x9MlVRTmY4Xivrc/JduNLF/yMXK/J0Gib F47AO5G/lGAqfWsYb4FAhydUmf+0kTWviHVYGx0f6LahxBXbRqi/8w2KoUrhTxgfb/pC CLrOrqcp1MxPISYAK2JGz0ijB24UQAwqaFPQsDZnXwQxTVpcDqHByfVghp0s2bRrGWaf ACzkM6n33zCkm9EsgdoeRrHTlpzLVJioIfwNX5tk1764BeIa39I5GBtv+uyVjY1K23jH PJZA== X-Gm-Message-State: AOAM532gxkqLHit9JHMa2NXni55kR+bBM83hQdfpKiZ4Wj6KoYvmdFHm 7sAD8x8FfWmJQks3EoWigHnqNQ== X-Google-Smtp-Source: ABdhPJyv3kF6WpEdqqe3i+tffnTY6lKO6zobwmr/asxTZWONqjhUiPvGfNrZYle6i0TT5oid3TPwng== X-Received: by 2002:a1c:dd85:: with SMTP id u127mr6531092wmg.65.1598434460238; Wed, 26 Aug 2020 02:34:20 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id u3sm3978759wml.44.2020.08.26.02.34.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 02:34:19 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Maya Erez , wil6210@qti.qualcomm.com Subject: [PATCH 12/30] wireless: ath: wil6210: wmi: Correct misnamed function parameter 'ptr_' Date: Wed, 26 Aug 2020 10:33:43 +0100 Message-Id: <20200826093401.1458456-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200826093401.1458456-1-lee.jones@linaro.org> References: <20200826093401.1458456-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/wil6210/wmi.c:279: warning: Function parameter or member 'ptr_' not described in 'wmi_buffer_block' drivers/net/wireless/ath/wil6210/wmi.c:279: warning: Excess function parameter 'ptr' description in 'wmi_buffer_block' Cc: Maya Erez Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: wil6210@qti.qualcomm.com Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/ath/wil6210/wmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/wil6210/wmi.c b/drivers/net/wireless/ath/wil6210/wmi.c index 3a6ee85acf6c7..1439737bbb7b2 100644 --- a/drivers/net/wireless/ath/wil6210/wmi.c +++ b/drivers/net/wireless/ath/wil6210/wmi.c @@ -266,7 +266,7 @@ struct fw_map *wil_find_fw_mapping(const char *section) /** * Check address validity for WMI buffer; remap if needed * @wil: driver data - * @ptr: internal (linker) fw/ucode address + * @ptr_: internal (linker) fw/ucode address * @size: if non zero, validate the block does not * exceed the device memory (bar) * From patchwork Wed Aug 26 09:33:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 259470 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AADC6C433E1 for ; Wed, 26 Aug 2020 09:39:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 88877208E4 for ; Wed, 26 Aug 2020 09:39:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PBwJBdkQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728301AbgHZJip (ORCPT ); Wed, 26 Aug 2020 05:38:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728320AbgHZJeq (ORCPT ); Wed, 26 Aug 2020 05:34:46 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B034EC06138F for ; Wed, 26 Aug 2020 02:34:23 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id t2so1086367wma.0 for ; Wed, 26 Aug 2020 02:34:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qElmRnHsar7tn4JV1a4MOU4ECliWfWuqmHMN13MnixU=; b=PBwJBdkQlk8+/glvNbz0NN9mU9pLT9iRphNJRoCwUkB7TBfg41MLFYDe9JWU4G4eSz iCZgPMD8KHcs2xTrORTWg9H0xYW4xLdiY/VdZDgZ58k8y9+IngWN8V66vafUV9a4j8mv ZMgrcGPYBYdj3/3d1SQ7JqQCHwSZE6fkwTf4ry/wbHo3DGWpzQWmmveF9yLR8HIBxX6E 4txc7BApPS000GyfapvamEZqKo9PpsZ7m1dTFY4Uj144iF4cUUa3nKtjQH39JzVPDoIQ XuwF7EN1CCGOSGA3e6rv9sCVtYV0zOw0RAbFRfsqExehODp8gWDYcuaCSbbz5U1NRWV+ aX5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qElmRnHsar7tn4JV1a4MOU4ECliWfWuqmHMN13MnixU=; b=G9xLyH435PjLBJVE91ehYg9Jmvg8A4OW3HlfX6vP3UZUjG1Y7A6n07pDd7ZxWzroEO xMbUy+G/kewKELL3o2anm6IwJk7kz527aopWOH3LoUbPBns1KuF0BAwZ60HXYWQTSYOd k0LVV6SaxpXLyICRpvTDxIfCyhMFlu8ehx+rD4d4m8AqPvv39jpq5cBQ+djfYsUj8sMJ 7Oed+MzInh8gN1qZL9ZoayQkXxgSBfnNwKTa11rcgavXbhX2+4+1/MRQcJ0p0UKsR9vw 9j8ygbHQLHjvrap6fNXuWD01DG5dIZ/XWXaMP2BcsWhz4FSBXtS0ywQ3P8VGMs+tABmm wdZQ== X-Gm-Message-State: AOAM530rjbN8xNK0P81b3QkUMtJ3IikfaRVJl5HTRyespjOE8A4jadtq N5qeKgygnNWj0rBHEz0HgVjzOQ== X-Google-Smtp-Source: ABdhPJx3h8A3mjpNHgeZ/6rKPE6GI6Xtear6POyYyOrLQKipA1gOfGiBA+GtMpx2b9EQwV0Whzi1Mg== X-Received: by 2002:a1c:96c5:: with SMTP id y188mr6392874wmd.72.1598434462418; Wed, 26 Aug 2020 02:34:22 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id u3sm3978759wml.44.2020.08.26.02.34.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 02:34:21 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones Subject: [PATCH 14/30] wireless: ath: ath6kl: wmi: Remove unused variable 'rate' Date: Wed, 26 Aug 2020 10:33:45 +0100 Message-Id: <20200826093401.1458456-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200826093401.1458456-1-lee.jones@linaro.org> References: <20200826093401.1458456-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/ath6kl/wmi.c: In function ‘ath6kl_wmi_bitrate_reply_rx’: drivers/net/wireless/ath/ath6kl/wmi.c:1204:6: warning: variable ‘rate’ set but not used [-Wunused-but-set-variable] Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/ath/ath6kl/wmi.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/net/wireless/ath/ath6kl/wmi.c b/drivers/net/wireless/ath/ath6kl/wmi.c index 6885d2ded53a8..a4339cca661f0 100644 --- a/drivers/net/wireless/ath/ath6kl/wmi.c +++ b/drivers/net/wireless/ath/ath6kl/wmi.c @@ -1201,8 +1201,7 @@ static int ath6kl_wmi_pstream_timeout_event_rx(struct wmi *wmi, u8 *datap, static int ath6kl_wmi_bitrate_reply_rx(struct wmi *wmi, u8 *datap, int len) { struct wmi_bit_rate_reply *reply; - s32 rate; - u32 sgi, index; + u32 index; if (len < sizeof(struct wmi_bit_rate_reply)) return -EINVAL; @@ -1211,15 +1210,10 @@ static int ath6kl_wmi_bitrate_reply_rx(struct wmi *wmi, u8 *datap, int len) ath6kl_dbg(ATH6KL_DBG_WMI, "rateindex %d\n", reply->rate_index); - if (reply->rate_index == (s8) RATE_AUTO) { - rate = RATE_AUTO; - } else { + if (reply->rate_index != (s8) RATE_AUTO) { index = reply->rate_index & 0x7f; if (WARN_ON_ONCE(index > (RATE_MCS_7_40 + 1))) return -EINVAL; - - sgi = (reply->rate_index & 0x80) ? 1 : 0; - rate = wmi_rate_tbl[index][sgi]; } ath6kl_wakeup_event(wmi->parent_dev); From patchwork Wed Aug 26 09:33:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 259472 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A39FC433DF for ; Wed, 26 Aug 2020 09:38:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 360DA208E4 for ; Wed, 26 Aug 2020 09:38:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="uUJKLbTU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728352AbgHZJi2 (ORCPT ); Wed, 26 Aug 2020 05:38:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728335AbgHZJer (ORCPT ); Wed, 26 Aug 2020 05:34:47 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9570C061796 for ; Wed, 26 Aug 2020 02:34:24 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id h15so1081010wrt.12 for ; Wed, 26 Aug 2020 02:34:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Bx7yNWclgWagoUc19DO980I/LQpudxltdUcBDgMx82s=; b=uUJKLbTU9CLl0GGHDJpGfj9qHXqTE3vmdSY72df5VY22nwMKPTB/gJEbRC16KsVj7V lqf/Msco72OZwC3/z43E9HJuCf6O4FXc4Ln2h+/SPuM85Apb34/d9LJm1+eeVSKbALFc c2rVrF2Sh84an294dpobLgvr2n7+wlJehzkTlL83PcF2HIXgrzahwnvouyL2GQg8BVCy YzEczRcmVW4jKWDL4pBiFlrSkNOCzvJm1JnA04lj/UemOevD3v2UMxrTXE53HxYDN0d2 mIfNdwOUuKYx7/GFEVMKTyGbyVQd+W2euTeJ/u8fddVeUrdSAHX+9rPgTn/5CayY333+ iGVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Bx7yNWclgWagoUc19DO980I/LQpudxltdUcBDgMx82s=; b=dATsFJFG57/Vwh0uWRkRds3TCFusMHiWv/Gjnc09rx5NSSrHi3jfVm7IADN+tO1bww xNRYhk6lrUZJPgDUuxMlz5czL3yujc9IOEgX3HnXZGqsf2LOLEQNCpj16RhE1/QcgQVA CW2jOkZScDbFIX6dXpZfoOT2KMquIA7h970v1bskefgh8j59/kjQBFagNoIgZTX8Mdra hWaAB73FCJs6OXfZVMWY+o6wC6pYVBByN4hmxqPoAwuboHkxg+iVXpEfyj+vCBMfYWNf ASsZ2s1unTV89MSbneDOXYoBVQLf8Ti8pZqKh1+DpXdLBgdCJt7fI4KYzQ25s3h7D31H HbuA== X-Gm-Message-State: AOAM531DQunf3z5F0suEuT+cE3Kc0Dzwj/R00m4gbNeZQU3wkqogjSAP SyOIqtxS7XcJKU71mT5bAW0jkA== X-Google-Smtp-Source: ABdhPJwQFvrvdmFHV9OPBjwjVStS/qGSXw/JVNaDpgJRCYX+jtI39dQIrk6xIFkbAjhbnJEZSJLl9g== X-Received: by 2002:a5d:4050:: with SMTP id w16mr1517291wrp.412.1598434463554; Wed, 26 Aug 2020 02:34:23 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id u3sm3978759wml.44.2020.08.26.02.34.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 02:34:22 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Luciano Coelho Subject: [PATCH 15/30] wireless: ti: wlcore: debugfs: Remove unused variable 'res' Date: Wed, 26 Aug 2020 10:33:46 +0100 Message-Id: <20200826093401.1458456-16-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200826093401.1458456-1-lee.jones@linaro.org> References: <20200826093401.1458456-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Luciano Coelho Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/ti/wlcore/debugfs.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/ti/wlcore/debugfs.h b/drivers/net/wireless/ti/wlcore/debugfs.h index fc3bb0d2ab8da..b143293e694f9 100644 --- a/drivers/net/wireless/ti/wlcore/debugfs.h +++ b/drivers/net/wireless/ti/wlcore/debugfs.h @@ -78,13 +78,13 @@ static ssize_t sub## _ ##name## _read(struct file *file, \ struct wl1271 *wl = file->private_data; \ struct struct_type *stats = wl->stats.fw_stats; \ char buf[DEBUGFS_FORMAT_BUFFER_SIZE] = ""; \ - int res, i; \ + int i; \ \ wl1271_debugfs_update_stats(wl); \ \ for (i = 0; i < len; i++) \ - res = snprintf(buf, sizeof(buf), "%s[%d] = %d\n", \ - buf, i, stats->sub.name[i]); \ + snprintf(buf, sizeof(buf), "%s[%d] = %d\n", \ + buf, i, stats->sub.name[i]); \ \ return wl1271_format_buffer(userbuf, count, ppos, "%s", buf); \ } \ From patchwork Wed Aug 26 09:33:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 248378 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:522:0:0:0:0 with SMTP id h2csp4155494ils; Wed, 26 Aug 2020 02:35:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzkT1WlAAsH4KW2jztF1O5PtiuQmUliDqFANo7VoNH2yNSZ8Ox8/OpM22aPxo+kVFA8Gv4i X-Received: by 2002:a50:e8c9:: with SMTP id l9mr12027818edn.239.1598434519439; Wed, 26 Aug 2020 02:35:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598434519; cv=none; d=google.com; s=arc-20160816; b=SISXHwGh1OtSfOefuivDyIMStEwTe5s0R1ja989lkeVXelfQBA798Xzdsr9N1gbvYL t8alD29mb974UDd6+tVcOJ04tXWklbkU5J/5+AVEqBksxLgiSXVzsnBxxR8bqh9R60q0 7aabq8qkZBG7Qevi38/Nv/bmrals3+jSqjcmndUV0ifIT2gZow5xDeq18enCS4mn+4qz GVJGVtUTFkhWMsCKXmAdIzSddufGaQTkanSh/8FzErkMN8bm16+U8g9+TperOkU8DX/+ bVABbLL4StNNMuR1xhOnsYCYSilaEj70KVgelkCTI0ThCAd+vnQHyZXwUZAjkxTd7sXJ Ne1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=1sh6GJ0mJWJb3ICmo91l9UDo6bvtBy9zVj1QpKnJ7Ig=; b=PLxeZyTzlXZbV2Jsl5UfKM+yyW2FuMFjFY0NS5UzfQlysGp2X9YAkM/JLJZNmRDI/p P1qlDTmDZRtp6KpRX1WO8+lZbmF/B2L+1QQsB2Oz9CUpuVp3v9IheynorsAdgLHqHZ/Y RSdYNh+foTaFOGdMGS46eDonUAlzxL5w1ijDRsoBo6IeqcGPCpq3fUK/x1PfCufjgLhG YIMscp/a5rtYQBj0TpxZIrHxMQjLxrWK9MoGoZ616QvP5CT9tPCRRqOdnGWWO3YbpWc7 A3EdkmxhvnLreek65aY/b4/lhKeJPsmm0VXuAWm5Y7lBWf/BFlEFH1OoSyapSmnikXpK 5tqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=E7S6Pkng; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d13si1209847eja.203.2020.08.26.02.35.19; Wed, 26 Aug 2020 02:35:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=E7S6Pkng; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728394AbgHZJfN (ORCPT + 2 others); Wed, 26 Aug 2020 05:35:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728022AbgHZJey (ORCPT ); Wed, 26 Aug 2020 05:34:54 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43C99C061343 for ; Wed, 26 Aug 2020 02:34:27 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id b79so483211wmb.4 for ; Wed, 26 Aug 2020 02:34:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1sh6GJ0mJWJb3ICmo91l9UDo6bvtBy9zVj1QpKnJ7Ig=; b=E7S6Pkng7Y0zFItSSiJ6u4PAD6CRFndCXBLJmIKAADhgYzB7tAwnaOstq39x7K8YiA aYOiEa6IQ9pL2hp7r4/h6gkkN38ntfPXaVOzMazdJu+zmREhsaSzSyEHFJRalsGXtdGq RH0GewQfte2wlRM98ENsZ362ARQtgwlM1+Sverg5BwZw6BS9GhUr+h+OwQTC+WD+R5LD xP6mO7vA/v8yQcC0oB3mckaIE4cr9uwDkWUMvsQSMjSzBT8BmE3dJhUPo5k9PsJ3dL4n 7i40Rog29DFzVrx7zYzM4LzRshP1DRoEa6cMkG1OOmgevWJPDDV//yehqKjWH3ay8Sb8 WoAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1sh6GJ0mJWJb3ICmo91l9UDo6bvtBy9zVj1QpKnJ7Ig=; b=f+bqXvfTytCb4K7+SAcdzBbMtQvUo44I+Drgqh8J9jSjNrXjV/QVMQ+cKWn65U83Et Ro0nWsnmvuDJdl5x1Lb3yDbgGT+t/uUuJr5qyd2RKfdRhHu2Pv3FdxgQIUYLe5pkdA7w dvMPfLd3eqlU4LZkfmcZ2pk43QAeAge/iGvdVqv2GT5JTRujXvUIUZn/9synvlq7bZpc leeVf4TOXdNlwU5n0pO6SRI7/v3f+zy28cwrAR0Tv64v+UDBVVERDFK2xcQqhB/Dr9PX /HZzDq1xufUtQvjD2bdyunon3anFbLrnWsbCdtIVKwFGDM1X6bHisItSiiHyTb2cHv+1 vscg== X-Gm-Message-State: AOAM533sunm8rQYIQIMByM6QjBZ1/zV2vu137Muk3xAs+VAOhpKqYiVP ITn36fB1ks9s6CP5PXyCmjwHMw== X-Received: by 2002:a1c:ed15:: with SMTP id l21mr6221723wmh.56.1598434465884; Wed, 26 Aug 2020 02:34:25 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id u3sm3978759wml.44.2020.08.26.02.34.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 02:34:25 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , QCA ath9k Development Subject: [PATCH 17/30] wireless: ath: ath9k: ar9002_initvals: Remove unused array 'ar9280PciePhy_clkreq_off_L1_9280' Date: Wed, 26 Aug 2020 10:33:48 +0100 Message-Id: <20200826093401.1458456-18-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200826093401.1458456-1-lee.jones@linaro.org> References: <20200826093401.1458456-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/ath9k/ar9002_initvals.h:900:18: warning: ‘ar9280PciePhy_clkreq_off_L1_9280’ defined but not used [-Wunused-const-variable=] Cc: QCA ath9k Development Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/ath/ath9k/ar9002_initvals.h | 14 -------------- 1 file changed, 14 deletions(-) -- 2.25.1 diff --git a/drivers/net/wireless/ath/ath9k/ar9002_initvals.h b/drivers/net/wireless/ath/ath9k/ar9002_initvals.h index 4d18c66a67903..e01b5c3728b86 100644 --- a/drivers/net/wireless/ath/ath9k/ar9002_initvals.h +++ b/drivers/net/wireless/ath/ath9k/ar9002_initvals.h @@ -897,20 +897,6 @@ static const u32 ar9280Modes_original_tx_gain_9280_2[][5] = { {0x00007844, 0x92592480, 0x92592480, 0x92592480, 0x92592480}, }; -static const u32 ar9280PciePhy_clkreq_off_L1_9280[][2] = { - /* Addr allmodes */ - {0x00004040, 0x9248fd00}, - {0x00004040, 0x24924924}, - {0x00004040, 0xa8000019}, - {0x00004040, 0x13160820}, - {0x00004040, 0xe5980560}, - {0x00004040, 0xc01dcffc}, - {0x00004040, 0x1aaabe41}, - {0x00004040, 0xbe105554}, - {0x00004040, 0x00043007}, - {0x00004044, 0x00000000}, -}; - static const u32 ar9280PciePhy_clkreq_always_on_L1_9280[][2] = { /* Addr allmodes */ {0x00004040, 0x9248fd00}, From patchwork Wed Aug 26 09:33:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 259473 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3F2BC433E1 for ; Wed, 26 Aug 2020 09:38:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8CC51208E4 for ; Wed, 26 Aug 2020 09:38:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NtAv25hj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728405AbgHZJhx (ORCPT ); Wed, 26 Aug 2020 05:37:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728370AbgHZJfD (ORCPT ); Wed, 26 Aug 2020 05:35:03 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BBC4FC061346 for ; Wed, 26 Aug 2020 02:34:29 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id o4so1107299wrn.0 for ; Wed, 26 Aug 2020 02:34:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5xYAPYXZqKI3g1GFZmnrzEgVa6jjBFa/aMcqWmXa5Dc=; b=NtAv25hji32BSctbHNSG6hvgojalWPH/q2SbQ6HmZPxPxofhzszwXZbiKeVhObOPRu 9FGE5aT64rD+pIVxs5baems82rqFmheemeohT5g0YqsAUxq4VzJ0QDqpHV8+7kaKCHfM 7g09v5S3ArlX5RSV2C7h+c9p5TXpyTkOVveKkl1BdsSYSftFphmajGgdnfWZUd6TWOn3 V95i0Yav3ECduA2ieGEHHnkRoEckdthoggrF0Hc7vGnmtdWsoz+pbgAWGuTbW+bfOdVJ k03tb/D35hhKdjGQUZLufVJhsvkPrSb9ks8YB8kPodnKxjU/Z0KyjAhF59cMnf/yDq1w bW6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5xYAPYXZqKI3g1GFZmnrzEgVa6jjBFa/aMcqWmXa5Dc=; b=BzbgNHqp5PCxHggw26bwdXkDHUfKxQlZDVIWxU99zP8DF7gMuUo9KhO6FObqw0YqMI jfQHz8MgsRCkij4PgZf10e4cb11VeMSU1NnlBP1zXC50YVExV+u2ScNN3WO3Wr++plsk EX4GlKJmGCv2wTB91+K2xNY+tNqCz25U2kelA43lF2poq2oXC2LqfcVnaYOrOdAtbaBP PzOpr/oL/B5GKkFAV2gQQbDGI3Wo+w8A+3G4c/SRk5P1Ik8Xhc6E53Eh/nlzXPObIFQ8 AGFNozGCd8nQ6i0WJMc4slMD6INoGBUoBuzBcOJwZ6b3NeuE/HUJc9pP2XEJ4e0uwD0j GvkA== X-Gm-Message-State: AOAM533rgFHcCKc2VF8grblhS8DyiAQG+6l4IeWozCWGhl3u3Qm8gXOW W3QXu1InMvpGXiFfigj7pWA0GA== X-Google-Smtp-Source: ABdhPJwlHgHvN4aaFIAjEP8d/rVGWNg4vJOAzlVz1zWIu7YkcH9UYqB9S9fIOyuB6XE6PgXJ4tP9XA== X-Received: by 2002:adf:f388:: with SMTP id m8mr15137432wro.338.1598434468397; Wed, 26 Aug 2020 02:34:28 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id u3sm3978759wml.44.2020.08.26.02.34.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 02:34:27 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Jouni Malinen , Cong Wang , Taehee Yoo Subject: [PATCH 19/30] wireless: intersil: hostap: hostap_hw: Remove unused variable 'fc' Date: Wed, 26 Aug 2020 10:33:50 +0100 Message-Id: <20200826093401.1458456-20-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200826093401.1458456-1-lee.jones@linaro.org> References: <20200826093401.1458456-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): In file included from drivers/net/wireless/intersil/hostap/hostap_cs.c:196: drivers/net/wireless/intersil/hostap/hostap_hw.c: In function ‘prism2_tx_80211’: drivers/net/wireless/intersil/hostap/hostap_hw.c:1806:18: warning: variable ‘fc’ set but not used [-Wunused-but-set-variable] 1806 | u16 tx_control, fc; | ^~ In file included from drivers/net/wireless/intersil/hostap/hostap_plx.c:264: drivers/net/wireless/intersil/hostap/hostap_hw.c: In function ‘prism2_tx_80211’: drivers/net/wireless/intersil/hostap/hostap_hw.c:1806:18: warning: variable ‘fc’ set but not used [-Wunused-but-set-variable] 1806 | u16 tx_control, fc; | ^~ In file included from drivers/net/wireless/intersil/hostap/hostap_pci.c:221: drivers/net/wireless/intersil/hostap/hostap_hw.c: In function ‘prism2_tx_80211’: drivers/net/wireless/intersil/hostap/hostap_hw.c:1806:18: warning: variable ‘fc’ set but not used [-Wunused-but-set-variable] 1806 | u16 tx_control, fc; | ^~ Cc: Jouni Malinen Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Cong Wang Cc: Taehee Yoo Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/intersil/hostap/hostap_hw.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/wireless/intersil/hostap/hostap_hw.c b/drivers/net/wireless/intersil/hostap/hostap_hw.c index b6c497ce12e12..a8aa8f64abe0c 100644 --- a/drivers/net/wireless/intersil/hostap/hostap_hw.c +++ b/drivers/net/wireless/intersil/hostap/hostap_hw.c @@ -1803,7 +1803,7 @@ static int prism2_tx_80211(struct sk_buff *skb, struct net_device *dev) struct hfa384x_tx_frame txdesc; struct hostap_skb_tx_data *meta; int hdr_len, data_len, idx, res, ret = -1; - u16 tx_control, fc; + u16 tx_control; iface = netdev_priv(dev); local = iface->local; @@ -1826,7 +1826,6 @@ static int prism2_tx_80211(struct sk_buff *skb, struct net_device *dev) /* skb->data starts with txdesc->frame_control */ hdr_len = 24; skb_copy_from_linear_data(skb, &txdesc.frame_control, hdr_len); - fc = le16_to_cpu(txdesc.frame_control); if (ieee80211_is_data(txdesc.frame_control) && ieee80211_has_a4(txdesc.frame_control) && skb->len >= 30) { From patchwork Wed Aug 26 09:33:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 259474 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B12A1C433E1 for ; Wed, 26 Aug 2020 09:37:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8A0F520897 for ; Wed, 26 Aug 2020 09:37:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="FNLJxtoV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728577AbgHZJhf (ORCPT ); Wed, 26 Aug 2020 05:37:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728374AbgHZJfE (ORCPT ); Wed, 26 Aug 2020 05:35:04 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA6C9C061349 for ; Wed, 26 Aug 2020 02:34:30 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id a5so1093599wrm.6 for ; Wed, 26 Aug 2020 02:34:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xyQoG+wQHbbYlAwDR9Bn2T0hbUw5R72XJoccL9iEkJo=; b=FNLJxtoVrKxlB4vCGPDuiCbB7S8XUvS4J1q45/v6Sr8NhRJ4fqNYXpCC4jETbEERE9 FxJosK13MYeGiugDoo1nLglq3De76KFu635G5p6i4E2KZqLOxscfPcB1eCOW5gMx4FUY qlTX4l31OguD2Dp9d561huIcQI/T+v2mpk6+DOzk2sLo/VOamMqvm+BcEPHf+Ay1xNjJ O1o/W8gkYG9ObrHJe7y2KcQYwOfZDjcDdw1iZV5wVAghQFzizdtHurIlWrk0QoP5gfnQ SxvGVQHSR/AxztB/6C/sZF3+AkIlQO/1Unajvzj3Jv/RqaVVk1yctcZiUqbI0ESq6mh3 BtaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xyQoG+wQHbbYlAwDR9Bn2T0hbUw5R72XJoccL9iEkJo=; b=U+goSmamz2Lu4L7IP+fFfSHYp5H0tmSu4bOifI7cwrTi7kfPGed/1JJN6QebtLf0Cv mgIJgbS7i9Qw56Gm3lECqTGkhf4l4vvsZKIwueYsk031iftOmiyyGaXATm+8eNnhfK/E jOBXfXU9RQabXWfv0KQJTjKEMcQrg7BR5FQDMp0IWwa9mF9l7t4d7mDqJMOr7qcqJNKd KV6rF68TnsOA4SgRVwNfwOl+zeUs2dyt1UCsR3RE5mNdKSjftKbeeBywVlvC7Cnl+xG9 KoEH0emBlua8ZXGcY3t2jr3n3BPOdZD2ESLGD+QYWF6D+oWlGKD8Zw4PZ4LGTGtCRdOC Iltg== X-Gm-Message-State: AOAM530qhghqlFDnTcU3CHOXpmktve6BNH22z0XTC0lJj4Y/vLVU9Ecv rNv3FcI157rCmcWWQu4rDIg2cA== X-Google-Smtp-Source: ABdhPJy50afRgESSXY0c75KtMkQTRCXM/0frNsxBhu29VRIOqcBUU+nGL06ugSrYWVuhv3Ig6hV5Mw== X-Received: by 2002:a5d:63c2:: with SMTP id c2mr14485590wrw.346.1598434469550; Wed, 26 Aug 2020 02:34:29 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id u3sm3978759wml.44.2020.08.26.02.34.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 02:34:29 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Fox Chen , de Melo , Gustavo Niemeyer Subject: [PATCH 20/30] wireless: wl3501_cs: Fix a bunch of formatting issues related to function docs Date: Wed, 26 Aug 2020 10:33:51 +0100 Message-Id: <20200826093401.1458456-21-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200826093401.1458456-1-lee.jones@linaro.org> References: <20200826093401.1458456-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): In file included from drivers/net/wireless/wl3501_cs.c:57: drivers/net/wireless/wl3501_cs.c:143: warning: Function parameter or member 'reg_domain' not described in 'iw_valid_channel' drivers/net/wireless/wl3501_cs.c:143: warning: Function parameter or member 'channel' not described in 'iw_valid_channel' drivers/net/wireless/wl3501_cs.c:162: warning: Function parameter or member 'reg_domain' not described in 'iw_default_channel' drivers/net/wireless/wl3501_cs.c:248: warning: Function parameter or member 'this' not described in 'wl3501_set_to_wla' drivers/net/wireless/wl3501_cs.c:270: warning: Function parameter or member 'this' not described in 'wl3501_get_from_wla' drivers/net/wireless/wl3501_cs.c:467: warning: Function parameter or member 'this' not described in 'wl3501_send_pkt' drivers/net/wireless/wl3501_cs.c:467: warning: Function parameter or member 'data' not described in 'wl3501_send_pkt' drivers/net/wireless/wl3501_cs.c:467: warning: Function parameter or member 'len' not described in 'wl3501_send_pkt' drivers/net/wireless/wl3501_cs.c:729: warning: Function parameter or member 'this' not described in 'wl3501_block_interrupt' drivers/net/wireless/wl3501_cs.c:746: warning: Function parameter or member 'this' not described in 'wl3501_unblock_interrupt' drivers/net/wireless/wl3501_cs.c:1124: warning: Function parameter or member 'irq' not described in 'wl3501_interrupt' drivers/net/wireless/wl3501_cs.c:1124: warning: Function parameter or member 'dev_id' not described in 'wl3501_interrupt' drivers/net/wireless/wl3501_cs.c:1257: warning: Function parameter or member 'dev' not described in 'wl3501_reset' drivers/net/wireless/wl3501_cs.c:1420: warning: Function parameter or member 'link' not described in 'wl3501_detach' Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Fox Chen Cc: de Melo Cc: Gustavo Niemeyer Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/wl3501_cs.c | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/drivers/net/wireless/wl3501_cs.c b/drivers/net/wireless/wl3501_cs.c index 686161db8706c..4e7a2140649b4 100644 --- a/drivers/net/wireless/wl3501_cs.c +++ b/drivers/net/wireless/wl3501_cs.c @@ -134,8 +134,8 @@ static const struct { /** * iw_valid_channel - validate channel in regulatory domain - * @reg_comain - regulatory domain - * @channel - channel to validate + * @reg_comain: regulatory domain + * @channel: channel to validate * * Returns 0 if invalid in the specified regulatory domain, non-zero if valid. */ @@ -154,7 +154,7 @@ static int iw_valid_channel(int reg_domain, int channel) /** * iw_default_channel - get default channel for a regulatory domain - * @reg_comain - regulatory domain + * @reg_domain: regulatory domain * * Returns the default channel for a regulatory domain */ @@ -237,6 +237,7 @@ static int wl3501_get_flash_mac_addr(struct wl3501_card *this) /** * wl3501_set_to_wla - Move 'size' bytes from PC to card + * @this: Card * @dest: Card addressing space * @src: PC addressing space * @size: Bytes to move @@ -259,6 +260,7 @@ static void wl3501_set_to_wla(struct wl3501_card *this, u16 dest, void *src, /** * wl3501_get_from_wla - Move 'size' bytes from card to PC + * @this: Card * @src: Card addressing space * @dest: PC addressing space * @size: Bytes to move @@ -455,7 +457,7 @@ static int wl3501_pwr_mgmt(struct wl3501_card *this, int suspend) /** * wl3501_send_pkt - Send a packet. - * @this - card + * @this: Card * * Send a packet. * @@ -720,7 +722,7 @@ static void wl3501_mgmt_scan_confirm(struct wl3501_card *this, u16 addr) /** * wl3501_block_interrupt - Mask interrupt from SUTRO - * @this - card + * @this: Card * * Mask interrupt from SUTRO. (i.e. SUTRO cannot interrupt the HOST) * Return: 1 if interrupt is originally enabled @@ -737,7 +739,7 @@ static int wl3501_block_interrupt(struct wl3501_card *this) /** * wl3501_unblock_interrupt - Enable interrupt from SUTRO - * @this - card + * @this: Card * * Enable interrupt from SUTRO. (i.e. SUTRO can interrupt the HOST) * Return: 1 if interrupt is originally enabled @@ -1110,8 +1112,8 @@ static inline void wl3501_ack_interrupt(struct wl3501_card *this) /** * wl3501_interrupt - Hardware interrupt from card. - * @irq - Interrupt number - * @dev_id - net_device + * @irq: Interrupt number + * @dev_id: net_device * * We must acknowledge the interrupt as soon as possible, and block the * interrupt from the same card immediately to prevent re-entry. @@ -1247,7 +1249,7 @@ static int wl3501_close(struct net_device *dev) /** * wl3501_reset - Reset the SUTRO. - * @dev - network device + * @dev: network device * * It is almost the same as wl3501_open(). In fact, we may just wl3501_close() * and wl3501_open() again, but I wouldn't like to free_irq() when the driver @@ -1410,7 +1412,7 @@ static struct iw_statistics *wl3501_get_wireless_stats(struct net_device *dev) /** * wl3501_detach - deletes a driver "instance" - * @link - FILL_IN + * @link: FILL_IN * * This deletes a driver "instance". The device is de-registered with Card * Services. If it has been released, all local data structures are freed. From patchwork Wed Aug 26 09:33:52 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 248389 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:522:0:0:0:0 with SMTP id h2csp4156584ils; Wed, 26 Aug 2020 02:37:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxb1u8MbfY4p9EyAyT3kIwox976ztYb5cxQcr3xpeTirFnSnkHN0guYsbxaiLlWd3QfHDcQ X-Received: by 2002:a05:6402:306f:: with SMTP id bs15mr13826199edb.249.1598434649835; Wed, 26 Aug 2020 02:37:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598434649; cv=none; d=google.com; s=arc-20160816; b=XeIrKr/uri3QD9ThXkVm30pJlp9iGLIEiK16vVSHVNLhB4w5bKEEKZb9qOl0AuDttH F2f3IMvLJZliHDhyxqy1sK/ED3fdHLcUhhFltFIv48wfAFtXnuvJv58OGdTeOb1kStyV +SQ+FBfnba2t9SEUosc2zrqGYkbXPkUKAguPgiryLnU7iRC1gp1eYyMZ8GuEjK5t24UR qiYBHRC5azDm/sUmGKPjLRPnL4VE9VtvWjQ/TgszvSzhoMaQHMeUgdchzXJFl2x3VNHb 33cwg6N0/tgFAikrRKOQmgVGs4o+URI+YBVTx6gNm8yV19cBhkEPBsOOIGvi3Ag6ECa+ SaEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Y9vzHS6aHZF+kDxD6ikVzao6jVEkcdJnGSqUufDJu9w=; b=FPpxHE+tRc2niaUvDut4nui6VVqr3itWNCfzAUOMF4o8eXPtm0GVvnzcz+GKz3w03b dO2XWbJ33Fza+2jotDnVbIrjxVUumZ1UJchSR/MYL/gGRqKRtpCrpxDSLfST4Mv5wPf8 ZphkBuHYfEeW1WrotSf1BqzOtZ70KUUYIBGJSKqjBjIOTidukpQaRpGw0vP4iojEnqsg kZ+oueKcN/oSYHeuyHk35z+2SiwdPNNXkD1Lw/hMW3SWq7TCgwTttEgLjaqsyfjFXz4H CD4xaTfxnVuNcpY4JIMonicF2Fv+ZimzoXq9gtQwVoMDbUTSeF1w8X4IdFU7hVe3NMSz 9CVg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=YC0J7kOL; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n15si1123616edy.588.2020.08.26.02.37.29; Wed, 26 Aug 2020 02:37:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=YC0J7kOL; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728254AbgHZJh2 (ORCPT + 2 others); Wed, 26 Aug 2020 05:37:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728376AbgHZJfG (ORCPT ); Wed, 26 Aug 2020 05:35:06 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 145FEC06134B for ; Wed, 26 Aug 2020 02:34:32 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id p17so1090165wrj.8 for ; Wed, 26 Aug 2020 02:34:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Y9vzHS6aHZF+kDxD6ikVzao6jVEkcdJnGSqUufDJu9w=; b=YC0J7kOL2kJwoCB6PgkNpW5h3dq6NVC2Xkws2NJEAH5xD2iKNQobz7x/NieN3UBwaM cSn2z7m4Smw7oi2IWzzyP/ohnJE3YCZOtULAeRrePXs6M5iC/emGeaaGP+9bxGeazca/ XME3AmOZg1kmyCCBeoP7SBIgjOvM0Twrt2+nKfkF8nC8UbaFCTW8QbDAMZ9U2wHWbUmr LoKbo+u8L1/REpsf1gxSh/Z8XFx0y1MbeHZJe5QM7dyEyyg+CcQ/0Jdnv6ScroburOgu +rAMk8tWQ4Lg9SaajGHqbhpP3cjBL7rEyrGnlPYUwPigpw7QeM8kH5AHWTP5FCw7t5Ct fSYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Y9vzHS6aHZF+kDxD6ikVzao6jVEkcdJnGSqUufDJu9w=; b=gYehrBFxYnmVwHqPAOZLeyuSXIAPCJNkwZCopTug0/dcW++c/KUejCiCMrun+kS6Uz zzovgRzVSPLvgO0IFlQ5R3KvNT4X6EgspVLhfvtUt63hBuqRZ518pAvxKNM4xweQXJWQ 2enFaLi3ba3xfj38eyPR4cS+i+ut8/rLFRQ2R+DqSCO3ISOCgUATnTiII9Xg25H/Xk0z sFH7cK1fQxBfVgjJdp62IzQbTalVucbCQ8QyA1tog83gN82y3DB6rekQ16OUpFsfaVJ5 vJM37CkE8tVdFgeJYj2VeWaIIEEiYnP2NnRNVkM7o7YXeJvOv0OKL4e/9zMRdO2qJLqf sY4w== X-Gm-Message-State: AOAM530sN8f+38HwurJNPn5MozXjJWi1/ud6hNvvEfGlFGA4XSS9ELbf 6+jOKZS0OZ3Qx4CuqDiHup0E3Q== X-Received: by 2002:a5d:56c6:: with SMTP id m6mr6343048wrw.204.1598434470695; Wed, 26 Aug 2020 02:34:30 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id u3sm3978759wml.44.2020.08.26.02.34.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 02:34:30 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Yan-Hsuan Chuang Subject: [PATCH 21/30] wireless: realtek: rtw88: debug: Remove unused variables 'val' Date: Wed, 26 Aug 2020 10:33:52 +0100 Message-Id: <20200826093401.1458456-22-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200826093401.1458456-1-lee.jones@linaro.org> References: <20200826093401.1458456-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/realtek/rtw88/debug.c: In function ‘rtw_debug_get_mac_page’: drivers/net/wireless/realtek/rtw88/debug.c:430:6: warning: variable ‘val’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/realtek/rtw88/debug.c: In function ‘rtw_debug_get_bb_page’: drivers/net/wireless/realtek/rtw88/debug.c:450:6: warning: variable ‘val’ set but not used [-Wunused-but-set-variable] Cc: Yan-Hsuan Chuang Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/realtek/rtw88/debug.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) -- 2.25.1 diff --git a/drivers/net/wireless/realtek/rtw88/debug.c b/drivers/net/wireless/realtek/rtw88/debug.c index f769c982cc91e..985cf5d606159 100644 --- a/drivers/net/wireless/realtek/rtw88/debug.c +++ b/drivers/net/wireless/realtek/rtw88/debug.c @@ -427,12 +427,11 @@ static int rtw_debug_get_mac_page(struct seq_file *m, void *v) { struct rtw_debugfs_priv *debugfs_priv = m->private; struct rtw_dev *rtwdev = debugfs_priv->rtwdev; - u32 val; u32 page = debugfs_priv->cb_data; int i, n; int max = 0xff; - val = rtw_read32(rtwdev, debugfs_priv->cb_data); + rtw_read32(rtwdev, debugfs_priv->cb_data); for (n = 0; n <= max; ) { seq_printf(m, "\n%8.8x ", n + page); for (i = 0; i < 4 && n <= max; i++, n += 4) @@ -447,12 +446,11 @@ static int rtw_debug_get_bb_page(struct seq_file *m, void *v) { struct rtw_debugfs_priv *debugfs_priv = m->private; struct rtw_dev *rtwdev = debugfs_priv->rtwdev; - u32 val; u32 page = debugfs_priv->cb_data; int i, n; int max = 0xff; - val = rtw_read32(rtwdev, debugfs_priv->cb_data); + rtw_read32(rtwdev, debugfs_priv->cb_data); for (n = 0; n <= max; ) { seq_printf(m, "\n%8.8x ", n + page); for (i = 0; i < 4 && n <= max; i++, n += 4) From patchwork Wed Aug 26 09:33:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 248387 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:522:0:0:0:0 with SMTP id h2csp4156342ils; Wed, 26 Aug 2020 02:36:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxLHdzwAA+PJoyX4X2uihAf02xq7E5n5j1acMX7V1sqQwRAlshsE6PissgH91PC+b4DqB6h X-Received: by 2002:a05:6402:2033:: with SMTP id ay19mr14050023edb.361.1598434617406; Wed, 26 Aug 2020 02:36:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598434617; cv=none; d=google.com; s=arc-20160816; b=gjqAjRiCRFOWINy4fWDaHVEFkZ2mZzS64JwenRe8LNUYOGGvDIvuzPqvVxYYUzu5XZ 0NKxajTzdOTGnUOph/uSPiowo9Xxbyn8qRPl24lZfyA2oVDVffa2Wv9kWwys/pBk9LgF 3LiZbrUQNC954uTE/kAeyTA3I1cGDigbR9I2xmKglvJ+D6rmUVOYgt2CWtEsV9oKgY7R X0uHXiuKxGIIzBQVguowyNMgFQjs2Ji9iR30pFdU4ECYPzPSI/SYXWd7bFFPoe+KozIi 1/dPoGeoGV0jG5hJhGnmVJsIuT940evywa5nuDOizjmURZ6wAJP3Dxam5z/fBJn61XfU Nc7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=yvoQanaWTpWNQEXwywlAc7o43dgHa3QRlp1C/cAGUU4=; b=Ndu9104XFDLMUQxHQv4SjT3K5+7TiG3MEkPN+TbLdG+pjIAiVAUOKaU9byARj+QjSA VSdrvRgDOnoh1EuI96q+/UrXuph7zGxIJKlf7cePMKMcUe4QXRg0f3vOfyc/SnV2lTRx sLGghldBGXDakmNe2eIe+A7OK1KEeWs0gdPu7XnWgFrY6331gfxYx6ExICn/bUDKbs5M fWZO9uG8FeIPpwAeHbVD715gd4t0xcp0GC5Md0tZ5PFeHE4xc356m/UW2kHmD1OJdYrc QHHRoBo6ww+ya8ZilbCRkj1sLoO+TIUA2RZNc0jBIv0HBiIYS3eoV/8IdSTPSYS5dmxq x9Xg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=s03wRDxS; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cz8si1089200edb.455.2020.08.26.02.36.57; Wed, 26 Aug 2020 02:36:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=s03wRDxS; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728523AbgHZJg4 (ORCPT + 2 others); Wed, 26 Aug 2020 05:36:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728382AbgHZJfJ (ORCPT ); Wed, 26 Aug 2020 05:35:09 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 815F3C061357 for ; Wed, 26 Aug 2020 02:34:34 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id d10so174118wrw.2 for ; Wed, 26 Aug 2020 02:34:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yvoQanaWTpWNQEXwywlAc7o43dgHa3QRlp1C/cAGUU4=; b=s03wRDxSuZJrkgF2oUckm/dxkHDlEzj7UzMo4Rqm6Jg4UF21WboPJXhBjmsdYI44VB T80Qv+u/ejdXfR88W2SGz656OtO/FWRBPOKx1iuuWvDdQrNMTfC5JE0nyJWAnusYydDc GOPazXC8CxR2wMTlSrN063oegcaXdEmuxL7OHTkh89TSmAWGWQJIp8QMfdTY51HreW3U kc8nEWXR50Oqtd60Nj305DBmXokL7F6Yf9ZUX0h/JTqLq9oSZV5GdQmUxXwIKir3clme AOdeWWnagZRvMsJg5BwaVzJpqvtcPMKSGuJ6WkwKZbXsyz1GFTc1PqqJ+D0GvAOe2vAZ 2yhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yvoQanaWTpWNQEXwywlAc7o43dgHa3QRlp1C/cAGUU4=; b=dEXqJKe0YsEkH57vADea7qO8mnSmI2HjqVoMOmtItyANTI828Se9499cYh2NgrjLnB oszNg9h7J30uAEbQi/+KvlZAidJp9lSpdT6t1VkQXDrAr6oYjALfr85VceQuDxyWLmc1 4eTltriWkgtcQ2n8KqWE5iIJAOtgyTHqFqybjlaEXvNDhdDCyJFKcte5ABnxTcsV1Vqz Kb8V3ZmkSzAeWR/lw5QYk0VrDnZmohoLTHwxZFV9UOD7vUA2xMLhxkirimm8/6l4wiyN Vh3iZ7Sv5rO2mA8tCtxz1vnOlDl4Ng6JGskEAuhmdfa3v9DeOPApST14fh5ySj+3w9Dz 6xzg== X-Gm-Message-State: AOAM531/z62qy335ySuLv+7tB6rthqfXTKGMgE86/bfqF6dcE5IWOpE+ K3qHqZyGO7nAH4QOfFfwJsSOAA== X-Received: by 2002:a5d:43ca:: with SMTP id v10mr14464274wrr.299.1598434473214; Wed, 26 Aug 2020 02:34:33 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id u3sm3978759wml.44.2020.08.26.02.34.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 02:34:32 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Luis Chamberlain , Aurelien Alleaume , Valerio Riedel , "Luis R. Rodriguez" Subject: [PATCH 23/30] wireless: intersil: prism54: isl_ioctl: Remove unused variable 'j' Date: Wed, 26 Aug 2020 10:33:54 +0100 Message-Id: <20200826093401.1458456-24-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200826093401.1458456-1-lee.jones@linaro.org> References: <20200826093401.1458456-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/intersil/prism54/isl_ioctl.c: In function ‘prism54_update_stats’: drivers/net/wireless/intersil/prism54/isl_ioctl.c:166:6: warning: variable ‘j’ set but not used [-Wunused-but-set-variable] Cc: Luis Chamberlain Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Aurelien Alleaume Cc: Valerio Riedel Cc: "Luis R. Rodriguez" Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/intersil/prism54/isl_ioctl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.25.1 diff --git a/drivers/net/wireless/intersil/prism54/isl_ioctl.c b/drivers/net/wireless/intersil/prism54/isl_ioctl.c index 3ccf2a4b548c6..5c49b9e52a0c4 100644 --- a/drivers/net/wireless/intersil/prism54/isl_ioctl.c +++ b/drivers/net/wireless/intersil/prism54/isl_ioctl.c @@ -163,7 +163,6 @@ prism54_update_stats(struct work_struct *work) { islpci_private *priv = container_of(work, islpci_private, stats_work); char *data; - int j; struct obj_bss bss, *bss2; union oid_res_t r; @@ -187,7 +186,7 @@ prism54_update_stats(struct work_struct *work) kfree(data); /* now ask for the corresponding bss */ - j = mgt_get_request(priv, DOT11_OID_BSSFIND, 0, (void *) &bss, &r); + mgt_get_request(priv, DOT11_OID_BSSFIND, 0, (void *) &bss, &r); bss2 = r.ptr; /* report the rssi and use it to calculate * link quality through a signal-noise From patchwork Wed Aug 26 09:33:55 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 248388 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:522:0:0:0:0 with SMTP id h2csp4156379ils; Wed, 26 Aug 2020 02:37:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxXMPjTjc3j81qsjmGRYDF1+VLr00gpUPBUK9qBTdLdmTr18OeNSbdkXRV5gcQAvRxoA4mI X-Received: by 2002:a17:907:7094:: with SMTP id yj20mr14471477ejb.179.1598434621754; Wed, 26 Aug 2020 02:37:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598434621; cv=none; d=google.com; s=arc-20160816; b=MYN4deXTaZSwlqdA25ZXeCctyfAjShLt8dKAXHPPNMMAHpvbHFRGAhu37zt6t65scJ A4g7NrOS9E08TpONp6O5q9qHlv+EtOlRkesxyLacz6MLjPrlrEiwKcycfiGPjOjsqzR8 B3mmJSKr1siWKz0XQGTFaOTbnSYULV1x/VmFlz6pUzLR2LXXjX7ZeS927d1VGivX18UB 9QW2BygJ9452MqcnpBIcI2GPmJe3oGKhnNwyJlLx19oNcPCdkfrnv2y1uw0gQNbMWcqT 0lTJR2fYVuVY/dARw7GGXF1S4rZDkeOykmd8XlKOjIQZVN4Qo9SgjmkYBMMJajG+UDeZ RPwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=wOk7+v5tRA8kQkojRiep+oFsY19pnrxzjDBrN8NxzU0=; b=T2KWIfbUwPmba25QJYI5LFbHEktSnyHdmoJ9Oa0SgC+SU/DEdVETzB8lczLugx0L4T OoM6l+3wfDpMleDURMYaVfNn3E1Pa20i3K5O7aGD60ERgkq4lE+Uahg+vX6Kn/jIzHMP cNit064Znd8O0a9MBwcpOVQ7jCPVH0dYnIw0WfYCVAG51wikZ+w/mk/U0FAW9T7nzKwk SCgKDMDRlq94pqXcZP3AbnsV3lKVSy7BttXkfZSEWJcq9WNA9ZbjDsE5BZ0/vEvcggVl 3y2UdzwguHTjvHwTy/wOGzmfcdWwrZEnpyPEm50YLkA0JhcIrSqOje0yI6DGu5Q7Tbm5 +ZYw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=oROYULir; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a10si1187525ejc.348.2020.08.26.02.37.01; Wed, 26 Aug 2020 02:37:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=oROYULir; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728514AbgHZJgy (ORCPT + 2 others); Wed, 26 Aug 2020 05:36:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728388AbgHZJfL (ORCPT ); Wed, 26 Aug 2020 05:35:11 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC185C06135A for ; Wed, 26 Aug 2020 02:34:35 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id r15so1072938wrp.13 for ; Wed, 26 Aug 2020 02:34:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wOk7+v5tRA8kQkojRiep+oFsY19pnrxzjDBrN8NxzU0=; b=oROYULirz7RycKlFmz17ODwkIRUf3Ag8qwgHItHR6BX/j/SEk6NQew0g/BRgEMzKRt tt5Jo4BYLTEgPjhR8lr8ljhURcObcNyebw4VhcIRTD8tNDzT+tN9XWFK/g1IEDDze0lo cVcmlCZWZ3+6bIsZPPUPS6/6TB7U+uwepRDGIDC6wHM5H0TXN7N+u6megW0Hfk/fhUh9 7ay25LPBDBt4KObWLrnNxDdAtrhYcz0n+4RItNhX+gnxbxzecxQt4SWzH3BOKu5ViVg0 KQqLjd3R2nlk95hbvc6xpBfj9zdeQaaNiOxwWcq04YmdmBtGeOwgHTAtW9TERdqwx4W4 y2MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wOk7+v5tRA8kQkojRiep+oFsY19pnrxzjDBrN8NxzU0=; b=AdNIgkOke06gm2gdnkXVHIo8gvjW3Jx7/BjfRqFAzPDY7i9pMIprR4lWNdVDVtkZFC 4eus9y8MsNuWuuJYxEk8kRpNu29VhWdoIQEIeTM9hg4/1OOkX508Gp7WgH8RoASC4Gnf IXgfiWvKz4fxkrfwC+H9P/HdaqvSxmmCH77JZYalh47oq3O+bXevdLEkH1bJV/9RMHA2 cQapHrNQa2bOKW9ip5O6WRTuyimDAC9a7cpVqIqplZ5iKJyN0imSOSIhYMUUt0Bvoo4Z Q2/qN0/aiEyGgy9K6DqgoaDeYHQtAZ1+QaM9GgHNJOE+rimkjVS8q9Ryq8Nm112u0QXt hAXg== X-Gm-Message-State: AOAM531lQ2CPJ5AzNPTkkXXiFSmytctvgjrtRozK+k5weOGhMRwCO+V7 aRYC7dYG4L/Sa+telDzsD8zEtg== X-Received: by 2002:adf:fe90:: with SMTP id l16mr15018301wrr.345.1598434474431; Wed, 26 Aug 2020 02:34:34 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id u3sm3978759wml.44.2020.08.26.02.34.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 02:34:33 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Amitkumar Karwar , Ganapathi Bhat , Xinming Hu Subject: [PATCH 24/30] wireless: marvell: mwifiex: wmm: Mark 'mwifiex_1d_to_wmm_queue' as __maybe_unused Date: Wed, 26 Aug 2020 10:33:55 +0100 Message-Id: <20200826093401.1458456-25-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200826093401.1458456-1-lee.jones@linaro.org> References: <20200826093401.1458456-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org 'mwifiex_1d_to_wmm_queue' is used in'; main.c, txrx.c and uap_txrx.c ... but not used in 14 other source files which include 'wmm.h'. Fixes the following W=1 kernel build warning(s): In file included from drivers/net/wireless/marvell/mwifiex/init.c:25: drivers/net/wireless/marvell/mwifiex/wmm.h:34:18: warning: ‘mwifiex_1d_to_wmm_queue’ defined but not used [-Wunused-const-variable=] 34 | static const u16 mwifiex_1d_to_wmm_queue[8] = { 1, 0, 0, 1, 2, 2, 3, 3 }; | ^~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/net/wireless/marvell/mwifiex/cmdevt.c:26: drivers/net/wireless/marvell/mwifiex/wmm.h:34:18: warning: ‘mwifiex_1d_to_wmm_queue’ defined but not used [-Wunused-const-variable=] 34 | static const u16 mwifiex_1d_to_wmm_queue[8] = { 1, 0, 0, 1, 2, 2, 3, 3 }; | ^~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/net/wireless/marvell/mwifiex/util.c:25: drivers/net/wireless/marvell/mwifiex/wmm.h:34:18: warning: ‘mwifiex_1d_to_wmm_queue’ defined but not used [-Wunused-const-variable=] 34 | static const u16 mwifiex_1d_to_wmm_queue[8] = { 1, 0, 0, 1, 2, 2, 3, 3 }; | ^~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/net/wireless/marvell/mwifiex/wmm.c:25: drivers/net/wireless/marvell/mwifiex/wmm.h:34:18: warning: ‘mwifiex_1d_to_wmm_queue’ defined but not used [-Wunused-const-variable=] 34 | static const u16 mwifiex_1d_to_wmm_queue[8] = { 1, 0, 0, 1, 2, 2, 3, 3 }; | ^~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/net/wireless/marvell/mwifiex/11n.c:25: drivers/net/wireless/marvell/mwifiex/wmm.h:34:18: warning: ‘mwifiex_1d_to_wmm_queue’ defined but not used [-Wunused-const-variable=] 34 | static const u16 mwifiex_1d_to_wmm_queue[8] = { 1, 0, 0, 1, 2, 2, 3, 3 }; | ^~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/net/wireless/marvell/mwifiex/11n_aggr.c:25: drivers/net/wireless/marvell/mwifiex/wmm.h:34:18: warning: ‘mwifiex_1d_to_wmm_queue’ defined but not used [-Wunused-const-variable=] 34 | static const u16 mwifiex_1d_to_wmm_queue[8] = { 1, 0, 0, 1, 2, 2, 3, 3 }; | ^~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/net/wireless/marvell/mwifiex/11n_rxreorder.c:25: drivers/net/wireless/marvell/mwifiex/wmm.h:34:18: warning: ‘mwifiex_1d_to_wmm_queue’ defined but not used [-Wunused-const-variable=] 34 | static const u16 mwifiex_1d_to_wmm_queue[8] = { 1, 0, 0, 1, 2, 2, 3, 3 }; | ^~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/net/wireless/marvell/mwifiex/11n.h:25, from drivers/net/wireless/marvell/mwifiex/scan.c:25: drivers/net/wireless/marvell/mwifiex/wmm.h:34:18: warning: ‘mwifiex_1d_to_wmm_queue’ defined but not used [-Wunused-const-variable=] 34 | static const u16 mwifiex_1d_to_wmm_queue[8] = { 1, 0, 0, 1, 2, 2, 3, 3 }; | ^~~~~~~~~~~~~~~~~~~~~~~ NB: Many entries - snipped for brevity. Cc: Amitkumar Karwar Cc: Ganapathi Bhat Cc: Xinming Hu Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/marvell/mwifiex/wmm.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.25.1 diff --git a/drivers/net/wireless/marvell/mwifiex/wmm.h b/drivers/net/wireless/marvell/mwifiex/wmm.h index 60bdbb82277a3..58bcd84b050c5 100644 --- a/drivers/net/wireless/marvell/mwifiex/wmm.h +++ b/drivers/net/wireless/marvell/mwifiex/wmm.h @@ -31,7 +31,8 @@ enum ieee_types_wmm_ecw_bitmasks { MWIFIEX_ECW_MAX = (BIT(4) | BIT(5) | BIT(6) | BIT(7)), }; -static const u16 mwifiex_1d_to_wmm_queue[8] = { 1, 0, 0, 1, 2, 2, 3, 3 }; +static const u16 __maybe_unused +mwifiex_1d_to_wmm_queue[8] = { 1, 0, 0, 1, 2, 2, 3, 3 }; /* * This function retrieves the TID of the given RA list. From patchwork Wed Aug 26 09:33:56 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 248386 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:522:0:0:0:0 with SMTP id h2csp4156275ils; Wed, 26 Aug 2020 02:36:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxkJuHaPGDyqvCIOUWh/NEPiEzvtEoPx8CAO0KMheQotMHNGLlPH6IYkuey9Y+xU/n5NY+e X-Received: by 2002:a17:906:b2c3:: with SMTP id cf3mr15504657ejb.387.1598434608267; Wed, 26 Aug 2020 02:36:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598434608; cv=none; d=google.com; s=arc-20160816; b=WemwrIJrvtPS+kIeF8ly69kGo36d/LSwguozQSXTs0WGgRITI2vRX1KMyHyzz7Stw9 q7xcYjc3ofTYHPJ/BAhBFdfJlWs6wANlvxDrau13H83BkqoK0WZfdyc99tfamagCy1rk pST5BPngbvupu3ZOc5URxByqFr225PRq+RKi/Zn7q2ygFjmk8/24z5xQJ8uQjszHhdZ9 J/Iu8wYzSLQeFIVMHyFY+N+l3FYS70Kz3PYfBgNF5pQkweLtfYbVMq/brRbOGB66Xxpm KrSZWPG01Lkttrg3SOMRTJwFTwmL2wm+oiaEgv6tKXkPX2jx4azfYnBVB8CiE/PO4vSU u15w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Ce/xQKtB6h18AIsA1S/vHOwsBOtcRFWUAHoCEtAF9MI=; b=lWO7dXCzFSP7gUlyOtMgyrIWBlXLb2KtibyU7Kard8uhE6QlMAkMsZFefXf6x5tTP8 bh//TLhMMnHb3bjQo26SmRvrCFZxBDO2KYJDReNgh5GqvZy5JgHFRmR90ab8zuube4Pt UodLSfjsjUcK+7XbeBWYsUexBrfx10zBHC61i9vuDiIbHwwtAsB0baN/Vv2SytlaIlR/ 3X20k6aEmdQ2WQdbFSvy6X0Z6yMwn/5Sc+COefuMdI8riNkR6wA8ZVf27VFjT1aDd1ck tNrDRGo5nemwsYMMxPGH2BA2OBkgBUJCjeA/Bmm26rXZahS7s5q7RX04x46lJAxji7Gw InmQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=j7GRt0ZV; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cz8si1089200edb.455.2020.08.26.02.36.48; Wed, 26 Aug 2020 02:36:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=j7GRt0ZV; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728122AbgHZJgq (ORCPT + 2 others); Wed, 26 Aug 2020 05:36:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728400AbgHZJfO (ORCPT ); Wed, 26 Aug 2020 05:35:14 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CBBBCC06135D for ; Wed, 26 Aug 2020 02:34:36 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id d10so174234wrw.2 for ; Wed, 26 Aug 2020 02:34:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Ce/xQKtB6h18AIsA1S/vHOwsBOtcRFWUAHoCEtAF9MI=; b=j7GRt0ZVvyJLC/IQxJbBRdWVh9IPb6r50Td8Ok6n3IwhwuwGb+5uH4Dg/H9O7DD+cB zz1mBimmNGNqXSDXvKC4udI1Es1Mn6+Fjzt4WOr5H0Jze6fbM9SJUrzpABJ8mEENeT4Y JUYPjZL0jpXlFXCdcylWj3wubP4D0eGp+0o8EAkbAmZitIm6Wnj+c27Qy1nKYK/arj0p 5OE/OfrAJLP2SgHRW+q4gL6ow+XzGX3/hu75oQ5gxNDmvVHA4nNPEuOxsEr42gU8eKOa gIUqWt6LDrtHD6FaiDBcOH3Bx9pS8s4sW3BHnMSnvZtNyOZW4VUcNlPxb6/AEDD8XtC8 YMbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ce/xQKtB6h18AIsA1S/vHOwsBOtcRFWUAHoCEtAF9MI=; b=E1AVoKObzre+LrBV8fC3BXAKRrYfpxwTmDLVJ8zxaMyQLgC/Crqxd8fls0bkS9YDBi djIVgWEmrq+QeAxE5Ijk/vuH9sYYTK05i2IwR6zUoqJ0/W8KFVFfxlzF6ythC1+zJG/C ppZgQemDrxUJn06IQOGxnQaorWXcjmsOl7U/UroynYmLzpVbCpdRBXQ71slRPwQUlmrP 6i85dbkP016ifzB+AQ2iQOVQQgSEA5NWdz2bAitogd4tpRe0pjTOOaSvoxqUapldC3II 3IgdIb/jQjPR8MbVs3rRr7uBKuju4wYi+VTTS49YBxWqlGtgqfg2npt6Kt84DxJxnGp6 0fkg== X-Gm-Message-State: AOAM532fZnqXVlNBxO+sQObKPRPScJsW9nMRS6BoizuL+YFKMijfFDy4 GT4kM/Fqanx5XOfODdzypKaZqA== X-Received: by 2002:a5d:6843:: with SMTP id o3mr661325wrw.421.1598434475499; Wed, 26 Aug 2020 02:34:35 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id u3sm3978759wml.44.2020.08.26.02.34.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 02:34:34 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , QCA ath9k Development Subject: [PATCH 25/30] wireless: ath: ath9k: ar5008_initvals: Remove unused table entirely Date: Wed, 26 Aug 2020 10:33:56 +0100 Message-Id: <20200826093401.1458456-26-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200826093401.1458456-1-lee.jones@linaro.org> References: <20200826093401.1458456-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/ath9k/ar5008_initvals.h:553:18: warning: ‘ar5416Bank6’ defined but not used [-Wunused-const-variable=] Cc: QCA ath9k Development Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- .../net/wireless/ath/ath9k/ar5008_initvals.h | 37 ------------------- 1 file changed, 37 deletions(-) -- 2.25.1 diff --git a/drivers/net/wireless/ath/ath9k/ar5008_initvals.h b/drivers/net/wireless/ath/ath9k/ar5008_initvals.h index 467ccfae2ceed..8d251600d8458 100644 --- a/drivers/net/wireless/ath/ath9k/ar5008_initvals.h +++ b/drivers/net/wireless/ath/ath9k/ar5008_initvals.h @@ -550,43 +550,6 @@ static const u32 ar5416Bank3[][3] = { {0x000098f0, 0x01400018, 0x01c00018}, }; -static const u32 ar5416Bank6[][3] = { - /* Addr 5G 2G */ - {0x0000989c, 0x00000000, 0x00000000}, - {0x0000989c, 0x00000000, 0x00000000}, - {0x0000989c, 0x00000000, 0x00000000}, - {0x0000989c, 0x00e00000, 0x00e00000}, - {0x0000989c, 0x005e0000, 0x005e0000}, - {0x0000989c, 0x00120000, 0x00120000}, - {0x0000989c, 0x00620000, 0x00620000}, - {0x0000989c, 0x00020000, 0x00020000}, - {0x0000989c, 0x00ff0000, 0x00ff0000}, - {0x0000989c, 0x00ff0000, 0x00ff0000}, - {0x0000989c, 0x00ff0000, 0x00ff0000}, - {0x0000989c, 0x40ff0000, 0x40ff0000}, - {0x0000989c, 0x005f0000, 0x005f0000}, - {0x0000989c, 0x00870000, 0x00870000}, - {0x0000989c, 0x00f90000, 0x00f90000}, - {0x0000989c, 0x007b0000, 0x007b0000}, - {0x0000989c, 0x00ff0000, 0x00ff0000}, - {0x0000989c, 0x00f50000, 0x00f50000}, - {0x0000989c, 0x00dc0000, 0x00dc0000}, - {0x0000989c, 0x00110000, 0x00110000}, - {0x0000989c, 0x006100a8, 0x006100a8}, - {0x0000989c, 0x004210a2, 0x004210a2}, - {0x0000989c, 0x0014008f, 0x0014008f}, - {0x0000989c, 0x00c40003, 0x00c40003}, - {0x0000989c, 0x003000f2, 0x003000f2}, - {0x0000989c, 0x00440016, 0x00440016}, - {0x0000989c, 0x00410040, 0x00410040}, - {0x0000989c, 0x0001805e, 0x0001805e}, - {0x0000989c, 0x0000c0ab, 0x0000c0ab}, - {0x0000989c, 0x000000f1, 0x000000f1}, - {0x0000989c, 0x00002081, 0x00002081}, - {0x0000989c, 0x000000d4, 0x000000d4}, - {0x000098d0, 0x0000000f, 0x0010000f}, -}; - static const u32 ar5416Bank6TPC[][3] = { /* Addr 5G 2G */ {0x0000989c, 0x00000000, 0x00000000}, From patchwork Wed Aug 26 09:33:58 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 259479 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5416C433E1 for ; Wed, 26 Aug 2020 09:35:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 862032087D for ; Wed, 26 Aug 2020 09:35:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="As6cWuop" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728453AbgHZJfh (ORCPT ); Wed, 26 Aug 2020 05:35:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728047AbgHZJfY (ORCPT ); Wed, 26 Aug 2020 05:35:24 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8FBFC061361 for ; Wed, 26 Aug 2020 02:34:39 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id 2so1083998wrj.10 for ; Wed, 26 Aug 2020 02:34:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rUAO3RuW/3xrjV/jLQoBhZg+qrtryFN4uR4f5U2383M=; b=As6cWuop/UitBN8qYzmoyyS8vCPET7V+08ebuq6oQcV6utLW7d2Wq3FC6+itt/QdM6 vJWvBjw4LqqhgSlcfR1SELi/4siTNwvRB6Jm2f3cik6e6/b7x2u4BDO47TPxwO1L4R06 d9SF74TQV6b21kHyDGr+r/5Sh1/eAZ6zYtppbV1UA55rXGMppf4Vplbb/bDgaRpAWLUr EwMvE7zOItgvt5lcKzz6GBg/x7iSpWuPIPW3rdoADPuZNeFe5UKcu6EkPg/iFw9LVAKR 1ZHYlNVyF5FsBso5UfAsFt825rivgBwDix2VBBQxYxYMcMoiOs8n98V25qtafhCAAVV1 H2Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rUAO3RuW/3xrjV/jLQoBhZg+qrtryFN4uR4f5U2383M=; b=T/rStxCOCpKaK6lL4ARJY6SXgNlIL5PsBo6cLivO8yF7V/4NM854sJS+4OlOiY646I kv9ztDgezEo+gV4CSmFe0sdWWjVjBdO1aCF632NxbIO8P6csSlyHZkCkP4saOz8FF2KY blatYkD9fhCTVKWmPiCR0W/4t+Cg5W6ExuNoqZd1r2BTM5ljCeSh0svRHX113H4OiU72 EZDgm0LJjR/4H6k0LkdiyGPBiz9j+l1swVYlRwpfxSkbKxJgmoLU6LWhvsQEenQbDbqw LoAHeUhfrcyKs3AZ7kxao531Ul7wFIMdjzd2RMK1D4fGlYvGbOhU9nuRAU5kZt4kA84B we3A== X-Gm-Message-State: AOAM532tamQtvxyBNN4hWrkVTec3DvzStpv6NFswOljRer2GogUKI50Q vmJBSYZjGkI5nlhGOukb6VQKcQ== X-Google-Smtp-Source: ABdhPJziN1RDbNaC2S+YMAoUkGKn2f+KngJEz1+d5F2GY3qWG0qGkU38nN0FtIz1QZ2HPMATScxOyg== X-Received: by 2002:a5d:43ca:: with SMTP id v10mr14464632wrr.299.1598434478379; Wed, 26 Aug 2020 02:34:38 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id u3sm3978759wml.44.2020.08.26.02.34.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 02:34:37 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com Subject: [PATCH 27/30] wireless: broadcom: brcm80211: phy_lcn: Remove a bunch of unused variables Date: Wed, 26 Aug 2020 10:33:58 +0100 Message-Id: <20200826093401.1458456-28-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200826093401.1458456-1-lee.jones@linaro.org> References: <20200826093401.1458456-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): In file included from drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c:11: drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c: In function ‘wlc_lcnphy_rx_iq_cal’: drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c:1366:29: warning: variable ‘RFOverride0_old’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c: In function ‘wlc_lcnphy_radio_2064_channel_tune_4313’: drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c:1667:21: warning: variable ‘qFvco’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c:1667:14: warning: variable ‘qFref’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c:1667:6: warning: variable ‘qFxtal’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c: In function ‘wlc_lcnphy_idle_tssi_est’: drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c:2856:6: warning: variable ‘idleTssi’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c: In function ‘wlc_lcnphy_tx_iqlo_soft_cal_full’: drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c:3861:53: warning: variable ‘locc4’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c:3861:46: warning: variable ‘locc3’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c:3861:39: warning: variable ‘locc2’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c:3861:32: warning: variable ‘iqcc0’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c: In function ‘wlc_lcnphy_periodic_cal’: drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c:4196:6: warning: variable ‘rx_iqcomp_sz’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c:4195:33: warning: variable ‘rx_iqcomp’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c:4194:16: warning: variable ‘full_cal’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c: In function ‘wlc_phy_txpwr_srom_read_lcnphy’: drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c:4919:7: warning: variable ‘opo’ set but not used [-Wunused-but-set-variable] Cc: Arend van Spriel Cc: Franky Lin Cc: Hante Meuleman Cc: Chi-Hsien Lin Cc: Wright Feng Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: brcm80211-dev-list.pdl@broadcom.com Cc: brcm80211-dev-list@cypress.com Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- .../broadcom/brcm80211/brcmsmac/phy/phy_lcn.c | 40 +++++-------------- 1 file changed, 11 insertions(+), 29 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c index 7ef36234a25dc..b8193c99e8642 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c @@ -1363,7 +1363,7 @@ wlc_lcnphy_rx_iq_cal(struct brcms_phy *pi, u16 tx_pwr_ctrl; u8 tx_gain_index_old = 0; bool result = false, tx_gain_override_old = false; - u16 i, Core1TxControl_old, RFOverride0_old, + u16 i, Core1TxControl_old, RFOverrideVal0_old, rfoverride2_old, rfoverride2val_old, rfoverride3_old, rfoverride3val_old, rfoverride4_old, rfoverride4val_old, afectrlovr_old, afectrlovrval_old; @@ -1404,7 +1404,7 @@ wlc_lcnphy_rx_iq_cal(struct brcms_phy *pi, or_phy_reg(pi, 0x631, 0x0015); - RFOverride0_old = read_phy_reg(pi, 0x44c); + read_phy_reg(pi, 0x44c); /* RFOverride0_old */ RFOverrideVal0_old = read_phy_reg(pi, 0x44d); rfoverride2_old = read_phy_reg(pi, 0x4b0); rfoverride2val_old = read_phy_reg(pi, 0x4b1); @@ -1664,7 +1664,7 @@ wlc_lcnphy_radio_2064_channel_tune_4313(struct brcms_phy *pi, u8 channel) const struct chan_info_2064_lcnphy *ci; u8 rfpll_doubler = 0; u8 pll_pwrup, pll_pwrup_ovr; - s32 qFxtal, qFref, qFvco, qFcal; + s32 qFcal; u8 d15, d16, f16, e44, e45; u32 div_int, div_frac, fvco3, fpfd, fref3, fcal_div; u16 loop_bw, d30, setCount; @@ -1738,10 +1738,7 @@ wlc_lcnphy_radio_2064_channel_tune_4313(struct brcms_phy *pi, u8 channel) fvco3 = (ci->freq * 3); fref3 = 2 * fpfd; - qFxtal = wlc_lcnphy_qdiv_roundup(pi->xtalfreq, PLL_2064_MHZ, 16); - qFref = wlc_lcnphy_qdiv_roundup(fpfd, PLL_2064_MHZ, 16); qFcal = pi->xtalfreq * fcal_div / PLL_2064_MHZ; - qFvco = wlc_lcnphy_qdiv_roundup(fvco3, 2, 16); write_radio_reg(pi, RADIO_2064_REG04F, 0x02); @@ -2853,7 +2850,7 @@ static void wlc_lcnphy_idle_tssi_est(struct brcms_phy_pub *ppi) bool suspend, tx_gain_override_old; struct lcnphy_txgains old_gains; struct brcms_phy *pi = container_of(ppi, struct brcms_phy, pubpi_ro); - u16 idleTssi, idleTssi0_2C, idleTssi0_OB, idleTssi0_regvalue_OB, + u16 idleTssi0_2C, idleTssi0_OB, idleTssi0_regvalue_OB, idleTssi0_regvalue_2C; u16 SAVE_txpwrctrl = wlc_lcnphy_get_tx_pwr_ctrl(pi); u16 SAVE_lpfgain = read_radio_reg(pi, RADIO_2064_REG112); @@ -2863,7 +2860,7 @@ static void wlc_lcnphy_idle_tssi_est(struct brcms_phy_pub *ppi) u16 SAVE_iqadc_aux_en = read_radio_reg(pi, RADIO_2064_REG11F) & 4; u8 SAVE_bbmult = wlc_lcnphy_get_bbmult(pi); - idleTssi = read_phy_reg(pi, 0x4ab); + read_phy_reg(pi, 0x4ab); /* idleTssi */ suspend = (0 == (bcma_read32(pi->d11core, D11REGOFFS(maccontrol)) & MCTL_EN_MAC)); if (!suspend) @@ -2887,8 +2884,7 @@ static void wlc_lcnphy_idle_tssi_est(struct brcms_phy_pub *ppi) wlc_lcnphy_set_bbmult(pi, 0x0); wlc_phy_do_dummy_tx(pi, true, OFF); - idleTssi = ((read_phy_reg(pi, 0x4ab) & (0x1ff << 0)) - >> 0); + read_phy_reg(pi, 0x4ab); /* idleTssi */ idleTssi0_2C = ((read_phy_reg(pi, 0x63e) & (0x1ff << 0)) >> 0); @@ -3858,8 +3854,6 @@ void wlc_lcnphy_get_tx_iqcc(struct brcms_phy *pi, u16 *a, u16 *b) static void wlc_lcnphy_tx_iqlo_soft_cal_full(struct brcms_phy *pi) { - struct lcnphy_unsign16_struct iqcc0, locc2, locc3, locc4; - wlc_lcnphy_set_cc(pi, 0, 0, 0); wlc_lcnphy_set_cc(pi, 2, 0, 0); wlc_lcnphy_set_cc(pi, 3, 0, 0); @@ -3872,10 +3866,10 @@ static void wlc_lcnphy_tx_iqlo_soft_cal_full(struct brcms_phy *pi) wlc_lcnphy_a1(pi, 2, 2, 1); wlc_lcnphy_a1(pi, 0, 4, 3); - iqcc0 = wlc_lcnphy_get_cc(pi, 0); - locc2 = wlc_lcnphy_get_cc(pi, 2); - locc3 = wlc_lcnphy_get_cc(pi, 3); - locc4 = wlc_lcnphy_get_cc(pi, 4); + wlc_lcnphy_get_cc(pi, 0); + wlc_lcnphy_get_cc(pi, 2); + wlc_lcnphy_get_cc(pi, 3); + wlc_lcnphy_get_cc(pi, 4); } u16 wlc_lcnphy_get_tx_locc(struct brcms_phy *pi) @@ -4191,9 +4185,7 @@ static void wlc_lcnphy_glacial_timer_based_cal(struct brcms_phy *pi) static void wlc_lcnphy_periodic_cal(struct brcms_phy *pi) { - bool suspend, full_cal; - const struct lcnphy_rx_iqcomp *rx_iqcomp; - int rx_iqcomp_sz; + bool suspend; u16 SAVE_pwrctrl = wlc_lcnphy_get_tx_pwr_ctrl(pi); s8 index; struct phytbl_info tab; @@ -4203,9 +4195,6 @@ static void wlc_lcnphy_periodic_cal(struct brcms_phy *pi) pi->phy_lastcal = pi->sh->now; pi->phy_forcecal = false; - full_cal = - (pi_lcn->lcnphy_full_cal_channel != - CHSPEC_CHANNEL(pi->radio_chanspec)); pi_lcn->lcnphy_full_cal_channel = CHSPEC_CHANNEL(pi->radio_chanspec); index = pi_lcn->lcnphy_current_index; @@ -4220,9 +4209,6 @@ static void wlc_lcnphy_periodic_cal(struct brcms_phy *pi) wlc_lcnphy_txpwrtbl_iqlo_cal(pi); - rx_iqcomp = lcnphy_rx_iqcomp_table_rev0; - rx_iqcomp_sz = ARRAY_SIZE(lcnphy_rx_iqcomp_table_rev0); - if (LCNREV_IS(pi->pubpi.phy_rev, 1)) wlc_lcnphy_rx_iq_cal(pi, NULL, 0, true, false, 1, 40); else @@ -4916,10 +4902,6 @@ static bool wlc_phy_txpwr_srom_read_lcnphy(struct brcms_phy *pi) offset_ofdm >>= 4; } } else { - u8 opo = 0; - - opo = sprom->opo; - for (i = TXP_FIRST_CCK; i <= TXP_LAST_CCK; i++) pi->tx_srom_max_rate_2g[i] = txpwr; From patchwork Wed Aug 26 09:33:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 259478 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39145C433DF for ; Wed, 26 Aug 2020 09:36:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0BFEA2087D for ; Wed, 26 Aug 2020 09:36:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="avYQsDcI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728478AbgHZJgG (ORCPT ); Wed, 26 Aug 2020 05:36:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728418AbgHZJf2 (ORCPT ); Wed, 26 Aug 2020 05:35:28 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18F0BC0617A3 for ; Wed, 26 Aug 2020 02:34:41 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id y3so1098530wrl.4 for ; Wed, 26 Aug 2020 02:34:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gIFuAgbU5KsSZartda2wv/vItp6gRgcDSq7Ia+efgpk=; b=avYQsDcIlHb1v5YkJd/vaqkVLjM5XIcFdZbGcQZAWvKMT1OUpi+Y2PQUXh8dRLs+BR z4rw/6NOguSsCeVFa6gnWDpsAbyQu9Dj83CYvpijW3Qq9SMDOeJepgI4wr+hBDGp5k75 QzcY2wKuN/KWNg89b3So2XrfPhyAytAZQTLKt3aU9yjpqGZ+RlnVWKsHleZDYyoWVtne W6IyLZ8w8hUbG50HFhpg21opLILC1ZNMA93YaWgGQSxfMB9pEPBAE2Ml8222w76w7n8s kFmpRxCZlx8vznMIExuKDi67foRE7NJDwkyaZYAuswIfmY2kEUnh+5R+U2fvcLWM4vN4 TccQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gIFuAgbU5KsSZartda2wv/vItp6gRgcDSq7Ia+efgpk=; b=r1lcKmJFd4y1/m1kDcXeqlovGplV69wsZlIIGmV51J+lYudW9ndv6C6TexDQv+xlXn LQY2fL23h2UkeP2MRDDAQDNPT04rPPIVqwPPa3/nZT+VHwDjjp9MXUxxOY+XINaCpudV FDft1YA5AmAsfJTcvcQy94MvcTkcO8Wqq0+4lxbk8CZpFyRh71qIeplh5vPxsNoVT80O BZto85BYBW56MD21oInCA8TaUDahFVxaxwyC8kjPC1S7sNxgJis/PZi9MlKZ203k0Uzl hGtn0nXrq2VH/0j9ZVexdhJEvQo2oubej2oPYx/Vz0QduORNbPos7uuVPJbpgjAVvbQX Vacg== X-Gm-Message-State: AOAM533HtIPmrffbxmXutono/qBNyWO23uRKOjsVbrY56PQ/ICVOFfHl 73Lh6wsrwVX91/BNCNcP1po4Aw== X-Google-Smtp-Source: ABdhPJwGiOx6SWFxrf5y6KCMyUCNb/Pbq+bbg4PuiTg8ehYEhO9dGBYbCn1ae2FRCyZ8kjZM3uUqbQ== X-Received: by 2002:adf:b1dc:: with SMTP id r28mr14310325wra.242.1598434479728; Wed, 26 Aug 2020 02:34:39 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id u3sm3978759wml.44.2020.08.26.02.34.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 02:34:39 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , zhong jiang , brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com Subject: [PATCH 28/30] wireless: broadcom: brcm80211: phy_n: Remove a bunch of unused variables Date: Wed, 26 Aug 2020 10:33:59 +0100 Message-Id: <20200826093401.1458456-29-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200826093401.1458456-1-lee.jones@linaro.org> References: <20200826093401.1458456-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): In file included from drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c:16: drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c: In function ‘wlc_phy_spurwar_nphy’: drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c:19036:6: warning: variable ‘tempval’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c: In function ‘wlc_phy_tempsense_nphy’: drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c:21983:28: warning: variable ‘RfctrlMiscReg6_save’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c: In function ‘wlc_phy_rssi_compute_nphy’: drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c:22986:6: warning: variable ‘phyRx0_l’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c: In function ‘wlc_phy_runsamples_nphy’: drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c:23101:6: warning: variable ‘lpf_bw_ctl_miscreg4’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c:23100:50: warning: variable ‘lpf_bw_ctl_miscreg3’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c: In function ‘wlc_phy_iqcal_gainparams_nphy’: drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c:23406:6: warning: variable ‘idx’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c: In function ‘wlc_phy_a2_nphy’: drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c:24707:7: warning: variable ‘phy_a6’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c: In function ‘wlc_phy_a3_nphy’: drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c:24999:7: warning: variable ‘phy_a11’ set but not used [-Wunused-but-set-variable] Cc: Arend van Spriel Cc: Franky Lin Cc: Hante Meuleman Cc: Chi-Hsien Lin Cc: Wright Feng Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: zhong jiang Cc: linux-wireless@vger.kernel.org Cc: brcm80211-dev-list.pdl@broadcom.com Cc: brcm80211-dev-list@cypress.com Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- .../broadcom/brcm80211/brcmsmac/phy/phy_n.c | 47 ++++--------------- 1 file changed, 8 insertions(+), 39 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c index a3f094568cfb2..8580a27547891 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c @@ -19033,7 +19033,6 @@ static void wlc_phy_spurwar_nphy(struct brcms_phy *pi) u32 nphy_adj_noise_var_buf[] = { 0x3ff, 0x3ff }; bool isAdjustNoiseVar = false; uint numTonesAdjust = 0; - u32 tempval = 0; if (NREV_GE(pi->pubpi.phy_rev, 3)) { if (pi->phyhang_avoid) @@ -19139,9 +19138,6 @@ static void wlc_phy_spurwar_nphy(struct brcms_phy *pi) numTonesAdjust, nphy_adj_tone_id_buf, nphy_adj_noise_var_buf); - - tempval = 0; - } else { wlc_phy_adjust_min_noisevar_nphy(pi, 0, NULL, NULL); @@ -21980,7 +21976,7 @@ s16 wlc_phy_tempsense_nphy(struct brcms_phy *pi) u16 auxADC_rssi_ctrlL, auxADC_rssi_ctrlH; s32 auxADC_Vl; u16 RfctrlOverride5_save, RfctrlOverride6_save; - u16 RfctrlMiscReg5_save, RfctrlMiscReg6_save; + u16 RfctrlMiscReg5_save; u16 RSSIMultCoef0QPowerDet_save; u16 tempsense_Rcal; @@ -21995,7 +21991,7 @@ s16 wlc_phy_tempsense_nphy(struct brcms_phy *pi) RfctrlOverride5_save = read_phy_reg(pi, 0x346); RfctrlOverride6_save = read_phy_reg(pi, 0x347); RfctrlMiscReg5_save = read_phy_reg(pi, 0x344); - RfctrlMiscReg6_save = read_phy_reg(pi, 0x345); + read_phy_reg(pi, 0x345); /* RfctrlMiscReg6_save */ wlc_phy_table_read_nphy(pi, NPHY_TBL_ID_AFECTRL, 1, 0x0A, 16, &auxADC_Vmid_save); @@ -22983,7 +22979,7 @@ int wlc_phy_rssi_compute_nphy(struct brcms_phy *pi, struct d11rxhdr *rxh) { s16 rxpwr, rxpwr0, rxpwr1; - s16 phyRx0_l, phyRx2_l; + s16 phyRx2_l; rxpwr = 0; rxpwr0 = rxh->PhyRxStatus_1 & PRXS1_nphy_PWR0_MASK; @@ -22994,7 +22990,6 @@ wlc_phy_rssi_compute_nphy(struct brcms_phy *pi, struct d11rxhdr *rxh) if (rxpwr1 > 127) rxpwr1 -= 256; - phyRx0_l = rxh->PhyRxStatus_0 & 0x00ff; phyRx2_l = rxh->PhyRxStatus_2 & 0x00ff; if (phyRx2_l > 127) phyRx2_l -= 256; @@ -23097,8 +23092,7 @@ wlc_phy_runsamples_nphy(struct brcms_phy *pi, u16 num_samps, u16 loops, u16 bb_mult; u8 phy_bw, sample_cmd; u16 orig_RfseqCoreActv; - u16 lpf_bw_ctl_override3, lpf_bw_ctl_override4, lpf_bw_ctl_miscreg3, - lpf_bw_ctl_miscreg4; + u16 lpf_bw_ctl_override3, lpf_bw_ctl_override4; if (pi->phyhang_avoid) wlc_phy_stay_in_carriersearch_nphy(pi, true); @@ -23111,12 +23105,7 @@ wlc_phy_runsamples_nphy(struct brcms_phy *pi, u16 num_samps, u16 loops, lpf_bw_ctl_override3 = read_phy_reg(pi, 0x342) & (0x1 << 7); lpf_bw_ctl_override4 = read_phy_reg(pi, 0x343) & (0x1 << 7); - if (lpf_bw_ctl_override3 | lpf_bw_ctl_override4) { - lpf_bw_ctl_miscreg3 = read_phy_reg(pi, 0x340) & - (0x7 << 8); - lpf_bw_ctl_miscreg4 = read_phy_reg(pi, 0x341) & - (0x7 << 8); - } else { + if (!(lpf_bw_ctl_override3 | lpf_bw_ctl_override4)) { wlc_phy_rfctrl_override_nphy_rev7( pi, (0x1 << 7), @@ -23126,12 +23115,9 @@ wlc_phy_runsamples_nphy(struct brcms_phy *pi, u16 num_samps, u16 loops, NPHY_REV7_RFCTRLOVERRIDE_ID1); pi->nphy_sample_play_lpf_bw_ctl_ovr = true; - - lpf_bw_ctl_miscreg3 = read_phy_reg(pi, 0x340) & - (0x7 << 8); - lpf_bw_ctl_miscreg4 = read_phy_reg(pi, 0x341) & - (0x7 << 8); } + read_phy_reg(pi, 0x340); /* lpf_bw_ctl_miscreg3 */ + read_phy_reg(pi, 0x341); /* lpf_bw_ctl_miscreg4 */ } if ((pi->nphy_bb_mult_save & BB_MULT_VALID_MASK) == 0) { @@ -23403,7 +23389,6 @@ wlc_phy_iqcal_gainparams_nphy(struct brcms_phy *pi, u16 core_no, struct nphy_iqcal_params *params) { u8 k; - int idx; u16 gain_index; u8 band_idx = (CHSPEC_IS5G(pi->radio_chanspec) ? 1 : 0); @@ -23436,13 +23421,10 @@ wlc_phy_iqcal_gainparams_nphy(struct brcms_phy *pi, u16 core_no, (target_gain.pga[core_no] << 4) | (target_gain.txgm[core_no] << 8)); - idx = -1; for (k = 0; k < NPHY_IQCAL_NUMGAINS; k++) { if (tbl_iqcal_gainparams_nphy[band_idx][k][0] == - gain_index) { - idx = k; + gain_index) break; - } } params->txgm = tbl_iqcal_gainparams_nphy[band_idx][k][1]; @@ -24704,7 +24686,6 @@ wlc_phy_a2_nphy(struct brcms_phy *pi, struct nphy_ipa_txcalgains *txgains, { u16 phy_a1, phy_a2, phy_a3; u16 phy_a4, phy_a5; - bool phy_a6; u8 phy_a7, m[2]; u32 phy_a8 = 0; struct nphy_txgains phy_a9; @@ -24714,9 +24695,6 @@ wlc_phy_a2_nphy(struct brcms_phy *pi, struct nphy_ipa_txcalgains *txgains, phy_a7 = (core == PHY_CORE_0) ? 1 : 0; - phy_a6 = ((cal_mode == CAL_GCTRL) - || (cal_mode == CAL_SOFT)) ? true : false; - if (NREV_GE(pi->pubpi.phy_rev, 7)) { phy_a9 = wlc_phy_get_tx_gain_nphy(pi); @@ -24996,7 +24974,6 @@ static u8 wlc_phy_a3_nphy(struct brcms_phy *pi, u8 start_gain, u8 core) s32 phy_a7, phy_a8; u32 phy_a9; int phy_a10; - bool phy_a11 = false; int phy_a12; u8 phy_a13 = 0; u8 phy_a14; @@ -25064,8 +25041,6 @@ static u8 wlc_phy_a3_nphy(struct brcms_phy *pi, u8 start_gain, u8 core) if (!phy_a6 && (phy_a3 != phy_a5)) { if (!phy_a3) phy_a12 -= (u8) phy_a1; - - phy_a11 = true; break; } @@ -25079,8 +25054,6 @@ static u8 wlc_phy_a3_nphy(struct brcms_phy *pi, u8 start_gain, u8 core) phy_a12 = phy_a14; else phy_a12 = phy_a13; - - phy_a11 = true; break; } @@ -25110,8 +25083,6 @@ static u8 wlc_phy_a3_nphy(struct brcms_phy *pi, u8 start_gain, u8 core) if (!phy_a6 && (phy_a3 != phy_a5)) { if (!phy_a3) phy_a12 -= (u8) phy_a1; - - phy_a11 = true; break; } @@ -25125,8 +25096,6 @@ static u8 wlc_phy_a3_nphy(struct brcms_phy *pi, u8 start_gain, u8 core) phy_a12 = 0; else phy_a12 = 127; - - phy_a11 = true; break; } From patchwork Wed Aug 26 09:34:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 259477 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7070FC433DF for ; Wed, 26 Aug 2020 09:36:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 496B42087D for ; Wed, 26 Aug 2020 09:36:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lHkQ9kbI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728075AbgHZJgD (ORCPT ); Wed, 26 Aug 2020 05:36:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728423AbgHZJfd (ORCPT ); Wed, 26 Aug 2020 05:35:33 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40623C061367 for ; Wed, 26 Aug 2020 02:34:42 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id w13so1096081wrk.5 for ; Wed, 26 Aug 2020 02:34:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xmeKWj6ihDtxXg7mmV0g02PkzMbJUwVy4vUADq1jq3Y=; b=lHkQ9kbI4YiHrMG+5c1O2DA0EUdgjZyvLmV+8YExFcXi1gdFNdZna7wI1C7eYgwRYz 9Xk1+KxSEYrXF/zIdSTSg24AIl/kZzSC8uzCISjmVpPb5WPvkYGGet2Msnt5AYRohb/9 tdTLogHLdCjhAebO1xjCBX6weShNPfIwXefOeUNOsk4XydWW3Dg3BLWF1dKUkFyUxjFH 89+MNPaKS6ACrOuzatrjQoAYZCgN2RoMGXmYGEZ8aYPqTCfAjVCfkJdUGw7QdeinfKnR fQiS/5nY5m8XV04zepMGobk9n7MVwie/ajSLslD2eTM/u2MZs63wJfpm38MbNLDGKajP esjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xmeKWj6ihDtxXg7mmV0g02PkzMbJUwVy4vUADq1jq3Y=; b=HB/+pB1LxAC+ZLZlYdgz8DrPM0+C5Kh1BIWhwtwno2y2E4ZT+3yRQ8f19JNbMauO47 tv6NaxaXAv1fnHWfvUasYaZcnpFJpRl0g0rqDiNxewWv2VPKcP0i0udk5l8C5gb0aJYD NO2+QI5JlJd+pOADUb1V8NNQxn07u+WUIZywb5+Ju6eN36Golg9nexWgHduTfRxFCRZL 3fSAAI7+WdxtQctm0d2NNHdOkz6u5SAhUGqT9bTxHv7xaCnhVDXCfcXKlN9JZKn8ZJ1I Vid0e/d6A/rI55W7xg/QudSbilk1s4he7N4G08CJjfyRL6c3xD+8JMTQ1CI/Ljyfka/1 o1Xg== X-Gm-Message-State: AOAM530O+PclvNJn9eTcTl1XnghT39DcW9PABnLDpOwglTgYwYpK6jXN v4TZE3N+fbXDcuEf+9OjnAPxr+8DRBgTbA== X-Google-Smtp-Source: ABdhPJysAlZ5GN6k56EGB8IkpZjoW4o5OuDOadTyLk2UwIoJAbWs4p5DNd4oDWJVopFCUT4nSOwAVg== X-Received: by 2002:adf:ff90:: with SMTP id j16mr477311wrr.105.1598434480972; Wed, 26 Aug 2020 02:34:40 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id u3sm3978759wml.44.2020.08.26.02.34.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 02:34:40 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com Subject: [PATCH 29/30] wireless: broadcom: brcm80211: phytbl_lcn: Remove unused array 'dot11lcnphytbl_rx_gain_info_rev1' Date: Wed, 26 Aug 2020 10:34:00 +0100 Message-Id: <20200826093401.1458456-30-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200826093401.1458456-1-lee.jones@linaro.org> References: <20200826093401.1458456-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phytbl_lcn.c:1510:33: warning: ‘dot11lcnphytbl_rx_gain_info_rev1’ defined but not used [-Wunused-const-variable=] Cc: Arend van Spriel Cc: Franky Lin Cc: Hante Meuleman Cc: Chi-Hsien Lin Cc: Wright Feng Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: brcm80211-dev-list.pdl@broadcom.com Cc: brcm80211-dev-list@cypress.com Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- .../broadcom/brcm80211/brcmsmac/phy/phytbl_lcn.c | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phytbl_lcn.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phytbl_lcn.c index be703be34616a..7526aa441de11 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phytbl_lcn.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phytbl_lcn.c @@ -1507,19 +1507,6 @@ const struct phytbl_info dot11lcnphytbl_rx_gain_info_rev0[] = { , }; -static const struct phytbl_info dot11lcnphytbl_rx_gain_info_rev1[] = { - {&dot11lcn_gain_tbl_rev1, - ARRAY_SIZE(dot11lcn_gain_tbl_rev1), 18, - 0, 32} - , - {&dot11lcn_aux_gain_idx_tbl_rev0, - ARRAY_SIZE(dot11lcn_aux_gain_idx_tbl_rev0), 14, 0, 16} - , - {&dot11lcn_gain_idx_tbl_rev0, - ARRAY_SIZE(dot11lcn_gain_idx_tbl_rev0), 13, 0, 32} - , -}; - const struct phytbl_info dot11lcnphytbl_rx_gain_info_2G_rev2[] = { {&dot11lcn_gain_tbl_2G, ARRAY_SIZE(dot11lcn_gain_tbl_2G), 18, 0, From patchwork Wed Aug 26 09:34:01 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 248385 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:522:0:0:0:0 with SMTP id h2csp4156216ils; Wed, 26 Aug 2020 02:36:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy/exwhJtqNq4Jzg3nHC2lO8i7yGYK0fNfNoNdhPWg+JlQAC5MdsorLFjnlMyEICSs9/v+x X-Received: by 2002:a05:6402:748:: with SMTP id p8mr14775661edy.305.1598434600317; Wed, 26 Aug 2020 02:36:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598434600; cv=none; d=google.com; s=arc-20160816; b=owa9TKgcTlLl1JBnAxbNhj7GOrrHgB/+JeCkq4nrQN6RyXVXKAuEpR59EaDeGO8nWb 2AAsa/ns80UnRQ+TtT7OJ/JIfCvYatzzdI3dkdhyPFmzCRACvReJsFmcjB2oLtg1o49b DRotFZS8/GqOBuTQWz0CtvOBfla8t4qmvC7wTvfE7ftlX2EOytCaKY7Ha+g36LpKDjo4 iL235jkUitRXiG7Gb+xkfYBSF5jQW3ZwkofXkGkmsBmv7MhKWE1oOuHfavhRmy/Cqu/P 78yrUYStHbCgCRsPp+SG1O8vUDiQu7bJcWpBXO8HVj/CqL9cIIXzOXX/jr4xWdn4WOX3 FSrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=EWWkC93UJ7xj7BkZ2b7U7Aw6lomOHNe1aGRj0IYiNWw=; b=w1P+TVQGElSW2h+7t1+F9lSbW3T2vBYWkLSIQ3yvNSOcEeWhaYzZ4WnSihdtF90Q4Y 4ReQWyV1ZyHgHxIQYo5foWURhWtQJxCRQ/5P2pt+HNjZdCFbX0HZGLODtK2/M9V4B3n8 feyB9+JpeH2HFZPAv33WtEJ67yy5372OGgHmfd/S83+3dqy0Oyu6LIPr6Fnj0dn6Jl5i wg5A00ITJzKYJLQnECdb21ZoDBbcbDz1LOq89scD2WwyxJk4C3XCw/+EPOv60uoKD5kI xikYSLivfVfpvg1M8G4OUCZ1/76LtWeLoLuzWkAbWcScBn+NRYdOGhDlDWetmbO+rJ+7 wV5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="Ajx7/Kr/"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bq25si1204047ejb.730.2020.08.26.02.36.40; Wed, 26 Aug 2020 02:36:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="Ajx7/Kr/"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728467AbgHZJgE (ORCPT + 2 others); Wed, 26 Aug 2020 05:36:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728425AbgHZJfd (ORCPT ); Wed, 26 Aug 2020 05:35:33 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80C6FC061368 for ; Wed, 26 Aug 2020 02:34:43 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id y3so1098648wrl.4 for ; Wed, 26 Aug 2020 02:34:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EWWkC93UJ7xj7BkZ2b7U7Aw6lomOHNe1aGRj0IYiNWw=; b=Ajx7/Kr/e8GtU4LIIPcwjtWRUh0vF1emJA2VjOu2Gia+48u0R30etyRK1i63xNy7L5 hMXIkmWto3dxWPN8FrOWpBl1pqjQ4dLkksZjPNfxFQVcXIlzVqQH+2wEkDf3NQRTgwJ1 VU8abeFTBhMh0hlrVZhbR1ni0bThPfgm0f0QKIidxW2P9i7yEtiTPcKCU0bqCScTrdJl nxse+3AwcjpD7ic6ZCoxS6GYLOOaAEDg2uwmoAY1N3brpUTSEsFzJ2D3I5FCnyPV8ox1 A+5T6/V5cMM2kr6bgevVjvMLYEjkqjoDNFOlGSuF/tKcGg5cfarQsONjK+8TnMoSEND/ FGjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EWWkC93UJ7xj7BkZ2b7U7Aw6lomOHNe1aGRj0IYiNWw=; b=QxeQoMaUC8WDkVKaU49yuyIgsY/d5pAXFDa5Tbgj1vMZXXNn0kJKCpfJojW5vc15jf UOp04p23QGtdAfLLs9zrNUqZIu+zKDYW18LJ/auXj7Ka53OA47ZY9oaPhlHRvbqj1w3z +ycKOp8rzwgTLIkGuOrT9CvwCb8U20j48qrKz8mXgzysdPWOTWLEgragPTYcsCincEcf 82BdnZ/kNOV324z0tnUaGFm0zLbqkT2TlspeDzO1pP7VIJWXXsdTGloWGl/ZkHtemX1Z 2rwaim6b/qyYaF3weP3G6ABjLrSoSRHlFTitJT2v9LOHngv49UJSQl2czcFc2zcYmY5x SjFg== X-Gm-Message-State: AOAM531jol5RVxpH8N/mAbXKMWND06BnHml9oudpWOnF6+tu/dU4sfJy 2CwfB2rFWVgARgPOW10gN+trVQ== X-Received: by 2002:adf:c453:: with SMTP id a19mr1604492wrg.179.1598434482172; Wed, 26 Aug 2020 02:34:42 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id u3sm3978759wml.44.2020.08.26.02.34.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 02:34:41 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com Subject: [PATCH 30/30] wireless: broadcom: brcm80211: phytbl_n: Remove a few unused arrays Date: Wed, 26 Aug 2020 10:34:01 +0100 Message-Id: <20200826093401.1458456-31-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200826093401.1458456-1-lee.jones@linaro.org> References: <20200826093401.1458456-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phytbl_n.c:9218:18: warning: ‘papd_cal_scalars_tbl_core1_rev3’ defined but not used [-Wunused-const-variable=] drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phytbl_n.c:9151:18: warning: ‘papd_comp_epsilon_tbl_core1_rev3’ defined but not used [-Wunused-const-variable=] drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phytbl_n.c:9084:18: warning: ‘papd_cal_scalars_tbl_core0_rev3’ defined but not used [-Wunused-const-variable=] drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phytbl_n.c:9017:18: warning: ‘papd_comp_epsilon_tbl_core0_rev3’ defined but not used [-Wunused-const-variable=] Cc: Arend van Spriel Cc: Franky Lin Cc: Hante Meuleman Cc: Chi-Hsien Lin Cc: Wright Feng Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: brcm80211-dev-list.pdl@broadcom.com Cc: brcm80211-dev-list@cypress.com Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- .../brcm80211/brcmsmac/phy/phytbl_n.c | 268 ------------------ 1 file changed, 268 deletions(-) -- 2.25.1 diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phytbl_n.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phytbl_n.c index 7607e67d20c75..396d005f4d165 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phytbl_n.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phytbl_n.c @@ -9014,274 +9014,6 @@ static const u16 papd_comp_rfpwr_tbl_core1_rev3[] = { 0x01d6, }; -static const u32 papd_comp_epsilon_tbl_core0_rev3[] = { - 0x00000000, - 0x00001fa0, - 0x00019f78, - 0x0001df7e, - 0x03fa9f86, - 0x03fd1f90, - 0x03fe5f8a, - 0x03fb1f94, - 0x03fd9fa0, - 0x00009f98, - 0x03fd1fac, - 0x03ff9fa2, - 0x03fe9fae, - 0x00001fae, - 0x03fddfb4, - 0x03ff1fb8, - 0x03ff9fbc, - 0x03ffdfbe, - 0x03fe9fc2, - 0x03fedfc6, - 0x03fedfc6, - 0x03ff9fc8, - 0x03ff5fc6, - 0x03fedfc2, - 0x03ff9fc0, - 0x03ff5fac, - 0x03ff5fac, - 0x03ff9fa2, - 0x03ff9fa6, - 0x03ff9faa, - 0x03ff5fb0, - 0x03ff5fb4, - 0x03ff1fca, - 0x03ff5fce, - 0x03fcdfdc, - 0x03fb4006, - 0x00000030, - 0x03ff808a, - 0x03ff80da, - 0x0000016c, - 0x03ff8318, - 0x03ff063a, - 0x03fd8bd6, - 0x00014ffe, - 0x00034ffe, - 0x00034ffe, - 0x0003cffe, - 0x00040ffe, - 0x00040ffe, - 0x0003cffe, - 0x0003cffe, - 0x00020ffe, - 0x03fe0ffe, - 0x03fdcffe, - 0x03f94ffe, - 0x03f54ffe, - 0x03f44ffe, - 0x03ef8ffe, - 0x03ee0ffe, - 0x03ebcffe, - 0x03e8cffe, - 0x03e74ffe, - 0x03e4cffe, - 0x03e38ffe, -}; - -static const u32 papd_cal_scalars_tbl_core0_rev3[] = { - 0x05af005a, - 0x0571005e, - 0x05040066, - 0x04bd006c, - 0x047d0072, - 0x04430078, - 0x03f70081, - 0x03cb0087, - 0x03870091, - 0x035e0098, - 0x032e00a1, - 0x030300aa, - 0x02d800b4, - 0x02ae00bf, - 0x028900ca, - 0x026400d6, - 0x024100e3, - 0x022200f0, - 0x020200ff, - 0x01e5010e, - 0x01ca011e, - 0x01b0012f, - 0x01990140, - 0x01830153, - 0x016c0168, - 0x0158017d, - 0x01450193, - 0x013301ab, - 0x012101c5, - 0x011101e0, - 0x010201fc, - 0x00f4021a, - 0x00e6011d, - 0x00d9012e, - 0x00cd0140, - 0x00c20153, - 0x00b70167, - 0x00ac017c, - 0x00a30193, - 0x009a01ab, - 0x009101c4, - 0x008901df, - 0x008101fb, - 0x007a0219, - 0x00730239, - 0x006d025b, - 0x0067027e, - 0x006102a4, - 0x005c02cc, - 0x005602f6, - 0x00520323, - 0x004d0353, - 0x00490385, - 0x004503bb, - 0x004103f3, - 0x003d042f, - 0x003a046f, - 0x003704b2, - 0x003404f9, - 0x00310545, - 0x002e0596, - 0x002b05f5, - 0x00290640, - 0x002606a4, -}; - -static const u32 papd_comp_epsilon_tbl_core1_rev3[] = { - 0x00000000, - 0x00001fa0, - 0x00019f78, - 0x0001df7e, - 0x03fa9f86, - 0x03fd1f90, - 0x03fe5f8a, - 0x03fb1f94, - 0x03fd9fa0, - 0x00009f98, - 0x03fd1fac, - 0x03ff9fa2, - 0x03fe9fae, - 0x00001fae, - 0x03fddfb4, - 0x03ff1fb8, - 0x03ff9fbc, - 0x03ffdfbe, - 0x03fe9fc2, - 0x03fedfc6, - 0x03fedfc6, - 0x03ff9fc8, - 0x03ff5fc6, - 0x03fedfc2, - 0x03ff9fc0, - 0x03ff5fac, - 0x03ff5fac, - 0x03ff9fa2, - 0x03ff9fa6, - 0x03ff9faa, - 0x03ff5fb0, - 0x03ff5fb4, - 0x03ff1fca, - 0x03ff5fce, - 0x03fcdfdc, - 0x03fb4006, - 0x00000030, - 0x03ff808a, - 0x03ff80da, - 0x0000016c, - 0x03ff8318, - 0x03ff063a, - 0x03fd8bd6, - 0x00014ffe, - 0x00034ffe, - 0x00034ffe, - 0x0003cffe, - 0x00040ffe, - 0x00040ffe, - 0x0003cffe, - 0x0003cffe, - 0x00020ffe, - 0x03fe0ffe, - 0x03fdcffe, - 0x03f94ffe, - 0x03f54ffe, - 0x03f44ffe, - 0x03ef8ffe, - 0x03ee0ffe, - 0x03ebcffe, - 0x03e8cffe, - 0x03e74ffe, - 0x03e4cffe, - 0x03e38ffe, -}; - -static const u32 papd_cal_scalars_tbl_core1_rev3[] = { - 0x05af005a, - 0x0571005e, - 0x05040066, - 0x04bd006c, - 0x047d0072, - 0x04430078, - 0x03f70081, - 0x03cb0087, - 0x03870091, - 0x035e0098, - 0x032e00a1, - 0x030300aa, - 0x02d800b4, - 0x02ae00bf, - 0x028900ca, - 0x026400d6, - 0x024100e3, - 0x022200f0, - 0x020200ff, - 0x01e5010e, - 0x01ca011e, - 0x01b0012f, - 0x01990140, - 0x01830153, - 0x016c0168, - 0x0158017d, - 0x01450193, - 0x013301ab, - 0x012101c5, - 0x011101e0, - 0x010201fc, - 0x00f4021a, - 0x00e6011d, - 0x00d9012e, - 0x00cd0140, - 0x00c20153, - 0x00b70167, - 0x00ac017c, - 0x00a30193, - 0x009a01ab, - 0x009101c4, - 0x008901df, - 0x008101fb, - 0x007a0219, - 0x00730239, - 0x006d025b, - 0x0067027e, - 0x006102a4, - 0x005c02cc, - 0x005602f6, - 0x00520323, - 0x004d0353, - 0x00490385, - 0x004503bb, - 0x004103f3, - 0x003d042f, - 0x003a046f, - 0x003704b2, - 0x003404f9, - 0x00310545, - 0x002e0596, - 0x002b05f5, - 0x00290640, - 0x002606a4, -}; - const struct phytbl_info mimophytbl_info_rev3_volatile[] = { {&ant_swctrl_tbl_rev3, ARRAY_SIZE(ant_swctrl_tbl_rev3), 9, 0, 16}, };