From patchwork Fri Aug 21 05:38:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?TGlnaHQgSHNpZWggKOisneaYjueHiCk=?= X-Patchwork-Id: 254590 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, MIME_BASE64_TEXT, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, UNPARSEABLE_RELAY,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56ADAC433E1 for ; Fri, 21 Aug 2020 05:38:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2FD78214F1 for ; Fri, 21 Aug 2020 05:38:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="IYw1w3cH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725968AbgHUFis (ORCPT ); Fri, 21 Aug 2020 01:38:48 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:37738 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725908AbgHUFis (ORCPT ); Fri, 21 Aug 2020 01:38:48 -0400 X-UUID: 0618d1d1f11b45cf98e9d0dbab0534b4-20200821 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:Date:Subject:CC:To:From; bh=plhV+IOc33r8xOeQyemErFzpqgMxm8+GRbRdLCyz3ks=; b=IYw1w3cHBysJPBszx3dvF2/yJxCYQdmpJFKN1dWkojOl1xoSyQRDsVqX2GtXBJUumI8TIaYL7OGb8Q538W3wUFWubFrf32uFHlYylX1J2XM0aFk+fkcxr9ZdiTpwaNKL+FgxXzk8yJq728ENE/fPa1uDbehJASrm+zzh5P5kwNo=; X-UUID: 0618d1d1f11b45cf98e9d0dbab0534b4-20200821 Received: from mtkcas08.mediatek.inc [(172.21.101.126)] by mailgw02.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 1114795160; Fri, 21 Aug 2020 13:38:45 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs08n2.mediatek.inc (172.21.101.56) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 21 Aug 2020 13:38:38 +0800 Received: from mtkswgap22.mediatek.inc (172.21.77.33) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 21 Aug 2020 13:38:38 +0800 From: To: CC: , , , , , Light Hsieh Subject: [PATCH v1 1/1] pinctrl: mediatek: remove log message in mtk_hw_pin_field_lookup Date: Fri, 21 Aug 2020 13:38:38 +0800 Message-ID: <1597988318-24944-1-git-send-email-light.hsieh@mediatek.com> X-Mailer: git-send-email 1.8.1.1.dirty MIME-Version: 1.0 X-TM-SNTS-SMTP: 888BF03EA216EF90D2412ABF7D47198C0C2C8BF5E24ACCF6310F5085B41C0D122000:8 X-MTK: N Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org From: Light Hsieh Originally, mtk_hw_pin_field_lookup() print log message in 2 conditions: 1. when soc does not support target property 2. when target pin does not support target property Now, mtk_hw_pin_field_lookup() does not print log message according to the following rationale: 1. Users of pinctrl have the duty to pass correct parameters and check return vale. After checking return value, the users can determine if log message shall be printed according to users' scenario. 2. Prevent message flooding when a bad user continously pass bad parameters to pinctrl. Signed-off-by: Light Hsieh --- drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) -- 1.8.1.1.dirty diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c index 2f3dfb5..161d4eb 100644 --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c @@ -74,13 +74,10 @@ static int mtk_hw_pin_field_lookup(struct mtk_pinctrl *hw, bool found = false; u32 bits; - if (hw->soc->reg_cal && hw->soc->reg_cal[field].range) { + if (hw->soc->reg_cal && hw->soc->reg_cal[field].range) rc = &hw->soc->reg_cal[field]; - } else { - dev_dbg(hw->dev, - "Not support field %d for this soc\n", field); + else return -ENOTSUPP; - } end = rc->nranges - 1; @@ -98,11 +95,8 @@ static int mtk_hw_pin_field_lookup(struct mtk_pinctrl *hw, start = check + 1; } - if (!found) { - dev_dbg(hw->dev, "Not support field %d for pin = %d (%s)\n", - field, desc->number, desc->name); + if (!found) return -ENOTSUPP; - } c = rc->range + check;