From patchwork Thu Sep 3 04:43:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 255018 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E38A5C433E2 for ; Thu, 3 Sep 2020 04:43:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B9D6A20716 for ; Thu, 3 Sep 2020 04:43:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="HxyIm4L5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725966AbgICEnN (ORCPT ); Thu, 3 Sep 2020 00:43:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725851AbgICEnM (ORCPT ); Thu, 3 Sep 2020 00:43:12 -0400 Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 637D1C061244 for ; Wed, 2 Sep 2020 21:43:11 -0700 (PDT) Received: by mail-pf1-x442.google.com with SMTP id f18so1221500pfa.10 for ; Wed, 02 Sep 2020 21:43:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ujAveOaaBdyq96Z9dyNuykpAuBn9CZjmoC9iNupYh6s=; b=HxyIm4L5zMFVFnsyDYvn3sqwdawBG4xlyQ9mc2VcvPEEzD+aPLCyxc8yS9SLibp30G CgfLUocFzE3AvHEUbRSh+dY73taKKlTF3IgZq/93F5USgv1PVL4mgZcnJ+RaGlt1Mw57 NCdqdIJmw772VeH03O1dmCEB6IX8qnU5urVhE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ujAveOaaBdyq96Z9dyNuykpAuBn9CZjmoC9iNupYh6s=; b=XjrclIMauKyPlz5KxT+x4tquhFbxGHWxQilDGM+nR0Xgjxyju1PRfhgYM/bmWcqIk3 ZOCJtwnwmPfDxszlyHM/3hrBCreo2w1DxQ9n842vHIb3gHezNBgj25BUQor7oiE5wLff Iv99Yw9op1HqqIzaH5n4CW9iJ4mVtVubPU5vphEdAP1WoiW+cllpT7G3bUve4Zo+577u CZffZJ6xGvupVj3Vzi0XMi4BncNNw8dz+Zza0Q9WM5IeSbMNsa0I478qZeLXdso5ueRa Dkr+wBCSKBfZeiMNm4tBGtcVv2uuajJW1vhlrDbJltvjBREFxk6NIm+LozvtuiPL5Ztk y5eQ== X-Gm-Message-State: AOAM531b6MCZYuUOaNjYWfusArKGqYsdYeGTN8xNqJPs3fY+4DKj46SF opUQdESjp+iWEa665vTshQnnDQ== X-Google-Smtp-Source: ABdhPJzPDJi+mUaZKseRY+d6FfXdEB6IDIHsARy6IMBCmGx44gf2A4Nf4vZaOTrRIHiNU/jVPUugog== X-Received: by 2002:a63:e347:: with SMTP id o7mr1288507pgj.143.1599108190812; Wed, 02 Sep 2020 21:43:10 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:42b0:34ff:fe3d:58e6]) by smtp.gmail.com with ESMTPSA id q190sm1236687pfc.176.2020.09.02.21.43.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Sep 2020 21:43:10 -0700 (PDT) From: Douglas Anderson To: Jiri Kosina Cc: Hans de Goede , Andrea Borgia , Kai-Heng Feng , Dmitry Torokhov , Douglas Anderson , Aaron Ma , Benjamin Tissoires , Daniel Playfair Cal , Pavel Balan , You-Sheng Yang , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] HID: i2c-hid: Prefer asynchronous probe Date: Wed, 2 Sep 2020 21:43:02 -0700 Message-Id: <20200902214250.1.I63d3f1c93f88cb0cda5161c42e97decb4a63a571@changeid> X-Mailer: git-send-email 2.28.0.402.g5ffc5be6b7-goog MIME-Version: 1.0 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Adding printouts to the i2c_hid_probe() function shows that it takes quite some time. It used to take about 70 ms, but after commit eef4016243e9 ("HID: i2c-hid: Always sleep 60ms after I2C_HID_PWR_ON commands") it takes about 190 ms. This is not tons of time but it's not trivial. Because we haven't yet specified that we'd prefer asynchronous probe for this driver then, if the driver is builtin to the kernel, we'll wait for this driver to finish before we start probes for more drivers. Let's set the flag to enable asynchronous for this driver so that other drivers aren't blocked from probing until we finish. Since this driver can be configured as a module and modules are always asynchronously probed this is quite a safe change and will benefit anyone who has a reason to build this driver into the kernel instead of using it as a module. Signed-off-by: Douglas Anderson --- drivers/hid/i2c-hid/i2c-hid-core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/hid/i2c-hid/i2c-hid-core.c b/drivers/hid/i2c-hid/i2c-hid-core.c index 87ff93bf76ba..c898bd8617f9 100644 --- a/drivers/hid/i2c-hid/i2c-hid-core.c +++ b/drivers/hid/i2c-hid/i2c-hid-core.c @@ -1280,8 +1280,10 @@ static struct i2c_driver i2c_hid_driver = { .driver = { .name = "i2c_hid", .pm = &i2c_hid_pm, + .probe_type = PROBE_PREFER_ASYNCHRONOUS, .acpi_match_table = ACPI_PTR(i2c_hid_acpi_match), .of_match_table = of_match_ptr(i2c_hid_of_match), + }, .probe = i2c_hid_probe,