From patchwork Wed Oct 18 18:42:44 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Denys Dmytriyenko X-Patchwork-Id: 116320 Delivered-To: patch@linaro.org Received: by 10.140.22.163 with SMTP id 32csp6380091qgn; Wed, 18 Oct 2017 11:42:57 -0700 (PDT) X-Google-Smtp-Source: AOwi7QBOx9yuI4z92zXbVh1jgMByQo4O3Ghd3pYhtG7Nv9ZsxC9TIp4SryODS0wMq5wLszA4xINS X-Received: by 10.99.63.199 with SMTP id m190mr14588956pga.275.1508352177650; Wed, 18 Oct 2017 11:42:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1508352177; cv=none; d=google.com; s=arc-20160816; b=pvLgPzdf+jGoC/+ISjfXQkoOewhgEHhw0E/qgxrAZIx52oYndj1ZriSgoeByp/TiaV rMDeMHvnVGBFu0iD8ytXsJsL4Er+FbfAdzE/DGQ941NZXWi/tYPVZteUjVzYVVziGun5 uFvBOjTD6EpIAvzHkW2uekduCWSv6IYlXCv6MoaH7jPJdyZyhjKdLJj0+GPebhLYobh1 h1J8M6AiCX1zmQBPdgQY8wGpZgBk4SwhDuleUbaonboEkw7M81qDOu2R6bJprRNF7pA1 WWkbxz42zycZI28OhFSmMbtQybqBDEJAdZ/C3xvOI59Wd1a4JKZdA63i0R6A4w37j0nX du6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:message-id:date:to:from:delivered-to :arc-authentication-results; bh=9/nNatQsJt6Yz3QddNfSLxv0O0zvUJhcstwFbmtHk+c=; b=cNQml8ylY8DxDnEh7sUrlA1kXEoxfxkAR4onsvHadIkLcWYQzq51pd/m4/MAMpYzOp S4WDwMSAZ6tDN8vJeyOCzujR6JfnGF0g1BnMCma71vLDX8Z9MyHO2GDUP0Mvq26clV2K QwspOCiq1KMG84aCKb4Y4QAuK+HcnvAyS+OxYbNqRRNvGFH7v+SulBmrTiIc5jGEJWtO eZVNbhraB8qZq48rJ0N46cuckEcROJ9LTAtEWf8+TAhN93mSXeV7qycG4HAjHajYkp+V rAHqzgHS4WG7DfqxyfMoB5qbWKcY46W+QT5hl99ni3AQV0ccnoJVDYz5HREHeKGopH7G jdLQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of openembedded-devel-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-devel-bounces@lists.openembedded.org Return-Path: Received: from mail.openembedded.org (mail.openembedded.org. [140.211.169.62]) by mx.google.com with ESMTP id j21si7323900pgn.484.2017.10.18.11.42.56; Wed, 18 Oct 2017 11:42:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of openembedded-devel-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) client-ip=140.211.169.62; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of openembedded-devel-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-devel-bounces@lists.openembedded.org Received: from review.yoctoproject.org (localhost [127.0.0.1]) by mail.openembedded.org (Postfix) with ESMTP id 836A578305; Wed, 18 Oct 2017 18:42:50 +0000 (UTC) X-Original-To: openembedded-devel@lists.openembedded.org Delivered-To: openembedded-devel@lists.openembedded.org Received: from mailout4.zoneedit.com (mailout4.zoneedit.com [64.68.198.17]) by mail.openembedded.org (Postfix) with ESMTP id 65E7571AB5 for ; Wed, 18 Oct 2017 18:42:48 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mailout4.zoneedit.com (Postfix) with ESMTP id AE565208CF; Wed, 18 Oct 2017 18:42:49 +0000 (UTC) Received: from mailout4.zoneedit.com ([127.0.0.1]) by localhost (zmo03-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vj7j2h_obtZh; Wed, 18 Oct 2017 18:42:49 +0000 (UTC) Received: from mail.denix.org (pool-100-15-85-143.washdc.fios.verizon.net [100.15.85.143]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mailout4.zoneedit.com (Postfix) with ESMTPSA id 8C1672010C; Wed, 18 Oct 2017 18:42:48 +0000 (UTC) Received: from gimli.denix (gimli [192.168.0.6]) by mail.denix.org (Postfix) with ESMTP id 093611626FE; Wed, 18 Oct 2017 14:42:48 -0400 (EDT) From: Denys Dmytriyenko To: openembedded-devel@lists.openembedded.org Date: Wed, 18 Oct 2017 14:42:44 -0400 Message-Id: <1508352164-79210-1-git-send-email-denis@denix.org> X-Mailer: git-send-email 2.7.4 Cc: Denys Dmytriyenko Subject: [oe] [meta-qt5][PATCH v2] qt5-ptest.inc: fix qtxmlpatterns:do_install_ptest out-of-order call X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: openembedded-devel-bounces@lists.openembedded.org Errors-To: openembedded-devel-bounces@lists.openembedded.org From: Denys Dmytriyenko ptest.bbclass provides a set of standard do_*_ptest_base tasks. Each of them calls a corresponding regular do_*_ptest task, that components are supposed to override for own implementation. When PTEST_ENABLED is not set, an anonymous python function removes all do_*_ptest_base tasks from the queue. qt5-ptest.inc adds a special case for do_populate_sysroot and re-arranges the order or ptest tasks due to that. But, unfortunately, do_install_ptest was added directly, not do_install_ptest_base, hence when "ptest" is disabled and all other do_*_ptest_base tasks are removed, this one do_install_ptest task is left w/o dependencies and gets scheduled for execution very early on, even before pseudo-native gets built and stages "fakeroot" functionality. The fix is to add do_install_ptest_base task, which calls do_install_ptest only when "ptest" is enabled. Signed-off-by: Denys Dmytriyenko --- v2 - fix circular dependencies, delete default do_install_ptest_base recipes-qt/qt5/qt5-ptest.inc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- 2.7.4 -- _______________________________________________ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel diff --git a/recipes-qt/qt5/qt5-ptest.inc b/recipes-qt/qt5/qt5-ptest.inc index 4844878..97bce88 100644 --- a/recipes-qt/qt5/qt5-ptest.inc +++ b/recipes-qt/qt5/qt5-ptest.inc @@ -4,8 +4,9 @@ inherit ptest addtask do_populate_sysroot after do_install before do_compile_ptest_base deltask do_compile_ptest_base -addtask do_compile_ptest_base after do_populate_sysroot before do_install_ptest -addtask do_install_ptest after do_compile_ptest_base before do_package +addtask do_compile_ptest_base after do_populate_sysroot before do_install_ptest_base +deltask do_install_ptest_base +addtask do_install_ptest_base after do_compile_ptest_base before do_package do_compile_ptest() { cd ${S}/tests