From patchwork Mon Oct 12 17:09:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 303068 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6933C433E7 for ; Mon, 12 Oct 2020 17:13:16 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4946220838 for ; Mon, 12 Oct 2020 17:13:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Azk7yZjP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4946220838 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45090 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kS1Nr-0007Vy-CE for qemu-devel@archiver.kernel.org; Mon, 12 Oct 2020 13:13:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50938) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kS1Kj-00032r-AN for qemu-devel@nongnu.org; Mon, 12 Oct 2020 13:10:01 -0400 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]:42516) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kS1Kg-0002f9-B9 for qemu-devel@nongnu.org; Mon, 12 Oct 2020 13:10:00 -0400 Received: by mail-wr1-x42f.google.com with SMTP id e18so20009164wrw.9 for ; Mon, 12 Oct 2020 10:09:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=K/0FGZZwlPzFsD7CDw6LNpeg+vGvRuv9FXjLqVDCM3o=; b=Azk7yZjPF6VVj+hqVlAB5HhEANYY+vQUs6Csf9I93BqimulxncYmv9zvzODaZSTEzf 9hdtmDhHtdMIXPCaBfFBhoSwMEyH6n6LSCtH0od5uZXCg9IFjUlNtyb1ESISX2ZYbLNf ciS73zcuYuIAvm/D3lS6nc06y5q1X7fgOYsV1gl0PmpPDCOJ/aX0aROz/EbaBIVLNBrH gw8iD26PzrmvUM7mqcUqABWjsd0C0J5SOKi/+DE4t8yXqaB2FzXUhH4gnm4aXjUFbPIE S9evP92w992zx2IsczO41kxsSrG8vcTT7ocFxgUNn0QPe0EF/CcOBOTI2GXqLxgAkXfi Xeqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=K/0FGZZwlPzFsD7CDw6LNpeg+vGvRuv9FXjLqVDCM3o=; b=eKVD7Z7yuqF8uhUrY8wV1oaMOxbdnHGsVUOgeY4Uf0XU2muqZqw09gNRX0j5aLz0Xt a8aHUNN2pMgEivVJdHhiR239HAIxw9SrYoZwp+cI0PSFmtVzXouA12xfz6nWP7ZtChsW JEI9XB8DVK7NbngqrKb3vDfpANtU3n2D4KsLCu2zma+UsgS4UJFr/KLyqPeEMRxIHMyX BVLnNKOGsh4T1MYzTnDHv8TITbPrSXQn3oddwrpwTuazjji2VRy8uRk+CtpMf2ontgqH ai2Pphje1JQBHOQsMF+U3Bgm6pV7dPOh7NQYs0iY1aSb4z2tsCFnD5OKfKenfw51fpEg IDRg== X-Gm-Message-State: AOAM532I/cG08DJCc0ebitEFiIS+MpMq1rLK18mJmDAyeJESBS9/UyGP w7CV69T6RP0MOJfcQeg4Mv9gIXTbnRY= X-Google-Smtp-Source: ABdhPJxQierGOMFl3ECY9FPz8M/NsDmtmT0d+XkIPtxvqdy28hHcR68zgD7Y4DwyrnukoDuJ+hJ/kA== X-Received: by 2002:adf:ff8e:: with SMTP id j14mr20584353wrr.255.1602522596794; Mon, 12 Oct 2020 10:09:56 -0700 (PDT) Received: from localhost.localdomain (106.red-83-59-162.dynamicip.rima-tde.net. [83.59.162.106]) by smtp.gmail.com with ESMTPSA id g139sm25872629wme.2.2020.10.12.10.09.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Oct 2020 10:09:56 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 1/6] hw/pci-host/sabre: Update documentation link Date: Mon, 12 Oct 2020 19:09:45 +0200 Message-Id: <20201012170950.3491912-2-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201012170950.3491912-1-f4bug@amsat.org> References: <20201012170950.3491912-1-f4bug@amsat.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x42f.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Cave-Ayland , =?utf-8?q?Philippe_M?= =?utf-8?q?athieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" The current link redirects to https://www.oracle.com/sun/ announcing "Oracle acquired Sun Microsystems in 2010, ..." but does not give hint where to find the datasheet. Use the archived PDF on the Wayback Machine, which works. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Mark Cave-Ayland --- hw/pci-host/sabre.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci-host/sabre.c b/hw/pci-host/sabre.c index 5ac62836238..3634f8369b7 100644 --- a/hw/pci-host/sabre.c +++ b/hw/pci-host/sabre.c @@ -44,7 +44,7 @@ /* * Chipset docs: * PBM: "UltraSPARC IIi User's Manual", - * http://www.sun.com/processors/manuals/805-0087.pdf + * https://web.archive.org/web/20030403110020/http://www.sun.com/processors/manuals/805-0087.pdf */ #define PBM_PCI_IMR_MASK 0x7fffffff From patchwork Mon Oct 12 17:09:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 303067 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D889C433E7 for ; Mon, 12 Oct 2020 17:14:50 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 363C620838 for ; Mon, 12 Oct 2020 17:14:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lziW4pza" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 363C620838 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50816 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kS1PN-0001RJ-E0 for qemu-devel@archiver.kernel.org; Mon, 12 Oct 2020 13:14:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50962) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kS1Km-000364-DR for qemu-devel@nongnu.org; Mon, 12 Oct 2020 13:10:04 -0400 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]:39172) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kS1Kk-0002gA-Sq for qemu-devel@nongnu.org; Mon, 12 Oct 2020 13:10:04 -0400 Received: by mail-wr1-x442.google.com with SMTP id y12so14659324wrp.6 for ; Mon, 12 Oct 2020 10:10:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vwsOKhAW+74BD2GAbdrqNd+j5DzxxpKUr1mlTm/twmU=; b=lziW4pza2F6T+QKnv7EF2LTo5wcWsiGfZKFxkkOcfrTNGVeDH3Ug/jwW/gNrDRgfZK d3+dOrkVH6ArESqdgE+p1J+TdR85UMubWwUO6fdtaHky+RlTHfsS7IduqKE1KlQ8o19P BvAtoalgINGOnbnqwW4PIFMcnCIVqoVjntYex+cuLZRj2fakatGATBX2Z4+054Y6Yxxq ee+3Cy+VOwgce/9Q19ed+FumSCheLEcHj92RUwsuzDtM0Bd0xvVvkTiXGlTfKUZt7weo xJ4IlVrHC011EgKBCRz3FSgWroaFfdBTnbm1UGezkLZ/7ZhEmThTCxHi/NMFOObGwRS7 +fXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=vwsOKhAW+74BD2GAbdrqNd+j5DzxxpKUr1mlTm/twmU=; b=sq1qpNQ0ucirleo/BurcSVlhbV3wKgvE8GmhVmVHCJIr6eMK50qDmbQ/efmYmGJP3b guEFkGiSoYvQ0fFfHa4WukakCGocL2Mh9DNKKbZjKRY6Sv8lL7xB4jCGuI9KxD1X37ap XGwmsn3CJs2sSMXFpmlD5clzfJsxtlvWEGyz8XSA4qBg4RG0nOGn466anYoTYZxEBPbf NPNNPHNm2y53vGq5eT5g1MQdbqU78Oe+l3EQ/88k+eRJzzK4RyvGxLrNmncVjwbjbO1N St0xCKQWWppB+Gf/i9YcQoprISm8VZdl1c/JxK/suVYQi0EpYZJM+G/5A5j0j0/xsgSw wMQA== X-Gm-Message-State: AOAM533fRxGZIVh9hYtufMJYxBPUTLQw2R6enVoh0lcaaLCtyZxOAK7G GCMl0J4ypZQrFuuE/h/H1VEE6NLfPuw= X-Google-Smtp-Source: ABdhPJys3cOIo3gINMhbNO3UuWTjUtkGT55PGq+YoebOdjTOBR+G6+jqzsFfrD7Jc5srWX0hVA7bxg== X-Received: by 2002:adf:912e:: with SMTP id j43mr30782924wrj.325.1602522601253; Mon, 12 Oct 2020 10:10:01 -0700 (PDT) Received: from localhost.localdomain (106.red-83-59-162.dynamicip.rima-tde.net. [83.59.162.106]) by smtp.gmail.com with ESMTPSA id p13sm24200745wmb.5.2020.10.12.10.10.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Oct 2020 10:10:00 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 2/6] hw/pci-host/sabre: Remove superfluous address range check Date: Mon, 12 Oct 2020 19:09:46 +0200 Message-Id: <20201012170950.3491912-3-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201012170950.3491912-1-f4bug@amsat.org> References: <20201012170950.3491912-1-f4bug@amsat.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::442; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x442.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Cave-Ayland , =?utf-8?q?Philippe_M?= =?utf-8?q?athieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" The region is registered as 64KiB in sabre_init(): memory_region_init_io(&s->sabre_config, OBJECT(s), &sabre_config_ops, s, "sabre-config", 0x10000); Remove the superfluous check. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Mark Cave-Ayland --- hw/pci-host/sabre.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/pci-host/sabre.c b/hw/pci-host/sabre.c index 3634f8369b7..0889c9369f6 100644 --- a/hw/pci-host/sabre.c +++ b/hw/pci-host/sabre.c @@ -120,7 +120,7 @@ static void sabre_config_write(void *opaque, hwaddr addr, trace_sabre_config_write(addr, val); - switch (addr & 0xffff) { + switch (addr) { case 0x30 ... 0x4f: /* DMA error registers */ /* XXX: not implemented yet */ break; @@ -197,7 +197,7 @@ static uint64_t sabre_config_read(void *opaque, SabreState *s = opaque; uint32_t val; - switch (addr & 0xffff) { + switch (addr) { case 0x30 ... 0x4f: /* DMA error registers */ val = 0; /* XXX: not implemented yet */ From patchwork Mon Oct 12 17:09:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 271474 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2447C433E7 for ; Mon, 12 Oct 2020 17:11:47 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3119320878 for ; Mon, 12 Oct 2020 17:11:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qculCezz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3119320878 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38642 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kS1MQ-0004tV-9K for qemu-devel@archiver.kernel.org; Mon, 12 Oct 2020 13:11:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50986) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kS1Kq-0003AL-PC for qemu-devel@nongnu.org; Mon, 12 Oct 2020 13:10:08 -0400 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]:38871) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kS1Kp-0002gw-8L for qemu-devel@nongnu.org; Mon, 12 Oct 2020 13:10:08 -0400 Received: by mail-wr1-x42c.google.com with SMTP id n18so20033769wrs.5 for ; Mon, 12 Oct 2020 10:10:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=u3qL4sMDH/Dtxtrv1yhVgK7r2RReEwtHtQeIMbIgt3M=; b=qculCezzeD43ig0+I83rawGeWv6OJTl8Z3uEMRe8vAk2ALOqMMnXDnULec4QESxgBl tPqDER1gzLmj/NVg23d5c8Ummt2E8HU3PzCAZYGZ7CY5crt/ruKPOHBjAG5pkD90Xns7 zxKqjdsJUaDk6/lt+rnHLLiB5P58sigWEDbg31oS4J12t7Rr35ehYsy6GPSJcLn7RPLX 1i3GS4iOHFzhi4irFKb/JO1MzqTaafPrkCMKAlB9aziHLN3VH9z8eM9JEschc34MWRlc MQsHzkVc3V8Jn1zNeLVlv8ffE3xucCrBREia3UlmPlvMk/14hC3pfg4VE/itcRPm3DcV OaHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=u3qL4sMDH/Dtxtrv1yhVgK7r2RReEwtHtQeIMbIgt3M=; b=ZNqlpL1+QO/myxyVuj8vxIhl5BSuYZ4ifd6n+vWT1GtVNwsMtRN8mAlY3G/9EzBTJL IYqDBarZJO3c4EX/JnlDZgSp6g4XV8HA3f+PNd+vKVqy7UezcCsJy4pO7hiMSKTGjX3A KvtR6LaCUhO64BQNHmiAmpbk0vlK9b5M4kfD+JZxMwulR9XpTzbADMEf8JYO5R0wTzB9 kln20/pbrGnPTeo8x1+mDPdx330CAWvNX6UMgOmvcj6RY+ZwwE0YNX1SsjhzCRzIWXDp SeswToXwsWgKu7Wx49XtvgRi9IJjE9d3IL8MxDoPL6qwfR5eWzt+EvHO9RAasQedGprQ 9d1g== X-Gm-Message-State: AOAM532+fU8nsPF3k+1TM94RHjH4jj5eKW/k1cERVysF1sdJkVPvGimt h2AvU8pgQiGYFCl4sF+WxV3oVfh5Ha0= X-Google-Smtp-Source: ABdhPJx9YarihkbWCLjLA+zauH3C5Ur5TUjz8h6l42q4X7K0ulHNlIBXm9b1PdViTxEjViRGQUF2QQ== X-Received: by 2002:a5d:6143:: with SMTP id y3mr13532957wrt.277.1602522605660; Mon, 12 Oct 2020 10:10:05 -0700 (PDT) Received: from localhost.localdomain (106.red-83-59-162.dynamicip.rima-tde.net. [83.59.162.106]) by smtp.gmail.com with ESMTPSA id y6sm25666395wrt.80.2020.10.12.10.10.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Oct 2020 10:10:05 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 3/6] hw/pci-host/sabre: Simplify code initializing variable once Date: Mon, 12 Oct 2020 19:09:47 +0200 Message-Id: <20201012170950.3491912-4-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201012170950.3491912-1-f4bug@amsat.org> References: <20201012170950.3491912-1-f4bug@amsat.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42c; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x42c.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Cave-Ayland , =?utf-8?q?Philippe_M?= =?utf-8?q?athieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" We only need to zero-initialize 'val' once. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Mark Cave-Ayland --- hw/pci-host/sabre.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/hw/pci-host/sabre.c b/hw/pci-host/sabre.c index 0889c9369f6..3645bc962cb 100644 --- a/hw/pci-host/sabre.c +++ b/hw/pci-host/sabre.c @@ -195,32 +195,25 @@ static uint64_t sabre_config_read(void *opaque, hwaddr addr, unsigned size) { SabreState *s = opaque; - uint32_t val; + uint32_t val = 0; switch (addr) { case 0x30 ... 0x4f: /* DMA error registers */ - val = 0; /* XXX: not implemented yet */ break; case 0xc00 ... 0xc3f: /* PCI interrupt control */ if (addr & 4) { val = s->pci_irq_map[(addr & 0x3f) >> 3]; - } else { - val = 0; } break; case 0x1000 ... 0x107f: /* OBIO interrupt control */ if (addr & 4) { val = s->obio_irq_map[(addr & 0xff) >> 3]; - } else { - val = 0; } break; case 0x1080 ... 0x108f: /* PCI bus error */ if (addr & 4) { val = s->pci_err_irq_map[(addr & 0xf) >> 3]; - } else { - val = 0; } break; case 0x2000 ... 0x202f: /* PCI control */ @@ -229,8 +222,6 @@ static uint64_t sabre_config_read(void *opaque, case 0xf020 ... 0xf027: /* Reset control */ if (addr & 4) { val = s->reset_control; - } else { - val = 0; } break; case 0x5000 ... 0x51cf: /* PIO/DMA diagnostics */ @@ -239,7 +230,6 @@ static uint64_t sabre_config_read(void *opaque, case 0xf000 ... 0xf01f: /* FFB config, memory control */ /* we don't care */ default: - val = 0; break; } trace_sabre_config_read(addr, val); From patchwork Mon Oct 12 17:09:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 303069 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CA15C433E7 for ; Mon, 12 Oct 2020 17:11:51 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DAC5320838 for ; Mon, 12 Oct 2020 17:11:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Tzncg49R" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DAC5320838 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38914 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kS1MT-00050K-Sy for qemu-devel@archiver.kernel.org; Mon, 12 Oct 2020 13:11:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50998) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kS1Ku-0003F7-Tj for qemu-devel@nongnu.org; Mon, 12 Oct 2020 13:10:13 -0400 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]:42863) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kS1Kt-0002hl-Ep for qemu-devel@nongnu.org; Mon, 12 Oct 2020 13:10:12 -0400 Received: by mail-wr1-x443.google.com with SMTP id e18so20009919wrw.9 for ; Mon, 12 Oct 2020 10:10:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=g+ZuN081JnWofgtvw5Xcnn25A8ChgQoZUlp7TAnTGlc=; b=Tzncg49ROC/sfxYjVrVxZ7A+r7tL+fD5nrGLNX8NgPAiDn/wJddqdLgNRfAIaCYioz Aup7mvBGbCcsBnf17lHSZ5qVuQWLxYFsN0sKxtXVBmTenDU/Obh/oHdSN/5X1abvjaB8 2CIQcPJtRe+nbMGb4Rg1zVNCIQgYS/a7vKsztHA9/DSMu9TkzdphaDAUnIWSyvrqXwQN XQzjXpmVByL6g/Z7yGArIOJfbTFofz/feVfBWRRN0f7NqEpP50nGsJaV2+9ClvG3X5WL VrwuQU4LJlUssE6hEYDQSLYzl1W9pPtxfX8aGeSS7jYdbF7uSM9fY14GNwfQ7V32sLLG DMkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=g+ZuN081JnWofgtvw5Xcnn25A8ChgQoZUlp7TAnTGlc=; b=EO95xGAPBJeeUaew0/fo23HbmudXuKZPgZUSmnEWGe+35DhdMBVmDAksXchTeJLxG+ dcn1+OJ3wN8U6nHgiGGOZS/lF5fRx7vZezbE+FlFW78zrlyO5jT036NhVK84Q9NjoARI eLEsbwNgAAARMpLqgfL5tgfBMHs9SeAXdqAcZ7fcyWNNeOM3IiWjoeooCbXdE8cqKG2v Db1KV4kY+a4iuMeW/vm0e/DOXoqjp3cYwhw/09xvaUPzH37K9gBp4T7MNWj1I64c4CMu lEEFX948Wdr28cCaTgs4PccYo5gTr30BChFmvc53jo/VFVjZKKU18ZdNk7dwtv8lvU+Q 0yjw== X-Gm-Message-State: AOAM533eEYiUeOqeuz92mOKiBV29HW/TUD3O10bFzfU7R2ve2q6TZKb3 L+9KSHu1FYJrsXePkvwSLtamjDFtnBk= X-Google-Smtp-Source: ABdhPJxGEj9mYPb+dAW62VOwNvCZDqTYCzRwcgq81RPp+ctwU3YWEo3DuJoWbgOZNW5jblugNRumoQ== X-Received: by 2002:adf:e681:: with SMTP id r1mr1622526wrm.181.1602522609942; Mon, 12 Oct 2020 10:10:09 -0700 (PDT) Received: from localhost.localdomain (106.red-83-59-162.dynamicip.rima-tde.net. [83.59.162.106]) by smtp.gmail.com with ESMTPSA id b5sm3359947wrs.97.2020.10.12.10.10.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Oct 2020 10:10:09 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 4/6] hw/pci-host/sabre: Report unimplemented accesses via UNIMP log_mask Date: Mon, 12 Oct 2020 19:09:48 +0200 Message-Id: <20201012170950.3491912-5-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201012170950.3491912-1-f4bug@amsat.org> References: <20201012170950.3491912-1-f4bug@amsat.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::443; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x443.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Cave-Ayland , =?utf-8?q?Philippe_M?= =?utf-8?q?athieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Report unimplemented register accesses using qemu_log_mask(UNIMP). Signed-off-by: Philippe Mathieu-Daudé --- hw/pci-host/sabre.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/hw/pci-host/sabre.c b/hw/pci-host/sabre.c index 3645bc962cb..4412e23131c 100644 --- a/hw/pci-host/sabre.c +++ b/hw/pci-host/sabre.c @@ -121,8 +121,10 @@ static void sabre_config_write(void *opaque, hwaddr addr, trace_sabre_config_write(addr, val); switch (addr) { - case 0x30 ... 0x4f: /* DMA error registers */ - /* XXX: not implemented yet */ + case 0x30 ... 0x4f: /* DMA error registers */ + qemu_log_mask(LOG_UNIMP, + "%s: Register 0x%02" HWADDR_PRIX " not implemented\n", + __func__, addr); break; case 0xc00 ... 0xc3f: /* PCI interrupt control */ if (addr & 4) { @@ -198,8 +200,10 @@ static uint64_t sabre_config_read(void *opaque, uint32_t val = 0; switch (addr) { - case 0x30 ... 0x4f: /* DMA error registers */ - /* XXX: not implemented yet */ + case 0x30 ... 0x4f: /* DMA error registers */ + qemu_log_mask(LOG_UNIMP, + "%s: Register 0x%02" HWADDR_PRIX " not implemented\n", + __func__, addr); break; case 0xc00 ... 0xc3f: /* PCI interrupt control */ if (addr & 4) { From patchwork Mon Oct 12 17:09:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 271473 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD6DDC433DF for ; Mon, 12 Oct 2020 17:11:52 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 38F6D20838 for ; Mon, 12 Oct 2020 17:11:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NtNvyNRM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 38F6D20838 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39054 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kS1MV-00053c-8P for qemu-devel@archiver.kernel.org; Mon, 12 Oct 2020 13:11:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51016) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kS1L1-0003Kn-LQ for qemu-devel@nongnu.org; Mon, 12 Oct 2020 13:10:21 -0400 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:39176) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kS1Ky-0002is-PU for qemu-devel@nongnu.org; Mon, 12 Oct 2020 13:10:18 -0400 Received: by mail-wr1-x444.google.com with SMTP id y12so14660072wrp.6 for ; Mon, 12 Oct 2020 10:10:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gLKWS8Y8T9sXU+gbSEsaUnFE046T7Q7iWcrjHNDSPUk=; b=NtNvyNRM4x7aQxGrPNbrQKZW4ltl1eJR38nqwUpNbd0/CVRCciWskuvfINpVkwywVb EhQCHZteY4Pb2I1KijKDI5molNPv94ekDuhf5IDR6lMyyy9+s9zXEDy/QBakCoJQjAsC lXyr5CcEN5HJ2mpcRitBf1XzzLtlRlss/L8HY+WMZq7Pq+ZC/jLrNqAXrMC+TTbeROQp Etnw+k0ihnMDBEAeo0jaHL7/G+ezgSk9vE6hu4L+D4idWAbvQJIelGl0fa7hDx0bgkNy 6lkdTJyzvbM/2NcR7/95KGNePe0AERHRFL1SOXDg5B17xHxGdJchvPiOHL+ixtPXBZrF 6Tuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=gLKWS8Y8T9sXU+gbSEsaUnFE046T7Q7iWcrjHNDSPUk=; b=QKearW8xyfuJ0DGR6xEQRaFoKJJaBkpzsRieoXiUbFr8CGt0V4dhUFnuZvMaLViG97 EfcXKObMx/kgyG4MWme1bqgtKQ4NsFNl3p1U0GKz/6g830ucZD/Eiy6rvqMK/bASfa8u HQ5pdtR9IfqBolnhekqlEpGIzrntCmRDpoQR5O2jUfKLXseQcWn+6cNfvbd4JC957JXX naf2jOs5TFWA5UV17ceFDtC3X+FRCc0DGcTTr/QIs1zPoF1RBh7iBuQbxpJT2gic33iI f91WKK3W4Ulh2H1sG/ZRkRODnOnrVVCjxiPXb+xOxyEghdfGfg2on+EwkkyCAbRuXtNy 68Tw== X-Gm-Message-State: AOAM531TVeoFObz5r4pU0AErRD+bJoB4pl2Ty7Vk+Qj0r+kxE0fNsoHq 28AupaX1fSrwwrLk4uMv/WcaNpVm1o4= X-Google-Smtp-Source: ABdhPJxRfwQn2L34y4SvXdgnGyJtQNCbpsc4mV/IiIX1Oqm+KoanB9VUGPBH4+AldnTX7IqHow+4nw== X-Received: by 2002:a5d:4fcc:: with SMTP id h12mr11815107wrw.132.1602522614431; Mon, 12 Oct 2020 10:10:14 -0700 (PDT) Received: from localhost.localdomain (106.red-83-59-162.dynamicip.rima-tde.net. [83.59.162.106]) by smtp.gmail.com with ESMTPSA id w11sm25209231wrs.26.2020.10.12.10.10.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Oct 2020 10:10:13 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 5/6] hw/pci-host/sabre: Report IOMMU address range as unimplemented Date: Mon, 12 Oct 2020 19:09:49 +0200 Message-Id: <20201012170950.3491912-6-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201012170950.3491912-1-f4bug@amsat.org> References: <20201012170950.3491912-1-f4bug@amsat.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::444; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x444.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Cave-Ayland , =?utf-8?q?Philippe_M?= =?utf-8?q?athieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Philippe Mathieu-Daudé --- hw/pci-host/sabre.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/pci-host/sabre.c b/hw/pci-host/sabre.c index 4412e23131c..67699ac9058 100644 --- a/hw/pci-host/sabre.c +++ b/hw/pci-host/sabre.c @@ -122,6 +122,7 @@ static void sabre_config_write(void *opaque, hwaddr addr, switch (addr) { case 0x30 ... 0x4f: /* DMA error registers */ + case 0x200 ... 0x21f: /* IOMMU registers */ qemu_log_mask(LOG_UNIMP, "%s: Register 0x%02" HWADDR_PRIX " not implemented\n", __func__, addr); @@ -201,6 +202,7 @@ static uint64_t sabre_config_read(void *opaque, switch (addr) { case 0x30 ... 0x4f: /* DMA error registers */ + case 0x200 ... 0x21f: /* IOMMU registers */ qemu_log_mask(LOG_UNIMP, "%s: Register 0x%02" HWADDR_PRIX " not implemented\n", __func__, addr); From patchwork Mon Oct 12 17:09:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 271472 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8FAEC433DF for ; Mon, 12 Oct 2020 17:17:07 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3ED1220838 for ; Mon, 12 Oct 2020 17:17:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ah7JfWJu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3ED1220838 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54192 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kS1Ra-0002w1-1y for qemu-devel@archiver.kernel.org; Mon, 12 Oct 2020 13:17:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51048) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kS1L4-0003Mj-Ky for qemu-devel@nongnu.org; Mon, 12 Oct 2020 13:10:23 -0400 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]:36644) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kS1L3-0002pr-6Z for qemu-devel@nongnu.org; Mon, 12 Oct 2020 13:10:22 -0400 Received: by mail-wm1-x342.google.com with SMTP id e2so18255099wme.1 for ; Mon, 12 Oct 2020 10:10:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=T1VyM6vO+/UgLy3YgWrY448pDVaigr36dSzmUkhUC2A=; b=ah7JfWJuVEfIlML4YkqazrwbS7sEXPVCIhdOxoNBXgZsX1PlXbFVgZntXipr8W2lpb 9OQymwbhvVjmyjpF4Ez0RdjTxIhfhK8uR9KqVNMWooaRANbRQMYlpGgllxDBadNRlL0s EP1iD+tjx+c1kD3HQCB8XUf85OwlYxldW4IfW7HFUZEQDq2LNJgjLHAwBGUQWfw0Llaq DPF7QkRHDx6Saqycyvg7E3iJlrwVvf6iMw+Hws1IRLxU3Q9loZ+jbWXh9vsfWiy0PYqc F93b9zOuO0vzW9Pu68qsVRVXWmKpQe36sjVrNr7Jg6nvq0vpgmvl7ZYkBEonj9X6OMyM hvLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=T1VyM6vO+/UgLy3YgWrY448pDVaigr36dSzmUkhUC2A=; b=YURxUqr+GP4M7LCZog2wyue2yEp6hp67ZLAxvVQPO0SotRPnlwmvPod4Bn8L/1Dl2D 58OaNamuzwBxnOmkcTNTqfT/d9pZILmx0oConKB++mXcwkMgyambKSnd4l9uDRUgm6yz Wa3U970qIvTO7iKpa5DwSDqhuf5czGAnBcnZDM/jF+hBSKv78YkGbo71g/RIaDNTEhkw oWoNjANCLg/bMXtlCDRaqi0qpjRltzD7Lhr638QENFmKjTHUm/3w1nLuqEDH1pnX6Ieb ctgktxe//w2xBl66kMZGQIgvU6Us00uzD3K0tTpTT8mIvqfq7vzYPRbAxK4SU2O9G4/p +bCQ== X-Gm-Message-State: AOAM533DZm3GqYXlHfhPc5SNmHpxhgV8GfToIap9Ft8Cavfs3S4FSCXs hTwheBVTLFNpl7ObcXy5X5dRtJ44JCg= X-Google-Smtp-Source: ABdhPJyxdsO9bDHuwTDwO7Z1fZXKTy3M2wfpNQrZ30oneOOWCHxnG40nAkdEInVoXWjVmeAJZFtjfA== X-Received: by 2002:a1c:9ecb:: with SMTP id h194mr11383273wme.140.1602522618940; Mon, 12 Oct 2020 10:10:18 -0700 (PDT) Received: from localhost.localdomain (106.red-83-59-162.dynamicip.rima-tde.net. [83.59.162.106]) by smtp.gmail.com with ESMTPSA id u15sm23106397wml.21.2020.10.12.10.10.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Oct 2020 10:10:18 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 6/6] hw/pci-host/sabre: Log reserved address accesses as GUEST_ERROR Date: Mon, 12 Oct 2020 19:09:50 +0200 Message-Id: <20201012170950.3491912-7-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201012170950.3491912-1-f4bug@amsat.org> References: <20201012170950.3491912-1-f4bug@amsat.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::342; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-x342.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Cave-Ayland , =?utf-8?q?Philippe_M?= =?utf-8?q?athieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Report accesses to reserved registers using qemu_log_mask(GUEST_ERROR). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Mark Cave-Ayland --- hw/pci-host/sabre.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/hw/pci-host/sabre.c b/hw/pci-host/sabre.c index 67699ac9058..cc97c266a57 100644 --- a/hw/pci-host/sabre.c +++ b/hw/pci-host/sabre.c @@ -189,7 +189,11 @@ static void sabre_config_write(void *opaque, hwaddr addr, case 0xa800 ... 0xa80f: /* Interrupt diagnostics */ case 0xf000 ... 0xf01f: /* FFB config, memory control */ /* we don't care */ + break; default: + qemu_log_mask(LOG_GUEST_ERROR, + "%s: Register 0x%04" HWADDR_PRIX " is reserved\n", + __func__, addr); break; } } @@ -235,7 +239,11 @@ static uint64_t sabre_config_read(void *opaque, case 0xa800 ... 0xa80f: /* Interrupt diagnostics */ case 0xf000 ... 0xf01f: /* FFB config, memory control */ /* we don't care */ + break; default: + qemu_log_mask(LOG_GUEST_ERROR, + "%s: Register 0x%04" HWADDR_PRIX " is reserved\n", + __func__, addr); break; } trace_sabre_config_read(addr, val);