From patchwork Mon Sep 14 15:07:11 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 273792 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43133C433E2 for ; Mon, 14 Sep 2020 15:09:39 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CADAF20829 for ; Mon, 14 Sep 2020 15:09:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="aPLyaifR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CADAF20829 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44234 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHq6r-0002I5-Sp for qemu-devel@archiver.kernel.org; Mon, 14 Sep 2020 11:09:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37776) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHq4g-0000bY-Ri for qemu-devel@nongnu.org; Mon, 14 Sep 2020 11:07:22 -0400 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:36608) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kHq4f-0000D2-6u for qemu-devel@nongnu.org; Mon, 14 Sep 2020 11:07:22 -0400 Received: by mail-wr1-x444.google.com with SMTP id z1so50161wrt.3 for ; Mon, 14 Sep 2020 08:07:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WnEEcW5T8TnW3Xg2cKGofSTt8rnGAByMYZea8oHCeVE=; b=aPLyaifRy8D2CtTGxJi9AW7rp61b7XdaJjsvPzytt/dpy/g5xOwhUF/OENXaAZ+gwG RWHzUdt9qTgKHScT/47tyOGbcIPsVKgb9wpoN8tIHRlhZz5BGZJwhYn/gq8aQOLGmW/5 I9DxkuvH4F0cAhveTf5cxbIW/sa4tWtcI4tQUd5R8AB3RCsYKvXeLlcCvMJIDuk7dZcQ cYgykGMuvL4nfwRHcUBBBGfML6qhcFA83kUD7HGhJ54sMbIuM/X0EBAugUP5oARE8pdz t47tmQoyA5WyEJVZlmEVlgoaMEBXILffsMu8SZiiD0uJvkzSLXXhHuoKeWJxqyDcEWIC Xp6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WnEEcW5T8TnW3Xg2cKGofSTt8rnGAByMYZea8oHCeVE=; b=my4cYBlaaR6j7Xc2XhyJiuHY1FHL94mqkyIDiWsH64NBjC8SwwKuAR9UWts6/HRYTr z2xztuh31sQ32tQiTfv6fZ2ACMRkGQ6HlTYzwIV2JlItOpIpXyC7MbOkQmMeovLFQ17s eaDZAUhRJ22SZ3XiPQCGf7BbAqH6l09WEQRVQvdngLaZCXBFOcykcjBBIIwgpG3yJL5s PfOlmYap+L9qqFbuVJTkdghdCGKK6pcSOGr2lGJafuPXvK2T1bgt24+wjfIyy72cI4Qs PyuKamtpiA8VN0XgTLfjVayJwgS2nI9pKEjl+ygqKMwG4Zc2DrhEixfML5DG3yQte7Ih ssgg== X-Gm-Message-State: AOAM531rHOD7YmxorT+isWhtNk2TDz6XwKdm9ZH32Jqz07axzGt9hPAU rW9C/I+Xdh93WH7U/0ZUglfoZQ== X-Google-Smtp-Source: ABdhPJwWlZ7XyMAF+woUaQZxZTAImBTPJHDauWw15PKL0XcGCVEMcFqLPT4y8xV+iEsvsn/btVzZgA== X-Received: by 2002:a5d:6406:: with SMTP id z6mr15796123wru.133.1600096039763; Mon, 14 Sep 2020 08:07:19 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id g8sm19206547wmd.12.2020.09.14.08.07.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2020 08:07:17 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id F38CD1FF87; Mon, 14 Sep 2020 16:07:16 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v1 1/6] linux-user: test, don't assert addr != test in pgb_reserved_va Date: Mon, 14 Sep 2020 16:07:11 +0100 Message-Id: <20200914150716.10501-2-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200914150716.10501-1-alex.bennee@linaro.org> References: <20200914150716.10501-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::444; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x444.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier , Bug 1895080 <1895080@bugs.launchpad.net> Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On older kernels which don't implement MAP_FIXED_NOREPLACE the kernel may still fail to give us the address we asked for despite having already probed the map for a valid hole. Asserting isn't particularly useful to the user so let us move the check up and expand the error_report a little to give them a fighting chance of working around the problem. Ameliorates: ee94743034 Cc: Bug 1895080 <1895080@bugs.launchpad.net> Signed-off-by: Alex Bennée --- linux-user/elfload.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/linux-user/elfload.c b/linux-user/elfload.c index 4961e6119e24..f6022fd70493 100644 --- a/linux-user/elfload.c +++ b/linux-user/elfload.c @@ -2331,14 +2331,13 @@ static void pgb_reserved_va(const char *image_name, abi_ulong guest_loaddr, assert(guest_base != 0); test = g2h(0); addr = mmap(test, reserved_va, PROT_NONE, flags, -1, 0); - if (addr == MAP_FAILED) { + if (addr == MAP_FAILED || addr != test) { error_report("Unable to reserve 0x%lx bytes of virtual address " - "space (%s) for use as guest address space (check your " - "virtual memory ulimit setting or reserve less " - "using -R option)", reserved_va, strerror(errno)); + "space at %p (%s) for use as guest address space (check your" + "virtual memory ulimit setting, min_mmap_addr or reserve less " + "using -R option)", reserved_va, test, strerror(errno)); exit(EXIT_FAILURE); } - assert(addr == test); } void probe_guest_base(const char *image_name, abi_ulong guest_loaddr, From patchwork Mon Sep 14 15:07:12 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 303451 Delivered-To: patch@linaro.org Received: by 2002:a92:5ad1:0:0:0:0:0 with SMTP id b78csp1713586ilg; Mon, 14 Sep 2020 08:08:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwdlCUqpxoSOQtdJIs3a2h4ME8nPev2pqDQC50zgRhj9dmM63GCn3KLUSlA20c2AFePqm9Z X-Received: by 2002:a25:e0d5:: with SMTP id x204mr22164901ybg.57.1600096128700; Mon, 14 Sep 2020 08:08:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600096128; cv=none; d=google.com; s=arc-20160816; b=X3JxBNUlAiI78mWmRfRGHSkkeWJYATu9sk8p2+ESDJxJ9BwijLtVDU/VbA81sVFQGA +lwsz5ZRTimrVclCiou+8uJqOWeMi341paxzVvsPkEMi2FbH2cVzxihuHPBE0uvJxmGw NJj3uYt/xK8rsvcA6RxHUYKS3zstTNGK5Glq01fWeEVQrCcfK/LsMZChhr5np/o2M1Xk k6dmlt6prEvH2l6yVjAz6ZhxxiuqmHty6S4061YpuZt/nm+Y8Nw6xLhK6OEFQSUEILs6 ECL2ciAo7SFdED2c7qN5auyCDSpZJw/9zad2p56H1imRgqaE4lnGhO2vkfMkCV2y+oeP FECw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=DcZH3/AM3ITUmRI3mSUTeNdaJ0mGPZEUhU4TVCzbSkM=; b=x74cBPh+1TNr9UYzPavrT2qsKFmCSbr/Xb8C1uSeAT27j9a1A82CQPuhoYrpiwWlRk z4XGO2Nxg1gyQt8HNYwNvxzILSbduk02/JDN1+nSH4NBM/Z9aBPZhpAkKw5rJyzuR3e6 7g2w4nVsqbvo04mH+lMQZ3GaPl6hxP084Oz+Js3mA7o4AElVmNI9MpVGlv5rn0vu1fUB 5WdxrodLKs3V3yd8R25LBvHfkzMq12Xhtt/zSsbEQnzu2a+qC2RVeXFKg62hhVQyuclb +OeGkYv3Q6aElR81fTZrYLnWYv2H5BGkZEYSZZ2BDbClIMBawRRsj2A/8BtUSuXrRYC5 hvjA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=v7tZ0xwk; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id h94si12958389ybi.99.2020.09.14.08.08.48 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 14 Sep 2020 08:08:48 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=v7tZ0xwk; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:40800 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHq64-0000fy-5E for patch@linaro.org; Mon, 14 Sep 2020 11:08:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37818) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHq4k-0000eR-Ls for qemu-devel@nongnu.org; Mon, 14 Sep 2020 11:07:26 -0400 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]:35375) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kHq4h-0000DN-8w for qemu-devel@nongnu.org; Mon, 14 Sep 2020 11:07:26 -0400 Received: by mail-wm1-x331.google.com with SMTP id y15so431922wmi.0 for ; Mon, 14 Sep 2020 08:07:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DcZH3/AM3ITUmRI3mSUTeNdaJ0mGPZEUhU4TVCzbSkM=; b=v7tZ0xwkuJ59RtexlPiJASSnnsOx1r+crLg1V7rF4fUpuKqNzdUutYJHUeo7oP4kA3 fIdYmcgH14APJD3T7NRTrTO3oE6H28fOt+zmsu0vFDn7mpmhoOOsVwLfumhWeRFbrjVI /VUrU+gABMDqYMAMe+L6h+2zbprWwWIRANBLhglGMZmtJS8sD5KPvBA7LURqP/uNiSUE 5XIePlS7sWBwuXyAebkd88So7LaYJvS1dzoTR6bQn2Cj0IxWeA77PuAHOKxcbUZurPD3 3OAx/5PbRWlU8emCCTFOUg7cOfbo3Nqv6t5EvmyAndFIr+yoKgOV81t38L6oSxGJ9JsA 3z5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DcZH3/AM3ITUmRI3mSUTeNdaJ0mGPZEUhU4TVCzbSkM=; b=f6wAIaUd4BkS5xaZ26aRAvOuaVLgXFxT8wwKMDifuGsCeeXWZxxhNFI4Yqf5LfQtaT wR1IZEdadOyF+9NwhEic5GBoK7GquYYG545A/Z5zQoF3wCeWTTD3kI63m/3JdQAzwPAp nQPXpz1mkLO8sG38oT++VpsVqItdkBooL+M9YPnuR481IUpQoXhZpt4E6Qpz7nT0A2z5 v8BrFfa5wCU/5AwllxJJT2XSuYT6xKublq4xoq+CcWuSHAgY50jQyaQuBD8DNm+3ohwv PpV9No2cNtBZgPmKFc1D1CFc+qdFCtKafL08+P36BFDmzrUsLWXVBDLkS+IWkvIwd1FM p14w== X-Gm-Message-State: AOAM533IzeSd7aFOwqKIp0kRrmUdGXL2GrCnl9lnBzEW6QaJOLqPYHyh GiTIXJzIx7JlwXHIkVovzp9s6xmHX1KGbA== X-Received: by 2002:a1c:5a87:: with SMTP id o129mr16039757wmb.145.1600096041666; Mon, 14 Sep 2020 08:07:21 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id u66sm19961158wmg.44.2020.09.14.08.07.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2020 08:07:17 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 12E3D1FF8C; Mon, 14 Sep 2020 16:07:17 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v1 2/6] configure: use add_to for tweaking deprecated_features Date: Mon, 14 Sep 2020 16:07:12 +0100 Message-Id: <20200914150716.10501-3-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200914150716.10501-1-alex.bennee@linaro.org> References: <20200914150716.10501-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x331.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Alex_Benn=C3=A9e?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Alex Bennée --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.20.1 Reviewed-by: Thomas Huth diff --git a/configure b/configure index 2b6a1196da50..e365a90cc133 100755 --- a/configure +++ b/configure @@ -7668,7 +7668,7 @@ case "$target_name" in TARGET_SYSTBL_ABI=common,nospu,32 echo "TARGET_ABI32=y" >> $config_target_mak gdb_xml_files="power64-core.xml power-fpu.xml power-altivec.xml power-spe.xml power-vsx.xml" - deprecated_features="ppc64abi32 ${deprecated_features}" + add_to deprecated_features ppc64abi32 ;; riscv32) TARGET_BASE_ARCH=riscv From patchwork Mon Sep 14 15:07:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 273788 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C363C433E2 for ; Mon, 14 Sep 2020 15:26:42 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EB9D620665 for ; Mon, 14 Sep 2020 15:26:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OjyaHq3h" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB9D620665 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49730 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHqNN-0000mf-3w for qemu-devel@archiver.kernel.org; Mon, 14 Sep 2020 11:26:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37888) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHq4r-0000i1-Qq for qemu-devel@nongnu.org; Mon, 14 Sep 2020 11:07:34 -0400 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:52445) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kHq4k-0000Da-AR for qemu-devel@nongnu.org; Mon, 14 Sep 2020 11:07:30 -0400 Received: by mail-wm1-x341.google.com with SMTP id q9so372194wmj.2 for ; Mon, 14 Sep 2020 08:07:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+qj72lK8wx2iNL797q3LY8hGwabeZRPUrw3VVMi4u3Y=; b=OjyaHq3hQx/JIUjAgrGwsYCLPtYXQ0C+AxMg+d7Eg90Om/c8OqcECCRhAsxPK/FSLQ ZVmHE5sPlxtgmPkdeAOaKC9WjM8QG6jXVQbdS1QMpnZLsUihD7fMAXrgpV//ajYOc7dP Om3hKL0QYldc/ZKonnKmzhTokgeQ5ZlDVs6q1KTDIW58Ez2mjg4e3479hmPaXD9umDMl 2yo/j1uyRfioeiUPmlfefwc0A8mdSIZUE3pjqtBZnHlNst5CzYPIMC6xM3FooEiE4BpV Tk1VSRLBdliOm2TzMvQH7NcDf6p5hoaN3pVKRypJYH490z8QWEVXZJaTfvGU/05CRv/c CTnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+qj72lK8wx2iNL797q3LY8hGwabeZRPUrw3VVMi4u3Y=; b=F1VPv7gO/uegdJRpnKeItq0t16PXgGpoyudfuRPbiineIZrp/Uzwig8kIdroZgS/M1 fI/O5/7526V6B1kW/SWf6kn9b3hrwTk3GH6XWl4fW1XGtzvLYJgufLPIQWRMd3OYS8Ib 0DYxpGeP8nAjMqOwpmafgSDb3mrhwIizwKwdHSUbFyrZSodjOyNASOfyKUtJV6NdIuU5 QC4VKptcnEvXeDPDD56upPGWG0xP/wfFWV7eUOapT2f+Ql3iJBaIKQddrp0xqvG3EF3V 8oFcb/Fl2ZkW3NSFZjMAz4wNCIf/T1z+qLzRb4ELMTR/X4iIpzV5xBt7yQe4aUWBlXAb YEjA== X-Gm-Message-State: AOAM531DGzuthEgDix+obsgFrDFBXmnqMYcyl1tSaIkO33f44hOUKVgu x7ULKfOx3wCcbAGC2egobM625qL+YHjZsA== X-Google-Smtp-Source: ABdhPJxGlkopwD3BuA6SaRfPrVQUBDwE8ICBSH11D+7S6jENuhPMkJfn7GVefzx8P9KRwgUhnBdbfw== X-Received: by 2002:a1c:2e17:: with SMTP id u23mr16310203wmu.73.1600096042834; Mon, 14 Sep 2020 08:07:22 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id m13sm20395126wrr.74.2020.09.14.08.07.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2020 08:07:18 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 291D11FF8F; Mon, 14 Sep 2020 16:07:17 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v1 3/6] configure: also skip deprecated targets with target-list-exclude Date: Mon, 14 Sep 2020 16:07:13 +0100 Message-Id: <20200914150716.10501-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200914150716.10501-1-alex.bennee@linaro.org> References: <20200914150716.10501-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::341; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x341.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Alex_Benn=C3=A9e?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Now the user has to make an even more deliberate decision to enable a deprecated target rather than getting it as a side effect of using --target-exclude-list. Signed-off-by: Alex Bennée --- configure | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/configure b/configure index e365a90cc133..50052378e417 100755 --- a/configure +++ b/configure @@ -1722,9 +1722,15 @@ if [ "$bsd_user" = "yes" ]; then mak_wilds="${mak_wilds} $source_path/default-configs/*-bsd-user.mak" fi -if test -z "$target_list_exclude" -a -z "$target_list"; then - # if the user doesn't specify anything lets skip deprecating stuff - target_list_exclude=ppc64abi32-linux-user +# If the user doesn't explicitly specify a deprecated target we will +# skip it. +if test -z "$target_list"; then + deprecated_targets_list=ppc64abi32-linux-user + if test -z "$target_list_exclude"; then + target_list_exclude="$deprecated_targets_list" + else + target_list_exclude="$target_list_exclude,$deprecated_targets_list" + fi fi exclude_list=$(echo "$target_list_exclude" | sed -e 's/,/ /g') From patchwork Mon Sep 14 15:07:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 303482 Delivered-To: patch@linaro.org Received: by 2002:a92:5ad1:0:0:0:0:0 with SMTP id b78csp1787136ilg; Mon, 14 Sep 2020 09:48:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz9MmTMSR+79lY7QmlZNZMqHu333Ri76lgZE38ExqTzK2VhnLsxe3a+j5tLBoAZlJ4nmmhl X-Received: by 2002:a25:ab2b:: with SMTP id u40mr23419604ybi.496.1600102136621; Mon, 14 Sep 2020 09:48:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600102136; cv=none; d=google.com; s=arc-20160816; b=m40gW4+ECu2FpucKuiPv4zwo7v7MBolDSphqBYvfvE61kJvPwQrzpqen/gBiPfp7mq 9jvu6cq26IZ7XWq0MqSdhaorr3vpfba2d41yRFookXvCv9LYD5ozhFm3Pno9v9gYua+I MIAyw9u37T+Roh3XxSyPG9wUK8VaK2pC29RlHovSGZnGVJ5OcXoLTnVKXy8ucKtRPbso axJm+E+vzew7mLHAHqY2UC5/8s22qIYc1czOi7LvZ0k9uQLpeYAdqe1gW2Si8ScP4RTi FX+f+/JSeGhSkW8n0LVN59cGUE1Hu3kmwnzmmIDuJcv6gUTaTF4en4eYWpW5MI+s7YMr 0mBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=bTZguQqXGVOp7T1z++Tht2natyY+bnRw2yDCKI4+jDM=; b=p7wXIvCv8a3caO+M0ejQ19i2k48HmaALU5YEz4Vv4659exK0G5CumPeKGu8gKpt8gZ NQ4ygneDBP+mfJ0gg5XPAcHiU41nnWtSfo5R84ZseIh70VI9HZ4Mj4eWOD78jPDshAv9 lp3Gp6WbYIEMS9yfyV0BY7d0naJzQsbPV7F1LLsDYNjs6PCCtcQpIuBSdsBEWHQuI1mI 7vmATYSo/aPIQICUfAEedoei24SqxV4DjgQjirVrpgGjqA6oWi5io2CJSuiN/+rmRwyK DXTY6aJ6aq9JWHsuFXJ3WsG9Z1NO44E7j0yW45zYHLRbHV+58JnJS/OyFPKJcPFc1YMP nqsQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=If6UFPyQ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id y5si11217216ybk.174.2020.09.14.09.48.56 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 14 Sep 2020 09:48:56 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=If6UFPyQ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:54902 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHrew-0002xX-Li for patch@linaro.org; Mon, 14 Sep 2020 12:48:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37854) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHq4l-0000gH-T4 for qemu-devel@nongnu.org; Mon, 14 Sep 2020 11:07:27 -0400 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:34224) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kHq4k-0000Dq-Ah for qemu-devel@nongnu.org; Mon, 14 Sep 2020 11:07:27 -0400 Received: by mail-wr1-x444.google.com with SMTP id t10so64537wrv.1 for ; Mon, 14 Sep 2020 08:07:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bTZguQqXGVOp7T1z++Tht2natyY+bnRw2yDCKI4+jDM=; b=If6UFPyQ2dleong+6iM3rtNm5B4HfItVs85fCwNkJCqD9g+oy+5ONJBg+5R6LAWVTc 4PU90lBBEXmd0UIVHIwTYFMlrFgy2JGOIaMqJlTE/J6bezhGDREfeG0aXQm8S5E+6eni L7hAo40H6UnvOKpvZrtLCIIRd73UZVccCApMtmdeSdxo3LoQltYLBz24B9KQVJynD5da 7ds2zWrHDtSiUlaZXXrM1OgKTpEP/XAnrb+bw/c2+xYznHdilS2vaoAiMKZhGHZQFU+L WG9e7PMbcBs858Fn2seCUUcsc/p6lpycXn92/OZ6581XCNcRIMqP61dmIgYa3a89klFI eDHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bTZguQqXGVOp7T1z++Tht2natyY+bnRw2yDCKI4+jDM=; b=W4Qu1atYBTZM6Nje/FZPqXpBvHFrtT/jQYJ6Yvviko8vrBvf8YVlomeEr+IGxiYyl6 yVJ33cRvc1IH18AGRbPw9ljWmrLAaGvCO+30tVziZUjwFlzUz6260OrJeSD8r8u8Mbr2 4d89JBp2e4+RpToIiac4UiXXe2NGepi6lXXkhJMg7KPo/an/c4aZyXxD4VVYNcF1G4Ot cP2WKx+/SEaiwZ3N5XEATkBKLdxEdAr7nav09JAwOadDPEBfgs4Ww8WW4Av/YKTr4Ceb Oii6QdoAEVfZIAzFfycnT1mriUrjvY+tdjCuII63m6rvIbHM+AEYw3GTLl4IffB+N5ZZ zrWg== X-Gm-Message-State: AOAM5337faz5ejlSZ0C0dvcCtYrV0FasrOZKTUFQmC86q2eiwjnKJXwk c8sKsQr/pBEN89xM8T3TZyKdHQ== X-Received: by 2002:adf:8b1d:: with SMTP id n29mr15803456wra.383.1600096044893; Mon, 14 Sep 2020 08:07:24 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id 185sm21137941wma.18.2020.09.14.08.07.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2020 08:07:21 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 400781FF90; Mon, 14 Sep 2020 16:07:17 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v1 4/6] configure: include tilegx-linux-user in the auto-exclude logic Date: Mon, 14 Sep 2020 16:07:14 +0100 Message-Id: <20200914150716.10501-5-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200914150716.10501-1-alex.bennee@linaro.org> References: <20200914150716.10501-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::444; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x444.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Alex_Benn=C3=A9e?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The target is already marked as deprecated in the documentation. Signed-off-by: Alex Bennée --- configure | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.20.1 Reviewed-by: Philippe Mathieu-Daudé diff --git a/configure b/configure index 50052378e417..d998723cccc3 100755 --- a/configure +++ b/configure @@ -1725,7 +1725,7 @@ fi # If the user doesn't explicitly specify a deprecated target we will # skip it. if test -z "$target_list"; then - deprecated_targets_list=ppc64abi32-linux-user + deprecated_targets_list=ppc64abi32-linux-user,tilegx-linux-user if test -z "$target_list_exclude"; then target_list_exclude="$deprecated_targets_list" else @@ -7719,6 +7719,7 @@ case "$target_name" in gdb_xml_files="s390x-core64.xml s390-acr.xml s390-fpr.xml s390-vx.xml s390-cr.xml s390-virt.xml s390-gs.xml" ;; tilegx) + add_to deprecated_features tilegx ;; tricore) ;; From patchwork Mon Sep 14 15:07:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 273790 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2F48C43461 for ; Mon, 14 Sep 2020 15:15:02 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 76A52208B3 for ; Mon, 14 Sep 2020 15:15:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YTjShj4R" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 76A52208B3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56848 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHqC5-00083f-9e for qemu-devel@archiver.kernel.org; Mon, 14 Sep 2020 11:15:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37962) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHq4x-0000jp-QG for qemu-devel@nongnu.org; Mon, 14 Sep 2020 11:07:39 -0400 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]:41723) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kHq4q-0000ES-T3 for qemu-devel@nongnu.org; Mon, 14 Sep 2020 11:07:37 -0400 Received: by mail-wr1-x442.google.com with SMTP id w5so8400wrp.8 for ; Mon, 14 Sep 2020 08:07:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AxePx8oOqocKMREyg0WDjugaJREHStftt0HCq39PBRY=; b=YTjShj4RCRH/EkoLHM2yai1lrk60a7ywpKZumVpSiCBn6XLv206v2dPeG8XAdWW+tB fXB23ZZDzIXZoefZvUG9M0UWzljqXZkprvQJINhP2dKOOO6p8BRl5C83kV23b942CtV6 swBlsfUw47DEYjljyD5ufnKRgCM3yMiz+hH9sXHdgHjXWyBMQu9mZLF0l1xK5bWIZi+b /P75HBHjjNEPeAQoBAhNklUg0yaaa5+j4to8g56G04X3WRbxyXb4PhQzjVHJsmC8LCWF QZRPlhl7yFuvfg/1bvRUfK3kknGpkkJHl08umMEc+I84EYQIMpjWHlUGJxpGp+dtX/dW pDVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AxePx8oOqocKMREyg0WDjugaJREHStftt0HCq39PBRY=; b=ZcIhnwuukpscTryeBzoIiiitFp8BboVcTW10c5VT5ccLrurVHtfEAZqJjKnRdPz4cf oODejeYMATTuD8g2ishnCH1u6Yid7eNOxPRBOVA0K525ahN50XpJraxbyY+mbw+bkr+F PuekH9YtsN3qi5rzNPjvyorVo9HnfUTv6g6F8J2K7NumgpU49ro4nOlLPGTp2bnnmyLD pUhHewmXrG/x+zzscO5RSbyYeZvnt0oqEB05/ALH3vC+UpJb/SneJf2PabtJ3/rEp7lC LFFkvbocTpTFhmEgJYWYl2SGtwNzwnyrPY702OPnZB8N+Ns/LA7XDgrVLMhN9oMUkWI5 4Smg== X-Gm-Message-State: AOAM532r9CgkUX7TGygT/rkoUvJ9iRWOUb4bdLcDVhrxpo/w4vEh83ps Gfq89yu/mhDwvnQqt2zxearZBZuWnZ17AQ== X-Google-Smtp-Source: ABdhPJwJN7ScZirFamp+WoxA23mZIXWEo01uQjBgJPbWRvVlLXhasv9qNWobOFZXuuubmaTK34aicw== X-Received: by 2002:adf:e407:: with SMTP id g7mr16263896wrm.349.1600096048068; Mon, 14 Sep 2020 08:07:28 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id a127sm20206161wmh.34.2020.09.14.08.07.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2020 08:07:23 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 55A1F1FF91; Mon, 14 Sep 2020 16:07:17 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v1 5/6] gitlab: create a build-deprecated target Date: Mon, 14 Sep 2020 16:07:15 +0100 Message-Id: <20200914150716.10501-6-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200914150716.10501-1-alex.bennee@linaro.org> References: <20200914150716.10501-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::442; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x442.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Thomas Huth , =?utf-8?q?Alex_Benn=C3=A9e?= , Wainer dos Santos Moschetta Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" These targets might be deprecated but we should keep them building before the final axe comes down. Lets keep them all in one place and don't hold up the CI if they do fail. They are either poorly tested or already flaky anyway, Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Acked-by: Thomas Huth --- .gitlab-ci.yml | 10 ++++++++++ .travis.yml | 3 +-- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 72e8604579ee..f027b55aef15 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -254,6 +254,16 @@ build-clang: ppc-softmmu s390x-softmmu arm-linux-user MAKE_CHECK_ARGS: check +# These targets are on the way out +build-deprecated: + <<: *native_build_job_definition + variables: + IMAGE: debian-all-test-cross + CONFIGURE_ARGS: --disable-docs --disable-tools --disable-system + MAKE_CHECK_ARGS: check-tcg + TARGETS: ppc64abi32-linux-user tilegx-linux-user + allow_failure: true + build-oss-fuzz: <<: *native_build_job_definition variables: diff --git a/.travis.yml b/.travis.yml index 65341634d02a..c75221dca3e7 100644 --- a/.travis.yml +++ b/.travis.yml @@ -344,10 +344,9 @@ jobs: # Run check-tcg against linux-user (with plugins) # we skip sparc64-linux-user until it has been fixed somewhat # we skip cris-linux-user as it doesn't use the common run loop - # we skip ppc64abi32-linux-user as it seems to have a broken libc - name: "GCC plugins check-tcg (user)" env: - - CONFIG="--disable-system --enable-plugins --enable-debug-tcg --target-list-exclude=sparc64-linux-user,cris-linux-user,ppc64abi32-linux-user" + - CONFIG="--disable-system --enable-plugins --enable-debug-tcg --target-list-exclude=sparc64-linux-user,cris-linux-user" - TEST_BUILD_CMD="make build-tcg" - TEST_CMD="make check-tcg" - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-debug-tcg" From patchwork Mon Sep 14 15:07:16 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 273791 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC395C433E2 for ; Mon, 14 Sep 2020 15:11:36 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 76BA6216C4 for ; Mon, 14 Sep 2020 15:11:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DsyRCmVm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 76BA6216C4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50354 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHq8l-0004zD-8W for qemu-devel@archiver.kernel.org; Mon, 14 Sep 2020 11:11:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37892) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHq4r-0000iE-Te for qemu-devel@nongnu.org; Mon, 14 Sep 2020 11:07:34 -0400 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]:50894) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kHq4l-0000Dx-8y for qemu-devel@nongnu.org; Mon, 14 Sep 2020 11:07:33 -0400 Received: by mail-wm1-x32d.google.com with SMTP id e17so387131wme.0 for ; Mon, 14 Sep 2020 08:07:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=o+QIQisstLv7dEECXFjFLhux+SH+QFhePF29ylUvIXs=; b=DsyRCmVmDZmupiVqhp4L8aRRxK62GCQ+y5tZV6je4u+tF1J0t6+pn7tOU8C/4tGdoi fypmfx6ZCWWacWb4isb+NPmpBzRLyQ2/uXarGy/O78Ce3q2AbJdiyCsD1l0vVoNX4URN EQcUhQZefREmAAV61Vwa61DShyh9mc9CRXdBughhPofeehyXuWfxhr2bAu09FoW5rOR+ zXzhI6uNc212p3VseXSEumsLKUjqdfJItQZkO6NoSXJ3JyjkB6TBxhnqjSikKoqy2AlQ Hh2u5LTT20ngdmRmGKDks8UesO/yAErZbJDNG7wy69pJbLe/I9r/jBhTnZ79h3dSK1xV Idzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=o+QIQisstLv7dEECXFjFLhux+SH+QFhePF29ylUvIXs=; b=DKCUQVBom8+OfTOSDNMeNcIcdAL6vWFrUQkEjXp4y8XeLYoxnhlXw0JyYlQ2zywcm2 BzdkQMYXLMpLxJxKYTjQucq+uqXa8VYj3qQCVykOOLOTyQ5kVTx6lEUbcdcwxZ2hDONj ILp14l9GXMYIMiT3MOE/p0yhuDzIv0FA3xRyst6XUEAU33Mlf82hzr8swe/LEawWbS5P KHfcdZeM18XZv8R7LXlJNEic3MMwtnTJbSNLBAgPRJFhSflzO6+9JHaWNo68JvPjZhFH duj2Q7EtNuP0Y3gjqOsp1mC9LMlUKlsocRbGZETmDViAv2d51n0FnUSlPf8e2GPUgvxr n3pg== X-Gm-Message-State: AOAM530efGflJcuptoJpqO0POl1nInnziRFwUtxaLj3Asz9ncnyaQ5zO s4P58Qd1CfrsB2W2klHBm1aULw== X-Google-Smtp-Source: ABdhPJyHLLeEdTsCHqiE+JzKvearCGN5s+p7grshVV5O0nGd7D1QHnOUVJK/bAyNUaXKtIM8sFY11Q== X-Received: by 2002:a05:600c:230f:: with SMTP id 15mr15542360wmo.186.1600096045829; Mon, 14 Sep 2020 08:07:25 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id 59sm21436525wro.82.2020.09.14.08.07.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2020 08:07:23 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 6C5841FF92; Mon, 14 Sep 2020 16:07:17 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v1 6/6] iotests: Work around failing readlink -f Date: Mon, 14 Sep 2020 16:07:16 +0100 Message-Id: <20200914150716.10501-7-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200914150716.10501-1-alex.bennee@linaro.org> References: <20200914150716.10501-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x32d.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Thomas Huth , "open list:Block layer core" , Max Reitz , Claudio Fontana , =?utf-8?q?Al?= =?utf-8?q?ex_Benn=C3=A9e?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: Max Reitz On macOS, (out of the box) readlink does not have -f. If the recent "readlink -f" call introduced by b1cbc33a397 fails, just fall back to the old behavior (which means you can run the iotests only from the build tree, but that worked fine for six years, so it should be fine still). Keep any potential error message on stderr. If users want to run the iotests from outside the build tree, this may point them to what's wrong (with their system). Fixes: b1cbc33a3971b6bb005d5ac3569feae35a71de0f ("iotests: Allow running from different directory") Reported-by: Claudio Fontana Reported-by: Thomas Huth Signed-off-by: Max Reitz Signed-off-by: Alex Bennée Tested-by: Thomas Huth Message-Id: <20200914113809.63640-1-mreitz@redhat.com> --- tests/qemu-iotests/check | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check index e14a1f354dd9..75675e1a18f0 100755 --- a/tests/qemu-iotests/check +++ b/tests/qemu-iotests/check @@ -45,6 +45,10 @@ then fi source_iotests=$(cd "$source_iotests"; pwd) || _init_error "failed to enter source tree" build_iotests=$(readlink -f $(dirname "$0")) + if [ "$?" -ne 0 ]; then + # Perhaps -f is unsupported, revert to pre-b1cbc33a397 behavior + build_iotests=$PWD + fi else # called from the source tree source_iotests=$PWD