From patchwork Wed Dec 6 09:50:08 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 120801 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp6843415qgn; Wed, 6 Dec 2017 01:53:03 -0800 (PST) X-Google-Smtp-Source: AGs4zMai/w77WPuizkYHVFR8sM9hIrWi0ViUTG42pSCUymlg8hZsTT0k82XFTBWWThTsyqXlK0U8 X-Received: by 10.99.117.19 with SMTP id q19mr20170769pgc.94.1512553983290; Wed, 06 Dec 2017 01:53:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1512553983; cv=none; d=google.com; s=arc-20160816; b=1DcITINEkBE9UysJxR1NcSTOhV1kZ9MaaFfnzkaIspPw6dq966QNGHi/rvWRcjjJhG k1P5jLw6yaKzwlGMAonI797DYKtWBBnVAOZUvVWH1MbzqRU/DxqzRSBNWSKBEhF7Bh1q rem7xISpQnPNK3csdRq09rLbFK7brrbUWLhZgM8UH1jr/1j2aVEp6GmL+UoC65TPhS6q 5GWsnNFAaU2e0btP0ObunJZEwrcqfgfXs3/C9pTbHD34NsSHO8JGNWi+0ujkRZOly/MV IUMexTKTA/fhLVoyhuMvG8+culRwooN64L9oY9Zh2us43MeYcR08dJpY/F9BOrYu3svL 1eaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=Spf5r9a8AwCEdkqMSE75XsaGxAkAQtolyxYBwrt/2Bw=; b=Ugg+sCJJx8LWdp8P7mzhuvKWOoGVx+B7nfgVUbR6OhUu8kcaoW11i19ic/IOugGbBm qzTz9xenyq/CUoD2cgP0Dhm+FtgpGjgvT+O87MO2lfNg9fYS/su77rccR0xzCqF2d5bO zPu6zZgxQcFYv/cj+xb+8canNxoogXSQiFvt5SfFEggZvXZlZPwDxGnPRS2+4B0Pq520 eBhV1F4YNMtG/GyGnbLmIfIIVg0+FTRAC0kYqqWQGu9zAp6Sz5GNfviKH1QgV4fwwyy/ 3q/HVeza/1TaNit5BYNZW6V4VJQX08w6DChvhmo5DrY7jLAiPHBgEwZT77Q5LRKi5zyF OsbA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=HMaODjZb; spf=pass (google.com: best guess record for domain of linux-efi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-efi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t84si1774477pfg.252.2017.12.06.01.53.03; Wed, 06 Dec 2017 01:53:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-efi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=HMaODjZb; spf=pass (google.com: best guess record for domain of linux-efi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-efi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754733AbdLFJxB (ORCPT + 2 others); Wed, 6 Dec 2017 04:53:01 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:37591 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753998AbdLFJw2 (ORCPT ); Wed, 6 Dec 2017 04:52:28 -0500 Received: by mail-wm0-f66.google.com with SMTP id f140so5975235wmd.2 for ; Wed, 06 Dec 2017 01:52:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=kPElbxAiULMDMzD3H8CQaN+o8vCoU9KM1JvUBU0xW+g=; b=HMaODjZbuMz8HRzLiD6xU7D71idvYr9ihDFEEg8HUEjYsmcUzCPN7rtK9zNX2qgI2o vdiamIDWZvkc923wv46BeCbENfz4WXNKOYdagjNRVP9QmZeCos3UzdSSMUSbOxUT2kHO aXKZLigJ5u4+2UyFvehbfTIdzQXCvg7oF2h30= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=kPElbxAiULMDMzD3H8CQaN+o8vCoU9KM1JvUBU0xW+g=; b=s0SNdrZxsC0XvmCOjqSMLegR/ZGSkBXTtgdvvtzz5ZtK97Kdoqp/ZW9+s1Oigbswdq PkM7B8GK756UaHw48PykWNNWoWnk3LHCeBzzAIdr4FdkdIpDOWPjJedY/8EkfW1psPhD iFVbp3liJOMpOmyRA65Q0dFO3IAtXYASq+SNm28xarSt4cnUYWsIV9AcCWPqYq7uyWKV igyfL8S/+yTOT4/NLsZlgmTu9CQF1sLiFeZ6YUKsXQJIHCiE+KMlkDwKWOYBbz7dlmkK w+let/TrgOw5qbNpfdqxRl/tuB6kCOcD0OUIGSaR/8VXWK6g4Z9FuBN/J4+TA+V7b/S2 FjbQ== X-Gm-Message-State: AJaThX6GFGRlIR9PTh/PXsFHzkfYA+rv/toKBSBvzIY+IAgcLCun4K+C msKQAPWk8XiZDzLWH2o7ygOsAQgd1iE= X-Received: by 10.28.70.66 with SMTP id t63mr11682919wma.106.1512553946595; Wed, 06 Dec 2017 01:52:26 -0800 (PST) Received: from localhost.localdomain ([105.150.171.234]) by smtp.gmail.com with ESMTPSA id w133sm2543113wmg.9.2017.12.06.01.52.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Dec 2017 01:52:25 -0800 (PST) From: Ard Biesheuvel To: linux-efi@vger.kernel.org, Ingo Molnar , Thomas Gleixner , "H . Peter Anvin" Cc: Greg Kroah-Hartman , Ard Biesheuvel , linux-kernel@vger.kernel.org, Matt Fleming , stable Subject: [PATCH 1/3] efi: move some sysfs files to be read-only by root Date: Wed, 6 Dec 2017 09:50:08 +0000 Message-Id: <20171206095010.24170-2-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171206095010.24170-1-ard.biesheuvel@linaro.org> References: <20171206095010.24170-1-ard.biesheuvel@linaro.org> Sender: linux-efi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-efi@vger.kernel.org From: Greg Kroah-Hartman Thanks to the scripts/leaking_addresses.pl script, it was found that some EFI values should not be readable by non-root users. So make them root-only, and to do that, add a __ATTR_RO_MODE() macro to make this easier, and use it in other places at the same time. Reported-by: Linus Torvalds Tested-by: Dave Young Cc: Matt Fleming Cc: Ard Biesheuvel Cc: stable Signed-off-by: Greg Kroah-Hartman Signed-off-by: Ard Biesheuvel --- drivers/firmware/efi/efi.c | 3 +-- drivers/firmware/efi/esrt.c | 15 ++++++--------- drivers/firmware/efi/runtime-map.c | 10 +++++----- include/linux/sysfs.h | 6 ++++++ 4 files changed, 18 insertions(+), 16 deletions(-) -- 2.11.0 -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c index f70febf680c3..c3eefa126e3b 100644 --- a/drivers/firmware/efi/efi.c +++ b/drivers/firmware/efi/efi.c @@ -143,8 +143,7 @@ static ssize_t systab_show(struct kobject *kobj, return str - buf; } -static struct kobj_attribute efi_attr_systab = - __ATTR(systab, 0400, systab_show, NULL); +static struct kobj_attribute efi_attr_systab = __ATTR_RO_MODE(systab, 0400); #define EFI_FIELD(var) efi.var diff --git a/drivers/firmware/efi/esrt.c b/drivers/firmware/efi/esrt.c index bd7ed3c1148a..7aae2483fcb9 100644 --- a/drivers/firmware/efi/esrt.c +++ b/drivers/firmware/efi/esrt.c @@ -106,7 +106,7 @@ static const struct sysfs_ops esre_attr_ops = { }; /* Generic ESRT Entry ("ESRE") support. */ -static ssize_t esre_fw_class_show(struct esre_entry *entry, char *buf) +static ssize_t fw_class_show(struct esre_entry *entry, char *buf) { char *str = buf; @@ -117,18 +117,16 @@ static ssize_t esre_fw_class_show(struct esre_entry *entry, char *buf) return str - buf; } -static struct esre_attribute esre_fw_class = __ATTR(fw_class, 0400, - esre_fw_class_show, NULL); +static struct esre_attribute esre_fw_class = __ATTR_RO_MODE(fw_class, 0400); #define esre_attr_decl(name, size, fmt) \ -static ssize_t esre_##name##_show(struct esre_entry *entry, char *buf) \ +static ssize_t name##_show(struct esre_entry *entry, char *buf) \ { \ return sprintf(buf, fmt "\n", \ le##size##_to_cpu(entry->esre.esre1->name)); \ } \ \ -static struct esre_attribute esre_##name = __ATTR(name, 0400, \ - esre_##name##_show, NULL) +static struct esre_attribute esre_##name = __ATTR_RO_MODE(name, 0400) esre_attr_decl(fw_type, 32, "%u"); esre_attr_decl(fw_version, 32, "%u"); @@ -193,14 +191,13 @@ static int esre_create_sysfs_entry(void *esre, int entry_num) /* support for displaying ESRT fields at the top level */ #define esrt_attr_decl(name, size, fmt) \ -static ssize_t esrt_##name##_show(struct kobject *kobj, \ +static ssize_t name##_show(struct kobject *kobj, \ struct kobj_attribute *attr, char *buf)\ { \ return sprintf(buf, fmt "\n", le##size##_to_cpu(esrt->name)); \ } \ \ -static struct kobj_attribute esrt_##name = __ATTR(name, 0400, \ - esrt_##name##_show, NULL) +static struct kobj_attribute esrt_##name = __ATTR_RO_MODE(name, 0400) esrt_attr_decl(fw_resource_count, 32, "%u"); esrt_attr_decl(fw_resource_count_max, 32, "%u"); diff --git a/drivers/firmware/efi/runtime-map.c b/drivers/firmware/efi/runtime-map.c index 8e64b77aeac9..f377609ff141 100644 --- a/drivers/firmware/efi/runtime-map.c +++ b/drivers/firmware/efi/runtime-map.c @@ -63,11 +63,11 @@ static ssize_t map_attr_show(struct kobject *kobj, struct attribute *attr, return map_attr->show(entry, buf); } -static struct map_attribute map_type_attr = __ATTR_RO(type); -static struct map_attribute map_phys_addr_attr = __ATTR_RO(phys_addr); -static struct map_attribute map_virt_addr_attr = __ATTR_RO(virt_addr); -static struct map_attribute map_num_pages_attr = __ATTR_RO(num_pages); -static struct map_attribute map_attribute_attr = __ATTR_RO(attribute); +static struct map_attribute map_type_attr = __ATTR_RO_MODE(type, 0400); +static struct map_attribute map_phys_addr_attr = __ATTR_RO_MODE(phys_addr, 0400); +static struct map_attribute map_virt_addr_attr = __ATTR_RO_MODE(virt_addr, 0400); +static struct map_attribute map_num_pages_attr = __ATTR_RO_MODE(num_pages, 0400); +static struct map_attribute map_attribute_attr = __ATTR_RO_MODE(attribute, 0400); /* * These are default attributes that are added for every memmap entry. diff --git a/include/linux/sysfs.h b/include/linux/sysfs.h index e32dfe098e82..40839c02d28c 100644 --- a/include/linux/sysfs.h +++ b/include/linux/sysfs.h @@ -117,6 +117,12 @@ struct attribute_group { .show = _name##_show, \ } +#define __ATTR_RO_MODE(_name, _mode) { \ + .attr = { .name = __stringify(_name), \ + .mode = VERIFY_OCTAL_PERMISSIONS(_mode) }, \ + .show = _name##_show, \ +} + #define __ATTR_WO(_name) { \ .attr = { .name = __stringify(_name), .mode = S_IWUSR }, \ .store = _name##_store, \ From patchwork Wed Dec 6 09:50:09 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 120800 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp6843326qgn; Wed, 6 Dec 2017 01:52:56 -0800 (PST) X-Google-Smtp-Source: AGs4zMYTrOEyHcFv4UWp/3fSx5PG5dPfn77BWRxDcRtFgzZuoK9kTf1P4/sBGchq60R7GxkkLAlO X-Received: by 10.84.130.34 with SMTP id 31mr21578921plc.67.1512553976270; Wed, 06 Dec 2017 01:52:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1512553976; cv=none; d=google.com; s=arc-20160816; b=ZOjGuLb7fef1vHdY/0L5W3jU6xOCr//aAJRq0QCB2di8fxZoDLhaJTVNPjHSjIXPLO gIQuXDRvk5/RUuC2chAhHuiniyWTVl5H7Kfxp8RIcAs+lWM/3IiovweMoCh55MssO3Vg WFGOTMTdN9jP7IiInFceEK7ZKymukIO+/Lo0YDQZVHurMk7atoIyXQ0kANb05rgDZ77B XaE9fvNTEU4nKjs/nIZz+nGwStgq42hKcPjhyTO9pTQ9Smi9YQ0MbFhznGmDACOAjtcs tzj1M4iY3mCA7XmDMBPXKinQgxU8Ee1aDEqT6orXDcwX+PO2WrZWDB3MpLFdlYrtLbls ozxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=jKhK4+1lUNNss6VUqblmU2Kv9gUAtWpAg+dmrxq7YbI=; b=ylXMwCz5aPKIS4txXyEyG5VO9h8jOlS/vujmphkAzsl+1RK6AYuDCu8mtuOs30CWWJ oEwomiMWHFB2xhl7T1yL9wpKgwoLhVEA0DLUl8aQdXd69qdkQDd88dFNrCB+2u0kY+GE n090bAtLUEy7mJBRh+Lu02iOwLO1ENtn3hwoZlzLI3BsV3EUyIOf/UDUNIfKO/j/7ufn N06jEdHAi8kk1B1HaYcazh4Gbxw6qHUICngCMtFY0NKiPYNFOjK3F3RsZ37KlZci1EI8 AFO3XxS+DxASky57m4qQLs+gkU/htXQhLyPAqykeJ5Sc3rQw0hQf+d9B+Uyemu/BD23C d4LA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Y+kexoQK; spf=pass (google.com: best guess record for domain of linux-efi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-efi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t84si1774477pfg.252.2017.12.06.01.52.56; Wed, 06 Dec 2017 01:52:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-efi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Y+kexoQK; spf=pass (google.com: best guess record for domain of linux-efi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-efi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751444AbdLFJwz (ORCPT + 2 others); Wed, 6 Dec 2017 04:52:55 -0500 Received: from mail-wr0-f196.google.com ([209.85.128.196]:34543 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752084AbdLFJwa (ORCPT ); Wed, 6 Dec 2017 04:52:30 -0500 Received: by mail-wr0-f196.google.com with SMTP id y21so3218982wrc.1 for ; Wed, 06 Dec 2017 01:52:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=tJpilBSvQoQM5bfglG36S2+5eYq/BZDnfaTqzLWAWG0=; b=Y+kexoQKJsLNxVCFtyzMh2wnTNlEhJuMd4VF7HPBvOZgKgU7EnJObxvsK2s7gCUT+5 3jJR2FpAFOWb+3K023ToRt+qgXwV4PbHkQQJv3tlT0OgNQmH+xfy1/p12DmUrIp48T9P W3E3ZDlNgutXdgwBkIksMl8ryfOtU2ItHQ/c8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=tJpilBSvQoQM5bfglG36S2+5eYq/BZDnfaTqzLWAWG0=; b=Cjrp4kaiCmaltVIYSm6YhzOyIwXdP6ILM4npCQ65mt4Sc7umelgUoIVLvPDf74Px8p 2fbDXSKFrTHAom/6ISPBYxYsWwxCzEZznv7Q9Aury1TmwyEbEdXPt+oaYaf9M+sy7GpH l9vdNIeIRoTQtbAvpnfxthYbISnFvG7SrhEHoJPZXpkBGEH6rAZIBDrnETCCRIeZoXX+ ObVFZlfZiPQujN83QHkh87id2rQB+4oRd0tMMF4I4mHYtw+NJi2jJEsGBM+M/maWAIXt lprS3rOBJfl6XA+1sdPjvFDJFTWwt1UY3U4wxQp+eAQGkYfU8iPBjvBl84zcdKC0BNOI Kwjg== X-Gm-Message-State: AJaThX45tzERaPeGF8gFM2RbPm8oT6Pe5Wq/d3boIR4Ulds57XSfIvf0 TS63mpV8rCK5YC1L9uK5YbGwXBMNc4E= X-Received: by 10.223.181.132 with SMTP id c4mr17875943wre.42.1512553948795; Wed, 06 Dec 2017 01:52:28 -0800 (PST) Received: from localhost.localdomain ([105.150.171.234]) by smtp.gmail.com with ESMTPSA id w133sm2543113wmg.9.2017.12.06.01.52.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Dec 2017 01:52:27 -0800 (PST) From: Ard Biesheuvel To: linux-efi@vger.kernel.org, Ingo Molnar , Thomas Gleixner , "H . Peter Anvin" Cc: Pan Bian , Ard Biesheuvel , linux-kernel@vger.kernel.org, Matt Fleming , stable@vger.kernel.org Subject: [PATCH 2/3] efi/esrt: use memunmap rather kfree to free the remapping Date: Wed, 6 Dec 2017 09:50:09 +0000 Message-Id: <20171206095010.24170-3-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171206095010.24170-1-ard.biesheuvel@linaro.org> References: <20171206095010.24170-1-ard.biesheuvel@linaro.org> Sender: linux-efi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-efi@vger.kernel.org From: Pan Bian The remapping result of memremap should be freed with memunmap, not kfree. Signed-off-by: Pan Bian Cc: Matt Fleming Cc: Signed-off-by: Ard Biesheuvel --- drivers/firmware/efi/esrt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.11.0 -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/firmware/efi/esrt.c b/drivers/firmware/efi/esrt.c index 7aae2483fcb9..c47e0c6ec00f 100644 --- a/drivers/firmware/efi/esrt.c +++ b/drivers/firmware/efi/esrt.c @@ -428,7 +428,7 @@ static int __init esrt_sysfs_init(void) err_remove_esrt: kobject_put(esrt_kobj); err: - kfree(esrt); + memunmap(esrt); esrt = NULL; return error; } From patchwork Wed Dec 6 09:50:10 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 120799 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp6843126qgn; Wed, 6 Dec 2017 01:52:39 -0800 (PST) X-Google-Smtp-Source: AGs4zMZqCy5mQBcm29a7EU3RRa7kZsM9UyZHKKaJmrLRIFf20nG46c32MrNMrtI8Og8Tm3znSVJV X-Received: by 10.101.69.203 with SMTP id m11mr19919663pgr.200.1512553959680; Wed, 06 Dec 2017 01:52:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1512553959; cv=none; d=google.com; s=arc-20160816; b=tiltC0Jw2AHuAVdrjFfU+X4WAHRFiDiFMXymOUsXVQwrT8I4AnVChcpMMMHqLDmP+b moish4bK0WLewJS1TtZZgqbDJMpdHE04LIlAAPDHJpiUIht93oQl0eSXbE5wfUBkWGYj SKS9yS9Nvq9y906Z8lHFzFzG+CDZaJjg5GAr8MjEo98FsqtkZGxayR6gqucEkf0h8R1V 0gEMEe7TkdmHpd/Ks+i/Aw9EuR04GpQwJqT6wd8+qOVS9VTvbi8tqgmSRyQAblX7HMzJ e6XLq57esla5j2neAHKipx1dJGy0L4ECtpADICNfJPfeImn/hiJ3QXL4ZoGwjkvwxGbD vYyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=midNgekMa2Lq4p3qtyxHOuQn7YdyqrXE4PqHF3qcN8o=; b=AD1dNZGiC9YYcctsuaD51iRo7uaBcHD+h/VtRAnmtnkO4vLZtDSSvC6B1QZU7WGyOw bdu+wLdzmiGHBP2JNK6sdtGmupbFY/ysHKccQL6L/y3Lq84tQddYTyeBvKTlYr7hx1W2 sUPDCNNskqHR/qOp10Z05/9fF/zHu1CmnPIjEcEUG2ztXiDtOMpKH6EHswmpIyTo5wtV YHK3AevhlCTJtuZ07YYkJJXab5SeQ4JYBYt8NlBIlKEwv75AiPaeS65HwnbgJnnCz0j1 VlfrvkReh2BikXlKm4Jn4nw2xvZ84ievkpPFZUvNdDc6QzedxiE6hCQ8/WsXoubakmvo YZtw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=TudhQJ7n; spf=pass (google.com: best guess record for domain of linux-efi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-efi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t84si1774477pfg.252.2017.12.06.01.52.39; Wed, 06 Dec 2017 01:52:39 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-efi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=TudhQJ7n; spf=pass (google.com: best guess record for domain of linux-efi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-efi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754309AbdLFJwi (ORCPT + 2 others); Wed, 6 Dec 2017 04:52:38 -0500 Received: from mail-wr0-f194.google.com ([209.85.128.194]:46655 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754698AbdLFJwd (ORCPT ); Wed, 6 Dec 2017 04:52:33 -0500 Received: by mail-wr0-f194.google.com with SMTP id x49so3187389wrb.13 for ; Wed, 06 Dec 2017 01:52:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=S6eGmIOm2TZW5xNeiq7Se/wcuDrOUrmbhQXQeSJhCvI=; b=TudhQJ7n4rxzj5VCntl0uAZ1rGIah/mZrS1fpE/GQDNHuJdjUKHnJOeM98ttK7KllI R19mSs7cvRUCBZR7rVP+qeDslS8hui1HZ/+0jf5PVrOdgHXg7LTpXsEREsv37XCL1Et1 jyf/AcAWZ+7lipLxXJ9OKcZjUDHXlv0xP7DyY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=S6eGmIOm2TZW5xNeiq7Se/wcuDrOUrmbhQXQeSJhCvI=; b=RBfZ5ex9A+UWiu2z/sFVIoPkH5lDAuFy/DoLJ4veEskEoCNAj1FfJrHHU58L+mnWXE P910khM/yl/RT3D8wNj3fRTQT4Fb2erT8jKkyLcpwmOIotEkrX+VHMkNA4JuJBRRbJJr e6gt9sBgLLcua+rnXUSk3ltQDuO2kYg9ci8Wk2rwv+8BydVXUm9adl3JYSyEjkS6PcwJ 8FJWDQ5prjAXhNxZDgkXwHk+u7XHzoNx2XAxb3NfSMbUzK71lwmILldsnaQV+IxZK+ZE yW6weEJFEV+6isamF/0vQj0j1ujVEBvRMV6Z5QUhJUXM9DG2Vy8DYQS8EyVBNZQzMiDP 0mCw== X-Gm-Message-State: AJaThX6F2kUJu+GR4eHfahe+9Y0O0yVIYdE1xd+uPeREhJMPFgL7QKfg pgkoA1PrAvRzalosF7+YAvU7ywaA3XU= X-Received: by 10.223.134.76 with SMTP id 12mr20551063wrw.137.1512553951746; Wed, 06 Dec 2017 01:52:31 -0800 (PST) Received: from localhost.localdomain ([105.150.171.234]) by smtp.gmail.com with ESMTPSA id w133sm2543113wmg.9.2017.12.06.01.52.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Dec 2017 01:52:30 -0800 (PST) From: Ard Biesheuvel To: linux-efi@vger.kernel.org, Ingo Molnar , Thomas Gleixner , "H . Peter Anvin" Cc: Dave Young , Ard Biesheuvel , linux-kernel@vger.kernel.org, Matt Fleming Subject: [PATCH 3/3] efi: add comment to avoid future expanding of sysfs systab Date: Wed, 6 Dec 2017 09:50:10 +0000 Message-Id: <20171206095010.24170-4-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171206095010.24170-1-ard.biesheuvel@linaro.org> References: <20171206095010.24170-1-ard.biesheuvel@linaro.org> Sender: linux-efi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-efi@vger.kernel.org From: Dave Young /sys/firmware/efi/systab shows several different values, it breaks sysfs one file one value design. But since there are already userspace tools depend on it eg. kexec-tools so add code comment to alert future expanding of this file. Signed-off-by: Dave Young Reviewed-by: Greg Kroah-Hartman Cc: Matt Fleming Signed-off-by: Ard Biesheuvel --- drivers/firmware/efi/efi.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.11.0 -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c index c3eefa126e3b..557a47829d03 100644 --- a/drivers/firmware/efi/efi.c +++ b/drivers/firmware/efi/efi.c @@ -109,6 +109,8 @@ struct kobject *efi_kobj; /* * Let's not leave out systab information that snuck into * the efivars driver + * Note, do not add more fields in systab sysfs file as it breaks sysfs + * one value per file rule! */ static ssize_t systab_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)