From patchwork Mon Oct 26 23:29:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 301919 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D206C56201 for ; Mon, 26 Oct 2020 23:31:56 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ACB6E20872 for ; Mon, 26 Oct 2020 23:31:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mVYUIsqd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ACB6E20872 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54968 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXBxv-00050O-IZ for qemu-devel@archiver.kernel.org; Mon, 26 Oct 2020 19:31:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58990) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXBvu-00034B-Dh for qemu-devel@nongnu.org; Mon, 26 Oct 2020 19:29:46 -0400 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]:40494) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kXBvs-0000G4-Uj for qemu-devel@nongnu.org; Mon, 26 Oct 2020 19:29:46 -0400 Received: by mail-ed1-x535.google.com with SMTP id p93so1163116edd.7 for ; Mon, 26 Oct 2020 16:29:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=urFZaeBJKljDRkArj0HwcSmE633p30vmh0ol15kKy9E=; b=mVYUIsqdMcm4JDdnKtYSmnLzcAatosaK79SgzMhDRVgep3RogvqG66cjf7Di22kUx7 3AUNiiBuOydJFnaw+x5n1VQiTGJ32VVvPisI33ZIcYpe7X+wq31hDkq1vy085SjkNcfR YZv11qr0l7v6cy92OQIXnMb1djFD9FdBTio0TK5HXRGQZSYyQ2M8yoJOp8vf8lNtTVgl ChQD/cxtkMsfABLbpos/mjLJPcrqUTPi9ZlRHdgNdEKGVj+aL7WMZmHfoq6KK8IbU3mN FkSj0mgirpXChqywlclbK0v2kHq5qsWsgEHqMWW25pP6HFaqUlZ2vxPK9SdosdvHqt42 jHXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=urFZaeBJKljDRkArj0HwcSmE633p30vmh0ol15kKy9E=; b=DIysfLqItitLIqFf5+badZoaZU73j5MAwSNr/JVXDxevX/J6EtH/BTxURvXXb6SQH2 +bf+7ulajs8kCPdWZQNA+FzLIOzinOGaTmXB4pFllfcZkEKIp6l82hMhiK3us70yucI9 GR4BsGk1eePrnLn17LJOMH4a8quV+lRqz9ROeE0KwU2n/KxrmEEWmaA32lEhKrUqItBy 0kyZyYFoIJz1q9D3f0mtovepoHRDSm4npp6tP6gLBsOJsRxlLOze+4GfF9wlgJxsetxd lobK1NcwLRSTw4ym/9toXjlX4EebaG/RoTSDNrwxh7pr29XUD2FcdKwZQn0fM+fP7iuN XuKg== X-Gm-Message-State: AOAM532cN6mFDD4oR2SXICf7+BwfomVC8Ml6aq9LrKc6b6G3Da+H0Jcy O9Xm9r4KFVDKQRvmPTqQ5CG/6AMWlLY= X-Google-Smtp-Source: ABdhPJyW6/eo7p9K54Vvl072fTYA7gHXy/vs5BzmhhMbmYP+49xJ2JAnHIR8KWBBcHl58hCCZDKbHg== X-Received: by 2002:a05:6402:a45:: with SMTP id bt5mr2669162edb.101.1603754983034; Mon, 26 Oct 2020 16:29:43 -0700 (PDT) Received: from x1w.redhat.com (237.red-88-18-140.staticip.rima-tde.net. [88.18.140.237]) by smtp.gmail.com with ESMTPSA id q9sm6642658ejr.115.2020.10.26.16.29.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2020 16:29:42 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 1/8] elf: Add EM_RX definition Date: Tue, 27 Oct 2020 00:29:28 +0100 Message-Id: <20201026232935.92777-2-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201026232935.92777-1-f4bug@amsat.org> References: <20201026232935.92777-1-f4bug@amsat.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::535; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ed1-x535.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , Magnus Damm , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Yoshinori Sato Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: Yoshinori Sato RX's ELF machine is not defined in "elf.h". Added it. Signed-off-by: Yoshinori Sato Reviewed-by: Richard Henderson Message-Id: <20200814131438.28406-1-ysato@users.sourceforge.jp> Signed-off-by: Philippe Mathieu-Daudé --- include/elf.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/elf.h b/include/elf.h index c117a4d1ab0..d9bf4a95d86 100644 --- a/include/elf.h +++ b/include/elf.h @@ -172,6 +172,8 @@ typedef struct mips_elf_abiflags_v0 { #define EM_UNICORE32 110 /* UniCore32 */ +#define EM_RX 173 /* Renesas RX family */ + #define EM_RISCV 243 /* RISC-V */ #define EM_NANOMIPS 249 /* Wave Computing nanoMIPS */ From patchwork Mon Oct 26 23:29:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 301920 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5E71C4363A for ; Mon, 26 Oct 2020 23:31:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 35EEB206DB for ; Mon, 26 Oct 2020 23:31:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bIW7W8qm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 35EEB206DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55132 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXBxy-00054Y-0o for qemu-devel@archiver.kernel.org; Mon, 26 Oct 2020 19:31:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59034) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXBwE-00038h-6h for qemu-devel@nongnu.org; Mon, 26 Oct 2020 19:30:07 -0400 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]:40995) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kXBw9-0000H1-Vv for qemu-devel@nongnu.org; Mon, 26 Oct 2020 19:30:04 -0400 Received: by mail-ej1-x62a.google.com with SMTP id s15so11930615ejf.8 for ; Mon, 26 Oct 2020 16:30:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2OjR/wUfEEBugepvrkgMq+mri256jiLmUAh08vclpww=; b=bIW7W8qmw+I/hh1l0NKHHt88h0LKNmG1nWv8jbPk/BlX3yFIeVyaP3k6FnhhM59K1w 7BbUMwMCNQUrFlXYfq+G72Rtx69AFlvfv6W3P8mGhfP9UwzOhAxN/kyHDIjGrkTbtFfc caun4lWhNcXLOUmZZd7f4+q5BrrlOj3y7VvE2yLoAvSxkqnb3p9WweQPkOWQjcUudwaN 9DaCeMV8Qj6cNGqKGemQwTopNAH88ez5OUnWWyR3BZCqZbnKEx6qrH91AVSB+GyqlV7V amVKbCIcgqGWvrVX0/3HGTCM81MVLwmhO9hCRhnXvKkabcJ+4gGtrbiQ5dp725luku38 LIww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=2OjR/wUfEEBugepvrkgMq+mri256jiLmUAh08vclpww=; b=aOoAFcrBmW0busG236DPUH/IkrY+L5d36WLSJGuvGOti+M4diRoz/UZjsWqGK02x9Y DJGfc6CKeJNGfdGgEQWi170rLqH0JeBbxbGf94gpMLmKBq9qwqQ6/wQvlsS7g/IgrG9n ddbtTtwFUQo3h5USKBdla2Q1y0mJrRhYJjyrqdh8ml+4O/W/CDhKQGudYuRAxnxd8nad 9Bl3qpTuTQNqyQFBHANWpvpptIkEYo3Q2oZmkqAmvewayhPEycvuoAi9Wk/ihWvGKD7b 18Wevp13yk3ifDY87YlNQT4DoJEUze9AyMsDOcUrvGURv6NBLxVTHiy6ca+CLwiWn80S 8PPw== X-Gm-Message-State: AOAM530NSSTv1X22MQvvd14eBc90dkIzJgvxRIN5nI0gAQq8PDJNKZjH y+Dc9T8zIn8LbTSxVOzKdIuXFkV9XkU= X-Google-Smtp-Source: ABdhPJxnD0XrshsqAsbiYsU2dfkGZR59jox1zaGn5TYf4myTczI15Kve6jh4wb/d/oTcBm9nte9C/w== X-Received: by 2002:a17:906:1107:: with SMTP id h7mr17808599eja.481.1603754999863; Mon, 26 Oct 2020 16:29:59 -0700 (PDT) Received: from x1w.redhat.com (237.red-88-18-140.staticip.rima-tde.net. [88.18.140.237]) by smtp.gmail.com with ESMTPSA id n22sm5969260edr.11.2020.10.26.16.29.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2020 16:29:59 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 4/8] hw/timer/sh_timer: Remove superfluous "break" statements Date: Tue, 27 Oct 2020 00:29:31 +0100 Message-Id: <20201026232935.92777-5-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201026232935.92777-1-f4bug@amsat.org> References: <20201026232935.92777-1-f4bug@amsat.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::62a; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ej1-x62a.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , Thomas Huth , Magnus Damm , =?utf-8?q?Ph?= =?utf-8?q?ilippe_Mathieu-Daud=C3=A9?= , Yoshinori Sato Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: Thomas Huth hw_error() is marked as QEMU_NORETURN, so the "break" statements after this function are just dead code. Signed-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20201020153935.54315-4-thuth@redhat.com> Signed-off-by: Philippe Mathieu-Daudé --- hw/timer/sh_timer.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/timer/sh_timer.c b/hw/timer/sh_timer.c index 934daaa7dcc..58af1a1edbd 100644 --- a/hw/timer/sh_timer.c +++ b/hw/timer/sh_timer.c @@ -125,7 +125,6 @@ static void sh_timer_write(void *opaque, hwaddr offset, /* fallthrough */ default: hw_error("sh_timer_write: Reserved TPSC value\n"); - break; } switch ((value & TIMER_TCR_CKEG) >> 3) { case 0: @@ -139,7 +138,6 @@ static void sh_timer_write(void *opaque, hwaddr offset, /* fallthrough */ default: hw_error("sh_timer_write: Reserved CKEG value\n"); - break; } switch ((value & TIMER_TCR_ICPE) >> 6) { case 0: @@ -152,7 +150,6 @@ static void sh_timer_write(void *opaque, hwaddr offset, /* fallthrough */ default: hw_error("sh_timer_write: Reserved ICPE value\n"); - break; } if ((value & TIMER_TCR_UNF) == 0) { s->int_level = 0; From patchwork Mon Oct 26 23:29:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 301917 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDC7AC55178 for ; Mon, 26 Oct 2020 23:33:49 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6DBDB207F7 for ; Mon, 26 Oct 2020 23:33:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nCDVqzfH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6DBDB207F7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35070 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXBzo-00006E-HK for qemu-devel@archiver.kernel.org; Mon, 26 Oct 2020 19:33:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59076) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXBwK-0003BF-4T for qemu-devel@nongnu.org; Mon, 26 Oct 2020 19:30:15 -0400 Received: from mail-ej1-x62f.google.com ([2a00:1450:4864:20::62f]:33455) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kXBwF-0000JD-B5 for qemu-devel@nongnu.org; Mon, 26 Oct 2020 19:30:10 -0400 Received: by mail-ej1-x62f.google.com with SMTP id c15so16522189ejs.0 for ; Mon, 26 Oct 2020 16:30:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ByHyPPqDa1B0Z2A0GB22PMBVgYYCiahQCzikXG3rHfE=; b=nCDVqzfHJDfKssmIVW/lJS3qdYaCfFEqyYwpayAM5sTxjHLP0WJjNHlmIqKcGgS0RW 7qvqDPL5AVXF1DgaTBqTtbSsx3w9OUPzg48I/tqniVHQA8U+80b+SnKOlDmy65HeXE3M HTKu3i1ZDkrZYqwl8VsD7oNCDoqx0FANLGbdkaqacc0T/LWaki1wFdiWt2uy+wGlbcl4 FaHwsERLQosvuqd/zksmqlpmSCNIZFM25+IYK11CUf/GTSYqlJZ+LbbpWsyRkjMcBIrW D8GsIFUXNqBRepLJ+0JFunPVQQPZUBv9nP7VhG/QAWiz+0e//nR2soMTjhcSs1uasXbU alQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=ByHyPPqDa1B0Z2A0GB22PMBVgYYCiahQCzikXG3rHfE=; b=H5cb9QBBnxbyDncBdc9oy+E5f1PUhntD75+B8mMzE+nsAd30C7JIk5JKdSPdKPsveb AeYThNa00Tuczrp88Ob0CmGBTk10Ev4bfm8WP18bU9v+23eyDIcrI7l/H6TBA0n3ZVnG e0OFya3ld50Jocb35Y51a3z8GLrq1UZXykRPudjtpwC/egLXmPoxtsgn/Oc7gCgjVk4K u0SrEttEee9JaxqnMEt0NmpyzMZUICSXF3ssVqjOjDJ0fmU505NE/lF9EOs4HbZvtsxM 2A4kSbxpYJFgNI6/yLz3J9oIJqctphW8xOeob4w0jxvAispy/pUdLKPrRWmhDKRgX02g lIcw== X-Gm-Message-State: AOAM530KdRK27aefvcqULdesZmdw9jfSMm388lesugLppFey/ENkiMWG xBnV2L46AtJDrF2f8AF87XMvd7SJjRY= X-Google-Smtp-Source: ABdhPJz2kjBKqV0Pjh0ofWny0kDlaRA08V2CrKQXUnnZRnuvqs+G6Kf3MM4Czb/b7pedng1X9deghA== X-Received: by 2002:a17:906:4351:: with SMTP id z17mr17968767ejm.110.1603755005557; Mon, 26 Oct 2020 16:30:05 -0700 (PDT) Received: from x1w.redhat.com (237.red-88-18-140.staticip.rima-tde.net. [88.18.140.237]) by smtp.gmail.com with ESMTPSA id d20sm5907484edp.85.2020.10.26.16.30.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2020 16:30:04 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 5/8] target/sh4: Update coding style to make checkpatch.pl happy Date: Tue, 27 Oct 2020 00:29:32 +0100 Message-Id: <20201026232935.92777-6-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201026232935.92777-1-f4bug@amsat.org> References: <20201026232935.92777-1-f4bug@amsat.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::62f; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ej1-x62f.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Magnus Damm , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?b?w6k=?= , Yoshinori Sato Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Avoid checkpatch.pl warnings in the next commit. Signed-off-by: Philippe Mathieu-Daudé --- target/sh4/op_helper.c | 8 +++++--- target/sh4/translate.c | 8 +++++--- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/target/sh4/op_helper.c b/target/sh4/op_helper.c index 14c3db0f485..fcd9ac7271c 100644 --- a/target/sh4/op_helper.c +++ b/target/sh4/op_helper.c @@ -398,9 +398,11 @@ float32 helper_fsrra_FT(CPUSH4State *env, float32 t0) /* "Approximate" 1/sqrt(x) via actual computation. */ t0 = float32_sqrt(t0, &env->fp_status); t0 = float32_div(float32_one, t0, &env->fp_status); - /* Since this is supposed to be an approximation, an imprecision - exception is required. One supposes this also follows the usual - IEEE rule that other exceptions take precidence. */ + /* + * Since this is supposed to be an approximation, an imprecision + * exception is required. One supposes this also follows the usual + * IEEE rule that other exceptions take precidence. + */ if (get_float_exception_flags(&env->fp_status) == 0) { set_float_exception_flags(float_flag_inexact, &env->fp_status); } diff --git a/target/sh4/translate.c b/target/sh4/translate.c index 60c863d9e1b..ec5b04889e1 100644 --- a/target/sh4/translate.c +++ b/target/sh4/translate.c @@ -1959,9 +1959,11 @@ static void decode_gusa(DisasContext *ctx, CPUSH4State *env) NEXT_INSN; switch (ctx->opcode & 0xf00f) { case 0x6003: /* mov Rm,Rn */ - /* Here we want to recognize ld_dst being saved for later consumtion, - or for another input register being copied so that ld_dst need not - be clobbered during the operation. */ + /* + * Here we want to recognize ld_dst being saved for later consumtion, + * or for another input register being copied so that ld_dst need not + * be clobbered during the operation. + */ op_dst = B11_8; mv_src = B7_4; if (op_dst == ld_dst) { From patchwork Mon Oct 26 23:29:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 301918 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C0E0C55178 for ; Mon, 26 Oct 2020 23:33:48 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AFF2720809 for ; Mon, 26 Oct 2020 23:33:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MvwyJshD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AFF2720809 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34944 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXBzm-0008Ub-Rn for qemu-devel@archiver.kernel.org; Mon, 26 Oct 2020 19:33:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59180) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXBwX-0003H8-Ae for qemu-devel@nongnu.org; Mon, 26 Oct 2020 19:30:25 -0400 Received: from mail-ej1-x62f.google.com ([2a00:1450:4864:20::62f]:38745) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kXBwR-0000LW-Ky for qemu-devel@nongnu.org; Mon, 26 Oct 2020 19:30:20 -0400 Received: by mail-ej1-x62f.google.com with SMTP id ce10so16481129ejc.5 for ; Mon, 26 Oct 2020 16:30:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pEqSKEMY04puZYBT7KxO2knLfSLveelIAXH747evHJ0=; b=MvwyJshDxZ7tllBWWiu5xhHIL9RNwRAgI4uwjqbfbGzpZ/IWd5K7angs5wbpSQ9+Lv s5hYBNlY2/yoOZ3RpSjBhr/qGv6UbO+NsJW1XN0JUUtuKLUJ7vZntIfx8ykQSESk2aUM /kCdvka9J8xwaHlX8Su+cnH2mzkswJD3wkXcJmwRxCvQ0BxcjrDxTU3TgsjlRQWfUZ6Q xQ7dP6aRamwnnpsre4q/5NJ7MjZ9+WTpVUelLq0spSuEbarGHzD4JJvrMWg50pwZ36pX 9f3sLzYk1hveFeFgftzGw/Qx6SuYkYbw99mK7XwV3eW9LMXS0gTKIjjgGj0KYopW87gq 3jWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=pEqSKEMY04puZYBT7KxO2knLfSLveelIAXH747evHJ0=; b=ERJcVN/Nd2wjOQdV4VstC/r7F+Ljgk7hnIif3U2xi4BZLmII5g/hMZRhjOVyFLeri1 NYCOZs4rs3gAxay5Vdt08CoRkmXKR0psq+CDp7+4PT4Ot0tr6dCwxyrc2Og1PxgeJdML L8o0dS88yRCyc4HduhAXUW9F5KHeFugpBydnJrcThkcaQhYHi7TtZxWMRISKWXXZgag7 fPkfwzzjfruQKxxT/KQg2a8OEelUozlk5HIP7YtZLX2uafYOx2quhjuGucWaUJ9HH3bH c+SXuupqUK9TcJfQXWSVwGt7wWS1UQFLs6Qj0dTR2BVZRPFtMPo4jTeU5tBGAvCQsYXp p0cA== X-Gm-Message-State: AOAM532yYraiZSdNmVIcEPvugRLzXgrEGZfakCy0VAbdzFM+kg1LVykt kh9N0IgXll8k5G0lpXqB2+5Mep7XVK4= X-Google-Smtp-Source: ABdhPJxNvylgZNUJpuhj3ahISda1unkvX7kRgyYwiHTUo5YBfCKnAe+6VQm2N0fIGUZLhoh9VOSmhA== X-Received: by 2002:a17:906:824b:: with SMTP id f11mr17585521ejx.16.1603755016520; Mon, 26 Oct 2020 16:30:16 -0700 (PDT) Received: from x1w.redhat.com (237.red-88-18-140.staticip.rima-tde.net. [88.18.140.237]) by smtp.gmail.com with ESMTPSA id m11sm5970344edv.14.2020.10.26.16.30.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2020 16:30:15 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 7/8] target/rx: Fix some comment spelling errors Date: Tue, 27 Oct 2020 00:29:34 +0100 Message-Id: <20201026232935.92777-8-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201026232935.92777-1-f4bug@amsat.org> References: <20201026232935.92777-1-f4bug@amsat.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::62f; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ej1-x62f.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Edmondson , Lichang Zhao , Magnus Damm , Philippe Mathieu-Daude , Yoshinori Sato Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: Lichang Zhao There are many spelling errors in the comments of target/rx. Use spellcheck to check the spelling errors, then fix them. Signed-off-by: zhaolichang Reviewed-by: David Edmondson Reviewed-by: Philippe Mathieu-Daude Message-Id: <20201009064449.2336-5-zhaolichang@huawei.com> Signed-off-by: Philippe Mathieu-Daudé --- target/rx/op_helper.c | 2 +- target/rx/translate.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target/rx/op_helper.c b/target/rx/op_helper.c index f89d294f2b2..59389f49921 100644 --- a/target/rx/op_helper.c +++ b/target/rx/op_helper.c @@ -318,7 +318,7 @@ void helper_swhile(CPURXState *env, uint32_t sz) env->psw_c = (tmp <= env->regs[2]); } -/* accumlator operations */ +/* accumulator operations */ void helper_rmpa(CPURXState *env, uint32_t sz) { uint64_t result_l, prev; diff --git a/target/rx/translate.c b/target/rx/translate.c index 482278edd25..9ea941c6302 100644 --- a/target/rx/translate.c +++ b/target/rx/translate.c @@ -1089,7 +1089,7 @@ static void rx_sub(TCGv ret, TCGv arg1, TCGv arg2) tcg_gen_xor_i32(temp, arg1, arg2); tcg_gen_and_i32(cpu_psw_o, cpu_psw_o, temp); tcg_temp_free_i32(temp); - /* CMP not requred return */ + /* CMP not required return */ if (ret) { tcg_gen_mov_i32(ret, cpu_psw_s); } From patchwork Mon Oct 26 23:29:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 301916 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50688C55178 for ; Mon, 26 Oct 2020 23:36:13 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C74F8207F7 for ; Mon, 26 Oct 2020 23:36:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fCXmF8Fb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C74F8207F7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41444 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXC27-0002xP-Sg for qemu-devel@archiver.kernel.org; Mon, 26 Oct 2020 19:36:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59192) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXBwa-0003Jd-RV for qemu-devel@nongnu.org; Mon, 26 Oct 2020 19:30:28 -0400 Received: from mail-ej1-x631.google.com ([2a00:1450:4864:20::631]:39284) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kXBwV-0000M4-L5 for qemu-devel@nongnu.org; Mon, 26 Oct 2020 19:30:26 -0400 Received: by mail-ej1-x631.google.com with SMTP id bn26so199882ejb.6 for ; Mon, 26 Oct 2020 16:30:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=W3Vv/QCWXUFg/foUe4To3UqDPWKAHvwPLF8rKVguBJk=; b=fCXmF8FbDBx/SIXLzr9WdkSYJwYMIY27zgNwbRw76qP71b6mwta7DeMxs1l1QjgtWi kSqYM2FCYTySMzjjU/gDQPafT5NySt+MnXK9OfQWhOpqdAmGaGkqrkSwjtmPlywIDCJd 7bDXDW3XNEsf4KgqbvKMT2eBsROMVze9fqnw1M4U4d3PBSvzRViVrtniRwBbtSh6MdoG vMpDGvneGZt2LioQEGXlPCGhjThYKGhLI5ORB/zgXISx6tsAhAKxY5GHOjaHDl7T9LtG 68zf+vSvi8H09IzkZe9QXoLuvjm2cpxSOG6iSssQS+FZfWamdwGO0iTZ4qTu3I/9EzkL SP0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=W3Vv/QCWXUFg/foUe4To3UqDPWKAHvwPLF8rKVguBJk=; b=g9m7+S96Y3kVo7VVy4YAJ1ZHISRErRO4bZw7JjNrQ3bg7XHELEYVljG5xBYxN7G74U nDbnFLrHDK1aXpOQIijTvwj7lgz/RmIZK/e6BoC3BudL+/fdRMD/heL6rUfdKxt7pZzL d6v7ptGuBrUTRlurYqm5T8kqmadcrFJ2zuCf1b//PDp6CIRBIQRVsIN6PjzF3B47khP1 0V/CKD5p1Y8fnFSOqu6mHXsK0FcSob2VABhF83LXQQbNI0sZU2oBRxYff+0kUhQVRPAL S2IZMyv7q0lSM4sSzkyFESGK+QIJRD7uDUgHm1ee87qK840XFAybhYpVutUe4nINWbbu N7EA== X-Gm-Message-State: AOAM531cf//dLtxQLpH9l2BIC9rMCRt5a3KCnPrum5DXzP3GVRjv5iSa cXCkqHSGndeCobg/H7v00pHg2No0MNE= X-Google-Smtp-Source: ABdhPJzAvg8E4+MptrAi3QV3nzihfSdPJcEzv7+ee50wxEtscV190cgXAxvcNu8UjBkmvpHhuMtpjQ== X-Received: by 2002:a17:906:3406:: with SMTP id c6mr17140314ejb.65.1603755021949; Mon, 26 Oct 2020 16:30:21 -0700 (PDT) Received: from x1w.redhat.com (237.red-88-18-140.staticip.rima-tde.net. [88.18.140.237]) by smtp.gmail.com with ESMTPSA id t15sm5948010edr.27.2020.10.26.16.30.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2020 16:30:21 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 8/8] target/rx: Fix Lesser GPL version number Date: Tue, 27 Oct 2020 00:29:35 +0100 Message-Id: <20201026232935.92777-9-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201026232935.92777-1-f4bug@amsat.org> References: <20201026232935.92777-1-f4bug@amsat.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::631; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ej1-x631.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Magnus Damm , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?b?w6k=?= , Yoshinori Sato , Chetan Pant Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: Chetan Pant There is no "version 2" of the "Lesser" General Public License. It is either "GPL version 2.0" or "Lesser GPL version 2.1". This patch replaces all occurrences of "Lesser GPL version 2" with "Lesser GPL version 2.1" in comment section. Signed-off-by: Chetan Pant Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20201023123840.19988-1-chetan4windows@gmail.com> Signed-off-by: Philippe Mathieu-Daudé --- target/rx/insns.decode | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/rx/insns.decode b/target/rx/insns.decode index 232a61fc8ed..ca9334b37af 100644 --- a/target/rx/insns.decode +++ b/target/rx/insns.decode @@ -7,7 +7,7 @@ # This library is free software; you can redistribute it and/or # modify it under the terms of the GNU Lesser General Public # License as published by the Free Software Foundation; either -# version 2 of the License, or (at your option) any later version. +# version 2.1 of the License, or (at your option) any later version. # # This library is distributed in the hope that it will be useful, # but WITHOUT ANY WARRANTY; without even the implied warranty of