From patchwork Fri Jan 5 09:44:04 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 123484 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp591674qgn; Fri, 5 Jan 2018 01:44:28 -0800 (PST) X-Google-Smtp-Source: ACJfBouu8FBChm8IlN2MQXaW4oUMz+icP6+S2ILW5Jf3jXYp4d4JIcREbba/J/CyCNrnPRlr7ooJ X-Received: by 10.84.253.137 with SMTP id a9mr2475091plm.253.1515145468106; Fri, 05 Jan 2018 01:44:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1515145468; cv=none; d=google.com; s=arc-20160816; b=JrKxQqyV3qsb4ruUQ1Hu4ZsSQYtXfn1AFnKE4Po7KsTu49L78LoDgv3bbwJi+C0egR yYO5VgIztawtEEmy0FvJ3yJhIsqVny/YvaLl/9qSI+bNzepp8apANOijQLi/iaNz+V7t gCqzoK/O5FFDmF9MXzxVe6ZQ9BXB4HZ6ZtGaRECs3mccsXHDULNNvK0RhcJlgYSA0syY NVNnGRaJRlVbjsULGjJmYx7/PkjIyqdMxQRl+yF5oy8RyHO61V8uax+EJWoC2Q26hSIT 0EWJnFaO4uRst0RQBSl3lZ5OwREFZJ+5CGImbtvJq3Krc8A8t8FhzBLgCZg5tGNW3cwJ O5ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=dNIgRRoC2k91YrrCiwPbO3FmzMjFdXhr8IIiYPFvZUo=; b=zhgbUiizJ244MtiUQiWVfiwb7dARFIJeczExzZQ2J8OGYKy+JXjlibD8yNStNifST5 JAaxQorsaiHMgV88fjY9fG3k0Ibokh9sf9sqwC2tNAT9JCvU4plXUwRStZC1MURp/VZs hU6tJ7icynTcPuKKA1ZHcXAFTjGuJQgV3lRCmbw/uzSmhZ20k5hEvXmHV6nnUi7iXYij IxhiNWJ4wQ1HXrdtLIt6PqWjK0zCmH0YDZlF30pTiXaG5n6IbWamgTfFgcARXYIO9qSI GDGMJoLZ9fRKBIuDJ2lzSTPaUYMcvEXwwYLFNQldSLjeWp7ulrXkjIQMyfM4yv148Mn7 sE2g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z63si3817014pfl.241.2018.01.05.01.44.27; Fri, 05 Jan 2018 01:44:28 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751490AbeAEJoY (ORCPT + 24 others); Fri, 5 Jan 2018 04:44:24 -0500 Received: from mout.kundenserver.de ([212.227.17.24]:57450 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751262AbeAEJoW (ORCPT ); Fri, 5 Jan 2018 04:44:22 -0500 Received: from wuerfel.lan ([95.208.111.237]) by mrelayeu.kundenserver.de (mreue105 [212.227.15.145]) with ESMTPA (Nemesis) id 0M8ztN-1eceOY3vYb-00CQYL; Fri, 05 Jan 2018 10:44:16 +0100 From: Arnd Bergmann To: Hans Verkuil , Mauro Carvalho Chehab Cc: Arnd Bergmann , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] media: cobalt: select CONFIG_SND_PCM Date: Fri, 5 Jan 2018 10:44:04 +0100 Message-Id: <20180105094415.2839559-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:pJV9qzHYoAIXwybtt3eQA8B4793x1u9nGGf/hR+YKzNi8OceRh+ 0NTNgV9n0+MPEQ4ip6my3MPfRmg8OiMy+ZyHuREGkNkSosfBeqPe1DJHemc381k0+wsUjLg 66S8ZBA9k6bWvxkolnwAt5+SLVUsKPGmvEuGH4n4kJ31XoGECTOG3zV0JHj6Iu6ireJtcQV DfkyIitkRTWxw2VXYxuTw== X-UI-Out-Filterresults: notjunk:1; V01:K0:4kzTV4EP6DY=:NiUf54wETGos9JtWw+BeMe +T/reg9uZtVWGtxVHKWf4V3/96v7ahI2IpIdmfqGXJwdk2rJF45RmlIkFCr24/GMvf+v54Td8 xGz6hjXO0gT25LqkLwwUWqL9LWKZVim520YY8NJxj+DQyliqdqXiSfXuGdZsnusqc2qLkf9/2 WMVd01WFpmvAWNgtyqugcd3eGKMnRSLFkcML7g6dB3LayREs3jcLTgRe4hytIg2FTHUuSuTls ekTaJbaS736sOnGwqW0rrgpSp7/h12s387hT2D+Rgd3ZolvbtxSe0SteRsgK7H14xC5kIwm81 Oi7TkYqba+O5c0F/Q9Kwx8S9BcwE7xCjAX1pfIo+uFgp0JahDlWqhi2L08692VGUAdyyvz2ov axdUH0mdh+nRLzUElbo2AExDbrKjcytG4SLL2W8HfvipoYV1Rcr0l7dHVZtoVqSJgpvauCdme V3duiGkjF4ItbAQMvYD4ZSsWf9+EHzrQvkperiIlR1LnbtRmkLeBe5ywM0goy/z82ZGr3gynp yymSL7DkCcx6awJlw4CqSMTlW1Y1HPneXSV13D1f6APkaGSHykzpijzG8xz7MQUiofSWiM9JF xIqjzDP2SP9WO8DzFECYsSPym0vwriiH4Gj1V2u5mlQ3V2qHDglcTus3NHemuhiDBFqu4QY33 ZJrOmGRJJOziXQ7P4iUHC7NpgZQDzRcC+qVGdY6+qS+ZTcjVnHfVsA2Nlbx8ellHagzKt/GG9 mKsboCoDbgzXOcTG6KyBWMv6Lefw2YRqYqpf/Q== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The cobalt sound driver has a dependency on ALSA, but not on the PCM helper code, so this can lead to an extremely rare link error in randconfig builds: ERROR: "snd_pcm_period_elapsed" [drivers/media/pci/cobalt/cobalt.ko] undefined! ERROR: "_snd_pcm_stream_lock_irqsave" [drivers/media/pci/cobalt/cobalt.ko] undefined! ERROR: "snd_pcm_hw_constraint_integer" [drivers/media/pci/cobalt/cobalt.ko] undefined! ERROR: "snd_pcm_set_ops" [drivers/media/pci/cobalt/cobalt.ko] undefined! ERROR: "snd_pcm_stream_unlock_irqrestore" [drivers/media/pci/cobalt/cobalt.ko] undefined! ERROR: "snd_pcm_lib_ioctl" [drivers/media/pci/cobalt/cobalt.ko] undefined! ERROR: "snd_pcm_new" [drivers/media/pci/cobalt/cobalt.ko] undefined! The other audio drivers select 'SND_PCM' for this, so let's do the same. Signed-off-by: Arnd Bergmann --- drivers/media/pci/cobalt/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.9.0 diff --git a/drivers/media/pci/cobalt/Kconfig b/drivers/media/pci/cobalt/Kconfig index 70343829a125..aa35cbc0a904 100644 --- a/drivers/media/pci/cobalt/Kconfig +++ b/drivers/media/pci/cobalt/Kconfig @@ -6,6 +6,7 @@ config VIDEO_COBALT depends on SND depends on MTD select I2C_ALGOBIT + select SND_PCM select VIDEO_ADV7604 select VIDEO_ADV7511 select VIDEO_ADV7842