From patchwork Fri Nov 6 21:49:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320841 Delivered-To: patch@linaro.org Received: by 2002:a92:7b12:0:0:0:0:0 with SMTP id w18csp1656918ilc; Fri, 6 Nov 2020 13:50:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJx1O3ctqJZQsgMXPBLl9AmGTc1C2iwbEOdkxb2mZVz1QXpKR/66DY2lPDqYNfRDgZS1SMEr X-Received: by 2002:a17:902:c084:b029:d6:b04a:b091 with SMTP id j4-20020a170902c084b02900d6b04ab091mr3148156pld.14.1604699401558; Fri, 06 Nov 2020 13:50:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604699401; cv=none; d=google.com; s=arc-20160816; b=ZPQHKbC3O3ZK4Qyp0o2Yf3gUblauiapnpTg9ta7EJTC04XPmaTt0B9z1cN/vxSW35i lBNeqhl79jZR0IKhq4R5KoN61wlAzrSQeEOVWwhViE5ILX2khWrbJEcuVCzb8E77X9QZ wRHYRw5NI/ix2QEaJflEmFgp+eO5UDaPBmOK64PietBaDU0FWdlhVD1q/T9gydpBd1gZ H70RybPOyuUKV3pc/rxA16JHza5q751sZSwHVZ/VKGRHWK5N+PuR0/YHqGbcr1CqC53o uaGuHD3zWtUwlAFc3J8aIvG+VVL26Pl3uvAa8Saf86dPjXhleB2XJArCn8XmEXOx+f2d Qtig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=x5GsSW9J4Mu/LentdPimjJiHlyCPyLqwjcIHwcpzQWk=; b=EAiNnuqKuXmyX7SYlrwZA9iijx/qdqkgyhgObT2EigHD9Q7Q0vH5vdEwVA60SVe6Ym Xmh8TjKIOBuZt3hO1/6uErA+mrpSXsaYf3W1ooFZ2TlMpt2ZA/V297ULgQFF2pKmkewN u4NyI9EGb2IFBrLcaGT0F2mdiQWSjhFtIKQm2nyyyhHZ1gUge2lsEaAEaDtPisJwm8HB 3x7CmjNduGPZzLuKJl8GsbTw5EBcyPA9R8Ke5u7eQYbPOMjiI/wVyuXkGH9yURHcFhAp OMV8TuUeIfqj529BNS2aVefMWbcSErrtZq4m8YISXAcno5/ch9+F5oDkRy5DU2WUS+hj jj0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=cRpiXYso; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id q30si2092044pgk.93.2020.11.06.13.50.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 13:50:01 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=cRpiXYso; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 844BF6EB1E; Fri, 6 Nov 2020 21:49:57 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8ACBC6EB1E for ; Fri, 6 Nov 2020 21:49:55 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id w14so2773492wrs.9 for ; Fri, 06 Nov 2020 13:49:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xPa36hbXRaCWHNKBNpsuuGTQcILERbE7+3Txd9Olckk=; b=cRpiXYsoYNFoqQKy6HN5L54gAQBJro5vQdbxqra3rZdwMubGOsuA58ftK516DBSs9w GfisJZOZifFFHK0+b3c+rwTW3EZj5pa3Qk8EP+YQond6DzGj6v3pxICy+0LYt3QJRgeC JdtOA2zJhY6yREC+w0s13kcQt8bi3GnpjMTUNybsESi/R49bwNwLvfhUzvfndgSntarZ gg0wIhsUmnT7BYGuuPSZ6i2qVs4D87b0qXpN0Na843lQ7CVoopJbVgDTUVm3fBKqQRQF MlqkPf6NkgtOkYCLb6/MBEgySUT7djXYFMV70RzxJHU6oaquZE9VB4sGHH9u5d8F0TGF PU8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xPa36hbXRaCWHNKBNpsuuGTQcILERbE7+3Txd9Olckk=; b=iV4eTgjpOv5zEoDXDKfn2GLDwuaMPSQQYnBj8ti0MFQn/BlFS54d13sqW8Jz5RirO4 4vQyqohAuxVuJqm9pXpdiWplXNadr6oqPOZaOjk/NQzhZSJ7hU1jx+fwSBe/AxmA2p1y cBTTCjngT2vCqk2Lkc9TdCM3vxgY7SxnVdjZDvEoRLBt8l/URD5zNQTElEgAGySc3oTF E4+aLXGHw7A7Vlz2xTUslnnbMpAfKFuR6lrOZ13nq7tKH+VzrQjOscXVrLrUEBGF1/3D ExLtElFwvI1P0KcRUdeNtSobh6avHTgYK2McHdH1LvQdK6vLJJnzYoZo9Py4z9jQdLbw 4kwA== X-Gm-Message-State: AOAM533QEhPj1PBFehc/rf/uoRtyRC9XSnXxCcQw+HKs/3zBQESRi5CR IfX8C4i8UEoZiumkhd8cexCESuV1XOSlU4sk X-Received: by 2002:adf:a54d:: with SMTP id j13mr893436wrb.132.1604699394143; Fri, 06 Nov 2020 13:49:54 -0800 (PST) Received: from dell.default ([91.110.221.236]) by smtp.gmail.com with ESMTPSA id t199sm3981084wmt.46.2020.11.06.13.49.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 13:49:53 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 01/19] drm/ttm/ttm_range_manager: Demote non-conformant kernel-doc header Date: Fri, 6 Nov 2020 21:49:31 +0000 Message-Id: <20201106214949.2042120-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201106214949.2042120-1-lee.jones@linaro.org> References: <20201106214949.2042120-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Huang Rui , Christian Koenig Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/ttm/ttm_range_manager.c:46: warning: cannot understand function prototype: 'struct ttm_range_manager ' Cc: Christian Koenig Cc: Huang Rui Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/ttm/ttm_range_manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.25.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel Reviewed-by: Christian König diff --git a/drivers/gpu/drm/ttm/ttm_range_manager.c b/drivers/gpu/drm/ttm/ttm_range_manager.c index ea77919569a2e..e0952444cea93 100644 --- a/drivers/gpu/drm/ttm/ttm_range_manager.c +++ b/drivers/gpu/drm/ttm/ttm_range_manager.c @@ -37,7 +37,7 @@ #include #include -/** +/* * Currently we use a spinlock for the lock, but a mutex *may* be * more appropriate to reduce scheduling latency if the range manager * ends up with very fragmented allocation patterns. From patchwork Fri Nov 6 21:49:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320842 Delivered-To: patch@linaro.org Received: by 2002:a92:7b12:0:0:0:0:0 with SMTP id w18csp1656953ilc; Fri, 6 Nov 2020 13:50:04 -0800 (PST) X-Google-Smtp-Source: ABdhPJzjhW9lkwZkUg/UHiaAmZGAbTH5vlhd28zKFTl/W8HC5jga9Vnhg4oegZooh5jqYLp9XYag X-Received: by 2002:a17:90b:1990:: with SMTP id mv16mr1672628pjb.49.1604699404364; Fri, 06 Nov 2020 13:50:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604699404; cv=none; d=google.com; s=arc-20160816; b=MBc7qSaShtCiMfP8wECunHA0ssQ8ksIHwTF5hIPwMlQ4vnLbBxDhIn3Uv+2+VB1v2s zUnXLkKbSA7ECoSeji8XQYXhaPZFtdBJPAHkJ+7WT/uyKPgnq9uOtOg8FuXopFCXZMkl ov/KqfcckM8KjROD5kyUMDrmJOUgrMlmYvqv9QoCNSsWI13rro//DA52y8wwnsvDL9PO P6bm2cs2yCZ+dKcP2FS2TuKILH3dRMmjjhYDVp3P6h06TR6HiIAeRfhrm+eQW/N6j+oY EWzWe9ghPpwLsigxKe51bhuJdPyGB0wUgb5vPMgp39Fcj+MSMH8N1gVDXwrU6CZAS0dl u50g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=km5I+OLsaDBrj9nuqrk063zxavgRBs6ESiaGMeh0BmM=; b=pneGXddLRnMjV4VoPu7q0u0Y0ywyPLfmjuhWgDI3HG/NDjwmuRvLKTkglKrobBmB8J msc2vxkUaGB2VtdxHq0EbAnYDrEVQVAmFLI9jy0XHfeULIiKDwhqYnw/y5dyr0ma7Fql q9fJhHpM9IkZvBxEqf8db/fUP8UIZrUH1kzX+gL86T10ekyi9Yf5wHwXEF7wvi461F7x yw5RfPASI3YACsitqQ70Xr9EYruA/Zcb3XLyguiX8PkzLknn7nCMoC1O7WvN5OWuFLlH 9u6krz0Wya1s+0d8mqvatMNY274ULW97fm45EeBBr+rnLS8v24Pw3H+eLM2z5EQWC952 yvZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=pfSMSQsc; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id y15si2189620plr.269.2020.11.06.13.50.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 13:50:04 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=pfSMSQsc; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AA2916EB20; Fri, 6 Nov 2020 21:49:58 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by gabe.freedesktop.org (Postfix) with ESMTPS id 011276EB1E for ; Fri, 6 Nov 2020 21:49:56 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id c16so2655698wmd.2 for ; Fri, 06 Nov 2020 13:49:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=X9TskLA8s6lsCaAvrmgVECkRi2+nWhb2pEMdbcj9ssA=; b=pfSMSQscAEe73YfdvPqoah0YUiDgsKi5tci2ntaEc+AOw7EFT/Rjz/9yaQ8JOlnuqg sjsCyUHP2m7SSEbuESRncBhPT0/U3T3mBIzd8oVeLEgQ2vkMSiXn6iU/egwDLfoCiHID WmKn5aUfrKNLjV/95GLV+jN/7folMFY6MmdF8W3AabVdy+YgBrI2xYHqDVVSIRcuwwv9 7dq40V4sfIu+gPKsuuqemhSRIdc1Eep9RErKn3hNocCTBW1i6HuUBuK9rWOqxqyRQcK7 fTuXB9watBMFV0B7V0N9jyN5D+ISmPnGsOhSY4Me+8AK107zbLEUh25TPoiu4oaoxKn3 ZN6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=X9TskLA8s6lsCaAvrmgVECkRi2+nWhb2pEMdbcj9ssA=; b=YX9+FD5ZInkF7qEhJXJkUcKqK6POiKZXvmqXAq7Se6gVlxRq/5dFJvsexdnZ5A0mZb sgTDoT+B+yoyIJi/Q9p7qBHkqA7gqGewjpDr5wEEIxCgUB5ZGSuSv3WJipEJ3Hk4Mt4S Hv4dQukrvMrlsmXQd89y2FCSYmL+2/AKShkvD4WtFweo5LQRUaX73U/vNdVKtKmFxNgg SNKJPp2LFr6AA08aQOCua1o2SnU2nlo79kI1ULBhi+nGfwn+MHBDjYnIDI/B88kIu4HN 9JJK44NTk4/+wRSRlKNRdeNfpH/2psLPj64Xt1JplGyEUQkf4fck+4EhAZJ5j12wu2Ck yAbw== X-Gm-Message-State: AOAM531OJ2nbNwu8ALf5CJS86RcZIyqwMu7j8OxiAx9cX4kib0x4h2in C+K3e+Qj/LNOc0+Ga4TCd/DcvQ== X-Received: by 2002:a1c:e056:: with SMTP id x83mr1688640wmg.83.1604699395695; Fri, 06 Nov 2020 13:49:55 -0800 (PST) Received: from dell.default ([91.110.221.236]) by smtp.gmail.com with ESMTPSA id t199sm3981084wmt.46.2020.11.06.13.49.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 13:49:54 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 02/19] drm/r128/ati_pcigart: Source file headers are not good candidates for kernel-doc Date: Fri, 6 Nov 2020 21:49:32 +0000 Message-Id: <20201106214949.2042120-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201106214949.2042120-1-lee.jones@linaro.org> References: <20201106214949.2042120-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , dri-devel@lists.freedesktop.org, Gareth Hughes , linux-kernel@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/r128/ati_pcigart.c:2: warning: Cannot understand * file ati_pcigart.c Cc: David Airlie Cc: Daniel Vetter Cc: Gareth Hughes Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/r128/ati_pcigart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.25.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/drivers/gpu/drm/r128/ati_pcigart.c b/drivers/gpu/drm/r128/ati_pcigart.c index 3e76ae5a17eea..1234ec60c0aff 100644 --- a/drivers/gpu/drm/r128/ati_pcigart.c +++ b/drivers/gpu/drm/r128/ati_pcigart.c @@ -1,4 +1,4 @@ -/** +/* * \file ati_pcigart.c * ATI PCI GART support * From patchwork Fri Nov 6 21:49:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320844 Delivered-To: patch@linaro.org Received: by 2002:a92:7b12:0:0:0:0:0 with SMTP id w18csp1657032ilc; Fri, 6 Nov 2020 13:50:10 -0800 (PST) X-Google-Smtp-Source: ABdhPJxSpYJganynNKpiDJZkIJN7Xe/CzGnBX9OZHNTouvZiQ6hFivm/3xg2nLdtB1CclEaord/O X-Received: by 2002:a17:902:d695:b029:d6:a255:ae32 with SMTP id v21-20020a170902d695b02900d6a255ae32mr3286207ply.43.1604699410495; Fri, 06 Nov 2020 13:50:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604699410; cv=none; d=google.com; s=arc-20160816; b=PAT3JHUmQVrzMWmLwXUYNMyItqQm5xNQZzrdo5Bp3V68PX2Ul4AuntD5tIEHkboyTW 8djG8x6mKwkmVHjw6cbn0rlhWtNfHuYcT71eFEd1BResUJy9Puow7rqCrZFGFTeDUtfQ MzttVJPjnNZ5PN/tZNApBd9aYDKWuQl/QmR+i1c1RRwTnnpMajeXvPzYG97hOtZDgvYZ qE1HtMhlmRhL2koiDnrHXbwJqNrb+axWAawmJUpS92VeZX+ktsd6nd/nyXRXIwyRfUs3 4BHl/GePDrQkOJ2ModfD+yShgBUKKUS5MCRdN3iKRXjNI4nCgwd9hNPNdXX4fqZ7+rip JjeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=l8R3mkubPvmSxWxRwQANtIkqmwHpFyJvBMuc1nj9aZA=; b=tdBPcdZ05ePllNKdRr0xVlYddnz+PwWCwNquFbw6W7fJfUlbzhOabRAQj32zcPYF7j SaFZYyoiikBa4GksfRsUGob5Oe1k2ntrh0ZOnwaHSNw2UvCB4Wmir1MBaMpYBf1bNRRY QMdAGQD0Hojl/3g/v7afKk8c6ez38TCrdUBy6FmLK5G4Km3VRotah65T8yKaOM6DnbwZ 9TLRomhgV27GjuPtIo2izOVQdHFd+c4RRi47mzyC9d7qzjr239TDCJG3YydsKDwBiTKw a5h/bx9ILrqPTVySsY+inRzOgnJeYIKg1GXl8MypbYFz0ysuhP97itliQadVT4jtsoiw jJhA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=TRvyCyTn; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id e18si1968029pjp.77.2020.11.06.13.50.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 13:50:10 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=TRvyCyTn; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 570056EB23; Fri, 6 Nov 2020 21:50:02 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2177C6EB22 for ; Fri, 6 Nov 2020 21:49:58 +0000 (UTC) Received: by mail-wm1-x344.google.com with SMTP id v5so2842386wmh.1 for ; Fri, 06 Nov 2020 13:49:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SmOPpMPfhIiNWLmfD425Vh4v6mCQcNCmoMGuMYmd5/A=; b=TRvyCyTnH/kQfSvaUF+4Mph7uYU4vkWmNwmMg9+BDBN6t+igCS95yEeZ4LEqh4XUXD R8eISkv5gAP1hNdQMKo8Ygf8Gve+fObVMUpbtkUZRz3t9vj+Rl5hLbsgS8TFMxYL1psx k2F/jE4BkilaJVkYfuqAELthkI0vmyfkkO8Sa7LPXqf0E8s41v60oHpJqCPM9CYOUw93 kFpqUD4NcLPRLJidrtSOKH515bDJ0/3XSArh4XbtdFHSMyCN2yhSMT34nqX25CCKGZpC k3MoG3RpKjMZ29E2uQ4EUbT3Dc9v20vXEg8ajge2Yhd2lTgTdopSaE0V/2USYSKYzNG2 OhGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SmOPpMPfhIiNWLmfD425Vh4v6mCQcNCmoMGuMYmd5/A=; b=EarrfABm0pbNEn34VtNOK2h08sVAcCVmRjK/Pz9om/ua65iY1ty4UUpf9BTTZosShd YbPVZFJgeh3YvzDX6dcjYyPmS8N1R0ukZayy48oa9+/T1IYNMilq9aMwCkt0RTd/S+wI vZnf6vtE3EnqXqGNVNJyG4+sAmBGWj95ka+Z4kFh8WXO83mVWGRaQJ90XyW3e7gY0RU3 HDWe912LllgqR6hccFFkC4rAw220S8TqgRV/U1/lXcysz2j41UvnYwbNo0xi/pdCHfe4 aylmGdt6O+AJRW87oUyGb40CjnlOpHZjmTcikZgH5ng8ffAqfXmGjwgvsZTRxtlIr0GV x/Sg== X-Gm-Message-State: AOAM532AEdw8exMOGoFOUgD/NyphKXUoliDKGr49COVFwvRBrLg9LDd0 B8TiculKkaXYQtDp/YuWcoGlKw== X-Received: by 2002:a1c:c90b:: with SMTP id f11mr1681391wmb.54.1604699396872; Fri, 06 Nov 2020 13:49:56 -0800 (PST) Received: from dell.default ([91.110.221.236]) by smtp.gmail.com with ESMTPSA id t199sm3981084wmt.46.2020.11.06.13.49.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 13:49:56 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 03/19] drm/selftests/test-drm_dp_mst_helper: Move 'sideband_msg_req_encode_decode' onto the heap Date: Fri, 6 Nov 2020 21:49:33 +0000 Message-Id: <20201106214949.2042120-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201106214949.2042120-1-lee.jones@linaro.org> References: <20201106214949.2042120-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" There is too much data being stored on the stack. Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c: In function ‘sideband_msg_req_encode_decode’: drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c:168:1: warning: the frame size of 1072 bytes is larger than 1024 bytes [-Wframe-larger-than=] Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c b/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c index e00bdc557f880..6b4759ed6bfd4 100644 --- a/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c +++ b/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c @@ -122,7 +122,7 @@ sideband_msg_req_encode_decode(struct drm_dp_sideband_msg_req_body *in) { struct drm_dp_sideband_msg_req_body *out; struct drm_printer p = drm_err_printer(PREFIX_STR); - struct drm_dp_sideband_msg_tx txmsg; + struct drm_dp_sideband_msg_tx *txmsg; int i, ret; bool result = true; @@ -130,8 +130,12 @@ sideband_msg_req_encode_decode(struct drm_dp_sideband_msg_req_body *in) if (!out) return false; - drm_dp_encode_sideband_req(in, &txmsg); - ret = drm_dp_decode_sideband_req(&txmsg, out); + txmsg = kzalloc(sizeof(*txmsg), GFP_KERNEL); + if (!txmsg) + return false; + + drm_dp_encode_sideband_req(in, txmsg); + ret = drm_dp_decode_sideband_req(txmsg, out); if (ret < 0) { drm_printf(&p, "Failed to decode sideband request: %d\n", ret); @@ -166,6 +170,7 @@ sideband_msg_req_encode_decode(struct drm_dp_sideband_msg_req_body *in) out: kfree(out); + kfree(txmsg); return result; } From patchwork Fri Nov 6 21:49:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320843 Delivered-To: patch@linaro.org Received: by 2002:a92:7b12:0:0:0:0:0 with SMTP id w18csp1656984ilc; Fri, 6 Nov 2020 13:50:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJxRt8jOmOdXgmIGMudfPkBl+TkR3VTXZtEBAoJORXOta+zCiUHDsuYNn27IXja6qHOBTlCb X-Received: by 2002:a62:7d89:0:b029:18b:86d4:7cbe with SMTP id y131-20020a627d890000b029018b86d47cbemr3863629pfc.77.1604699406734; Fri, 06 Nov 2020 13:50:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604699406; cv=none; d=google.com; s=arc-20160816; b=DR2Br8U71lQVHkjGNdPLbXYIhV06eiuFIR3q7iJVc8wRONKfy5JTa9Tqoci1aomXoZ PNYyKLzX2QENrA5BbaUch0iMreCPIqWUvLy1yCSTUGs/fVAePM0H7tQud/qzjtyANX3+ nwgZGp4D6ksDKzlU2C7RWKoNqFWkwsfuuNl8Bja5VgzjGbCwAYrlHUXdr/1SpRwS2sYU +haLqMETUwFeI5yREfb1vjkuTLsFP8+OdUkFjTjkJ+rOGhwnWysgU1yQkQEHRZ1gpfl1 yP/47m7LSrKuCruq0YIPDF8pjP6Q0xLmEhFGG3DoovV9MHR6WtVYuOYK4XtSdszdHbfl fhKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=8+gdX+gh51TVLnSYPtHEk4A9bwCBlqxTH0DIfuGtUeo=; b=DA5ehsaVUhJYJxW+daTTc2sQsAueGARoAaGBox6UdFsazWhwYbJuN8MXsqTT/FTHxI MzGSjb253vtYe/Kv3hd5316Q3qMsg1ymOty5d8/p99hI/YsF8/UXVKFK66V7vhMu8YTH qZTdTYHrXgtwKyMogvJODHXWH/0Pvk6gveR8wkMypr8ZOdYvvS4zFscOWvs9u0nN67Bd yVh3e5rz9J0DdIA9WTKrZdpWVojW8dM7ahVmOg1qdQJYSOqjatQu+olFWZKUkiFf6qIi +1bFpjqep/CzA6mcLePqsG+M2kMZRouwjoS0HgrcJob1jynFbkrV25nLioi7tJVJYtY0 Bi9A== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=M9M573Ul; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id b3si2330849plz.416.2020.11.06.13.50.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 13:50:06 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=M9M573Ul; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 023996EB21; Fri, 6 Nov 2020 21:50:01 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by gabe.freedesktop.org (Postfix) with ESMTPS id D40A16EB21 for ; Fri, 6 Nov 2020 21:49:59 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id k18so2644582wmj.5 for ; Fri, 06 Nov 2020 13:49:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Ue3FoQJoMgBlIukOkf8MbD26USrDaAOvZdGWpXVWbrY=; b=M9M573Ul/P22elihygTSgOrYwuABiN98HcCxBcTWjwtR/8XWlIeqsnJqVrqplr+Hbg GxfTPhYgAI24Bg2FrOkqrWiJyxdQSNoW9Zs5VayctWxJnd/T+j87Q/fxsK8UbQP1P/Bq TZq1XFZ7jWuuaX4IYcHZ54/M2M9toRE3AVLih/FcyQV/FIjNj9473s2waCQlrFrvFeID WgLqtNbMWWQ8gYQjgfpQDsvRtohrRa812F4p0/ahW0/ySpdooIQAwRHlOcslW4PwDPb3 PSHC43NNEID/ErdejNgSQtwoCLol9B+ChkkArGESsdmRpq9LdGUO1TBYtSMrIaY4vmlf KhcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ue3FoQJoMgBlIukOkf8MbD26USrDaAOvZdGWpXVWbrY=; b=M60q/yFt8rrZDDKJD3ysaSfqbB1I2qK0MZGax212mAtYYpTl1KE9VvPscjAW6LMw/w HHK/tx5No/2Sqkg+6b86YBmTeuNJW5TEeRdZXAvqrVFERtIGsj4u9FwjQKjCG54hqjRo Kdx6zGYYsKXuklL5EClHHTepMPwH/duiCN7K/2P+9SbcrlDqgSw3evn/rVQBlv1pTfLA cg3kunLI0+lwhjjSZwsb0v5UmJRwDmQkyv29xwCzzkLOvtjWjlUg2b7ZPdAbPHY2YHW9 iF81lmYtFqua9fgA7HfhtxWVyw/kw0nMUpjW3/mZcnWHEa7hzTnpYSs6b2A2+hOoSphs oKDQ== X-Gm-Message-State: AOAM5330UG3K2toowF8NJF0YxtIKpLw/gfofrR3OG7HuA1776WAKCrw7 qdxhBZHFD4xeirmNYP6mi1u3xe9w6WyWqlJi X-Received: by 2002:a1c:f20d:: with SMTP id s13mr1718240wmc.156.1604699398532; Fri, 06 Nov 2020 13:49:58 -0800 (PST) Received: from dell.default ([91.110.221.236]) by smtp.gmail.com with ESMTPSA id t199sm3981084wmt.46.2020.11.06.13.49.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 13:49:57 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 04/19] drm/mga/mga_dma: Demote kernel-doc abusers to standard comment blocks Date: Fri, 6 Nov 2020 21:49:34 +0000 Message-Id: <20201106214949.2042120-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201106214949.2042120-1-lee.jones@linaro.org> References: <20201106214949.2042120-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, by , Faith , dri-devel@lists.freedesktop.org, Keith Whitwell , Jeff Hartmann , Gareth Hughes Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/mga/mga_dma.c:29: warning: Cannot understand * file mga_dma.c drivers/gpu/drm/mga/mga_dma.c:455: warning: Function parameter or member 'dev' not described in 'mga_do_agp_dma_bootstrap' drivers/gpu/drm/mga/mga_dma.c:455: warning: Function parameter or member 'dma_bs' not described in 'mga_do_agp_dma_bootstrap' drivers/gpu/drm/mga/mga_dma.c:629: warning: Function parameter or member 'dev' not described in 'mga_do_pci_dma_bootstrap' drivers/gpu/drm/mga/mga_dma.c:629: warning: Function parameter or member 'dma_bs' not described in 'mga_do_pci_dma_bootstrap' drivers/gpu/drm/mga/mga_dma.c:1150: warning: Function parameter or member 'dev' not described in 'mga_driver_unload' drivers/gpu/drm/mga/mga_dma.c:1159: warning: Function parameter or member 'dev' not described in 'mga_driver_lastclose' Cc: David Airlie Cc: Daniel Vetter Cc: by Cc: Faith Cc: Jeff Hartmann Cc: Keith Whitwell Cc: Gareth Hughes Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/mga/mga_dma.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) -- 2.25.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/drivers/gpu/drm/mga/mga_dma.c b/drivers/gpu/drm/mga/mga_dma.c index 85c74364ce24c..1cb7d120d18fe 100644 --- a/drivers/gpu/drm/mga/mga_dma.c +++ b/drivers/gpu/drm/mga/mga_dma.c @@ -25,7 +25,7 @@ * DEALINGS IN THE SOFTWARE. */ -/** +/* * \file mga_dma.c * DMA support for MGA G200 / G400. * @@ -435,7 +435,7 @@ int mga_driver_load(struct drm_device *dev, unsigned long flags) } #if IS_ENABLED(CONFIG_AGP) -/** +/* * Bootstrap the driver for AGP DMA. * * \todo @@ -610,7 +610,7 @@ static int mga_do_agp_dma_bootstrap(struct drm_device *dev, } #endif -/** +/* * Bootstrap the driver for PCI DMA. * * \todo @@ -1143,7 +1143,7 @@ int mga_dma_buffers(struct drm_device *dev, void *data, return ret; } -/** +/* * Called just before the module is unloaded. */ void mga_driver_unload(struct drm_device *dev) @@ -1152,7 +1152,7 @@ void mga_driver_unload(struct drm_device *dev) dev->dev_private = NULL; } -/** +/* * Called when the last opener of the device is closed. */ void mga_driver_lastclose(struct drm_device *dev) From patchwork Fri Nov 6 21:49:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320845 Delivered-To: patch@linaro.org Received: by 2002:a92:7b12:0:0:0:0:0 with SMTP id w18csp1657046ilc; Fri, 6 Nov 2020 13:50:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJw/MI76pMvquQvSNdA2U/6xerfTkRupQm3mro3Fk7+8MQ62iLhuDZazk2UvDO//3M+JRBcu X-Received: by 2002:a63:3041:: with SMTP id w62mr3372018pgw.166.1604699411971; Fri, 06 Nov 2020 13:50:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604699411; cv=none; d=google.com; s=arc-20160816; b=gI44f0GBMBB+iTcv6V/HCOZz5ajASJXHn4Ow7AwwJF7KB72uUNc2QyYQjLihWYAgOF CwWIsqRFZDC2iWBrsjAmNIaIdKN1a57kj3Ph19Vl3XNdfIMc7a4vc5+oMvc2Q6mca6vo FQ7TPrQEicXV9DCfncyr6hBYzX7HermfR/HW2KdN4yhpS+k6qctDHEuIs6Tg1zgUbN9K nkt8ey4oM44PR2Kf/eoygZ16s/RVLbDxUGMCl6UbCodoELO62NbEiSlk6a2tZF+cS7Ll iF+/GTH88W5nOIjel/7isb4KecNtAEg3rL382BZMtMYSWWYabzcNHhDpTR2aKfCzooWT egtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=m7rFZqEGChchV1X2td7Lx3WGa3BCZqQtNkzbYSADQoU=; b=Z6nX7L0kGphCXS3++t7F11U9h96FkzrPkO5F8wmlgQX5jXOUINUdGuK7uPAiM7YmC4 pdA77YZIeULVzbVniG6sOtJal6v9sYj/64h1XneWpiK++aoPD+iXbBFJvCBJ9TkW3XH4 AhYTQUXnNpjB0FgNhgyTZuZE71+p/lNA0qp6pMM38QxpQSBw1ZUY3oOitiKbS/NtdNUv u8ae4DwgZdHbEMYZyGYbNLu0uPTL6f1J+19qiEZredS4d1t9zT5vEYgGAJunDUZENIkr OUFBKO5B33WOhtHAjWCsc0LwPH5NlWXxPrMfsRIAMYcAro63sDi2M5cWWN+XJc/mnwKx YdQA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=uu5CGwOh; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id z18si1984932pfj.123.2020.11.06.13.50.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 13:50:11 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=uu5CGwOh; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 269A26EB24; Fri, 6 Nov 2020 21:50:02 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2E1816EB23 for ; Fri, 6 Nov 2020 21:50:01 +0000 (UTC) Received: by mail-wm1-x344.google.com with SMTP id v5so2842489wmh.1 for ; Fri, 06 Nov 2020 13:50:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/yTQMc6a66cwUFoQYWGGyiO2EU4ADWxZkG+2OvZt+WM=; b=uu5CGwOhSh+kpjSSd4FX+GvasU7eWip8CDp0IRaYQIF5N1TIYgU5kTexPHmzjkcK5D rTMLSCA6JSbeVTgKQKc0amCA0raDfgjYOkfCwhHq6PPFHEqV2O2FThee1nR93MVA41DF vznj0gRfU91Nt7HHqrhb1lHlpEqH573c8ytllAEtmVkmRqGXc7tF+34xrKGJQ+2DtLBi q4Qgut7OuPIbGSw2oNfsoZxevt2fuKfP00Wn4+I3MglnWzYYBwbbhQxF2x/EzvEfJ29K m1x3flrkiiysoh9NkBkFMCBloyKb7FbsxskEnnXG//znSHi7DxDSXACWic4J5SZHaJrg kTxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/yTQMc6a66cwUFoQYWGGyiO2EU4ADWxZkG+2OvZt+WM=; b=J3Jf1ZnzH9J98E49ZjydeY3LQ+iVN0MCCma2n+gbuFV8cFEN5d4utIG02cSR4ld7T3 hXDMIbhHo1L/ZExxStBIjoxB8+VDempYUSHeFJbe0C8B17Y2GolWskRvqNioDw7DOKRv pizUdA/AGLQFUDeA6KIvLLljZ3TLNsX6C/jIOpCowL1hCRxevQlNn4+M6uHyQw18RWKd 8eZREjQ3vi6HS3H773C5KdFGszFUZr1u6aez5fv9B7eSiCKTVUcmfM/MR/iA0+b4Q6yW YNwhpYsNajjEDnn2/Yu5O/c/Qm7GfQeCKt1+p8hvIQKJhtJr903meECUa52xlxQWoTxx V3ew== X-Gm-Message-State: AOAM531QfTHOUBVvqBotSh/KYjqRPNfrWlYwGWf6wKXGLmoqPU7VBK9E n+GjaM1OdWpPAar/EdgGhC0fXg== X-Received: by 2002:a1c:8087:: with SMTP id b129mr1656632wmd.10.1604699399772; Fri, 06 Nov 2020 13:49:59 -0800 (PST) Received: from dell.default ([91.110.221.236]) by smtp.gmail.com with ESMTPSA id t199sm3981084wmt.46.2020.11.06.13.49.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 13:49:59 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 05/19] drm/mga/mga_state: Remove unused variable 'buf_priv' Date: Fri, 6 Nov 2020 21:49:35 +0000 Message-Id: <20201106214949.2042120-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201106214949.2042120-1-lee.jones@linaro.org> References: <20201106214949.2042120-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, by , dri-devel@lists.freedesktop.org, Keith Whitwell , Jeff Hartmann , Gareth Hughes Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/mga/mga_state.c: In function ‘mga_dma_iload’: drivers/gpu/drm/mga/mga_state.c:945:22: warning: variable ‘buf_priv’ set but not used [-Wunused-but-set-variable] Cc: David Airlie Cc: Daniel Vetter Cc: by Cc: Jeff Hartmann Cc: Keith Whitwell Cc: Gareth Hughes Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/mga/mga_state.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/mga/mga_state.c b/drivers/gpu/drm/mga/mga_state.c index 77a0b006f0669..0dec4062e5a2f 100644 --- a/drivers/gpu/drm/mga/mga_state.c +++ b/drivers/gpu/drm/mga/mga_state.c @@ -942,7 +942,6 @@ static int mga_dma_iload(struct drm_device *dev, void *data, struct drm_file *fi struct drm_device_dma *dma = dev->dma; drm_mga_private_t *dev_priv = dev->dev_private; struct drm_buf *buf; - drm_mga_buf_priv_t *buf_priv; drm_mga_iload_t *iload = data; DRM_DEBUG("\n"); @@ -959,7 +958,6 @@ static int mga_dma_iload(struct drm_device *dev, void *data, struct drm_file *fi return -EINVAL; buf = dma->buflist[iload->idx]; - buf_priv = buf->dev_private; if (mga_verify_iload(dev_priv, iload->dstorg, iload->length)) { mga_freelist_put(dev, buf); From patchwork Fri Nov 6 21:49:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320847 Delivered-To: patch@linaro.org Received: by 2002:a92:7b12:0:0:0:0:0 with SMTP id w18csp1657085ilc; Fri, 6 Nov 2020 13:50:15 -0800 (PST) X-Google-Smtp-Source: ABdhPJzWSp4qBPmB1WcWX598zqjqWwXWnKLb3FWNPHrGeNboSuH7b5iuXqALBSL4cU3DcoFIZU80 X-Received: by 2002:aa7:9699:0:b029:18a:e057:c44 with SMTP id f25-20020aa796990000b029018ae0570c44mr3862743pfk.34.1604699415609; Fri, 06 Nov 2020 13:50:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604699415; cv=none; d=google.com; s=arc-20160816; b=enpp6mNY1cZI71d6F/OHj2PTb9LFgloB1exJNvR5MMCmxeIk9L3aAvRdF30ayhXOBR kY6AY6MnMBdhjnWBeXhY5vsc2/3qn25tSon9FLaFwUNhrwHg2Qcg6s2tLVMVJiUAquFS SIdhsFJHbDxXLjlMHXqae/JWXp4PQPcy/2M/IhLcBFJMo5owyKPuuIHtkR6MrWZg9yUi PDE2fKe9gg6pPYaKlwgDoKgUTDBUmJJYphUF7rA+i9kzT2VlBgSzlHgCl760juat3JSf A/QgfozPUrlMQHdvdvO0QNGSPktOxa6At1cy65MKrunISj28Quam/CJiCO3OYrWBQwyZ GL/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=cjbq+/QTHPgHQ0z9xozke2lIFXtPHOtAYjuPmlOWABc=; b=RWWVhw5/JwZEMwPzyCrI2j7jaq6vN67XVsZdYi4a5wyGUQGRj1Imp/XBRCHsRDCE3o xrxUGIXhb4QDeqwG1fsj2yyZbCqwMv2mTCChqu9NKoDgVTYMAfkN44fj5/U6gF8y0Rlv LLcuj89x4/kA/X/dKxZYWc5KNfXi9Bv8JtRUOJ5FJeyB0DGET2j/aoYWXxEkAZgT1gXr Mo/2cTqq1OZozRmtXWWmqoZ3niRhmgGBWvO4zQ6BWbcY2GWQnMkVdgwKldgF5HRVlYq8 83E5/N3YKckYbH1qtRZ/9p2taJN8JOYpXoNsHGaD8/pnbxcQqlZIZBZ3KHQTuKHB1Fdu U9pg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=cVJbpGO0; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id t23si2146500pfc.114.2020.11.06.13.50.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 13:50:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=cVJbpGO0; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 460246EB28; Fri, 6 Nov 2020 21:50:07 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7EC476EB26 for ; Fri, 6 Nov 2020 21:50:02 +0000 (UTC) Received: by mail-wm1-x342.google.com with SMTP id 23so1771628wmg.1 for ; Fri, 06 Nov 2020 13:50:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=E44zAySPmawq+qLbsH9q5xt7WGcYQXLEVwBfYO570wQ=; b=cVJbpGO0mn9PFOK6wV3RI1ztFhosLDnGLAYO4ev3T9QpIRZ2SSqsEx8FWEUkN+upm/ HS8YHS57ONCD2IVwBKqTIIoyLLrbNFPelDe5IxCJ8PGsFiXgXqe7cLhkoTUrAoHixgZo KDP2patea7yG8pSvObvQ56FR4KjPr651sE8b30YFsZQO1CI2rUBjP+Jg9kQsXCsrIiYl kvdHKnkUFuKAF51usqRPb3FB+WAkJ3NKop0XNHNG/HonC/IukIGGjt2gWOzW3Yk3+aB6 L0qwyZria23XEQBZ4ZV4Z9dI8tXdlsT47zwq42PF50XnSulcKL9WAjNKbSUvqekGHt4W z3Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=E44zAySPmawq+qLbsH9q5xt7WGcYQXLEVwBfYO570wQ=; b=KN0FW05AbOlpfLoERBS7fkcI1Iwl5x3PV1wfDH+E06mIebyg/NSMIMRVVsqAcVr9Qd WGkFbFW+bNoWgnv4pmI67FlK39FgwDPTZhLFqWZ5hwj7Gjm00o2UC0TlVVYywpuC9N9d prFE96VuPaTCe6FJJ45TqkRVrjcLSWV6qLHUe6bXJWhRi8OI+YXAd794wp8kQcVLSq0n 2hhPz4hHPW0wI1OFLwAHjbuGWBcLphq34WWl9tCTFZEki8ANpRMfny/Dyt2kRSoHykiH 5j40Yn4h6nStjpPGOBbH5VslvrrlkNLU88Cwhwvqeq/Yueu2sGLOukqvXycHDTi40FDg wd0A== X-Gm-Message-State: AOAM532wtnZqfLCgwI+CZCqMJ6gnENPPnQ2NrNt8d7V36v65Rno96gGv 8ESaimnQNs18QzfEe72XQ3LNow== X-Received: by 2002:a1c:ba0b:: with SMTP id k11mr1557572wmf.37.1604699401085; Fri, 06 Nov 2020 13:50:01 -0800 (PST) Received: from dell.default ([91.110.221.236]) by smtp.gmail.com with ESMTPSA id t199sm3981084wmt.46.2020.11.06.13.49.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 13:50:00 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 06/19] drm/radeon/atom: Move prototype into shared location Date: Fri, 6 Nov 2020 21:49:36 +0000 Message-Id: <20201106214949.2042120-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201106214949.2042120-1-lee.jones@linaro.org> References: <20201106214949.2042120-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6?= =?utf-8?q?nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Both source files include atom.h, which seems like a reasonable location to place an atom based function into. Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_atombios.c:1791:6: warning: no previous prototype for ‘radeon_atom_get_tv_timings’ [-Wmissing-prototypes] 1791 | bool radeon_atom_get_tv_timings(struct radeon_device *rdev, int index, | ^~~~~~~~~~~~~~~~~~~~~~~~~~ Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/radeon/atom.h | 6 ++++++ drivers/gpu/drm/radeon/atombios_encoders.c | 4 ---- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/radeon/atom.h b/drivers/gpu/drm/radeon/atom.h index 1bf06c91cd959..cb93b83114dbe 100644 --- a/drivers/gpu/drm/radeon/atom.h +++ b/drivers/gpu/drm/radeon/atom.h @@ -154,6 +154,12 @@ bool atom_parse_data_header(struct atom_context *ctx, int index, uint16_t *size, bool atom_parse_cmd_header(struct atom_context *ctx, int index, uint8_t *frev, uint8_t *crev); int atom_allocate_fb_scratch(struct atom_context *ctx); + +struct drm_display_mode; +struct radeon_device; +bool radeon_atom_get_tv_timings(struct radeon_device *rdev, int index, + struct drm_display_mode *mode); + #include "atom-types.h" #include "atombios.h" #include "ObjectID.h" diff --git a/drivers/gpu/drm/radeon/atombios_encoders.c b/drivers/gpu/drm/radeon/atombios_encoders.c index cc5ee1b3af84f..85f903caf12e1 100644 --- a/drivers/gpu/drm/radeon/atombios_encoders.c +++ b/drivers/gpu/drm/radeon/atombios_encoders.c @@ -296,10 +296,6 @@ static void radeon_atom_backlight_exit(struct radeon_encoder *encoder) #endif -/* evil but including atombios.h is much worse */ -bool radeon_atom_get_tv_timings(struct radeon_device *rdev, int index, - struct drm_display_mode *mode); - static bool radeon_atom_mode_fixup(struct drm_encoder *encoder, const struct drm_display_mode *mode, struct drm_display_mode *adjusted_mode) From patchwork Fri Nov 6 21:49:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320849 Delivered-To: patch@linaro.org Received: by 2002:a92:7b12:0:0:0:0:0 with SMTP id w18csp1657116ilc; Fri, 6 Nov 2020 13:50:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJw4+05bzdQVnQI0bdUieXRIWYgVgUGolHdXl0jGBtzAGcJEadxsN3jUvZDNeehDVferQtiG X-Received: by 2002:a63:1e5e:: with SMTP id p30mr3300068pgm.159.1604699417997; Fri, 06 Nov 2020 13:50:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604699417; cv=none; d=google.com; s=arc-20160816; b=gAVCnBAAdyL0/l8reMdNYekEFQkxPfrQ8vmSVwJdA9hyQIFz360/Hwo3gUfK6mw5bk Og8GPeHRe+okGuTcTZ5Tm0Adny0TQnvZ3dLJT+R+sP/DZ6hpURSIqE4NYB63+vJafKHa DoIqsZ87jXqlh+Pp00nlqXscmx4GHNEKTeSn5TbdEibcFJmTDR224PsEmixn5CMZkuE8 MUeBMUxb+ixkoLCP+vgbbR6JkJPF/lxCupM0bIS9hMFZt6FDooUg/nO5i+NolFWzau1W NtRU+b1yTqqFhupaqXYmMsHouu5KWd1YGthxYCQIRaVAeuKAnacA2/lHR4fXZd4Dq67a qr1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=ZPGI+t2uUyMsGAUjtQqxPncpBOAq4UgIgCZM3s0XXZY=; b=lvUtJtsRd5GunRWqpxwJBl9W+YDZbN+l95tkWaa6oZUOXhFMKpCNDX2GSjtjBYvIDR qmd+OKS31e92hCymEG7b7rR/1/BotHzjGJyFef8C9U0nWIrW9TI2H4rMe5m+O+i/lM2N Ycuz5U1WiHkzGt2s4Lb+tnhwpBo2rg0siU75hcj+9YQNhctOX0RPFmJwl5y9ADEtYLd6 72tTuHP/V+MVILPoR2BLnulZ0JSi4qRULi5LHBhKPg6tyocJNkYN3N0IIDDFcqrA6+10 dD4AMcUvXsr8dDrkNWOcAojy2DvN1gjjDsNZAkYigOZcCi3N0+c3enxqD+/jU5mC5IKC v61w== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Gzq3IRI0; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id a10si2157915pgl.446.2020.11.06.13.50.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 13:50:17 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Gzq3IRI0; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0DE2A6EB2A; Fri, 6 Nov 2020 21:50:09 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by gabe.freedesktop.org (Postfix) with ESMTPS id AE9796EB28 for ; Fri, 6 Nov 2020 21:50:03 +0000 (UTC) Received: by mail-wm1-x344.google.com with SMTP id h62so2646777wme.3 for ; Fri, 06 Nov 2020 13:50:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vkQ+EXF2yvxMQDq5My2ZO6G3Ve/ySfBy90ygkHt2VtU=; b=Gzq3IRI0uTFVZlLkG4qnK9tDKHmeGHf2mKcsxo5k/h1Bg2Tv8V54kdCY9AHxJgSEPs r+ddfC6UKgvuGktLUD0J4MeReXJRe8D9mj8jmxwpjda+Blbkmmo/NxejuMXZKnmqryPV tOsi1wq4BJ6Ix3M2w7sZ5r2Mq9Xk+iazjCRbiP4qCoYmVzorxIgZMMyZQ9MEgPs/9zvF TwCO+hl7gCCuh8YRq88MEFHPz7Te9KdEsbrLCjKGDkMsG4rypxZFbZ27YEaobgDFV4WB iMpXoWS9j+cBHUnPyuPpO22zo/9LPEyWSS2QNNcMyESyZYCS7f4/GglC1fKpXEZcZcwS 5JWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vkQ+EXF2yvxMQDq5My2ZO6G3Ve/ySfBy90ygkHt2VtU=; b=Ws4wav+5cObF5A0MS9zCwQYzPsfWHt5vsCiE9fmntNz7PYqx4wfYVDQXmHERSAFP1P y1Vx2AWleYaJZNmysnlUKeExqRhpK2pP4zsGrVt1UMyP56mlxwTSphQu/up675S76KpX na8D7GNMS+34dMloBy5XmXcKcwuZp/uKNM3qU5ApunJ5P7DNPWJ2H+ZL7P95qSExqsFr cmAGLWfrVW5vI/kQ5V/5SrLHlTjsyWBjgEJfV4b6Ho2GFgTr5dgCvAjvQT7ix5fzNk1i qJ5bC6jiWpUHTzdPfLV0Ec7DoRfqX6OT+ynOET+6Cr2pOR0HZFBXoMdCvgtYvibzXXhk v6XA== X-Gm-Message-State: AOAM530T/og64+N9g0fjwwgeOZ7oTZpOENqL83XvLHnYK18MdCRCRvSD HPzIny1GXPicXFuQmyo0sNU94A== X-Received: by 2002:a1c:9e93:: with SMTP id h141mr1524494wme.153.1604699402333; Fri, 06 Nov 2020 13:50:02 -0800 (PST) Received: from dell.default ([91.110.221.236]) by smtp.gmail.com with ESMTPSA id t199sm3981084wmt.46.2020.11.06.13.50.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 13:50:01 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 07/19] drm/radeon/radeon_kms: Include header containing our own prototypes Date: Fri, 6 Nov 2020 21:49:37 +0000 Message-Id: <20201106214949.2042120-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201106214949.2042120-1-lee.jones@linaro.org> References: <20201106214949.2042120-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6?= =?utf-8?q?nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_kms.c:61:6: warning: no previous prototype for ‘radeon_driver_unload_kms’ [-Wmissing-prototypes] drivers/gpu/drm/radeon/radeon_kms.c:104:5: warning: no previous prototype for ‘radeon_driver_load_kms’ [-Wmissing-prototypes] drivers/gpu/drm/radeon/radeon_kms.c:618:6: warning: no previous prototype for ‘radeon_driver_lastclose_kms’ [-Wmissing-prototypes] drivers/gpu/drm/radeon/radeon_kms.c:633:5: warning: no previous prototype for ‘radeon_driver_open_kms’ [-Wmissing-prototypes] drivers/gpu/drm/radeon/radeon_kms.c:704:6: warning: no previous prototype for ‘radeon_driver_postclose_kms’ [-Wmissing-prototypes] drivers/gpu/drm/radeon/radeon_kms.c:755:5: warning: no previous prototype for ‘radeon_get_vblank_counter_kms’ [-Wmissing-prototypes] drivers/gpu/drm/radeon/radeon_kms.c:825:5: warning: no previous prototype for ‘radeon_enable_vblank_kms’ [-Wmissing-prototypes] drivers/gpu/drm/radeon/radeon_kms.c:852:6: warning: no previous prototype for ‘radeon_disable_vblank_kms’ [-Wmissing-prototypes] Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/radeon/radeon_kms.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/radeon/radeon_kms.c b/drivers/gpu/drm/radeon/radeon_kms.c index 99ee60f8b604d..0d8fbabffcead 100644 --- a/drivers/gpu/drm/radeon/radeon_kms.c +++ b/drivers/gpu/drm/radeon/radeon_kms.c @@ -40,6 +40,7 @@ #include "radeon.h" #include "radeon_asic.h" +#include "radeon_drv.h" #if defined(CONFIG_VGA_SWITCHEROO) bool radeon_has_atpx(void); From patchwork Fri Nov 6 21:49:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320858 Delivered-To: patch@linaro.org Received: by 2002:a92:7b12:0:0:0:0:0 with SMTP id w18csp1657261ilc; Fri, 6 Nov 2020 13:50:31 -0800 (PST) X-Google-Smtp-Source: ABdhPJxGdHlWRSw2avxByDieqtsQPBJTZxm2hnXqk/1H90lULliiY4kqLu0+MphgDgV494MTvIam X-Received: by 2002:a17:90a:ea93:: with SMTP id h19mr1650460pjz.107.1604699431394; Fri, 06 Nov 2020 13:50:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604699431; cv=none; d=google.com; s=arc-20160816; b=00+kPOUPrXZ97br6o6V0Cj2C62i7fmfA4G304vhT9+Q/f8yhmHO+tcBWYXAXmngNi3 1GNfaPSMplKcTLudR5J96rDIwZu1oJXt8MFtIVZTljgDUSIZTr67GgJQu1iU3lrPx/ik q127CidUEJMrJmFxQr7F6CD6YMuLeQiIRPvLmNuDCVv7+k7VFWGmS5nbn3ICgqMR9ts0 CMs2jGh9iKtoz5etHXPdGQwai0CAiQs5GTsLEqgZ1+f0hHpx1WrYe0Ketn5WVik1dQYc xI3pp5hwQZBGMgI8xsnPUdbYtiu8U7i9fXBBrXGA38yM+7haaDF9ve3pvKktiwJiw9Ze P0Eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=nLhC2MYKjJUPQABNWSZayTOp++SvTIq2soqVOb6tw+A=; b=q4/Br+IA4Td+C1HCWaOEZZ6hg5zoezPYiZ4M9aJdxo/e7t+jhVboz7hrauiYhuNR0D UV9dTlZRx1X5pWJydSohTRFG6FEPG8Ir+EA0kzp+yKao5dSTROd+5FDR2LjYXQCb4siq T5FRIqtRmNms1DjDKO7w/Na+9p8W1W9lmIxsf1JV0UhGHzZDg4FjqtLKOSQ47TQt440C ZhAEIk5EhNzBJd7CVFKIH/uaMu5g9+0uCQXxA+o/wK9balDCpVdTnS3+MBTEemdZ/emD zdZzcSowIQbw0OWLV+njopNhv/w7RtH10zPMUvBraQ4FNJcECZf2BpkiNMV0IM/V2O1n AUBw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=u2YdzXP+; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id w12si2138410pgh.491.2020.11.06.13.50.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 13:50:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=u2YdzXP+; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2ACAD6EB38; Fri, 6 Nov 2020 21:50:20 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by gabe.freedesktop.org (Postfix) with ESMTPS id C616F6EB25 for ; Fri, 6 Nov 2020 21:50:04 +0000 (UTC) Received: by mail-wm1-x344.google.com with SMTP id 23so1771690wmg.1 for ; Fri, 06 Nov 2020 13:50:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=socaU7um35iwEdYbuZIG6DpwnbxHw+sI5ykPEkbUzts=; b=u2YdzXP+cI8hNzxPMwK6P2NcmDOFEzfBJQ1EpULD/0QTAzDAFswU3D9HeqnrXDaHgs Oy1MEtKUiI0ihnz/ecIt2Zgh/i8gi71GIO72wLjJAI/LL7YwzoMcf0+q+tmjnKo6QcuJ +Pey6urIMQgILLkxbg12Gxzk65TaqpK+n5BAvblzKUfHnkTnovij7Oz3MZsQst54SD4J nN9l+QaZBIpPJG2iHMDHMANkmJHJXM/PXJq3dYk1iUFhneAtRGIYLAUkr2iWoOZDT5V0 /pv6XxQ+ZFkcmR/MEtxE2C/os+HjFieodE3x8YaO2IXZw4PxzJnvCd0D5EwooPWjpxl5 FXig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=socaU7um35iwEdYbuZIG6DpwnbxHw+sI5ykPEkbUzts=; b=sgBkDvqx2yDds+KjxCqLYcAdgpH4yGp0rnYW/hLf1vAHtZCrJvOWzCBPSwful1LFVI JIWTw49sdIi5q/gq95RBDLA61n8YTHtRc13VQqG01N/8WBqIlHmuo6218toKMHgLVEjB r7XaZhBH3qbl9IpP0XpYsEGpuB+/jOV3ng8LVwzvWshHxTqrjfzfnAhEdetPC9nAnV20 mf8w5jdbQYTwnM3hOixrnC+2GcaDIsoqxJ/bxjg8ijK4geNBA7AW9jdvfW8MgkN3sqGF Nxigp27vcJPlSn2z0k9E2U++NH7Nd7YviOSGUR014leEEoUyCI6HUftZQkbgKl7fyx3C +xgA== X-Gm-Message-State: AOAM531TA1sPqkV8Bf6SkLxYS6hI5t+KiAhMorFkHAgdcgp4klwSCS6b C+z1SZFqfLhQiYT5IoauDh36Yg== X-Received: by 2002:a05:600c:210a:: with SMTP id u10mr1644995wml.98.1604699403507; Fri, 06 Nov 2020 13:50:03 -0800 (PST) Received: from dell.default ([91.110.221.236]) by smtp.gmail.com with ESMTPSA id t199sm3981084wmt.46.2020.11.06.13.50.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 13:50:02 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 08/19] drm/omapdrm/omap_gem: Fix misnamed and missing parameter descriptions Date: Fri, 6 Nov 2020 21:49:38 +0000 Message-Id: <20201106214949.2042120-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201106214949.2042120-1-lee.jones@linaro.org> References: <20201106214949.2042120-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, Tomi Valkeinen , Rob Clark , =?utf-8?q?Christian_K=C3=B6nig?= , linux-media@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/omapdrm/omap_gem.c:593: warning: Function parameter or member 'file' not described in 'omap_gem_dumb_create' drivers/gpu/drm/omapdrm/omap_gem.c:593: warning: Excess function parameter 'drm_file' description in 'omap_gem_dumb_create' drivers/gpu/drm/omapdrm/omap_gem.c:619: warning: Function parameter or member 'offset' not described in 'omap_gem_dumb_map_offset' Cc: Tomi Valkeinen Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: "Christian König" Cc: Rob Clark Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/omapdrm/omap_gem.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c b/drivers/gpu/drm/omapdrm/omap_gem.c index d8e09792793ab..0e5adfaae6455 100644 --- a/drivers/gpu/drm/omapdrm/omap_gem.c +++ b/drivers/gpu/drm/omapdrm/omap_gem.c @@ -580,7 +580,7 @@ int omap_gem_mmap_obj(struct drm_gem_object *obj, /** * omap_gem_dumb_create - create a dumb buffer - * @drm_file: our client file + * @file: our client file * @dev: our device * @args: the requested arguments copied from userspace * @@ -610,6 +610,7 @@ int omap_gem_dumb_create(struct drm_file *file, struct drm_device *dev, * @file: our drm client file * @dev: drm device * @handle: GEM handle to the object (from dumb_create) + * @offset: memory map offset placeholder * * Do the necessary setup to allow the mapping of the frame buffer * into user memory. We don't have to do much here at the moment. From patchwork Fri Nov 6 21:49:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320846 Delivered-To: patch@linaro.org Received: by 2002:a92:7b12:0:0:0:0:0 with SMTP id w18csp1657065ilc; Fri, 6 Nov 2020 13:50:14 -0800 (PST) X-Google-Smtp-Source: ABdhPJxY0RyQm18zlmO8wmyK+JRIAHlWXo+Z3Srdr4CwWY7Kb8GgqmWPis0IVDHIdZLryzJ96uuW X-Received: by 2002:a63:5f17:: with SMTP id t23mr3401798pgb.190.1604699413915; Fri, 06 Nov 2020 13:50:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604699413; cv=none; d=google.com; s=arc-20160816; b=Pqs5RJqId8tipHmOP0uMOSbe/j+j4V9Hkbe6DODn8Ht1TMVu6cNIP3kQJa+IlBZtVz ZP1Qpw0bJ2kp8PiHds9FvXDTFPPqrBfNMrJbxVmNQiLwWYCOkuFZhcWmbbW6T18tqMN7 9YEja6xcCbekROofFn3cFhKiq2hkLYoYoDreAUmUyu4yY0JwAg6x2LrpBkCj03KR0vpq XuUSdKGcuUQs2chDfwyuYN61nSXGWohjamWu7qimI35cN21ulfOAVYFqrf2KNHqyZYDz 0Hciicfcwnu5fV6Z2hF35EwrtPNxFdAmLwPyMf+sautcY7pM6fsHZQTku7hi2pJ/M/bt O7Lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=rOgN7b0Ak8ysy2LYcAXegirATyBQQdGG/eP6S9qgBqQ=; b=ofsVsWnAyWRY32d7N40nEBjmveeS8/4rn6DZmtHTqh9E+sMmNpz/WK0kAVB/VT9WyV H9MTO+Np3MQ3UMKIAUM3OtD4GwsA3abbOKCDqFefiDCYUF6TjwV5V0dLSIrMnvOOYfba I8pDUaDmGiqYa+/VOgzMaCy7I++RBS13Y7khaccoSiIyBsd/QEjpb0ki6GSBfof++ZhP mIuvIp8yHEjTzdMqdYRmrBtqz/GwdgInu3KjfijguLt/cHH5zlUeLQt9oxzklC+YpMbo AZaiTix1bYuwmPIWXcyU+1XtbWgtSBJXfI8328ZCVVEs6hflj1AwNMBAZy8K9EA8Z1e0 QDPA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=QWCbYIFH; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id 7si2162292pgp.203.2020.11.06.13.50.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 13:50:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=QWCbYIFH; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2B0DD6EB27; Fri, 6 Nov 2020 21:50:07 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by gabe.freedesktop.org (Postfix) with ESMTPS id 021BA6EB26 for ; Fri, 6 Nov 2020 21:50:06 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id 23so1771721wmg.1 for ; Fri, 06 Nov 2020 13:50:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=g3s/vNbQhCOhaWUYjnatK+JAnL9zFArhDEfxOk3yJ9s=; b=QWCbYIFHbnL6cvVci1njVHiIUyhUnpp3bWojQBoR2JpVYoexBntA0mWqhP0DaOE2fM M7A6HqqFQ7dsmueWwZcVWsA9lu9tHYweFv81kqWlo1c4FbFUtVgUaCvtZQkpWHDUnrWk hjnAtDgqlGXxpfXJuujeGzda1GJmOmIi9oIyAzvinNSYXX0/bqCAczSXaP964OnyZqnQ itH5RagP5FQTTjj4FyQddYro6+/8euDYjhwzlwQI2+M3D6xnTS1GANsk3X7PZrzs8kTK pNZ2tlRH7Kl64ZBNSGfJAK63+d4wrmV3FTejPZe/RLzgVbbvigIP1/ZdAD4BzTX3iJ97 berA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=g3s/vNbQhCOhaWUYjnatK+JAnL9zFArhDEfxOk3yJ9s=; b=RqaCfvFsMigUi+DlB0jlJ83Oytei/gnDl447IP8g5kEGaxwD4PVWqyFwhY3Pmd0q7w KhJbljG9EE4bSJBKwj+iZuR31w10mGhIvyHnD/9pw/36LzaS8hJ3BuiixpZeUs6XYjrP Fw0hBbheRcerad6OsMOdZm1Jr6TcA1H1TcYsVwNeRO8bdWG836hi4Yp8UdU9JHEwo40r 4RX0KkkojmMiqAQS8Fu609UqCv5XBVWuvmdMlpMsLSGTVldCZ6xbrxYup6fgNrxiYB8M paxQKJ52NKYQKlwCMyZPAohfzlmReoJGYnKNKnxQbe9pIxLI1u7JP5EuxwSI+1yrEeuR BzYA== X-Gm-Message-State: AOAM533R4nsi6SBh5c7ICFqim9CA5rVwNTte5EtIYhT3qYObhqW50aRy cRmnwXL2yZT+bwNOR8+7/KB/rw== X-Received: by 2002:a1c:4d4:: with SMTP id 203mr1615684wme.153.1604699404699; Fri, 06 Nov 2020 13:50:04 -0800 (PST) Received: from dell.default ([91.110.221.236]) by smtp.gmail.com with ESMTPSA id t199sm3981084wmt.46.2020.11.06.13.50.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 13:50:04 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 09/19] drm/omapdrm/omap_dmm_tiler: Demote abusive use of kernel-doc format Date: Fri, 6 Nov 2020 21:49:39 +0000 Message-Id: <20201106214949.2042120-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201106214949.2042120-1-lee.jones@linaro.org> References: <20201106214949.2042120-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Tomi Valkeinen , Rob Clark , Andy Gross Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/omapdrm/omap_dmm_tiler.c:313: warning: Function parameter or member 'dmm' not described in 'dmm_txn_init' drivers/gpu/drm/omapdrm/omap_dmm_tiler.c:313: warning: Function parameter or member 'tcm' not described in 'dmm_txn_init' drivers/gpu/drm/omapdrm/omap_dmm_tiler.c:353: warning: Function parameter or member 'txn' not described in 'dmm_txn_append' drivers/gpu/drm/omapdrm/omap_dmm_tiler.c:353: warning: Function parameter or member 'area' not described in 'dmm_txn_append' drivers/gpu/drm/omapdrm/omap_dmm_tiler.c:353: warning: Function parameter or member 'pages' not described in 'dmm_txn_append' drivers/gpu/drm/omapdrm/omap_dmm_tiler.c:353: warning: Function parameter or member 'npages' not described in 'dmm_txn_append' drivers/gpu/drm/omapdrm/omap_dmm_tiler.c:353: warning: Function parameter or member 'roll' not described in 'dmm_txn_append' drivers/gpu/drm/omapdrm/omap_dmm_tiler.c:399: warning: Function parameter or member 'txn' not described in 'dmm_txn_commit' drivers/gpu/drm/omapdrm/omap_dmm_tiler.c:399: warning: Function parameter or member 'wait' not described in 'dmm_txn_commit' Cc: Tomi Valkeinen Cc: David Airlie Cc: Daniel Vetter Cc: Rob Clark Cc: Andy Gross Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.25.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c index 42ec51bb7b1b0..cedaab456041a 100644 --- a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c +++ b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c @@ -306,7 +306,7 @@ static irqreturn_t omap_dmm_irq_handler(int irq, void *arg) return IRQ_HANDLED; } -/** +/* * Get a handle for a DMM transaction */ static struct dmm_txn *dmm_txn_init(struct dmm *dmm, struct tcm *tcm) @@ -344,7 +344,7 @@ static struct dmm_txn *dmm_txn_init(struct dmm *dmm, struct tcm *tcm) return txn; } -/** +/* * Add region to DMM transaction. If pages or pages[i] is NULL, then the * corresponding slot is cleared (ie. dummy_pa is programmed) */ @@ -392,7 +392,7 @@ static void dmm_txn_append(struct dmm_txn *txn, struct pat_area *area, return; } -/** +/* * Commit the DMM transaction. */ static int dmm_txn_commit(struct dmm_txn *txn, bool wait) From patchwork Fri Nov 6 21:49:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320852 Delivered-To: patch@linaro.org Received: by 2002:a92:7b12:0:0:0:0:0 with SMTP id w18csp1657182ilc; Fri, 6 Nov 2020 13:50:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJwQeai/Lr0ObPsNRAHuJrvxmDMhGnTPpEpE1EwW10wQ03948ipriypzWUC0+FF/Eb1pwQO5 X-Received: by 2002:a62:7883:0:b029:18a:e054:edf1 with SMTP id t125-20020a6278830000b029018ae054edf1mr3602763pfc.70.1604699422694; Fri, 06 Nov 2020 13:50:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604699422; cv=none; d=google.com; s=arc-20160816; b=hG64wc1+rcyd7C0LR1MZTUYj3AgmiP34XRfU/LrGLYW+niqDaVZs/dqxKm5Af36roT dg4Ue6peu0g/X8aDePUo4bwvE6McNq1evg3de6g73DLkSp648bMzN/aQVaNXdU3kq55W ybvqpYoyL8r+BBpPaeU2EavPMd74ACOWM8gwyUW1y2av1I3xXjZijn6/EIex6cOL+ycV vFPB6gNnFxU7vmUjJeEDtLq9+L6kmRjl5GhOL9F7ZKCzj7fy1rW5SP3PdsuCeSGGPskv FF7fxeq67YECBXPuJrZ7dXmtXyWRG52+sD1HE60CTBJ4Jye8c2rxOE5n5oFwtN1FDbyt XPkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=LDHo8BUNURxST+bo1UHsjcOMPIqn1JW/9WvLv2Y2UJo=; b=zzihVs9cXImekVd3k+QLdJOWhei+s3Dz4zOIwN/Ro/rWVxRhG6rECWvT/SUe/9zIa5 QSz16lYLkzTtF+/jtMpXu1L3xqic0U62vVpdOB5MI0p4BdFyU7KpBw/BODeC6LLMdxs7 jwSVhXi44cNjWB2bJTO9xsctNVs3y7OXfi9ti0FfnlmdjLbRv59g+o6dl9KVwR1XGGGp 9yZFj6x1PVVl4NbztBg1phStukb63xAoJFOd38sRfAWSURMwVQlprIKtgov8wXjvZajr ATIEfMjhFDZi3mpWMhpnXbLfcfBP1+9ndngjJ4RRNrzQ9AoXkbtw+JrPcV2EkrAEf+a+ S+eQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=eXZxFJ0D; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id p26si2171016pgm.183.2020.11.06.13.50.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 13:50:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=eXZxFJ0D; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AF4126EB26; Fri, 6 Nov 2020 21:50:14 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by gabe.freedesktop.org (Postfix) with ESMTPS id 631B46EB2B for ; Fri, 6 Nov 2020 21:50:07 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id c9so2843724wml.5 for ; Fri, 06 Nov 2020 13:50:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xaVwrMr6e/jbnTc5qGRYSEriQiljvoWqO6b2JcTWvj4=; b=eXZxFJ0DJnXnG4PTRnW4zbY40yCi26ZRguq8FgTlJbA5SNWLBT9jWR5zy1R2sUX1TM CMHOP+N7nrftop8HRYZB+EagLdSwgk3Z/SXWWqj/O97kqn1n+TDDyqo8b0KoNy3bReyb HPe4pHgcNYeo3m2J+aH4PH4Lc+6HNLQwlmWJ1Yqo5OXuPcc336PxwRnc7u3uPpoqoeQm EcbvtA9V1xc983pr9fJX2OQTH+ogpHZKb4opW6oKP9iDkH2ZS+wUuhPTYB4AH4SQRTiJ i7HVBe4elFUAD88VJK0DZAAZSjIQE0ehoP3LF/KWBD7ru9eGI0jGKdsWChjT9uWyOavh emoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xaVwrMr6e/jbnTc5qGRYSEriQiljvoWqO6b2JcTWvj4=; b=msP+F7cn5+MMtvlCf8jqBhdrC6CeUVGOPJHAa7gXDDbEGNN16rIqCEaBz86aAiFAvS Ev8ARzSkNiP1yr2ItAo2M3VeEhNOWgfxwvNpmY2teSCalhSxRpIrJ6mg/T9QnvarNdd1 xdFGGmKzuvo3m9jwP0RUsLS3Z4hnSO5dAutqixbO+5e5UrqPIw23VKGouWs/Shs8E6Q+ 1l3p8GOAa4JrB2GopUuRd2IsZy6KDSYOPXavZPzkUjR1DcQPSyaWDvlsxyacZX/T0vK1 yn3iXtJLQF7vD2+cCtVThCt+98YZrb2wwfYx7unf/GTgcx2J4YWSo5QZw8YlkGYCtnOR k/3Q== X-Gm-Message-State: AOAM533h+QRUYiOmKsS6sxLlq642tYY9LhIGkNygJeeuxUYPOw9MJZsr PBf+vtoiI9QvdUm1FbuQi+VIWg== X-Received: by 2002:a1c:5605:: with SMTP id k5mr1502624wmb.99.1604699406015; Fri, 06 Nov 2020 13:50:06 -0800 (PST) Received: from dell.default ([91.110.221.236]) by smtp.gmail.com with ESMTPSA id t199sm3981084wmt.46.2020.11.06.13.50.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 13:50:05 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 10/19] drm/radeon/radeon: Move prototype into shared header Date: Fri, 6 Nov 2020 21:49:40 +0000 Message-Id: <20201106214949.2042120-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201106214949.2042120-1-lee.jones@linaro.org> References: <20201106214949.2042120-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, =?utf-8?q?Christian_K=C3=B6nig?= , linaro-mm-sig@lists.linaro.org, dri-devel@lists.freedesktop.org, Alex Deucher , linux-media@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Unfortunately, a suitable one didn't already exist. Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_device.c:637:6: warning: no previous prototype for ‘radeon_device_is_virtual’ [-Wmissing-prototypes] 637 | bool radeon_device_is_virtual(void) | ^~~~~~~~~~~~~~~~~~~~~~~~ Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/radeon/radeon_device.c | 1 + drivers/gpu/drm/radeon/radeon_device.h | 32 ++++++++++++++++++++++++++ drivers/gpu/drm/radeon/radeon_drv.c | 3 +-- 3 files changed, 34 insertions(+), 2 deletions(-) create mode 100644 drivers/gpu/drm/radeon/radeon_device.h diff --git a/drivers/gpu/drm/radeon/radeon_device.c b/drivers/gpu/drm/radeon/radeon_device.c index 7f384ffe848a7..ad572f965190b 100644 --- a/drivers/gpu/drm/radeon/radeon_device.c +++ b/drivers/gpu/drm/radeon/radeon_device.c @@ -42,6 +42,7 @@ #include #include +#include "radeon_device.h" #include "radeon_reg.h" #include "radeon.h" #include "atom.h" diff --git a/drivers/gpu/drm/radeon/radeon_device.h b/drivers/gpu/drm/radeon/radeon_device.h new file mode 100644 index 0000000000000..c8e6dd2005224 --- /dev/null +++ b/drivers/gpu/drm/radeon/radeon_device.h @@ -0,0 +1,32 @@ +/* radeon_drv.h -- Private header for radeon device -*- linux-c -*- + * + * Copyright 1999 Precision Insight, Inc., Cedar Park, Texas. + * Copyright 2000 VA Linux Systems, Inc., Fremont, California. + * All rights reserved. + * + * Permission is hereby granted, free of charge, to any person obtaining a + * copy of this software and associated documentation files (the "Software"), + * to deal in the Software without restriction, including without limitation + * the rights to use, copy, modify, merge, publish, distribute, sublicense, + * and/or sell copies of the Software, and to permit persons to whom the + * Software is furnished to do so, subject to the following conditions: + * + * The above copyright notice and this permission notice (including the next + * paragraph) shall be included in all copies or substantial portions of the + * Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL + * PRECISION INSIGHT AND/OR ITS SUPPLIERS BE LIABLE FOR ANY CLAIM, DAMAGES OR + * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, + * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER + * DEALINGS IN THE SOFTWARE. + */ + +#ifndef __RADEON_DEV_H__ +#define __RADEON_DEV_H__ + +bool radeon_device_is_virtual(void); + +#endif /* __RADEON_DEV_H__ */ diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c index f5f1cb700d873..560267cc25892 100644 --- a/drivers/gpu/drm/radeon/radeon_drv.c +++ b/drivers/gpu/drm/radeon/radeon_drv.c @@ -51,6 +51,7 @@ #include #include "radeon_drv.h" +#include "radeon_device.h" /* * KMS wrapper. @@ -300,8 +301,6 @@ MODULE_DEVICE_TABLE(pci, pciidlist); static struct drm_driver kms_driver; -bool radeon_device_is_virtual(void); - static int radeon_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent) { From patchwork Fri Nov 6 21:49:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320850 Delivered-To: patch@linaro.org Received: by 2002:a92:7b12:0:0:0:0:0 with SMTP id w18csp1657136ilc; Fri, 6 Nov 2020 13:50:19 -0800 (PST) X-Google-Smtp-Source: ABdhPJzp/xmBqgrcexztZK/gPRBoBx4Gw36TQjizq87z7xHsrWNtLK19PSKwqAPeytAe2LnYSzxq X-Received: by 2002:a62:25c7:0:b029:156:72a3:b0c0 with SMTP id l190-20020a6225c70000b029015672a3b0c0mr3758444pfl.59.1604699419459; Fri, 06 Nov 2020 13:50:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604699419; cv=none; d=google.com; s=arc-20160816; b=VzeCdyXuCLfzSEfX1hY9f+iyzdVTT/NIFzI7Ong9mobfNYu5lFBIgtT9OWazo0zXiV dfNqqRl4QYE4Z4Ow5DIgiRkZKjb1vtapVGxyqaAHLKz5vfXvMiNB5QRZ6D19KooYVPeJ 0qKY2s0WM+7k9SbCgqWJqHJYE1S467YbAs8FHKFHTbZmoiMwdIqJiuHDX16YckgvUKV7 T83jFG+pCwpAW4RxocZATKcKvQNfnp/Km59bTSyJIAzMAfAc7yMJHzBjbhD5WCNO0kRA wIycG++lVl4HoLMgkUHnZjNVcT9R+Yq6KYAgB+dSBg1hzDT0O7ckifFp/IO/UC+bbBp3 3I8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=50Z9YnfWfrrwyoccwEqm7kCYxfbbaL9jT71bUN8X5gk=; b=Xh37/FufwTc1oPtozKrH+OzvD8o1mqj6YMrMn3Dqh3RWYu2xZynHcoaoZ8Ug91qDZ6 DQZXYadEA/v6nj2vxi7mBwAcSQazpuQrBDAEkfGo8UI6Bc5Oac6aqmN0ZmcD5Q0ShaHF 2CbvurqZAtsxzpeUJzubFzbraDECwcRWToFcwTlwGspZKKibQdebsXRCAE/E6Nbl9Gbd uin9NiS6dvj5I/BBFCdHD+XBWQhkF2LTAanCKc7nbM609aIFyU5DnGFoEZx8irtiqeYE fBqPRcfRtRBG2aJSiphIsZqlw5286OhcKfXxKwu1Smto1tWie7oVdxX5SWJtN0xZfi9/ NxoQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=eYaXK275; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id gi24si2073168pjb.109.2020.11.06.13.50.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 13:50:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=eYaXK275; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4E1F06EB25; Fri, 6 Nov 2020 21:50:12 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8AEA16EB25 for ; Fri, 6 Nov 2020 21:50:08 +0000 (UTC) Received: by mail-wm1-x343.google.com with SMTP id a65so2658242wme.1 for ; Fri, 06 Nov 2020 13:50:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Egmlgv9H3fW37Nl0/DO7Y7+0OQCWufEB+r7yIAqkua0=; b=eYaXK275kZ6tl5bZ2mLwFa4Hvd2EKmC0/VME8B9G/DISC2ffhyEptBOVG0KMjuNOLC XsEsCBmAoM7RHtAu3Qlc9CDxH+LWQ1uBALNxpw6HcSXEq0Pwu0m95yHxCdsAjrL12ceV KKvpLWrKJWTh5XU+PgrRW9YhQWWPAJMptrUEfAahqFedytbPfoYgCfYmvN5loU/6Lx/p jUyrunnT1AJH5g9RK08Qcpg1guaWrUBsccPIJSv44/qAOHunj6+eiN42lzj/+reg9vaX FXAGldEVoHjpHPVRlk78/1fsZaFkU/N2gn3wWzFRiBhdyL1xxlo9jkwAjDu4MIG2RFV2 2N0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Egmlgv9H3fW37Nl0/DO7Y7+0OQCWufEB+r7yIAqkua0=; b=TG8ybVLg1ep+7lqrZWVh6ysLzb8XjI7K/VqjfWQsm40PO0zdq82ofAt0nZyWZag8go HLrNh8v4c1C5MTAc9BA52DlK4q4XA69n9dq7H33gMtdPZIrhnlA7X8TB3YMXtmRTrnx3 mnuHVfqeDxgt3fQVQnjWbdOWvwWOS0uWzN03gmGRtB4zOL8raLCTvKdwr0mIoStFnkWk kJiSAiU3X/PJPB3pgP7mOugeN5Ws11VNU7OnsNr6Jjncu3hlUaKzR+qdeUGh1wFMoRcy ZnUcT3x43xZlqkq/INxp01f51drycgGI0ib2BZQH9DfUTP2K5QHJ7zUFTvWvl7lU3B2Y 9UHQ== X-Gm-Message-State: AOAM532VHbLvd2tb0N7PhrQ5gcn21sdnriL5FZKPmAya5aBNKHS/kFBg aOR94oSWmZRvGCxkKLD5CdAMWw== X-Received: by 2002:a1c:6484:: with SMTP id y126mr1515842wmb.141.1604699407208; Fri, 06 Nov 2020 13:50:07 -0800 (PST) Received: from dell.default ([91.110.221.236]) by smtp.gmail.com with ESMTPSA id t199sm3981084wmt.46.2020.11.06.13.50.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 13:50:06 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 11/19] drm/radeon/radeon_drv: Source file headers are not good candidates for kernel-doc Date: Fri, 6 Nov 2020 21:49:41 +0000 Message-Id: <20201106214949.2042120-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201106214949.2042120-1-lee.jones@linaro.org> References: <20201106214949.2042120-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , Gareth Hughes , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_drv.c:2: warning: Cannot understand * file radeon_drv.c Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Gareth Hughes Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/radeon/radeon_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c index 560267cc25892..bb7b33e535f81 100644 --- a/drivers/gpu/drm/radeon/radeon_drv.c +++ b/drivers/gpu/drm/radeon/radeon_drv.c @@ -1,4 +1,4 @@ -/** +/* * \file radeon_drv.c * ATI Radeon driver * From patchwork Fri Nov 6 21:49:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320853 Delivered-To: patch@linaro.org Received: by 2002:a92:7b12:0:0:0:0:0 with SMTP id w18csp1657198ilc; Fri, 6 Nov 2020 13:50:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJz/VzOAbK+ksrbf+BLtrSwb2eGWrrXoq/Vc0JG3GT7G3euCDkdqrmNY3wmwrrnsLJKjANDz X-Received: by 2002:a17:902:bd05:b029:d6:f041:f5b with SMTP id p5-20020a170902bd05b02900d6f0410f5bmr3402731pls.9.1604699423858; Fri, 06 Nov 2020 13:50:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604699423; cv=none; d=google.com; s=arc-20160816; b=Gbekk5To1FlOowZ/qNAGa7VeC3PSXRuUS2Sfd0LJFpg1MESPPImB7og0oDAxt/f5WZ bhMyPZQ8qk2Z6WEkqUEomB5/+abc07mxEL8u/xDZnxLodAmNUVEzyGAUSKsmk/ClmQL5 zRmoAbX2Ef4JUvzrNRpecyfc/jPnh7Ils+fF+qYQVIg8g4JXVEqmvP3Q2UKzI20ybsH/ IKKEx7eJVic0BXyPmYGtU5EDfLfF7L8gb9qRHsKx0LTy3V3aEVgTsCJED6q65PjLZndo gHHCxjEBL+QUJ8VNRLBS+/8gWBuMYZlvuw7xtZxdgBkCPaTCvJYuTWh1gYb2Mz8hM05A iG9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=peTr2g6lvfiAkZ5Je4pNCoaVOWzLEPs9IjKG/5amcPo=; b=kXptyMischPPLE0djAkr7idTt9Oe91D5Y5bAJJoLvMPQN/alIsyvk4Er/EADT+hxET 7rPtlC9uLFI1hn/Y0mad5nuY9UUmixcNVoN7Zs6QhJOIFoz+ztYIg5qm/0Ed18YjgCrS gNMM9EPKICCSdKXdx9A5Ub0e3PX3tvKJo0TVVoG8Uht4LC8rZiv3htWKbNR4BK+FXrPS VDP455YXd/BXxUkHlHH0APS4GxeWqb+Iw9n0uR21GNRqz0U/38kgq//QVZ7LKZHvr84T 4HMIhiwK9E5Cq++0dcCrgU7pJ6xzEGcLHO1l6/ytvIsind52UUK5ougtbhFZrMH5lf9z TSdw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Fg03f1ie; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id o16si2057812pjp.165.2020.11.06.13.50.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 13:50:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Fg03f1ie; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B26966EB2B; Fri, 6 Nov 2020 21:50:14 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by gabe.freedesktop.org (Postfix) with ESMTPS id C9AF56EB26 for ; Fri, 6 Nov 2020 21:50:09 +0000 (UTC) Received: by mail-wr1-x441.google.com with SMTP id g12so2772364wrp.10 for ; Fri, 06 Nov 2020 13:50:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=sSLs3el2OyWbVsEn+pD70NcssOBrvqEsumretpeL3Ds=; b=Fg03f1ie4ITmoYfqfIpjifTAA8wKVblmO4KjzkpCm6gE2NytBaRSUY0L+Sq4e5GQBG bFs4s7QvgryHFMdcA8em7y6YUQG39npIUgTlI0EQowc5rrw9+Odku+gMoW8GldBSQC9E E6QQiE93cA7d+XE4vK/HHNAFJMLZnMfWTRTCQ/4GcPWro5oThTV0vDGY+GjugtfprdZA UObpFO64SEriemyPjtFfNmQHZSF6jBoXuv1PRiSquaJUayoglzNLxW6RN8ip1FxtwfRz +wnrud83OxAq4nw4ooTpKeGh/5O/MyU2psfVdwHs59GyAWuR3cVY1FMKf4vD64Fdrc0i HZ+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sSLs3el2OyWbVsEn+pD70NcssOBrvqEsumretpeL3Ds=; b=jCdgBJ1jyQyulBp+YlBfUZ3JTb0uuEH2HZGfozBzGbgQkE1UMqAXerjponO5HFbeSQ +aicFbeDbx2Yedgis1H18bmucQIdPq02J5wX/P2iF8f4QNI0JqSxZOqQW7ksFgK0dEes uPYiGfFJGwnYifdC37rqxE2iRMzaCOrknswyT/PVHtKIjdC8Iyhh34V0ougie1gvYsqZ fdc5TFQmnSbro/798DpYmowfL3oqyx29fz8ZvpmFJPWYGvm6D/P9fFmdprzJBgPzEFbA FPi4f0binJHDbIsL1ng72GqXx9hsM/3gXOvGjjUJ2lmpRQ5p9MBn5Vqi37BtxkynTKhk 9H8g== X-Gm-Message-State: AOAM531IBSOmPd6x7hs04k4RkYZftbz/Nx6RzqmLjo4tDrbhIe2D+iCT 7/jxt1CndjLd4q5n9qVs8j1Ab4F+llIAbu7a X-Received: by 2002:a5d:6744:: with SMTP id l4mr4577899wrw.378.1604699408431; Fri, 06 Nov 2020 13:50:08 -0800 (PST) Received: from dell.default ([91.110.221.236]) by smtp.gmail.com with ESMTPSA id t199sm3981084wmt.46.2020.11.06.13.50.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 13:50:07 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 12/19] drm/amd/display/dc/basics/fixpt31_32: Move variables to where they're used Date: Fri, 6 Nov 2020 21:49:42 +0000 Message-Id: <20201106214949.2042120-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201106214949.2042120-1-lee.jones@linaro.org> References: <20201106214949.2042120-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Leo Li , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, David Airlie , dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Also rid some unused ones. This patch solves 2000 warnings! Fixes the following W=1 kernel build warning(s): In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dc_types.h:33, from drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services_types.h:30, from drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services.h:35, from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_helpers.c:35: At top level: drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h:76:32: warning: ‘dc_fixpt_ln2_div_2’ defined but not used [-Wunused-const-variable=] 76 | static const struct fixed31_32 dc_fixpt_ln2_div_2 = { 1488522236LL }; | ^~~~~~~~~~~~~~~~~~ drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h:75:32: warning: ‘dc_fixpt_ln2’ defined but not used [-Wunused-const-variable=] 75 | static const struct fixed31_32 dc_fixpt_ln2 = { 2977044471LL }; | ^~~~~~~~~~~~ drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h:74:32: warning: ‘dc_fixpt_e’ defined but not used [-Wunused-const-variable=] 74 | static const struct fixed31_32 dc_fixpt_e = { 11674931555LL }; | ^~~~~~~~~~ drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h:73:32: warning: ‘dc_fixpt_two_pi’ defined but not used [-Wunused-const-variable=] 73 | static const struct fixed31_32 dc_fixpt_two_pi = { 26986075409LL }; | ^~~~~~~~~~~~~~~ drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h:72:32: warning: ‘dc_fixpt_pi’ defined but not used [-Wunused-const-variable=] 72 | static const struct fixed31_32 dc_fixpt_pi = { 13493037705LL }; | ^~~~~~~~~~~ Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/display/dc/basics/fixpt31_32.c | 5 +++++ drivers/gpu/drm/amd/display/include/fixed31_32.h | 6 ------ 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/basics/fixpt31_32.c b/drivers/gpu/drm/amd/display/dc/basics/fixpt31_32.c index 1e9a2d3520684..59f37563704ad 100644 --- a/drivers/gpu/drm/amd/display/dc/basics/fixpt31_32.c +++ b/drivers/gpu/drm/amd/display/dc/basics/fixpt31_32.c @@ -26,6 +26,11 @@ #include "dm_services.h" #include "include/fixed31_32.h" +static const struct fixed31_32 dc_fixpt_pi = { 13493037705LL }; +static const struct fixed31_32 dc_fixpt_two_pi = { 26986075409LL }; +static const struct fixed31_32 dc_fixpt_ln2 = { 2977044471LL }; +static const struct fixed31_32 dc_fixpt_ln2_div_2 = { 1488522236LL }; + static inline unsigned long long abs_i64( long long arg) { diff --git a/drivers/gpu/drm/amd/display/include/fixed31_32.h b/drivers/gpu/drm/amd/display/include/fixed31_32.h index 16df2a485dd0d..22053d7ea6ced 100644 --- a/drivers/gpu/drm/amd/display/include/fixed31_32.h +++ b/drivers/gpu/drm/amd/display/include/fixed31_32.h @@ -69,12 +69,6 @@ static const struct fixed31_32 dc_fixpt_epsilon = { 1LL }; static const struct fixed31_32 dc_fixpt_half = { 0x80000000LL }; static const struct fixed31_32 dc_fixpt_one = { 0x100000000LL }; -static const struct fixed31_32 dc_fixpt_pi = { 13493037705LL }; -static const struct fixed31_32 dc_fixpt_two_pi = { 26986075409LL }; -static const struct fixed31_32 dc_fixpt_e = { 11674931555LL }; -static const struct fixed31_32 dc_fixpt_ln2 = { 2977044471LL }; -static const struct fixed31_32 dc_fixpt_ln2_div_2 = { 1488522236LL }; - /* * @brief * Initialization routines From patchwork Fri Nov 6 21:49:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320851 Delivered-To: patch@linaro.org Received: by 2002:a92:7b12:0:0:0:0:0 with SMTP id w18csp1657161ilc; Fri, 6 Nov 2020 13:50:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJzF74AeJ9QRRuRJON4LwzTwaR8Q+XRxyXe4WRkhJ8HcK8qij/ZROAgzqmJbYw7ZBbNgO2xx X-Received: by 2002:a17:90a:7784:: with SMTP id v4mr1711930pjk.60.1604699420749; Fri, 06 Nov 2020 13:50:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604699420; cv=none; d=google.com; s=arc-20160816; b=cRwJWGAEt7MCQMHNpHmp3hGQQnVz+fd2a+DxrK/g45P0SS6VwikQtllj8mp1e2W4DM mnsOeATxK7HQAqyDEJukC52hhDZr211KrwLiuFbMhLmHy5OT+KoU2Aig/FTdRklHrejq zl8scwBke7zmLlFjymcoMSf4dHqoIsrB7DILQoMjy6Fym2Qp/aSW8iRToQ7qyXgvxyWI FU7qmSqByEIyxv+WYyU+UEvXx1FTcq10TF0lg8y5knUGTRFExEbxbCd+3ZPHg61GoESB UppemgNwRYUxAf7Ajjx+T9oX9eP6mNGPS4L0nekgL8M/rpcCnvqXpP6/Cw1f0ynS0Ir7 189w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=7BbUR6uCgS8CkWR/vu/bZu4x8DXhqQxXFInLojMksuk=; b=lsiaDlLied43vW0s47d1+64K332LUeHHHtYUDtoQsScvEEE3w7jadWtmsiZcRCspBb mta2I5+igvNGlznnSdJ2yAme5uz3X/eGY/mbhJxmZa+6cBZz2k7W2+/KZzvMmBxWb58t V6bN0ketw/mVbHArNoqlq94ODu5Pfm3TR1N/AVHvMi/SF7/+Cd1syqLwSnazcKN9w91G wi62+wt0ULlK/p+aNwHOP315WNaadcBGLotJSBm96paULc4UWa6tUtrFMSnCcYqxN19h muyK4Sp0qDEkd1x+OJLGm+L9lQvBG0Shr8/CztSk1dMLccWoy1rKtQuXhJ3ob59x+blV nwrg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Oia3Jh4+; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id w2si2053877pll.338.2020.11.06.13.50.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 13:50:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Oia3Jh4+; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7BA346EB2C; Fri, 6 Nov 2020 21:50:12 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by gabe.freedesktop.org (Postfix) with ESMTPS id 07A766EB25 for ; Fri, 6 Nov 2020 21:50:11 +0000 (UTC) Received: by mail-wr1-x441.google.com with SMTP id n15so2791771wrq.2 for ; Fri, 06 Nov 2020 13:50:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SjA8v4JLA0wt0cf7/uKVTogVLZnV31tTyBrzOli6fTM=; b=Oia3Jh4+Z4jZyw1RDFWjabOewBGewQgIFa2hSMdeANo/YNjwRKSyyHR/LmjPTFtqt1 s1PWVzmYK/yiFcYzVOiScC7s9flKEXDvrwkM8+oFQquVQSrvMGl3gMbuKiDFQZsoSMb0 rVNafzN6YaSO41UutCfcOGF7aLMiRl5tBPvTD3hz392MP3sMQmLcsT4BykIuFqirx8xj L0xAzBNZGRx/MvGtnG1EMg+6rETJR5G94Dl9+sR3bxebp6rscL2fgQ57Y0TR5TU2S0dL hBmeBZSxQW/agwFMc4PH6qo9+jx7lpTW+LKLienKAzuco0zomsAXcRe7G/4pzTNyydrt sa0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SjA8v4JLA0wt0cf7/uKVTogVLZnV31tTyBrzOli6fTM=; b=Y4dyr9lHJq/ckIWIOamNXr8UGqCSeqPTze2OYAfduGBiGbVphPRZRsLW736CTTE+ts Op89rhZtz3ig2Jwbr7FeHIE71AU0Y/ygAHkQ6qRfvD9IgYUUSFxRDKllSKtusj1vFdOf FKJdERMlbNj96+XZvE+EibmLX0igoKw+v6YvFPY22dY03I0RERnUnYr+olvoKkUUjPnU Bg552Z/wnS1EnUmfw3LADoF8aN8uNgG4lv0OvIy/8y7X5cxH07UwWj9j4LRYYDIVshHT Va6QtPDAIDUc177wzj2/n/eIHmxOE4/wdgfOfhonxU8M5kmK6z3KktGY3uovalwZFoLb bl9Q== X-Gm-Message-State: AOAM533hvunc4XqFZF46bQnIV78qYIc9P9iKfNHll4TAoADCxgtcDirj vDCtbOHKUOelmh07Kl3dJONl4g== X-Received: by 2002:adf:c14c:: with SMTP id w12mr5035604wre.40.1604699409717; Fri, 06 Nov 2020 13:50:09 -0800 (PST) Received: from dell.default ([91.110.221.236]) by smtp.gmail.com with ESMTPSA id t199sm3981084wmt.46.2020.11.06.13.50.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 13:50:09 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 13/19] drm/radeon/radeon_drv: Move prototypes to a shared headerfile Date: Fri, 6 Nov 2020 21:49:43 +0000 Message-Id: <20201106214949.2042120-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201106214949.2042120-1-lee.jones@linaro.org> References: <20201106214949.2042120-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , Gareth Hughes , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): 62 | void radeon_driver_unload_kms(struct drm_device *dev) | ^~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/radeon/radeon_kms.c:105:5: warning: no previous prototype for ‘radeon_driver_load_kms’ [-Wmissing-prototypes] 105 | int radeon_driver_load_kms(struct drm_device *dev, unsigned long flags) | ^~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/radeon/radeon_kms.c:619:6: warning: no previous prototype for ‘radeon_driver_lastclose_kms’ [-Wmissing-prototypes] 619 | void radeon_driver_lastclose_kms(struct drm_device *dev) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/radeon/radeon_kms.c:634:5: warning: no previous prototype for ‘radeon_driver_open_kms’ [-Wmissing-prototypes] 634 | int radeon_driver_open_kms(struct drm_device *dev, struct drm_file *file_priv) | ^~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/radeon/radeon_kms.c:705:6: warning: no previous prototype for ‘radeon_driver_postclose_kms’ [-Wmissing-prototypes] 705 | void radeon_driver_postclose_kms(struct drm_device *dev, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Gareth Hughes Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/radeon/radeon_drv.c | 6 ------ drivers/gpu/drm/radeon/radeon_drv.h | 7 +++++++ 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c index bb7b33e535f81..e0d664e9e2feb 100644 --- a/drivers/gpu/drm/radeon/radeon_drv.c +++ b/drivers/gpu/drm/radeon/radeon_drv.c @@ -112,12 +112,6 @@ #define KMS_DRIVER_MAJOR 2 #define KMS_DRIVER_MINOR 50 #define KMS_DRIVER_PATCHLEVEL 0 -int radeon_driver_load_kms(struct drm_device *dev, unsigned long flags); -void radeon_driver_unload_kms(struct drm_device *dev); -void radeon_driver_lastclose_kms(struct drm_device *dev); -int radeon_driver_open_kms(struct drm_device *dev, struct drm_file *file_priv); -void radeon_driver_postclose_kms(struct drm_device *dev, - struct drm_file *file_priv); int radeon_suspend_kms(struct drm_device *dev, bool suspend, bool fbcon, bool freeze); int radeon_resume_kms(struct drm_device *dev, bool resume, bool fbcon); diff --git a/drivers/gpu/drm/radeon/radeon_drv.h b/drivers/gpu/drm/radeon/radeon_drv.h index 173deb4634146..ac7970919c4d3 100644 --- a/drivers/gpu/drm/radeon/radeon_drv.h +++ b/drivers/gpu/drm/radeon/radeon_drv.h @@ -118,4 +118,11 @@ long radeon_drm_ioctl(struct file *filp, unsigned int cmd, unsigned long arg); +int radeon_driver_load_kms(struct drm_device *dev, unsigned long flags); +void radeon_driver_unload_kms(struct drm_device *dev); +void radeon_driver_lastclose_kms(struct drm_device *dev); +int radeon_driver_open_kms(struct drm_device *dev, struct drm_file *file_priv); +void radeon_driver_postclose_kms(struct drm_device *dev, + struct drm_file *file_priv); + #endif /* __RADEON_DRV_H__ */ From patchwork Fri Nov 6 21:49:44 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320854 Delivered-To: patch@linaro.org Received: by 2002:a92:7b12:0:0:0:0:0 with SMTP id w18csp1657212ilc; Fri, 6 Nov 2020 13:50:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJyQ1YHaL6w9nWkyU4dzy4nOWNSa3g8v28JF/7z+WTroBhHUq3PicP5eA+052FGlpAmF5FwR X-Received: by 2002:a65:4cc9:: with SMTP id n9mr3437301pgt.236.1604699425308; Fri, 06 Nov 2020 13:50:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604699425; cv=none; d=google.com; s=arc-20160816; b=w/dBc7dJU66cF5D6ARiXCiY0UbYNrGur5QSMUabx0FRoEooWw4g3sE5RooPndWrbm3 mhSt5viNnMOn8nVMo+2Hir8qFhOgsKQfHdhxcvqPXD+hAMC9OjPnD0dp50GwLqowEClr /SaPfyg9m0f3RWb30ap78HPjJtiglxheaBMWNtSop+WKM0E9oozpQk8rME6jT84zCts1 0D42J6mE6l53IRcmWMFeYVTEVJOia+zUgvDE64wmTgnO1tPsyuy10QwmUn9bOSbzNkKz d0AtZOg3jFSPAdui8aVKHicSoOaiOpTUsMeSDtSOFaNA89mGHExOp5buqdKHZ2dRtqQ4 BsnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=Pu6HcgNXp8+BfH95S97IMYTkvlSWuNN2g4IotxycIlQ=; b=Pa3iHPaPgSYBXgHXUa0n9SxR/RzDTQZt7E+P9qJNk7MSbPLUN0Lgu7AivWv39Kwjn1 gH3zaAClnus68GcQOIgAOOckENmaG8MdT+0jip3k31FpkCFOQW3WiUZhZvQsfCM6JvWw pMFhvl28Bwj5DbjHRCUDweSDKm9lz6c/EirYZA8Qn5tGiEN7r/ZZEvkGIKq3JyHLMVLa 9rk7whr+QrGtjCUnm7B/aRFpVSuVQ2eG8RN16jct96QeOUe02/6yy7i8Ybe1acMOZK1o 7oMyZDJo6CSAlxTIzwb7W1CKQQlw6umpwOmchyAB0qnKYRw83l650prDvbRwA/Vy9mEB yTGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=CTrg6Tx6; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id i21si2008010pfu.115.2020.11.06.13.50.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 13:50:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=CTrg6Tx6; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D47F56EB2D; Fri, 6 Nov 2020 21:50:14 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id 576D96EB26 for ; Fri, 6 Nov 2020 21:50:12 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id g12so2772431wrp.10 for ; Fri, 06 Nov 2020 13:50:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/vzXOfe3LQJ1tPjw4mGTlBd2Hha/B9WB2NE4h+LPHsM=; b=CTrg6Tx6WbaAEcip1oP69BTNYGApk3DcwyCdUIuDQ2NDdnRBvWJ1vAX/ZU360Uj2H3 z2RJwZ1+S16zy979ZmaON1OE5ShHP9tn4UZpPgSmyA/uBIfj1vjmH+jWAjbfh3kcAI+N vT9asDh4Mu/wxBCF1XvL2esu1JYbTTLz+JNFFGMzs0UJu4zl3JLxby5TvA9gZghh1n8E xgYZIZKANmxc4y1D04xef/nQe3Mc/WsFTjsItHINOS2+gcjAGg4rCIRkTLtMqCjztxQv AImujyKOROsE+WUyTvErplm6dKHsfOgyEv5JJ1hSVPExxmbbHfSR6B+4fSicdViUancm iJig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/vzXOfe3LQJ1tPjw4mGTlBd2Hha/B9WB2NE4h+LPHsM=; b=NVe2ON7cE4I1wNofpJWilHm4AMmUF/m10vnnxbz9RFP5VsJM5HxCgNmaihB+Pr58HT 6EQ1noYN0fmjEWkY7QKeJfDOo/k1k+/CdnYv/kl0u8T8HpopVE7tQCqdHZrkIUMHTr5/ RT3gLyazzbpTMODB6F3HYk6Wdsv/akJjanspF/j6CDppX32ygofkisKM5fZp2r+j8Z1x kmxxYNBeLrbjo0S7nFxxePHGyewpQKaUnGsaX72VwXesjpZ32+LxLr5qGSOoyJZO34Jg fweTlPkaZhO8rOp8zLtLEWbO2+NVyBadBbD9i4Xo8+fASRt4WHkwYESZFXeMMpxaHpCr AHzg== X-Gm-Message-State: AOAM530sYbA2SytnLd86o0v/e0dkXCpmsk0w55UP2qnPMMHG5CbAiCvm OuXc8tWqN1RPNDRrB4OLwKSkNA== X-Received: by 2002:adf:e551:: with SMTP id z17mr4904423wrm.374.1604699411021; Fri, 06 Nov 2020 13:50:11 -0800 (PST) Received: from dell.default ([91.110.221.236]) by smtp.gmail.com with ESMTPSA id t199sm3981084wmt.46.2020.11.06.13.50.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 13:50:10 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 14/19] drm/amd/amdgpu/amdgpu_device: Provide documentation for 'reg_addr' params Date: Fri, 6 Nov 2020 21:49:44 +0000 Message-Id: <20201106214949.2042120-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201106214949.2042120-1-lee.jones@linaro.org> References: <20201106214949.2042120-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, =?utf-8?q?Christian_K=C3=B6nig?= , linaro-mm-sig@lists.linaro.org, dri-devel@lists.freedesktop.org, Alex Deucher , linux-media@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:594: warning: Function parameter or member 'reg_addr' not described in 'amdgpu_device_indirect_rreg' drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:624: warning: Function parameter or member 'reg_addr' not described in 'amdgpu_device_indirect_rreg64' Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index 300fcade4a2b1..63374d12e00fe 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c @@ -585,6 +585,7 @@ void amdgpu_mm_wdoorbell64(struct amdgpu_device *adev, u32 index, u64 v) * @adev: amdgpu_device pointer * @pcie_index: mmio register offset * @pcie_data: mmio register offset + * @reg_addr: indirect register address to read from * * Returns the value of indirect register @reg_addr */ @@ -615,6 +616,7 @@ u32 amdgpu_device_indirect_rreg(struct amdgpu_device *adev, * @adev: amdgpu_device pointer * @pcie_index: mmio register offset * @pcie_data: mmio register offset + * @reg_addr: indirect register address to read from * * Returns the value of indirect register @reg_addr */ From patchwork Fri Nov 6 21:49:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320857 Delivered-To: patch@linaro.org Received: by 2002:a92:7b12:0:0:0:0:0 with SMTP id w18csp1657253ilc; Fri, 6 Nov 2020 13:50:30 -0800 (PST) X-Google-Smtp-Source: ABdhPJwxDFQ1CRsvib7T408oig3GHX0Wq1+OFIsFVQrlkJjyGaUoV8W4wvuge/KimgO23l26dXqK X-Received: by 2002:a63:e343:: with SMTP id o3mr3455616pgj.308.1604699430348; Fri, 06 Nov 2020 13:50:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604699430; cv=none; d=google.com; s=arc-20160816; b=gswENyWgMenlr6hS3C0BvwdgC4+Fw0X8Zs5jRHI5OyCbc5EoZLlOoWv3IhtRgp6x9E ezLNN9vFJFrOLV/7ReUexVTNmmB+vyrMHMKOW0ZSnraG3Xdn5l9o42rX6m+fprBte0m4 RUyJ1kLUlu5/SOIXNuKiJvME0V84g8m+ZaCPVfOnpd20bchG8oocPzcAVOAUdr/vYYGO a902YY3KfuIAdK5nMCO8uNfHWHWIXKNNlJYIipmZf5YqJdtPKpBK9Gd9GZAMLKALl7iL Pz+GHwOWVVyb2KH3Ws8esT86DZTGevpi+4dRO0SzsGt6Cm2KVr8qEHqjIKXJEYWxEZqj /VRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=sww7t4+wV5E1HvaG/SC5OAeyQlU/qontPhFrc/3HzDo=; b=VZQW3bQLrXYUE3vBAKCP9+DD+dAUED/O6Ny29Y/8sx/HK7N4tWCxhpips5z0CZskty /NSMzGaiuF4p7NkyTb7qIAwn7WUC3yrQd+0b0CP17s0Slqs8Gck6v+zW2fWZjavT4cW2 E7wNwF/MG0vSJAL0W9Qs2PHAZ83LBR93Wh/jeoZ6853Bb4a+jqb6T8YFjaLxKOswbBJ+ xYB+dETfU4QpxjxquhhyIMKHQRKlWvmnlarE1mOpyUF1pkOrZ9S+0b9G+tO2NYc0fQTK QryL9LacBDCqpEA1SSGt/juRJ/J4ez5zI4Rk2OwJ/Lflm/S5Xi4MmzN47WDB7keQFdhl RGjA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=IOrFk0Bu; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id l8si1670130plt.55.2020.11.06.13.50.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 13:50:30 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=IOrFk0Bu; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 40E176EB39; Fri, 6 Nov 2020 21:50:20 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id 116C96EB2F for ; Fri, 6 Nov 2020 21:50:15 +0000 (UTC) Received: by mail-wr1-x444.google.com with SMTP id w14so2774101wrs.9 for ; Fri, 06 Nov 2020 13:50:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5L5j9WeVf4OsGrOI+zWyqNE90Jqm8OHoY/X5eer+uIE=; b=IOrFk0Bum8NpeO7vrbdT+XF4GBjyGBJirBDhxAK8aUBIKAcElcG4GD3NpjReOmFrTO LNLQT1Bp/et1mAqsqqvJwrYOwSCeu4qCr+4EFsp6WHjxr7qmDknJ+/AjCk13hiavhUqk UpiKHCRBbIv0f1XbNH35v08ckSZ5oFOCE93dTd66rbwUvPbqlyosD3vsT6AYCa/U9M+T 87TTsY///sjDCxef1KSDqVk0xLrjDQmwAJ4i3URwNA8yg7RZL0mhIRV3C+lYwA8zQ0E2 G3uwwRMXnGQ64wRyv1KqN+Y3EHHytDdE5YbYb0blE7CeA+XR9uD2xGk8ovxdFFN/d4/m RTNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5L5j9WeVf4OsGrOI+zWyqNE90Jqm8OHoY/X5eer+uIE=; b=W8qyO3ht1sx3sTGHAQrq3YsvBvgZlbF99kFPQUVtFB29j1T1+rm71IAjxje97zVlUm Hft0wy9LIhvbWDQoNJbz2PKHLg5uy+LbnRG1/WEeyODpkBplD9rmQqQUzNkEY3/XQ0uO EQ8K07xKOvfMj+PVJsB6IQWG9DaJLocKurUa0fFcbAOP2KYjvJWqREx+/dYRn9QsXupL hFBwD3tn6pQyoAuib4Wlo3gorrPRMElmERX141VYx9cvnKS8eU/bOA+LntUZikXlRvER r7G/3unYH1cmKh0/6JfL3modLDSA6WB/qAJeHTUNV9tny7TEAEkRyE+2uhTpXekhL66S nNpw== X-Gm-Message-State: AOAM533oKtMZkvECLHE/VLWvddDagqCkcPm3RpUavOtGvbgduU2SEkVm ElgnnnLRV/5dEkFOWa+uOq0qkw== X-Received: by 2002:a5d:660e:: with SMTP id n14mr4522258wru.94.1604699413709; Fri, 06 Nov 2020 13:50:13 -0800 (PST) Received: from dell.default ([91.110.221.236]) by smtp.gmail.com with ESMTPSA id t199sm3981084wmt.46.2020.11.06.13.50.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 13:50:13 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 16/19] drm/amd/amdgpu/amdgpu_kms: Remove 'struct drm_amdgpu_info_device dev_info' from the stack Date: Fri, 6 Nov 2020 21:49:46 +0000 Message-Id: <20201106214949.2042120-17-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201106214949.2042120-1-lee.jones@linaro.org> References: <20201106214949.2042120-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6?= =?utf-8?q?nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Place it on the heap instead. Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c: In function ‘amdgpu_info_ioctl’: drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c:979:1: warning: the frame size of 1128 bytes is larger than 1024 bytes [-Wframe-larger-than=] Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 104 +++++++++++++----------- 1 file changed, 55 insertions(+), 49 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c index 918d4e9c6461a..ef6fa5007d135 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c @@ -721,38 +721,42 @@ static int amdgpu_info_ioctl(struct drm_device *dev, void *data, struct drm_file return n ? -EFAULT : 0; } case AMDGPU_INFO_DEV_INFO: { - struct drm_amdgpu_info_device dev_info; + struct drm_amdgpu_info_device *dev_info; uint64_t vm_size; + int ret; + + dev_info = kzalloc(sizeof(*dev_info), GFP_KERNEL); + if (!dev_info) + return -ENOMEM; - memset(&dev_info, 0, sizeof(dev_info)); - dev_info.device_id = dev->pdev->device; - dev_info.chip_rev = adev->rev_id; - dev_info.external_rev = adev->external_rev_id; - dev_info.pci_rev = dev->pdev->revision; - dev_info.family = adev->family; - dev_info.num_shader_engines = adev->gfx.config.max_shader_engines; - dev_info.num_shader_arrays_per_engine = adev->gfx.config.max_sh_per_se; + dev_info->device_id = dev->pdev->device; + dev_info->chip_rev = adev->rev_id; + dev_info->external_rev = adev->external_rev_id; + dev_info->pci_rev = dev->pdev->revision; + dev_info->family = adev->family; + dev_info->num_shader_engines = adev->gfx.config.max_shader_engines; + dev_info->num_shader_arrays_per_engine = adev->gfx.config.max_sh_per_se; /* return all clocks in KHz */ - dev_info.gpu_counter_freq = amdgpu_asic_get_xclk(adev) * 10; + dev_info->gpu_counter_freq = amdgpu_asic_get_xclk(adev) * 10; if (adev->pm.dpm_enabled) { - dev_info.max_engine_clock = amdgpu_dpm_get_sclk(adev, false) * 10; - dev_info.max_memory_clock = amdgpu_dpm_get_mclk(adev, false) * 10; + dev_info->max_engine_clock = amdgpu_dpm_get_sclk(adev, false) * 10; + dev_info->max_memory_clock = amdgpu_dpm_get_mclk(adev, false) * 10; } else { - dev_info.max_engine_clock = adev->clock.default_sclk * 10; - dev_info.max_memory_clock = adev->clock.default_mclk * 10; + dev_info->max_engine_clock = adev->clock.default_sclk * 10; + dev_info->max_memory_clock = adev->clock.default_mclk * 10; } - dev_info.enabled_rb_pipes_mask = adev->gfx.config.backend_enable_mask; - dev_info.num_rb_pipes = adev->gfx.config.max_backends_per_se * + dev_info->enabled_rb_pipes_mask = adev->gfx.config.backend_enable_mask; + dev_info->num_rb_pipes = adev->gfx.config.max_backends_per_se * adev->gfx.config.max_shader_engines; - dev_info.num_hw_gfx_contexts = adev->gfx.config.max_hw_contexts; - dev_info._pad = 0; - dev_info.ids_flags = 0; + dev_info->num_hw_gfx_contexts = adev->gfx.config.max_hw_contexts; + dev_info->_pad = 0; + dev_info->ids_flags = 0; if (adev->flags & AMD_IS_APU) - dev_info.ids_flags |= AMDGPU_IDS_FLAGS_FUSION; + dev_info->ids_flags |= AMDGPU_IDS_FLAGS_FUSION; if (amdgpu_mcbp || amdgpu_sriov_vf(adev)) - dev_info.ids_flags |= AMDGPU_IDS_FLAGS_PREEMPTION; + dev_info->ids_flags |= AMDGPU_IDS_FLAGS_PREEMPTION; if (amdgpu_is_tmz(adev)) - dev_info.ids_flags |= AMDGPU_IDS_FLAGS_TMZ; + dev_info->ids_flags |= AMDGPU_IDS_FLAGS_TMZ; vm_size = adev->vm_manager.max_pfn * AMDGPU_GPU_PAGE_SIZE; vm_size -= AMDGPU_VA_RESERVED_SIZE; @@ -762,45 +766,47 @@ static int amdgpu_info_ioctl(struct drm_device *dev, void *data, struct drm_file adev->vce.fw_version < AMDGPU_VCE_FW_53_45) vm_size = min(vm_size, 1ULL << 40); - dev_info.virtual_address_offset = AMDGPU_VA_RESERVED_SIZE; - dev_info.virtual_address_max = + dev_info->virtual_address_offset = AMDGPU_VA_RESERVED_SIZE; + dev_info->virtual_address_max = min(vm_size, AMDGPU_GMC_HOLE_START); if (vm_size > AMDGPU_GMC_HOLE_START) { - dev_info.high_va_offset = AMDGPU_GMC_HOLE_END; - dev_info.high_va_max = AMDGPU_GMC_HOLE_END | vm_size; + dev_info->high_va_offset = AMDGPU_GMC_HOLE_END; + dev_info->high_va_max = AMDGPU_GMC_HOLE_END | vm_size; } - dev_info.virtual_address_alignment = max((int)PAGE_SIZE, AMDGPU_GPU_PAGE_SIZE); - dev_info.pte_fragment_size = (1 << adev->vm_manager.fragment_size) * AMDGPU_GPU_PAGE_SIZE; - dev_info.gart_page_size = AMDGPU_GPU_PAGE_SIZE; - dev_info.cu_active_number = adev->gfx.cu_info.number; - dev_info.cu_ao_mask = adev->gfx.cu_info.ao_cu_mask; - dev_info.ce_ram_size = adev->gfx.ce_ram_size; - memcpy(&dev_info.cu_ao_bitmap[0], &adev->gfx.cu_info.ao_cu_bitmap[0], + dev_info->virtual_address_alignment = max((int)PAGE_SIZE, AMDGPU_GPU_PAGE_SIZE); + dev_info->pte_fragment_size = (1 << adev->vm_manager.fragment_size) * AMDGPU_GPU_PAGE_SIZE; + dev_info->gart_page_size = AMDGPU_GPU_PAGE_SIZE; + dev_info->cu_active_number = adev->gfx.cu_info.number; + dev_info->cu_ao_mask = adev->gfx.cu_info.ao_cu_mask; + dev_info->ce_ram_size = adev->gfx.ce_ram_size; + memcpy(&dev_info->cu_ao_bitmap[0], &adev->gfx.cu_info.ao_cu_bitmap[0], sizeof(adev->gfx.cu_info.ao_cu_bitmap)); - memcpy(&dev_info.cu_bitmap[0], &adev->gfx.cu_info.bitmap[0], + memcpy(&dev_info->cu_bitmap[0], &adev->gfx.cu_info.bitmap[0], sizeof(adev->gfx.cu_info.bitmap)); - dev_info.vram_type = adev->gmc.vram_type; - dev_info.vram_bit_width = adev->gmc.vram_width; - dev_info.vce_harvest_config = adev->vce.harvest_config; - dev_info.gc_double_offchip_lds_buf = + dev_info->vram_type = adev->gmc.vram_type; + dev_info->vram_bit_width = adev->gmc.vram_width; + dev_info->vce_harvest_config = adev->vce.harvest_config; + dev_info->gc_double_offchip_lds_buf = adev->gfx.config.double_offchip_lds_buf; - dev_info.wave_front_size = adev->gfx.cu_info.wave_front_size; - dev_info.num_shader_visible_vgprs = adev->gfx.config.max_gprs; - dev_info.num_cu_per_sh = adev->gfx.config.max_cu_per_sh; - dev_info.num_tcc_blocks = adev->gfx.config.max_texture_channel_caches; - dev_info.gs_vgt_table_depth = adev->gfx.config.gs_vgt_table_depth; - dev_info.gs_prim_buffer_depth = adev->gfx.config.gs_prim_buffer_depth; - dev_info.max_gs_waves_per_vgt = adev->gfx.config.max_gs_threads; + dev_info->wave_front_size = adev->gfx.cu_info.wave_front_size; + dev_info->num_shader_visible_vgprs = adev->gfx.config.max_gprs; + dev_info->num_cu_per_sh = adev->gfx.config.max_cu_per_sh; + dev_info->num_tcc_blocks = adev->gfx.config.max_texture_channel_caches; + dev_info->gs_vgt_table_depth = adev->gfx.config.gs_vgt_table_depth; + dev_info->gs_prim_buffer_depth = adev->gfx.config.gs_prim_buffer_depth; + dev_info->max_gs_waves_per_vgt = adev->gfx.config.max_gs_threads; if (adev->family >= AMDGPU_FAMILY_NV) - dev_info.pa_sc_tile_steering_override = + dev_info->pa_sc_tile_steering_override = adev->gfx.config.pa_sc_tile_steering_override; - dev_info.tcc_disabled_mask = adev->gfx.config.tcc_disabled_mask; + dev_info->tcc_disabled_mask = adev->gfx.config.tcc_disabled_mask; - return copy_to_user(out, &dev_info, - min((size_t)size, sizeof(dev_info))) ? -EFAULT : 0; + ret = copy_to_user(out, dev_info, + min((size_t)size, sizeof(*dev_info))) ? -EFAULT : 0; + kfree(dev_info); + return ret; } case AMDGPU_INFO_VCE_CLOCK_TABLE: { unsigned i; From patchwork Fri Nov 6 21:49:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320856 Delivered-To: patch@linaro.org Received: by 2002:a92:7b12:0:0:0:0:0 with SMTP id w18csp1657246ilc; Fri, 6 Nov 2020 13:50:29 -0800 (PST) X-Google-Smtp-Source: ABdhPJyH4iH2ZPRRG42Ldmy+2GAT7x0pH2xoZ81EtsP/SB0J80YJcgdux0JI74jLOkCwHguL6lsu X-Received: by 2002:a17:90a:7d12:: with SMTP id g18mr1629005pjl.137.1604699429300; Fri, 06 Nov 2020 13:50:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604699429; cv=none; d=google.com; s=arc-20160816; b=WfrV3614k338XGrR21TX+AlWVwKDI7OJmN5FUFXVM3Yzbw+YnIIN7E6Vo2CJgzxq8u 3lMpZdZRXN3hlYPXiVUkkE53XeoCjZRsldUEo5zZ3OQfxjf7j8xesM2MJA82KRRIYehD 9NNEbk+kWlSoRU1cZgL7KcTE972x1+2QafGlbwwhO5Lk0Md5MRUkCMCF8K6tpBJt8AW7 d+cbuU2dzB64bjjB1ohf3q1kMsmoQre8bqPz05j6vmg4Gt+4q0RFXxiNKtIm4cMwhQuD oNiWHxh/aoIDo2U5uEHTnWYUqOSeAnBMlSrV3tRhOS4BBrGwfgvzHmdayrnhvmJh9e38 SjIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=ctDmKdk7+YJuPpwqI8CsF392IkTc1oA+oLCbCef0w9k=; b=xDB+lyj/n0VU/Vdgc3z/b3KY02CHYx04sfj6Rh92+cXiLgtJKLYngQLaZnagq8RFmT uBQETG/cS0x0O+0iKLF9r3XBP7oSDOrf3YVg68F/sjRB+AjMaCILdHGHxVUxMucvdSzz ZBL2+lY36sVjD3Tq8/sQWITsML9Y9M7uAoJLFlAf6Ei/OAThnHCQvZ2WRYaz71mqAMta u1fjUmwgv6PdscKMGDU/aIOMrHMpx0BxENEfSYgPMYEQ1HL57OlKrvHi2DGxqCbcZL8v nmwnn5OkPAcu3KMwYgSCBEeX2L3n31cGVe31IhMI/j6Qp94P5A3ns9PBbeR9rNjJtGBJ FRIg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b="Q/dYjguv"; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id p8si2033917pju.36.2020.11.06.13.50.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 13:50:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b="Q/dYjguv"; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D39636EB2F; Fri, 6 Nov 2020 21:50:19 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id 516536EB2F for ; Fri, 6 Nov 2020 21:50:16 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id e6so2806216wro.1 for ; Fri, 06 Nov 2020 13:50:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nopEvpxJII5W2X0oKSxO5qTCMfgTR4xaU1b6yHoTHoc=; b=Q/dYjguv8S6NsqfuKHgA061fmsexpTGcj3625pXi+PgAAgyL2muaEoshXwa+Kvnc8M 59TG+TyhDa9fhxU8kIXiT3LXDmM8E9cUAyQ7qO59NrYbQDdRF+hOw9843TRurp2N1BXe Ai8xtWFs0fS315EoPuu8iPpZCzNdgLs2ST/VfWYd4RdGXIlr+q7rTJ/aFjdxIEqIbH7z hP83MnWVORZUN1gv5M7ZnOV+MDikTRoRWtIUNZdw6XIMqWWeiuQDjJ/ZnLMS3CEpivUb LxqLrkuSh1nL7vsvi5aSkA8MPdprs4DsYk5wo3vhBTOD+9cNuMocqJbzAgsCAtPi2h1X wi3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nopEvpxJII5W2X0oKSxO5qTCMfgTR4xaU1b6yHoTHoc=; b=nI+qMUseIMUetq1tgM6tfqNaWSFhWo/njbkVzHD8rbHyNBNeIkaxqHo4aJteDgT5Kz So4SsmMFwZ/m/WSc3EUJoyrFCLK45GZlgUwbX8gvwZvp6KuQQV8gh6BN9ftvdXFx8vTy dskxO8E7D4YOCvcbhvUD5cn7VjoDnDyTydqQFl6ioJ9vvHMYVpsyosx+KSOEofhb/gW0 wrek0G1W7XHqaqT6OyJXORs3SEU9DTbSlbRNTwcSnpUCt9qj3kZI4gPScyyS+0F159rK rIE4wXtk5BpOBA5e9xC1An5Sd5/K8DpRPTJEsRHBxXIrssYvbJPBNaxk1vFZ2ATNDt7l fr8g== X-Gm-Message-State: AOAM5334YoYSfME0n1nCgM0hky6pYb6AblQfa1yKORVD+lnv9p7NhBDb I9jCfihA1SB37sDThKXHQd46BCjJbTZKSzaI X-Received: by 2002:adf:bb07:: with SMTP id r7mr5108985wrg.150.1604699415033; Fri, 06 Nov 2020 13:50:15 -0800 (PST) Received: from dell.default ([91.110.221.236]) by smtp.gmail.com with ESMTPSA id t199sm3981084wmt.46.2020.11.06.13.50.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 13:50:14 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 17/19] drm/radeon/radeon_kms: Fix misnaming of 'radeon_info_ioctl's dev param Date: Fri, 6 Nov 2020 21:49:47 +0000 Message-Id: <20201106214949.2042120-18-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201106214949.2042120-1-lee.jones@linaro.org> References: <20201106214949.2042120-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6?= =?utf-8?q?nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_kms.c:226: warning: Function parameter or member 'dev' not described in 'radeon_info_ioctl' drivers/gpu/drm/radeon/radeon_kms.c:226: warning: Excess function parameter 'rdev' description in 'radeon_info_ioctl' Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/radeon/radeon_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/radeon_kms.c b/drivers/gpu/drm/radeon/radeon_kms.c index 0d8fbabffcead..21c206795c364 100644 --- a/drivers/gpu/drm/radeon/radeon_kms.c +++ b/drivers/gpu/drm/radeon/radeon_kms.c @@ -213,7 +213,7 @@ static void radeon_set_filp_rights(struct drm_device *dev, /** * radeon_info_ioctl - answer a device specific request. * - * @rdev: radeon device pointer + * @dev: radeon device pointer * @data: request object * @filp: drm filp * From patchwork Fri Nov 6 21:49:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320855 Delivered-To: patch@linaro.org Received: by 2002:a92:7b12:0:0:0:0:0 with SMTP id w18csp1657239ilc; Fri, 6 Nov 2020 13:50:28 -0800 (PST) X-Google-Smtp-Source: ABdhPJzbw4cf1AcgFK/hFSiCV2Uyql92RUMtXVqz3DQpKloTZd8x2gVUqHTsnhe2xpb+YDBc/HZn X-Received: by 2002:a62:cec6:0:b029:18a:d620:6b86 with SMTP id y189-20020a62cec60000b029018ad6206b86mr3489260pfg.2.1604699428185; Fri, 06 Nov 2020 13:50:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604699428; cv=none; d=google.com; s=arc-20160816; b=bBdqzpfY6ra2UbLDwscny74VQuYGqBzM8wKVBXqQ2aUMFAZR6zX324k56iQRsapU6R DS2k7Iz5hRDuKEnZJ0kSLh/QM8ooSGjaHhToIjmRv1ddFxlSMB2TRCSIDgL9mVJhP4xt tFQSKdBrl4j9FXIWsPY7bXFib6BJGrtDn6KVFVZUM7mHR+BkljSc5qswkOUSW9zBIVgw 9QFsxO1m+wUHAU4fKm9B8AUAS16PjtQMCyGjOD25MbEB5QRB4gsW4vC2xwtr7QujO1nT HjaziWkShu0dtV7ymvCFOc92l2HJwgCly86e17barOw7NpMiOBK7fgJrxZJAnSvV9/iu 62FQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=cQPlr5uHInod5yUThEamSbfO/sQqE0WAhbMehVElJzg=; b=xbnryIX0RXgrYtpweL+za+4VSdxNmoDYC8+wRL+wtwlDp+zFQcsJg7hbku788n3VHb lAApAL4kBGZPZ9eog3CuYA0Uf+2giDgMdbiG5ePVT/3KyT/5m0UeQZrd114fHPkB2yzG LrKSF43Cxlv2kpnnPCxQc7Rxp8u7zhMtqXQpbaza+ZWA6VwRAJ5HNQsDOJNMiLuHnM3L WtTs8ZWQ7jYbdRi9Wcw5U3/74oYdmzWlnjsuFbFM8VoO/Plq/w6ctKBz+9yXtWULp5Ky 496LApVHI4WGWyr8xK9/vvFuuz+gOmjMdZWlk2cT1XeT9p44w4L+6wt04UyWalXj8aGL DwCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=ccFvN7q5; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id g17si2118592plj.419.2020.11.06.13.50.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 13:50:28 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=ccFvN7q5; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 86D046EB37; Fri, 6 Nov 2020 21:50:18 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7FE586EB38 for ; Fri, 6 Nov 2020 21:50:17 +0000 (UTC) Received: by mail-wr1-x441.google.com with SMTP id 33so2779813wrl.7 for ; Fri, 06 Nov 2020 13:50:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=H95rA0QKKaL3+FIhv21U45aIyhbFkd+FiaPq5zaa4zk=; b=ccFvN7q5RxD4CM0NZ+0NxOOG6O0PgSIXE+amCe86rCTSBZLuWX37GhNGsshfXsaMgJ iJ+m8coKTU8tmP8qge3HwIuTlw6dRtNHcwYQoDi0f2+qc7AJiR+nGeV09VYcqv3176Ps Z4rIW0Ek+Ibod01RSdTTLjdionhBuOzof//ifUqw8gtS7OVpCBHufYnY7iISAOwDON89 8xox35G1GiJLy2sNXn3sNnHV8RbvddMWz/MEVUR8Lekn7rI/ELHoZ3UWfBQdxqeSpqyX 4Z0EBLkLyasPaxfUW9RF1jPxDJT4MtCVhxwJV7ziZHtyfaZlgC6YN1pEUtBZ0X+ZzIJj +nTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=H95rA0QKKaL3+FIhv21U45aIyhbFkd+FiaPq5zaa4zk=; b=EGtI8T7Am7QnSw/n3p+6QOotbAHzoFhLaaHVs3dm9JoIqorQp5cZKyC665lNwOjDqg uaBDSKpgSNPpTok7cAe+2vtGAlWQDzPelHn9XM2mxzieuZeohBPGRba6srRZkAHKrNz+ bxyOOXCbypVlYEwwxQQUNDwT/j9Z69aWvqa/TKw80qz/qL5bQH8qs/ztJWmBdtrWg/h0 C8j5tMB8f3/nMkLlDlD6EXwNi7pB1RWqaiAuPqpLUcUjn4vBOnczFstE8YIq/PsY6Ylz 8XPpd2tBBCfuuEDfGFnqYo2VA/TuijedK/95BcX5lsAwGpfYZopz3XtyD2WNvUvpTq8h uxpg== X-Gm-Message-State: AOAM530cN8dz27IxERLm5JRFDqA8I9qirmNTvzoW/6qJtkH8lxI3J4Cd 9NbfPtJlyevhRRbqcTeYxkCZAQ== X-Received: by 2002:adf:cd0d:: with SMTP id w13mr2494726wrm.382.1604699416188; Fri, 06 Nov 2020 13:50:16 -0800 (PST) Received: from dell.default ([91.110.221.236]) by smtp.gmail.com with ESMTPSA id t199sm3981084wmt.46.2020.11.06.13.50.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 13:50:15 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 18/19] drm/radeon/atombios_crtc: Remove description of non-existent function param 'encoder' Date: Fri, 6 Nov 2020 21:49:48 +0000 Message-Id: <20201106214949.2042120-19-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201106214949.2042120-1-lee.jones@linaro.org> References: <20201106214949.2042120-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6?= =?utf-8?q?nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/atombios_crtc.c:1796: warning: Excess function parameter 'encoder' description in 'radeon_get_shared_nondp_ppll' Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/radeon/atombios_crtc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/atombios_crtc.c b/drivers/gpu/drm/radeon/atombios_crtc.c index 91811757104c0..1979ed3d65472 100644 --- a/drivers/gpu/drm/radeon/atombios_crtc.c +++ b/drivers/gpu/drm/radeon/atombios_crtc.c @@ -1787,7 +1787,6 @@ static int radeon_get_shared_dp_ppll(struct drm_crtc *crtc) * radeon_get_shared_nondp_ppll - return the PPLL used by another non-DP crtc * * @crtc: drm crtc - * @encoder: drm encoder * * Returns the PPLL (Pixel PLL) used by another non-DP crtc/encoder which can * be shared (i.e., same clock). From patchwork Fri Nov 6 21:49:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320859 Delivered-To: patch@linaro.org Received: by 2002:a92:7b12:0:0:0:0:0 with SMTP id w18csp1658203ilc; Fri, 6 Nov 2020 13:52:15 -0800 (PST) X-Google-Smtp-Source: ABdhPJw7fto0SA8N+/Uz52kW6XrByINnZeG0wA3cC1XW1sobZbwWBeFBp19FlHCam3Ffa+gVeEN9 X-Received: by 2002:a17:902:9a4c:b029:d6:1f21:8021 with SMTP id x12-20020a1709029a4cb02900d61f218021mr3128263plv.58.1604699432502; Fri, 06 Nov 2020 13:50:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604699432; cv=none; d=google.com; s=arc-20160816; b=JRIRtYXEGR8CLN1AizfNGlQd3iFr04+sa4AjKpqQy9CpZIa/7OxYEBl31r0dul7l7w /d9Te8jB4JfuZwR2Mll5RhEGpKtxZFbTlHcoDEQF4/eHpZavL8xNRYHS5+xG0bnXdkO5 kg38E00DBJq9W9ctqZ7WIE2D+zoChhDh0TVYRbTHIOgoGkOS2LnnIvdltCypfTPP9Cwt eevLWrzKIBBIK13Qh3KFxvlco+zz1MXIw7x6GuhWobSIdtrmJvCMBhoP37vzcF0bsc1u oU608JIFic2b4gx4HYmORuWJh1DxKN6bj3HXEjaZlWmUnSWi1BlCKPoogXwo5yRdAz1Z 7CYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=Bmx+KpHlYyBZUF5S+uAA07/kkO+Nhf/GRk16z5GsSs4=; b=g1q3U/FCCgV0b2/mNoBhYqwmeAJqETUjK8rKeOkVaNqdLgkpR83nOf6ZEJaDFTxp2F lETpY32tZ50fHtgAiyTC6FsSSj+ZIVGvpf+ETpBpLc0kuu6RDPBFMFWzYnIUIiRcrEOc Aks/cQiC6y0F37O4f/hjnES7WlUZ0gSLTGF4CuwdvgQXYMAByJTbcgmZZowYjHhHkyqd MTsCUrVl4WDEQh3BnQTR1E4MCFMRbNKhxxzrRAcJ/MgN3dpFF6rx4rrPTJNL1+6G0FET rjpsbQ75By0vf1l79IsW3reJSnMUPPR2nbesZUa24CFVdHZv2ZUK62PuKG4HgCRXC1z/ q9Mg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=TxSb65pM; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id f22si2127136plr.4.2020.11.06.13.50.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 13:50:32 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=TxSb65pM; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EB82F6EB36; Fri, 6 Nov 2020 21:50:19 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by gabe.freedesktop.org (Postfix) with ESMTPS id A234B6EB36 for ; Fri, 6 Nov 2020 21:50:18 +0000 (UTC) Received: by mail-wr1-x441.google.com with SMTP id p1so2767500wrf.12 for ; Fri, 06 Nov 2020 13:50:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1BAWNAgt/8o6t/4tV7E6hU4K4LH6BnOtAjU2sn0ZUiI=; b=TxSb65pMrJbCHOjX25f6OYd4V3p7wJVF4lcHGevOnmecoTAVwndthxXLhT3rNte7gY AxAnOEXF595IqOTv2Y5tl+q50a13jAGJ59jbWY73piaE9WrgUamD9uoaZbFhY8wJMRg2 D1CJcaJ5NE9ZQKz0Q8+Es7snc67U/gUqzxXuX4Y6nXFEwrGx3ic3MXsvei2itMhLMVB8 JVNmWtaKLiz5e3hAyW4MwkdidZUdfHiWY/HKn2rt37hARCWQPKS0ohh8s4047lOVBBrX S6un+r7uNWVJchl8piFvJz5DGC95hpA+4lq85jUn/8NZ4cRfK/K7b85Y78SdYlNn0Z4b M/ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1BAWNAgt/8o6t/4tV7E6hU4K4LH6BnOtAjU2sn0ZUiI=; b=menpoAu6wPpec6C3RNe/9EKCCwsBxTtyqtmi5u5buwIIQm10vZIDSF/q7UfG4R2YYm 2J3gwdjik1NJcWS8u+TTBxYq7J7vt+4FmyRD5/2pubK6vuJIEnUCipzOeZ/Yvp/srL2Z tCMFgCcgPiym/pwh80V85nRhgpAf0/FpxiY672HXiB6MvH5mUb9XyFwa8OO+6n9jMR+k joiluqVYNfvMm+N2oZ3w0qP3RfLjiq6JjO76gHEe/9mU4eg3k2m54a4zHQwBQB7t7P4Y gsZEm8ZWanwF6Nk4wMHeRti1IJ+JR14xkknKCxZa/onq6tDWq7HrgR364uiiR8GolAMe cnJw== X-Gm-Message-State: AOAM531rnQ3WKUlfQvYjUUPSA5a3eEH/c00Z7UCfS/WZVzEPPWxpbd84 kzBHK1N443jHQS3fR+mhHpG6eQ== X-Received: by 2002:adf:f2c7:: with SMTP id d7mr1084417wrp.142.1604699417367; Fri, 06 Nov 2020 13:50:17 -0800 (PST) Received: from dell.default ([91.110.221.236]) by smtp.gmail.com with ESMTPSA id t199sm3981084wmt.46.2020.11.06.13.50.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 13:50:16 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 19/19] drm/v3d/v3d_drv: Remove unused static variable 'v3d_v3d_pm_ops' Date: Fri, 6 Nov 2020 21:49:49 +0000 Message-Id: <20201106214949.2042120-20-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201106214949.2042120-1-lee.jones@linaro.org> References: <20201106214949.2042120-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/v3d/v3d_drv.c:73:32: warning: ‘v3d_v3d_pm_ops’ defined but not used [-Wunused-const-variable=] Cc: Eric Anholt Cc: David Airlie Cc: Daniel Vetter Cc: Philipp Zabel Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/v3d/v3d_drv.c | 36 ----------------------------------- 1 file changed, 36 deletions(-) diff --git a/drivers/gpu/drm/v3d/v3d_drv.c b/drivers/gpu/drm/v3d/v3d_drv.c index 9f7c261938312..a5bf09458451c 100644 --- a/drivers/gpu/drm/v3d/v3d_drv.c +++ b/drivers/gpu/drm/v3d/v3d_drv.c @@ -38,42 +38,6 @@ #define DRIVER_MINOR 0 #define DRIVER_PATCHLEVEL 0 -#ifdef CONFIG_PM -static int v3d_runtime_suspend(struct device *dev) -{ - struct drm_device *drm = dev_get_drvdata(dev); - struct v3d_dev *v3d = to_v3d_dev(drm); - - v3d_irq_disable(v3d); - - clk_disable_unprepare(v3d->clk); - - return 0; -} - -static int v3d_runtime_resume(struct device *dev) -{ - struct drm_device *drm = dev_get_drvdata(dev); - struct v3d_dev *v3d = to_v3d_dev(drm); - int ret; - - ret = clk_prepare_enable(v3d->clk); - if (ret != 0) - return ret; - - /* XXX: VPM base */ - - v3d_mmu_set_page_table(v3d); - v3d_irq_enable(v3d); - - return 0; -} -#endif - -static const struct dev_pm_ops v3d_v3d_pm_ops = { - SET_RUNTIME_PM_OPS(v3d_runtime_suspend, v3d_runtime_resume, NULL) -}; - static int v3d_get_param_ioctl(struct drm_device *dev, void *data, struct drm_file *file_priv) {