From patchwork Mon Nov 16 12:24:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 324374 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:5ce:0:0:0:0 with SMTP id l14csp3272721ils; Mon, 16 Nov 2020 04:24:42 -0800 (PST) X-Google-Smtp-Source: ABdhPJyUC1adiCAk68077jF2IHLB0agg2+oaWbuLAmmdEsOR/zcV/wbld9ZBWJ3xeTC7G5Ha0hqj X-Received: by 2002:a25:2e41:: with SMTP id b1mr18277975ybn.384.1605529482347; Mon, 16 Nov 2020 04:24:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605529482; cv=none; d=google.com; s=arc-20160816; b=aM2nE4tSsV/Q6VinY5antu6ywWIuG6Qnyo4CoBxs3vBOCjvEI4ExPDScAfxyZBvFPe DP9/4No+l7mOYmIHi7ZhP4WF2o3i84o6IUAwOXZxZU+2hPYrkjhD7fQJ27JVF7D8rpzW qUNmyk2M7B2Z6EURnD9hl3R2Qowqur+rBJlqQZwy3shneeAmwtH/HUwi2WPsgOI4Hc7h OLkGr4PI/jsndkzeetIjn2WKWzJAyzAV/My1elP3gamjGGZdni/9CiUFcRoi5LkSarE6 xDzU+bj09tep2jpoZWeUG0rwZNWrfADBvyyIxYBYPbncKGFxcuX4nIikrGBouItF+0BU qIgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=vHv4EHcIqVjX/nk8AgqAMkp9FkP1WHOt6fzSvyu1HXc=; b=WMkklk3cc3LNRt5BOy6PrdmeXMJC26DJ/WvsExs1bSbjPZAk0Yxe5SOhWLeBIqFOzI iHsYEX3GsuHEH/yS0fFJJ5HZEJazb+m1R/n1tUC7bFWWGIV852NvoyTrPghypMWzGzFD Ni5TtSx7E9+lM5Fz/XauVEmOARHEQVtjRzrgmYKWduEBTATEtvlbiXjKkw8yZYW3RqLL N8PrgjOR59pe1WiVC8+FuJeqG1pk1GEFpsLyk22zmt1IJ4wZ76qnGmf68u2GsRZ7i/oq qxcu1VQ1chNfRaSNO7stnmWqXc2Y+lIYQUnN2z6m4O2JYhQtD1NRi6/TGYCoRjWX1hgX Ictw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=cQEEMK3h; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id u12si17507447ybm.271.2020.11.16.04.24.42 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 16 Nov 2020 04:24:42 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=cQEEMK3h; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:51502 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kedYn-0001Vc-R5 for patch@linaro.org; Mon, 16 Nov 2020 07:24:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57934) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kedYX-0001Th-Tp for qemu-devel@nongnu.org; Mon, 16 Nov 2020 07:24:25 -0500 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]:51103) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kedYW-00037o-8n for qemu-devel@nongnu.org; Mon, 16 Nov 2020 07:24:25 -0500 Received: by mail-wm1-x335.google.com with SMTP id h2so23567988wmm.0 for ; Mon, 16 Nov 2020 04:24:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vHv4EHcIqVjX/nk8AgqAMkp9FkP1WHOt6fzSvyu1HXc=; b=cQEEMK3h469kTNKn+cv+AOMt5eP0GBBv7ROtsjqyUby9+ebseIjkMAOT19cBFMgLQ/ p0rlk2EKbmjb61rpxVbl5Gweq8u3/m6Tzp/Ys1BPn24iiNR3ys23qPjqmHM8yGKGbWhx ac1GyJ+u5sHU4gHrjVSpS/1AgY8seaCgV5pjWv5txsRdRJ7esfwTzV2adHj2AJ7oAKdm d9w9gC2Z60TnfaDYaWUxt1yhCptvlW2c2+SFcFb+FwFjoJEo4LSteqcvemYXl7wZCPxL PoSlTr19wo6hMJTaMLsKKBCeApzqU8lNs2Z8jkZtsjZnbG1WaB37+6LfMbXlpu54h8LY K3Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vHv4EHcIqVjX/nk8AgqAMkp9FkP1WHOt6fzSvyu1HXc=; b=N7BDPitqUqJtPSLOPCI5ExBpSKQntojKAjvOs64RSBUS6XpJJgdYxC1Vjx+BnmbFyg COfU+zcp+PnWsp0dG0ZYJxq7HbQL9+jQS65uQGjzntea1itHIzlK1+p1pygKI4to7bPo xWMlfOlpNUFRYdCdWkEZINuq2QbOKP4DCE6rNhWXbdjpDmB9lcgHIUPd5E0l9jvxy4qM wMPHOsThkk8FDyE8+jwFgGNcziHyRTIAv/8j33PwcqGSROm/raPdIOQ7EqGbTDfuxuZZ Au0CBnb7KVO5tvk8rGYCi0I5ZMmPurZAOCqLiNsoyh20dOXvSnUoNHUphbByMObors23 ArRQ== X-Gm-Message-State: AOAM530z3VEpreI36jxAT9lsp0STQbQPYRHQVnIxehmRFyfA44TXe+ny 5xwIJJyETucj0P3+5mqzv1Ommw== X-Received: by 2002:a7b:c202:: with SMTP id x2mr14950568wmi.48.1605529460860; Mon, 16 Nov 2020 04:24:20 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id t74sm20045679wmt.8.2020.11.16.04.24.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 04:24:18 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id DF03F1FF87; Mon, 16 Nov 2020 12:24:17 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: peter.maydell@linaro.org Subject: [PULL 1/9] plugins: Fix resource leak in connect_socket() Date: Mon, 16 Nov 2020 12:24:09 +0000 Message-Id: <20201116122417.28346-2-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201116122417.28346-1-alex.bennee@linaro.org> References: <20201116122417.28346-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x335.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alex Chen , =?utf-8?q?Alex_Benn=C3=A9e?= , qemu-devel@nongnu.org, Euler Robot Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Alex Chen Close the fd when the connect() fails. Reported-by: Euler Robot Signed-off-by: Alex Chen Signed-off-by: Alex Bennée Message-Id: <20201109082829.87496-2-alex.chen@huawei.com> Message-Id: <20201110192316.26397-2-alex.bennee@linaro.org> -- 2.20.1 diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c index a696673dff..319bd44b83 100644 --- a/contrib/plugins/lockstep.c +++ b/contrib/plugins/lockstep.c @@ -292,6 +292,7 @@ static bool connect_socket(const char *path) if (connect(fd, (struct sockaddr *)&sockaddr, sizeof(sockaddr)) < 0) { perror("failed to connect"); + close(fd); return false; } From patchwork Mon Nov 16 12:24:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 324378 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:5ce:0:0:0:0 with SMTP id l14csp3273807ils; Mon, 16 Nov 2020 04:26:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJwToJgPztMhXxx23rzn5W8XOPrtuLbWVwiJseGLTpODM7LRLAQgWe85hkTk92AQ+HPJjbRt X-Received: by 2002:a5b:852:: with SMTP id v18mr16320749ybq.294.1605529580107; Mon, 16 Nov 2020 04:26:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605529580; cv=none; d=google.com; s=arc-20160816; b=COxlSuheMP4+TnX0tg9BStaaP4l08J13gQqjof4MQIW4knhN+9ZuNgI9MSTBi8tpyS OR/Glj4O1pLT998GBJyFWaBzY/3D6dWK1pk3hkcdbZveOt8NHIrQoo/IK2keQkz61g1e 2nvcPAd3EnjyeC4BiXygNXcrxjFFcMC9tVAdgKtRvPWoiDLuc1lcgI0OZNWecEyaDNqq xNbVgTIdVcgq9v5Gh6V71iR6azUpf+B06DgUsiuXOoViAqUbJWwaXFyKOPz9Aa3auGJy yqx6lN1u+2zTcHUalt4qY0yy6JUM9gVTXDdmnbIbQYA7DVzggCwyn8oEX51qauAEKm4F kifw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=zd36bEnryeQaHWHJSjvHzqGrH8fim6jYM/QnIrK9Ve4=; b=SczWofVJ3wv14owecQ83tM3HVuAyWGvWMUEdOB+xJvk9NWID0CS/8W8sRFGTlacOgk S9rTXJBG+4Q851safSd33K75PcUlXIC6dcv0FddfNIKLAEEiI1opedJETY29+CNNqUR+ 2cuGCZ5MQXS7flCMj0gxCyBiMrdjfnhvzBKwRlKR81Ps3F7jCjhxz6W0RpUEym2X+X9u SnpVpnT2p5o52vSfw4ZHqNcB30GJcaZjFf5cbaTPYhFhBLfaOiDDO822E1SIsF7bPnfC +udkqQcEkBfudhl3J1X8GOU8+Jh2NGzr+fcsQjTCnABjuZiQLwgqTI5RMkhAMbtUtrVB Yzkg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=lxXzheFI; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id v8si16837113ybq.437.2020.11.16.04.26.20 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 16 Nov 2020 04:26:20 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=lxXzheFI; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:54116 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kedaN-0002ge-JU for patch@linaro.org; Mon, 16 Nov 2020 07:26:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57950) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kedYY-0001UV-Lg for qemu-devel@nongnu.org; Mon, 16 Nov 2020 07:24:26 -0500 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]:45537) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kedYW-00037t-AF for qemu-devel@nongnu.org; Mon, 16 Nov 2020 07:24:26 -0500 Received: by mail-wr1-x42c.google.com with SMTP id p1so18439349wrf.12 for ; Mon, 16 Nov 2020 04:24:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zd36bEnryeQaHWHJSjvHzqGrH8fim6jYM/QnIrK9Ve4=; b=lxXzheFIEfvO5COIsQ4JTCW6OMHJlZ0ihB8+YzY4xHU6fRQXDMk4EwX1tmiwwZG0RK qGTCdjUyGDUPu3ou1QPtsFo6MmA3j2VETNW1TX4xI7gPsUfXymIubQc64y+ixtwD59Ei IG4M9VX+3QIbu+vAGlr7KuhEcfYV54qOXuD634yxC9n/HdvQhLPSFDByVgYIneqG3j0X GZ7pq8tr4U7UZue4SKht+LrM3zSvX5xHSopqoOr+B1j9UXdcxyCV+7u+SJlSM/2vL1mH kLYUd7msDlVlLNmm7XNbV095l7pm68ZQQMWMPFIRZ16+GJJ8+GRhsjMRyxal+Vv+WfXv BqSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zd36bEnryeQaHWHJSjvHzqGrH8fim6jYM/QnIrK9Ve4=; b=ugc1pjV4HPdcpFe0i/ignADL75TWBDgbdNeymFV0ghcIc4pK6XToFFxczR5SXvd4la BFptrkEmpAvz50KQMBmmM1TwH/7yESjGoxpVugpbn/GBgjxbMhzWUsCd/KkEIqOJAJGj KZF14BBdoLY7aiwUVMWkg+4bK3JhE585lmBjnYdT2WXqTwymsvRBn2C5iWWD03fM4AKo r7Wx0/QndDjj0cAm30vcob/c8RhzMxR7DJ8fuwaoeJp03y91NS+e9g5Zb0hwpzdgyQHV 8guk2b0u54hvlnSaMLoCdFcV13JAmq2GEdyOKJU/1XHYKpo0vjDeza5W2DC0j82rMnKb MRrQ== X-Gm-Message-State: AOAM531eMZIVJKtlSO2ZzAG5TtihXLwrzJUZ6veL2jBeEfkCTi8RKAHe On3HZ2ruDss/seXbVvZEGUyH0A== X-Received: by 2002:adf:f852:: with SMTP id d18mr18270630wrq.232.1605529462406; Mon, 16 Nov 2020 04:24:22 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id q17sm26118448wro.36.2020.11.16.04.24.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 04:24:19 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 013761FF8C; Mon, 16 Nov 2020 12:24:18 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: peter.maydell@linaro.org Subject: [PULL 2/9] plugins: Fix two resource leaks in setup_socket() Date: Mon, 16 Nov 2020 12:24:10 +0000 Message-Id: <20201116122417.28346-3-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201116122417.28346-1-alex.bennee@linaro.org> References: <20201116122417.28346-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42c; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42c.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alex Chen , =?utf-8?q?Alex_Benn=C3=A9e?= , qemu-devel@nongnu.org, Euler Robot Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Alex Chen Either accept() fails or exits normally, we need to close the fd. Reported-by: Euler Robot Signed-off-by: Alex Chen Signed-off-by: Alex Bennée Message-Id: <20201109082829.87496-3-alex.chen@huawei.com> Message-Id: <20201110192316.26397-3-alex.bennee@linaro.org> -- 2.20.1 diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c index 319bd44b83..5aad50869d 100644 --- a/contrib/plugins/lockstep.c +++ b/contrib/plugins/lockstep.c @@ -268,11 +268,13 @@ static bool setup_socket(const char *path) socket_fd = accept(fd, NULL, NULL); if (socket_fd < 0 && errno != EINTR) { perror("accept socket"); + close(fd); return false; } qemu_plugin_outs("setup_socket::ready\n"); + close(fd); return true; } From patchwork Mon Nov 16 12:24:11 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 324377 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:5ce:0:0:0:0 with SMTP id l14csp3273786ils; Mon, 16 Nov 2020 04:26:19 -0800 (PST) X-Google-Smtp-Source: ABdhPJwpMyLCKM4JSDP8YszRydi6kSVZusXmJxLS+fJRCAswZt7EUUMAtglPbfgCM/tV2BPf/fVt X-Received: by 2002:a25:428b:: with SMTP id p133mr25868789yba.261.1605529578975; Mon, 16 Nov 2020 04:26:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605529578; cv=none; d=google.com; s=arc-20160816; b=G7wmQ8yEwittpcPTs3d8L9f1eW9INCCmwqZiNuViQugUzUg1yNM3ULP36VGllXWeDJ NE8k0y+0lu2ZKt6rxU0erLN5h80W0bgB4vIucKYuxU+qabZFeyGSVLkVy3OWK2DwNr07 6sAEs+tbXxbprjSDPrjN8huS9xZFy6tnlffKTsKgryzF7YH6z6k+K3wlIxw1FGgdil9f S0jik0oPPErjLyKyNN16q31xhvBRMy1m70x7Io4KUJ7d+yeueDrcXLYVZt/12tMX8QtF zaxJaK5J1xO5J6JjGPtwMlWyWdMaEoGVsURPQJyXm90+esoDjtF74DhikPVTVGWlnKzh XZYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=Q0zxAwcwYBxpBHl7aUkK6beKSxBJqCkVvaQ7o3vFSac=; b=b2Tr91bWyXpwZzNBEQR6Clg6cEI5aM2G/NUg0WdH1OHXgQD0+kcLY6u/OfSToGEKkR EaMUWrCqwqQT3T37hxIPDs1yrCCL57McuypT8mZM9eg0fh0L6vp70TPKKC8svAtqU64/ RpvCkVzXme4cR1SCyqEp0LkDPI7dZHM7YpLIT+6MyhnjrVORR3nRgJfQ1y3pNY/nbGWK vUJkz7hCDvwuPFUsSbh0Zpe+LSA7V+eOl9WjKqYGt8ADSCt7iZpvJIZEdAQqUVR6fwAR JaUUhvV53jTbcswbhlmc88k2ogD+BZLM1Lm4JitcJO/XZJDGZ09kukaTfRnD7fiu8k+o Zemg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=b1pQUa2E; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id o203si18656421ybg.323.2020.11.16.04.26.18 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 16 Nov 2020 04:26:18 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=b1pQUa2E; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:51646 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kedaM-0001ZB-Fq for patch@linaro.org; Mon, 16 Nov 2020 07:26:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57954) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kedYa-0001WQ-19 for qemu-devel@nongnu.org; Mon, 16 Nov 2020 07:24:28 -0500 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]:51511) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kedYX-00037x-1T for qemu-devel@nongnu.org; Mon, 16 Nov 2020 07:24:27 -0500 Received: by mail-wm1-x32e.google.com with SMTP id 19so23545578wmf.1 for ; Mon, 16 Nov 2020 04:24:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Q0zxAwcwYBxpBHl7aUkK6beKSxBJqCkVvaQ7o3vFSac=; b=b1pQUa2E9nj/YN9o0VLCOXTzklCK3hPL0MK+radCP2iofi+zq1ECqT9GuIdQrA+z3F r7406UPfMi+lMQiabjxqng4HMCAgSTCcyJhm0+Z/yNvWuhG7wo5/r0pI9sZjA+uLTi5e 0jukkH0W5XGY4UHlE5FRIZCdmbaRVWWjgDT3qhS5WeqD74wmGZP5RdYXMno2yHk5KTUU AUKA2bhqDAatPx143RRAfeRl9oJDaCmROu72xhZdNgrs3YwC7SHIAu+Z/IJFWHKNJV8h keEU96AzRFW4OALXIKoOGV/4XYwN987L5CeBIKx/392SYxvZyKUWJLLhy//yGzEUfDlr M/lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Q0zxAwcwYBxpBHl7aUkK6beKSxBJqCkVvaQ7o3vFSac=; b=ah6uZLBS+TEoxYcivryg1z8jobuKxG4N6i5Imeeat0WR3jiNs/QCwRmyUwonTixAd7 DzAy98hTn31B85E4DPkj3dEZEz4OOo9XbBdSEyPgGf4KxarFTxt+3OY9LBmNSBnWHYcM kJsZrd/798tJU2zw6mjdmTjGLYpw+SMaCi1qeJVwyCfDHs13jscT3sFlfNbXwlSruBFI 4Be7+q8AzJ3gi52/D0/vZVJyRFFFeximRX/uilg0geMjnWqkZEI2NGv2ul4q/xV33q0V ZvwWHwpmGSS0aZfYW38RA63WYSDhTTX0BaVmcnG37HCCD6o7GUv5on2we3hYcjg7MJlz Qfcw== X-Gm-Message-State: AOAM531avbGwSL3CrR1JgTa1OvxfH8Fj8z/iGWJEWVJQJsc5QJNns+ld p267JIZXQS+r9tBOGDln4JCQdg== X-Received: by 2002:a7b:c77a:: with SMTP id x26mr15262421wmk.63.1605529463753; Mon, 16 Nov 2020 04:24:23 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id e3sm6017716wro.90.2020.11.16.04.24.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 04:24:21 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 171EB1FF8F; Mon, 16 Nov 2020 12:24:18 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: peter.maydell@linaro.org Subject: [PULL 3/9] meson.build: fix building of Xen support for aarch64 Date: Mon, 16 Nov 2020 12:24:11 +0000 Message-Id: <20201116122417.28346-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201116122417.28346-1-alex.bennee@linaro.org> References: <20201116122417.28346-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32e; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x32e.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Masami Hiramatsu , Paul Durrant , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, Anthony Perard , Paolo Bonzini , =?utf-8?q?Alex_Benn=C3=A9e?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Xen is supported on ARM although weirdly using the i386-softmmu model. Checking based on the host CPU meant we never enabled Xen support. It would be nice to enable CONFIG_XEN for aarch64-softmmu to make it not seem weird but that will require further build surgery. Fixes: 8a19980e3f ("configure: move accelerator logic to meson") Suggested-by: Paolo Bonzini Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Cc: Masami Hiramatsu Cc: Stefano Stabellini Cc: Anthony Perard Cc: Paul Durrant Message-Id: <20201110192316.26397-4-alex.bennee@linaro.org> -- 2.20.1 diff --git a/meson.build b/meson.build index 61d883bc07..132bc49782 100644 --- a/meson.build +++ b/meson.build @@ -74,10 +74,15 @@ else endif accelerator_targets = { 'CONFIG_KVM': kvm_targets } +if cpu in ['x86', 'x86_64', 'arm', 'aarch64'] + # i368 emulator provides xenpv machine type for multiple architectures + accelerator_targets += { + 'CONFIG_XEN': ['i386-softmmu', 'x86_64-softmmu'], + } +endif if cpu in ['x86', 'x86_64'] accelerator_targets += { 'CONFIG_HAX': ['i386-softmmu', 'x86_64-softmmu'], - 'CONFIG_XEN': ['i386-softmmu', 'x86_64-softmmu'], 'CONFIG_HVF': ['x86_64-softmmu'], 'CONFIG_WHPX': ['i386-softmmu', 'x86_64-softmmu'], } From patchwork Mon Nov 16 12:24:12 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 324375 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:5ce:0:0:0:0 with SMTP id l14csp3273556ils; Mon, 16 Nov 2020 04:26:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJy+Ka083+jAyE49eDrKx5M4Lohf1oAV0mRNu6m0kj5nXa8hvAmJDzov2Uh3gcSFSL7F7MzK X-Received: by 2002:a92:b504:: with SMTP id f4mr7703013ile.34.1605529561973; Mon, 16 Nov 2020 04:26:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605529561; cv=none; d=google.com; s=arc-20160816; b=kZN8zEWUOnVZa9LZrRV4ZG8Rs4Hpejf6WM/w1RzhdmiykkFD+ObGi4iCpP7iclPW9Y V6gqOkfmaPwP7xJoVa9g9sCzItlfCIBawC8AdKp30+3Gh3y3paNaundrdzA2uJEH66PJ mxoWZ5lOPcLaLzMc19NPFjwVqqSTA8eaOMFrA4aQnF5YuVAF8RfwiYSVbqLog10bJYne XI+TdK5MesXeLwwnPrf8EYurp9yUhRI85gVCUDrU7Fb0+kRsZEf+Dn1AqrDtQjX4WHmJ hvZjQ1BcoOUPVfeau1HqZLJ3o5qXT+AkF1YFC4ghBBl/hx4HtlLCGVT5dXDyiZ7XNtEM rryQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:sender:precedence :errors-to:list-subscribe:list-help:list-post:list-unsubscribe :list-id; bh=25kCBizsj7x/H9MBq/7Zh8HdKyedfrYbs0Sj7nFGxRg=; b=D9xVQz9r6j2Zk80aXTISpKFgTkIEfnm9iJieVD2+kLdF19XwPWecbojwRW7RYNbeZS a4b7IbmvOiHMAOgRQc6cyj2HxWrkO90wZRtzFysYlCaL9g79mP4nqRMGzp228UXX/YxJ qGnIRE19Sp69HXFjUoW2uZntixQTkukcxun45RSuhyyFEXo/J+J01gVQ41PHqxDe8S8A zCyRzI+22ryImwW0iVoo11liiRa7ilyTPbDeBgCn8egoeUXSHyjZI7NyyYcs+C6pjVdD N0nDc5ZbbQCa53DeWysbLDwFojiKO4a/FQXH1yNd2CJtB+jnyHAI/GmjkFW0qNEMrH46 P5Aw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=d5pz22vL; spf=pass (google.com: domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org. [192.237.175.120]) by mx.google.com with ESMTPS id r12si4676512ilt.20.2020.11.16.04.26.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 04:26:01 -0800 (PST) Received-SPF: pass (google.com: domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=d5pz22vL; spf=pass (google.com: domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from list by lists.xenproject.org with outflank-mailman.27871.56446 (Exim 4.92) (envelope-from ) id 1kedYb-0001Nq-Jf; Mon, 16 Nov 2020 12:24:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 27871.56446; Mon, 16 Nov 2020 12:24:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kedYb-0001Nj-GQ; Mon, 16 Nov 2020 12:24:29 +0000 Received: by outflank-mailman (input) for mailman id 27871; Mon, 16 Nov 2020 12:24:29 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kedYb-0001Nd-7U for xen-devel@lists.xenproject.org; Mon, 16 Nov 2020 12:24:29 +0000 Received: from mail-wr1-x436.google.com (unknown [2a00:1450:4864:20::436]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 57e0c7ed-5be5-49e0-8a38-19966425d512; Mon, 16 Nov 2020 12:24:28 +0000 (UTC) Received: by mail-wr1-x436.google.com with SMTP id p8so18490266wrx.5 for ; Mon, 16 Nov 2020 04:24:28 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id t5sm19671024wmg.19.2020.11.16.04.24.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 04:24:21 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 2DD991FF90; Mon, 16 Nov 2020 12:24:18 +0000 (GMT) Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kedYb-0001Nd-7U for xen-devel@lists.xenproject.org; Mon, 16 Nov 2020 12:24:29 +0000 X-Inumbo-ID: 57e0c7ed-5be5-49e0-8a38-19966425d512 Received: from mail-wr1-x436.google.com (unknown [2a00:1450:4864:20::436]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 57e0c7ed-5be5-49e0-8a38-19966425d512; Mon, 16 Nov 2020 12:24:28 +0000 (UTC) Received: by mail-wr1-x436.google.com with SMTP id p8so18490266wrx.5 for ; Mon, 16 Nov 2020 04:24:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=25kCBizsj7x/H9MBq/7Zh8HdKyedfrYbs0Sj7nFGxRg=; b=d5pz22vLeXK1wHTPtF+ZsxVIjXGA8gl6Tp/KPuXBtayrc3ZztGUFqO9NqNNtYCD6S9 GIqQTWfi7rk11d3aNpYM5Sovu1nZQUg4k78J8N0ovb1RP8rhqjz2ziat2y93gTIR19az oIzdPJAEHeOZ+1ho5ixYDxsdnnSTsvLBGvo0C1S/ZpaCfzu60H/ZhbVXIE/Fz6X2rnuz bGp+15bJpLSMupv0X7HDh/jbzWyiTXsvLQDjR/xUxuiuAC0BgRnrEMAv7S86N9y/PO/J YZ30NYDyOCbsIzdK53/YmkNgrvXL1/EPIj5xyUtm8/JL1r8SstFTI9HT3CYaUmH7ZgB5 9gbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=25kCBizsj7x/H9MBq/7Zh8HdKyedfrYbs0Sj7nFGxRg=; b=hjM8EAHhvikVpXKRBjxijdWu/BQ9fy+Mktfq2nlQlLlSVQiw0xVGzjokS9ysqJ2pUQ JWSQfGLcqV/I3TOR+2FFvASkzdkTQTQC27Tkib4lEIIzNfH1qjzssiRey/4a563sQpEr EbDpOLDt3E4c3Nraph1lPlq64f269pWgXReI8WkuFdW/YXbq7SQMts08QiRtfg/ONJ3m RpdRkCGlEb8kwzMnaZYrm/CLUfky3qco/J46vxtp2wilrUlis0Klm+J2SRW9pXErr4Sq axPQiN6yfs7zakhgmVPimV6G+JebnClq2ut+eUo1su8LpOcfd6YhwXGfQyTNzFoT2/4x pP5Q== X-Gm-Message-State: AOAM530pZISXlPBI3HBaY+G4prUzaV+ykNvn6Pk8zWd0udiNSe3KGGTr CBBaRanLIkyMPq636SQWoK71QQ== X-Received: by 2002:adf:d84b:: with SMTP id k11mr18703530wrl.305.1605529467569; Mon, 16 Nov 2020 04:24:27 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id t5sm19671024wmg.19.2020.11.16.04.24.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 04:24:21 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 2DD991FF90; Mon, 16 Nov 2020 12:24:18 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: peter.maydell@linaro.org Cc: qemu-devel@nongnu.org, =?utf-8?q?Alex_Benn=C3=A9e?= , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Stefano Stabellini , Anthony Perard , Paul Durrant , xen-devel@lists.xenproject.org (open list:X86 Xen CPUs) Subject: [PULL 4/9] include/hw/xen.h: drop superfluous struct Date: Mon, 16 Nov 2020 12:24:12 +0000 Message-Id: <20201116122417.28346-5-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201116122417.28346-1-alex.bennee@linaro.org> References: <20201116122417.28346-1-alex.bennee@linaro.org> MIME-Version: 1.0 Chardev is already a typedef'ed struct. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20201110192316.26397-5-alex.bennee@linaro.org> -- 2.20.1 diff --git a/include/hw/xen/xen.h b/include/hw/xen/xen.h index 1406648ca5..0f9962b1c1 100644 --- a/include/hw/xen/xen.h +++ b/include/hw/xen/xen.h @@ -28,7 +28,7 @@ int xen_is_pirq_msi(uint32_t msi_data); qemu_irq *xen_interrupt_controller_init(void); -void xenstore_store_pv_console_info(int i, struct Chardev *chr); +void xenstore_store_pv_console_info(int i, Chardev *chr); void xen_register_framebuffer(struct MemoryRegion *mr); From patchwork Mon Nov 16 12:24:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 324376 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:5ce:0:0:0:0 with SMTP id l14csp3273613ils; Mon, 16 Nov 2020 04:26:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJz608zLxN8MLM0FFLEz1wmGq2gc4Oeq5paZp1UXnel8jXiQEIMcMQ2EVIZs8HHLYalpRU0d X-Received: by 2002:a05:6638:58a:: with SMTP id a10mr10240255jar.51.1605529565511; Mon, 16 Nov 2020 04:26:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605529565; cv=none; d=google.com; s=arc-20160816; b=fU7Tkp/fe81lLtTlHnE4HlI3avBND3JjcwJspE6vUwtnUtvA7xFUbVk1GRpOUH1IVD iZyKx6RXFf+S81f+4kpXxuSkVN/3UAmNCvik6PnyD9jov8wS6fCJN4f0aiU2Doj+w1TC vl8HJrIVClGYFgH0kogKlunc/StmXkWRdd1wfh1grY+uBAlDBFHpx3KsB03cFWttasT3 rAOCc4KziB+vkpmIWMNyNsNms9K4iBwom7GCaBjxap0WVi/nJCAczw1iQ+e0r3zs7BkY XHZECbZPhrk1Tq/+ceS4u0JyWOXWSVaY3o16uIVFlIlBFihVW3XWfQufiGaX7Ht3/yeM hxBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:sender:precedence :errors-to:list-subscribe:list-help:list-post:list-unsubscribe :list-id; bh=I5N/dAQ0srBictVseT2rP2fA4AanR0t+DIq+DoGQDUA=; b=I24nUP1CPr9Zc8MhIuWYsrvl0fRs1HYBdDQB8DmSyt3tHmTHycPw/k+6DZ/eO/JSXC 8M7T6Fw5EwSuvlSb8Y2BluFKWPWgN0CGzNhz+QXkIpu5fv1bCwWHDC9t2Sa6YmIwfNzU VlQ6Ru35AQkNJmMnVdHQqKq05DkPRVSqEx7dGZk5nHNoss4RVcTd04Qv04/JKUcVqPzO etKba3UDj+PahgVUFjmNKV2UcdWRX1t988JoDaDGVpr168aWEetEypPxZAClgm6zBqGW xhW0+oWz/bjkZifLvC3ixS5pqFj+9uZymqSH9cQ40MikTbC5saUwR+ALVFXI8SfTFi9s QNhw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=kUv5YnOu; spf=pass (google.com: domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org. [192.237.175.120]) by mx.google.com with ESMTPS id d19si9816504jak.9.2020.11.16.04.26.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 04:26:05 -0800 (PST) Received-SPF: pass (google.com: domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=kUv5YnOu; spf=pass (google.com: domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from list by lists.xenproject.org with outflank-mailman.27872.56457 (Exim 4.92) (envelope-from ) id 1kedYg-0001QH-W8; Mon, 16 Nov 2020 12:24:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 27872.56457; Mon, 16 Nov 2020 12:24:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kedYg-0001QA-T6; Mon, 16 Nov 2020 12:24:34 +0000 Received: by outflank-mailman (input) for mailman id 27872; Mon, 16 Nov 2020 12:24:34 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kedYg-0001Nd-6Q for xen-devel@lists.xenproject.org; Mon, 16 Nov 2020 12:24:34 +0000 Received: from mail-wr1-x435.google.com (unknown [2a00:1450:4864:20::435]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6996d5b0-907b-4f02-84a4-68e287af2eeb; Mon, 16 Nov 2020 12:24:29 +0000 (UTC) Received: by mail-wr1-x435.google.com with SMTP id s8so18457502wrw.10 for ; Mon, 16 Nov 2020 04:24:29 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id w15sm23012424wrp.52.2020.11.16.04.24.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 04:24:22 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 4553E1FF91; Mon, 16 Nov 2020 12:24:18 +0000 (GMT) Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kedYg-0001Nd-6Q for xen-devel@lists.xenproject.org; Mon, 16 Nov 2020 12:24:34 +0000 X-Inumbo-ID: 6996d5b0-907b-4f02-84a4-68e287af2eeb Received: from mail-wr1-x435.google.com (unknown [2a00:1450:4864:20::435]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6996d5b0-907b-4f02-84a4-68e287af2eeb; Mon, 16 Nov 2020 12:24:29 +0000 (UTC) Received: by mail-wr1-x435.google.com with SMTP id s8so18457502wrw.10 for ; Mon, 16 Nov 2020 04:24:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=I5N/dAQ0srBictVseT2rP2fA4AanR0t+DIq+DoGQDUA=; b=kUv5YnOumF/Ptfw2eqBb3oW9vbtrXH2sp4GACYHhA96xfqkjYNrDu1E4hPFaiMhABN 5r6Bp5+qFL+41JkZts4NLOMDU+BOZ7f+B3OxTSrsN4NMQ1sCmvnPaCAgK7AUxbRQBHMz 2eie64PA2/H4D4HRatmXT07ZJAMsiUF2S2iEBlis90fJOUM3ifH+NgoBJ7NHRUe5GSxJ 51rArOQXs0dhUX8EN7kitzVSfDEdlKri/ftf2l6VWkJuIkLMNx4oHB7NGAIgPePTFDsa KOcaFHJBgMjEndAwhqkKbtIf/jfW3DQ88lvtkMKy0vdV8Oahf+jklSClwHom/imIJJtL QtGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=I5N/dAQ0srBictVseT2rP2fA4AanR0t+DIq+DoGQDUA=; b=f2+qH64Qv46f34qMaTyttnwN3+MCBs8E2OfWuGrR1N1m+hTFqRfX7nXocvWvCLavby anhG9xcHhV9G/DkEyzVlutGdojLEiXYqsStlWNQxYwKI85goWZJfZvYbEOHjDjMAp4Hh rArCtTXBT8DPKa984O5s3xvyX79qWa3ZdRH7TaPg66DEHvDS9mEk2PJ8DDdF75OYdlzS 3dR3ufQPAI0QF1wYI9nN7/CUiwJq7xWM3vSnvvNTt+oCF2VDEyinNDgPx0gA5gKWfh/3 gt0iLBuzS+jQAsryql0iCf8L72yq+i+CtjGG3Mch0/RruFha6zqOZ5dsSCVuh5g8OBuJ KgoQ== X-Gm-Message-State: AOAM530api3En5Oq9k53KMPoPcxqvXhklT0YZhLVTgVle8jQQdEqmGea R3o7dra3f4YWU7ZgWIi0jtLmzw== X-Received: by 2002:adf:e74d:: with SMTP id c13mr19836328wrn.277.1605529469173; Mon, 16 Nov 2020 04:24:29 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id w15sm23012424wrp.52.2020.11.16.04.24.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 04:24:22 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 4553E1FF91; Mon, 16 Nov 2020 12:24:18 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: peter.maydell@linaro.org Cc: qemu-devel@nongnu.org, =?utf-8?q?Alex_Benn=C3=A9e?= , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Stefano Stabellini , Anthony Perard , Paul Durrant , Paolo Bonzini , xen-devel@lists.xenproject.org (open list:X86 Xen CPUs) Subject: [PULL 5/9] stubs/xen-hw-stub: drop xenstore_store_pv_console_info stub Date: Mon, 16 Nov 2020 12:24:13 +0000 Message-Id: <20201116122417.28346-6-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201116122417.28346-1-alex.bennee@linaro.org> References: <20201116122417.28346-1-alex.bennee@linaro.org> MIME-Version: 1.0 We should never build something that calls this without having it. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20201110192316.26397-6-alex.bennee@linaro.org> -- 2.20.1 diff --git a/stubs/xen-hw-stub.c b/stubs/xen-hw-stub.c index 2ea8190921..15f3921a76 100644 --- a/stubs/xen-hw-stub.c +++ b/stubs/xen-hw-stub.c @@ -10,10 +10,6 @@ #include "hw/xen/xen.h" #include "hw/xen/xen-x86.h" -void xenstore_store_pv_console_info(int i, Chardev *chr) -{ -} - int xen_pci_slot_get_pirq(PCIDevice *pci_dev, int irq_num) { return -1; From patchwork Mon Nov 16 12:24:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 324379 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:5ce:0:0:0:0 with SMTP id l14csp3274416ils; Mon, 16 Nov 2020 04:27:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJwKJU4ZmUnH9G+iNjuqwfP47o318Zw0qhxkpoFDYrCx+0MJfdcOpFzcfVujtLh+oDPiP9pZ X-Received: by 2002:a25:7e42:: with SMTP id z63mr23473621ybc.63.1605529637962; Mon, 16 Nov 2020 04:27:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605529637; cv=none; d=google.com; s=arc-20160816; b=maPf8QLgFyn05rrJmpO+q3IwXtvq+joxpxBeL4jpXIdfggkqTd+07j18GzDFAJe7XT N3/bbE52o0WYuaY8BupeS9ssfNTsbF59C2viShtguOo5Kr8FvNMTVkjV7gRQp+BNXvRZ uSHnEZ6oTCihTDqxchZj9Tzz9bmOP+2lJyMg4MZ6TmNj2VPXiblckVQ+gUZMyN6FFXhT e1LUUzK6rzeduNplgK3dQJ7EK5yWA2dog30qSpfWih9blmSFQxp9ZPrxyKlhXcDUJYu+ m9N4ogO2fFdPU8ea1j5d+JbQHQ4FyM+Im4tTWPW5XFWU1yXaftdIom+0RKggLcV5Zrny k0RA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=/2liRrUwUK/XXyLL2k39bK5WwC6hOMXMLxY6QbrHJfg=; b=QVAGAm1EROvfgSL1n5OfzgwzFATyOToLd6u9ji93R3A/0dAHiIZux49DJ1f0Ditoux ceBA4UjcCKtWLgmlN24YQaVvKY9THIHoRUWc6/dcHggxF/X4zNIUkvHeWXe+L6LjGZHi BBa9TNU/i+d4li0CSilvCROXnukR1f8zTcMje3hBeDnOriBys+ziPywbytPGPh8FxeOL 92oqMJOBHh5G5VWfbapCjUG8Isf3yNDmvjWQ1E+JYXBz0Hd4CgV1dKFnwiW/CBLHJYhW eL74WE6tfiPfnSKHlhjGZcDFcQ8eqiLl2gJAJmtAowThnx08HlHxAX/FP2lzeyS/OEvY epMQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=TGSxyuJr; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id p16si16425788ybg.428.2020.11.16.04.27.17 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 16 Nov 2020 04:27:17 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=TGSxyuJr; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:58598 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kedbJ-0004Ut-G9 for patch@linaro.org; Mon, 16 Nov 2020 07:27:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58016) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kedYl-0001oN-DH for qemu-devel@nongnu.org; Mon, 16 Nov 2020 07:24:39 -0500 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]:38560) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kedYj-0003B1-MK for qemu-devel@nongnu.org; Mon, 16 Nov 2020 07:24:39 -0500 Received: by mail-wm1-x332.google.com with SMTP id m125so12184261wmm.3 for ; Mon, 16 Nov 2020 04:24:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/2liRrUwUK/XXyLL2k39bK5WwC6hOMXMLxY6QbrHJfg=; b=TGSxyuJroYeBgN20M1A9yZqN45c1gb85AebozfWmW+aCLT9YOx0Zaz+qLhD5pHApRW MAkTzxoGGmuf4znMwPIDjZ3xQ16UtFC2UAmFPjC+VdA7OCIIdZjRMIKTZG53EezyfbOU NOkJBPGQpCckVBJnYU3Hptvr8dLhPnpvQzq7gnSqsiqQ3xRvgsdPaRdXh0kCi3ziZY3b 4EeXsy3tQmst6oyMD8A85vUlE+W9ojkH5+DSpNWat8bXwnbgS67pYVw6/maGYRgd9PBT NSUMwp4XQk4TkZxzuAeREzNcmsqXbjcC2glsZUmrufiuf0kp4pYjzkNDB0ovP154aF3b Cw0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/2liRrUwUK/XXyLL2k39bK5WwC6hOMXMLxY6QbrHJfg=; b=q2lO53nlC5Y9wNPmnT+PvAC1IBzyk6qRiBwkMECRzeBKSUNeEbMxKl1RyX7EEuB5Bp or/qBQvKC2s8yNY/DUvtEKltqrCmicqVa3FGh08ujZw/MhHKJRMi1Y/UGVm1SFr7q1NO pBKVgdzbi1smPX+gqHKWXN3TuboshhRTBbkjmv218k73rgxtJsXoKXHvuA39WI/HXlwR eBtsm0HNfQ9W4CgGIssq191rGqplAIhA6JsrHzsMHJml5qeyF7o5u2wKeAJROHXZA7FX qnk510IKSj7iBHLQVzn/h2D2FgQhNLg0fEydIVRPcZTP/pjtKiSPoS1yjIftJrZY5HBn EYZw== X-Gm-Message-State: AOAM530caLyAEjThpvBPGgsO7Ku2p1E6q7kmBemoEyO0jeaLshMoF2mP HzgHFSaFsdm7M9DHEFdDEXdkUw== X-Received: by 2002:a1c:3d02:: with SMTP id k2mr15760536wma.183.1605529474027; Mon, 16 Nov 2020 04:24:34 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id s188sm19922233wmf.45.2020.11.16.04.24.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 04:24:22 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 598491FF92; Mon, 16 Nov 2020 12:24:18 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: peter.maydell@linaro.org Subject: [PULL 6/9] accel/stubs: drop unused cpu.h include Date: Mon, 16 Nov 2020 12:24:14 +0000 Message-Id: <20201116122417.28346-7-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201116122417.28346-1-alex.bennee@linaro.org> References: <20201116122417.28346-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x332.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Alex_Benn=C3=A9e?= , qemu-devel@nongnu.org, "open list:X86 HAXM CPUs" , Colin Xu , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Wenchao Wang Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20201110192316.26397-7-alex.bennee@linaro.org> -- 2.20.1 diff --git a/accel/stubs/hax-stub.c b/accel/stubs/hax-stub.c index 1a9da83185..49077f88e3 100644 --- a/accel/stubs/hax-stub.c +++ b/accel/stubs/hax-stub.c @@ -14,7 +14,6 @@ */ #include "qemu/osdep.h" -#include "cpu.h" #include "sysemu/hax.h" int hax_sync_vcpus(void) From patchwork Mon Nov 16 12:24:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 324382 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:5ce:0:0:0:0 with SMTP id l14csp3275906ils; Mon, 16 Nov 2020 04:29:35 -0800 (PST) X-Google-Smtp-Source: ABdhPJyg49af0bkT1dqEJ0K4IzLhPCG775uS4bIgqbC20SreJ4VpXN4lYD0/cJ0ZlUngkku+drKm X-Received: by 2002:a25:bc42:: with SMTP id d2mr21333557ybk.461.1605529774923; Mon, 16 Nov 2020 04:29:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605529774; cv=none; d=google.com; s=arc-20160816; b=DfoOTV+vR+Ob8OTclwFJFLzeEJ9NNo8tKDuSxNJDrcPTdFv5YFs0cE1qXfqmAxorI9 nOf9rAU3jfycxbOuimznjIVb/QXUDdkxH0k0KJgsTtrg6WMToAaX4lSggGpUzF4VaBKX jLD9rTcGGV/H5Nz5tj1TYUvGoOpejnD1EwjT0ofvM5FbnpqSzyIw7rphJBDKThYYXhgk YCaYxF2z/35DZ1IRa9jnEZvUmG+V9z0dR3Knd6aBavoz31xLphxYkI6ij6QieRn8vIus bXVCHP+yXj9xsUmKExriiFEP/xwctNDgwZOfCyNShw5QwcKQ3wpu05g1YjYlv3TLwV+8 qN8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=OUmMobUpj5JXbp+PLsouZvAX3qQPm1cOEtWl7FIgmgA=; b=pPF5UIJWIJXcuwjAKvQyB/apynZvScjKpLZE9j5BUd6Y4E7OiNOWtTVryD2kUwAN+A m/NtGvByInfEPqtp3xjbDZ5Tp6GScm+k3gLvI2WIt/FVAohvAXXUCOUIINolhZzod6ms ti+UOYVVGC5PhonkFbkEY2X5LgEsZBHJmA+95nhR6V7SkNxtl/QhoOm80OkZHMEM3bV2 /8tO+o3WddaqcimIVJf1PWUhKf2Nk91rjgXMs0uKHLBrQTMqftVY5hjIWXMOjO9Zldcn vn9cpBBI6RGD2ebdiiivUkKuStERvYpS6NHjeQV0wr7Z/0tuKJ918XoC51K6aOxs/X53 PaXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=yJAFf4qq; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id s203si18169783ybb.453.2020.11.16.04.29.34 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 16 Nov 2020 04:29:34 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=yJAFf4qq; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:36672 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1keddW-00070o-Cr for patch@linaro.org; Mon, 16 Nov 2020 07:29:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58080) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kedYo-0001vg-EI for qemu-devel@nongnu.org; Mon, 16 Nov 2020 07:24:42 -0500 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]:34017) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kedYm-0003CC-D8 for qemu-devel@nongnu.org; Mon, 16 Nov 2020 07:24:42 -0500 Received: by mail-wr1-x435.google.com with SMTP id r17so18509407wrw.1 for ; Mon, 16 Nov 2020 04:24:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OUmMobUpj5JXbp+PLsouZvAX3qQPm1cOEtWl7FIgmgA=; b=yJAFf4qqdOvgvwzFs6bvcMu9vnX9hnsmc+UxrpNTIqugeXjRxj2R3b1IAPlTZGxcFL Qpf7+RYD0ZghQjwQe4P9s+0M1GFAfpy9LYQZo41QrCCcexPE7uitTHuCVJ/mFSISgO7k gTFp/xUuZD6nseUlaanCfsIL5fRvKiGGuYYxAnzOPiL9/uIpN014FrUE38gT9Zxroe1Z z6giYXLU5K8OKEuSe9gHCoK4qe1h7eLfo087A9sHPVjiIHFjMXv9dKq1j9YZZm5Vbfxg hPKm8gO1Bt+j/ALLuPOnZ2mdST3S08i82bpH4wPZEwK8+Af7oYUp0sEDP9MuaRP2G6jS ry+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OUmMobUpj5JXbp+PLsouZvAX3qQPm1cOEtWl7FIgmgA=; b=ZK/bheaMPxQPhpBivovRHXlz738egVry4MAzMRkA+88PL9ncwla7hSS3/QwCBvl73V 3ioZcMTD9jlgUx2KfucEufjeXlDaN5KVCsC2IyadYbbwoPIYE7Q0t1jKucMRltuKkJTj dvVjFFBqFJbg22CR3sNGlxzX/9+j51Zky4URXatBuq6QcNw8EtOoZK610mXxGyF0vAFe lCpCZp06eP6NOFO3rTA3CxGho7C2uzrroF3l4Kid4gnPuc15yBCSn2vzmm4JCu5+O/2u ZiSb3lNckxuuZBnVbxmNHWafd0XyJYMpFzH0E4HXbzY7ZbA1uvee2afMFw62T7fuqLIs xsyw== X-Gm-Message-State: AOAM531vK8nwpGmbyakcGZ9qFxW8bveRzHd3rm0qsq7OOmjV3Azah1rq u1H1kmdRwr6+QwgHeg6vioEXnm2JRiyyDA== X-Received: by 2002:a5d:6992:: with SMTP id g18mr18880546wru.362.1605529478899; Mon, 16 Nov 2020 04:24:38 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id z3sm21650510wrw.87.2020.11.16.04.24.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 04:24:27 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 6F1551FF93; Mon, 16 Nov 2020 12:24:18 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: peter.maydell@linaro.org Subject: [PULL 7/9] hw/i386/acpi-build: Fix maybe-uninitialized error when ACPI hotplug off Date: Mon, 16 Nov 2020 12:24:15 +0000 Message-Id: <20201116122417.28346-8-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201116122417.28346-1-alex.bennee@linaro.org> References: <20201116122417.28346-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::435; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x435.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , "Michael S. Tsirkin" , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Richard Henderson , qemu-devel@nongnu.org, Igor Mammedov , Paolo Bonzini , =?utf-8?q?Alex_Benn=C3=A9e?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé GCC 9.3.0 thinks that 'method' can be left uninitialized. This code is already in the "if (bsel || pcihp_bridge_en)" block statement, but it isn't smart enough to figure it out. Restrict the code to be used only in the "if (bsel || pcihp_bridge_en)" block statement to fix (on Ubuntu): ../hw/i386/acpi-build.c: In function 'build_append_pci_bus_devices': ../hw/i386/acpi-build.c:496:9: error: 'method' may be used uninitialized in this function [-Werror=maybe-uninitialized] 496 | aml_append(parent_scope, method); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors Fixes: df4008c9c59 ("piix4: don't reserve hw resources when hotplug is off globally") Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Reviewed-by: Igor Mammedov Message-Id: <20201108204535.2319870-4-philmd@redhat.com> Message-Id: <20201110192316.26397-8-alex.bennee@linaro.org> -- 2.20.1 diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 4f66642d88..1f5c211245 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -465,34 +465,31 @@ static void build_append_pci_bus_devices(Aml *parent_scope, PCIBus *bus, */ if (bsel || pcihp_bridge_en) { method = aml_method("PCNT", 0, AML_NOTSERIALIZED); - } - /* If bus supports hotplug select it and notify about local events */ - if (bsel) { - uint64_t bsel_val = qnum_get_uint(qobject_to(QNum, bsel)); - aml_append(method, aml_store(aml_int(bsel_val), aml_name("BNUM"))); - aml_append(method, - aml_call2("DVNT", aml_name("PCIU"), aml_int(1) /* Device Check */) - ); - aml_append(method, - aml_call2("DVNT", aml_name("PCID"), aml_int(3)/* Eject Request */) - ); - } + /* If bus supports hotplug select it and notify about local events */ + if (bsel) { + uint64_t bsel_val = qnum_get_uint(qobject_to(QNum, bsel)); - /* Notify about child bus events in any case */ - if (pcihp_bridge_en) { - QLIST_FOREACH(sec, &bus->child, sibling) { - int32_t devfn = sec->parent_dev->devfn; + aml_append(method, aml_store(aml_int(bsel_val), aml_name("BNUM"))); + aml_append(method, aml_call2("DVNT", aml_name("PCIU"), + aml_int(1))); /* Device Check */ + aml_append(method, aml_call2("DVNT", aml_name("PCID"), + aml_int(3))); /* Eject Request */ + } - if (pci_bus_is_root(sec) || pci_bus_is_express(sec)) { - continue; - } + /* Notify about child bus events in any case */ + if (pcihp_bridge_en) { + QLIST_FOREACH(sec, &bus->child, sibling) { + int32_t devfn = sec->parent_dev->devfn; + + if (pci_bus_is_root(sec) || pci_bus_is_express(sec)) { + continue; + } - aml_append(method, aml_name("^S%.02X.PCNT", devfn)); + aml_append(method, aml_name("^S%.02X.PCNT", devfn)); + } } - } - if (bsel || pcihp_bridge_en) { aml_append(parent_scope, method); } qobject_unref(bsel); From patchwork Mon Nov 16 12:24:16 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 324381 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:5ce:0:0:0:0 with SMTP id l14csp3275325ils; Mon, 16 Nov 2020 04:28:43 -0800 (PST) X-Google-Smtp-Source: ABdhPJyQCZehCEm0NVzadTrOoNPUGYPzLMnA3v7xSejZRAHnU5jj+VyQrJd25sQPF8h0HnowQ8hM X-Received: by 2002:a25:b281:: with SMTP id k1mr19538380ybj.303.1605529723451; Mon, 16 Nov 2020 04:28:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605529723; cv=none; d=google.com; s=arc-20160816; b=0m3VVkpgNCRzX8EZEAJiW9APdha8tYXmM0MS6UPp2KkO0GJ/aNcXKExecehHuJtS4X tHnpS1ax6ewujGrGJMOF1Bntt2OYtSAg29R34bs+gfm45KrsjovCfZVcB76PnNglmjBi ecJQlJTcrxkk0pwAOP32j7+nWjTw91wKzFI7+pw9vIaXq6VckiSeRsgAzzrlUZwApgHV WeEEF7Wen8taV2lL2bKerKck06Pb2Maob+/nbbld8JHYxHx1+PKcDqYaE5pU5j0x8GoY 2XW1TDMnMtbhNAzbJAYMTYM/W/h4cPhN4+IyOJWtOIP+9lFcMWAaN5RmH7h2loDQy6yC nlUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=28K6JTDfvyt129r+I2Y/ffL4NilW+jIaq7T324O7hUA=; b=YA2kNCKFbDK8Zh9CzIqyRMrjgZ2aKGTr+TzqQ2cghzel1Ce5uG725lh7PGUQnsrWSs i8gBzzJHQnbKnsJ1NZtiU3fZDYkovZZw0wjWQmqgr9SD6ni67PQ10AfegWuw+jTWEjqH 27oPJL/HceIhfOk37NQCNa9h4+ZtyVjlZjod1E6PgHzN63S43f1nEczoiqhbD81FvzBg 9c98qbnbo1Sen46d8t8ryz2QCquPQDdoSdbStrNDu2DjREdhkQUwLpgvZHZJM/FBoHI8 NkCTxUpnYEZxyyDAIeqtttshhMurDl1q1dU41vDEilqVEngdh/5UuSGqyeCSUjb5s1vK E1Wg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b="y/ltc9Xc"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id t97si17574779ybi.461.2020.11.16.04.28.43 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 16 Nov 2020 04:28:43 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b="y/ltc9Xc"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:36746 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kedcg-00072e-UF for patch@linaro.org; Mon, 16 Nov 2020 07:28:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58042) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kedYn-0001sP-1W for qemu-devel@nongnu.org; Mon, 16 Nov 2020 07:24:41 -0500 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]:33653) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kedYk-0003BF-QT for qemu-devel@nongnu.org; Mon, 16 Nov 2020 07:24:40 -0500 Received: by mail-wr1-x429.google.com with SMTP id u12so11265673wrt.0 for ; Mon, 16 Nov 2020 04:24:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=28K6JTDfvyt129r+I2Y/ffL4NilW+jIaq7T324O7hUA=; b=y/ltc9XcSx/9PJfDpz32Bs0tIHeZjqxWILWrGLIQR85yd04f1X1OW5el0sGwiIVJQn 418IUL703JAEAyXMymmwQZiJtlpuM2iqESVfKQcOk8Vi/UdQKYzxehq7pL3Oil1eBe8U uzhQbaG9GYLFDDC0hQEn5ql2I/EuWwNB7yWsy0UmVO2XJTNiHH3RdplwJxyLN8ttBsgO Klxsq29/c8PSUYC1LD1trSfGWbu8EadGMXpjoUi6Xy1A/9yhryBimKgEjiVvfv6OGrzX mAsNKe6sN2LPAo5SwPYDCMOXORF1j3zplrbLXyr0RoNhsGQuAM5rbCmRevLrhvQ6wyQk Go3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=28K6JTDfvyt129r+I2Y/ffL4NilW+jIaq7T324O7hUA=; b=VVhYjjGp0ihLyW8c2h1jD3DdOsu5Pe+L9TfUxowKUyVkUL5msujp7d9zN0nKlwKqoW SFl7JRqT7QmFr/Fu9wfApeAI9yw1D1mudvG7VJYA1rge+42BedyL337vfOifgZfFF2Ah Vmfyv91TFtFuKRwg/sui+6RsRnD2UjQUGeObUvBLw/u4zW9PwL8qSFTbJLfvZETA0F21 TJ0UIG6IdpTwcA+j4ktGG09KxZC3sXNXpk7ioJtLSU+P0WFv69yFXHjRzV4TjgJ6MWRr wggussVmmL5GezjIMYIqY9nav4KygrzaqbSDjSCPKxEC1O6jigZ8xbfEPDkaRtXOhUe4 kSLA== X-Gm-Message-State: AOAM532eGQkICuGtcQ7VE+LkZmrZSgTzm7K3WS54zPTP2MqxWoPh11XI kB6XgfBflChXPP81uwvVhHPQaA== X-Received: by 2002:a5d:488f:: with SMTP id g15mr18952642wrq.151.1605529477384; Mon, 16 Nov 2020 04:24:37 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id d134sm19429705wmd.8.2020.11.16.04.24.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 04:24:27 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 8634E1FF96; Mon, 16 Nov 2020 12:24:18 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: peter.maydell@linaro.org Subject: [PULL 8/9] tests/acceptance: Disable Spartan-3A DSP 1800A test Date: Mon, 16 Nov 2020 12:24:16 +0000 Message-Id: <20201116122417.28346-9-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201116122417.28346-1-alex.bennee@linaro.org> References: <20201116122417.28346-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x429.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , =?utf-8?q?Alex_Benn=C3=A9e?= , qemu-devel@nongnu.org, Wainer dos Santos Moschetta , =?utf-8?q?Philippe?= =?utf-8?q?_Mathieu-Daud=C3=A9?= , Pavel Dovgalyuk , Cleber Rosa , Paolo Bonzini , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?b?w6k=?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé This test is regularly failing on CI: (05/34) tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_microblaze_s3adsp1800: Linux version 4.11.3 (thuth@thuth.remote.csb) (gcc version 6.4.0 (Buildroot 2018.05.2) ) #5 Tue Dec 11 11:56:23 CET 2018 ... Freeing unused kernel memory: 1444K This architecture does not have kernel memory protection. [nothing happens here] Runner error occurred: Timeout reached (90.91 s) This is a regression. Until someone figure out the problem, disable the test to keep CI pipeline useful. Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Acked-by: Thomas Huth Message-Id: <20201109091719.2449141-1-f4bug@amsat.org> Message-Id: <20201110192316.26397-9-alex.bennee@linaro.org> -- 2.20.1 diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/boot_linux_console.py index 8f433a67f8..cc6ec0f8c1 100644 --- a/tests/acceptance/boot_linux_console.py +++ b/tests/acceptance/boot_linux_console.py @@ -13,6 +13,7 @@ import lzma import gzip import shutil +from avocado import skip from avocado import skipUnless from avocado_qemu import Test from avocado_qemu import exec_command_and_wait_for_pattern @@ -1025,6 +1026,7 @@ class BootLinuxConsole(LinuxKernelTest): tar_hash = 'ac688fd00561a2b6ce1359f9ff6aa2b98c9a570c' self.do_test_advcal_2018('07', tar_hash, 'sanity-clause.elf') + @skip("Test currently broken") # Console stuck as of 5.2-rc1 def test_microblaze_s3adsp1800(self): """ :avocado: tags=arch:microblaze diff --git a/tests/acceptance/replay_kernel.py b/tests/acceptance/replay_kernel.py index 00c228382b..772633b01d 100644 --- a/tests/acceptance/replay_kernel.py +++ b/tests/acceptance/replay_kernel.py @@ -14,6 +14,7 @@ import shutil import logging import time +from avocado import skip from avocado import skipIf from avocado import skipUnless from avocado_qemu import wait_for_console_pattern @@ -280,6 +281,7 @@ class ReplayKernelNormal(ReplayKernelBase): file_path = self.fetch_asset(tar_url, asset_hash=tar_hash) self.do_test_advcal_2018(file_path, 'sanity-clause.elf') + @skip("Test currently broken") # Console stuck as of 5.2-rc1 def test_microblaze_s3adsp1800(self): """ :avocado: tags=arch:microblaze From patchwork Mon Nov 16 12:24:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 324383 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:5ce:0:0:0:0 with SMTP id l14csp3277342ils; Mon, 16 Nov 2020 04:31:42 -0800 (PST) X-Google-Smtp-Source: ABdhPJyeTv9odS99xuJyBJUgsjSgxaXwIGywebbYX3nSsz8YDXTsD+bDWxREHMbmqwQRWVw3NBTD X-Received: by 2002:a25:d804:: with SMTP id p4mr20516024ybg.7.1605529902536; Mon, 16 Nov 2020 04:31:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605529902; cv=none; d=google.com; s=arc-20160816; b=UAk0v4Rj4Gt2D/IWzB2Axl6Ccx2yWm7lqEIyQYq4PUQ2smS5GPiyndGuxjJ8wyVlvh OUGOPWYmC9bdb2TTFgHTXIAv8aP4j910Hk8JyeU4qudizqjV8Hicn9xvV3ldwCPYzvgP sBAVcXB4Jv50/oO4sKddEJc5umUI2QLqXBPupusnmrYYAQLXz5zGXuXz50ojbEwNV4Ii 9DvyvZc6UIbG8s7RnIVAQ5a+WYivcREv1KeNs19W2+FTA+cmf5dae456U2U7WQ7ZhGdT qEXRUucZbEa30WbqKTotnGkNApxMTjibIf2a+pGCzZf/Mc8idMRO/XULJFM3299nHmPB OK9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=B18e+BpFDaCqmpOB60TiGLIYa4fVaamK8mnIgG8BoPM=; b=pEWiBQfGbQScPw+LHco9Umz95cl+fVIOxX/gXaV4swM+5h+yo+96D5lQ7Op8i2jBJz 5fs7TX9mmzUh9vzQUbFXAQcoUajANZzyskOFargLL75WKFFEQF8YrcqnkqI6V2A3cTT5 pI4cXAktnLK4ZbcXWaeJH3dpcNdfEW9G9mRUBrcO2wVG7j89ZN0BjGvlY9MvBxR0+HPH F+n/UR4EE54b7T6EZIXgoNAiWms6ZnFoqGTLye0lOExQBtWikxUjjemlkXm8FlGafxLq hNBuoYcwr6CjJ0T8F/Bl/T5VZ6C55WK/lXCkPXrxOA3sY4ln7J40M+X1Y/Q/8PaqOO0F HlqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=UJKMFjbM; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id i204si21249944ybb.169.2020.11.16.04.31.42 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 16 Nov 2020 04:31:42 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=UJKMFjbM; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:43908 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kedfY-0001d9-Qf for patch@linaro.org; Mon, 16 Nov 2020 07:31:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58082) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kedYo-0001wD-M5 for qemu-devel@nongnu.org; Mon, 16 Nov 2020 07:24:42 -0500 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]:35292) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kedYm-0003CH-LP for qemu-devel@nongnu.org; Mon, 16 Nov 2020 07:24:42 -0500 Received: by mail-wr1-x42b.google.com with SMTP id k2so18519840wrx.2 for ; Mon, 16 Nov 2020 04:24:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=B18e+BpFDaCqmpOB60TiGLIYa4fVaamK8mnIgG8BoPM=; b=UJKMFjbMkrTGlQQ91HviaPQUqV+pml8l7ZJulRi/4OjlL1Mi4R2y98n9G3QgMiPyo4 A258JSnUuLOXR9z4LGqVGxpEZmDvzWW/1spkXJYh+hZbg2Iw1C+Ghw+g/Z3TT17DHy2v x6J2nw11VyqPx46fCnBlab1stW4LCJseNmfKB5r8dUKRurVuznU1nNDFanQEj2iXyQDh XNv5qmGhSCq30OJGW+yFy8VYZ4ThZqGzX9WNUIPH3o9Ru+OZgtDefU95Bvb1F5ZH66B6 ocGDxX5x24B+b1WPoB4VPDzbAZ2bc655AxaNTiFbHxzslqur7nrD/J/kzMOvsh7Nwlt4 R8gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=B18e+BpFDaCqmpOB60TiGLIYa4fVaamK8mnIgG8BoPM=; b=cVn/2BHLtD4YiQ1SadypS8+ty1F+HVFS4R6o53c/Dwf9kMTcCl/6Z5CKmLwzTXWveW 643LFjz/6lLdRLtSS4XnjA1n+tsx34r2vqorfRE7Lith73fFQX8IO1M7d+9EbPLdJefb Jq0+b9qCGKtmohztAf0oNPzc9e6sXo3iFySOkFYx19usZkf7d1djMVTk0i1dOdH7RhYX 0t0FYtaf40v++ooBXdX7NAEHaMWpzC/XabiPdln0104hcISBXG3PKwR3iHvfzlhJa57C Oenu7jjRv3tleCszLX/Z5d8r4+Gkul4ybdBAKMvKdQlHb9Yd3E3kaOrXl2+zkpKHo4oe fVAA== X-Gm-Message-State: AOAM531MiB6YTx95vdkm20msT25lpZFsk9guvjpkI9W2kqaKmCUGbvtJ NnHqEn+uXw2oFwXMLPCp5WcZzg== X-Received: by 2002:a5d:46c6:: with SMTP id g6mr20048789wrs.170.1605529479146; Mon, 16 Nov 2020 04:24:39 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id u7sm553018wmb.20.2020.11.16.04.24.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 04:24:34 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 9D6441FF98; Mon, 16 Nov 2020 12:24:18 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: peter.maydell@linaro.org Subject: [PULL 9/9] .gitlab-ci.d/check-patch: tweak output for CI logs Date: Mon, 16 Nov 2020 12:24:17 +0000 Message-Id: <20201116122417.28346-10-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201116122417.28346-1-alex.bennee@linaro.org> References: <20201116122417.28346-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42b; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42b.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , =?utf-8?q?Daniel_P_=2E_Berrang=C3=A9?= , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, Wainer dos Santos Moschetta , =?utf-8?q?Alex_Ben?= =?utf-8?q?n=C3=A9e?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" We don't need running commentary for the CI logs and by keeping it short we might just see the problem on the first page. While we are at it flush the previous line so order is maintained between script and sub process. Signed-off-by: Alex Bennée Reviewed-by: Daniel P. Berrangé Message-Id: <20201113174404.19608-1-alex.bennee@linaro.org> -- 2.20.1 diff --git a/.gitlab-ci.d/check-patch.py b/.gitlab-ci.d/check-patch.py index 0ff30ee077..39e2b403c9 100755 --- a/.gitlab-ci.d/check-patch.py +++ b/.gitlab-ci.d/check-patch.py @@ -45,9 +45,9 @@ if log == "": errors = False -print("\nChecking all commits since %s...\n" % ancestor) +print("\nChecking all commits since %s...\n" % ancestor, flush=True) -ret = subprocess.run(["scripts/checkpatch.pl", ancestor + "..."]) +ret = subprocess.run(["scripts/checkpatch.pl", "--terse", ancestor + "..."]) if ret.returncode != 0: print(" ❌ FAIL one or more commits failed scripts/checkpatch.pl")