From patchwork Tue Nov 17 17:14:11 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Chris Wilson X-Patchwork-Id: 328006 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7876C2D0E4 for ; Tue, 17 Nov 2020 17:14:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5847024248 for ; Tue, 17 Nov 2020 17:14:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728889AbgKQROR (ORCPT ); Tue, 17 Nov 2020 12:14:17 -0500 Received: from mail.fireflyinternet.com ([77.68.26.236]:63606 "EHLO fireflyinternet.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1728890AbgKQROR (ORCPT ); Tue, 17 Nov 2020 12:14:17 -0500 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from build.alporthouse.com (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP id 23021599-1500050 for multiple; Tue, 17 Nov 2020 17:14:09 +0000 From: Chris Wilson To: intel-gfx@lists.freedesktop.org Cc: Chris Wilson , Clinton A Taylor , Lucas De Marchi , Matt Roper , =?utf-8?q?Jos=C3=A9_Roberto_de_Souza?= , stable@vger.kernel.org Subject: [PATCH] drm/i915/phy: Quieten state loss across suspend Date: Tue, 17 Nov 2020 17:14:11 +0000 Message-Id: <20201117171411.10030-1-chris@chris-wilson.co.uk> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org When the HW is powered down, the register state and links are lost. This may be an issue in the firmware, or in the code expectations; whatever it is, it is expected behaviour now for Tigerlake; stop warning! References: https://gitlab.freedesktop.org/drm/intel/-/issues/2411 Fixes: 239bef676d8e ("drm/i915/display: Implement new combo phy initialization step") Signed-off-by: Chris Wilson Cc: Clinton A Taylor Cc: Lucas De Marchi Cc: Matt Roper Cc: José Roberto de Souza Cc: # v5.9+ --- drivers/gpu/drm/i915/display/intel_combo_phy.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_combo_phy.c b/drivers/gpu/drm/i915/display/intel_combo_phy.c index d5ad61e4083e..9a87df982af8 100644 --- a/drivers/gpu/drm/i915/display/intel_combo_phy.c +++ b/drivers/gpu/drm/i915/display/intel_combo_phy.c @@ -428,9 +428,9 @@ static void icl_combo_phys_uninit(struct drm_i915_private *dev_priv) if (phy == PHY_A && !icl_combo_phy_verify_state(dev_priv, phy)) - drm_warn(&dev_priv->drm, - "Combo PHY %c HW state changed unexpectedly\n", - phy_name(phy)); + drm_dbg_kms(&dev_priv->drm, + "Combo PHY %c HW state changed unexpectedly\n", + phy_name(phy)); if (!has_phy_misc(dev_priv, phy)) goto skip_phy_misc;