From patchwork Fri Nov 20 11:21:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Eggers X-Patchwork-Id: 329747 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFDBAC56202 for ; Fri, 20 Nov 2020 11:25:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8044D22254 for ; Fri, 20 Nov 2020 11:25:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728109AbgKTLYw (ORCPT ); Fri, 20 Nov 2020 06:24:52 -0500 Received: from mailout05.rmx.de ([94.199.90.90]:36604 "EHLO mailout05.rmx.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727677AbgKTLYv (ORCPT ); Fri, 20 Nov 2020 06:24:51 -0500 Received: from kdin02.retarus.com (kdin02.dmz1.retloc [172.19.17.49]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mailout05.rmx.de (Postfix) with ESMTPS id 4CcvMy3lB6z9sY0; Fri, 20 Nov 2020 12:24:46 +0100 (CET) Received: from mta.arri.de (unknown [217.111.95.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by kdin02.retarus.com (Postfix) with ESMTPS id 4CcvLd3kWDz2TSBc; Fri, 20 Nov 2020 12:23:37 +0100 (CET) Received: from N95HX1G2.wgnetz.xx (192.168.54.143) by mta.arri.de (192.168.100.104) with Microsoft SMTP Server (TLS) id 14.3.487.0; Fri, 20 Nov 2020 12:22:38 +0100 From: Christian Eggers To: Vladimir Oltean , Jakub Kicinski , Andrew Lunn , Rob Herring CC: Richard Cochran , Vivien Didelot , "David S . Miller" , "Kurt Kanzenbach" , Marek Vasut , Codrin Ciubotariu , Tristram Ha , Woojung Huh , Microchip Linux Driver Support , "Christian Eggers" , , , Subject: [PATCH net-next 2/4] net: dsa: microchip: support for "ethernet-ports" node Date: Fri, 20 Nov 2020 12:21:05 +0100 Message-ID: <20201120112107.16334-3-ceggers@arri.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201120112107.16334-1-ceggers@arri.de> References: <20201120112107.16334-1-ceggers@arri.de> MIME-Version: 1.0 X-Originating-IP: [192.168.54.143] X-RMX-ID: 20201120-122339-4CcvLd3kWDz2TSBc-0@kdin02 X-RMX-SOURCE: 217.111.95.66 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The dsa.yaml device tree binding allows "ethernet-ports" (preferred) and "ports". Signed-off-by: Christian Eggers Reviewed-by: Vladimir Oltean --- drivers/net/dsa/microchip/ksz_common.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/microchip/ksz_common.c index 71cd1828e25d..a135fd5a9264 100644 --- a/drivers/net/dsa/microchip/ksz_common.c +++ b/drivers/net/dsa/microchip/ksz_common.c @@ -427,7 +427,9 @@ int ksz_switch_register(struct ksz_device *dev, ret = of_get_phy_mode(dev->dev->of_node, &interface); if (ret == 0) dev->compat_interface = interface; - ports = of_get_child_by_name(dev->dev->of_node, "ports"); + ports = of_get_child_by_name(dev->dev->of_node, "ethernet-ports"); + if (!ports) + ports = of_get_child_by_name(dev->dev->of_node, "ports"); if (ports) for_each_available_child_of_node(ports, port) { if (of_property_read_u32(port, "reg", From patchwork Fri Nov 20 11:21:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Eggers X-Patchwork-Id: 329746 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A474FC63798 for ; Fri, 20 Nov 2020 11:27:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 60F4022254 for ; Fri, 20 Nov 2020 11:27:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728519AbgKTL1R (ORCPT ); Fri, 20 Nov 2020 06:27:17 -0500 Received: from mailout08.rmx.de ([94.199.90.85]:60922 "EHLO mailout08.rmx.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727857AbgKTL1R (ORCPT ); Fri, 20 Nov 2020 06:27:17 -0500 Received: from kdin02.retarus.com (kdin02.dmz1.retloc [172.19.17.49]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mailout08.rmx.de (Postfix) with ESMTPS id 4CcvQm1kBNzMr0y; Fri, 20 Nov 2020 12:27:12 +0100 (CET) Received: from mta.arri.de (unknown [217.111.95.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by kdin02.retarus.com (Postfix) with ESMTPS id 4CcvPK2ctTz2TS7q; Fri, 20 Nov 2020 12:25:57 +0100 (CET) Received: from N95HX1G2.wgnetz.xx (192.168.54.143) by mta.arri.de (192.168.100.104) with Microsoft SMTP Server (TLS) id 14.3.487.0; Fri, 20 Nov 2020 12:23:48 +0100 From: Christian Eggers To: Vladimir Oltean , Jakub Kicinski , Andrew Lunn , Rob Herring CC: Richard Cochran , Vivien Didelot , "David S . Miller" , "Kurt Kanzenbach" , Marek Vasut , Codrin Ciubotariu , Tristram Ha , Woojung Huh , Microchip Linux Driver Support , "Christian Eggers" , , , Subject: [PATCH net-next 4/4] net: dsa: microchip: ksz8795: setup SPI mode Date: Fri, 20 Nov 2020 12:21:07 +0100 Message-ID: <20201120112107.16334-5-ceggers@arri.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201120112107.16334-1-ceggers@arri.de> References: <20201120112107.16334-1-ceggers@arri.de> MIME-Version: 1.0 X-Originating-IP: [192.168.54.143] X-RMX-ID: 20201120-122603-4CcvPK2ctTz2TS7q-0@kdin02 X-RMX-SOURCE: 217.111.95.66 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This should be done in the device driver instead of the device tree. Signed-off-by: Christian Eggers --- drivers/net/dsa/microchip/ksz8795_spi.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/dsa/microchip/ksz8795_spi.c b/drivers/net/dsa/microchip/ksz8795_spi.c index 8b00f8e6c02f..f98432a3e2b5 100644 --- a/drivers/net/dsa/microchip/ksz8795_spi.c +++ b/drivers/net/dsa/microchip/ksz8795_spi.c @@ -49,6 +49,12 @@ static int ksz8795_spi_probe(struct spi_device *spi) if (spi->dev.platform_data) dev->pdata = spi->dev.platform_data; + /* setup spi */ + spi->mode = SPI_MODE_3; + ret = spi_setup(spi); + if (ret) + return ret; + ret = ksz8795_switch_register(dev); /* Main DSA driver may not be started yet. */