From patchwork Thu Dec 3 12:47:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Enrico Weigelt, metux IT consult" X-Patchwork-Id: 337543 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE27AC83018 for ; Thu, 3 Dec 2020 12:52:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8747A22206 for ; Thu, 3 Dec 2020 12:52:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730578AbgLCMve (ORCPT ); Thu, 3 Dec 2020 07:51:34 -0500 Received: from mout.kundenserver.de ([212.227.126.131]:44283 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730502AbgLCMut (ORCPT ); Thu, 3 Dec 2020 07:50:49 -0500 Received: from orion.localdomain ([95.118.71.13]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1N2jO8-1k1WXp1v8W-0135VV; Thu, 03 Dec 2020 13:48:05 +0100 From: "Enrico Weigelt, metux IT consult" To: linux-kernel@vger.kernel.org Cc: rspringer@google.com, toddpoynor@google.com, benchan@chromium.org, rcy@google.com, laurent.pinchart@ideasonboard.com, mchehab@kernel.org, f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, nsaenzjulienne@suse.de, speakup@linux-speakup.org, devel@driverdev.osuosl.org, linux-media@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 01/11] drivers: staging: speakup: remove unneeded MODULE_VERSION() call Date: Thu, 3 Dec 2020 13:47:53 +0100 Message-Id: <20201203124803.23390-1-info@metux.net> X-Mailer: git-send-email 2.11.0 X-Provags-ID: V03:K1:2y8lEqcYnL2cBhFNRzxmlZlDfDvW7WCjo5V1dlbOXb4jKG4jY/S cb/XYaDxgxA9QzRw281fwgHAFnH/0j5LuCB/mq02pO6YDeRPkBXxvWQQ/oWiJYeo/IWK49C 0JLh8zQo6WOt91WRQ0hLcy8eX+9GAHOXHv35ilU6VjIQ3kFLDeiHl6vjvJ0JKMlVrCaV3wn OWeqrvLscDtIia9z0W5QA== X-UI-Out-Filterresults: notjunk:1; V03:K0:8YQQZCRYH6M=:4eWnAdVI6COiV7xTKFuxgz 5Sqp7KuEo5o0qsnXsPM9Fx36tkR7kIExtV/EXzBviWdFSZfF/y3vazsyQP0pPp8M8bedP6XVd yziv+FqEbzIlKnBe80IwphhKgto91CITmXj+kcF1RYoOiV294Ip8lvHAXUusjWRTSQ43dgPRF Rvi3a8c7TWrTMM89KrdaSNX/AShcmiwe9eL/YHuYTDboTURoyFJcMFMx8f2WeQalRngCHa/+Z RjupiXkrznWEpRusR+nd8mhSZw/F+CxEgjulKP4otcESBHuXiwzP69zFkcmv3Kz0nmgWFPY94 TWs7eTGM1J3pIESuTtzVoLt6B1aAT4yXGwfKm9SYR7r1XdrcneAFQIIkRuosYPFP/IZflKKck kVz3bmHCFoS08FLYw7iDlSijY2xsXCs5OgM+ZolpcjNy87yM47NiDv/fe4Mt8 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Remove MODULE_VERSION(), as it doesn't seem to serve any practical purpose. For in-tree drivers, the kernel version matters. The drivers have received lots of changes, without the module version (or the underlying DRV_VERSION macro) ever changed, since the code landed in the kernel tree. So, it doesn't seem to have any practical meaning anymore. Signed-off-by: Enrico Weigelt --- drivers/accessibility/speakup/main.c | 1 - drivers/accessibility/speakup/speakup_acntpc.c | 1 - drivers/accessibility/speakup/speakup_acntsa.c | 1 - drivers/accessibility/speakup/speakup_apollo.c | 2 -- drivers/accessibility/speakup/speakup_audptr.c | 2 -- drivers/accessibility/speakup/speakup_bns.c | 2 -- drivers/accessibility/speakup/speakup_decext.c | 1 - drivers/accessibility/speakup/speakup_decpc.c | 1 - drivers/accessibility/speakup/speakup_dectlk.c | 1 - drivers/accessibility/speakup/speakup_dtlk.c | 2 -- drivers/accessibility/speakup/speakup_dummy.c | 2 -- drivers/accessibility/speakup/speakup_keypc.c | 1 - drivers/accessibility/speakup/speakup_ltlk.c | 2 -- drivers/accessibility/speakup/speakup_soft.c | 1 - drivers/accessibility/speakup/speakup_spkout.c | 2 -- drivers/accessibility/speakup/speakup_txprt.c | 2 -- 16 files changed, 24 deletions(-) diff --git a/drivers/accessibility/speakup/main.c b/drivers/accessibility/speakup/main.c index 48019660a096..d512f4775ae1 100644 --- a/drivers/accessibility/speakup/main.c +++ b/drivers/accessibility/speakup/main.c @@ -46,7 +46,6 @@ MODULE_AUTHOR("Kirk Reiser "); MODULE_AUTHOR("Daniel Drake "); MODULE_DESCRIPTION("Speakup console speech"); MODULE_LICENSE("GPL"); -MODULE_VERSION(SPEAKUP_VERSION); char *synth_name; module_param_named(synth, synth_name, charp, 0444); diff --git a/drivers/accessibility/speakup/speakup_acntpc.c b/drivers/accessibility/speakup/speakup_acntpc.c index c94328a5bd4a..4d9ebf8b3460 100644 --- a/drivers/accessibility/speakup/speakup_acntpc.c +++ b/drivers/accessibility/speakup/speakup_acntpc.c @@ -315,5 +315,4 @@ MODULE_AUTHOR("Kirk Reiser "); MODULE_AUTHOR("David Borowski"); MODULE_DESCRIPTION("Speakup support for Accent PC synthesizer"); MODULE_LICENSE("GPL"); -MODULE_VERSION(DRV_VERSION); diff --git a/drivers/accessibility/speakup/speakup_acntsa.c b/drivers/accessibility/speakup/speakup_acntsa.c index 3a863dc61286..1dc2fd99043f 100644 --- a/drivers/accessibility/speakup/speakup_acntsa.c +++ b/drivers/accessibility/speakup/speakup_acntsa.c @@ -140,5 +140,4 @@ MODULE_AUTHOR("Kirk Reiser "); MODULE_AUTHOR("David Borowski"); MODULE_DESCRIPTION("Speakup support for Accent SA synthesizer"); MODULE_LICENSE("GPL"); -MODULE_VERSION(DRV_VERSION); diff --git a/drivers/accessibility/speakup/speakup_apollo.c b/drivers/accessibility/speakup/speakup_apollo.c index 0877b4044c28..ce215fb3f7ff 100644 --- a/drivers/accessibility/speakup/speakup_apollo.c +++ b/drivers/accessibility/speakup/speakup_apollo.c @@ -204,5 +204,3 @@ MODULE_AUTHOR("Kirk Reiser "); MODULE_AUTHOR("David Borowski"); MODULE_DESCRIPTION("Speakup support for Apollo II synthesizer"); MODULE_LICENSE("GPL"); -MODULE_VERSION(DRV_VERSION); - diff --git a/drivers/accessibility/speakup/speakup_audptr.c b/drivers/accessibility/speakup/speakup_audptr.c index e6a6a9665d8f..e4733215b5a9 100644 --- a/drivers/accessibility/speakup/speakup_audptr.c +++ b/drivers/accessibility/speakup/speakup_audptr.c @@ -167,5 +167,3 @@ MODULE_AUTHOR("Kirk Reiser "); MODULE_AUTHOR("David Borowski"); MODULE_DESCRIPTION("Speakup support for Audapter synthesizer"); MODULE_LICENSE("GPL"); -MODULE_VERSION(DRV_VERSION); - diff --git a/drivers/accessibility/speakup/speakup_bns.c b/drivers/accessibility/speakup/speakup_bns.c index 76dfa3f7c058..6783b007c020 100644 --- a/drivers/accessibility/speakup/speakup_bns.c +++ b/drivers/accessibility/speakup/speakup_bns.c @@ -124,5 +124,3 @@ MODULE_AUTHOR("Kirk Reiser "); MODULE_AUTHOR("David Borowski"); MODULE_DESCRIPTION("Speakup support for Braille 'n Speak synthesizers"); MODULE_LICENSE("GPL"); -MODULE_VERSION(DRV_VERSION); - diff --git a/drivers/accessibility/speakup/speakup_decext.c b/drivers/accessibility/speakup/speakup_decext.c index 7408eb29cf38..efe7ccbfbf05 100644 --- a/drivers/accessibility/speakup/speakup_decext.c +++ b/drivers/accessibility/speakup/speakup_decext.c @@ -236,5 +236,4 @@ MODULE_AUTHOR("Kirk Reiser "); MODULE_AUTHOR("David Borowski"); MODULE_DESCRIPTION("Speakup support for DECtalk External synthesizers"); MODULE_LICENSE("GPL"); -MODULE_VERSION(DRV_VERSION); diff --git a/drivers/accessibility/speakup/speakup_decpc.c b/drivers/accessibility/speakup/speakup_decpc.c index 96f24c848cc5..60da9ec9949c 100644 --- a/drivers/accessibility/speakup/speakup_decpc.c +++ b/drivers/accessibility/speakup/speakup_decpc.c @@ -492,4 +492,3 @@ MODULE_AUTHOR("Kirk Reiser "); MODULE_AUTHOR("David Borowski"); MODULE_DESCRIPTION("Speakup support for DECtalk PC synthesizers"); MODULE_LICENSE("GPL"); -MODULE_VERSION(DRV_VERSION); diff --git a/drivers/accessibility/speakup/speakup_dectlk.c b/drivers/accessibility/speakup/speakup_dectlk.c index 780214b5ca16..dc5e91c7a2c9 100644 --- a/drivers/accessibility/speakup/speakup_dectlk.c +++ b/drivers/accessibility/speakup/speakup_dectlk.c @@ -307,5 +307,4 @@ MODULE_AUTHOR("Kirk Reiser "); MODULE_AUTHOR("David Borowski"); MODULE_DESCRIPTION("Speakup support for DECtalk Express synthesizers"); MODULE_LICENSE("GPL"); -MODULE_VERSION(DRV_VERSION); diff --git a/drivers/accessibility/speakup/speakup_dtlk.c b/drivers/accessibility/speakup/speakup_dtlk.c index dbebed0eeeec..265ab003627e 100644 --- a/drivers/accessibility/speakup/speakup_dtlk.c +++ b/drivers/accessibility/speakup/speakup_dtlk.c @@ -386,5 +386,3 @@ MODULE_AUTHOR("Kirk Reiser "); MODULE_AUTHOR("David Borowski"); MODULE_DESCRIPTION("Speakup support for DoubleTalk PC synthesizers"); MODULE_LICENSE("GPL"); -MODULE_VERSION(DRV_VERSION); - diff --git a/drivers/accessibility/speakup/speakup_dummy.c b/drivers/accessibility/speakup/speakup_dummy.c index e393438af81b..f3b38dc04499 100644 --- a/drivers/accessibility/speakup/speakup_dummy.c +++ b/drivers/accessibility/speakup/speakup_dummy.c @@ -130,5 +130,3 @@ module_spk_synth(synth_dummy); MODULE_AUTHOR("Samuel Thibault "); MODULE_DESCRIPTION("Speakup support for text console"); MODULE_LICENSE("GPL"); -MODULE_VERSION(DRV_VERSION); - diff --git a/drivers/accessibility/speakup/speakup_keypc.c b/drivers/accessibility/speakup/speakup_keypc.c index 414827e888fc..8110ddea8ef3 100644 --- a/drivers/accessibility/speakup/speakup_keypc.c +++ b/drivers/accessibility/speakup/speakup_keypc.c @@ -314,5 +314,4 @@ module_spk_synth(synth_keypc); MODULE_AUTHOR("David Borowski"); MODULE_DESCRIPTION("Speakup support for Keynote Gold PC synthesizers"); MODULE_LICENSE("GPL"); -MODULE_VERSION(DRV_VERSION); diff --git a/drivers/accessibility/speakup/speakup_ltlk.c b/drivers/accessibility/speakup/speakup_ltlk.c index 3c59519a871f..d506380d7235 100644 --- a/drivers/accessibility/speakup/speakup_ltlk.c +++ b/drivers/accessibility/speakup/speakup_ltlk.c @@ -171,5 +171,3 @@ MODULE_AUTHOR("Kirk Reiser "); MODULE_AUTHOR("David Borowski"); MODULE_DESCRIPTION("Speakup support for DoubleTalk LT/LiteTalk synthesizers"); MODULE_LICENSE("GPL"); -MODULE_VERSION(DRV_VERSION); - diff --git a/drivers/accessibility/speakup/speakup_soft.c b/drivers/accessibility/speakup/speakup_soft.c index 9a7029539f35..7c97444744ea 100644 --- a/drivers/accessibility/speakup/speakup_soft.c +++ b/drivers/accessibility/speakup/speakup_soft.c @@ -427,4 +427,3 @@ module_spk_synth(synth_soft); MODULE_AUTHOR("Kirk Reiser "); MODULE_DESCRIPTION("Speakup userspace software synthesizer support"); MODULE_LICENSE("GPL"); -MODULE_VERSION(DRV_VERSION); diff --git a/drivers/accessibility/speakup/speakup_spkout.c b/drivers/accessibility/speakup/speakup_spkout.c index 6e933bf1de2e..dbaec515d94e 100644 --- a/drivers/accessibility/speakup/speakup_spkout.c +++ b/drivers/accessibility/speakup/speakup_spkout.c @@ -135,5 +135,3 @@ MODULE_AUTHOR("Kirk Reiser "); MODULE_AUTHOR("David Borowski"); MODULE_DESCRIPTION("Speakup support for Speak Out synthesizers"); MODULE_LICENSE("GPL"); -MODULE_VERSION(DRV_VERSION); - diff --git a/drivers/accessibility/speakup/speakup_txprt.c b/drivers/accessibility/speakup/speakup_txprt.c index a7326f226a5e..687efe2f02e6 100644 --- a/drivers/accessibility/speakup/speakup_txprt.c +++ b/drivers/accessibility/speakup/speakup_txprt.c @@ -123,5 +123,3 @@ MODULE_AUTHOR("Kirk Reiser "); MODULE_AUTHOR("David Borowski"); MODULE_DESCRIPTION("Speakup support for Transport synthesizers"); MODULE_LICENSE("GPL"); -MODULE_VERSION(DRV_VERSION); - From patchwork Thu Dec 3 12:47:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Enrico Weigelt, metux IT consult" X-Patchwork-Id: 337544 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 071CFC83013 for ; Thu, 3 Dec 2020 12:52:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C114C22245 for ; Thu, 3 Dec 2020 12:52:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730539AbgLCMut (ORCPT ); Thu, 3 Dec 2020 07:50:49 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:52111 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730506AbgLCMur (ORCPT ); Thu, 3 Dec 2020 07:50:47 -0500 Received: from orion.localdomain ([95.118.71.13]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MQy0N-1kZRNh0hRX-00NvnC; Thu, 03 Dec 2020 13:48:06 +0100 From: "Enrico Weigelt, metux IT consult" To: linux-kernel@vger.kernel.org Cc: rspringer@google.com, toddpoynor@google.com, benchan@chromium.org, rcy@google.com, laurent.pinchart@ideasonboard.com, mchehab@kernel.org, f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, nsaenzjulienne@suse.de, speakup@linux-speakup.org, devel@driverdev.osuosl.org, linux-media@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 02/11] drivers: staging: gasket: remove unneeded MODULE_VERSION() call Date: Thu, 3 Dec 2020 13:47:54 +0100 Message-Id: <20201203124803.23390-2-info@metux.net> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20201203124803.23390-1-info@metux.net> References: <20201203124803.23390-1-info@metux.net> X-Provags-ID: V03:K1:5cNNaj3L1/oSaoHWBOWl0bfD/3mFxrG/x2hhKeTIwCx0/LVUkqJ 9NVSdVPi4tZ8L7wKa7HtR7+OYYkwTIuZXgExz+2yWHIHjzhMXdwkO221R8mu8e3PmZ3gxGh KVPomrKpJKUobLqzoQICc41cHBibPpHdW0AblAT4iJkB/TZQGkencXQEj2T/2HetV82Yyph PD7FG5NSALtrKTRLxAo+A== X-UI-Out-Filterresults: notjunk:1; V03:K0:ch9o7BlYNY0=:PCQG1wY9TcGzs26MLv2lEQ JI/cf0W1LfysAd/VFg13X3YS5gKmsaf3j9MEDQEMb5cNyUKy4CQqjdekZG0SxCW2dE62/VfPl xTtXC5ypyvj/C1VNLHFuavsgs4xmO3lRF26k8gKGTS7ZSfW55AjQ7ntjoFWjrL2sU3W9C6Twj p3t2OVVPRHH0oqA5WWFfBeN77/Pk45kF5WCzNclG0FJgCz/S63wcjXL6GEUgga+or2MtkPUAY O9PygrJ8tBk+sDOpX6KMNbKyRm0tTc7fgdawzvC75cNjo+FsAmuj4uLwZ6QpQQuRwzXRniWaZ 2PnovUxiYTTcJuUu8cbmygnPsYvZmIcvCozRwU3nieAYD1UWyw16aZjcTwOxlaKrlIwZD521m OuxFxIWDTyckIpwES9kNKA3PhBhQ5QJHmLqZrgYwc2BIP/Y+i3wV8/W+qIVEk Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Remove MODULE_VERSION(), as it doesn't seem to serve any practical purpose. For in-tree drivers, the kernel version matters. The code has received lots of changes, w/o the versions being actively maintained, so it doesn't seem to have much practical meaning. Signed-off-by: Enrico Weigelt --- drivers/staging/gasket/apex_driver.c | 1 - drivers/staging/gasket/gasket_core.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging/gasket/apex_driver.c b/drivers/staging/gasket/apex_driver.c index f12f81c8dd2f..66ae99bebfd8 100644 --- a/drivers/staging/gasket/apex_driver.c +++ b/drivers/staging/gasket/apex_driver.c @@ -718,7 +718,6 @@ static void apex_exit(void) gasket_unregister_device(&apex_desc); } MODULE_DESCRIPTION("Google Apex driver"); -MODULE_VERSION(APEX_DRIVER_VERSION); MODULE_LICENSE("GPL v2"); MODULE_AUTHOR("John Joseph "); MODULE_DEVICE_TABLE(pci, apex_pci_ids); diff --git a/drivers/staging/gasket/gasket_core.c b/drivers/staging/gasket/gasket_core.c index 28dab302183b..763d5ea45e68 100644 --- a/drivers/staging/gasket/gasket_core.c +++ b/drivers/staging/gasket/gasket_core.c @@ -1809,7 +1809,6 @@ static int __init gasket_init(void) } MODULE_DESCRIPTION("Google Gasket driver framework"); -MODULE_VERSION(GASKET_FRAMEWORK_VERSION); MODULE_LICENSE("GPL v2"); MODULE_AUTHOR("Rob Springer "); module_init(gasket_init); From patchwork Thu Dec 3 12:47:55 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Enrico Weigelt, metux IT consult" X-Patchwork-Id: 337542 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 733E0C8301E for ; Thu, 3 Dec 2020 12:52:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1F05921D91 for ; Thu, 3 Dec 2020 12:52:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730617AbgLCMvs (ORCPT ); Thu, 3 Dec 2020 07:51:48 -0500 Received: from mout.kundenserver.de ([212.227.126.131]:32951 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730503AbgLCMur (ORCPT ); Thu, 3 Dec 2020 07:50:47 -0500 Received: from orion.localdomain ([95.118.71.13]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1Mrfgi-1kPmZ03hwK-00nkW5; Thu, 03 Dec 2020 13:48:07 +0100 From: "Enrico Weigelt, metux IT consult" To: linux-kernel@vger.kernel.org Cc: rspringer@google.com, toddpoynor@google.com, benchan@chromium.org, rcy@google.com, laurent.pinchart@ideasonboard.com, mchehab@kernel.org, f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, nsaenzjulienne@suse.de, speakup@linux-speakup.org, devel@driverdev.osuosl.org, linux-media@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 03/11] drivers: staging: gdm724x: remove unneeded MODULE_VERSION() call Date: Thu, 3 Dec 2020 13:47:55 +0100 Message-Id: <20201203124803.23390-3-info@metux.net> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20201203124803.23390-1-info@metux.net> References: <20201203124803.23390-1-info@metux.net> X-Provags-ID: V03:K1:y/GRYT+te7Xvb7tqixaHWNKlrsFAQsktrzB4LZEe1ypwz1DoS68 HNy5FLm7U6iklFSixKOCHtXY2kF48DiVaeuPrLGmy0DXsQZyGMBuHVtCM4C5T04ORFcmFb9 1QNyTCBTBB861jFXXj1JCfg22dQDfhM52ieKjGpOtFqygA1jxZCid554JQBNmBAL1CCYJAD Xllzu1X8tGbIRTfaM6k7w== X-UI-Out-Filterresults: notjunk:1; V03:K0:f24F5x+x0sk=:/niJrw9CbZxm8SsYM0Uqyt 54SI3myUUg/yESet1Neh6kEryUvzRVV3D0etBZG1U06WU041rOie57lSUYeSpCaCPH4n56OD8 s9Lklkmj/Ci16AIN+3FKW8HBz1z41XUzntXRkm4uT6ZHah3Yq31iG8aXQLCQmmfVaRIwxZom9 B4kCaZVaCKyWrxvVoVM814L+H+SJjk+qy7fStVwXdn1AlegP5MuSjQhNw7KJy7Z+a/nJoDVQL XHya0MD8jPFKQrJsem41b3YKrCluMZqOU9ZeXI7mIg8TDcQidGv/7ur3I/buC/U5nlZEGcX1z Watp+frjGAYm8TtIboTE9++3BRc/Rlbi77wRIro32Fwg9VjGRd9q3pS2srkwZLZKWOF9LjCQr bq3XFUNXcAOhVeYgObI7ew9jNXoEuYKcCVgbB85Zm+CLTJk+Ph9L3wBKvp68P Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Remove MODULE_VERSION(), as it doesn't seem to serve any practical purpose. For in-kernel drivers, the kernel version matters. And the code has received lots of changes, without the version ever been touched (remained constant since landing in the mainline tree), so it doesn't seem to have any practical meaning anymore. Signed-off-by: Enrico Weigelt --- drivers/staging/gdm724x/gdm_lte.h | 1 - drivers/staging/gdm724x/gdm_usb.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging/gdm724x/gdm_lte.h b/drivers/staging/gdm724x/gdm_lte.h index f2143a6e0e99..bf6478ab05dd 100644 --- a/drivers/staging/gdm724x/gdm_lte.h +++ b/drivers/staging/gdm724x/gdm_lte.h @@ -11,7 +11,6 @@ #define MAX_NIC_TYPE 4 #define MAX_RX_SUBMIT_COUNT 3 -#define DRIVER_VERSION "3.7.17.0" enum TX_ERROR_CODE { TX_NO_ERROR = 0, diff --git a/drivers/staging/gdm724x/gdm_usb.c b/drivers/staging/gdm724x/gdm_usb.c index dc4da66c3695..aa6f08396396 100644 --- a/drivers/staging/gdm724x/gdm_usb.c +++ b/drivers/staging/gdm724x/gdm_usb.c @@ -1003,6 +1003,5 @@ static void __exit gdm_usb_lte_exit(void) module_init(gdm_usb_lte_init); module_exit(gdm_usb_lte_exit); -MODULE_VERSION(DRIVER_VERSION); MODULE_DESCRIPTION("GCT LTE USB Device Driver"); MODULE_LICENSE("GPL"); From patchwork Thu Dec 3 12:47:56 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Enrico Weigelt, metux IT consult" X-Patchwork-Id: 337546 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED09BC8301F for ; Thu, 3 Dec 2020 12:51:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6CE9721D91 for ; Thu, 3 Dec 2020 12:51:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389079AbgLCMuz (ORCPT ); Thu, 3 Dec 2020 07:50:55 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:39307 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389048AbgLCMuw (ORCPT ); Thu, 3 Dec 2020 07:50:52 -0500 Received: from orion.localdomain ([95.118.71.13]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MEUaQ-1kwMUn2U7W-00G3at; Thu, 03 Dec 2020 13:48:07 +0100 From: "Enrico Weigelt, metux IT consult" To: linux-kernel@vger.kernel.org Cc: rspringer@google.com, toddpoynor@google.com, benchan@chromium.org, rcy@google.com, laurent.pinchart@ideasonboard.com, mchehab@kernel.org, f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, nsaenzjulienne@suse.de, speakup@linux-speakup.org, devel@driverdev.osuosl.org, linux-media@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 04/11] drivers: staging: goldfish: remove unneeded MODULE_VERSION() call Date: Thu, 3 Dec 2020 13:47:56 +0100 Message-Id: <20201203124803.23390-4-info@metux.net> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20201203124803.23390-1-info@metux.net> References: <20201203124803.23390-1-info@metux.net> X-Provags-ID: V03:K1:4VMUivbUOMUD8OthMTSocKelq1MbRgHbaY3f/G6xITxz6Xk22M8 uEHUC/m7pcHhQN7/1teMHnGJ105bj2MFxIG8OKD8iMvw0OijeR18OxT+t8B0FkJvqbNflL2 kBIVNRlu9uGg7FSNGDM3EvhgOQpvUQ/ujKwC7A+tlDShQON10tV25yv0S6bLDTnEhdvdql7 Mi+EHZ1SnUSeR+e459RGA== X-UI-Out-Filterresults: notjunk:1; V03:K0:/ZThhDNRtBg=:nhBRCngE4HdS48BlApC8N0 ONTzsyy9ujSC4Xeo4w9hxz3+VWhpmVANsgQOAJXhGAbxAOONikbDE3xX3mM/8A1v7qv0GoM6u qhcDtZyGVu9+gbScyuV0g7+9cqiYQhwEG5DTqQNb59qfKoSvttrPrX8Uffz5UwTNqtScGHHBF IXtFSlwWy87137LwHju9B1fgIG+U87TnNu+8di0HDUUpRD8RgwUjOEOkAAYdQBmE6EDq4C7iY ZYdyZ1IHuiCls74t1twRXYX8JX674vhxqqi1e1MaWLfxL5xqY18X7eH4TFkn75hWw3zPyLuig vy7NQcwZDhyQCYwcRQoUUDmfmZIps7uRuz330L3JPoqP8CpqLeZKXdZgPkpWAuygzScxOZUmi 9Gr9AGejryjR2VV6Qgia9N7SnlGfrYRyoQYAjJXxomK2+nxFUhlJ3QSHkbP7k Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Remove MODULE_VERSION(), as it doesn't seem to have much practical purpose. For in-kernel drivers, the kernel version matters. The driver received lots of changes, but version number has remained the same since it's introducing into mainline, seven years ago. So, it doesn't seem to have much practical meaning anymore. Signed-off-by: Enrico Weigelt --- drivers/staging/goldfish/goldfish_audio.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/goldfish/goldfish_audio.c b/drivers/staging/goldfish/goldfish_audio.c index 0c65a0121dde..4a23f40e549a 100644 --- a/drivers/staging/goldfish/goldfish_audio.c +++ b/drivers/staging/goldfish/goldfish_audio.c @@ -24,7 +24,6 @@ MODULE_AUTHOR("Google, Inc."); MODULE_DESCRIPTION("Android QEMU Audio Driver"); MODULE_LICENSE("GPL"); -MODULE_VERSION("1.0"); struct goldfish_audio { char __iomem *reg_base; From patchwork Thu Dec 3 12:48:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Enrico Weigelt, metux IT consult" X-Patchwork-Id: 337545 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D437DC83024 for ; Thu, 3 Dec 2020 12:51:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 970F020709 for ; Thu, 3 Dec 2020 12:51:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730567AbgLCMvQ (ORCPT ); Thu, 3 Dec 2020 07:51:16 -0500 Received: from mout.kundenserver.de ([212.227.126.135]:58389 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389062AbgLCMuz (ORCPT ); Thu, 3 Dec 2020 07:50:55 -0500 Received: from orion.localdomain ([95.118.71.13]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MC0HF-1ksnqw3rED-00CUou; Thu, 03 Dec 2020 13:48:12 +0100 From: "Enrico Weigelt, metux IT consult" To: linux-kernel@vger.kernel.org Cc: rspringer@google.com, toddpoynor@google.com, benchan@chromium.org, rcy@google.com, laurent.pinchart@ideasonboard.com, mchehab@kernel.org, f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, nsaenzjulienne@suse.de, speakup@linux-speakup.org, devel@driverdev.osuosl.org, linux-media@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 10/11] drivers: staging: rtl8723bs: remove unneeded MODULE_VERSION() call Date: Thu, 3 Dec 2020 13:48:02 +0100 Message-Id: <20201203124803.23390-10-info@metux.net> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20201203124803.23390-1-info@metux.net> References: <20201203124803.23390-1-info@metux.net> X-Provags-ID: V03:K1:hQGIBq/BUgPqVCEvTnHhF20SdK3ePaui9xmOcpQzW4CBNAeGWxQ 6dlSkT/baOy2QIyYpoUTMDbZ2qRYy4QjbRiOimlX7nHiu4rtmkCbU1n8XpdkUUpsT0mbrRL WBjJEIOolFjHbZbrlYh0Zk0i6Fx0S5oT7x3/eVUw+uDgdZQatf8trTDNYxSRVqcNyslMLb2 XU8R0s82TL/NGrQRwrvFQ== X-UI-Out-Filterresults: notjunk:1; V03:K0:6RGQO+J5kMs=:v3LsgrUhYwB/y2iFa9vQb0 e9xMagAtqCzJZABxOcvKblZxcYBWxuUc24caTFsDorn7uMCod/SwqUO2GGuwV6TBgQkXbPO02 D/JHB4OqicEPtdfEuyFV61vR/qSYC0VXf1xbLCMI5NgG/0uNcRw0Q2Xt8r0bI/Ddsh4dFnMF/ urhCr2E9ERtkx29wO/7oRLcYIwvMJEuVAUoxZx1MnuXMGKnNmtX+jmn1olRVtuUNZ+B5dyblv fxVK8Run2oS5tkGetn/m/47SbXm4O55qofzlt88pIZ2jGmWEXM7GtghDJiyNnu6QkA8Vy5x3z g7FysiqrU9ZGLIEchhQubxA+p5Tgga9IvKv13o91HqKJn4vMEfWO1UIo7Q9497g5dmL45LILn BiOwG/cgPZos9Iz+uH3ci9MhBU1afUIuEH2Ov1SoqH098lBEXHRVhK4Zw2NcR Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Remove MODULE_VERSION(), as it doesn't seem to have any pratical purpose. The code received lots of huge changes, but module version remained constant, since it landed in mainline tree, back 11 years go. Unmaintained version numbers aren't actually useful. For in-tree drivers, the kernel version really matters. Signed-off-by: Enrico Weigelt --- drivers/staging/rtl8192u/r8192U_core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c index 27dc181c4c9b..da871f45042a 100644 --- a/drivers/staging/rtl8192u/r8192U_core.c +++ b/drivers/staging/rtl8192u/r8192U_core.c @@ -90,7 +90,6 @@ static const struct usb_device_id rtl8192_usb_id_tbl[] = { }; MODULE_LICENSE("GPL"); -MODULE_VERSION("V 1.1"); MODULE_DEVICE_TABLE(usb, rtl8192_usb_id_tbl); MODULE_DESCRIPTION("Linux driver for Realtek RTL8192 USB WiFi cards"); From patchwork Thu Dec 3 12:48:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Enrico Weigelt, metux IT consult" X-Patchwork-Id: 337547 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2217CC83016 for ; Thu, 3 Dec 2020 12:51:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D58D121D91 for ; Thu, 3 Dec 2020 12:51:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389032AbgLCMuv (ORCPT ); Thu, 3 Dec 2020 07:50:51 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:37063 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730527AbgLCMut (ORCPT ); Thu, 3 Dec 2020 07:50:49 -0500 Received: from orion.localdomain ([95.118.71.13]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MsaeR-1jsPzT2mwF-00tyos; Thu, 03 Dec 2020 13:48:12 +0100 From: "Enrico Weigelt, metux IT consult" To: linux-kernel@vger.kernel.org Cc: rspringer@google.com, toddpoynor@google.com, benchan@chromium.org, rcy@google.com, laurent.pinchart@ideasonboard.com, mchehab@kernel.org, f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, nsaenzjulienne@suse.de, speakup@linux-speakup.org, devel@driverdev.osuosl.org, linux-media@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 11/11] drivers: staging: rtl8723bs: remove unneeded MODULE_VERSION() call Date: Thu, 3 Dec 2020 13:48:03 +0100 Message-Id: <20201203124803.23390-11-info@metux.net> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20201203124803.23390-1-info@metux.net> References: <20201203124803.23390-1-info@metux.net> X-Provags-ID: V03:K1:K37+eyIhv0Jb/MzK3jnMGWBmLWepPJuiKdD1EOq0NyyZs+7YC10 jE5E0O/ntftFAhWSpM6FBNp32u3g80+Y4PIwebTKvt5maocGGGDlttLPphBTnwemY9iA8P0 Ea4YxF/NhpPtBLgkJnp+yOkmLcdgXZZYuMsiL86C1siiIxDdT7ySmroAcuRa8yKj912uvsa qTDf9K/Ihh8mumSlgcyiQ== X-UI-Out-Filterresults: notjunk:1; V03:K0:qfkFQp5hoTE=:VCgOPZqPOsCzjVT2ig9+gx 7c88PXwrJDy9bnQNZJel1Drz5LJfxrl+YLIyLCB8nQVheLEW+gNWDMcmEQwWXw3ORRnqU5Hq9 sxLclY3Xas4uzGXxVbmNpsobNlDji0ie5fwBeZUeOUlIUWp6KHkpjwF/O96nj63n2iboEOxHB yoco/hULUQ7NYOaBzmh79eg58EFKG9ijM2U8cvlOuy2ka96guUAbtEH/PhksJB42t5yjlk2+0 h9wzj7QMUnhvOt8yeRz0YoNUZf20XdOt43sKan/UTZ3uYMadWV5Bk+zOlwHNspxKsC1jPQCxZ c1ApsrHuA4tWHmbvquJz4EVxZ6y0EOZ5XBQ/oOqqYTEbdgiJjLXeYe6Vd2YpEOG7JfmLamlFA /7v8kDK1B2CRtvUIOY3nbiuHFwtwoBjCi9yJiiu19qWJnu4UieoAmFLxiKLUg Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Remove MODULE_VERSION(), as it doesn't seem to serve any practical purpose. The driver received lots of changes, but module remained constant since it landed in mainline, several years ago. Signed-off-by: Enrico Weigelt --- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c index 27f990a01a23..0a94bab4fdcb 100644 --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c @@ -13,7 +13,6 @@ MODULE_LICENSE("GPL"); MODULE_DESCRIPTION("Realtek Wireless Lan Driver"); MODULE_AUTHOR("Realtek Semiconductor Corp."); -MODULE_VERSION(DRIVERVERSION); /* module param defaults */ static int rtw_chip_version;