From patchwork Sun Jan 28 22:29:46 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sasha Levin X-Patchwork-Id: 126084 Delivered-To: patch@linaro.org Received: by 10.46.84.92 with SMTP id y28csp1955955ljd; Sun, 28 Jan 2018 14:35:43 -0800 (PST) X-Google-Smtp-Source: AH8x226OGJdLkLUvEerzOEa4yAzxhjO5Ym5z3jOwF/u+YUghqm0GPHdjcRy9TyVKceYor+JL/gbU X-Received: by 2002:a17:902:6943:: with SMTP id k3-v6mr19700453plt.285.1517178943539; Sun, 28 Jan 2018 14:35:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517178943; cv=none; d=google.com; s=arc-20160816; b=ovEB1MwmzsnHrB0nkJOtIcz66xran6Lf9nJh7EDK/WcwVd43YmBwdHrSfhi6rUd7ZL poCP76/B4OTEOjQR46KBjlPoMflYymaiqGnfmrn/1dK9RcIdpprbToDXymDavJnyLB4Q +ogpvv9GxRaCM6iw5MvmeBu49pBVt9EVbNprRhienBbkKhMNQV+0ubGOIo0u9TpBXFkH pYpH2oYA4teB5nBU8qcVBeFt+6xVZcmwusaWmVLww6tphKDmJY6Eafs5qlNMH1BDmEPa PIDuMrcUxiOIBm7acArMpJl9OlCQe0Mcn6LY4cKTpj7/7naBuZDTjxNyAveGQXf5E8ws J5EQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=1qNvfMehfmbuX3Vhc1hdXywpl9hILk7NjDRvmTAZ93k=; b=EyXUSrW3939DxsTJZOpLkVa0YMH85nL3/RngPEVDLm1p2imyzF7yiv5IMIB3hkHw/X jbkNUz0oIyYfHlGKdfH9QaU/xvtYhlEn3wYubUyozCc6o76JQfyrwfYRcRqylL4g5+rV fovAG4E7ug6mjtJx+bGBq+y8pEWFaut0zz4+IDcxrxZ5tU3N9SdEqiLbFJKjPfJlIbBj CLkZ4w1gyO4tPOWkvZKz74ajNMT/IfKJTpZPO9WMyh8FvM0uw/l1X27sVNu4LaBRoHC/ v7NR61LHVVw5A3l9KDGsdCgulIQQvran5ie9aWY8Bg8P4CbhdHntZkaRc09Shhe1YZdO 2lrw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=iCY30nP5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 89-v6si7859829plb.612.2018.01.28.14.35.43; Sun, 28 Jan 2018 14:35:43 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=iCY30nP5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932822AbeA1Wfm (ORCPT + 24 others); Sun, 28 Jan 2018 17:35:42 -0500 Received: from mail-bl2nam02on0093.outbound.protection.outlook.com ([104.47.38.93]:45074 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753834AbeA1Waf (ORCPT ); Sun, 28 Jan 2018 17:30:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=1qNvfMehfmbuX3Vhc1hdXywpl9hILk7NjDRvmTAZ93k=; b=iCY30nP5qP4bL8LLKNTPFYTjaZWbEzl4HNBBlQrnO5V8her68k/O8ZU5muc8Hk5zfWIfCeT+Nkn0/AZLrGZhkgzOchfT+oXozYUvwBoZ2MZejMM4nMtTAAADFPfnzKKji2Sh1TV7xlrN2+SXbCdReWatd2yJ47rdbeZTggKh62Q= Received: from MW2PR2101MB1034.namprd21.prod.outlook.com (52.132.149.10) by MW2PR2101MB1098.namprd21.prod.outlook.com (52.132.149.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.485.0; Sun, 28 Jan 2018 22:30:29 +0000 Received: from MW2PR2101MB1034.namprd21.prod.outlook.com ([fe80::e153:81e1:bbc3:3c22]) by MW2PR2101MB1034.namprd21.prod.outlook.com ([fe80::e153:81e1:bbc3:3c22%2]) with mapi id 15.20.0485.000; Sun, 28 Jan 2018 22:30:29 +0000 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Will Deacon , Matthew Wilcox , Jonathan Corbet , Sasha Levin Subject: [PATCH AUTOSEL for 3.18 07/25] scripts/kernel-doc: Don't fail with status != 0 if error encountered with -none Thread-Topic: [PATCH AUTOSEL for 3.18 07/25] scripts/kernel-doc: Don't fail with status != 0 if error encountered with -none Thread-Index: AQHTmIeA24GQp/yAu0K3FW10RWGchw== Date: Sun, 28 Jan 2018 22:29:46 +0000 Message-ID: <20180128222931.7781-7-alexander.levin@microsoft.com> References: <20180128222931.7781-1-alexander.levin@microsoft.com> In-Reply-To: <20180128222931.7781-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; MW2PR2101MB1098; 7:EyIpgHMh722WdBwGgI6cQyYtwNRlKYGZF1DKokBOiHXM8QderE/x1iUdRqRvLCY1Q9mpD4lB2MvFTXfZbClijol52LK9/d9pC/bTONs1hRelB8d5wDEmrL4wTaxBpmDjeZGCFb+FXa0DtLRAD95QoqDOZDgJSu4L3E48bVktCgWb3wRKB8iN+Z+GV19MD3iWFbSHEw/Atxp75VnuieP55CPSMQCMRonnJ1KtEFDA1rUbBh+LdZ5omeenft96kCRz x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 534fdba4-19fd-4cae-c18b-08d5669ebc61 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7193020); SRVR:MW2PR2101MB1098; x-ms-traffictypediagnostic: MW2PR2101MB1098: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(180628864354917)(89211679590171); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(61425038)(6040501)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(3231101)(944501161)(6055026)(61426038)(61427038)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(20161123562045)(20161123560045)(6072148)(201708071742011); SRVR:MW2PR2101MB1098; BCL:0; PCL:0; RULEID:; SRVR:MW2PR2101MB1098; x-forefront-prvs: 05669A7924 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(366004)(346002)(376002)(396003)(39860400002)(39380400002)(189003)(199004)(54906003)(7736002)(66066001)(305945005)(316002)(72206003)(106356001)(2950100002)(6666003)(478600001)(10290500003)(6506007)(97736004)(2906002)(105586002)(59450400001)(25786009)(107886003)(5250100002)(8676002)(110136005)(14454004)(5660300001)(2501003)(22452003)(2900100001)(81156014)(68736007)(6436002)(8936002)(53936002)(10090500001)(81166006)(99286004)(102836004)(3660700001)(36756003)(3280700002)(86612001)(3846002)(6116002)(86362001)(1076002)(4326008)(26005)(76176011)(6512007)(6486002)(186003)(22906009)(217873001); DIR:OUT; SFP:1102; SCL:1; SRVR:MW2PR2101MB1098; H:MW2PR2101MB1034.namprd21.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: Nj2CsFW3HVxg4bDZvx8LAKj7ZXzywm7FIcdV4mJjAHMb/Bt252KeCXv9CXTVLWxEPLQbii+tz2nHgZ51qFAQoA== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 534fdba4-19fd-4cae-c18b-08d5669ebc61 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jan 2018 22:29:46.0784 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB1098 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Will Deacon [ Upstream commit e814bccbafece52a24e152d2395b5d49eef55841 ] My bisect scripts starting running into build failures when trying to compile 4.15-rc1 with the builds failing with things like: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:2078: error: Cannot parse struct or union! The line in question is actually just a #define, but after some digging it turns out that my scripts pass W=1 and since commit 3a025e1d1c2ea ("Add optional check for bad kernel-doc comments") that results in kernel-doc running on each source file. The file in question has a badly formatted comment immediately before the #define: /** * struct brcmf_skbuff_cb reserves first two bytes in sk_buff::cb for * bus layer usage. */ which causes the regex in dump_struct to fail (lack of braces following struct declaration) and kernel-doc returns 1, which causes the build to fail. Fix the issue by always returning 0 from kernel-doc when invoked with -none. It successfully generates no documentation, and prints out any issues. Cc: Matthew Wilcox Cc: Jonathan Corbet Signed-off-by: Will Deacon Signed-off-by: Jonathan Corbet Signed-off-by: Sasha Levin --- scripts/kernel-doc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.11.0 diff --git a/scripts/kernel-doc b/scripts/kernel-doc index 9922e66883a5..f936d9e5db91 100755 --- a/scripts/kernel-doc +++ b/scripts/kernel-doc @@ -2616,4 +2616,4 @@ if ($verbose && $warnings) { print STDERR "$warnings warnings\n"; } -exit($errors); +exit($output_mode eq "none" ? 0 : $errors);