From patchwork Sun Jan 28 22:27:46 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sasha Levin X-Patchwork-Id: 126086 Delivered-To: patch@linaro.org Received: by 10.46.84.92 with SMTP id y28csp1963087ljd; Sun, 28 Jan 2018 14:53:24 -0800 (PST) X-Google-Smtp-Source: AH8x226uKH+JSOWA6Zxz03j869w2ZbyklV90hMcvJR0YsZ49nHVPipOyRjV/SUKdkwiRRPmODk8W X-Received: by 10.99.154.73 with SMTP id e9mr18088023pgo.26.1517180004784; Sun, 28 Jan 2018 14:53:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517180004; cv=none; d=google.com; s=arc-20160816; b=VmUU0U5aICnebsFJVvh64pY0+0mejXukkw/5td+BcvmBTSsxPLxBFxs4Cdl/fYTag/ BJwB4HRFqqZR5qEeddUyeCW8LmNLD5rnqBpP33hNh03bHiT7Iffw1cdzwrhsL14swUKd uu6t3osgoqCJyx6jnFHGrpacU/dHId1IpJqYVHUxtdyoHEO0kgRBET+2kc6UvnyZMral mj9UvJd2YFTfk98Lw2iztkQHZlE/telkw9bm5CuDuJiCnrvjrY3RAHSaAiVRKHIjObjk 81qk9uHbKfmZr5V7uniw83gOYMIbfkHMGjS+8l93eSSShqxRNdF5e3T8iIvQS36Wr8yp xvRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=8XTaEa03xoXSNRZj7ZTMerVrWrMAgYz73PBltKqmP1Q=; b=o0O7DYl+W73LRzyGSci9sWhDew70CyOWnf/2vIJ4J3hiH3TAda7k4XCklp5DRD/3uy UkRSif0czh9e/HVF45SD0GLQluyj6Wso+7LMdyDyO+4j859i6riPHBwOFYFEn8SddsEc aXE7GCVKuiZ4yg8yeJqPdD/prPgEGmXVEWYXyKm8QC37eK/fSfzSckujVjWD6vBhRfI6 l26DjbFTsx6fNb36ABGPjJ3g0Vm675R3O/SBLuPsMyX2VzWXAXIBbhA8kc4ODeqZVNNw PCgOoYYpX76WIJ8FT4OLr5udW1bCdr6d5uL6taZmUQ02gODSU/1F53RbTMLQVUHKuIOA AeTg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=PadokFZ2; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o20-v6si7808931pli.757.2018.01.28.14.53.24; Sun, 28 Jan 2018 14:53:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=PadokFZ2; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932731AbeA1WxW (ORCPT + 10 others); Sun, 28 Jan 2018 17:53:22 -0500 Received: from mail-dm3nam03on0095.outbound.protection.outlook.com ([104.47.41.95]:55532 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753694AbeA1W2e (ORCPT ); Sun, 28 Jan 2018 17:28:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=8XTaEa03xoXSNRZj7ZTMerVrWrMAgYz73PBltKqmP1Q=; b=PadokFZ2Nl9okUd4f95jEqxlO2eAa4qw0CydI4thXKWWAHomKOHizB5FLEpcuVSrPqvauNj0MH4eecWdLFOAMIydtbpaWd1yZnQDlzB3svO7uduq4GVBzPfGA9jOWIUQ4SxfBV13Dnze6d++mLW/Ovj/04DsWsbRlZpBTqG6FNI= Received: from MW2PR2101MB1034.namprd21.prod.outlook.com (52.132.149.10) by MW2PR2101MB1097.namprd21.prod.outlook.com (52.132.149.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.485.0; Sun, 28 Jan 2018 22:28:27 +0000 Received: from MW2PR2101MB1034.namprd21.prod.outlook.com ([fe80::e153:81e1:bbc3:3c22]) by MW2PR2101MB1034.namprd21.prod.outlook.com ([fe80::e153:81e1:bbc3:3c22%2]) with mapi id 15.20.0485.000; Sun, 28 Jan 2018 22:28:27 +0000 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Will Deacon , Matthew Wilcox , Jonathan Corbet , Sasha Levin Subject: [PATCH AUTOSEL for 4.9 17/49] scripts/kernel-doc: Don't fail with status != 0 if error encountered with -none Thread-Topic: [PATCH AUTOSEL for 4.9 17/49] scripts/kernel-doc: Don't fail with status != 0 if error encountered with -none Thread-Index: AQHTmIc5Q9pQlo+KfUmqsfMPCfTLsg== Date: Sun, 28 Jan 2018 22:27:46 +0000 Message-ID: <20180128222727.22404-17-alexander.levin@microsoft.com> References: <20180128222727.22404-1-alexander.levin@microsoft.com> In-Reply-To: <20180128222727.22404-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; MW2PR2101MB1097; 7:PC9C3aQLOEaIk5I1d1YjbR/ORyn8YNMNljkGtuA1Rf+zb+dDzaN1zE1Lw3ZwnAWBgS5gO8fmI1dgRg+4XeMbRRqc42du8AgFFm2LjMHmaNIlJMXQIFBjnh4XfxjjF7VnOsKHuOLuvnlNwHowdaOjJN/AQWu07EnWX16wdUTmVvIFZxtVZzc8aCO3a1nvA+Zx/pd3WeDM/DLJh7mvDFPmmPETtLZ/Ce4pmg1qcZVYULEfd26zrh4q8IsIuBCYreW5 x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 8ef437a4-4499-42b8-ce0b-08d5669e73b2 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7193020); SRVR:MW2PR2101MB1097; x-ms-traffictypediagnostic: MW2PR2101MB1097: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(180628864354917)(89211679590171); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(61425038)(6040501)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(3231101)(944501161)(6055026)(61426038)(61427038)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(20161123562045)(20161123560045)(6072148)(201708071742011); SRVR:MW2PR2101MB1097; BCL:0; PCL:0; RULEID:; SRVR:MW2PR2101MB1097; x-forefront-prvs: 05669A7924 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(346002)(366004)(39380400002)(39860400002)(396003)(376002)(199004)(189003)(72206003)(14454004)(3280700002)(106356001)(4326008)(478600001)(10290500003)(76176011)(102836004)(3660700001)(59450400001)(25786009)(6506007)(105586002)(316002)(6486002)(97736004)(22452003)(186003)(99286004)(110136005)(54906003)(107886003)(26005)(86362001)(8676002)(81156014)(2906002)(1076002)(81166006)(68736007)(3846002)(6116002)(305945005)(7736002)(36756003)(86612001)(10090500001)(6512007)(2950100002)(66066001)(5660300001)(53936002)(6666003)(8936002)(6436002)(2501003)(2900100001)(5250100002)(22906009)(217873001); DIR:OUT; SFP:1102; SCL:1; SRVR:MW2PR2101MB1097; H:MW2PR2101MB1034.namprd21.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: FSVnn3PuPdMKYi6LiujspSEMmbBk5USG1b9rc2ALL76ijQDTunhT5IR309f4W/F6YGGbdt3As1xLWzfuq6fDQw== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8ef437a4-4499-42b8-ce0b-08d5669e73b2 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jan 2018 22:27:46.8799 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB1097 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Will Deacon [ Upstream commit e814bccbafece52a24e152d2395b5d49eef55841 ] My bisect scripts starting running into build failures when trying to compile 4.15-rc1 with the builds failing with things like: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:2078: error: Cannot parse struct or union! The line in question is actually just a #define, but after some digging it turns out that my scripts pass W=1 and since commit 3a025e1d1c2ea ("Add optional check for bad kernel-doc comments") that results in kernel-doc running on each source file. The file in question has a badly formatted comment immediately before the #define: /** * struct brcmf_skbuff_cb reserves first two bytes in sk_buff::cb for * bus layer usage. */ which causes the regex in dump_struct to fail (lack of braces following struct declaration) and kernel-doc returns 1, which causes the build to fail. Fix the issue by always returning 0 from kernel-doc when invoked with -none. It successfully generates no documentation, and prints out any issues. Cc: Matthew Wilcox Cc: Jonathan Corbet Signed-off-by: Will Deacon Signed-off-by: Jonathan Corbet Signed-off-by: Sasha Levin --- scripts/kernel-doc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.11.0 diff --git a/scripts/kernel-doc b/scripts/kernel-doc index 93721f3c91bf..7b163f99624c 100755 --- a/scripts/kernel-doc +++ b/scripts/kernel-doc @@ -3139,4 +3139,4 @@ if ($verbose && $warnings) { print STDERR "$warnings warnings\n"; } -exit($errors); +exit($output_mode eq "none" ? 0 : $errors);