From patchwork Sat Dec 26 21:35:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Henrie X-Patchwork-Id: 352475 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87BF0C433DB for ; Sat, 26 Dec 2020 21:38:30 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 71C552184D for ; Sat, 26 Dec 2020 21:38:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 71C552184D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 4114D17BE; Sat, 26 Dec 2020 22:37:35 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 4114D17BE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1609018705; bh=/oV/aLaP+XKy3csQx5bzW39yF1Yw6gpzcXbZuzKmZ/4=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=i86LNugO48DkXr0l+WohHAz10FfBpwSgcxIwKAzN/gzUma0Hlm4TihOD9MPoGAJU5 HX9k+0I/L+p6YmfQPSBVAo8GOKZsIyiZuGZeEouAbsTWRPUVAI98TzAiH8GNPHjrpw aZ7rrIZz8LKUiCEWafGILScxw3QQ0zl/vJfsZgB0= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 4F7CAF804C2; Sat, 26 Dec 2020 22:36:44 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id BE472F800C8; Sat, 26 Dec 2020 22:36:37 +0100 (CET) Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C7EADF8021D for ; Sat, 26 Dec 2020 22:36:31 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C7EADF8021D Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="al5Jz13K" Received: by mail-pj1-x1034.google.com with SMTP id b5so4387303pjl.0 for ; Sat, 26 Dec 2020 13:36:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=G56ZDzgOT1ni0Po4A/IH2ndoD3TEINMsanasrB2rOGw=; b=al5Jz13KNOn0RayOhT+ebAx2BVXnNnsF0hZ/7FsdgWWcq6Em5/q5lbmQJlgARiIkWI LzExwT5vm6Ex+oQWC2+nfRq6qxgnCFf1ChZx4uU0ROT+JVf0nP1Zq4m9O0SThyekATeq Iy41D95x/H9BS056wQusVV8z8lQ/Tqxo4RhWbm72Y0iWor+7FX9tuVSXqH29xD4DRkvu 3oYOmJfJd0sVU9ZvlEka7JZpaZzbDDzLRXpDNPt3euy7FTm+T8dcgCSDqCnYZ0QMkdP0 9d0+z514EN36aG3Eu2hPCoJ91+u8YU3P8ot9eobIEcDN2fzSfP/SOzfl1eXokjLa32yb Fs8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=G56ZDzgOT1ni0Po4A/IH2ndoD3TEINMsanasrB2rOGw=; b=VGUyiU5ToCVfYg7mC+5j+0tcByR2zKrrflU0AFEpo8087amYCblgR/L+54T0JAdmHK LFR+ueIbxQRJJ0JovVFsphEXKta4Q/brg/ZX/L+RxXQLwbe+WmAXr3dhKZSTBlETbdR3 x6k111IWKarklhlOAh0Rpo8NDPaaazETsE66B81+aRQBL04nhalwRBk1UNoKby4HeqME Hl5bzXfiZYvdwGDQWv/k7UF7+ZMZo4hjl4i/jUiVYuxx0XiSPM5I87TtMK/rU5faW2+x sNy4BBYVeFzuBYJGdo80+QYq/tP4cvwxbHg1/g2t6LBsf8UTixTEumiijcvmYhgRDnVr +qlg== X-Gm-Message-State: AOAM533ZIjpBRK6MyQbB43DVuA9e9AEeLke+BqwhDJpEWDydCw6bU8E1 Ryakyyt0I4+M3MWR/oRN3WMKguYW/B4B+A== X-Google-Smtp-Source: ABdhPJzlJAjcDH5RfqZ07CU+IBPa88gvZFE4WdtXZNor4pEqR31joUOSJSlKIBPP1lJkcBk0Wr//3A== X-Received: by 2002:a17:902:9043:b029:dc:299b:b9bb with SMTP id w3-20020a1709029043b02900dc299bb9bbmr38879794plz.66.1609018589403; Sat, 26 Dec 2020 13:36:29 -0800 (PST) Received: from viper.bn-i.net ([2001:470:b:65c:b92f:8d47:b3dd:6388]) by smtp.gmail.com with ESMTPSA id b12sm30990560pft.114.2020.12.26.13.36.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Dec 2020 13:36:28 -0800 (PST) From: Alex Henrie To: alsa-devel@alsa-project.org, perex@perex.cz, tiwai@suse.de Subject: [PATCH 3/9] rawmidi: fix memory leak in snd_rawmidi_virtual_open Date: Sat, 26 Dec 2020 14:35:41 -0700 Message-Id: <20201226213547.175071-4-alexhenrie24@gmail.com> X-Mailer: git-send-email 2.29.2.368.ge46b91665e.dirty In-Reply-To: <20201226213547.175071-1-alexhenrie24@gmail.com> References: <20201226213547.175071-1-alexhenrie24@gmail.com> MIME-Version: 1.0 Cc: Alex Henrie X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Signed-off-by: Alex Henrie --- src/rawmidi/rawmidi_virt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/rawmidi/rawmidi_virt.c b/src/rawmidi/rawmidi_virt.c index 2c4c27f5..884b8ff8 100644 --- a/src/rawmidi/rawmidi_virt.c +++ b/src/rawmidi/rawmidi_virt.c @@ -315,7 +315,7 @@ int snd_rawmidi_virtual_open(snd_rawmidi_t **inputp, snd_rawmidi_t **outputp, int merge, int mode) { int err; - snd_rawmidi_t *rmidi; + snd_rawmidi_t *rmidi = NULL; snd_rawmidi_virtual_t *virt = NULL; struct pollfd pfd; @@ -392,6 +392,7 @@ int snd_rawmidi_virtual_open(snd_rawmidi_t **inputp, snd_rawmidi_t **outputp, free(*inputp); if (outputp) free(*outputp); + free(rmidi); return err; } From patchwork Sat Dec 26 21:35:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Henrie X-Patchwork-Id: 352474 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EF1AC433E0 for ; Sat, 26 Dec 2020 21:39:12 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8286621D7A for ; Sat, 26 Dec 2020 21:39:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8286621D7A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id E39CA17F0; Sat, 26 Dec 2020 22:38:19 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz E39CA17F0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1609018750; bh=27rvBlhhf4w5Z4DFjh0Aw5x9G+07Kx0Kfl8tROdKzDs=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=mwIsDBg5aChz1UZsIeqqhzFaYZIkGsRvCv3m2pif81C3Xr84ZgB6LsVHl8veYM1rF GbzqqmdSAkyhaF0XShJ5GxPOMOxDWHguhGOYt+Tl6Bor8yvT43BIPEbIbpXz5qnwN0 BbrKSh/uY28kPm2/98E0xHdNu63yc8SVpInou1dY= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id D4FD3F804BD; Sat, 26 Dec 2020 22:36:45 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 889ACF804B3; Sat, 26 Dec 2020 22:36:39 +0100 (CET) Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C5233F80128 for ; Sat, 26 Dec 2020 22:36:33 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C5233F80128 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JFvya+xm" Received: by mail-pl1-x631.google.com with SMTP id b8so3826218plx.0 for ; Sat, 26 Dec 2020 13:36:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jq/6tcPUBYiBTQ1rQtKYROKYlBauXerKjDz6CDptgY4=; b=JFvya+xm3qQmXYghULp4U5s/nX4LO3xghoCTk+WaacwS3tPmhdH+rrzsgzo3Fet/5Y mxq+OHbmlkg+MxT3d17Adr15h22+lZn9sZ+zgy3Gqv4qOo4vM7xp4aivL+Cg9n6dOCM6 B/GXe1ac1h63rBukBLbVvzyKIJjaJ+A2w1lQ0hhW3MhEgfnn0BgXv9bS+t2abnfcHwQB bt7/HTpPJDkwE1mRWR0nHT9QXlTLSs//17CUmbwTjIi5B1A2tSP7Auz/oCR1+1q8jpLz 24bza3W6WMcOH0/Prp8OwgvJwncZOA0qfB+SFi6wT6IkjosN1/rQErynFF20/27Kvr99 GWGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jq/6tcPUBYiBTQ1rQtKYROKYlBauXerKjDz6CDptgY4=; b=hSWZO3Q4nI1v7hZ4AwLHAg411EB9kAZDsV9PsrvXNWAxps1xhLJQYTXEGJO6ZbFv2f HDQDJMHbbiRXdZyMjfTXCoubOo5uSN0Unoisf0J7ra4wnd3yYbojMYiL+rWSZs97IZbh 8HP+HNZNpt+WkgE7k3xyVN5m0cWDHc1eC4c7esG7tsY5FI0zBaHcUkODUau/XS1mUm0D Rtr5SQEO+nkoYAF/n7uNmt0CgoxsOI6Qf/R6FePMl1bUl64FiMGoeCOkrJ8Cl3qbB6s5 rPdpXuFFXJ3rNTqM7siNlxOsaZ795PxnmwfIs6l47sF8n7oWhDj/qD70TOSZXbTAk6IG 5GwA== X-Gm-Message-State: AOAM532StHzB50klRpSMFU+3bAUKKMK/P7hIXjEHodZFk+0m1wPaNZNw mOgsrE0vI8yBEW3uRVPUSOG+G3qMmSGLag== X-Google-Smtp-Source: ABdhPJyIlUWgoSSbjnbYGX4KJNUB6q07xNBwc8IjQIvh3xwkEpEJNrFoEd7nbExiXBjc+INjR6lv+w== X-Received: by 2002:a17:90a:3948:: with SMTP id n8mr13911651pjf.206.1609018590658; Sat, 26 Dec 2020 13:36:30 -0800 (PST) Received: from viper.bn-i.net ([2001:470:b:65c:b92f:8d47:b3dd:6388]) by smtp.gmail.com with ESMTPSA id b12sm30990560pft.114.2020.12.26.13.36.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Dec 2020 13:36:30 -0800 (PST) From: Alex Henrie To: alsa-devel@alsa-project.org, perex@perex.cz, tiwai@suse.de Subject: [PATCH 4/9] confmisc: fix memory leak in snd_func_concat Date: Sat, 26 Dec 2020 14:35:42 -0700 Message-Id: <20201226213547.175071-5-alexhenrie24@gmail.com> X-Mailer: git-send-email 2.29.2.368.ge46b91665e.dirty In-Reply-To: <20201226213547.175071-1-alexhenrie24@gmail.com> References: <20201226213547.175071-1-alexhenrie24@gmail.com> MIME-Version: 1.0 Cc: Alex Henrie X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Signed-off-by: Alex Henrie --- src/confmisc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/confmisc.c b/src/confmisc.c index eb8218c1..aece39c3 100644 --- a/src/confmisc.c +++ b/src/confmisc.c @@ -440,8 +440,8 @@ int snd_func_concat(snd_config_t **dst, snd_config_t *root, snd_config_t *src, err = snd_config_get_id(src, &id); if (err >= 0) err = snd_config_imake_string(dst, id, res); - free(res); __error: + free(res); return err; } #ifndef DOC_HIDDEN From patchwork Sat Dec 26 21:35:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Henrie X-Patchwork-Id: 352473 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8A79C433E0 for ; Sat, 26 Dec 2020 21:40:01 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BDE3E2184D for ; Sat, 26 Dec 2020 21:40:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BDE3E2184D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 1CAE817E2; Sat, 26 Dec 2020 22:39:09 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 1CAE817E2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1609018799; bh=sPskISSkHf67G79XiidFSR9sYjMVxWX29MR7q19iVRE=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Q9lK2BCDPMdvi5yk0KCzGuLOg+Z9NuguRwfzofJQ40DEPJQp6kJatztXXQmepJGqu GgINaPExoXSLlPBEDgNgVVk8vPcHhrm6cs6loDwWmDbz57uOX8al3ybCN45nLcjELv QUkiZ68BHkdF+TlhChp52Iz0FI1mTPR6Wl2jDCgQ= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 42404F804E0; Sat, 26 Dec 2020 22:36:49 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 79D7FF804B3; Sat, 26 Dec 2020 22:36:42 +0100 (CET) Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 304DCF8021D for ; Sat, 26 Dec 2020 22:36:35 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 304DCF8021D Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Hw31J2lc" Received: by mail-pj1-x102f.google.com with SMTP id m5so4374578pjv.5 for ; Sat, 26 Dec 2020 13:36:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KNxKH7kPT8D5/vzKIanSIdnixFhHf6LxdF+kDOphzzQ=; b=Hw31J2lck1Mv9PKOhzuZyGaQcQIrBy8gWfmYr3CZbut8eGVU7WduZRzOtbCyerv+s6 gTjJzt9jpXpuwCz2sFpYrDS2SlP5GMzhesa3ays7j+0HNgY94Ck7QaSQeanUCKgyJ2WL 674k4bIvoS6FfSFmUX3+4SbhVGRYcw15ydA4SAO/owjl/f+5CbmaiEb5ncdO1eiNOUqP G9g+hsbtIEafeFWcen/jHn+WeO0ZEILrhHgME+QdDHxPpsHz0hOgxKuHYgEN2+WXs2gU 4uGueGHPpYfy1xkDieeMU8FgI73DAnEnPv+WB+30A79I6nSMhEw92PYkBwr3kKeuIoDY X+JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KNxKH7kPT8D5/vzKIanSIdnixFhHf6LxdF+kDOphzzQ=; b=QmOJEZK2JP/0+ZA7Y1OjboRr4mUhpcvNdNQBB1X7XeDrmOdy+I2gH6+fo+rCMV/IU5 J517QlgrehlNtt4J2G4JlK4I4SSz9V+rNfpt80V2VpFCbwczpCptOnv4xtBwFJWCxsKA RP9STq/TxOzuLaCOIjsbj6rE5ww5mr0GexkDyM+cv7DU+RqqG7vCBnKkB4E91qhbgiWa C4n34F8APpFiJiu1emPWQxKiFkC++fhP2v5X03Pr+ZmHcrM3J2yCA8kNmnvHv2gTAc3r 59Be9sgPXBuDJ4yMyQKjqCK3XnWVsl6itT5wvJFPTqXiVZRU/f2BcQ1578xdMZ74+P3/ Xw/Q== X-Gm-Message-State: AOAM532Pzvp2AhOX1UMX2bWy0ikARB1f1DzABAx6PTJmqLqblPBKN6N4 nmpYCYcPnT6DO6+4Vm2f/Dd9u5Fm2aAx3g== X-Google-Smtp-Source: ABdhPJzJNbCJz9GV5pjgQIewG3tTHjBE+uwZcpR4A/hnAuFlgyux2M09hIP/L9aRDW4kP1HqbFEVwA== X-Received: by 2002:a17:90b:4b06:: with SMTP id lx6mr13996160pjb.224.1609018592703; Sat, 26 Dec 2020 13:36:32 -0800 (PST) Received: from viper.bn-i.net ([2001:470:b:65c:b92f:8d47:b3dd:6388]) by smtp.gmail.com with ESMTPSA id b12sm30990560pft.114.2020.12.26.13.36.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Dec 2020 13:36:32 -0800 (PST) From: Alex Henrie To: alsa-devel@alsa-project.org, perex@perex.cz, tiwai@suse.de Subject: [PATCH 5/9] timer: fix sizeof operator mismatch in snd_timer_query_hw_open Date: Sat, 26 Dec 2020 14:35:43 -0700 Message-Id: <20201226213547.175071-6-alexhenrie24@gmail.com> X-Mailer: git-send-email 2.29.2.368.ge46b91665e.dirty In-Reply-To: <20201226213547.175071-1-alexhenrie24@gmail.com> References: <20201226213547.175071-1-alexhenrie24@gmail.com> MIME-Version: 1.0 Cc: Alex Henrie X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Signed-off-by: Alex Henrie --- src/timer/timer_query_hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/timer/timer_query_hw.c b/src/timer/timer_query_hw.c index dad228c8..d8bac6e7 100644 --- a/src/timer/timer_query_hw.c +++ b/src/timer/timer_query_hw.c @@ -104,7 +104,7 @@ int snd_timer_query_hw_open(snd_timer_query_t **handle, const char *name, int mo close(fd); return -SND_ERROR_INCOMPATIBLE_VERSION; } - tmr = (snd_timer_query_t *) calloc(1, sizeof(snd_timer_t)); + tmr = (snd_timer_query_t *) calloc(1, sizeof(snd_timer_query_t)); if (tmr == NULL) { close(fd); return -ENOMEM; From patchwork Sat Dec 26 21:35:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Henrie X-Patchwork-Id: 352472 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C06CC433DB for ; Sat, 26 Dec 2020 21:40:49 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9D91421E92 for ; Sat, 26 Dec 2020 21:40:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D91421E92 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 300FE17DC; Sat, 26 Dec 2020 22:39:57 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 300FE17DC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1609018847; bh=WL3dvaKnlqF/QmDYOtdc5Jhu6Hl1f+5yb6nuxwse0nI=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=UpwifQL+vpmpGYhf24LO42CRj3I99Oeyky2cOFdv//QnWrYHeNfd6XVrLOmVfKAai oGw1cNqEpbbt1VgWLQ84f4Gvq2Q1rwrh53wJtm433JQyXWaj4X0jeLHD+AuTsZPmYl LGTviHgJq96bhLPCtQf/+0AoD/Y5dMfoeVvG2MTM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id B5888F804EB; Sat, 26 Dec 2020 22:36:50 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id C7D58F804CB; Sat, 26 Dec 2020 22:36:44 +0100 (CET) Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id CB83DF80128 for ; Sat, 26 Dec 2020 22:36:38 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz CB83DF80128 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UORcVBCi" Received: by mail-pl1-x62d.google.com with SMTP id e2so3786854plt.12 for ; Sat, 26 Dec 2020 13:36:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CGMDXHzae7cbtDODzEaOuSaiCvodayE5Yptws/W6AnA=; b=UORcVBCiK45lya3zy5POm6OAXP90+Pe7EpeG7Ih0Wp3jw7lcj7v0BalQ1BLw2lTbQW rk7gZQP252PTSsNXYKH1HoSoKNXF0d0b8XWpsnofhnNye05EgwYzC6nC2piDSkzrjktO AhIeNx+mQqg/HriishHvnuXp7c24ddrU0UkZLte6elllcbBOlCSZ2owRs+m3oCeIzSQn 5kJ6dzDSa2IuUANFMva/Y1HYdbgcd/4JG5N9Fy0pZJvFdnAdvXo2GkmwPi2mEqgIrjfa fM9kvLlTatd5wOeG0gmJGDmWlJK4Wat1JHCfMTbltMszDaNhjAq4nsJMaz7S8VYbb39o YQvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CGMDXHzae7cbtDODzEaOuSaiCvodayE5Yptws/W6AnA=; b=Zlxi81i46KipWOzcQvzj5Dmnu9RjYJgaCI9BfU5MupjVzUexrAjYlSNnAZfZ09D58L i7f7/AbKNsezJdDnRD7b3FJpBCiCbeLk3lG69mZNlLUso9PHIMm0+IBSIUmTZbhQq4YQ sQSpZNmBA10fnYU5fjMg4qDvddIiII8AF2rhOObqNaSMtwR0+kNPBvGZMAv8zhaEXz4r I6OODC210ZsB1JkLWaQZWzcURIcyCsbmaGUaYKbFOxnkZWUMnSV0db/KiBDuuSNybpi4 MyylQKWDoaHEAWZ3ilhOpPWQWdxxRwhOwVUsWFLL9rXqAbpQz8d02/7seVPfvlQOk1PO 9xgg== X-Gm-Message-State: AOAM532awxiRAcqC1eUVmgirEHorX+bHZg38zMUs3eo/nU0OjMSgjMSU PDAKYCqlxxkWSPfskN1SLWGLKCimEa1JWw== X-Google-Smtp-Source: ABdhPJz7VK6+lGQPVIcWmBhIE6nkOYozvGsw9I239hPEr6/aHqux10xuUDfEj8Q3sM7yo35CH3iLPw== X-Received: by 2002:a17:902:c40c:b029:da:74c9:df4f with SMTP id k12-20020a170902c40cb02900da74c9df4fmr13635795plk.68.1609018595652; Sat, 26 Dec 2020 13:36:35 -0800 (PST) Received: from viper.bn-i.net ([2001:470:b:65c:b92f:8d47:b3dd:6388]) by smtp.gmail.com with ESMTPSA id b12sm30990560pft.114.2020.12.26.13.36.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Dec 2020 13:36:35 -0800 (PST) From: Alex Henrie To: alsa-devel@alsa-project.org, perex@perex.cz, tiwai@suse.de Subject: [PATCH 7/9] pcm_multi: remove dead assignment from _snd_pcm_multi_open Date: Sat, 26 Dec 2020 14:35:45 -0700 Message-Id: <20201226213547.175071-8-alexhenrie24@gmail.com> X-Mailer: git-send-email 2.29.2.368.ge46b91665e.dirty In-Reply-To: <20201226213547.175071-1-alexhenrie24@gmail.com> References: <20201226213547.175071-1-alexhenrie24@gmail.com> MIME-Version: 1.0 Cc: Alex Henrie X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Signed-off-by: Alex Henrie --- src/pcm/pcm_multi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/pcm/pcm_multi.c b/src/pcm/pcm_multi.c index 53c414d5..5fa09b9b 100644 --- a/src/pcm/pcm_multi.c +++ b/src/pcm/pcm_multi.c @@ -1323,7 +1323,6 @@ int _snd_pcm_multi_open(snd_pcm_t **pcmp, const char *name, err = -ENOMEM; goto _free; } - idx = 0; for (idx = 0; idx < channels_count; ++idx) channels_sidx[idx] = -1; idx = 0; From patchwork Sat Dec 26 21:35:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Henrie X-Patchwork-Id: 352471 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F59DC433E0 for ; Sat, 26 Dec 2020 21:41:35 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 063AA2184D for ; Sat, 26 Dec 2020 21:41:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 063AA2184D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 78C791830; Sat, 26 Dec 2020 22:40:43 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 78C791830 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1609018893; bh=OtJwW2dEDE9yvmdjhTCGV7+lk7O5ntp8OkFUMCAIGlE=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=IQ0Kt56gr0Jhkl/DHRFNHn67ttEByKy3yXqGXPFe/ntGiYrUgQsPeZp0OafX5AApF RP4/qKsnfvTA2a4Yq+LeUKtYZ8p/ZeSUVKv7yPAEF/XgwP/KHVDLpq7jFLeimqR+3l FroiD2r7hnNjci3D1Xb4mpkpzrqB/s4C/s9aB3Ec= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 265F2F804F3; Sat, 26 Dec 2020 22:36:52 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id BCAA0F804CA; Sat, 26 Dec 2020 22:36:45 +0100 (CET) Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id B4B9BF800C8 for ; Sat, 26 Dec 2020 22:36:41 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz B4B9BF800C8 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="uWk2fmKX" Received: by mail-pj1-x1030.google.com with SMTP id iq13so3977299pjb.3 for ; Sat, 26 Dec 2020 13:36:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SGvZhjq5QthoZWs63qADXvtqQZNJI6Nm2I7oDs2JzP8=; b=uWk2fmKXwSvrqYS5a+lcHPZFPlb7ZzcLF3hOVyx+bgenNq5vrfJAoYNcf5rei5eC/9 Keg8VdcpkQLt1dQpHjONrIdhVBYA+0ZQl0zciQU/StQCfA7TSomEqsSLcj2eJfCC1qkm PZspiDA4WrFsKNOpXBZGCnKw26/ifoYTcCY1ObNYYT0nZuKpKEpoqqgpg+1E+iQoku+4 KIzTBpwdyuXC0RHF9okbj+MZWA2Zk6idNPDzQtbTDbVkwCIHMV3VFBSg2dsaWu4M8Iu9 Na36HqSCzt0Hl8+EwN56Kc5dE8a20yLv1JYwqdwjqgDYD5rut7rMLABwmTnIuwzSR/uZ sCyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SGvZhjq5QthoZWs63qADXvtqQZNJI6Nm2I7oDs2JzP8=; b=F/VFxpqYYs/aOhdLrqJfPJaOkJ51kxyhGfquoYulH5462of1c5UQw46/DK1R6BFFwm dXKFHrbntw/2thwhEkG1tbcV3/zkPerWd3temf+5xe6Ptz0shl3iMWuI46WWuvUSv2iL SkQSbfgD8MtP25ksVjQrazYvt6eowsxvn7Z6WXj6FYebdUtM7Aovwe0wCe6n5y7g0dhx 0oXy8JTSZRhJ3Wts93Q7NNqxGHxjsX2j6tRb2PVg7I0LzaUqxgFX4OVHOOuYlbTTch+h vo2geYe4Qi4nq23B3lAFC0UAaB7wkg5LGJ+gX5BhAQgkwZOlzTxVYUebL8M+N6vkCUmc josw== X-Gm-Message-State: AOAM532sY+G7W2SyY3aNYcL09hFH35mXlbwajp8MI7OXoOyQqCu8m37o 4Dxa76SoC367lejOyQlVpzlyFRQqSLdj8A== X-Google-Smtp-Source: ABdhPJyhB2/PnmlaWcmPctU560N3oVfw9Mu0GVJFVgAPnXN294POfrBfg2yDjxRvTo66gGwMDovOvQ== X-Received: by 2002:a17:90a:be0a:: with SMTP id a10mr14385329pjs.139.1609018598228; Sat, 26 Dec 2020 13:36:38 -0800 (PST) Received: from viper.bn-i.net ([2001:470:b:65c:b92f:8d47:b3dd:6388]) by smtp.gmail.com with ESMTPSA id b12sm30990560pft.114.2020.12.26.13.36.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Dec 2020 13:36:37 -0800 (PST) From: Alex Henrie To: alsa-devel@alsa-project.org, perex@perex.cz, tiwai@suse.de Subject: [PATCH 9/9] conf: remove dead code from get_hexachar Date: Sat, 26 Dec 2020 14:35:47 -0700 Message-Id: <20201226213547.175071-10-alexhenrie24@gmail.com> X-Mailer: git-send-email 2.29.2.368.ge46b91665e.dirty In-Reply-To: <20201226213547.175071-1-alexhenrie24@gmail.com> References: <20201226213547.175071-1-alexhenrie24@gmail.com> MIME-Version: 1.0 Cc: Alex Henrie X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Signed-off-by: Alex Henrie --- src/conf.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/src/conf.c b/src/conf.c index 44d1bfde..970ad643 100644 --- a/src/conf.c +++ b/src/conf.c @@ -877,16 +877,9 @@ static int get_nonwhite(input_t *input) static inline int get_hexachar(input_t *input) { - int c, num = 0; - + int c; c = get_char(input); - if (c >= '0' && c <= '9') num |= (c - '0') << 4; - else if (c >= 'a' && c <= 'f') num |= (c - 'a') << 4; - else if (c >= 'A' && c <= 'F') num |= (c - 'A') << 4; c = get_char(input); - if (c >= '0' && c <= '9') num |= (c - '0') << 0; - else if (c >= 'a' && c <= 'f') num |= (c - 'a') << 0; - else if (c >= 'A' && c <= 'F') num |= (c - 'A') << 0; return c; }