From patchwork Tue Jan 5 15:28:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 357728 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD7AEC433E0 for ; Tue, 5 Jan 2021 15:39:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AF41822AAD for ; Tue, 5 Jan 2021 15:39:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728262AbhAEPia (ORCPT ); Tue, 5 Jan 2021 10:38:30 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:38190 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727987AbhAEPi3 (ORCPT ); Tue, 5 Jan 2021 10:38:29 -0500 Received: from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 29B5E1BE8; Tue, 5 Jan 2021 16:30:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1609860615; bh=H7wvGaBXpW96W4larKhHIvjCU3x2Xb/IHlfEIZWXDFI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aLDQitAGsFHzEGtiypqjL28X2xbnSKr3cljaBYtzex3jXJaBmhqMCHMWxccNAvnN/ 0qktiaEOHlbW8wr1FPTzVfy80KzS3yIcgp2etFMDnHQWVndspB38hwn/AEIcN+Oa7s w5fv9bAhcvsNiYL1K456IYLZ1kIH/wIfjfBBfJZw= From: Laurent Pinchart To: linux-media@vger.kernel.org Cc: Rui Miguel Silva , Steve Longerbeam , Philipp Zabel , Ezequiel Garcia , Rob Herring , devicetree@vger.kernel.org Subject: [PATCH 57/75] dt-bindings: media: Convert i.MX7 MIPI CSI-2 receiver binding to YAML Date: Tue, 5 Jan 2021 17:28:34 +0200 Message-Id: <20210105152852.5733-58-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210105152852.5733-1-laurent.pinchart@ideasonboard.com> References: <20210105152852.5733-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Convert the DT binding for the i.MX7 MIPI CSI-2 receiver to YAML. Add Rui to the maintainers list as he's the original author of the binding. Signed-off-by: Laurent Pinchart --- .../bindings/media/fsl,imx7-mipi-csi2.yaml | 204 ++++++++++++++++++ .../bindings/media/imx7-mipi-csi2.txt | 90 -------- MAINTAINERS | 2 +- 3 files changed, 205 insertions(+), 91 deletions(-) create mode 100644 Documentation/devicetree/bindings/media/fsl,imx7-mipi-csi2.yaml delete mode 100644 Documentation/devicetree/bindings/media/imx7-mipi-csi2.txt diff --git a/Documentation/devicetree/bindings/media/fsl,imx7-mipi-csi2.yaml b/Documentation/devicetree/bindings/media/fsl,imx7-mipi-csi2.yaml new file mode 100644 index 000000000000..2df997293780 --- /dev/null +++ b/Documentation/devicetree/bindings/media/fsl,imx7-mipi-csi2.yaml @@ -0,0 +1,204 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/fsl,imx7-mipi-csi2.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: NXP i.MX7 MIPI CSI-2 receiver + +maintainers: + - Laurent Pinchart + - Rui Miguel Silva + +description: |- + The NXP i.MX7 SoC family includes a MIPI CSI-2 receiver IP core, documented + as "CSIS V3.3". The IP core seems to originate from Samsung, and may be + compatible with some of the Exynos4 ad S5P SoCs. + + While the CSI-2 receiver is separate from the MIPI D-PHY IP core, the PHY is + completely wrapped by the CSIS and doesn't expose a control interface of its + own. This binding thus covers both IP cores. + +properties: + compatible: + const: fsl,imx7-mipi-csi2 + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + items: + - description: The peripheral clock (a.k.a. APB clock) + - description: The external clock (optionally used as the pixel clock) + - description: The MIPI D-PHY clock + + clock-names: + items: + - const: pclk + - const: wrap + - const: phy + + resets: + items: + - description: MIPI D-PHY slave reset + + reset-names: + items: + - const: mrst + + power-domains: true + + phy-supply: + description: The MIPI D-PHY digital power supply + + clock-frequency: + description: The desired external clock ("wrap") frequency, in Hz + default: 166000000 + + fsl,csis-hs-settle: + $ref: /schemas/types.yaml#/definitions/uint32 + description: HS-SETTLE time (unit unknown) + + ports: + # See ./video-interfaces.txt for details + type: object + + properties: + "#address-cells": + $ref: /schemas/types.yaml#/definitions/uint32 + const: 1 + + "#size-cells": + $ref: /schemas/types.yaml#/definitions/uint32 + const: 0 + + port@0: + type: object + description: The input port, connected to the CSI-2 source + + properties: + reg: + const: 0 + + endpoint: + type: object + + properties: + data-lanes: + $ref: /schemas/types.yaml#/definitions/uint32-array + items: + minItems: 1 + maxItems: 2 + items: + - const: 1 + - const: 2 + + remote-endpoint: + $ref: /schemas/types.yaml#/definitions/phandle + + required: + - data-lanes + - remote-endpoint + + additionalProperties: false + + required: + - reg + + additionalProperties: false + + port@1: + type: object + description: The output port + + properties: + reg: + const: 1 + + endpoint: + type: object + + properties: + remote-endpoint: + $ref: /schemas/types.yaml#/definitions/phandle + + required: + - remote-endpoint + + additionalProperties: false + + required: + - reg + + additionalProperties: false + + required: + - "#address-cells" + - "#size-cells" + - port@0 + - port@1 + + additionalProperties: false + +required: + - compatible + - reg + - interrupts + - clocks + - clock-names + - resets + - reset-names + - power-domains + - phy-supply + - ports + +additionalProperties: false + +examples: + - | + #include + #include + #include + + mipi_csi: mipi-csi@30750000 { + compatible = "fsl,imx7-mipi-csi2"; + reg = <0x30750000 0x10000>; + interrupts = ; + clocks = <&clks IMX7D_IPG_ROOT_CLK>, + <&clks IMX7D_MIPI_CSI_ROOT_CLK>, + <&clks IMX7D_MIPI_DPHY_ROOT_CLK>; + clock-names = "pclk", "wrap", "phy"; + clock-frequency = <166000000>; + power-domains = <&pgc_mipi_phy>; + phy-supply = <®_1p0d>; + resets = <&src IMX7_RESET_MIPI_PHY_MRST>; + reset-names = "mrst"; + fsl,csis-hs-settle = <3>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + + mipi_csi_in: endpoint { + remote-endpoint = <&ov2680_out>; + data-lanes = <1>; + }; + }; + + port@1 { + reg = <1>; + + mipi_csi_out: endpoint { + remote-endpoint = <&csi_mux_from_mipi_vc0>; + }; + }; + }; + }; + +... diff --git a/Documentation/devicetree/bindings/media/imx7-mipi-csi2.txt b/Documentation/devicetree/bindings/media/imx7-mipi-csi2.txt deleted file mode 100644 index 71fd74ed3ec8..000000000000 --- a/Documentation/devicetree/bindings/media/imx7-mipi-csi2.txt +++ /dev/null @@ -1,90 +0,0 @@ -Freescale i.MX7 Mipi CSI2 -========================= - -mipi_csi2 node --------------- - -This is the device node for the MIPI CSI-2 receiver core in i.MX7 SoC. It is -compatible with previous version of Samsung D-phy. - -Required properties: - -- compatible : "fsl,imx7-mipi-csi2"; -- reg : base address and length of the register set for the device; -- interrupts : should contain MIPI CSIS interrupt; -- clocks : list of clock specifiers, see - Documentation/devicetree/bindings/clock/clock-bindings.txt for details; -- clock-names : must contain "pclk", "wrap" and "phy" entries, matching - entries in the clock property; -- power-domains : a phandle to the power domain, see - Documentation/devicetree/bindings/power/power_domain.txt for details. -- reset-names : should include following entry "mrst"; -- resets : a list of phandle, should contain reset entry of - reset-names; -- phy-supply : from the generic phy bindings, a phandle to a regulator that - provides power to MIPI CSIS core; - -Optional properties: - -- clock-frequency : The IP's main (system bus) clock frequency in Hz, default - value when this property is not specified is 166 MHz; -- fsl,csis-hs-settle : differential receiver (HS-RX) settle time; - -The device node should contain two 'port' child nodes with one child 'endpoint' -node, according to the bindings defined in: - Documentation/devicetree/bindings/ media/video-interfaces.txt. - The following are properties specific to those nodes. - -port node ---------- - -- reg : (required) can take the values 0 or 1, where 0 shall be - related to the sink port and port 1 shall be the source - one; - -endpoint node -------------- - -- data-lanes : (required) an array specifying active physical MIPI-CSI2 - data input lanes and their mapping to logical lanes; this - shall only be applied to port 0 (sink port), the array's - content is unused only its length is meaningful, - in this case the maximum length supported is 2; - -example: - - mipi_csi: mipi-csi@30750000 { - #address-cells = <1>; - #size-cells = <0>; - - compatible = "fsl,imx7-mipi-csi2"; - reg = <0x30750000 0x10000>; - interrupts = ; - clocks = <&clks IMX7D_IPG_ROOT_CLK>, - <&clks IMX7D_MIPI_CSI_ROOT_CLK>, - <&clks IMX7D_MIPI_DPHY_ROOT_CLK>; - clock-names = "pclk", "wrap", "phy"; - clock-frequency = <166000000>; - power-domains = <&pgc_mipi_phy>; - phy-supply = <®_1p0d>; - resets = <&src IMX7_RESET_MIPI_PHY_MRST>; - reset-names = "mrst"; - fsl,csis-hs-settle = <3>; - - port@0 { - reg = <0>; - - mipi_from_sensor: endpoint { - remote-endpoint = <&ov2680_to_mipi>; - data-lanes = <1>; - }; - }; - - port@1 { - reg = <1>; - - mipi_vc0_to_csi_mux: endpoint { - remote-endpoint = <&csi_mux_from_mipi_vc0>; - }; - }; - }; diff --git a/MAINTAINERS b/MAINTAINERS index 970d9cee509d..584ea2116c38 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -10842,8 +10842,8 @@ L: linux-media@vger.kernel.org S: Maintained T: git git://linuxtv.org/media_tree.git F: Documentation/admin-guide/media/imx7.rst +F: Documentation/devicetree/bindings/media/fsl,imx7-mipi-csi2.yaml F: Documentation/devicetree/bindings/media/imx7-csi.txt -F: Documentation/devicetree/bindings/media/imx7-mipi-csi2.txt F: drivers/staging/media/imx/imx7-media-csi.c F: drivers/staging/media/imx/imx7-mipi-csis.c From patchwork Tue Jan 5 15:28:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 357727 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F303C433E6 for ; Tue, 5 Jan 2021 15:39:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E67AE22AAD for ; Tue, 5 Jan 2021 15:39:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728257AbhAEPig (ORCPT ); Tue, 5 Jan 2021 10:38:36 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:38168 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727987AbhAEPif (ORCPT ); Tue, 5 Jan 2021 10:38:35 -0500 Received: from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D78991BEA; Tue, 5 Jan 2021 16:30:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1609860616; bh=s76zZJfcRt9wW5Lw9OfDHVspf3tyAVGMIqynLyAQwsc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Bqgg0Sl/xPTTlOUrPzYyksiKLbrmAeiPpayoVLEy0hLRkDLPewROOxt2X7zcZf4Vu w4S8DGyZPQ+S1/icFVrh0WQAyKyszAavGS+XANCWcKIBztIyrxJcFJj323NyqDsOmW 9fWmvCYN68QqFXVFzLWzPQaYnwYak50dU10Mng+Q= From: Laurent Pinchart To: linux-media@vger.kernel.org Cc: Rui Miguel Silva , Steve Longerbeam , Philipp Zabel , Ezequiel Garcia , Rob Herring , devicetree@vger.kernel.org Subject: [PATCH 58/75] dt-bindings: media: fsl, imx7-mipi-csi2: Drop the reset-names property Date: Tue, 5 Jan 2021 17:28:35 +0200 Message-Id: <20210105152852.5733-59-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210105152852.5733-1-laurent.pinchart@ideasonboard.com> References: <20210105152852.5733-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The reset-names property is incorrect, as it references the reset of the MIPI D-PHY master, which is used by the DSI controller. Fixing the property name would create backward-compatibility issues. As the device has a single reset, we can instead drop reset-names completely, which also simplifies the binding. Fix the example accordingly to use the correct reset. Signed-off-by: Laurent Pinchart --- .../devicetree/bindings/media/fsl,imx7-mipi-csi2.yaml | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/Documentation/devicetree/bindings/media/fsl,imx7-mipi-csi2.yaml b/Documentation/devicetree/bindings/media/fsl,imx7-mipi-csi2.yaml index 2df997293780..d8918ba3b06c 100644 --- a/Documentation/devicetree/bindings/media/fsl,imx7-mipi-csi2.yaml +++ b/Documentation/devicetree/bindings/media/fsl,imx7-mipi-csi2.yaml @@ -45,10 +45,6 @@ properties: items: - description: MIPI D-PHY slave reset - reset-names: - items: - - const: mrst - power-domains: true phy-supply: @@ -150,7 +146,6 @@ required: - clocks - clock-names - resets - - reset-names - power-domains - phy-supply - ports @@ -174,8 +169,7 @@ examples: clock-frequency = <166000000>; power-domains = <&pgc_mipi_phy>; phy-supply = <®_1p0d>; - resets = <&src IMX7_RESET_MIPI_PHY_MRST>; - reset-names = "mrst"; + resets = <&src IMX7_RESET_MIPI_PHY_SRST>; fsl,csis-hs-settle = <3>; ports { From patchwork Tue Jan 5 15:28:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 357039 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63928C433E9 for ; Tue, 5 Jan 2021 15:39:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 31D7F22AAD for ; Tue, 5 Jan 2021 15:39:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726096AbhAEPiq (ORCPT ); Tue, 5 Jan 2021 10:38:46 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:38190 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726957AbhAEPiq (ORCPT ); Tue, 5 Jan 2021 10:38:46 -0500 Received: from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 9239F1BEF; Tue, 5 Jan 2021 16:30:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1609860617; bh=QijKmJDIjOo7MKVny8M7NUeZo6zYDFwqShZIVrpphus=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=G3nTtbEb4p+HJQEX16g6HeL+Qv+xBUbsrb/FecMQUZPlAtrNMOp9HPm4/vrviJDoN lAR5dUBe+jhxZmURhMHyS4L8e5/MuU9Tdlh3Y91cKWxbMLR0ts3IGwZC0jtgvFeU7f xaUEUJ+rp1k6LRthMjNRBQj+JUQETJRJWGO3ycPg= From: Laurent Pinchart To: linux-media@vger.kernel.org Cc: Rui Miguel Silva , Steve Longerbeam , Philipp Zabel , Ezequiel Garcia , Rob Herring , devicetree@vger.kernel.org Subject: [PATCH 59/75] dt-bindings: media: fsl, imx7-mipi-csi2: Drop fsl, csis-hs-settle property Date: Tue, 5 Jan 2021 17:28:36 +0200 Message-Id: <20210105152852.5733-60-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210105152852.5733-1-laurent.pinchart@ideasonboard.com> References: <20210105152852.5733-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The fsl,csis-hs-settle property isn't used by the driver anymore. Drop it. Signed-off-by: Laurent Pinchart --- .../devicetree/bindings/media/fsl,imx7-mipi-csi2.yaml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/Documentation/devicetree/bindings/media/fsl,imx7-mipi-csi2.yaml b/Documentation/devicetree/bindings/media/fsl,imx7-mipi-csi2.yaml index d8918ba3b06c..656aac67470d 100644 --- a/Documentation/devicetree/bindings/media/fsl,imx7-mipi-csi2.yaml +++ b/Documentation/devicetree/bindings/media/fsl,imx7-mipi-csi2.yaml @@ -54,10 +54,6 @@ properties: description: The desired external clock ("wrap") frequency, in Hz default: 166000000 - fsl,csis-hs-settle: - $ref: /schemas/types.yaml#/definitions/uint32 - description: HS-SETTLE time (unit unknown) - ports: # See ./video-interfaces.txt for details type: object