From patchwork Tue Feb 20 11:05:22 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 128866 Delivered-To: patch@linaro.org Received: by 10.46.124.24 with SMTP id x24csp4509397ljc; Tue, 20 Feb 2018 03:05:54 -0800 (PST) X-Google-Smtp-Source: AH8x225KLzuUGhzujd58HInAnnTCTtrWAjBm+UVMXC/LRVXjlYcTnbcTl9y0aV889ms899DF4CER X-Received: by 10.99.102.1 with SMTP id a1mr14801798pgc.452.1519124754123; Tue, 20 Feb 2018 03:05:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519124754; cv=none; d=google.com; s=arc-20160816; b=U2+RRPXFRTyireinMUBMBZsDNcqG0ZGP+AcAPg215VL+ZgkMrqEsP4XPo66Ym2mWWV Z30oPsKN/jzFoGU0gW6/vPuLLvDRANZBYN/NN3rCkB9wijmfn+jm5tUSNToaLj3XIqos gkZPcaGdsotwRjJgB8XMGoEzrbTgVnXr+6+1Zq33IUxqzjEkkY37Ox2dYureYLlM+pRV X6dfQN3A9Ev0EJC/TSoQdki5kyn9GBSBT6WKeUdqbGUXcuzzoR/NEYT4oK6syplNEM+7 1cLVCS0uvI07EOay9U830pUWHorgO++OqWh6niXY3W4PyjA51G/HjqWkbX7cXhZP/rDx ErcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:dkim-signature:delivered-to:arc-authentication-results; bh=UyU+cTGwHP+Ul93l1oiW8y5U/VQtoe1Ap496FzjHyuE=; b=SfWrc6hTzo2k7Xw/+lOqnpryGouQCNRhLgupf8zZbZqUSVAzTyRbazmPPE+n9GVvJ7 TwR0ThX77bJaoeTjsaVUX7sOuaZH7ex/VTa6gK4DFPyfjQax5wWL98oWKDynkb8BoQfP eVQANCv6PXL9iBVA0Dhxp42U6kjm5UrTb4PJmaYiVxYu6Pqx6ZBoBlIvmAbKUa1n4GtE D6s21w0xavN/dwQWIa4zd3SDfktueucKe/e5wzQa9U9oDla846TquKRXWbGHZYsgD61J St6vMVuv5XWqJaU3I5i7no1kc5xzZ4wqCuOERBcOdY6DzTdF2Lany2OtHCSNYGOftkMp MrRA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=d2+MG53g; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [2001:19d0:306:5::1]) by mx.google.com with ESMTPS id g128si6606546pgc.574.2018.02.20.03.05.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Feb 2018 03:05:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) client-ip=2001:19d0:306:5::1; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=d2+MG53g; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 39B4C223C1785; Tue, 20 Feb 2018 02:59:55 -0800 (PST) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::243; helo=mail-wr0-x243.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x243.google.com (mail-wr0-x243.google.com [IPv6:2a00:1450:400c:c0c::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1C5D5223C1769 for ; Tue, 20 Feb 2018 02:59:51 -0800 (PST) Received: by mail-wr0-x243.google.com with SMTP id 34so13122780wre.13 for ; Tue, 20 Feb 2018 03:05:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=hbbmCOe2BcUU3NIfixTwhEpEH7g+2mjs1eWBBZWBKbM=; b=d2+MG53gbAsnd4g5kM9hsNN7qreGqZgXkR5riYUf2lY6AEHD5jfv7eh5RdoUjAzega 1f7l3M/kgBghIPJAriPVFPs9L5wW/VzBbwqxPJCe0sY1HVsl/KL7d2BxtYKZQhjZVlSG qt9tegUxTckYzEYZl25yyn9QFAAh6apobCuis= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=hbbmCOe2BcUU3NIfixTwhEpEH7g+2mjs1eWBBZWBKbM=; b=WH1AB1/kjCNrktAVezpLymC13KLAQ9IfZgHYC2pIolgaCq4G53OR5ppdGshKDMRsQ5 lvyZeCoog4XbqtZWGXUU95B0vDxYtjEhMwlGt0cUaK1kgIsQb6eTxBrXh3My7ZCvFwvH FySSoYl4ANjk7KNL8GG/VYtebc64Kf9JysJqr6BEmOif4hx+B3qj68e6jpp6lVdxU7AM FCwext0Lr5dnBwgCwzLJINWcn6UMNV90I+fSy5eHVQXqGOAthd1rygcU41xHCETHVDC5 MwnlEaDVh3pwsiKmvV7baOxGs3hae24PAcZiNkl9L9+OISH4uDti4giRLq6L3MU5YcEs v+oQ== X-Gm-Message-State: APf1xPDmiTYSp11Z9Z7W78hEqBb9jB7jbxfJd2rNm2V9tb0gK0XcQ0Om dR5niJWni2RR0TTQWIX+3FoUpFPTMBk= X-Received: by 10.28.88.70 with SMTP id m67mr14954713wmb.134.1519124748263; Tue, 20 Feb 2018 03:05:48 -0800 (PST) Received: from localhost.localdomain ([105.149.187.179]) by smtp.gmail.com with ESMTPSA id u198sm7417343wmu.44.2018.02.20.03.05.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Feb 2018 03:05:47 -0800 (PST) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Tue, 20 Feb 2018 11:05:22 +0000 Message-Id: <20180220110524.9050-2-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180220110524.9050-1-ard.biesheuvel@linaro.org> References: <20180220110524.9050-1-ard.biesheuvel@linaro.org> Subject: [edk2] [PATCH 1/3] MdePkg: introduce DxeRuntimeDebugLibSerialPort X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ruiyu.ni@intel.com, Ard Biesheuvel , afish@apple.com, leif.lindholm@linaro.org, liming.gao@intel.com, michael.d.kinney@intel.com, lersek@redhat.com, star.zeng@intel.com MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" Introduce a variant of BaseDebugLibSerialPort that behaves correctly wrt to use of the serial port after ExitBootServices(). Also, it uses fixed PCDs for all the parameterized values so that no calls into PcdLib are made at runtime. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- MdePkg/Library/DxeRuntimeDebugLibSerialPort/DebugLib.c | 342 ++++++++++++++++++++ MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf | 46 +++ MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.uni | 21 ++ 3 files changed, 409 insertions(+) -- 2.11.0 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel diff --git a/MdePkg/Library/DxeRuntimeDebugLibSerialPort/DebugLib.c b/MdePkg/Library/DxeRuntimeDebugLibSerialPort/DebugLib.c new file mode 100644 index 000000000000..d18267d91322 --- /dev/null +++ b/MdePkg/Library/DxeRuntimeDebugLibSerialPort/DebugLib.c @@ -0,0 +1,342 @@ +/** @file + DXE runtime Debug library instance based on Serial Port library. + It uses PrintLib to send debug messages to serial port device. + + NOTE: If the Serial Port library enables hardware flow control, then a call + to DebugPrint() or DebugAssert() may hang if writes to the serial port are + being blocked. This may occur if a key(s) are pressed in a terminal emulator + used to monitor the DEBUG() and ASSERT() messages. + + Copyright (c) 2006 - 2011, Intel Corporation. All rights reserved.
+ Copyright (c) 2018, Linaro, Ltd. All rights reserved.
+ + This program and the accompanying materials + are licensed and made available under the terms and conditions of the BSD License + which accompanies this distribution. The full text of the license may be found at + http://opensource.org/licenses/bsd-license.php. + + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. + +**/ + +#include +#include +#include +#include +#include +#include +#include +#include + +STATIC EFI_EVENT mEfiExitBootServicesEvent; +STATIC BOOLEAN mEfiAtRuntime; + +// +// Define the maximum debug and assert message length that this library supports +// +#define MAX_DEBUG_MESSAGE_LENGTH 0x100 + +/** + Set AtRuntime flag as TRUE after ExitBootServices. + + @param[in] Event The Event that is being processed. + @param[in] Context The Event Context. + +**/ +STATIC +VOID +EFIAPI +RuntimeLibExitBootServicesEvent ( + IN EFI_EVENT Event, + IN VOID *Context + ) +{ + mEfiAtRuntime = TRUE; +} + +/** + The constructor function initialize the Serial Port Library + + @retval EFI_SUCCESS The constructor always returns RETURN_SUCCESS. + +**/ +EFI_STATUS +EFIAPI +DxeRuntimeDebugLibSerialPortConstructor ( + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE *SystemTable + ) +{ + EFI_STATUS Status; + + Status = SerialPortInitialize (); + if (EFI_ERROR (Status)) { + return Status; + } + + return SystemTable->BootServices->CreateEventEx ( + EVT_NOTIFY_SIGNAL, + TPL_NOTIFY, + RuntimeLibExitBootServicesEvent, + NULL, + &gEfiEventExitBootServicesGuid, + &mEfiExitBootServicesEvent); +} + +/** + Prints a debug message to the debug output device if the specified error level + is enabled. + + If any bit in ErrorLevel is also set in DebugPrintErrorLevelLib function + GetDebugPrintErrorLevel (), then print the message specified by Format and the + associated variable argument list to the debug output device. + + If Format is NULL, then ASSERT(). + + @param ErrorLevel The error level of the debug message. + @param Format Format string for the debug message to print. + @param ... Variable argument list whose contents are accessed + based on the format string specified by Format. + +**/ +VOID +EFIAPI +DebugPrint ( + IN UINTN ErrorLevel, + IN CONST CHAR8 *Format, + ... + ) +{ + CHAR8 Buffer[MAX_DEBUG_MESSAGE_LENGTH]; + VA_LIST Marker; + + if (mEfiAtRuntime) { + return; + } + + // + // Check driver debug mask value and global mask + // + if ((ErrorLevel & GetDebugPrintErrorLevel ()) == 0) { + return; + } + + // + // Convert the DEBUG() message to an ASCII String + // + VA_START (Marker, Format); + AsciiVSPrint (Buffer, sizeof (Buffer), Format, Marker); + VA_END (Marker); + + // + // Send the print string to a Serial Port + // + SerialPortWrite ((UINT8 *)Buffer, AsciiStrLen (Buffer)); +} + + +/** + Prints an assert message containing a filename, line number, and description. + This may be followed by a breakpoint or a dead loop. + + Print a message of the form "ASSERT (): \n" + to the debug output device. If DEBUG_PROPERTY_ASSERT_BREAKPOINT_ENABLED bit + of PcdDebugProperyMask is set then CpuBreakpoint() is called. Otherwise, if + DEBUG_PROPERTY_ASSERT_DEADLOOP_ENABLED bit of PcdDebugProperyMask is set then + CpuDeadLoop() is called. If neither of these bits are set, then this function + returns immediately after the message is printed to the debug output device. + DebugAssert() must actively prevent recursion. If DebugAssert() is called + while processing another DebugAssert(), then DebugAssert() must return + immediately. + + If FileName is NULL, then a string of "(NULL) Filename" is printed. + If Description is NULL, then a string of "(NULL) Description" is + printed. + + @param FileName The pointer to the name of the source file that generated + the assert condition. + @param LineNumber The line number in the source file that generated the + assert condition + @param Description The pointer to the description of the assert condition. + +**/ +VOID +EFIAPI +DebugAssert ( + IN CONST CHAR8 *FileName, + IN UINTN LineNumber, + IN CONST CHAR8 *Description + ) +{ + CHAR8 Buffer[MAX_DEBUG_MESSAGE_LENGTH]; + + if (!mEfiAtRuntime) { + // + // Generate the ASSERT() message in Ascii format + // + AsciiSPrint (Buffer, sizeof (Buffer), "ASSERT [%a] %a(%d): %a\n", + gEfiCallerBaseName, FileName, LineNumber, Description); + + // + // Send the print string to the Console Output device + // + SerialPortWrite ((UINT8 *)Buffer, AsciiStrLen (Buffer)); + } + + // + // Generate a Breakpoint, DeadLoop, or NOP based on PCD settings + // + if ((FixedPcdGet8 (PcdDebugPropertyMask) & + DEBUG_PROPERTY_ASSERT_BREAKPOINT_ENABLED) != 0) { + CpuBreakpoint (); + } else if ((FixedPcdGet8 (PcdDebugPropertyMask) & + DEBUG_PROPERTY_ASSERT_DEADLOOP_ENABLED) != 0) { + CpuDeadLoop (); + } +} + + +/** + Fills a target buffer with PcdDebugClearMemoryValue, and returns the target + buffer. + + This function fills Length bytes of Buffer with the value specified by + PcdDebugClearMemoryValue, and returns Buffer. + + If Buffer is NULL, then ASSERT(). + If Length is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT(). + + @param Buffer The pointer to the target buffer to be filled with + PcdDebugClearMemoryValue. + @param Length The number of bytes in Buffer to fill with + PcdDebugClearMemoryValue. + + @return Buffer The pointer to the target buffer filled with + PcdDebugClearMemoryValue. + +**/ +VOID * +EFIAPI +DebugClearMemory ( + OUT VOID *Buffer, + IN UINTN Length + ) +{ + // + // SetMem() checks for the the ASSERT() condition on Length and returns Buffer + // + return SetMem (Buffer, Length, FixedPcdGet8 (PcdDebugClearMemoryValue)); +} + + +/** + Returns TRUE if ASSERT() macros are enabled. + + This function returns TRUE if the DEBUG_PROPERTY_DEBUG_ASSERT_ENABLED bit of + PcdDebugProperyMask is set. Otherwise FALSE is returned. + + @retval TRUE The DEBUG_PROPERTY_DEBUG_ASSERT_ENABLED bit of + PcdDebugProperyMask is set. + @retval FALSE The DEBUG_PROPERTY_DEBUG_ASSERT_ENABLED bit of + PcdDebugProperyMask is clear. + +**/ +BOOLEAN +EFIAPI +DebugAssertEnabled ( + VOID + ) +{ + return (FixedPcdGet8 (PcdDebugPropertyMask) & + DEBUG_PROPERTY_DEBUG_ASSERT_ENABLED) != 0; +} + + +/** + Returns TRUE if DEBUG() macros are enabled. + + This function returns TRUE if the DEBUG_PROPERTY_DEBUG_PRINT_ENABLED bit of + PcdDebugProperyMask is set. Otherwise FALSE is returned. + + @retval TRUE The DEBUG_PROPERTY_DEBUG_PRINT_ENABLED bit of + PcdDebugProperyMask is set. + @retval FALSE The DEBUG_PROPERTY_DEBUG_PRINT_ENABLED bit of + PcdDebugProperyMask is clear. + +**/ +BOOLEAN +EFIAPI +DebugPrintEnabled ( + VOID + ) +{ + return (FixedPcdGet8 (PcdDebugPropertyMask) & + DEBUG_PROPERTY_DEBUG_PRINT_ENABLED) != 0; +} + + +/** + Returns TRUE if DEBUG_CODE() macros are enabled. + + This function returns TRUE if the DEBUG_PROPERTY_DEBUG_CODE_ENABLED bit of + PcdDebugProperyMask is set. Otherwise FALSE is returned. + + @retval TRUE The DEBUG_PROPERTY_DEBUG_CODE_ENABLED bit of + PcdDebugProperyMask is set. + @retval FALSE The DEBUG_PROPERTY_DEBUG_CODE_ENABLED bit of + PcdDebugProperyMask is clear. + +**/ +BOOLEAN +EFIAPI +DebugCodeEnabled ( + VOID + ) +{ + return (FixedPcdGet8 (PcdDebugPropertyMask) & + DEBUG_PROPERTY_DEBUG_CODE_ENABLED) != 0; +} + + +/** + Returns TRUE if DEBUG_CLEAR_MEMORY() macro is enabled. + + This function returns TRUE if the DEBUG_PROPERTY_CLEAR_MEMORY_ENABLED bit of + PcdDebugProperyMask is set. Otherwise FALSE is returned. + + @retval TRUE The DEBUG_PROPERTY_CLEAR_MEMORY_ENABLED bit of + PcdDebugProperyMask is set. + @retval FALSE The DEBUG_PROPERTY_CLEAR_MEMORY_ENABLED bit of + PcdDebugProperyMask is clear. + +**/ +BOOLEAN +EFIAPI +DebugClearMemoryEnabled ( + VOID + ) +{ + return (FixedPcdGet8 (PcdDebugPropertyMask) & + DEBUG_PROPERTY_CLEAR_MEMORY_ENABLED) != 0; +} + +/** + Returns TRUE if any one of the bit is set both in ErrorLevel and + PcdFixedDebugPrintErrorLevel. + + This function compares the bit mask of ErrorLevel and + PcdFixedDebugPrintErrorLevel. + + @retval TRUE Current ErrorLevel is supported. + @retval FALSE Current ErrorLevel is not supported. + +**/ +BOOLEAN +EFIAPI +DebugPrintLevelEnabled ( + IN CONST UINTN ErrorLevel + ) +{ + return (ErrorLevel & FixedPcdGet32 (PcdFixedDebugPrintErrorLevel)) != 0; +} diff --git a/MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf b/MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf new file mode 100644 index 000000000000..9f300f4f1b12 --- /dev/null +++ b/MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf @@ -0,0 +1,46 @@ +## @file +# +# Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.
+# Copyright (c) 2018, Linaro, Ltd. All rights reserved.
+# +# This program and the accompanying materials +# are licensed and made available under the terms and conditions of the BSD License +# which accompanies this distribution. The full text of the license may be found at +# http://opensource.org/licenses/bsd-license.php. +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. +# +# +## + +[Defines] + INF_VERSION = 0x00010005 + BASE_NAME = DxeRuntimeDebugLibSerialPort + MODULE_UNI_FILE = DxeRuntimeDebugLibSerialPort.uni + FILE_GUID = 9D914E2F-7CCB-41DB-8E74-9AFF8F3BBFBF + MODULE_TYPE = DXE_RUNTIME_DRIVER + VERSION_STRING = 1.0 + LIBRARY_CLASS = DebugLib + CONSTRUCTOR = DxeRuntimeDebugLibSerialPortConstructor + +[Sources] + DebugLib.c + +[Packages] + MdePkg/MdePkg.dec + +[LibraryClasses] + BaseLib + BaseMemoryLib + DebugPrintErrorLevelLib + PcdLib + PrintLib + SerialPortLib + +[Guids] + gEfiEventExitBootServicesGuid + +[FixedPcd] + gEfiMdePkgTokenSpaceGuid.PcdDebugClearMemoryValue ## SOMETIMES_CONSUMES + gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask ## CONSUMES + gEfiMdePkgTokenSpaceGuid.PcdFixedDebugPrintErrorLevel ## CONSUMES diff --git a/MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.uni b/MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.uni new file mode 100644 index 000000000000..cd65515c4177 --- /dev/null +++ b/MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.uni @@ -0,0 +1,21 @@ +// /** @file +// Instance of Debug Library based on Serial Port Library. +// +// It uses Print Library to produce formatted output strings to seiral port device. +// +// Copyright (c) 2006 - 2014, Intel Corporation. All rights reserved.
+// +// This program and the accompanying materials +// are licensed and made available under the terms and conditions of the BSD License +// which accompanies this distribution. The full text of the license may be found at +// http://opensource.org/licenses/bsd-license.php. +// THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, +// WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. +// +// **/ + + +#string STR_MODULE_ABSTRACT #language en-US "Instance of Debug Library based on Serial Port Library" + +#string STR_MODULE_DESCRIPTION #language en-US "It uses Print Library to produce formatted output strings to a serial port device." + From patchwork Tue Feb 20 11:05:23 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 128867 Delivered-To: patch@linaro.org Received: by 10.46.124.24 with SMTP id x24csp4509442ljc; Tue, 20 Feb 2018 03:05:57 -0800 (PST) X-Google-Smtp-Source: AH8x225vLpe6jVL31HIDe3IcNaeQToHZuQM/jg/yC+e97yLek+ouPMlAQ++Ey0gbWabbvh2W36bm X-Received: by 2002:a17:902:ab85:: with SMTP id f5-v6mr17462565plr.199.1519124756799; Tue, 20 Feb 2018 03:05:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519124756; cv=none; d=google.com; s=arc-20160816; b=Hq99iVfnJX/iMCUI01MwhHUgivGs0jiLrEqSWtCJnul/yE530jPvPbIsCERnyWguF5 6lzVhfYfkG/OZWrethfQfIpeTLGINXjmlT1xK6xqjmdnSAzi4Mc4KzvdSs8vE/tpH7Sl wigfStH0WP6XNywsR3nQEe88akO/8q/JrSp/kgEJs0bCPih5KqhoxCQDtM6HDOdbqnxa txxHgeFjqMsAPfXxwCFlRG1LMfL+LTiEFoq8ooERQh+Nc0ebXvcZRR8ZjT28ujpjgD4/ x/4DvvN3chrn9ASTETfLjTJY1yWZOkC83gABHE3TMMWmlPyesF7eQl3mJQTl32Qp4EB6 jsJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:dkim-signature:delivered-to:arc-authentication-results; bh=2a+U3gSqh38zw6GggIk5YNloTm+jhqDmFY3Un+Ncf4U=; b=0u1eSZ4r1VMWK9QBOC+rVrY0Hz9ke5uDG17b6hgaTpUtKvi3ePbpaJgaWPtdncT7SE zu5MXtpTGShr8aWu0Ef4U+AQ8oWG+5t6SQbK0Q0m/ZEr2jlGbiu0Fblhae3FuOl/0CHp r3OuNHgCmWP4zjUww3jl0EJmCJfTkfuwYI8fG7cpLaETIVV4yRJ49IjsFyZgAfsxXftd Z11L3n29PaaHXLV7f+Q9iCh/Ql10mKgWc+9FKPMm2gbLooJhUrwRp3opw/7M5xDBQZwx TOG5V64YbnWaOQyiZXyhhW8dPXnt04jCBlhfTutrJJV+rGPKiS7kJgBwTxOC0QlYqvRl pZjA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Ghq6/+aO; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [2001:19d0:306:5::1]) by mx.google.com with ESMTPS id i66si14215217pgc.445.2018.02.20.03.05.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Feb 2018 03:05:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) client-ip=2001:19d0:306:5::1; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Ghq6/+aO; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 9C60F223C1796; Tue, 20 Feb 2018 02:59:56 -0800 (PST) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::241; helo=mail-wr0-x241.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x241.google.com (mail-wr0-x241.google.com [IPv6:2a00:1450:400c:c0c::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 98869223C1784 for ; Tue, 20 Feb 2018 02:59:54 -0800 (PST) Received: by mail-wr0-x241.google.com with SMTP id s5so13169764wra.0 for ; Tue, 20 Feb 2018 03:05:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=tYExiMSxYW71Xb5sR9W/1s9+kNWzOCuuvo/1d+tfcI8=; b=Ghq6/+aOv48y6RGmrPodVbKlJBCrj2SLj2wZwLUxBNVmdxUylLxRf3S2yBk8iQLouc qKpd7YvUB7W/4t0d1s6uyK+Uc+69pH3AKW6sMuxrmBF7G80rOK9tSsLBw6VIhsRh4c5J x9eQbrzqWwe549cGzdcYLTJMoTsm1KtzsOXgg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=tYExiMSxYW71Xb5sR9W/1s9+kNWzOCuuvo/1d+tfcI8=; b=iHLmqhlmjQ6Vft0m+DVsF+rKfXlW5jLnYpElmmaG6GcFt3NXCzvjUtEnNewVHzzTzS H+7U6pnL9NcuZ15z2w+OT6G9bAS7g7r7MVGF1/3sK7bcXNvFZneeXTsLLSHfzIewfMK7 ObQ2un2TOhCBDsD2jgEh8g04ZFJjyrnBWyPSokL/Asx9qNW1u1eQSJRyG7/GwFvS2wTc cFA0KyR2J4M08UZHpIhOLOV0Tg9reaQntRFFNgyPsFunNjwbwJzwbMfq1SDdHyqVibTz ZyXhbMtbzkIOOSPR0jDwciTc4DZW850PM/6UGXc01o5M4b1LKnrR7A8qsJHFOGtk6K1j x/Xg== X-Gm-Message-State: APf1xPCtmNjudegXloRj3+PNm5CexsEm9SW6PsYCPdupc9dl6Lv5Jrmq f3N5uWPWKHStui91vFz+T76aVh9T0cw= X-Received: by 10.223.150.41 with SMTP id b38mr15815693wra.229.1519124750511; Tue, 20 Feb 2018 03:05:50 -0800 (PST) Received: from localhost.localdomain ([105.149.187.179]) by smtp.gmail.com with ESMTPSA id u198sm7417343wmu.44.2018.02.20.03.05.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Feb 2018 03:05:49 -0800 (PST) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Tue, 20 Feb 2018 11:05:23 +0000 Message-Id: <20180220110524.9050-3-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180220110524.9050-1-ard.biesheuvel@linaro.org> References: <20180220110524.9050-1-ard.biesheuvel@linaro.org> Subject: [edk2] [PATCH 2/3] ArmVirtPkg: switch to DXE runtime version of DebugLib where appropriate X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ruiyu.ni@intel.com, Ard Biesheuvel , afish@apple.com, leif.lindholm@linaro.org, liming.gao@intel.com, michael.d.kinney@intel.com, lersek@redhat.com, star.zeng@intel.com MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" Switch all users of ArmVirt.dsc.inc to the new DebugLib implementation that was created especially for DXE_RUNTIME_DRIVER modules, ensuring that DEBUG() calls do not touch the UART at runtime. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- ArmVirtPkg/ArmVirt.dsc.inc | 3 +++ 1 file changed, 3 insertions(+) -- 2.11.0 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel Reviewed-by: Laszlo Ersek diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc index 0cb48f08e9bf..cde514958da2 100644 --- a/ArmVirtPkg/ArmVirt.dsc.inc +++ b/ArmVirtPkg/ArmVirt.dsc.inc @@ -231,6 +231,9 @@ [LibraryClasses.common.UEFI_DRIVER] [LibraryClasses.common.DXE_RUNTIME_DRIVER] MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf +!if $(TARGET) != RELEASE + DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf +!endif !if $(SECURE_BOOT_ENABLE) == TRUE BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf From patchwork Tue Feb 20 11:05:24 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 128868 Delivered-To: patch@linaro.org Received: by 10.46.124.24 with SMTP id x24csp4509495ljc; Tue, 20 Feb 2018 03:05:59 -0800 (PST) X-Google-Smtp-Source: AH8x225LlR3DEczLNl3yln/yyzmyUZUOpoFrlzOyeqB91BZqlue3wnE7xsg2Sp4QDcNj6DLz0HKo X-Received: by 10.98.55.66 with SMTP id e63mr17962902pfa.102.1519124759360; Tue, 20 Feb 2018 03:05:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519124759; cv=none; d=google.com; s=arc-20160816; b=hFBlYBy4Wc2T3YWIYJGMbBqNks2MPi2Y0ybAyoGYhTdYfLvrcpp3i+uKpnzeCm1A5B xzBL+Pn+yWTlH51KAQRFrxAf9SbYVhBfmuMMzIQn+jJ7CXLcVmaP5ywTG42NE0RBm//Y 6H2kwkliJHXTJL7J4lj2zrgxw7CFpJG+P+MNEhZJ6UIoGlPe6vIxhvPZIkOMoUrKWgeE s1TY7QwijyGoDhURNiobSbjBTvpq7d7GSz1OPB/GlZG7za/IUoc58VSh9CyMk4Fd80aV ICJdLQJxy0mcHDcPdV4u1uN3r1uE5VPylC3Cr8NrNcUkEkpmbwz+2zmOlGwuEC2rJ+cn SigQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:dkim-signature:delivered-to:arc-authentication-results; bh=fgwL4VUdBClKNiZ2Ar6KnMWhnf1z2p7s9v/9t2ydxsA=; b=1I0vt826NWoQViP/bjl6qQsDG4m3E4bWIoVHZlqW0E1H9q+18uM0aBwHdvrDsChqq/ fziAl57r2GLBJCNWXAPIS26YilQvXjbl+Em3L9Lj6q6FXzoND8/E/0//cOv6nK0V0O3u SRCIJj2Z7d7+XMbSGDdwwiSw021UjymnodjDdmmN563GCBDUKzrU9QySXEuHlLvmBNc7 jwkzh5KLGtjb4UTfdlz/QKgz0n0vuTtabZ67oFpRotfkMTpAVWjcJ8YxnyQqfR1Y2xkM KBdSnKyijXQk3lWtoJxhorzsaj0hrPXXXC298W7XroEswcfqYFY/XmCbeVocefZaee8p fyHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=LNR5YfCP; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [198.145.21.10]) by mx.google.com with ESMTPS id 1-v6si1117404plb.601.2018.02.20.03.05.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Feb 2018 03:05:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) client-ip=198.145.21.10; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=LNR5YfCP; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 1EDF1223C179A; Tue, 20 Feb 2018 02:59:58 -0800 (PST) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::243; helo=mail-wr0-x243.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x243.google.com (mail-wr0-x243.google.com [IPv6:2a00:1450:400c:c0c::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 13A10223C1792 for ; Tue, 20 Feb 2018 02:59:56 -0800 (PST) Received: by mail-wr0-x243.google.com with SMTP id u49so8501040wrc.10 for ; Tue, 20 Feb 2018 03:05:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=UpZyYyU/u9JG0+cA7/Xx5IxGvkLdqbO5Ptp04Y2o1b0=; b=LNR5YfCPKL6+cc+VglurHqRxLwmctJfrZKFsi1Pcz8PWJurjzBhk2iwVWeLaXO8rvA hqukVwS74WIpwXEYbNBfQw6cDrhe99/j3YfRbvhe/y8Xd6EigNnTnJCYeaMwxrR37GxT 4YjFyLGk8woZLJ5/5PRMZAM+dhuv+hvBu4vCQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=UpZyYyU/u9JG0+cA7/Xx5IxGvkLdqbO5Ptp04Y2o1b0=; b=Bns3Wzp2N2ycIWaTBHVN18Ih2lFG/0Fp+Xq7dvsaaHPzE+cj8ijm2zgv9pvc9jgCoJ FXmvdJMCv8Ueqc+r2P/pV8Tt1lfNI/EwpDOApssMXQkPhdYu7TwAuQreZOWBda4w2dtL mAQXjGCdIsRWgEFJnyD1b+Hb/6tfWHyRU2m3ckIOb0h/8ulPJn6M/N8Q0HkEoRUIi+4E TZupsPwyHLlLn+/tSWxcC/RbpYotgRxGenv+7l6aeRBJsbMnDq7m0lBIIFp2LxsOx/DL kW1UIpW3s2YHoW5XCikF2LzueHF6ZELokUzaDas1Zqj4sxtpwFbXXS016iJo3E8ujhfM XKtg== X-Gm-Message-State: APf1xPAPZj/4MNicaKgA5KGyfxAZCJeGEsBXfYBSvocHaA4v5d8j5DjM S46O79F74otBefqh8Ahy8fpV8lYthqc= X-Received: by 10.223.186.145 with SMTP id p17mr14645280wrg.263.1519124752833; Tue, 20 Feb 2018 03:05:52 -0800 (PST) Received: from localhost.localdomain ([105.149.187.179]) by smtp.gmail.com with ESMTPSA id u198sm7417343wmu.44.2018.02.20.03.05.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Feb 2018 03:05:52 -0800 (PST) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Tue, 20 Feb 2018 11:05:24 +0000 Message-Id: <20180220110524.9050-4-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180220110524.9050-1-ard.biesheuvel@linaro.org> References: <20180220110524.9050-1-ard.biesheuvel@linaro.org> Subject: [edk2] [PATCH 3/3] MdePkg/BaseDebugLibSerialPort: blacklist for use by DXE runtime drivers X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ruiyu.ni@intel.com, Ard Biesheuvel , afish@apple.com, leif.lindholm@linaro.org, liming.gao@intel.com, michael.d.kinney@intel.com, lersek@redhat.com, star.zeng@intel.com MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" BaseDebugLibSerialPort is not suitable for use by DXE_RUNTIME_DRIVER modules, so blacklist it for use by such modules. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.11.0 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel Reviewed-by: Laszlo Ersek diff --git a/MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf b/MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf index 823511b22f6b..25da1fb9363a 100644 --- a/MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf +++ b/MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf @@ -21,7 +21,7 @@ [Defines] FILE_GUID = BB83F95F-EDBC-4884-A520-CD42AF388FAE MODULE_TYPE = BASE VERSION_STRING = 1.0 - LIBRARY_CLASS = DebugLib + LIBRARY_CLASS = DebugLib|SEC PEI_CORE PEIM DXE_CORE DXE_DRIVER DXE_SMM_DRIVER DXE_SAL_DRIVER UEFI_DRIVER UEFI_APPLICATION SMM_CORE MM_STANDALONE MM_CORE_STANDALONE CONSTRUCTOR = BaseDebugLibSerialPortConstructor #