From patchwork Fri Jan 8 13:21:13 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: wangyunjian X-Patchwork-Id: 359539 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54BC1C433DB for ; Fri, 8 Jan 2021 13:22:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E9395239FF for ; Fri, 8 Jan 2021 13:22:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726468AbhAHNWK (ORCPT ); Fri, 8 Jan 2021 08:22:10 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:10423 "EHLO szxga06-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725791AbhAHNWJ (ORCPT ); Fri, 8 Jan 2021 08:22:09 -0500 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4DC3d50QXrzj41q; Fri, 8 Jan 2021 21:20:41 +0800 (CST) Received: from localhost (10.174.243.127) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.498.0; Fri, 8 Jan 2021 21:21:17 +0800 From: wangyunjian To: CC: , , , , Yunjian Wang Subject: [PATCH net-next] devlink: fix return of uninitialized variable err Date: Fri, 8 Jan 2021 21:21:13 +0800 Message-ID: <1610112073-23424-1-git-send-email-wangyunjian@huawei.com> X-Mailer: git-send-email 1.9.5.msysgit.1 MIME-Version: 1.0 X-Originating-IP: [10.174.243.127] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Yunjian Wang There is a potential execution path in which variable err is returned without being properly initialized previously. Fix this by initializing variable err to 0. Addresses-Coverity: ("Uninitialized scalar variable") Fixes: 1db64e8733f6 ("devlink: Add devlink formatted message (fmsg) API") Signed-off-by: Yunjian Wang --- net/core/devlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/devlink.c b/net/core/devlink.c index ee828e4b1007..470215cd60b5 100644 --- a/net/core/devlink.c +++ b/net/core/devlink.c @@ -5699,7 +5699,7 @@ devlink_fmsg_prepare_skb(struct devlink_fmsg *fmsg, struct sk_buff *skb, struct devlink_fmsg_item *item; struct nlattr *fmsg_nlattr; int i = 0; - int err; + int err = 0; fmsg_nlattr = nla_nest_start_noflag(skb, DEVLINK_ATTR_FMSG); if (!fmsg_nlattr)