From patchwork Wed Feb 21 12:54:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: gaurav jindal X-Patchwork-Id: 129060 Delivered-To: patch@linaro.org Received: by 10.46.124.24 with SMTP id x24csp587993ljc; Wed, 21 Feb 2018 04:54:16 -0800 (PST) X-Google-Smtp-Source: AH8x2274QZXS9qTx9M2cL/qZWBOXrT1hVde0E4/LzrRpROHN+p6eVqIxsoYVKpMNXRqaiSWVFP3i X-Received: by 10.99.180.3 with SMTP id s3mr2654647pgf.258.1519217656733; Wed, 21 Feb 2018 04:54:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519217656; cv=none; d=google.com; s=arc-20160816; b=hU9DUQ6rA4IQpOGoi8wvkbm2Yi17/sW6kBk2Uu5UHOO/+0dtTJfMdAnFTZf4mvjLw2 3V0+BNFkDLMVi3cE6WP47oAKkGTvC01v9gBLXwdfKz5tl7ec+RnGnDNOyEI76rLW+i4E B5sPLWOvSXk01bzAWj9mwmZcvNf6RQYoSdhH4DXGJQCkWOjO83jxajuPnPJ9jpfCm4vQ wV2PLXBnaWSZsa44Jsz1337HuPpOqVLO2wVHdcH/aQZUWDCFnku581sYQuFwJhummWss zEtLy1PHWRYd10SKFvwBSiAkDmx/2uJ8sa4WYPQ3moeA4exaCtm/JhzlHKYlnrZocu2V /ijQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=oJH5Z3IgSLPJDwIe+bi9SYCuag8/zMeIuKJLCWNABxs=; b=y8hlFfqh8rv2vppqsavxYxvkcWlEGXiyjO8AU5u8L8AjbNDB8N7bxxt4tcQ+1+rhdE nmDF8FWlvTt+qdPTvnG+J5iPz+SD9y0o6m639eRgr82QFEPwrMHIx4ISO0/9QAwhrcOS x0PQXozYyGa2m23CP5S5ZMM0EJx28kbuo9ZIIQ10cAUA32O920OVhyyJ6W/HnFG15sQz r6DofdWD1bdRuIqStA3Vd5Szww1MhT/I+AauoUr564pxhk+akrbLe64huTtY9u6rIBiZ Mhr3Ir+1ax1BfFWIHxm3Nh3xd6YLPszWtlxrAWFri2ccIAHOpukJqcEGZ1xmHU2n8v/e 1KKg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=iIYt67hF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d4si1545991pgq.337.2018.02.21.04.54.16; Wed, 21 Feb 2018 04:54:16 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=iIYt67hF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932593AbeBUMyN (ORCPT + 28 others); Wed, 21 Feb 2018 07:54:13 -0500 Received: from mail-pf0-f193.google.com ([209.85.192.193]:38366 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752961AbeBUMyL (ORCPT ); Wed, 21 Feb 2018 07:54:11 -0500 Received: by mail-pf0-f193.google.com with SMTP id d26so610013pfn.5 for ; Wed, 21 Feb 2018 04:54:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=oJH5Z3IgSLPJDwIe+bi9SYCuag8/zMeIuKJLCWNABxs=; b=iIYt67hFkpvF3VJPzy5lC6+dDuaXcUYKs0cyS8+7k+5BwqxbdrrRGodmYDKehRI88+ eKdxeNOoPx1FhVbDSSzSeNs4lexq9WCzlDKPXDy57fy+7bqvgVWLdoMCybZCmpcfkpFi Snf4oNODjEWrw8aiouMkcA+IXi5hehCbKvcpHHgSwNgB8dZ8FgtyFn/mtNm+X6QWMxA0 ZBmasBwx0QwgRNM7GpkS0fI3maw8xtr1ahC6itn6DLKIn1PCE1LleWos5bQv8pvDS7BV B7ivJtDhwSQgSl3KGe7pKvxl0OHUZbddkWREsnX7XmdO7FeUm5hN0J2fOUoi8kpZjJtb 36EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=oJH5Z3IgSLPJDwIe+bi9SYCuag8/zMeIuKJLCWNABxs=; b=mXVFh1GXRYIDZj34MnWB2y9MslqeTkpu9cMXerlF4HFItoEfPWOzoZk2lRuKFKVeVe nLSISOJoadYkAH2uWu4tMvDohqiVMyCTGr/PlvyPZf6fY4MLQ3m+H5LlvRmrvzcWO0LA G0Os3DB7HJ7ZZ9/9uk15NY/e1OQALBXouFrx/F1xEtduvjnpIThJCeuLPFg/+g5EoH6p Dj08WE1Dte5NDBfucxti3VuqgXnhX8EAVZdTr98p+Uj8/1AfGRGKCc6UB7NSFigCwgsP 0JyJEt44+g8/wTfqOT+jj+/ploglp5d5wCdhhkktjlsvqm6aFzdOe7hMT0JvhEzkJ/wj gW4Q== X-Gm-Message-State: APf1xPCGOeP9mjRQs4gUMBDRO2d6oxJb+22apCFB6xcySN7oGCspdYX1 /BbB0XMWctprgf0nEQf1VgI= X-Received: by 10.99.131.198 with SMTP id h189mr2694330pge.25.1519217651354; Wed, 21 Feb 2018 04:54:11 -0800 (PST) Received: from localhost ([182.73.133.58]) by smtp.gmail.com with ESMTPSA id b88sm59282339pfd.108.2018.02.21.04.54.10 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 21 Feb 2018 04:54:10 -0800 (PST) Date: Wed, 21 Feb 2018 18:24:07 +0530 From: gaurav jindal To: peterz@infradead.org, mingo@redhat.com Cc: linux-kernel@vger.kernel.org Subject: [PATCH]sched: completion: use bool in try_wait_for_completion Message-ID: <20180221125407.GA14292@gmail.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Variable ret in try_wait_for_completion can have only true/false values. Since the return type of the function is also bool, variable ret should have data type as bool in place of int. Moreover, the size of bool in many platforms is 1 byte whereas size of int is 4 bytes(though architecture dependent). Modifying the data type reduces the size consumed for the stack. Signed-off-by: Gaurav Jindal diff --git a/kernel/sched/completion.c b/kernel/sched/completion.c index 0926aef..3e15e8d 100644 --- a/kernel/sched/completion.c +++ b/kernel/sched/completion.c @@ -283,7 +283,7 @@ int __sched wait_for_completion_killable(struct completion *x) bool try_wait_for_completion(struct completion *x) { unsigned long flags; - int ret = 1; + bool ret = true; /* * Since x->done will need to be locked only @@ -292,11 +292,11 @@ bool try_wait_for_completion(struct completion *x) * return early in the blocking case. */ if (!READ_ONCE(x->done)) - return 0; + return false; spin_lock_irqsave(&x->wait.lock, flags); if (!x->done) - ret = 0; + ret = false; else if (x->done != UINT_MAX) x->done--; spin_unlock_irqrestore(&x->wait.lock, flags);