From patchwork Thu Mar 1 15:27:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sasha Levin X-Patchwork-Id: 130277 Delivered-To: patch@linaro.org Received: by 10.80.172.228 with SMTP id x91csp2952007edc; Thu, 1 Mar 2018 07:38:12 -0800 (PST) X-Google-Smtp-Source: AG47ELtUG73mAqJvf/alGuG5CR3ChaRGGBjhbhRGaytBh/c/f945PvW2gd1RegddUJKxFOaKwqzp X-Received: by 10.98.10.65 with SMTP id s62mr2351081pfi.234.1519918692415; Thu, 01 Mar 2018 07:38:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519918692; cv=none; d=google.com; s=arc-20160816; b=zAjItkxljf1cV3lkoLk/DJ0lOd77okYkLPhT3HiviElsYh5m+QjImHqALcAzg6bOjK 0Vq6UenihQwGzzurH3I9xMWvKJ3Pzajx2domMgiXU5UrPewwJooDwRWt6D34cL2fnR3o Wyh4LPXCRICkEPecwKM90CyJTkUFkB3LBBLZDo9TGHjpdKopskZNMW3LN0TMVyQTZd6z 86Ghugf9pfwRxuDuCi9/Ja4rhEDfmQIkjqOhy0sBqNrflSlEoj3PDMvO+wrcuLmiUUyR 5W4DxNr0zn8TBe6+Vq/QddKZfOdLhyEXai5HbWPJQAlUp6khM9J4afIEv5mUbQc6c78N SjmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=TyJ2VRdWYbQK9+bwubbpRa8vpmocXA58h90c97hYlfE=; b=DK8+zmR+F8/zK1knAno/Dv13moKn9Hlzo7t5yNOGrpat3+8vTU1WV9vk8+/umbzIZf kxAXuz5UD3wqYmKvrVVB8CwMIpwHB82OhntD0zrXPM9sdcJorLCR/AaZIWT7iTmwqkO4 ZP5lyjhzSvIozY0jQGkJsPTWRhpXhP+XaGP5hSkUvvAzXs22v37ONGR2b2im1ijLg609 UzHzlNU3vs+byjo82Mf6k4g55IymIYg4o4ZpjsYtjcVUeGyv1naDrAoAp6OglELduMbO l5+9qtTnDYpbQMDrq2kEkbEvm6lePM5h/9vWyCKp0OGdBbKcUqmC6PtStI59XPZ0TbEm BcWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=GQwUywQN; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d24-v6si3165005plr.615.2018.03.01.07.38.12; Thu, 01 Mar 2018 07:38:12 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=GQwUywQN; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1032269AbeCAPiI (ORCPT + 10 others); Thu, 1 Mar 2018 10:38:08 -0500 Received: from mail-by2nam03on0132.outbound.protection.outlook.com ([104.47.42.132]:24496 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1032515AbeCAPhp (ORCPT ); Thu, 1 Mar 2018 10:37:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=TyJ2VRdWYbQK9+bwubbpRa8vpmocXA58h90c97hYlfE=; b=GQwUywQNDTMSsVA99PjLxCQvSGX2F6GCkEn+/ST6Sorz+KC0Qy49oLFAunfcpkV65sKMwuj8j181nOIcJA9AGlQ+vbmSGGbo0yze8bfW/fDkUNVEvFJNZ7/Eve+xcOh9U6n0EyrUHc1f1cWNTRxB778Qd7lk4Ore1f5V1UVvSWU= Received: from DM5PR2101MB1032.namprd21.prod.outlook.com (52.132.128.13) by DM5PR2101MB1014.namprd21.prod.outlook.com (52.132.133.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.567.3; Thu, 1 Mar 2018 15:37:39 +0000 Received: from DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8063:c68a:b210:7446]) by DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8063:c68a:b210:7446%2]) with mapi id 15.20.0567.006; Thu, 1 Mar 2018 15:37:39 +0000 From: Sasha Levin To: "stable@vger.kernel.org" , "stable-commits@vger.kernel.org" CC: Arnd Bergmann , "Martin K . Petersen" , Sasha Levin Subject: [added to the 4.1 stable tree] scsi: advansys: fix build warning for PCI=n Thread-Topic: [added to the 4.1 stable tree] scsi: advansys: fix build warning for PCI=n Thread-Index: AQHTsXHCrrZrqdHQa0efacvMGHJoJw== Date: Thu, 1 Mar 2018 15:27:07 +0000 Message-ID: <20180301152116.1486-433-alexander.levin@microsoft.com> References: <20180301152116.1486-1-alexander.levin@microsoft.com> In-Reply-To: <20180301152116.1486-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DM5PR2101MB1014; 7:vkxEU7V7NaKoCKRgXufAGiddlUUxxt76iTKDKPoLLUyxsxnHws2Wu0NBG+KDvnx0fS+iQIXWXDpFmSAMmu4D76IUsomyViUm0Yg6nFoz648TNkydMJy9DN4tjBtQZPNhSqgUkUGxLK0li08q+LdMxLxfzJgEDEyAh6pNqM1uEoN3MHcRZZgIo9sj1SE2ry/miT85yC5+aipcM0VyYd/vx+nLbGZJ/pXHq3i5ZVMwdY4UpmWld7yV0kde/Vht+O87 x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: bbdf2663-f95a-4a8d-cf96-08d57f8a5dd1 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7193020); SRVR:DM5PR2101MB1014; x-ms-traffictypediagnostic: DM5PR2101MB1014: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(146099531331640); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(61425038)(6040501)(2401047)(8121501046)(5005006)(3231220)(944501228)(52105095)(3002001)(10201501046)(93006095)(93001095)(6055026)(61426038)(61427038)(6041288)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123558120)(6072148)(201708071742011); SRVR:DM5PR2101MB1014; BCL:0; PCL:0; RULEID:; SRVR:DM5PR2101MB1014; x-forefront-prvs: 05986C03E0 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(366004)(39380400002)(346002)(39860400002)(376002)(396003)(199004)(189003)(53936002)(2906002)(3280700002)(6436002)(6486002)(3846002)(6512007)(2900100001)(6116002)(2950100002)(107886003)(6666003)(72206003)(5660300001)(36756003)(10090500001)(3660700001)(14454004)(7736002)(305945005)(97736004)(1076002)(22452003)(26005)(6506007)(105586002)(86362001)(59450400001)(478600001)(68736007)(102836004)(4326008)(6346003)(54906003)(110136005)(81156014)(81166006)(86612001)(8936002)(186003)(10290500003)(8676002)(76176011)(316002)(2501003)(66066001)(25786009)(5250100002)(106356001)(99286004)(22906009); DIR:OUT; SFP:1102; SCL:1; SRVR:DM5PR2101MB1014; H:DM5PR2101MB1032.namprd21.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-message-info: E+ZoUwEW/GmJf0JETT/pYZgqWn2NPcQIhPaRNdF1QTz9/aYrPP7Qrl9UUmiUXbcGFxDZJs46NINxj7L1x1oU8AkNs/D88iaRBwNXyqBnrWnEtLspiVso6ANhB3FvfsKhPupjZJYOyj71nJuFef9II5np0kr9BFpr6pSzGWJSi9o= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: bbdf2663-f95a-4a8d-cf96-08d57f8a5dd1 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Mar 2018 15:27:07.7954 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB1014 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Arnd Bergmann This patch has been added to the 4.1 stable tree. If you have any objections, please let us know. -- 2.14.1 =============== [ Upstream commit f46e7cd36b5f2ce2bfb567e278a10ca717f85b84 ] The advansys probe function tries to handle both ISA and PCI cases, each hidden in an #ifdef when unused. This leads to a warning indicating that when PCI is disabled we could be using uninitialized data: drivers/scsi/advansys.c: In function advansys_board_found : drivers/scsi/advansys.c:11036:5: error: ret may be used uninitialized in this function [-Werror=maybe-uninitialized] drivers/scsi/advansys.c:10928:28: note: ret was declared here drivers/scsi/advansys.c:11309:8: error: share_irq may be used uninitialized in this function [-Werror=maybe-uninitialized] drivers/scsi/advansys.c:10928:6: note: share_irq was declared here This cannot happen in practice because the hardware in question only exists for PCI, but changing the code to just error out here is better for consistency and avoids the warning. Signed-off-by: Arnd Bergmann Reviewed-by: Hannes Reinecke Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/advansys.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c index ae95e347f37d..969469261353 100644 --- a/drivers/scsi/advansys.c +++ b/drivers/scsi/advansys.c @@ -11476,6 +11476,9 @@ static int advansys_board_found(struct Scsi_Host *shost, unsigned int iop, ASC_DBG(2, "AdvInitGetConfig()\n"); ret = AdvInitGetConfig(pdev, shost) ? -ENODEV : 0; +#else + share_irq = 0; + ret = -ENODEV; #endif /* CONFIG_PCI */ }