From patchwork Thu Jan 21 22:57:11 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saravana Kannan X-Patchwork-Id: 368034 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-26.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 538F0C433E0 for ; Thu, 21 Jan 2021 22:58:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0F7C223A63 for ; Thu, 21 Jan 2021 22:58:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726865AbhAUW6D (ORCPT ); Thu, 21 Jan 2021 17:58:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726780AbhAUW6A (ORCPT ); Thu, 21 Jan 2021 17:58:00 -0500 Received: from mail-qv1-xf4a.google.com (mail-qv1-xf4a.google.com [IPv6:2607:f8b0:4864:20::f4a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BCA60C0613ED for ; Thu, 21 Jan 2021 14:57:18 -0800 (PST) Received: by mail-qv1-xf4a.google.com with SMTP id m1so2537102qvp.0 for ; Thu, 21 Jan 2021 14:57:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:in-reply-to:message-id:mime-version:references:subject :from:to:cc; bh=uXaJ+OStKaU1TSDiW6h4CbV+WkJ9mG9O+r64LsV2Mn0=; b=nmTtBqSvr08bFOptKNcnSwo1YDeMJkZzF68xQek9c3YINaVsmTMySUDd2xXtLvWxWZ tjLmThb8Lfo+sR5bmrD4iEyakM5OrmBzghsoGrYqzxf/PKZd2CvPBvLi+n/9gOWDbezO 2e9kqUbeB00crKhHvlMJV9haXkGiaj0dAGkXdLm1XIxUOTvqLBMQSSF51OQ4AE9yDmwS DbvR3N1OiBNp1pOlE7TzGuGzqafNrowIP6/fhh3Uga6Z5mQKviWaB1gszrOkJgxDPtfq JgnT5LBRTxx+ipdKzvzSh1efd2VLLeCInjPxZoOTraBeMlQvCdZLHppUdXp0dv/EO2F5 x5wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=uXaJ+OStKaU1TSDiW6h4CbV+WkJ9mG9O+r64LsV2Mn0=; b=K6n1BRrKmFcdps5UFuTEJ6ZtSBxFx7xkfG/Kg9nfU6CEMwEPQViQETejt8pUH+1yeF XU6yDVYfFserYnMZtjuBUmEd83cj1MCZnnF7gB5xZVCEvJBxF7qFQus2aWR5Ss5CyFDz XltuN7BrOLQ3ookkGeYL364h9skOtiA6TX3Ql+YlMvVsL8ITCooHV1SfP+CyPaQtGBpp alwISYqpkZ4OeZBFBlZ1vte+3hq9/pDDlBsOp18bGGx4KI1w12a8vtkV1+Ik2kedllD3 smRuXXMVNeTKlOLSVS/rvuzcnGB03FhpcNkff2cvKgSaj2IODUTKuVJpQukAOH4Miq9k dcUg== X-Gm-Message-State: AOAM530W4dAmIcQuAWgAy1Q5EvFbjt33jKge0DOJl7QoCscDCB/bmTJ8 SAEsq7nyrOAb49M2IOdOf9/HlJi7GD35ynU= X-Google-Smtp-Source: ABdhPJzZsp+6O4qLnPlS0yerTYDKRtyqqRjS5GVEnuxz1NCmThN07PoGdf5AN1Xru0GR5/LMb7l7tU/mTL9+x1U= Sender: "saravanak via sendgmr" X-Received: from saravanak.san.corp.google.com ([2620:15c:2d:3:7220:84ff:fe09:fedc]) (user=saravanak job=sendgmr) by 2002:ad4:5a53:: with SMTP id ej19mr1822719qvb.61.1611269837945; Thu, 21 Jan 2021 14:57:17 -0800 (PST) Date: Thu, 21 Jan 2021 14:57:11 -0800 In-Reply-To: <20210121225712.1118239-1-saravanak@google.com> Message-Id: <20210121225712.1118239-2-saravanak@google.com> Mime-Version: 1.0 References: <20210121225712.1118239-1-saravanak@google.com> X-Mailer: git-send-email 2.30.0.280.ga3ce27912f-goog Subject: [PATCH v2 1/2] of: property: Add fw_devlink support for "gpio" and "gpios" binding From: Saravana Kannan To: Rob Herring , Frank Rowand , Greg Kroah-Hartman , Saravana Kannan Cc: linux-tegra , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Linus Walleij , Bartosz Golaszewski , Geert Uytterhoeven , Jon Hunter , Marc Zyngier , Kevin Hilman , kernel-team@android.com, Rob Herring , Thierry Reding Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org To provide backward compatibility for boards that use deprecated DT bindings, we need to add fw_devlink support for "gpio" and "gpios". We also need to ignore these properties on nodes with "gpio-hog" property because their gpio[s] are all supplied by the parent node. Cc: linux-tegra Cc: Linus Walleij Cc: Bartosz Golaszewski Cc: Greg Kroah-Hartman Cc: Geert Uytterhoeven Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default") Reviewed-by: Rob Herring Reviewed-by: Thierry Reding Tested-by: Jon Hunter Signed-off-by: Saravana Kannan Reviewed-by: Linus Walleij --- drivers/of/property.c | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/drivers/of/property.c b/drivers/of/property.c index 5f9eed79a8aa..b2ea1951d937 100644 --- a/drivers/of/property.c +++ b/drivers/of/property.c @@ -1271,6 +1271,28 @@ static struct device_node *parse_iommu_maps(struct device_node *np, return of_parse_phandle(np, prop_name, (index * 4) + 1); } +static struct device_node *parse_gpio_compat(struct device_node *np, + const char *prop_name, int index) +{ + struct of_phandle_args sup_args; + + if (strcmp(prop_name, "gpio") && strcmp(prop_name, "gpios")) + return NULL; + + /* + * Ignore node with gpio-hog property since its gpios are all provided + * by its parent. + */ + if (of_find_property(np, "gpio-hog", NULL)) + return NULL; + + if (of_parse_phandle_with_args(np, prop_name, "#gpio-cells", index, + &sup_args)) + return NULL; + + return sup_args.np; +} + static const struct supplier_bindings of_supplier_bindings[] = { { .parse_prop = parse_clocks, }, { .parse_prop = parse_interconnects, }, @@ -1296,6 +1318,7 @@ static const struct supplier_bindings of_supplier_bindings[] = { { .parse_prop = parse_pinctrl6, }, { .parse_prop = parse_pinctrl7, }, { .parse_prop = parse_pinctrl8, }, + { .parse_prop = parse_gpio_compat, }, { .parse_prop = parse_regulators, }, { .parse_prop = parse_gpio, }, { .parse_prop = parse_gpios, }, From patchwork Thu Jan 21 22:57:12 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saravana Kannan X-Patchwork-Id: 368033 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-26.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F0BFC433E0 for ; Thu, 21 Jan 2021 22:59:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C8F8523A03 for ; Thu, 21 Jan 2021 22:59:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727165AbhAUW7P (ORCPT ); Thu, 21 Jan 2021 17:59:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727073AbhAUW6t (ORCPT ); Thu, 21 Jan 2021 17:58:49 -0500 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25534C06178B for ; Thu, 21 Jan 2021 14:57:21 -0800 (PST) Received: by mail-yb1-xb49.google.com with SMTP id p80so3673905ybg.10 for ; Thu, 21 Jan 2021 14:57:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:in-reply-to:message-id:mime-version:references:subject :from:to:cc; bh=uK0Guj4THP5+g44Z1zImR7+l85HfUzHMOtHW5TTbFrQ=; b=ImsE1yIWnsaLWJKqkKF6DHLyG4Jfq9a8VZaWAtFYT5/ADnPXhERzP1ZWXSFdsvDIDD EuHN6GEGCtOpkwE9UYUFBJUYv7S++PFMoMcUjMNu+zv6BPbShHbfo+/Hbtf7ZothLc57 TlsHjBXz7qc8X9ugUrxMCKCQAJi8q30LOuPfn7T4SOgTa9bEUuFALFvycM/5XteYnO0p W5R7fzwIewBeXDQzuwGiqboXlgy3cFEibVvuWrFzkx308XTVrK3HijFfsQ6IcnD0QxrY gSsINIMbyPfnooS281kGwFZo96F79RBV8twjIcXpc/Ewj0Oear7t/jSdS3G6VgPZP7yR 8ZfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=uK0Guj4THP5+g44Z1zImR7+l85HfUzHMOtHW5TTbFrQ=; b=I9cxYrvWse5yxf8ODkVyHagwaeulWr8HXDhATvUWJ0Y02gk7UGBAe30w7sjzDmeboR PyuW76l+2Y5KEVLiCgh2LH2kJl18HdyYWu1u2wURSqLIFA2oPOsqgX7woXTSLZcccinZ i0jjyy2BdGPvSRXmtdG+Ib+9k9hOR7tiEC34nS6sHEXhees3d018uxZ6kNitSBeH3utt Cgy5GnqgazYd/MAbdxcaVSrTY5kP//Ugsk6Z2ZW0/mysrJT3+6r6lM/s7lllcDEMLrdE 89tIjMpogfO724+m0w/u2cJ5PeUV/Fg5nb0AA49077kHh8z8E0gKzEn9qYwYK4hOcJpd 7iiA== X-Gm-Message-State: AOAM533iaooChvGpZNFh8bIkbUID709VgEID+9WtFZhLgrC9uOuQ/tzl bMXKAEEikS6A6ltr6DXJiF3bZQQJnFSZ4rw= X-Google-Smtp-Source: ABdhPJwFPya6ZpnojdN9+DfUQ2rdg/34vXkXUzMjpHddMGECP5xV2BbOs91bcILedlNvkfi3tEmbyaqkd6sPwjI= Sender: "saravanak via sendgmr" X-Received: from saravanak.san.corp.google.com ([2620:15c:2d:3:7220:84ff:fe09:fedc]) (user=saravanak job=sendgmr) by 2002:a25:7c46:: with SMTP id x67mr2450968ybc.464.1611269840361; Thu, 21 Jan 2021 14:57:20 -0800 (PST) Date: Thu, 21 Jan 2021 14:57:12 -0800 In-Reply-To: <20210121225712.1118239-1-saravanak@google.com> Message-Id: <20210121225712.1118239-3-saravanak@google.com> Mime-Version: 1.0 References: <20210121225712.1118239-1-saravanak@google.com> X-Mailer: git-send-email 2.30.0.280.ga3ce27912f-goog Subject: [PATCH v2 2/2] of: property: Add fw_devlink support for interrupts From: Saravana Kannan To: Rob Herring , Frank Rowand , Greg Kroah-Hartman Cc: Saravana Kannan , linux-tegra , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Linus Walleij , Bartosz Golaszewski , Geert Uytterhoeven , Jon Hunter , Marc Zyngier , Kevin Hilman , kernel-team@android.com, Rob Herring , Thierry Reding Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org This allows fw_devlink to create device links between consumers of an interrupt and the supplier of the interrupt. Cc: Marc Zyngier Cc: Kevin Hilman Cc: Greg Kroah-Hartman Reviewed-by: Rob Herring Reviewed-by: Thierry Reding Reviewed-by: Linus Walleij Signed-off-by: Saravana Kannan Reported-by: Marek Szyprowski Tested-by: Marek Szyprowski --- drivers/of/property.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/of/property.c b/drivers/of/property.c index b2ea1951d937..6287c6d60bb7 100644 --- a/drivers/of/property.c +++ b/drivers/of/property.c @@ -24,6 +24,7 @@ #include #include #include +#include #include #include @@ -1293,6 +1294,15 @@ static struct device_node *parse_gpio_compat(struct device_node *np, return sup_args.np; } +static struct device_node *parse_interrupts(struct device_node *np, + const char *prop_name, int index) +{ + if (strcmp(prop_name, "interrupts") || index) + return NULL; + + return of_irq_find_parent(np); +} + static const struct supplier_bindings of_supplier_bindings[] = { { .parse_prop = parse_clocks, }, { .parse_prop = parse_interconnects, }, @@ -1319,6 +1329,7 @@ static const struct supplier_bindings of_supplier_bindings[] = { { .parse_prop = parse_pinctrl7, }, { .parse_prop = parse_pinctrl8, }, { .parse_prop = parse_gpio_compat, }, + { .parse_prop = parse_interrupts, }, { .parse_prop = parse_regulators, }, { .parse_prop = parse_gpio, }, { .parse_prop = parse_gpios, },