From patchwork Wed Jan 27 09:10:00 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 371490 Delivered-To: patch@linaro.org Received: by 2002:a02:a60d:0:0:0:0:0 with SMTP id c13csp77968jam; Wed, 27 Jan 2021 01:16:37 -0800 (PST) X-Google-Smtp-Source: ABdhPJzMGT9ZlY/58OLPnUjpIqzwHhuUR1xrrIlRfJe/suaZV0jmECsHUfJHsrMSdagVb5zBfzDK X-Received: by 2002:a05:6402:34d2:: with SMTP id w18mr8520169edc.102.1611738996962; Wed, 27 Jan 2021 01:16:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611738996; cv=none; d=google.com; s=arc-20160816; b=L9q44oH43LgrkbDOO8GOJHT/nVSnq93KRf7dCjVLUL6s+g2jPfNSV70YvYo4HBnJ2y 5sTGxB+U5Jct15HNK1pXsaHrMqd0bssUyGFgz6IbTm4lD/o0GWlCPdyJUMHPTTf8tkNR DMUNuyioCZCu1ggONAdU2Wu1SZ54IvUGFWwwvXpix6sFV3Nx1IrcgumG01Y0eORbxJB6 zPxIYJnPXU4AEhlc3RMT+X/Op7Aug5WXYyYPiX6lIubieVV3Xixb1iKh/fIhCEofBsrJ V9n3POPoIBHHbvz085Dl+vinPIPH9qYGkTlq/ijlltR8Lk/o6z/X/rZbCaTEnSXaEhbY TC/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=rRKTArZOg1KrGjFi8d6fGv/HZF1EOkxq/275M+KtPoM=; b=nS8wxfa9kUvR+e8KotHPOSJ6f4ZkwNKdFGdnJq7bIxCAcactPUFl/rbGdGTKRa7rtq MPt7NPHY6C0xOEb8mafW4LCf8RY5xgqBvz/Ldk8vElXaIIxbRTI0RnXMApqW4qrT2FDn av9oAgxf+hoDkNO8B4V/YvpfJbe/DxQ3F97+FggQEXppCqbe+oDAV7Ac99KTi+GSMLU8 XPCfCpWLWA+0O+fe4h4AxJZnY371NHfn8f537Sl6ahqvefibECsmp4TwIZxMsAiqLjYT y6nXtddk4mbr4xAqUoHCoso/H2JwsldEJZ2Q9+CWHRP0ctZbHgreBXPJ3t6ppymoX69k JP6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Uwi3vAvN; spf=pass (google.com: domain of linux-pm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id zd10si596467ejb.77.2021.01.27.01.16.36; Wed, 27 Jan 2021 01:16:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-pm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Uwi3vAvN; spf=pass (google.com: domain of linux-pm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234682AbhA0JQK (ORCPT + 7 others); Wed, 27 Jan 2021 04:16:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231668AbhA0JKr (ORCPT ); Wed, 27 Jan 2021 04:10:47 -0500 Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EAA17C061786 for ; Wed, 27 Jan 2021 01:10:05 -0800 (PST) Received: by mail-pf1-x432.google.com with SMTP id w14so801857pfi.2 for ; Wed, 27 Jan 2021 01:10:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rRKTArZOg1KrGjFi8d6fGv/HZF1EOkxq/275M+KtPoM=; b=Uwi3vAvNi1s+fF28WE+kMRQKlLALPib/vLCh98PitSRYo0RLK7BJNXcZJY8kJfdfCh QjPJy/jOQUcOTSfmLC6YooQySA/r8sREjF1KpI3tE578WpmdEf8+mpMrlWzPcWZEMQlw ptgUiPaZ1OQ3Pv9jjp/E5Gl3S1o7exI3S8p/HVlwxOPrCgS9qCuCrAWZ3TLLjKL3oScy h1Sb8WbTzWSzfIv0X6HOXnjoB6I6Btf1Pw24B7aUgx60k/1+jxsPK9luftsez9AZyVhm JM3bhBiTpL1BWmN1LpNlu8Ribeqp5zezKYgK26eKERrW5NIWZ1OwT6vtgwmOWZxlmERM HtcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rRKTArZOg1KrGjFi8d6fGv/HZF1EOkxq/275M+KtPoM=; b=cjM7oAKynvh56DxsQfQcJdpHW+0SWy0CooL2FTEEKH2AADftt0+TlmiCc0g8ZAX3pQ cSWN4xzeII9yQ/Kc4YQbv0nKywgutqAOu6D+Erpaa1w8c6ZarWetbcLKD0vX/pGWqOHX SWws0v1DOQmeTwITZlsIXKeq8Lp4ddWMK66YtgqTP622vwQwmc1oUnpgBunVJFjevMeC 5JViGVcuvI/UU7LmLN4G37OkchKMrIIIi7lPAhhuaEGvbmg4JvnNd0EfwplVCWlKqVXU Caq8/cdcxZtrU35JA+D1sVzMg+yaFb+pGMeGFoxHiCp6MBKYRjQdrcFhetkF8k/oMYWX T0FA== X-Gm-Message-State: AOAM532XJ3idSudbrRSZVufpJ/jsRVA1yDtcXs9X9C4PfrJp0PUPW9bW qZuibTODIfc+S5rCfRvz32I9Bg== X-Received: by 2002:a62:144c:0:b029:1c0:d62d:e16e with SMTP id 73-20020a62144c0000b02901c0d62de16emr9544172pfu.25.1611738605363; Wed, 27 Jan 2021 01:10:05 -0800 (PST) Received: from localhost ([122.172.59.240]) by smtp.gmail.com with ESMTPSA id p64sm1574652pfb.201.2021.01.27.01.10.04 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Jan 2021 01:10:04 -0800 (PST) From: Viresh Kumar To: Dmitry Osipenko , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Thierry Reding , Jonathan Hunter Cc: Viresh Kumar , linux-pm@vger.kernel.org, Vincent Guittot , Rafael Wysocki , Stephen Boyd , Nishanth Menon , linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH V2 11/13] devfreq: tegra30: Migrate to dev_pm_opp_set_opp() Date: Wed, 27 Jan 2021 14:40:00 +0530 Message-Id: X-Mailer: git-send-email 2.25.0.rc1.19.g042ed3e048af In-Reply-To: <3345fd49f7987d022f4f61edb6c44f230f7354c4.1611227342.git.viresh.kumar@linaro.org> References: <3345fd49f7987d022f4f61edb6c44f230f7354c4.1611227342.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org dev_pm_opp_set_bw() is getting removed and dev_pm_opp_set_opp() should be used instead. Migrate to the new API. We don't want the OPP core to manage the clk for this driver, migrate to dev_pm_opp_of_add_table_noclk() to make sure dev_pm_opp_set_opp() doesn't have any side effects. Signed-off-by: Viresh Kumar --- Dmitry, This is based over the patches sent here: https://lore.kernel.org/lkml/6c2160ff30a8f421563793020264cf9f533f293c.1611738228.git.viresh.kumar@linaro.org/ This should fix the problem you mentioned earlier. Will push this for linux-next unless you have any issues with it. drivers/devfreq/tegra30-devfreq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.25.0.rc1.19.g042ed3e048af Acked-by: Chanwoo Choi Tested-by: Dmitry Osipenko diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c index 117cad7968ab..31f7dec5990b 100644 --- a/drivers/devfreq/tegra30-devfreq.c +++ b/drivers/devfreq/tegra30-devfreq.c @@ -647,7 +647,7 @@ static int tegra_devfreq_target(struct device *dev, unsigned long *freq, return PTR_ERR(opp); } - ret = dev_pm_opp_set_bw(dev, opp); + ret = dev_pm_opp_set_opp(dev, opp); dev_pm_opp_put(opp); return ret; @@ -849,7 +849,7 @@ static int tegra_devfreq_probe(struct platform_device *pdev) return err; } - err = dev_pm_opp_of_add_table(&pdev->dev); + err = dev_pm_opp_of_add_table_noclk(&pdev->dev); if (err) { dev_err(&pdev->dev, "Failed to add OPP table: %d\n", err); goto put_hw;