From patchwork Thu Jan 28 11:18:42 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hermann.Lauer@uni-heidelberg.de X-Patchwork-Id: 372765 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFD56C433DB for ; Thu, 28 Jan 2021 11:19:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6A0BD64DDB for ; Thu, 28 Jan 2021 11:19:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229831AbhA1LTZ (ORCPT ); Thu, 28 Jan 2021 06:19:25 -0500 Received: from relay2.uni-heidelberg.de ([129.206.119.212]:58996 "EHLO relay2.uni-heidelberg.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229774AbhA1LTY (ORCPT ); Thu, 28 Jan 2021 06:19:24 -0500 X-IPAS-Result: A2D1AwCNnBJg/1BqzoFiHAEBAQEBAQcBARIBAQQEAQFAgU+DDGtlg3pGriMBAQEBAQEBAQEJLAECBAEBhEqBegIlOBMCAwEBAQMCAwEBAQEGAQEBAQEGBIZfhXQGI1YQJQImAgIUKDSGLbUTgTKJIoEtgQ4qixuCSYIbhGiEBVYwgkw0giwEgkeBDoEDgh2PKgkXpmGCBgeeXwINIpMdj2eRX4Vlnm6BbYF6Mz6DOFAZDZxrQzA3AgYKAQEDCVkBAYh0gkYBAQ X-IronPort-Anti-Spam-Filtered: true Received: from lemon.iwr.uni-heidelberg.de ([129.206.106.80]) by relay2.uni-heidelberg.de with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 28 Jan 2021 12:18:43 +0100 Received: from hlauer by lemon.iwr.uni-heidelberg.de with local (Exim 4.92) (envelope-from ) id 1l55Jy-00037W-KT; Thu, 28 Jan 2021 12:18:42 +0100 Date: Thu, 28 Jan 2021 12:18:42 +0100 From: Hermann.Lauer@uni-heidelberg.de To: linux-arm-kernel@lists.infradead.org Cc: mripard@kernel.org, wens@csie.org, jernej.skrabec@siol.net, robh+dt@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4] ARM: dts: sun7i: a20: bananapro: Fix ethernet phy-mode Message-ID: <20210128111842.GA11919@lemon.iwr.uni-heidelberg.de> References: <20210121170836.GA4948@lemon.iwr.uni-heidelberg.de> <20210128094040.GD11559@lemon.iwr.uni-heidelberg.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210128094040.GD11559@lemon.iwr.uni-heidelberg.de> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org BPi Pro needs TX and RX delay for Gbit to work reliable and avoid high packet loss rates. The realtek phy driver overrides the settings of the pull ups for the delays, so fix this for BananaPro. Fix the phy-mode description to correctly reflect this so that the implementation doesn't reconfigure the delays incorrectly. This happened with commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay config"). Fixes: 10662a33dcd9 ("ARM: dts: sun7i: Add dts file for Bananapro board") Signed-off-by: Hermann Lauer --- arch/arm/boot/dts/sun7i-a20-bananapro.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/sun7i-a20-bananapro.dts b/arch/arm/boot/dts/sun7i-a20-bananapro.dts --- a/arch/arm/boot/dts/sun7i-a20-bananapro.dts +++ b/arch/arm/boot/dts/sun7i-a20-bananapro.dts @@ -110,7 +110,7 @@ pinctrl-names = "default"; pinctrl-0 = <&gmac_rgmii_pins>; phy-handle = <&phy1>; - phy-mode = "rgmii"; + phy-mode = "rgmii-id"; phy-supply = <®_gmac_3v3>; status = "okay"; };