diff mbox

validation: inform when tests_global_init fails

Message ID 1418235251-46141-1-git-send-email-mike.holmes@linaro.org
State Rejected
Headers show

Commit Message

Mike Holmes Dec. 10, 2014, 6:14 p.m. UTC
Currently a test can fail tests_gloabl_init without indicating to the user.
This patch ensures that an indication is always given via stdout.

Signed-off-by: Mike Holmes <mike.holmes@linaro.org>
---
 test/validation/common/odp_cunit_common.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Ciprian Barbu Dec. 11, 2014, 2:15 p.m. UTC | #1
On Wed, Dec 10, 2014 at 8:14 PM, Mike Holmes <mike.holmes@linaro.org> wrote:
> Currently a test can fail tests_gloabl_init without indicating to the user.
> This patch ensures that an indication is always given via stdout.
>
> Signed-off-by: Mike Holmes <mike.holmes@linaro.org>

Reviewed-by: Ciprian Barbu <ciprian.barbu@linaro.org>

> ---
>  test/validation/common/odp_cunit_common.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/test/validation/common/odp_cunit_common.c b/test/validation/common/odp_cunit_common.c
> index 950bd18..1fc5725 100644
> --- a/test/validation/common/odp_cunit_common.c
> +++ b/test/validation/common/odp_cunit_common.c
> @@ -58,8 +58,10 @@ int main(void)
>         }
>
>         ret = tests_global_init();
> -       if (ret)
> +       if (ret) {
> +               printf("tests_global_init fail.\n");
>                 return ret;
> +       }
>
>         CU_set_error_action(CUEA_ABORT);
>
> --
> 2.1.0
>
>
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> http://lists.linaro.org/mailman/listinfo/lng-odp
diff mbox

Patch

diff --git a/test/validation/common/odp_cunit_common.c b/test/validation/common/odp_cunit_common.c
index 950bd18..1fc5725 100644
--- a/test/validation/common/odp_cunit_common.c
+++ b/test/validation/common/odp_cunit_common.c
@@ -58,8 +58,10 @@  int main(void)
 	}
 
 	ret = tests_global_init();
-	if (ret)
+	if (ret) {
+		printf("tests_global_init fail.\n");
 		return ret;
+	}
 
 	CU_set_error_action(CUEA_ABORT);