| Message ID | 59d56d7aea5dfb69bc7bda0c40529d3ef15efcab.1375964117.git.viresh.kumar@linaro.org |
|---|---|
| State | New |
| Headers | show |
On Thu, Aug 08, 2013 at 07:18:10PM +0530, Viresh Kumar wrote: > Lets use cpufreq_table_validate_and_show() instead of calling > cpufreq_frequency_table_cpuinfo() and cpufreq_frequency_table_get_attr(). > > Cc: Shawn Guo <shawn.guo@linaro.org> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> I'm not copied on the patch that introduces function cpufreq_table_validate_and_show(). So if it does the right/equivalent thing, for cpufreq-cpu0 and imx6q-cpufreq: Acked-by: Shawn Guo <shawn.guo@linaro.org>
On 12 August 2013 13:05, Shawn Guo <shawn.guo@linaro.org> wrote: > On Thu, Aug 08, 2013 at 07:18:10PM +0530, Viresh Kumar wrote: >> Lets use cpufreq_table_validate_and_show() instead of calling >> cpufreq_frequency_table_cpuinfo() and cpufreq_frequency_table_get_attr(). >> >> Cc: Shawn Guo <shawn.guo@linaro.org> >> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > > I'm not copied on the patch that introduces function > cpufreq_table_validate_and_show(). So if it does the right/equivalent > thing, for cpufreq-cpu0 and imx6q-cpufreq: You better check it :) https://lkml.org/lkml/2013/8/8/266 I wasn't probably following the right way for sending mails as I was expecting people to look at these patches over list.. In the next series with 44 patch I tried to fix this issue. And so cc'd people on cover-letter and the important patch they must check. > Acked-by: Shawn Guo <shawn.guo@linaro.org> Thanks.
diff --git a/drivers/cpufreq/cpufreq-cpu0.c b/drivers/cpufreq/cpufreq-cpu0.c index ad1fde2..65d70a3 100644 --- a/drivers/cpufreq/cpufreq-cpu0.c +++ b/drivers/cpufreq/cpufreq-cpu0.c @@ -128,7 +128,7 @@ static int cpu0_cpufreq_init(struct cpufreq_policy *policy) { int ret; - ret = cpufreq_frequency_table_cpuinfo(policy, freq_table); + ret = cpufreq_table_validate_and_show(policy, freq_table); if (ret) { pr_err("invalid frequency table: %d\n", ret); return ret; @@ -144,8 +144,6 @@ static int cpu0_cpufreq_init(struct cpufreq_policy *policy) */ cpumask_setall(policy->cpus); - cpufreq_frequency_table_get_attr(freq_table, policy->cpu); - return 0; }
Lets use cpufreq_table_validate_and_show() instead of calling cpufreq_frequency_table_cpuinfo() and cpufreq_frequency_table_get_attr(). Cc: Shawn Guo <shawn.guo@linaro.org> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- drivers/cpufreq/cpufreq-cpu0.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)