| Message ID | 1481021828-59826-38-git-send-email-heyi.guo@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
This looks fine style wise to me Reviewed-by: Graeme Gregory <graeme.gregory@linaro.org> On Tue, Dec 06, 2016 at 06:57:08PM +0800, Heyi Guo wrote: > D05 platform numa nodes distance: > > -------------- -------------- > |Node1--Node0|<------>|Node2--Node3| > -------------- -------------- > cluster0 cluster1 > > Each cluster has two nodes, we treat that the node0 > and node1 have the same distance to Node2 and node3, > on the other hand, the node2 and node3 have the same > distance to node0 and node1. > The default distance of Slit table is wrong, correct it. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Chenhui Sun <sunchenhui@huawei.com> > --- > Chips/Hisilicon/Hi1616/D05AcpiTables/D05Slit.aslc | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/Chips/Hisilicon/Hi1616/D05AcpiTables/D05Slit.aslc b/Chips/Hisilicon/Hi1616/D05AcpiTables/D05Slit.aslc > index ea93504..89cc4a9 100644 > --- a/Chips/Hisilicon/Hi1616/D05AcpiTables/D05Slit.aslc > +++ b/Chips/Hisilicon/Hi1616/D05AcpiTables/D05Slit.aslc > @@ -51,10 +51,10 @@ EFI_ACPI_6_0_SYSTEM_LOCALITY_INFORMATION_TABLE Slit = { > EFI_ACPI_SYSTEM_LOCALITIES_ENTRY_COUNT, > }, > { > - {{0x0A, 0x10, 0x20, 0x21}}, //Locality 0 > - {{0x10, 0x0A, 0x19, 0x20}}, //Locality 1 > - {{0x20, 0x19, 0x0A, 0x10}}, //Locality 2 > - {{0x21, 0x20, 0x10, 0x0A}}, //Locality 3 > + {{0x0A, 0x0F, 0x14, 0x14}}, //Locality 0 > + {{0x0F, 0x0A, 0x14, 0x14}}, //Locality 1 > + {{0x14, 0x14, 0x0A, 0x0F}}, //Locality 2 > + {{0x14, 0x14, 0x0F, 0x0A}}, //Locality 3 > }, > }; > > -- > 1.9.1 >
On 12/06/2016 06:57 PM, Heyi Guo wrote: > D05 platform numa nodes distance: > > -------------- -------------- > |Node1--Node0|<------>|Node2--Node3| > -------------- -------------- > cluster0 cluster1 > > Each cluster has two nodes, we treat that the node0 > and node1 have the same distance to Node2 and node3, > on the other hand, the node2 and node3 have the same > distance to node0 and node1. > The default distance of Slit table is wrong, correct it. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Chenhui Sun <sunchenhui@huawei.com> Reviewed-by: Hanjun Guo <hanjun.guo@linaro.org>
On 12/06/2016 06:57 PM, Heyi Guo wrote: > D05 platform numa nodes distance: > > -------------- -------------- > |Node1--Node0|<------>|Node2--Node3| > -------------- -------------- > cluster0 cluster1 > > Each cluster has two nodes, we treat that the node0 > and node1 have the same distance to Node2 and node3, > on the other hand, the node2 and node3 have the same > distance to node0 and node1. > The default distance of Slit table is wrong, correct it. By the way, the SRAT seems wrong, and I can see that you send a patch for that, should that be sent for merge? Thanks Hanjun
Hi Hanjun, Only rp-16.12-01-all branch is wrong, we fix it at the new branch. Thanks and Regards, Heyi 在 12/7/2016 5:21 PM, Hanjun Guo 写道: > On 12/06/2016 06:57 PM, Heyi Guo wrote: >> D05 platform numa nodes distance: >> >> -------------- -------------- >> |Node1--Node0|<------>|Node2--Node3| >> -------------- -------------- >> cluster0 cluster1 >> >> Each cluster has two nodes, we treat that the node0 >> and node1 have the same distance to Node2 and node3, >> on the other hand, the node2 and node3 have the same >> distance to node0 and node1. >> The default distance of Slit table is wrong, correct it. > > By the way, the SRAT seems wrong, and I can see that > you send a patch for that, should that be sent for merge? > > Thanks > Hanjun
On 12/07/2016 08:23 PM, Heyi Guo wrote: > Hi Hanjun, > > Only rp-16.12-01-all branch is wrong, we fix it at the new branch. Got it, thanks! Hanjun > > Thanks and Regards, > > Heyi > > > 在 12/7/2016 5:21 PM, Hanjun Guo 写道: >> On 12/06/2016 06:57 PM, Heyi Guo wrote: >>> D05 platform numa nodes distance: >>> >>> -------------- -------------- >>> |Node1--Node0|<------>|Node2--Node3| >>> -------------- -------------- >>> cluster0 cluster1 >>> >>> Each cluster has two nodes, we treat that the node0 >>> and node1 have the same distance to Node2 and node3, >>> on the other hand, the node2 and node3 have the same >>> distance to node0 and node1. >>> The default distance of Slit table is wrong, correct it. >> >> By the way, the SRAT seems wrong, and I can see that >> you send a patch for that, should that be sent for merge? >> >> Thanks >> Hanjun >
diff --git a/Chips/Hisilicon/Hi1616/D05AcpiTables/D05Slit.aslc b/Chips/Hisilicon/Hi1616/D05AcpiTables/D05Slit.aslc index ea93504..89cc4a9 100644 --- a/Chips/Hisilicon/Hi1616/D05AcpiTables/D05Slit.aslc +++ b/Chips/Hisilicon/Hi1616/D05AcpiTables/D05Slit.aslc @@ -51,10 +51,10 @@ EFI_ACPI_6_0_SYSTEM_LOCALITY_INFORMATION_TABLE Slit = { EFI_ACPI_SYSTEM_LOCALITIES_ENTRY_COUNT, }, { - {{0x0A, 0x10, 0x20, 0x21}}, //Locality 0 - {{0x10, 0x0A, 0x19, 0x20}}, //Locality 1 - {{0x20, 0x19, 0x0A, 0x10}}, //Locality 2 - {{0x21, 0x20, 0x10, 0x0A}}, //Locality 3 + {{0x0A, 0x0F, 0x14, 0x14}}, //Locality 0 + {{0x0F, 0x0A, 0x14, 0x14}}, //Locality 1 + {{0x14, 0x14, 0x0A, 0x0F}}, //Locality 2 + {{0x14, 0x14, 0x0F, 0x0A}}, //Locality 3 }, };
D05 platform numa nodes distance: -------------- -------------- |Node1--Node0|<------>|Node2--Node3| -------------- -------------- cluster0 cluster1 Each cluster has two nodes, we treat that the node0 and node1 have the same distance to Node2 and node3, on the other hand, the node2 and node3 have the same distance to node0 and node1. The default distance of Slit table is wrong, correct it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Chenhui Sun <sunchenhui@huawei.com> --- Chips/Hisilicon/Hi1616/D05AcpiTables/D05Slit.aslc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)