| Message ID | 20170627153705.1378256-1-arnd@arndb.de |
|---|---|
| State | Accepted |
| Commit | 5d6a312e8f99f0a0bf793256c203fa17c97a15e1 |
| Headers | show |
On Tue, Jun 27, 2017 at 8:36 AM, Arnd Bergmann <arnd@arndb.de> wrote: > The only reference to the new functions is inside of an #ifdef, > which now causes a harmless warning when CONFIG_PM_SLEEP is not set: > > chrome/cros_ec_dev.c:478:12: error: 'ec_device_resume' defined but not used [-Werror=unused-function] > chrome/cros_ec_dev.c:469:12: error: 'ec_device_suspend' defined but not used [-Werror=unused-function] > > This marks the two functions as __maybe_unused so they can get > silently dropped by the compiler. > > Fixes: 405c84308c43 ("platform/chrome: cros_ec_lightbar - Control of suspend/resume lightbar sequence") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Guenter Roeck <groeck@chromium.org> > --- > drivers/platform/chrome/cros_ec_dev.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/platform/chrome/cros_ec_dev.c b/drivers/platform/chrome/cros_ec_dev.c > index b9bf086f7569..cf6c4f0846b8 100644 > --- a/drivers/platform/chrome/cros_ec_dev.c > +++ b/drivers/platform/chrome/cros_ec_dev.c > @@ -466,7 +466,7 @@ static const struct platform_device_id cros_ec_id[] = { > }; > MODULE_DEVICE_TABLE(platform, cros_ec_id); > > -static int ec_device_suspend(struct device *dev) > +static __maybe_unused int ec_device_suspend(struct device *dev) > { > struct cros_ec_dev *ec = dev_get_drvdata(dev); > > @@ -475,7 +475,7 @@ static int ec_device_suspend(struct device *dev) > return 0; > } > > -static int ec_device_resume(struct device *dev) > +static __maybe_unused int ec_device_resume(struct device *dev) > { > struct cros_ec_dev *ec = dev_get_drvdata(dev); > > -- > 2.9.0 >
Hi Arnd, On Tue, Jun 27, 2017 at 05:36:36PM +0200, Arnd Bergmann wrote: > The only reference to the new functions is inside of an #ifdef, > which now causes a harmless warning when CONFIG_PM_SLEEP is not set: > > chrome/cros_ec_dev.c:478:12: error: 'ec_device_resume' defined but not used [-Werror=unused-function] > chrome/cros_ec_dev.c:469:12: error: 'ec_device_suspend' defined but not used [-Werror=unused-function] > > This marks the two functions as __maybe_unused so they can get > silently dropped by the compiler. > > Fixes: 405c84308c43 ("platform/chrome: cros_ec_lightbar - Control of suspend/resume lightbar sequence") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Good catch. Applied. Thanks! -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. bleung@google.com Chromium OS Project bleung@chromium.org
diff --git a/drivers/platform/chrome/cros_ec_dev.c b/drivers/platform/chrome/cros_ec_dev.c index b9bf086f7569..cf6c4f0846b8 100644 --- a/drivers/platform/chrome/cros_ec_dev.c +++ b/drivers/platform/chrome/cros_ec_dev.c @@ -466,7 +466,7 @@ static const struct platform_device_id cros_ec_id[] = { }; MODULE_DEVICE_TABLE(platform, cros_ec_id); -static int ec_device_suspend(struct device *dev) +static __maybe_unused int ec_device_suspend(struct device *dev) { struct cros_ec_dev *ec = dev_get_drvdata(dev); @@ -475,7 +475,7 @@ static int ec_device_suspend(struct device *dev) return 0; } -static int ec_device_resume(struct device *dev) +static __maybe_unused int ec_device_resume(struct device *dev) { struct cros_ec_dev *ec = dev_get_drvdata(dev);
The only reference to the new functions is inside of an #ifdef, which now causes a harmless warning when CONFIG_PM_SLEEP is not set: chrome/cros_ec_dev.c:478:12: error: 'ec_device_resume' defined but not used [-Werror=unused-function] chrome/cros_ec_dev.c:469:12: error: 'ec_device_suspend' defined but not used [-Werror=unused-function] This marks the two functions as __maybe_unused so they can get silently dropped by the compiler. Fixes: 405c84308c43 ("platform/chrome: cros_ec_lightbar - Control of suspend/resume lightbar sequence") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/platform/chrome/cros_ec_dev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.9.0