diff mbox series

f2fs: avoid using timespec

Message ID 20171019095252.688181-1-arnd@arndb.de
State Accepted
Commit 6bccfa19bb3ba31ebe9abc3ec95b27cc4667194e
Headers show
Series f2fs: avoid using timespec | expand

Commit Message

Arnd Bergmann Oct. 19, 2017, 9:52 a.m. UTC
All uses of timespec are deprecated, and this one is not particularly
useful, as the documented method for converting seconds to jiffies
is to multiply by 'HZ'.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
 fs/f2fs/f2fs.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

-- 
2.9.0

Comments

Chao Yu Oct. 22, 2017, 2:55 p.m. UTC | #1
On 2017/10/19 17:52, Arnd Bergmann wrote:
> All uses of timespec are deprecated, and this one is not particularly

> useful, as the documented method for converting seconds to jiffies

> is to multiply by 'HZ'.

> 

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>


Reviewed-by: Chao Yu <yuchao0@huawei.com>


Thanks,

> ---

>  fs/f2fs/f2fs.h | 3 +--

>  1 file changed, 1 insertion(+), 2 deletions(-)

> 

> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h

> index 4b4a72f392be..b9a4a5db426c 100644

> --- a/fs/f2fs/f2fs.h

> +++ b/fs/f2fs/f2fs.h

> @@ -1178,8 +1178,7 @@ static inline void f2fs_update_time(struct f2fs_sb_info *sbi, int type)

>  

>  static inline bool f2fs_time_over(struct f2fs_sb_info *sbi, int type)

>  {

> -	struct timespec ts = {sbi->interval_time[type], 0};

> -	unsigned long interval = timespec_to_jiffies(&ts);

> +	unsigned long interval = sbi->interval_time[type] * HZ;

>  

>  	return time_after(jiffies, sbi->last_time[type] + interval);

>  }

>
diff mbox series

Patch

diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index 4b4a72f392be..b9a4a5db426c 100644
--- a/fs/f2fs/f2fs.h
+++ b/fs/f2fs/f2fs.h
@@ -1178,8 +1178,7 @@  static inline void f2fs_update_time(struct f2fs_sb_info *sbi, int type)
 
 static inline bool f2fs_time_over(struct f2fs_sb_info *sbi, int type)
 {
-	struct timespec ts = {sbi->interval_time[type], 0};
-	unsigned long interval = timespec_to_jiffies(&ts);
+	unsigned long interval = sbi->interval_time[type] * HZ;
 
 	return time_after(jiffies, sbi->last_time[type] + interval);
 }