| Message ID | 20170505194745.3627137-83-arnd@arndb.de |
|---|---|
| State | Accepted |
| Commit | b617649468390713db1515ea79fc772d2eb897a8 |
| Headers | show |
| Series | build warnings and errors | expand |
On Fri, 2017-05-05 at 21:47 +0200, Arnd Bergmann wrote: > Commit c64ebe32d3fc90c52277257d6c9fa7d589877cc2 upstream. > > One of the last remaining failures in kernelci.org is for a gcc bug: > > drivers/net/ethernet/qlogic/qlge/qlge_main.c:4819:1: error: insn does not satisfy its constraints: > drivers/net/ethernet/qlogic/qlge/qlge_main.c:4819:1: internal compiler error: in extract_constrain_insn, at recog.c:2190 > > This is apparently broken in gcc-6 but fixed in gcc-7, and I cannot > reproduce the problem here. However, it is clear that ip27_defconfig > does not actually need this driver as the platform has only PCI-X but > not PCIe, and the qlge adapter in turn is PCIe-only. You could disable CONFIG_SFC here as well, since it only supports PCIe devices. Ben. > The driver was originally enabled in 2010 along with lots of other > drivers. > > Fixes: 59d302b342e5 ("MIPS: IP27: Make defconfig useful again.") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Cc: Ralf Baechle <ralf@linux-mips.org> > Cc: linux-mips@linux-mips.org > Cc: linux-kernel@vger.kernel.org > Patchwork: https://patchwork.linux-mips.org/patch/15197/ > Signed-off-by: James Hogan <james.hogan@imgtec.com> > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > arch/mips/configs/ip27_defconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/mips/configs/ip27_defconfig b/arch/mips/configs/ip27_defconfig > index 0e36abcd39cc..7446284dd7b3 100644 > --- a/arch/mips/configs/ip27_defconfig > +++ b/arch/mips/configs/ip27_defconfig > @@ -206,7 +206,6 @@ CONFIG_MLX4_EN=m > # CONFIG_MLX4_DEBUG is not set > CONFIG_TEHUTI=m > CONFIG_BNX2X=m > -CONFIG_QLGE=m > CONFIG_SFC=m > CONFIG_BE2NET=m > CONFIG_LIBERTAS_THINFIRM=m -- Ben Hutchings It is a miracle that curiosity survives formal education. - Albert Einstein
diff --git a/arch/mips/configs/ip27_defconfig b/arch/mips/configs/ip27_defconfig index 0e36abcd39cc..7446284dd7b3 100644 --- a/arch/mips/configs/ip27_defconfig +++ b/arch/mips/configs/ip27_defconfig @@ -206,7 +206,6 @@ CONFIG_MLX4_EN=m # CONFIG_MLX4_DEBUG is not set CONFIG_TEHUTI=m CONFIG_BNX2X=m -CONFIG_QLGE=m CONFIG_SFC=m CONFIG_BE2NET=m CONFIG_LIBERTAS_THINFIRM=m
Commit c64ebe32d3fc90c52277257d6c9fa7d589877cc2 upstream. One of the last remaining failures in kernelci.org is for a gcc bug: drivers/net/ethernet/qlogic/qlge/qlge_main.c:4819:1: error: insn does not satisfy its constraints: drivers/net/ethernet/qlogic/qlge/qlge_main.c:4819:1: internal compiler error: in extract_constrain_insn, at recog.c:2190 This is apparently broken in gcc-6 but fixed in gcc-7, and I cannot reproduce the problem here. However, it is clear that ip27_defconfig does not actually need this driver as the platform has only PCI-X but not PCIe, and the qlge adapter in turn is PCIe-only. The driver was originally enabled in 2010 along with lots of other drivers. Fixes: 59d302b342e5 ("MIPS: IP27: Make defconfig useful again.") Signed-off-by: Arnd Bergmann <arnd@arndb.de> Cc: Ralf Baechle <ralf@linux-mips.org> Cc: linux-mips@linux-mips.org Cc: linux-kernel@vger.kernel.org Patchwork: https://patchwork.linux-mips.org/patch/15197/ Signed-off-by: James Hogan <james.hogan@imgtec.com> Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- arch/mips/configs/ip27_defconfig | 1 - 1 file changed, 1 deletion(-) -- 2.9.0