| Message ID | 20180208191925.24269-1-leif.lindholm@linaro.org |
|---|---|
| State | Accepted |
| Commit | 4745a1efe5c52dce5570b9c1493098ced8032388 |
| Headers | show |
| Series | [edk2,1/2] BeagleBoardPkg: drop unused PcdCacheEnabled dependency | expand |
On 8 February 2018 at 19:19, Leif Lindholm <leif.lindholm@linaro.org> wrote: > Commit f72df138 got rid of the use of PcdCacheEnabled, but failed to > actually drop it as a dependency for BeagleBoardLib. > > Get rid of it, so the module will still build when the Pcd is _really_ > removed. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org> For the series: Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > --- > BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf b/BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf > index e004d6f10b..3b62f3cbf7 100644 > --- a/BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf > +++ b/BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf > @@ -44,9 +44,6 @@ [Sources.common] > BeagleBoardHelper.S | GCC > BeagleBoardHelper.asm | RVCT > > -[FeaturePcd] > - gEmbeddedTokenSpaceGuid.PcdCacheEnable > - > [FixedPcd] > gArmTokenSpaceGuid.PcdFdBaseAddress > gArmTokenSpaceGuid.PcdFdSize > -- > 2.11.0 > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
On Thu, Feb 08, 2018 at 07:22:33PM +0000, Ard Biesheuvel wrote: > On 8 February 2018 at 19:19, Leif Lindholm <leif.lindholm@linaro.org> wrote: > > Commit f72df138 got rid of the use of PcdCacheEnabled, but failed to > > actually drop it as a dependency for BeagleBoardLib. > > > > Get rid of it, so the module will still build when the Pcd is _really_ > > removed. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org> > > For the series: > Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> Thanks! Pushed as ce2818e418..6791175f05. > > --- > > BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf b/BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf > > index e004d6f10b..3b62f3cbf7 100644 > > --- a/BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf > > +++ b/BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf > > @@ -44,9 +44,6 @@ [Sources.common] > > BeagleBoardHelper.S | GCC > > BeagleBoardHelper.asm | RVCT > > > > -[FeaturePcd] > > - gEmbeddedTokenSpaceGuid.PcdCacheEnable > > - > > [FixedPcd] > > gArmTokenSpaceGuid.PcdFdBaseAddress > > gArmTokenSpaceGuid.PcdFdSize > > -- > > 2.11.0 > > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
diff --git a/BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf b/BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf index e004d6f10b..3b62f3cbf7 100644 --- a/BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf +++ b/BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf @@ -44,9 +44,6 @@ [Sources.common] BeagleBoardHelper.S | GCC BeagleBoardHelper.asm | RVCT -[FeaturePcd] - gEmbeddedTokenSpaceGuid.PcdCacheEnable - [FixedPcd] gArmTokenSpaceGuid.PcdFdBaseAddress gArmTokenSpaceGuid.PcdFdSize
Commit f72df138 got rid of the use of PcdCacheEnabled, but failed to actually drop it as a dependency for BeagleBoardLib. Get rid of it, so the module will still build when the Pcd is _really_ removed. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org> --- BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf | 3 --- 1 file changed, 3 deletions(-) -- 2.11.0 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel