diff mbox series

[v2,05/27] fpu/softfloat: Move softfloat-specialize.h below FloatParts definition

Message ID 20180512004311.9299-6-richard.henderson@linaro.org
State New
Headers show
Series softfloat patch roundup | expand

Commit Message

Richard Henderson May 12, 2018, 12:42 a.m. UTC
We want to be able to specialize on the canonical representation.

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

---
 fpu/softfloat.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

-- 
2.17.0

Comments

Peter Maydell May 14, 2018, 10:23 a.m. UTC | #1
On 12 May 2018 at 01:42, Richard Henderson <richard.henderson@linaro.org> wrote:
> We want to be able to specialize on the canonical representation.

>

> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

> ---

>  fpu/softfloat.c | 20 ++++++++++----------

>  1 file changed, 10 insertions(+), 10 deletions(-)

>

> diff --git a/fpu/softfloat.c b/fpu/softfloat.c

> index bc0f52fa54..353893aaea 100644

> --- a/fpu/softfloat.c

> +++ b/fpu/softfloat.c

> @@ -95,16 +95,6 @@ this code that are retained.

>  *----------------------------------------------------------------------------*/

>  #include "fpu/softfloat-macros.h"

>

> -/*----------------------------------------------------------------------------

> -| Functions and definitions to determine:  (1) whether tininess for underflow

> -| is detected before or after rounding by default, (2) what (if anything)

> -| happens when exceptions are raised, (3) how signaling NaNs are distinguished

> -| from quiet NaNs, (4) the default generated quiet NaNs, and (5) how NaNs

> -| are propagated from function inputs to output.  These details are target-

> -| specific.

> -*----------------------------------------------------------------------------*/

> -#include "softfloat-specialize.h"

> -

>  /*----------------------------------------------------------------------------

>  | Returns the fraction bits of the half-precision floating-point value `a'.

>  *----------------------------------------------------------------------------*/

> @@ -247,6 +237,16 @@ typedef struct {

>      uint64_t roundeven_mask;

>  } FloatFmt;

>

> +/*----------------------------------------------------------------------------

> +| Functions and definitions to determine:  (1) whether tininess for underflow

> +| is detected before or after rounding by default, (2) what (if anything)

> +| happens when exceptions are raised, (3) how signaling NaNs are distinguished

> +| from quiet NaNs, (4) the default generated quiet NaNs, and (5) how NaNs

> +| are propagated from function inputs to output.  These details are target-

> +| specific.

> +*----------------------------------------------------------------------------*/

> +#include "softfloat-specialize.h"

> +

>  /* Expand fields based on the size of exponent and fraction */

>  #define FLOAT_PARAMS(E, F)                                           \

>      .exp_size       = E,                                             \

> --

> 2.17.0

>

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>


thanks
-- PMM
diff mbox series

Patch

diff --git a/fpu/softfloat.c b/fpu/softfloat.c
index bc0f52fa54..353893aaea 100644
--- a/fpu/softfloat.c
+++ b/fpu/softfloat.c
@@ -95,16 +95,6 @@  this code that are retained.
 *----------------------------------------------------------------------------*/
 #include "fpu/softfloat-macros.h"
 
-/*----------------------------------------------------------------------------
-| Functions and definitions to determine:  (1) whether tininess for underflow
-| is detected before or after rounding by default, (2) what (if anything)
-| happens when exceptions are raised, (3) how signaling NaNs are distinguished
-| from quiet NaNs, (4) the default generated quiet NaNs, and (5) how NaNs
-| are propagated from function inputs to output.  These details are target-
-| specific.
-*----------------------------------------------------------------------------*/
-#include "softfloat-specialize.h"
-
 /*----------------------------------------------------------------------------
 | Returns the fraction bits of the half-precision floating-point value `a'.
 *----------------------------------------------------------------------------*/
@@ -247,6 +237,16 @@  typedef struct {
     uint64_t roundeven_mask;
 } FloatFmt;
 
+/*----------------------------------------------------------------------------
+| Functions and definitions to determine:  (1) whether tininess for underflow
+| is detected before or after rounding by default, (2) what (if anything)
+| happens when exceptions are raised, (3) how signaling NaNs are distinguished
+| from quiet NaNs, (4) the default generated quiet NaNs, and (5) how NaNs
+| are propagated from function inputs to output.  These details are target-
+| specific.
+*----------------------------------------------------------------------------*/
+#include "softfloat-specialize.h"
+
 /* Expand fields based on the size of exponent and fraction */
 #define FLOAT_PARAMS(E, F)                                           \
     .exp_size       = E,                                             \